AuroraMiddleware/skia2
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
8455893840
skia2/tests/sksl/errors/OverflowIntLiteral.glsl

13 lines
316 B
Plaintext
Raw Normal View History

Add unit tests for overflowing int and uint literal limits. At present, we do not report any error; the values wrap silently. Change-Id: I8c435cfdd81f6c2e5fd87e9c39c708138bf4ec82 Bug: skia:10932 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/333676 Auto-Submit: John Stiles <johnstiles@google.com> Commit-Queue: Ethan Nicholas <ethannicholas@google.com> Reviewed-by: Ethan Nicholas <ethannicholas@google.com>
2020-11-10 19:17:42 +00:00
out vec4 sk_FragColor;
int intMin = -2147483648;
Handle values above int32 safely during IR generation. Previously, SKSL_INT was limited to an int32_t, so we couldn't differentiate between -1 and 4294967295. We could paper over the difference in some cases by relying on the expression's type, but this was imperfect and left us unable to differentiate between an overflow and valid results. SKSL_INT is now an int64_t; the code has been updated to fix bugs that shook out as a result of the change. This isn't a complete solution for overflow handling. There are still lots of obvious places for improvement--e.g. constant folding can easily overflow, and statements like `byte x = 1000;` are still happily accepted. Change-Id: I30d1f56b6f264543f3aa83046f43c2eb56d5fce4 Bug: skia:10932 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/345173 Commit-Queue: John Stiles <johnstiles@google.com> Reviewed-by: Brian Osman <brianosman@google.com> Auto-Submit: John Stiles <johnstiles@google.com>
2020-12-29 14:47:20 +00:00
int intMinMinusOne = -2147483649;
Add unit tests for overflowing int and uint literal limits. At present, we do not report any error; the values wrap silently. Change-Id: I8c435cfdd81f6c2e5fd87e9c39c708138bf4ec82 Bug: skia:10932 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/333676 Auto-Submit: John Stiles <johnstiles@google.com> Commit-Queue: Ethan Nicholas <ethannicholas@google.com> Reviewed-by: Ethan Nicholas <ethannicholas@google.com>
2020-11-10 19:17:42 +00:00
int intMax = 2147483647;
Handle values above int32 safely during IR generation. Previously, SKSL_INT was limited to an int32_t, so we couldn't differentiate between -1 and 4294967295. We could paper over the difference in some cases by relying on the expression's type, but this was imperfect and left us unable to differentiate between an overflow and valid results. SKSL_INT is now an int64_t; the code has been updated to fix bugs that shook out as a result of the change. This isn't a complete solution for overflow handling. There are still lots of obvious places for improvement--e.g. constant folding can easily overflow, and statements like `byte x = 1000;` are still happily accepted. Change-Id: I30d1f56b6f264543f3aa83046f43c2eb56d5fce4 Bug: skia:10932 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/345173 Commit-Queue: John Stiles <johnstiles@google.com> Reviewed-by: Brian Osman <brianosman@google.com> Auto-Submit: John Stiles <johnstiles@google.com>
2020-12-29 14:47:20 +00:00
int intMaxPlusOne = 2147483648;
Add unit tests for overflowing int and uint literal limits. At present, we do not report any error; the values wrap silently. Change-Id: I8c435cfdd81f6c2e5fd87e9c39c708138bf4ec82 Bug: skia:10932 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/333676 Auto-Submit: John Stiles <johnstiles@google.com> Commit-Queue: Ethan Nicholas <ethannicholas@google.com> Reviewed-by: Ethan Nicholas <ethannicholas@google.com>
2020-11-10 19:17:42 +00:00
void main() {
sk_FragColor.x = float(intMin);
sk_FragColor.x = float(intMax);
sk_FragColor.x = float(intMinMinusOne);
sk_FragColor.x = float(intMaxPlusOne);
}
Reference in New Issue Copy Permalink