AuroraMiddleware/skia2
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
9ae860a9fe
skia2/gn/core.gni

590 lines
19 KiB
Plaintext
Raw Normal View History

gypi -> gni: core, effects, android framework defines BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4023 Change-Id: I29a26c1716a319156a34a64999756ed7dba1e603 Reviewed-on: https://skia-review.googlesource.com/4023 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
2016-10-26 21:19:03 +00:00
# Copyright 2016 Google Inc.
#
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
# Things are easiest for everyone if these source paths are absolute.
_src = get_path_info("../src", "abspath")
_include = get_path_info("../include", "abspath")
GN: split out skia_*_public from skia_*_sources `gn check` passes. We will work towards removing `check_includes = false`. Change-Id: I0ab396fadaf31a166921bdea334b2cfedca23dcd Reviewed-on: https://skia-review.googlesource.com/c/skia/+/195363 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Hal Canary <halcanary@google.com>
2019-02-26 16:54:25 +00:00
skia_core_public = [
"$_include/core/SkAnnotation.h",
"$_include/core/SkBBHFactory.h",
"$_include/core/SkBitmap.h",
"$_include/core/SkBlendMode.h",
"$_include/core/SkBlurTypes.h",
"$_include/core/SkCanvas.h",
"$_include/core/SkCanvasVirtualEnforcer.h",
"$_include/core/SkClipOp.h",
"$_include/core/SkColor.h",
"$_include/core/SkColorFilter.h",
"$_include/core/SkColorPriv.h",
"$_include/core/SkColorSpace.h",
"$_include/core/SkContourMeasure.h",
"$_include/core/SkCoverageMode.h",
"$_include/core/SkCubicMap.h",
"$_include/core/SkData.h",
"$_include/core/SkDataTable.h",
Move SkDeferredDisplayList.h into include\core (take 2) Clients will need official access to this class for the compilation iterator. This CL also hides some of the cruft we don't want exposed. Bug: skia:9455 Change-Id: I696c058f1c409fb459229552fbbdd935ec112358 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/272643 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com>
2020-02-21 19:24:40 +00:00
"$_include/core/SkDeferredDisplayList.h",
GN: split out skia_*_public from skia_*_sources `gn check` passes. We will work towards removing `check_includes = false`. Change-Id: I0ab396fadaf31a166921bdea334b2cfedca23dcd Reviewed-on: https://skia-review.googlesource.com/c/skia/+/195363 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Hal Canary <halcanary@google.com>
2019-02-26 16:54:25 +00:00
"$_include/core/SkDeferredDisplayListRecorder.h",
"$_include/core/SkDocument.h",
"$_include/core/SkDrawLooper.h",
"$_include/core/SkDrawable.h",
"$_include/core/SkEncodedImageFormat.h",
"$_include/core/SkExecutor.h",
"$_include/core/SkFilterQuality.h",
"$_include/core/SkFlattenable.h",
"$_include/core/SkFont.h",
"$_include/core/SkFontArguments.h",
"$_include/core/SkFontLCDConfig.h",
"$_include/core/SkFontMetrics.h",
"$_include/core/SkFontMgr.h",
"$_include/core/SkFontParameters.h",
"$_include/core/SkFontStyle.h",
"$_include/core/SkFontTypes.h",
"$_include/core/SkGraphics.h",
"$_include/core/SkICC.h",
"$_include/core/SkImage.h",
"$_include/core/SkImageEncoder.h",
"$_include/core/SkImageFilter.h",
"$_include/core/SkImageGenerator.h",
"$_include/core/SkImageInfo.h",
Reland "Implement `dumpInfo` for .fp files." This is a reland of a1df23c8b71e193d2facfc3c6af79626f47d4666 Original change's description: > Implement `dumpInfo` for .fp files. > > Change-Id: I40f6c1a02e194f090e67a0e3f2d7d83cd2317efd > Bug: skia:8434 > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/309139 > Commit-Queue: Brian Osman <brianosman@google.com> > Reviewed-by: Brian Osman <brianosman@google.com> > Auto-Submit: John Stiles <johnstiles@google.com> Bug: skia:8434 Change-Id: If485635440b800f8a282c871a1c5f2801608d3c7 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/309660 Commit-Queue: John Stiles <johnstiles@google.com> Commit-Queue: Brian Osman <brianosman@google.com> Auto-Submit: John Stiles <johnstiles@google.com> Reviewed-by: Brian Osman <brianosman@google.com>
2020-08-12 13:56:50 +00:00
"$_include/core/SkM44.h",
GN: split out skia_*_public from skia_*_sources `gn check` passes. We will work towards removing `check_includes = false`. Change-Id: I0ab396fadaf31a166921bdea334b2cfedca23dcd Reviewed-on: https://skia-review.googlesource.com/c/skia/+/195363 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Hal Canary <halcanary@google.com>
2019-02-26 16:54:25 +00:00
"$_include/core/SkMallocPixelRef.h",
"$_include/core/SkMaskFilter.h",
"$_include/core/SkMath.h",
"$_include/core/SkMatrix.h",
"$_include/core/SkMatrix44.h",
"$_include/core/SkMilestone.h",
"$_include/core/SkOverdrawCanvas.h",
"$_include/core/SkPaint.h",
"$_include/core/SkPath.h",
add simple pathbuilder 88.26 ? makepath_arrays_reserve nonrendering 235.97 makepath_detach_reserve nonrendering 274.56 makepath_snapshot_reserve nonrendering 537.61 makepath_path_reserve nonrendering 472.98 makepath_detach_noreserve nonrendering 482.56 makepath_snapshot_noreserve nonrendering 750.83 ? makepath_path_noreserve nonrendering Bug: skia:9000 Change-Id: I346537e899b08946c5778042a021f464006b029c Reviewed-on: https://skia-review.googlesource.com/c/skia/+/209403 Commit-Queue: Mike Reed <reed@google.com> Reviewed-by: Chris Dalton <csmartdalton@google.com>
2020-06-24 01:06:28 +00:00
"$_include/core/SkPathBuilder.h",
GN: split out skia_*_public from skia_*_sources `gn check` passes. We will work towards removing `check_includes = false`. Change-Id: I0ab396fadaf31a166921bdea334b2cfedca23dcd Reviewed-on: https://skia-review.googlesource.com/c/skia/+/195363 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Hal Canary <halcanary@google.com>
2019-02-26 16:54:25 +00:00
"$_include/core/SkPathEffect.h",
"$_include/core/SkPathMeasure.h",
"$_include/core/SkPixelRef.h",
"$_include/core/SkPixmap.h",
"$_include/core/SkPngChunkReader.h",
"$_include/core/SkPoint.h",
"$_include/core/SkPoint3.h",
"$_include/core/SkPromiseImageTexture.h",
"$_include/core/SkRRect.h",
"$_include/core/SkRSXform.h",
"$_include/core/SkRWBuffer.h",
"$_include/core/SkRasterHandleAllocator.h",
"$_include/core/SkRect.h",
"$_include/core/SkRefCnt.h",
"$_include/core/SkRegion.h",
"$_include/core/SkScalar.h",
"$_include/core/SkSerialProcs.h",
"$_include/core/SkShader.h",
"$_include/core/SkSize.h",
"$_include/core/SkStream.h",
"$_include/core/SkString.h",
"$_include/core/SkStrokeRec.h",
"$_include/core/SkSurface.h",
"$_include/core/SkSurfaceCharacterization.h",
"$_include/core/SkSurfaceProps.h",
"$_include/core/SkSwizzle.h",
"$_include/core/SkTextBlob.h",
"$_include/core/SkTime.h",
"$_include/core/SkTraceMemoryDump.h",
"$_include/core/SkTypeface.h",
"$_include/core/SkTypes.h",
"$_include/core/SkUnPreMultiply.h",
"$_include/core/SkVertices.h",
"$_include/core/SkYUVAIndex.h",
A new way to specify YUVA planar data from SkCodec to SkImage_Lazy Tunnels through SkImageGenerator as well. The new SkCodec interface doesn't assume three 8 bit planes. New SkYUVASpec more clearly defines chroma subsampling and siting of the planes. The intent is to use this for other YUVA APIs as well, in particular SkImage factories in the future. In this change we convert to the SkYUVASpec to SkYUVASizeInfo and SkYUVAIndex[4] representation. But the intent is to use the SkYUVASpec representation throughout the pipeline once legacy APIs are removed. orientation GM is replicated to test a variety of chroma subsampling configs. Bug: skia:10632 Change-Id: I3fad35752b87cac16c51b24824331f2ae7d458d3 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/309658 Commit-Queue: Brian Salomon <bsalomon@google.com> Reviewed-by: Robert Phillips <robertphillips@google.com> Reviewed-by: Leon Scroggins <scroggo@google.com>
2020-08-24 13:18:16 +00:00
"$_include/core/SkYUVAInfo.h",
New helpers for SkYUVAInfo when used with pixmaps. SkYUVAPixmapInfo is a SkYUVAInfo with per-plane color types and row bytes. It describes a set of pixmaps that make up a planar image. Consolidates validity checks of the SkYUVAInfo with the color types and row bytes. It can provide SkImageInfos for each plane and also assist with configuring planes to share a common allocation. SkYUVAPixmaps is a collection of SkPixmaps that are valid for a SkYUVAInfo. It can either wrap existing SkPixmaps or allocate and own the memory. It consolidates validity checking of SkPixmaps with the SkYUVAInfo. Replaces sk_gpu_test::YUVAPixmaps. Minor tweaks to SkYUVAInfo naming, parameter order consistency, adds a hasAlpha() method. Bug: skia:10632 Change-Id: Ib0f48b8448fff22805fd0c04e07887d0b7338b76 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/312886 Commit-Queue: Brian Salomon <bsalomon@google.com> Reviewed-by: Robert Phillips <robertphillips@google.com> Reviewed-by: Leon Scroggins <scroggo@google.com>
2020-08-27 15:00:04 +00:00
"$_include/core/SkYUVAPixmaps.h",
"$_include/core/SkYUVASizeInfo.h",
GN: split out skia_*_public from skia_*_sources `gn check` passes. We will work towards removing `check_includes = false`. Change-Id: I0ab396fadaf31a166921bdea334b2cfedca23dcd Reviewed-on: https://skia-review.googlesource.com/c/skia/+/195363 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Hal Canary <halcanary@google.com>
2019-02-26 16:54:25 +00:00
]
gypi -> gni: core, effects, android framework defines BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4023 Change-Id: I29a26c1716a319156a34a64999756ed7dba1e603 Reviewed-on: https://skia-review.googlesource.com/4023 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
2016-10-26 21:19:03 +00:00
skia_core_sources = [
expand imageinfo in C api, start on colorspace After sk_imageinfo was initially created, we have added a colorspace to it, and that object is a smart-pointer. In response to that, this CL upgrades imageinfo to an "object" (like paint), so we can manage the ref-counting of its colorspace, and to allow for future changes/expansion (like paint). Bug: skia: Change-Id: I629ff99c0820fdbe83f062d9fb768c15cda68e18 Reviewed-on: https://skia-review.googlesource.com/157156 Commit-Queue: Mike Klein <mtklein@google.com> Reviewed-by: Brian Osman <brianosman@google.com> Reviewed-by: Mike Klein <mtklein@google.com>
2018-09-28 15:27:57 +00:00
"$_src/c/sk_imageinfo.cpp",
gypi -> gni: core, effects, android framework defines BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4023 Change-Id: I29a26c1716a319156a34a64999756ed7dba1e603 Reviewed-on: https://skia-review.googlesource.com/4023 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
2016-10-26 21:19:03 +00:00
"$_src/c/sk_paint.cpp",
"$_src/c/sk_surface.cpp",
"$_src/c/sk_types_priv.h",
"$_src/core/Sk4px.h",
"$_src/core/SkAAClip.cpp",
harmonize rewrite-includes and gn-format checks The CheckGeneratedFiles bot only required rewriting .gn files, while the presubmit wants both .gn and .gni files. It also appears that the #includes rewrite script runs on both the presubmit and CheckGeneratedFiles bots. These presubmits run on the CQ before landing right? If so, no need for them in the CheckGeneratedFIles bot at all. And of course, format .gni files. Change-Id: Icd4526d62f85088862ad93566cc9ace11dc3e33f Reviewed-on: https://skia-review.googlesource.com/c/skia/+/281505 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Mike Klein <mtklein@google.com>
2020-04-03 15:59:37 +00:00
"$_src/core/SkATrace.cpp",
"$_src/core/SkATrace.h",
gypi -> gni: core, effects, android framework defines BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4023 Change-Id: I29a26c1716a319156a34a64999756ed7dba1e603 Reviewed-on: https://skia-review.googlesource.com/4023 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
2016-10-26 21:19:03 +00:00
"$_src/core/SkAdvancedTypefaceMetrics.h",
"$_src/core/SkAlphaRuns.cpp",
harmonize rewrite-includes and gn-format checks The CheckGeneratedFiles bot only required rewriting .gn files, while the presubmit wants both .gn and .gni files. It also appears that the #includes rewrite script runs on both the presubmit and CheckGeneratedFiles bots. These presubmits run on the CQ before landing right? If so, no need for them in the CheckGeneratedFIles bot at all. And of course, format .gni files. Change-Id: Icd4526d62f85088862ad93566cc9ace11dc3e33f Reviewed-on: https://skia-review.googlesource.com/c/skia/+/281505 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Mike Klein <mtklein@google.com>
2020-04-03 15:59:37 +00:00
"$_src/core/SkAnalyticEdge.cpp",
"$_src/core/SkAnnotation.cpp",
gypi -> gni: core, effects, android framework defines BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4023 Change-Id: I29a26c1716a319156a34a64999756ed7dba1e603 Reviewed-on: https://skia-review.googlesource.com/4023 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
2016-10-26 21:19:03 +00:00
"$_src/core/SkAntiRun.h",
harmonize rewrite-includes and gn-format checks The CheckGeneratedFiles bot only required rewriting .gn files, while the presubmit wants both .gn and .gni files. It also appears that the #includes rewrite script runs on both the presubmit and CheckGeneratedFiles bots. These presubmits run on the CQ before landing right? If so, no need for them in the CheckGeneratedFIles bot at all. And of course, format .gni files. Change-Id: Icd4526d62f85088862ad93566cc9ace11dc3e33f Reviewed-on: https://skia-review.googlesource.com/c/skia/+/281505 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Mike Klein <mtklein@google.com>
2020-04-03 15:59:37 +00:00
"$_src/core/SkArenaAlloc.cpp",
"$_src/core/SkArenaAlloc.h",
"$_src/core/SkArenaAllocList.h",
gypi -> gni: core, effects, android framework defines BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4023 Change-Id: I29a26c1716a319156a34a64999756ed7dba1e603 Reviewed-on: https://skia-review.googlesource.com/4023 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
2016-10-26 21:19:03 +00:00
"$_src/core/SkAutoPixmapStorage.cpp",
harmonize rewrite-includes and gn-format checks The CheckGeneratedFiles bot only required rewriting .gn files, while the presubmit wants both .gn and .gni files. It also appears that the #includes rewrite script runs on both the presubmit and CheckGeneratedFiles bots. These presubmits run on the CQ before landing right? If so, no need for them in the CheckGeneratedFIles bot at all. And of course, format .gni files. Change-Id: Icd4526d62f85088862ad93566cc9ace11dc3e33f Reviewed-on: https://skia-review.googlesource.com/c/skia/+/281505 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Mike Klein <mtklein@google.com>
2020-04-03 15:59:37 +00:00
"$_src/core/SkAutoPixmapStorage.h",
gypi -> gni: core, effects, android framework defines BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4023 Change-Id: I29a26c1716a319156a34a64999756ed7dba1e603 Reviewed-on: https://skia-review.googlesource.com/4023 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
2016-10-26 21:19:03 +00:00
"$_src/core/SkBBHFactory.cpp",
"$_src/core/SkBitmap.cpp",
"$_src/core/SkBitmapCache.cpp",
"$_src/core/SkBitmapController.cpp",
"$_src/core/SkBitmapDevice.cpp",
Revert "Revert "move device headers to core"" This reverts commit d4bdee5f2c4c2c1387426d287f61645b5af8f8e0. BUG=skia: Change-Id: If5c316f8585881e43321412a2a38f97fd4aa5f02 Reviewed-on: https://skia-review.googlesource.com/7315 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Reed <reed@google.com>
2017-01-19 21:07:49 +00:00
"$_src/core/SkBitmapDevice.h",
gypi -> gni: core, effects, android framework defines BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4023 Change-Id: I29a26c1716a319156a34a64999756ed7dba1e603 Reviewed-on: https://skia-review.googlesource.com/4023 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
2016-10-26 21:19:03 +00:00
"$_src/core/SkBitmapProcState.cpp",
"$_src/core/SkBitmapProcState.h",
"$_src/core/SkBitmapProcState_matrixProcs.cpp",
move Coeff into blendmode Bug: skia: Change-Id: Ib4f3398b0cdc6b0f575f6db80d2ce0bf9666f077 Reviewed-on: https://skia-review.googlesource.com/18843 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Reed <reed@google.com>
2017-06-06 14:41:18 +00:00
"$_src/core/SkBlendMode.cpp",
gypi -> gni: core, effects, android framework defines BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4023 Change-Id: I29a26c1716a319156a34a64999756ed7dba1e603 Reviewed-on: https://skia-review.googlesource.com/4023 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
2016-10-26 21:19:03 +00:00
"$_src/core/SkBlitBWMaskTemplate.h",
move SkBlitRow.h out of public BUG=skia: Change-Id: I9a9c04fdb9fcfe50d57b28fa560a9b3d5499b699 Reviewed-on: https://skia-review.googlesource.com/6734 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Reed <reed@google.com>
2017-01-08 15:32:57 +00:00
"$_src/core/SkBlitRow.h",
gypi -> gni: core, effects, android framework defines BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4023 Change-Id: I29a26c1716a319156a34a64999756ed7dba1e603 Reviewed-on: https://skia-review.googlesource.com/4023 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
2016-10-26 21:19:03 +00:00
"$_src/core/SkBlitRow_D32.cpp",
"$_src/core/SkBlitter.cpp",
harmonize rewrite-includes and gn-format checks The CheckGeneratedFiles bot only required rewriting .gn files, while the presubmit wants both .gn and .gni files. It also appears that the #includes rewrite script runs on both the presubmit and CheckGeneratedFiles bots. These presubmits run on the CQ before landing right? If so, no need for them in the CheckGeneratedFIles bot at all. And of course, format .gni files. Change-Id: Icd4526d62f85088862ad93566cc9ace11dc3e33f Reviewed-on: https://skia-review.googlesource.com/c/skia/+/281505 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Mike Klein <mtklein@google.com>
2020-04-03 15:59:37 +00:00
"$_src/core/SkBlitter.h",
gypi -> gni: core, effects, android framework defines BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4023 Change-Id: I29a26c1716a319156a34a64999756ed7dba1e603 Reviewed-on: https://skia-review.googlesource.com/4023 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
2016-10-26 21:19:03 +00:00
"$_src/core/SkBlitter_A8.cpp",
"$_src/core/SkBlitter_ARGB32.cpp",
experiments to speed up drawing 32bit images into 565 New (legacy style) blitters only coded for shaders (and very restricted blendmodes) Bug: skia: See https://buganizer.corp.google.com/issues/64884885 Change-Id: Ie2546093bfe1e670a825dfd9542d252d53732c40 Reviewed-on: https://skia-review.googlesource.com/54103 Commit-Queue: Mike Reed <reed@google.com> Reviewed-by: Herb Derby <herb@google.com>
2017-10-05 20:04:41 +00:00
"$_src/core/SkBlitter_RGB565.cpp",
gypi -> gni: core, effects, android framework defines BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4023 Change-Id: I29a26c1716a319156a34a64999756ed7dba1e603 Reviewed-on: https://skia-review.googlesource.com/4023 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
2016-10-26 21:19:03 +00:00
"$_src/core/SkBlitter_Sprite.cpp",
harmonize rewrite-includes and gn-format checks The CheckGeneratedFiles bot only required rewriting .gn files, while the presubmit wants both .gn and .gni files. It also appears that the #includes rewrite script runs on both the presubmit and CheckGeneratedFiles bots. These presubmits run on the CQ before landing right? If so, no need for them in the CheckGeneratedFIles bot at all. And of course, format .gni files. Change-Id: Icd4526d62f85088862ad93566cc9ace11dc3e33f Reviewed-on: https://skia-review.googlesource.com/c/skia/+/281505 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Mike Klein <mtklein@google.com>
2020-04-03 15:59:37 +00:00
"$_src/core/SkBlurMF.cpp",
remove unused ConvertRadiusToSigma from SkBlurMaskFilter Bug: skia: Change-Id: I1726f22fc40ad61b1b0485bcda6d383614da1fdb Reviewed-on: https://skia-review.googlesource.com/113463 Commit-Queue: Mike Reed <reed@google.com> Reviewed-by: Mike Reed <reed@google.com>
2018-03-09 21:18:56 +00:00
"$_src/core/SkBlurMask.cpp",
"$_src/core/SkBlurMask.h",
gypi -> gni: core, effects, android framework defines BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4023 Change-Id: I29a26c1716a319156a34a64999756ed7dba1e603 Reviewed-on: https://skia-review.googlesource.com/4023 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
2016-10-26 21:19:03 +00:00
"$_src/core/SkBuffer.cpp",
"$_src/core/SkCachedData.cpp",
"$_src/core/SkCanvas.cpp",
update pipe for lattice and shadowrec - move some lattice routines into shared helper (SkCanvasPriv) Bug: skia: Change-Id: Ibbb80dd7461c7fd3082a0220604ab42cbb8815be Reviewed-on: https://skia-review.googlesource.com/90540 Reviewed-by: Florin Malita <fmalita@chromium.org> Reviewed-by: Mike Klein <mtklein@google.com> Commit-Queue: Mike Reed <reed@google.com>
2018-01-03 14:23:34 +00:00
"$_src/core/SkCanvasPriv.cpp",
gypi -> gni: core, effects, android framework defines BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4023 Change-Id: I29a26c1716a319156a34a64999756ed7dba1e603 Reviewed-on: https://skia-review.googlesource.com/4023 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
2016-10-26 21:19:03 +00:00
"$_src/core/SkCanvasPriv.h",
"$_src/core/SkClipStack.cpp",
Revert "Revert "make SkClipStack.h private (in src)"" This reverts commit 1c8e82b72bfeb1a02297688cf082c365b62705f7. Reason for revert: previous reason to revert fixed. relanding. Original change's description: > Revert "make SkClipStack.h private (in src)" > > This reverts commit 3efca0a2a8fc412a318199fa386c1375b55ee81e. > > Reason for revert: update caller in GraphicsContext.cpp > > Original change's description: > > make SkClipStack.h private (in src) > > > > BUG=skia: > > > > Change-Id: I05f1140fe483f4a92093cb9783c6e9f067420d30 > > Reviewed-on: https://skia-review.googlesource.com/8481 > > Reviewed-by: Florin Malita <fmalita@chromium.org> > > Commit-Queue: Mike Reed <reed@google.com> > > > > TBR=fmalita@chromium.org,reed@google.com,reviews@skia.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=skia: > > Change-Id: Iff1138d72ff2d1187d522487fe76ea293f706f60 > Reviewed-on: https://skia-review.googlesource.com/8501 > Commit-Queue: Mike Reed <reed@google.com> > Reviewed-by: Mike Reed <reed@google.com> > TBR=reviews@skia.org,fmalita@chromium.org,reed@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Change-Id: If7e54653c00a0c57ffa60b0c9f40dd0ffad2fe42 Reviewed-on: https://skia-review.googlesource.com/8522 Commit-Queue: Mike Reed <reed@google.com> Reviewed-by: Mike Reed <reed@google.com>
2017-02-15 19:15:55 +00:00
"$_src/core/SkClipStack.h",
use common intermediate device class for clipstack management BUG=skia:6214 Change-Id: I64b849ad7c8dafe423e24e6fccfb3f0c1d096ab0 Reviewed-on: https://skia-review.googlesource.com/8669 Commit-Queue: Mike Reed <reed@google.com> Reviewed-by: Florin Malita <fmalita@chromium.org>
2017-02-17 19:38:11 +00:00
"$_src/core/SkClipStackDevice.cpp",
"$_src/core/SkClipStackDevice.h",
gypi -> gni: core, effects, android framework defines BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4023 Change-Id: I29a26c1716a319156a34a64999756ed7dba1e603 Reviewed-on: https://skia-review.googlesource.com/4023 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
2016-10-26 21:19:03 +00:00
"$_src/core/SkColor.cpp",
"$_src/core/SkColorFilter.cpp",
change colormatrixfilter to be 0...1 for translate ... once I've updated callers of SkColorMatrix, that can be changed to 0...1 as well. Replacement for https://skia-review.googlesource.com/c/skia/+/209408 Bug: skia: 4872 Change-Id: Ieb0173e7af4c34f6a2c0b90787afb5387c216d68 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/209806 Commit-Queue: Mike Reed <reed@google.com> Reviewed-by: Mike Klein <mtklein@google.com>
2019-04-23 16:19:00 +00:00
"$_src/core/SkColorFilter_Matrix.cpp",
"$_src/core/SkColorFilter_Matrix.h",
gypi -> gni: core, effects, android framework defines BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4023 Change-Id: I29a26c1716a319156a34a64999756ed7dba1e603 Reviewed-on: https://skia-review.googlesource.com/4023 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
2016-10-26 21:19:03 +00:00
"$_src/core/SkColorSpace.cpp",
SkColorSpaceXformSteps Lots TODO. Change-Id: I95edb764b85a5140d432adb506c3b537869e6df4 Reviewed-on: https://skia-review.googlesource.com/129933 Commit-Queue: Mike Klein <mtklein@chromium.org> Reviewed-by: Brian Osman <brianosman@google.com> Auto-Submit: Mike Klein <mtklein@chromium.org>
2018-05-24 16:33:23 +00:00
"$_src/core/SkColorSpaceXformSteps.cpp",
Add SkImage::MakeRasterFromCompressed and make MakeFromCompressed fall back to decompression for unsupported compression types (take 2) This is intended to make using compressed textures easier since developers can just provided compressed data and it will be uploaded to the GPU in some way, shape or form. TBR=reed@google.com Change-Id: I8c672ccc7db5cd098f629c3469ae7cbdc7436392 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/266939 Reviewed-by: Robert Phillips <robertphillips@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com>
2020-01-27 21:11:57 +00:00
"$_src/core/SkCompressedDataUtils.cpp",
harmonize rewrite-includes and gn-format checks The CheckGeneratedFiles bot only required rewriting .gn files, while the presubmit wants both .gn and .gni files. It also appears that the #includes rewrite script runs on both the presubmit and CheckGeneratedFiles bots. These presubmits run on the CQ before landing right? If so, no need for them in the CheckGeneratedFIles bot at all. And of course, format .gni files. Change-Id: Icd4526d62f85088862ad93566cc9ace11dc3e33f Reviewed-on: https://skia-review.googlesource.com/c/skia/+/281505 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Mike Klein <mtklein@google.com>
2020-04-03 15:59:37 +00:00
"$_src/core/SkCompressedDataUtils.h",
per-contour variant of SkPathMeasure Bug: skia:8721 Change-Id: I1e79a49dee25ccc9138baf6fb2df3dc80d1ff66b Reviewed-on: https://skia-review.googlesource.com/c/187922 Commit-Queue: Mike Reed <reed@google.com> Reviewed-by: Kevin Lubick <kjlubick@google.com>
2019-02-06 16:40:27 +00:00
"$_src/core/SkContourMeasure.cpp",
Rename SkConfig8888/SkPixelInfo to SkConvertPixels BUG=skia: Change-Id: I4f3c6370b3ef4247aa446716c7c154899925d089 Reviewed-on: https://skia-review.googlesource.com/8442 Commit-Queue: Mike Klein <mtklein@chromium.org> Reviewed-by: Mike Klein <mtklein@chromium.org>
2017-02-14 19:18:27 +00:00
"$_src/core/SkConvertPixels.cpp",
"$_src/core/SkConvertPixels.h",
gypi -> gni: core, effects, android framework defines BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4023 Change-Id: I29a26c1716a319156a34a64999756ed7dba1e603 Reviewed-on: https://skia-review.googlesource.com/4023 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
2016-10-26 21:19:03 +00:00
"$_src/core/SkCoreBlitters.h",
"$_src/core/SkCpu.cpp",
"$_src/core/SkCpu.h",
"$_src/core/SkCubicClipper.cpp",
"$_src/core/SkCubicClipper.h",
cubic-map for non-linear t Bug: skia: Change-Id: I248864bd853361c1abfc2d8af61a27ab27a49a91 Reviewed-on: https://skia-review.googlesource.com/38882 Reviewed-by: Florin Malita <fmalita@chromium.org> Commit-Queue: Mike Reed <reed@google.com>
2018-01-04 22:05:11 +00:00
"$_src/core/SkCubicMap.cpp",
gypi -> gni: core, effects, android framework defines BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4023 Change-Id: I29a26c1716a319156a34a64999756ed7dba1e603 Reviewed-on: https://skia-review.googlesource.com/4023 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
2016-10-26 21:19:03 +00:00
"$_src/core/SkData.cpp",
"$_src/core/SkDataTable.cpp",
"$_src/core/SkDebug.cpp",
Implement GPU/OpList DDLs This relies on https://skia-review.googlesource.com/c/skia/+/102101 (Add SkSurface_Gpu::MakeWrappedRenderTarget method) landing first TBR=bsalomon@google.com Change-Id: I4d2d66af5800407f638ef32d7b19ce49084bd4e4 Reviewed-on: https://skia-review.googlesource.com/102263 Commit-Queue: Robert Phillips <robertphillips@google.com> Reviewed-by: Greg Daniel <egdaniel@google.com>
2018-02-01 14:10:04 +00:00
"$_src/core/SkDeferredDisplayList.cpp",
harmonize rewrite-includes and gn-format checks The CheckGeneratedFiles bot only required rewriting .gn files, while the presubmit wants both .gn and .gni files. It also appears that the #includes rewrite script runs on both the presubmit and CheckGeneratedFiles bots. These presubmits run on the CQ before landing right? If so, no need for them in the CheckGeneratedFIles bot at all. And of course, format .gni files. Change-Id: Icd4526d62f85088862ad93566cc9ace11dc3e33f Reviewed-on: https://skia-review.googlesource.com/c/skia/+/281505 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Mike Klein <mtklein@google.com>
2020-04-03 15:59:37 +00:00
"$_src/core/SkDeferredDisplayListPriv.h",
DeferredDisplayList API proposal Chrome would like to perform cpu-side preprocessing for gpu draws in parallel. They do not want to go through a picture (since they have their own display list format). The general idea is that we add a new SkDeferredDisplayListRecorder class to perform all of Ganesh's cpu-side preprocessing ahead of time and in parallel. The SkDDLRecorder operates like SkPictureRecorder. The user can get an SkCanvas from the SkDDLRecorder and feed it draw operations. Once finished, the user calls 'detach' to get an SkDeferredDisplayList. All the work up to and including the 'detach' call can be done in parallel and will not touch the GPU. To actually get pixels the client must call SkSurface::draw(SkDDL) on an SkSurface that is "compatible" with the surface characterization initially given to the SkDDLMaker. The surface characterization contains the minimum amount of information Ganesh needs to know about the ultimate destination in order to perform its cpu-side work (i.e., caps, width, height, config). Change-Id: I75faa483ab5a6b779c8de56ea56b9d90b990f43a Reviewed-on: https://skia-review.googlesource.com/30140 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com>
2017-08-30 16:06:35 +00:00
"$_src/core/SkDeferredDisplayListRecorder.cpp",
gypi -> gni: core, effects, android framework defines BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4023 Change-Id: I29a26c1716a319156a34a64999756ed7dba1e603 Reviewed-on: https://skia-review.googlesource.com/4023 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
2016-10-26 21:19:03 +00:00
"$_src/core/SkDeque.cpp",
Update SkDescriptor * add reset(const SkDescriptor&) to SkAutoDescriptor * move impl to .cpp * general updating of code Change-Id: Id224d73456576927f78b4ba3afecc759c1fe3a1b Reviewed-on: https://skia-review.googlesource.com/c/181175 Commit-Queue: Herb Derby <herb@google.com> Reviewed-by: Robert Phillips <robertphillips@google.com>
2019-01-04 18:14:28 +00:00
"$_src/core/SkDescriptor.cpp",
gypi -> gni: core, effects, android framework defines BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4023 Change-Id: I29a26c1716a319156a34a64999756ed7dba1e603 Reviewed-on: https://skia-review.googlesource.com/4023 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
2016-10-26 21:19:03 +00:00
"$_src/core/SkDescriptor.h",
"$_src/core/SkDevice.cpp",
Revert "Revert "move device headers to core"" This reverts commit d4bdee5f2c4c2c1387426d287f61645b5af8f8e0. BUG=skia: Change-Id: If5c316f8585881e43321412a2a38f97fd4aa5f02 Reviewed-on: https://skia-review.googlesource.com/7315 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Reed <reed@google.com>
2017-01-19 21:07:49 +00:00
"$_src/core/SkDevice.h",
gypi -> gni: core, effects, android framework defines BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4023 Change-Id: I29a26c1716a319156a34a64999756ed7dba1e603 Reviewed-on: https://skia-review.googlesource.com/4023 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
2016-10-26 21:19:03 +00:00
"$_src/core/SkDiscardableMemory.h",
"$_src/core/SkDistanceFieldGen.cpp",
"$_src/core/SkDistanceFieldGen.h",
"$_src/core/SkDocument.cpp",
"$_src/core/SkDraw.cpp",
move SkDraw.h to core BUG=skia: Change-Id: Ic8c949530414f3f8d7caded969941dc853a06271 Reviewed-on: https://skia-review.googlesource.com/6845 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Reed <reed@google.com>
2017-01-10 19:57:59 +00:00
"$_src/core/SkDraw.h",
gypi -> gni: core, effects, android framework defines BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4023 Change-Id: I29a26c1716a319156a34a64999756ed7dba1e603 Reviewed-on: https://skia-review.googlesource.com/4023 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
2016-10-26 21:19:03 +00:00
"$_src/core/SkDrawLooper.cpp",
"$_src/core/SkDrawProcs.h",
Compute correct bounds for DrawShadowRec. Bug: skia:6880 Change-Id: Ia8b94e52eec3feb5104d2351bf7a7e6f99101deb Reviewed-on: https://skia-review.googlesource.com/26370 Commit-Queue: Jim Van Verth <jvanverth@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com>
2017-07-31 13:34:58 +00:00
"$_src/core/SkDrawShadowInfo.cpp",
"$_src/core/SkDrawShadowInfo.h",
harmonize rewrite-includes and gn-format checks The CheckGeneratedFiles bot only required rewriting .gn files, while the presubmit wants both .gn and .gni files. It also appears that the #includes rewrite script runs on both the presubmit and CheckGeneratedFiles bots. These presubmits run on the CQ before landing right? If so, no need for them in the CheckGeneratedFIles bot at all. And of course, format .gni files. Change-Id: Icd4526d62f85088862ad93566cc9ace11dc3e33f Reviewed-on: https://skia-review.googlesource.com/c/skia/+/281505 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Mike Klein <mtklein@google.com>
2020-04-03 15:59:37 +00:00
"$_src/core/SkDraw_atlas.cpp",
"$_src/core/SkDraw_text.cpp",
"$_src/core/SkDraw_vertices.cpp",
"$_src/core/SkDrawable.cpp",
"$_src/core/SkEdge.cpp",
"$_src/core/SkEdge.h",
gypi -> gni: core, effects, android framework defines BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4023 Change-Id: I29a26c1716a319156a34a64999756ed7dba1e603 Reviewed-on: https://skia-review.googlesource.com/4023 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
2016-10-26 21:19:03 +00:00
"$_src/core/SkEdgeBuilder.cpp",
"$_src/core/SkEdgeBuilder.h",
"$_src/core/SkEdgeClipper.cpp",
"$_src/core/SkEdgeClipper.h",
"$_src/core/SkEndian.h",
harmonize rewrite-includes and gn-format checks The CheckGeneratedFiles bot only required rewriting .gn files, while the presubmit wants both .gn and .gni files. It also appears that the #includes rewrite script runs on both the presubmit and CheckGeneratedFiles bots. These presubmits run on the CQ before landing right? If so, no need for them in the CheckGeneratedFIles bot at all. And of course, format .gni files. Change-Id: Icd4526d62f85088862ad93566cc9ace11dc3e33f Reviewed-on: https://skia-review.googlesource.com/c/skia/+/281505 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Mike Klein <mtklein@google.com>
2020-04-03 15:59:37 +00:00
"$_src/core/SkEnumerate.h",
SkExecutor Refactoring to refamiliarize myself with SkTaskGroup and SkThreadPool. This adds an SkExecutor interface to describe how we use SkThreadPool, with a global setter and getter for a default instance. Then I rewrote SkTaskGroup to work with any executor, the global default by default. I also think I've made the SkTaskGroup::wait() borrow logic clearer with the addition of SkSemaphore::try_wait(). This lets me keep the semaphore count and actual count of work in perfect sync. Change-Id: I6bbdfaeb0e2c3a43daff6192d34bc4a3f7210178 Reviewed-on: https://skia-review.googlesource.com/8836 Reviewed-by: Mike Reed <reed@google.com> Reviewed-by: Herb Derby <herb@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
2017-02-22 03:53:16 +00:00
"$_src/core/SkExecutor.cpp",
gypi -> gni: core, effects, android framework defines BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4023 Change-Id: I29a26c1716a319156a34a64999756ed7dba1e603 Reviewed-on: https://skia-review.googlesource.com/4023 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
2016-10-26 21:19:03 +00:00
"$_src/core/SkFDot6.h",
"$_src/core/SkFlattenable.cpp",
"$_src/core/SkFont.cpp",
"$_src/core/SkFontDescriptor.cpp",
"$_src/core/SkFontDescriptor.h",
harmonize rewrite-includes and gn-format checks The CheckGeneratedFiles bot only required rewriting .gn files, while the presubmit wants both .gn and .gni files. It also appears that the #includes rewrite script runs on both the presubmit and CheckGeneratedFiles bots. These presubmits run on the CQ before landing right? If so, no need for them in the CheckGeneratedFIles bot at all. And of course, format .gni files. Change-Id: Icd4526d62f85088862ad93566cc9ace11dc3e33f Reviewed-on: https://skia-review.googlesource.com/c/skia/+/281505 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Mike Klein <mtklein@google.com>
2020-04-03 15:59:37 +00:00
"$_src/core/SkFontLCDConfig.cpp",
"$_src/core/SkFontMgr.cpp",
Add missing #includes for referenced types, and missing headers in GN. These missing items were discovered when attempting a refactor. Change-Id: Ibf905dacba14ebf5d3174f11c557741c7ab7848f Reviewed-on: https://skia-review.googlesource.com/c/skia/+/306061 Reviewed-by: Michael Ludwig <michaelludwig@google.com> Commit-Queue: John Stiles <johnstiles@google.com> Auto-Submit: John Stiles <johnstiles@google.com>
2020-07-27 19:53:49 +00:00
"$_src/core/SkFontMgrPriv.h",
"$_src/core/SkFontPriv.h",
gypi -> gni: core, effects, android framework defines BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4023 Change-Id: I29a26c1716a319156a34a64999756ed7dba1e603 Reviewed-on: https://skia-review.googlesource.com/4023 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
2016-10-26 21:19:03 +00:00
"$_src/core/SkFontStream.cpp",
"$_src/core/SkFontStream.h",
harmonize rewrite-includes and gn-format checks The CheckGeneratedFiles bot only required rewriting .gn files, while the presubmit wants both .gn and .gni files. It also appears that the #includes rewrite script runs on both the presubmit and CheckGeneratedFiles bots. These presubmits run on the CQ before landing right? If so, no need for them in the CheckGeneratedFIles bot at all. And of course, format .gni files. Change-Id: Icd4526d62f85088862ad93566cc9ace11dc3e33f Reviewed-on: https://skia-review.googlesource.com/c/skia/+/281505 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Mike Klein <mtklein@google.com>
2020-04-03 15:59:37 +00:00
"$_src/core/SkFont_serial.cpp",
gypi -> gni: core, effects, android framework defines BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4023 Change-Id: I29a26c1716a319156a34a64999756ed7dba1e603 Reviewed-on: https://skia-review.googlesource.com/4023 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
2016-10-26 21:19:03 +00:00
"$_src/core/SkFuzzLogging.h",
harmonize rewrite-includes and gn-format checks The CheckGeneratedFiles bot only required rewriting .gn files, while the presubmit wants both .gn and .gni files. It also appears that the #includes rewrite script runs on both the presubmit and CheckGeneratedFiles bots. These presubmits run on the CQ before landing right? If so, no need for them in the CheckGeneratedFIles bot at all. And of course, format .gni files. Change-Id: Icd4526d62f85088862ad93566cc9ace11dc3e33f Reviewed-on: https://skia-review.googlesource.com/c/skia/+/281505 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Mike Klein <mtklein@google.com>
2020-04-03 15:59:37 +00:00
"$_src/core/SkGaussFilter.cpp",
"$_src/core/SkGaussFilter.h",
gypi -> gni: core, effects, android framework defines BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4023 Change-Id: I29a26c1716a319156a34a64999756ed7dba1e603 Reviewed-on: https://skia-review.googlesource.com/4023 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
2016-10-26 21:19:03 +00:00
"$_src/core/SkGeometry.cpp",
"$_src/core/SkGeometry.h",
"$_src/core/SkGlobalInitialization_core.cpp",
Cleanup size calculations in SkGlyph BUG=skia:7515 Change-Id: Ie9d255a93ecff86ce018f8510332bdb280ec575e Reviewed-on: https://skia-review.googlesource.com/113863 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Herb Derby <herb@google.com>
2018-03-12 20:02:29 +00:00
"$_src/core/SkGlyph.cpp",
harmonize rewrite-includes and gn-format checks The CheckGeneratedFiles bot only required rewriting .gn files, while the presubmit wants both .gn and .gni files. It also appears that the #includes rewrite script runs on both the presubmit and CheckGeneratedFiles bots. These presubmits run on the CQ before landing right? If so, no need for them in the CheckGeneratedFIles bot at all. And of course, format .gni files. Change-Id: Icd4526d62f85088862ad93566cc9ace11dc3e33f Reviewed-on: https://skia-review.googlesource.com/c/skia/+/281505 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Mike Klein <mtklein@google.com>
2020-04-03 15:59:37 +00:00
"$_src/core/SkGlyph.h",
Introduce SkGlyphDrawableBuffer Used for efficient glyph id to glyph lookup. This is part of a larger change: https://skia-review.googlesource.com/c/skia/+/238196 Change-Id: Ifce43879685bf0d760a7e12dceb32f7a650be687 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/247340 Commit-Queue: Herb Derby <herb@google.com> Reviewed-by: Ben Wagner <bungeman@google.com>
2019-10-09 16:26:56 +00:00
"$_src/core/SkGlyphBuffer.cpp",
harmonize rewrite-includes and gn-format checks The CheckGeneratedFiles bot only required rewriting .gn files, while the presubmit wants both .gn and .gni files. It also appears that the #includes rewrite script runs on both the presubmit and CheckGeneratedFiles bots. These presubmits run on the CQ before landing right? If so, no need for them in the CheckGeneratedFIles bot at all. And of course, format .gni files. Change-Id: Icd4526d62f85088862ad93566cc9ace11dc3e33f Reviewed-on: https://skia-review.googlesource.com/c/skia/+/281505 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Mike Klein <mtklein@google.com>
2020-04-03 15:59:37 +00:00
"$_src/core/SkGlyphBuffer.h",
Reland "Have draw(Text|PosText|PosTextH) use a single entry on the device" This reverts commit 74b390d6b136a60f1df15ac5ecd19bd8ad5a394b. Reason for revert: reverting to add patch for valgrind Original change's description: > Revert "Have draw(Text|PosText|PosTextH) use a single entry on the device" > > This reverts commit 4225b3220ef4bf50f0d9403f812ea94d50c4ee59. > > Reason for revert: made valgrind unhappy. > > Original change's description: > > Have draw(Text|PosText|PosTextH) use a single entry on the device > > > > Handle the positioning of drawText at the canvas layer. Simplify > > the code by removing similar implementations. > > > > Change-Id: I8b711783435072f560e29fca1dd934fa2e345ed2 > > Reviewed-on: https://skia-review.googlesource.com/127131 > > Reviewed-by: Ben Wagner <bungeman@google.com> > > Commit-Queue: Herb Derby <herb@google.com> > > TBR=jvanverth@google.com,bungeman@google.com,herb@google.com > > Change-Id: I65c9d30ae6ecb1f87e8660e56d8f8ce5daab7551 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://skia-review.googlesource.com/132403 > Reviewed-by: Hal Canary <halcanary@google.com> > Commit-Queue: Hal Canary <halcanary@google.com> TBR=jvanverth@google.com,halcanary@google.com,bungeman@google.com,herb@google.com Change-Id: I9bbb73aac447b51eb8215ac42331759fa4c9fa45 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://skia-review.googlesource.com/132580 Reviewed-by: Herb Derby <herb@google.com> Commit-Queue: Herb Derby <herb@google.com>
2018-06-06 17:45:53 +00:00
"$_src/core/SkGlyphRun.cpp",
"$_src/core/SkGlyphRun.h",
Extract SkGlyphRunListPainter from SkGlyphRun.* Change-Id: I2c5275b6dd9cf2f83d4d99b73dd32dff487e659b Reviewed-on: https://skia-review.googlesource.com/150660 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Ben Wagner <bungeman@google.com>
2018-08-30 18:50:04 +00:00
"$_src/core/SkGlyphRunPainter.cpp",
"$_src/core/SkGlyphRunPainter.h",
gypi -> gni: core, effects, android framework defines BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4023 Change-Id: I29a26c1716a319156a34a64999756ed7dba1e603 Reviewed-on: https://skia-review.googlesource.com/4023 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
2016-10-26 21:19:03 +00:00
"$_src/core/SkGpuBlurUtils.cpp",
harmonize rewrite-includes and gn-format checks The CheckGeneratedFiles bot only required rewriting .gn files, while the presubmit wants both .gn and .gni files. It also appears that the #includes rewrite script runs on both the presubmit and CheckGeneratedFiles bots. These presubmits run on the CQ before landing right? If so, no need for them in the CheckGeneratedFIles bot at all. And of course, format .gni files. Change-Id: Icd4526d62f85088862ad93566cc9ace11dc3e33f Reviewed-on: https://skia-review.googlesource.com/c/skia/+/281505 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Mike Klein <mtklein@google.com>
2020-04-03 15:59:37 +00:00
"$_src/core/SkGpuBlurUtils.h",
gypi -> gni: core, effects, android framework defines BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4023 Change-Id: I29a26c1716a319156a34a64999756ed7dba1e603 Reviewed-on: https://skia-review.googlesource.com/4023 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
2016-10-26 21:19:03 +00:00
"$_src/core/SkGraphics.cpp",
"$_src/core/SkHalf.cpp",
Revert "Revert "WIP: Skia support library for ICC tasks"" This reverts commit eb733fbf56538838a36814c75cd03f917462cb22. Reason for revert: Revert patch was automatically merged incorrectly? Original change's description: > Revert "WIP: Skia support library for ICC tasks" > > This reverts commit fc8dc3194acb959ee5980b41766660ca0644bcab. > > Reason for revert: Breaks Build-Mac-Clang-Arm7-{Debug,Release}-iOS builds. > Example tasks: > * https://chromium-swarm.appspot.com/task?id=3322f668620b9e10&refresh=10 > * https://chromium-swarm.appspot.com/task?id=332296146331e810&refresh=10 > > Original change's description: > > WIP: Skia support library for ICC tasks > > > > As a starting point, this would be mostly trivial to implement using > > SkColorSpace. > > > > This also would give us the flexibility to begin to move all of > > the ICC related code from SkColorSpace to SkICC. > > > > What are the advantages of moving this away from SkColorSpace? > > (1) A long term goal (once Chrome uses SkCodec), might be to > > move SkColorSpace::MakeICC() out of the public API. That way, > > we can guarantee that we can draw to/from *any* SkColorSpace. > > (2) Keeps SkColorSpace separate from ICC-specific representations > > like SkColorSpaceTransferFn etc. > > > > BUG=skia: > > > > Change-Id: Iddeb9903221fb57fbfc01218d8641c928b4a5165 > > Reviewed-on: https://skia-review.googlesource.com/5676 > > Commit-Queue: Matt Sarett <msarett@google.com> > > Reviewed-by: Brian Osman <brianosman@google.com> > > Reviewed-by: Mike Reed <reed@google.com> > > > > TBR=mtklein@google.com,msarett@google.com,brianosman@google.com,reed@google.com,reviews@skia.org > BUG=skia: > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > > Change-Id: Ibdf272fce25892402bd3e85595fb8814cdf59856 > Reviewed-on: https://skia-review.googlesource.com/6232 > Commit-Queue: Ravi Mistry <rmistry@google.com> > Reviewed-by: Ravi Mistry <rmistry@google.com> > TBR=mtklein@google.com,rmistry@google.com,msarett@google.com,reviews@skia.org,brianosman@google.com,reed@google.com BUG=skia: NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Change-Id: I68b1624cfab8adfe31b17e1193a7766507dec8b0 Reviewed-on: https://skia-review.googlesource.com/6233 Commit-Queue: Ravi Mistry <rmistry@google.com> Reviewed-by: Ravi Mistry <rmistry@google.com>
2016-12-17 01:31:03 +00:00
"$_src/core/SkICC.cpp",
Prevent unbounded listener growth on SkPixelRefs. Use SkIDChangeListener and update GrBitmapTextureMaker to add listener to key to deregister if texture is purged before genID changes. Add a common listener list implementation and replace existing lists. Change-Id: Ib0c78241eaf59b59b892d8b004b2bb095140bc6d Reviewed-on: https://skia-review.googlesource.com/c/skia/+/274549 Commit-Queue: Brian Salomon <bsalomon@google.com> Reviewed-by: Brian Osman <brianosman@google.com>
2020-03-02 21:59:40 +00:00
"$_src/core/SkIDChangeListener.cpp",
gypi -> gni: core, effects, android framework defines BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4023 Change-Id: I29a26c1716a319156a34a64999756ed7dba1e603 Reviewed-on: https://skia-review.googlesource.com/4023 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
2016-10-26 21:19:03 +00:00
"$_src/core/SkImageFilter.cpp",
"$_src/core/SkImageFilterCache.cpp",
"$_src/core/SkImageFilterCache.h",
Define coord space tagged geometry for image filters v2. This is an alternative approach to https://skia-review.googlesource.com/c/skia/+/234896 It inverts the templates and coordinate spaces, so that each coordinate space is defined by a struct that accepts the SkIRect/etc. type as an argument. For parameter space and device space, the only exposed functionality is holding on to the coordinates and moving into and out of the layer space (using the Mapping type, which now encapsulates the definition of parameter, layer, and device space for a given CTM). The LayerSpace struct has specialized definitions for each of the 6 key geometric types, exposes accessors/mutators and operations like join/intersect that work on appropriate layer-space geometry. FilterResult and Context have been updated to use these new types, although they no longer take a Usage enum. If this strategy works, FilterResult will be updated to have more utilities to operate and read from its image in layer-space so there won't be a need to have the image space (and the usage enum to differentiate between different image spaces). To further reinforce the differences between getInputBounds() and getOutputBounds() (which previously used Usage to do this), they now accept/return values in device and parameter space. This is no different than what SkCanvas would have done before calling the old functions, but now that work is owned by SkImageFilter (seems like a good thing), and achieves the same reinforcement. Change-Id: I8bebb9fadf6c8f2bd51fa863b2d6f2e4a33dd08b Reviewed-on: https://skia-review.googlesource.com/c/skia/+/244515 Commit-Queue: Michael Ludwig <michaelludwig@google.com> Reviewed-by: Robert Phillips <robertphillips@google.com>
2019-10-02 17:38:29 +00:00
"$_src/core/SkImageFilterTypes.cpp",
Move Context into separate header/namespace The new namespace 'skif' will contain many more types down the road to help with image filter implementations. Too many to make inner classes like Context was, but once the namespace exists, it doesn't make sense for Context to be the only inner class. Bug: skia:9282 Change-Id: I4ed76bd5f6c8f0b8ca2f2e1c5d76006c7cccf91e Reviewed-on: https://skia-review.googlesource.com/c/skia/+/234581 Commit-Queue: Michael Ludwig <michaelludwig@google.com> Reviewed-by: Robert Phillips <robertphillips@google.com>
2019-08-14 18:39:00 +00:00
"$_src/core/SkImageFilterTypes.h",
harmonize rewrite-includes and gn-format checks The CheckGeneratedFiles bot only required rewriting .gn files, while the presubmit wants both .gn and .gni files. It also appears that the #includes rewrite script runs on both the presubmit and CheckGeneratedFiles bots. These presubmits run on the CQ before landing right? If so, no need for them in the CheckGeneratedFIles bot at all. And of course, format .gni files. Change-Id: Icd4526d62f85088862ad93566cc9ace11dc3e33f Reviewed-on: https://skia-review.googlesource.com/c/skia/+/281505 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Mike Klein <mtklein@google.com>
2020-04-03 15:59:37 +00:00
"$_src/core/SkImageFilter_Base.h",
gypi -> gni: core, effects, android framework defines BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4023 Change-Id: I29a26c1716a319156a34a64999756ed7dba1e603 Reviewed-on: https://skia-review.googlesource.com/4023 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
2016-10-26 21:19:03 +00:00
"$_src/core/SkImageGenerator.cpp",
harmonize rewrite-includes and gn-format checks The CheckGeneratedFiles bot only required rewriting .gn files, while the presubmit wants both .gn and .gni files. It also appears that the #includes rewrite script runs on both the presubmit and CheckGeneratedFiles bots. These presubmits run on the CQ before landing right? If so, no need for them in the CheckGeneratedFIles bot at all. And of course, format .gni files. Change-Id: Icd4526d62f85088862ad93566cc9ace11dc3e33f Reviewed-on: https://skia-review.googlesource.com/c/skia/+/281505 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Mike Klein <mtklein@google.com>
2020-04-03 15:59:37 +00:00
"$_src/core/SkImageInfo.cpp",
Add SkLRUCache.h to core.gni. It wasn't listed in gn so didn't show up in editors as a known file in projects. Change-Id: Ie01773489dd72f055f04785ca7f21b6bdef6a3f7 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/290541 Commit-Queue: Ben Wagner <bungeman@google.com> Auto-Submit: Ben Wagner <bungeman@google.com> Reviewed-by: Herb Derby <herb@google.com>
2020-05-18 15:57:53 +00:00
"$_src/core/SkLRUCache.h",
harmonize rewrite-includes and gn-format checks The CheckGeneratedFiles bot only required rewriting .gn files, while the presubmit wants both .gn and .gni files. It also appears that the #includes rewrite script runs on both the presubmit and CheckGeneratedFiles bots. These presubmits run on the CQ before landing right? If so, no need for them in the CheckGeneratedFIles bot at all. And of course, format .gni files. Change-Id: Icd4526d62f85088862ad93566cc9ace11dc3e33f Reviewed-on: https://skia-review.googlesource.com/c/skia/+/281505 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Mike Klein <mtklein@google.com>
2020-04-03 15:59:37 +00:00
"$_src/core/SkLatticeIter.cpp",
"$_src/core/SkLatticeIter.h",
gypi -> gni: core, effects, android framework defines BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4023 Change-Id: I29a26c1716a319156a34a64999756ed7dba1e603 Reviewed-on: https://skia-review.googlesource.com/4023 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
2016-10-26 21:19:03 +00:00
"$_src/core/SkLineClipper.cpp",
"$_src/core/SkLocalMatrixImageFilter.cpp",
"$_src/core/SkLocalMatrixImageFilter.h",
Revert "Revert "Extend SkCanvas matrix stack to be 4x4, but with (basically) the same public API."" The reason for the assert was breaking an assert, that if the CTM was scale/translate, that after a preTranslate, it should still be that. This is true... unless the new translate values are non-finite. In that case, we might turn a zero into a NaN, (0 * non_finite --> nan), so we either have to require finite args (which we don't at the moment) or we can't make this assert. This re-land removes that assert. This reverts commit 268ed57d71e7aa7230d0c1a5722cf84a65f43e61. Change-Id: I3c48a0aa17649351a246c1fbab5449f2d59aaf84 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/263023 Commit-Queue: Mike Reed <reed@google.com> Commit-Queue: Brian Osman <brianosman@google.com> Auto-Submit: Mike Reed <reed@google.com> Reviewed-by: Brian Osman <brianosman@google.com>
2020-01-08 15:40:39 +00:00
"$_src/core/SkM44.cpp",
gypi -> gni: core, effects, android framework defines BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4023 Change-Id: I29a26c1716a319156a34a64999756ed7dba1e603 Reviewed-on: https://skia-review.googlesource.com/4023 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
2016-10-26 21:19:03 +00:00
"$_src/core/SkMD5.cpp",
"$_src/core/SkMD5.h",
refactor/layering: SkMalloc.cpp Change-Id: Ie27c9f0ba2b9f160010d33548dc8359851610d79 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/251819 Commit-Queue: Hal Canary <halcanary@google.com> Auto-Submit: Hal Canary <halcanary@google.com> Reviewed-by: Ben Wagner <bungeman@google.com>
2019-10-30 21:26:45 +00:00
"$_src/core/SkMalloc.cpp",
gypi -> gni: core, effects, android framework defines BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4023 Change-Id: I29a26c1716a319156a34a64999756ed7dba1e603 Reviewed-on: https://skia-review.googlesource.com/4023 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
2016-10-26 21:19:03 +00:00
"$_src/core/SkMallocPixelRef.cpp",
Move markerstack into its own object: - owned by canvas - pointed to by devices Change-Id: Ia5abc60434cd34810ceea09ecab63c6b25eb972e Reviewed-on: https://skia-review.googlesource.com/c/skia/+/283436 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Mike Reed <reed@google.com>
2020-04-14 13:16:40 +00:00
"$_src/core/SkMarkerStack.cpp",
gypi -> gni: core, effects, android framework defines BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4023 Change-Id: I29a26c1716a319156a34a64999756ed7dba1e603 Reviewed-on: https://skia-review.googlesource.com/4023 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
2016-10-26 21:19:03 +00:00
"$_src/core/SkMask.cpp",
move SkMask.h to src Bug: skia: Change-Id: Ie51476412fb52df7cc07fdbd4dbbbfc89d9c08a7 Reviewed-on: https://skia-review.googlesource.com/104081 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Reed <reed@google.com>
2018-02-06 02:27:27 +00:00
"$_src/core/SkMask.h",
Revert "Revert "Experimental blur code with 32 bit fix."" This reverts commit 27b3d272a8fcce24813212f5816b177090111ec6. Reason for revert: guard has landed in android Original change's description: > Revert "Experimental blur code with 32 bit fix." > > This reverts commit d4b2c537d058ad4cb890ba116d00aa86c3416c08. > > Reason for revert: speculative fix for android-roll > > java.lang.AssertionError: expected:<0> but was:<255> > at org.junit.Assert.fail(Assert.java:88) > at org.junit.Assert.failNotEquals(Assert.java:834) > at org.junit.Assert.assertEquals(Assert.java:645) > at org.junit.Assert.assertEquals(Assert.java:631) > at android.graphics.cts.BlurMaskFilterTest.verifyColor(BlurMaskFilterTest.java:79) > at android.graphics.cts.BlurMaskFilterTest.verifyQuadrants(BlurMaskFilterTest.java:72) > at android.graphics.cts.BlurMaskFilterTest.testBlurMaskFilter(BlurMaskFilterTest.java:56) > > Original change's description: > > Experimental blur code with 32 bit fix. > > > > This uses a new method of blurring that runs the three > > passes of the box filter in a single pass. This implementation > > currently only does 1x1 pixel at a time, but it should be simple > > to expand to 4x4 pixels at a time. > > > > On the blur_10_normal_high_quality benchmark, the new is 7% faster > > than the old code. For the blur_100.50_normal_high_quality > > benchmark, the new code is 11% slower. > > > > Bug: skia: > > Change-Id: I847270906b0ceac1dfbf43ab5446756689ef660f > > Reviewed-on: https://skia-review.googlesource.com/22700 > > Reviewed-by: Mike Reed <reed@google.com> > > Commit-Queue: Herb Derby <herb@google.com> > > TBR=herb@google.com,reed@google.com > > Change-Id: Ie84f6bf8872cae08c06d679f0c2f2e6c3d8a02a2 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: skia: > Reviewed-on: https://skia-review.googlesource.com/22880 > Reviewed-by: Mike Reed <reed@google.com> > Commit-Queue: Mike Reed <reed@google.com> TBR=herb@google.com,reed@google.com Change-Id: I393d1c05f83ccf98137201bc7b4e7d8e8b0e8742 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: skia: Reviewed-on: https://skia-review.googlesource.com/23121 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Reed <reed@google.com>
2017-07-13 17:16:34 +00:00
"$_src/core/SkMaskBlurFilter.cpp",
harmonize rewrite-includes and gn-format checks The CheckGeneratedFiles bot only required rewriting .gn files, while the presubmit wants both .gn and .gni files. It also appears that the #includes rewrite script runs on both the presubmit and CheckGeneratedFiles bots. These presubmits run on the CQ before landing right? If so, no need for them in the CheckGeneratedFIles bot at all. And of course, format .gni files. Change-Id: Icd4526d62f85088862ad93566cc9ace11dc3e33f Reviewed-on: https://skia-review.googlesource.com/c/skia/+/281505 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Mike Klein <mtklein@google.com>
2020-04-03 15:59:37 +00:00
"$_src/core/SkMaskBlurFilter.h",
gypi -> gni: core, effects, android framework defines BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4023 Change-Id: I29a26c1716a319156a34a64999756ed7dba1e603 Reviewed-on: https://skia-review.googlesource.com/4023 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
2016-10-26 21:19:03 +00:00
"$_src/core/SkMaskCache.cpp",
"$_src/core/SkMaskFilter.cpp",
Add missing #includes for referenced types, and missing headers in GN. These missing items were discovered when attempting a refactor. Change-Id: Ibf905dacba14ebf5d3174f11c557741c7ab7848f Reviewed-on: https://skia-review.googlesource.com/c/skia/+/306061 Reviewed-by: Michael Ludwig <michaelludwig@google.com> Commit-Queue: John Stiles <johnstiles@google.com> Auto-Submit: John Stiles <johnstiles@google.com>
2020-07-27 19:53:49 +00:00
"$_src/core/SkMaskFilterBase.h",
gypi -> gni: core, effects, android framework defines BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4023 Change-Id: I29a26c1716a319156a34a64999756ed7dba1e603 Reviewed-on: https://skia-review.googlesource.com/4023 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
2016-10-26 21:19:03 +00:00
"$_src/core/SkMaskGamma.cpp",
"$_src/core/SkMaskGamma.h",
"$_src/core/SkMath.cpp",
"$_src/core/SkMathPriv.h",
"$_src/core/SkMatrix.cpp",
"$_src/core/SkMatrix44.cpp",
"$_src/core/SkMatrixImageFilter.cpp",
"$_src/core/SkMatrixImageFilter.h",
"$_src/core/SkMatrixUtils.h",
Move SkMessageBus.h into src/core Not used by anything else in the include directory, probably don't want to accidentially expose it either. Change-Id: I50d255e2cac43d8405305a825fd194bb36edd8fd Reviewed-on: https://skia-review.googlesource.com/c/skia/+/213826 Reviewed-by: Mike Klein <mtklein@google.com> Commit-Queue: Ben Wagner <bungeman@google.com>
2019-05-15 14:15:52 +00:00
"$_src/core/SkMessageBus.h",
Revert "remove SkMiniPicture and co." This reverts commit 046ecb1b5e0133bde915ffbd0f727224169f39b7. Reason for revert: Flutter Original change's description: > remove SkMiniPicture and co. > > This was an optimization for Chromium that I believe is no longer > relevant in a world of PaintOpBuffers. > > Change-Id: Ic7526715a0ef1c3cec387a44189b7d56d5107af5 > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/213680 > Reviewed-by: Mike Reed <reed@google.com> > Commit-Queue: Mike Klein <mtklein@google.com> TBR=mtklein@google.com,reed@google.com,chinmaygarde@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: Ibf1ccee88c9ea140210cb9258ec96f9841e84c24 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/214661 Reviewed-by: Mike Klein <mtklein@google.com> Commit-Queue: Mike Klein <mtklein@google.com>
2019-05-20 12:45:50 +00:00
"$_src/core/SkMiniRecorder.cpp",
"$_src/core/SkMiniRecorder.h",
rename SkMipMap to SkMipmap Change-Id: I1fa8a0482a717847236a30b4851061f4074b7755 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/302644 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Mike Reed <reed@google.com>
2020-07-14 21:16:32 +00:00
"$_src/core/SkMipmap.cpp",
"$_src/core/SkMipmap.h",
gypi -> gni: core, effects, android framework defines BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4023 Change-Id: I29a26c1716a319156a34a64999756ed7dba1e603 Reviewed-on: https://skia-review.googlesource.com/4023 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
2016-10-26 21:19:03 +00:00
"$_src/core/SkModeColorFilter.cpp",
Update SkModeColorFilter to support an input FP. This change relies on the Xfermode updates in the prior CL (http://review.skia.org/299703) to render properly, and requires slightly different blending behavior in the compose FP which necessitated a new ComposeBehavior enum. Eventually we would like to settle on a universal ComposeBehavior which works well for all call sites, but that will be its own fairly disruptive change. This work will be tracked at skia:10457. Change-Id: I3cc0ea5e016fbef82bc63d653d60d0505efaa66f Bug: skia:10217 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/298821 Commit-Queue: John Stiles <johnstiles@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com> Reviewed-by: Brian Osman <brianosman@google.com>
2020-06-30 18:07:57 +00:00
"$_src/core/SkModeColorFilter.h",
gypi -> gni: core, effects, android framework defines BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4023 Change-Id: I29a26c1716a319156a34a64999756ed7dba1e603 Reviewed-on: https://skia-review.googlesource.com/4023 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
2016-10-26 21:19:03 +00:00
"$_src/core/SkNextID.h",
harmonize rewrite-includes and gn-format checks The CheckGeneratedFiles bot only required rewriting .gn files, while the presubmit wants both .gn and .gni files. It also appears that the #includes rewrite script runs on both the presubmit and CheckGeneratedFiles bots. These presubmits run on the CQ before landing right? If so, no need for them in the CheckGeneratedFIles bot at all. And of course, format .gni files. Change-Id: Icd4526d62f85088862ad93566cc9ace11dc3e33f Reviewed-on: https://skia-review.googlesource.com/c/skia/+/281505 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Mike Klein <mtklein@google.com>
2020-04-03 15:59:37 +00:00
"$_src/core/SkOSFile.h",
gypi -> gni: core, effects, android framework defines BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4023 Change-Id: I29a26c1716a319156a34a64999756ed7dba1e603 Reviewed-on: https://skia-review.googlesource.com/4023 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
2016-10-26 21:19:03 +00:00
"$_src/core/SkOpts.cpp",
"$_src/core/SkOpts.h",
"$_src/core/SkOrderedReadBuffer.h",
Add SkOverdrawCanvas to detect overdraw This is the first part of a multi-part change to detect and display gpu overdraw on Android. BUG:32370375 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4907 Change-Id: Ibba9d7343f2fd57397fa1168a5a5b1ef6ef91287 Reviewed-on: https://skia-review.googlesource.com/4907 Reviewed-by: Ben Wagner <bungeman@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Matt Sarett <msarett@google.com>
2016-11-22 16:31:41 +00:00
"$_src/core/SkOverdrawCanvas.cpp",
gypi -> gni: core, effects, android framework defines BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4023 Change-Id: I29a26c1716a319156a34a64999756ed7dba1e603 Reviewed-on: https://skia-review.googlesource.com/4023 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
2016-10-26 21:19:03 +00:00
"$_src/core/SkPaint.cpp",
"$_src/core/SkPaintDefaults.h",
"$_src/core/SkPaintPriv.cpp",
"$_src/core/SkPaintPriv.h",
"$_src/core/SkPath.cpp",
add simple pathbuilder 88.26 ? makepath_arrays_reserve nonrendering 235.97 makepath_detach_reserve nonrendering 274.56 makepath_snapshot_reserve nonrendering 537.61 makepath_path_reserve nonrendering 472.98 makepath_detach_noreserve nonrendering 482.56 makepath_snapshot_noreserve nonrendering 750.83 ? makepath_path_noreserve nonrendering Bug: skia:9000 Change-Id: I346537e899b08946c5778042a021f464006b029c Reviewed-on: https://skia-review.googlesource.com/c/skia/+/209403 Commit-Queue: Mike Reed <reed@google.com> Reviewed-by: Chris Dalton <csmartdalton@google.com>
2020-06-24 01:06:28 +00:00
"$_src/core/SkPathBuilder.cpp",
gypi -> gni: core, effects, android framework defines BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4023 Change-Id: I29a26c1716a319156a34a64999756ed7dba1e603 Reviewed-on: https://skia-review.googlesource.com/4023 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
2016-10-26 21:19:03 +00:00
"$_src/core/SkPathEffect.cpp",
"$_src/core/SkPathMeasure.cpp",
"$_src/core/SkPathPriv.h",
"$_src/core/SkPathRef.cpp",
harmonize rewrite-includes and gn-format checks The CheckGeneratedFiles bot only required rewriting .gn files, while the presubmit wants both .gn and .gni files. It also appears that the #includes rewrite script runs on both the presubmit and CheckGeneratedFiles bots. These presubmits run on the CQ before landing right? If so, no need for them in the CheckGeneratedFIles bot at all. And of course, format .gni files. Change-Id: Icd4526d62f85088862ad93566cc9ace11dc3e33f Reviewed-on: https://skia-review.googlesource.com/c/skia/+/281505 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Mike Klein <mtklein@google.com>
2020-04-03 15:59:37 +00:00
"$_src/core/SkPath_serial.cpp",
gypi -> gni: core, effects, android framework defines BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4023 Change-Id: I29a26c1716a319156a34a64999756ed7dba1e603 Reviewed-on: https://skia-review.googlesource.com/4023 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
2016-10-26 21:19:03 +00:00
"$_src/core/SkPixelRef.cpp",
"$_src/core/SkPixmap.cpp",
"$_src/core/SkPoint.cpp",
"$_src/core/SkPoint3.cpp",
Revert "Revert "Reuse GrTexture instances when the same GrBackendTexture is used to"" This reverts commit 426ba463d54c7fdd6f3b94f88b66c10c0212dafd. Bug: skia:8613 Change-Id: Iacaf40549369110aa95015e8d4579ec41db22d13 Reviewed-on: https://skia-review.googlesource.com/c/182963 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
2019-01-10 17:09:52 +00:00
"$_src/core/SkPromiseImageTexture.cpp",
gypi -> gni: core, effects, android framework defines BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4023 Change-Id: I29a26c1716a319156a34a64999756ed7dba1e603 Reviewed-on: https://skia-review.googlesource.com/4023 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
2016-10-26 21:19:03 +00:00
"$_src/core/SkPtrRecorder.cpp",
SkCustomTypefaceBuilder to set SkFontStyle Allow the user of SkCustomTypefaceBuilder to set the SkFontStyle of the resulting SkTypeface. This allows users to build font families. Fix the Font_flatten test to actually work (instead of relying on the magic behavior of nullptr for SkTypeface), add a test with the custom typeface, and reduce the number of times the inner loop runs from 302,400 times to 4,032 times so that the test finishes in a reasonable amount of time. Bug: skia:10630 Change-Id: I0b5e939552ee4a9a1249eefbb7a7279a59b38e5a Reviewed-on: https://skia-review.googlesource.com/c/skia/+/311596 Commit-Queue: Ben Wagner <bungeman@google.com> Reviewed-by: Xiao Yu <xster@google.com> Reviewed-by: Mike Klein <mtklein@google.com>
2020-08-18 17:17:09 +00:00
"$_src/core/SkPtrRecorder.h",
gypi -> gni: core, effects, android framework defines BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4023 Change-Id: I29a26c1716a319156a34a64999756ed7dba1e603 Reviewed-on: https://skia-review.googlesource.com/4023 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
2016-10-26 21:19:03 +00:00
"$_src/core/SkQuadClipper.cpp",
"$_src/core/SkQuadClipper.h",
harmonize rewrite-includes and gn-format checks The CheckGeneratedFiles bot only required rewriting .gn files, while the presubmit wants both .gn and .gni files. It also appears that the #includes rewrite script runs on both the presubmit and CheckGeneratedFiles bots. These presubmits run on the CQ before landing right? If so, no need for them in the CheckGeneratedFIles bot at all. And of course, format .gni files. Change-Id: Icd4526d62f85088862ad93566cc9ace11dc3e33f Reviewed-on: https://skia-review.googlesource.com/c/skia/+/281505 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Mike Klein <mtklein@google.com>
2020-04-03 15:59:37 +00:00
"$_src/core/SkRRect.cpp",
"$_src/core/SkRRectPriv.h",
"$_src/core/SkRTree.cpp",
"$_src/core/SkRTree.h",
"$_src/core/SkRWBuffer.cpp",
gypi -> gni: core, effects, android framework defines BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4023 Change-Id: I29a26c1716a319156a34a64999756ed7dba1e603 Reviewed-on: https://skia-review.googlesource.com/4023 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
2016-10-26 21:19:03 +00:00
"$_src/core/SkRasterClip.cpp",
"$_src/core/SkRasterPipeline.cpp",
"$_src/core/SkRasterPipelineBlitter.cpp",
"$_src/core/SkReadBuffer.cpp",
harmonize rewrite-includes and gn-format checks The CheckGeneratedFiles bot only required rewriting .gn files, while the presubmit wants both .gn and .gni files. It also appears that the #includes rewrite script runs on both the presubmit and CheckGeneratedFiles bots. These presubmits run on the CQ before landing right? If so, no need for them in the CheckGeneratedFIles bot at all. And of course, format .gni files. Change-Id: Icd4526d62f85088862ad93566cc9ace11dc3e33f Reviewed-on: https://skia-review.googlesource.com/c/skia/+/281505 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Mike Klein <mtklein@google.com>
2020-04-03 15:59:37 +00:00
"$_src/core/SkReadBuffer.h",
gypi -> gni: core, effects, android framework defines BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4023 Change-Id: I29a26c1716a319156a34a64999756ed7dba1e603 Reviewed-on: https://skia-review.googlesource.com/4023 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
2016-10-26 21:19:03 +00:00
"$_src/core/SkRecord.cpp",
"$_src/core/SkRecordDraw.cpp",
"$_src/core/SkRecordOpts.cpp",
"$_src/core/SkRecordOpts.h",
"$_src/core/SkRecordPattern.h",
harmonize rewrite-includes and gn-format checks The CheckGeneratedFiles bot only required rewriting .gn files, while the presubmit wants both .gn and .gni files. It also appears that the #includes rewrite script runs on both the presubmit and CheckGeneratedFiles bots. These presubmits run on the CQ before landing right? If so, no need for them in the CheckGeneratedFIles bot at all. And of course, format .gni files. Change-Id: Icd4526d62f85088862ad93566cc9ace11dc3e33f Reviewed-on: https://skia-review.googlesource.com/c/skia/+/281505 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Mike Klein <mtklein@google.com>
2020-04-03 15:59:37 +00:00
"$_src/core/SkRecords.cpp",
"$_src/core/SkRecords.h",
gypi -> gni: core, effects, android framework defines BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4023 Change-Id: I29a26c1716a319156a34a64999756ed7dba1e603 Reviewed-on: https://skia-review.googlesource.com/4023 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
2016-10-26 21:19:03 +00:00
"$_src/core/SkRect.cpp",
"$_src/core/SkRegion.cpp",
"$_src/core/SkRegionPriv.h",
"$_src/core/SkRegion_path.cpp",
Consolidate all the id handling and caching code. BUG=skia:7515 Change-Id: Iab31e8cadfaa1ce09d85aab9cc84a3e614ea5e45 Reviewed-on: https://skia-review.googlesource.com/100420 Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Herb Derby <herb@google.com>
2018-01-26 21:47:54 +00:00
"$_src/core/SkRemoteGlyphCache.cpp",
harmonize rewrite-includes and gn-format checks The CheckGeneratedFiles bot only required rewriting .gn files, while the presubmit wants both .gn and .gni files. It also appears that the #includes rewrite script runs on both the presubmit and CheckGeneratedFiles bots. These presubmits run on the CQ before landing right? If so, no need for them in the CheckGeneratedFIles bot at all. And of course, format .gni files. Change-Id: Icd4526d62f85088862ad93566cc9ace11dc3e33f Reviewed-on: https://skia-review.googlesource.com/c/skia/+/281505 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Mike Klein <mtklein@google.com>
2020-04-03 15:59:37 +00:00
"$_src/core/SkRemoteGlyphCache.h",
gypi -> gni: core, effects, android framework defines BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4023 Change-Id: I29a26c1716a319156a34a64999756ed7dba1e603 Reviewed-on: https://skia-review.googlesource.com/4023 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
2016-10-26 21:19:03 +00:00
"$_src/core/SkResourceCache.cpp",
Major refactor of runtime effects Adds SkRuntimeEffect, a ref-counted object to hold SkSL, a Compiler, and compiled Program, along with uniform info. Removes the old SkSLFP factory and factory cache types. Caching is done by simply holding on to the effect (or the shader/color filter factories, which own an effect). The effect class is simply ref'd by the factories, the shader and color filter types, and the FP. NOTE: Changes to public headers only affect private functions. Change-Id: I0c1401505cb234e83943ad4ef2db6680f4c69fb9 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/259336 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Brian Osman <brianosman@google.com>
2019-12-16 14:17:25 +00:00
"$_src/core/SkRuntimeEffect.cpp",
Add missing headers to .gn files. Change-Id: Id2f3ed80c76c4c409afdd2fa86c9b8e7fd1266ab Reviewed-on: https://skia-review.googlesource.com/c/skia/+/312485 Commit-Queue: John Stiles <johnstiles@google.com> Commit-Queue: Brian Osman <brianosman@google.com> Auto-Submit: John Stiles <johnstiles@google.com> Reviewed-by: Brian Osman <brianosman@google.com>
2020-08-21 16:52:03 +00:00
"$_src/core/SkSafeMath.h",
gypi -> gni: core, effects, android framework defines BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4023 Change-Id: I29a26c1716a319156a34a64999756ed7dba1e603 Reviewed-on: https://skia-review.googlesource.com/4023 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
2016-10-26 21:19:03 +00:00
"$_src/core/SkScalar.cpp",
harmonize rewrite-includes and gn-format checks The CheckGeneratedFiles bot only required rewriting .gn files, while the presubmit wants both .gn and .gni files. It also appears that the #includes rewrite script runs on both the presubmit and CheckGeneratedFiles bots. These presubmits run on the CQ before landing right? If so, no need for them in the CheckGeneratedFIles bot at all. And of course, format .gni files. Change-Id: Icd4526d62f85088862ad93566cc9ace11dc3e33f Reviewed-on: https://skia-review.googlesource.com/c/skia/+/281505 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Mike Klein <mtklein@google.com>
2020-04-03 15:59:37 +00:00
"$_src/core/SkScaleToSides.h",
Make SkStrikeCache::Node be SkStrike. SkStrike becomes SkScalerCache. It will eventually externalize the memory accounting to SkStrikeCache::Node because the amount of memory used by the scaler cache, and the overall strike cache memory usage must be kept in sync. Change-Id: Ia889f057d8138ec7f22f996e7ebb9d2441dea4ee Reviewed-on: https://skia-review.googlesource.com/c/skia/+/271018 Reviewed-by: Ben Wagner <bungeman@google.com>
2020-02-14 16:47:35 +00:00
"$_src/core/SkScalerCache.cpp",
"$_src/core/SkScalerCache.h",
gypi -> gni: core, effects, android framework defines BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4023 Change-Id: I29a26c1716a319156a34a64999756ed7dba1e603 Reviewed-on: https://skia-review.googlesource.com/4023 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
2016-10-26 21:19:03 +00:00
"$_src/core/SkScalerContext.cpp",
"$_src/core/SkScalerContext.h",
"$_src/core/SkScan.cpp",
"$_src/core/SkScan.h",
"$_src/core/SkScanPriv.h",
"$_src/core/SkScan_AAAPath.cpp",
"$_src/core/SkScan_AntiPath.cpp",
"$_src/core/SkScan_Antihair.cpp",
"$_src/core/SkScan_Hairline.cpp",
"$_src/core/SkScan_Path.cpp",
Revert "Revert "Add method to sk_gpu_test::TestContext to automatically restore the previous context."" This reverts commit 1e09e461d2ffcf8b07242cfe93dd7d12c4d75866. Change-Id: I95d5544a7baaa078536790493ce4119816a77e94 Reviewed-on: https://skia-review.googlesource.com/72903 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
2017-11-17 14:25:23 +00:00
"$_src/core/SkScopeExit.h",
gypi -> gni: core, effects, android framework defines BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4023 Change-Id: I29a26c1716a319156a34a64999756ed7dba1e603 Reviewed-on: https://skia-review.googlesource.com/4023 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
2016-10-26 21:19:03 +00:00
"$_src/core/SkSemaphore.cpp",
Revert "replace SkSharedMutex" This reverts commit cfdc07aa0ee75dd6daf1bb9a0787ba6f72438375. Reason for revert: nope, flutter windows bots don't have it. we got caught. Original change's description: > replace SkSharedMutex > > I am debugging an issue with SkSharedMutex and noticed > how sparsely it is used. That got me curious to see if > we can replace it with a std::shared_mutex (from C++17). > > Bug: skia:10177 > Change-Id: I1ce4d2a5897af198d6ae5fb850548ff917a58f50 > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/285691 > Reviewed-by: Ben Wagner <bungeman@google.com> > Commit-Queue: Mike Klein <mtklein@google.com> TBR=mtklein@google.com,bungeman@google.com,herb@google.com Change-Id: Iab4e55d749e386233ff0e2ba2c1cd10d5e6f1615 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: skia:10177 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/286124 Reviewed-by: Mike Klein <mtklein@google.com> Commit-Queue: Mike Klein <mtklein@google.com>
2020-04-29 18:50:26 +00:00
"$_src/core/SkSharedMutex.cpp",
"$_src/core/SkSharedMutex.h",
Pull SkSpan into its own header file Change-Id: I32d800c91794093973cb8128fd1b83b4aff91845 Reviewed-on: https://skia-review.googlesource.com/148672 Commit-Queue: Herb Derby <herb@google.com> Commit-Queue: Ben Wagner <bungeman@google.com> Reviewed-by: Ben Wagner <bungeman@google.com>
2018-08-22 18:19:04 +00:00
"$_src/core/SkSpan.h",
gypi -> gni: core, effects, android framework defines BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4023 Change-Id: I29a26c1716a319156a34a64999756ed7dba1e603 Reviewed-on: https://skia-review.googlesource.com/4023 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
2016-10-26 21:19:03 +00:00
"$_src/core/SkSpecialImage.cpp",
"$_src/core/SkSpecialImage.h",
"$_src/core/SkSpecialSurface.cpp",
"$_src/core/SkSpecialSurface.h",
"$_src/core/SkSpinlock.cpp",
harmonize rewrite-includes and gn-format checks The CheckGeneratedFiles bot only required rewriting .gn files, while the presubmit wants both .gn and .gni files. It also appears that the #includes rewrite script runs on both the presubmit and CheckGeneratedFiles bots. These presubmits run on the CQ before landing right? If so, no need for them in the CheckGeneratedFIles bot at all. And of course, format .gni files. Change-Id: Icd4526d62f85088862ad93566cc9ace11dc3e33f Reviewed-on: https://skia-review.googlesource.com/c/skia/+/281505 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Mike Klein <mtklein@google.com>
2020-04-03 15:59:37 +00:00
"$_src/core/SkSpriteBlitter.h",
gypi -> gni: core, effects, android framework defines BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4023 Change-Id: I29a26c1716a319156a34a64999756ed7dba1e603 Reviewed-on: https://skia-review.googlesource.com/4023 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
2016-10-26 21:19:03 +00:00
"$_src/core/SkSpriteBlitter_ARGB32.cpp",
experiments to speed up drawing 32bit images into 565 New (legacy style) blitters only coded for shaders (and very restricted blendmodes) Bug: skia: See https://buganizer.corp.google.com/issues/64884885 Change-Id: Ie2546093bfe1e670a825dfd9542d252d53732c40 Reviewed-on: https://skia-review.googlesource.com/54103 Commit-Queue: Mike Reed <reed@google.com> Reviewed-by: Herb Derby <herb@google.com>
2017-10-05 20:04:41 +00:00
"$_src/core/SkSpriteBlitter_RGB565.cpp",
gypi -> gni: core, effects, android framework defines BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4023 Change-Id: I29a26c1716a319156a34a64999756ed7dba1e603 Reviewed-on: https://skia-review.googlesource.com/4023 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
2016-10-26 21:19:03 +00:00
"$_src/core/SkStream.cpp",
"$_src/core/SkStreamPriv.h",
Reorganize strike cache and glyph cache code BUG=skia:7515 Change-Id: I05867890e88de7a7d23b60d9eec989d93d39d333 Reviewed-on: https://skia-review.googlesource.com/121783 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Herb Derby <herb@google.com>
2018-04-17 12:04:47 +00:00
"$_src/core/SkStrikeCache.cpp",
Rename SkGlyphCacheGlobals to SkStrikeCache Change-Id: I7773c1fff309bf9416f16fe9908191eeba94eb99 Reviewed-on: https://skia-review.googlesource.com/121356 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Herb Derby <herb@google.com>
2018-04-16 20:42:08 +00:00
"$_src/core/SkStrikeCache.h",
Restrict SkStrikeInterface to GPU and rename to SkStrikeForGPU SkStrikeInterface has become more and more focused on support of the GPU stack. Finishing this focus clears up some of the confusing parts of the Bitmap code. Remove use of SkStrikeInterface from the BitmapCode. Change-Id: I18a50d3ec17d81fcbe55030a3a3ec7eeeba23497 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/244297 Commit-Queue: Herb Derby <herb@google.com> Reviewed-by: Ben Wagner <bungeman@google.com>
2019-09-25 17:34:19 +00:00
"$_src/core/SkStrikeForGPU.cpp",
harmonize rewrite-includes and gn-format checks The CheckGeneratedFiles bot only required rewriting .gn files, while the presubmit wants both .gn and .gni files. It also appears that the #includes rewrite script runs on both the presubmit and CheckGeneratedFiles bots. These presubmits run on the CQ before landing right? If so, no need for them in the CheckGeneratedFIles bot at all. And of course, format .gni files. Change-Id: Icd4526d62f85088862ad93566cc9ace11dc3e33f Reviewed-on: https://skia-review.googlesource.com/c/skia/+/281505 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Mike Klein <mtklein@google.com>
2020-04-03 15:59:37 +00:00
"$_src/core/SkStrikeForGPU.h",
Introduce SkStrikeSpecStorage. SkStrikeSpecStorage is the centralized class for creating different sets of SkScalerContextRecs/Effects for different text rendering methods. It is initailly called SkStrikeSpecStorage, but as a last stage will be renamed to SkStrikeSpec as it encompasses the current functionality of the existing SkStrikeSpec. I'm breaking up a much larger prototype for this CL and several following CLs. The prototype is at: https://skia-review.googlesource.com/c/skia/+/209109 Change-Id: I617eaae6fcb4b0b29914c3f1a82c52c81d81aabe Reviewed-on: https://skia-review.googlesource.com/c/skia/+/212733 Commit-Queue: Herb Derby <herb@google.com> Reviewed-by: Mike Klein <mtklein@google.com>
2019-05-08 18:38:51 +00:00
"$_src/core/SkStrikeSpec.cpp",
"$_src/core/SkStrikeSpec.h",
gypi -> gni: core, effects, android framework defines BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4023 Change-Id: I29a26c1716a319156a34a64999756ed7dba1e603 Reviewed-on: https://skia-review.googlesource.com/4023 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
2016-10-26 21:19:03 +00:00
"$_src/core/SkString.cpp",
"$_src/core/SkStringUtils.cpp",
"$_src/core/SkStroke.cpp",
harmonize rewrite-includes and gn-format checks The CheckGeneratedFiles bot only required rewriting .gn files, while the presubmit wants both .gn and .gni files. It also appears that the #includes rewrite script runs on both the presubmit and CheckGeneratedFiles bots. These presubmits run on the CQ before landing right? If so, no need for them in the CheckGeneratedFIles bot at all. And of course, format .gni files. Change-Id: Icd4526d62f85088862ad93566cc9ace11dc3e33f Reviewed-on: https://skia-review.googlesource.com/c/skia/+/281505 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Mike Klein <mtklein@google.com>
2020-04-03 15:59:37 +00:00
"$_src/core/SkStroke.h",
gypi -> gni: core, effects, android framework defines BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4023 Change-Id: I29a26c1716a319156a34a64999756ed7dba1e603 Reviewed-on: https://skia-review.googlesource.com/4023 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
2016-10-26 21:19:03 +00:00
"$_src/core/SkStrokeRec.cpp",
"$_src/core/SkStrokerPriv.cpp",
"$_src/core/SkStrokerPriv.h",
Add SkSurfaceCharacterization operator== && != TBR=bsalomon@google.com Change-Id: Ic58849dcb3be1f00431f897af328f6f3c3f00d75 Reviewed-on: https://skia-review.googlesource.com/118340 Reviewed-by: Brian Salomon <bsalomon@google.com> Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com>
2018-04-04 15:12:39 +00:00
"$_src/core/SkSurfaceCharacterization.cpp",
gypi -> gni: core, effects, android framework defines BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4023 Change-Id: I29a26c1716a319156a34a64999756ed7dba1e603 Reviewed-on: https://skia-review.googlesource.com/4023 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
2016-10-26 21:19:03 +00:00
"$_src/core/SkSurfacePriv.h",
"$_src/core/SkSwizzle.cpp",
"$_src/core/SkTDPQueue.h",
"$_src/core/SkTDynamicHash.h",
harmonize rewrite-includes and gn-format checks The CheckGeneratedFiles bot only required rewriting .gn files, while the presubmit wants both .gn and .gni files. It also appears that the #includes rewrite script runs on both the presubmit and CheckGeneratedFiles bots. These presubmits run on the CQ before landing right? If so, no need for them in the CheckGeneratedFIles bot at all. And of course, format .gni files. Change-Id: Icd4526d62f85088862ad93566cc9ace11dc3e33f Reviewed-on: https://skia-review.googlesource.com/c/skia/+/281505 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Mike Klein <mtklein@google.com>
2020-04-03 15:59:37 +00:00
"$_src/core/SkTInternalLList.h",
"$_src/core/SkTLList.h",
"$_src/core/SkTLazy.h",
"$_src/core/SkTMultiMap.h",
"$_src/core/SkTSearch.cpp",
"$_src/core/SkTSearch.h",
Revert "Remove custom SkSort algorithms." This reverts commit 70474c1cb0bc19a025ee678161b633cf57b0a83e. Reason for revert: bot build failure Original change's description: > Remove custom SkSort algorithms. > > SortBench shows that SkTQSort and SkTHeapSort are inferior to std::sort. > The difference is small on randomized inputs, but quite significant for > semi-ordered inputs (forward/backward/repeated). There doesn't seem to > to be any compelling advantage to SkTQSort. > > Nanobench results: https://screenshot.googleplex.com/9JOLV1d6Z0u > > (These performance numbers are from an optimized build my local machine; > it's possible that we might see different results on the test bots.) > > Change-Id: Iaf19563041547eae7de2953be249129108f093b1 > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/302295 > Commit-Queue: John Stiles <johnstiles@google.com> > Reviewed-by: Mike Klein <mtklein@google.com> TBR=mtklein@google.com,brianosman@google.com,johnstiles@google.com Change-Id: I1126dd4cda95716dac225ad32d5b0e5cf3f09421 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://skia-review.googlesource.com/c/skia/+/302447 Reviewed-by: John Stiles <johnstiles@google.com> Commit-Queue: Mike Klein <mtklein@google.com>
2020-07-14 00:13:51 +00:00
"$_src/core/SkTSort.h",
harmonize rewrite-includes and gn-format checks The CheckGeneratedFiles bot only required rewriting .gn files, while the presubmit wants both .gn and .gni files. It also appears that the #includes rewrite script runs on both the presubmit and CheckGeneratedFiles bots. These presubmits run on the CQ before landing right? If so, no need for them in the CheckGeneratedFIles bot at all. And of course, format .gni files. Change-Id: Icd4526d62f85088862ad93566cc9ace11dc3e33f Reviewed-on: https://skia-review.googlesource.com/c/skia/+/281505 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Mike Klein <mtklein@google.com>
2020-04-03 15:59:37 +00:00
"$_src/core/SkTTopoSort.h",
"$_src/core/SkTaskGroup.cpp",
"$_src/core/SkTaskGroup.h",
gypi -> gni: core, effects, android framework defines BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4023 Change-Id: I29a26c1716a319156a34a64999756ed7dba1e603 Reviewed-on: https://skia-review.googlesource.com/4023 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
2016-10-26 21:19:03 +00:00
"$_src/core/SkTextBlob.cpp",
Filter TextBlob paints in Viewer. In particular this allows subpixel positioning to be forced for drawing. Change-Id: I2c88311f075944fef66fe5ba0237804aa5755800 Reviewed-on: https://skia-review.googlesource.com/156370 Reviewed-by: Herb Derby <herb@google.com> Commit-Queue: Ben Wagner <bungeman@google.com>
2018-09-24 17:01:54 +00:00
"$_src/core/SkTextBlobPriv.h",
SkRemoteGlyphCache Add tracing to diff canvas Use `extra_cflags=["-DSK_CAPTURE_DRAW_TEXT_BLOB"]` to enable. Change-Id: I1d6db478ee91696cdce090647b889c17a83a2718 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/250259 Commit-Queue: Hal Canary <halcanary@google.com> Reviewed-by: Herb Derby <herb@google.com>
2019-10-23 16:52:33 +00:00
"$_src/core/SkTextBlobTrace.cpp",
"$_src/core/SkTextBlobTrace.h",
gypi -> gni: core, effects, android framework defines BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4023 Change-Id: I29a26c1716a319156a34a64999756ed7dba1e603 Reviewed-on: https://skia-review.googlesource.com/4023 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
2016-10-26 21:19:03 +00:00
"$_src/core/SkTextFormatParams.h",
"$_src/core/SkThreadID.cpp",
harmonize rewrite-includes and gn-format checks The CheckGeneratedFiles bot only required rewriting .gn files, while the presubmit wants both .gn and .gni files. It also appears that the #includes rewrite script runs on both the presubmit and CheckGeneratedFiles bots. These presubmits run on the CQ before landing right? If so, no need for them in the CheckGeneratedFIles bot at all. And of course, format .gni files. Change-Id: Icd4526d62f85088862ad93566cc9ace11dc3e33f Reviewed-on: https://skia-review.googlesource.com/c/skia/+/281505 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Mike Klein <mtklein@google.com>
2020-04-03 15:59:37 +00:00
"$_src/core/SkTime.cpp",
gypi -> gni: core, effects, android framework defines BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4023 Change-Id: I29a26c1716a319156a34a64999756ed7dba1e603 Reviewed-on: https://skia-review.googlesource.com/4023 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
2016-10-26 21:19:03 +00:00
"$_src/core/SkTraceEvent.h",
"$_src/core/SkTraceEventCommon.h",
"$_src/core/SkTypeface.cpp",
"$_src/core/SkTypefaceCache.cpp",
"$_src/core/SkTypefaceCache.h",
harmonize rewrite-includes and gn-format checks The CheckGeneratedFiles bot only required rewriting .gn files, while the presubmit wants both .gn and .gni files. It also appears that the #includes rewrite script runs on both the presubmit and CheckGeneratedFiles bots. These presubmits run on the CQ before landing right? If so, no need for them in the CheckGeneratedFIles bot at all. And of course, format .gni files. Change-Id: Icd4526d62f85088862ad93566cc9ace11dc3e33f Reviewed-on: https://skia-review.googlesource.com/c/skia/+/281505 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Mike Klein <mtklein@google.com>
2020-04-03 15:59:37 +00:00
"$_src/core/SkTypeface_remote.cpp",
"$_src/core/SkTypeface_remote.h",
gypi -> gni: core, effects, android framework defines BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4023 Change-Id: I29a26c1716a319156a34a64999756ed7dba1e603 Reviewed-on: https://skia-review.googlesource.com/4023 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
2016-10-26 21:19:03 +00:00
"$_src/core/SkUnPreMultiply.cpp",
"$_src/core/SkUtils.cpp",
"$_src/core/SkUtils.h",
sketch an skvm With all the thinking around a stack-based interpreter, I figured I'd sketch out some ideas for a register VM too. I kind of have the hunch that this is the direction that will actually let us replace large amounts of Skia's CPU backend with an efficient interpreter or JIT. Change-Id: Ia2b5ba4a3fc27556f5b6ba95cd1ace46d3217403 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/216665 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Mike Klein <mtklein@google.com>
2019-05-29 17:57:54 +00:00
"$_src/core/SkVM.cpp",
"$_src/core/SkVM.h",
sketch SkVMBlitter I'm having a hard time implementing SkRasterPipeline with SkVM, so maybe it makes sense to try stepping over it instead? Have not done much timing, except that it's noticeably slower to generate GMs with this blitter turned on than turned off: use of uniforms is forcing us into the interpreter. I decided to start off with a perfect div255()... I'm curious to see if we can live with perfect instead of an approximation. Change-Id: I752f4a32ebe32ca550c9762aaad9ad86670b79d5 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/231117 Commit-Queue: Mike Klein <mtklein@google.com> Reviewed-by: Mike Reed <reed@google.com>
2019-07-31 17:37:00 +00:00
"$_src/core/SkVMBlitter.cpp",
harmonize rewrite-includes and gn-format checks The CheckGeneratedFiles bot only required rewriting .gn files, while the presubmit wants both .gn and .gni files. It also appears that the #includes rewrite script runs on both the presubmit and CheckGeneratedFiles bots. These presubmits run on the CQ before landing right? If so, no need for them in the CheckGeneratedFIles bot at all. And of course, format .gni files. Change-Id: Icd4526d62f85088862ad93566cc9ace11dc3e33f Reviewed-on: https://skia-review.googlesource.com/c/skia/+/281505 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Mike Klein <mtklein@google.com>
2020-04-03 15:59:37 +00:00
"$_src/core/SkVM_fwd.h",
gypi -> gni: core, effects, android framework defines BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4023 Change-Id: I29a26c1716a319156a34a64999756ed7dba1e603 Reviewed-on: https://skia-review.googlesource.com/4023 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
2016-10-26 21:19:03 +00:00
"$_src/core/SkValidationUtils.h",
"$_src/core/SkVertState.cpp",
harmonize rewrite-includes and gn-format checks The CheckGeneratedFiles bot only required rewriting .gn files, while the presubmit wants both .gn and .gni files. It also appears that the #includes rewrite script runs on both the presubmit and CheckGeneratedFiles bots. These presubmits run on the CQ before landing right? If so, no need for them in the CheckGeneratedFIles bot at all. And of course, format .gni files. Change-Id: Icd4526d62f85088862ad93566cc9ace11dc3e33f Reviewed-on: https://skia-review.googlesource.com/c/skia/+/281505 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Mike Klein <mtklein@google.com>
2020-04-03 15:59:37 +00:00
"$_src/core/SkVertices.cpp",
gypi -> gni: core, effects, android framework defines BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4023 Change-Id: I29a26c1716a319156a34a64999756ed7dba1e603 Reviewed-on: https://skia-review.googlesource.com/4023 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
2016-10-26 21:19:03 +00:00
"$_src/core/SkWriteBuffer.cpp",
"$_src/core/SkWriter32.cpp",
move SkWriter32.h to src Bug: skia: Change-Id: If110f1716d2ad3b967aadca1c61d3e22386e17b1 Reviewed-on: https://skia-review.googlesource.com/94862 Commit-Queue: Mike Reed <reed@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org> Reviewed-by: Mike Klein <mtklein@chromium.org>
2018-01-16 20:51:27 +00:00
"$_src/core/SkWriter32.h",
gypi -> gni: core, effects, android framework defines BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4023 Change-Id: I29a26c1716a319156a34a64999756ed7dba1e603 Reviewed-on: https://skia-review.googlesource.com/4023 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
2016-10-26 21:19:03 +00:00
"$_src/core/SkXfermode.cpp",
"$_src/core/SkXfermodeInterpretation.cpp",
"$_src/core/SkXfermodeInterpretation.h",
A new way to specify YUVA planar data from SkCodec to SkImage_Lazy Tunnels through SkImageGenerator as well. The new SkCodec interface doesn't assume three 8 bit planes. New SkYUVASpec more clearly defines chroma subsampling and siting of the planes. The intent is to use this for other YUVA APIs as well, in particular SkImage factories in the future. In this change we convert to the SkYUVASpec to SkYUVASizeInfo and SkYUVAIndex[4] representation. But the intent is to use the SkYUVASpec representation throughout the pipeline once legacy APIs are removed. orientation GM is replicated to test a variety of chroma subsampling configs. Bug: skia:10632 Change-Id: I3fad35752b87cac16c51b24824331f2ae7d458d3 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/309658 Commit-Queue: Brian Salomon <bsalomon@google.com> Reviewed-by: Robert Phillips <robertphillips@google.com> Reviewed-by: Leon Scroggins <scroggo@google.com>
2020-08-24 13:18:16 +00:00
"$_src/core/SkYUVAInfo.cpp",
New helpers for SkYUVAInfo when used with pixmaps. SkYUVAPixmapInfo is a SkYUVAInfo with per-plane color types and row bytes. It describes a set of pixmaps that make up a planar image. Consolidates validity checks of the SkYUVAInfo with the color types and row bytes. It can provide SkImageInfos for each plane and also assist with configuring planes to share a common allocation. SkYUVAPixmaps is a collection of SkPixmaps that are valid for a SkYUVAInfo. It can either wrap existing SkPixmaps or allocate and own the memory. It consolidates validity checking of SkPixmaps with the SkYUVAInfo. Replaces sk_gpu_test::YUVAPixmaps. Minor tweaks to SkYUVAInfo naming, parameter order consistency, adds a hasAlpha() method. Bug: skia:10632 Change-Id: Ib0f48b8448fff22805fd0c04e07887d0b7338b76 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/312886 Commit-Queue: Brian Salomon <bsalomon@google.com> Reviewed-by: Robert Phillips <robertphillips@google.com> Reviewed-by: Leon Scroggins <scroggo@google.com>
2020-08-27 15:00:04 +00:00
"$_src/core/SkYUVAPixmaps.cpp",
Replace use of SkYUVSizeInfo with SkYUVASizeInfo Bug: skia:7903 Change-Id: If5acd50711ed8bd4a49efcb93db66fd3d14c8992 Reviewed-on: https://skia-review.googlesource.com/c/164681 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Jim Van Verth <jvanverth@google.com>
2018-10-29 20:26:02 +00:00
"$_src/core/SkYUVASizeInfo.cpp",
split RGB into YUV planes Change-Id: Ifd1d010068691e187561a25aff45d8b67ae62c39 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/215442 Commit-Queue: Mike Reed <reed@google.com> Reviewed-by: Robert Phillips <robertphillips@google.com>
2019-05-23 19:30:07 +00:00
"$_src/core/SkYUVMath.cpp",
harmonize rewrite-includes and gn-format checks The CheckGeneratedFiles bot only required rewriting .gn files, while the presubmit wants both .gn and .gni files. It also appears that the #includes rewrite script runs on both the presubmit and CheckGeneratedFiles bots. These presubmits run on the CQ before landing right? If so, no need for them in the CheckGeneratedFIles bot at all. And of course, format .gni files. Change-Id: Icd4526d62f85088862ad93566cc9ace11dc3e33f Reviewed-on: https://skia-review.googlesource.com/c/skia/+/281505 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Mike Klein <mtklein@google.com>
2020-04-03 15:59:37 +00:00
"$_src/core/SkYUVPlanesCache.cpp",
"$_src/core/SkYUVPlanesCache.h",
Reland "SkZip - synchronized indexing of several pointers" This is a reland of f3c4a829c64f6ef2177f86603366c6df9fe801e1 Original change's description: > SkZip - synchronized indexing of several pointers > > This is the mechanism for syncing a bunch of things with > contiguous memory like vector<>, array<> and SkSpan<>. > > In a following CL, a convenience function SkMakeZip will > easily convert most containers into a zip. > > Change-Id: Icda5b1774ae21c4c163a663f6d2b0f119f63ccba > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/240200 > Commit-Queue: Herb Derby <herb@google.com> > Reviewed-by: Ben Wagner <bungeman@google.com> Change-Id: I7d1a91a9c35dde721147bb3c1f23c9b3a8d59d04 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/242476 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Herb Derby <herb@google.com>
2019-09-09 15:36:39 +00:00
"$_src/core/SkZip.h",
gypi -> gni: core, effects, android framework defines BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4023 Change-Id: I29a26c1716a319156a34a64999756ed7dba1e603 Reviewed-on: https://skia-review.googlesource.com/4023 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
2016-10-26 21:19:03 +00:00
"$_src/image/SkImage.cpp",
harmonize rewrite-includes and gn-format checks The CheckGeneratedFiles bot only required rewriting .gn files, while the presubmit wants both .gn and .gni files. It also appears that the #includes rewrite script runs on both the presubmit and CheckGeneratedFiles bots. These presubmits run on the CQ before landing right? If so, no need for them in the CheckGeneratedFIles bot at all. And of course, format .gni files. Change-Id: Icd4526d62f85088862ad93566cc9ace11dc3e33f Reviewed-on: https://skia-review.googlesource.com/c/skia/+/281505 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Mike Klein <mtklein@google.com>
2020-04-03 15:59:37 +00:00
"$_src/lazy/SkDiscardableMemoryPool.cpp",
gypi -> gni: core, effects, android framework defines BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4023 Change-Id: I29a26c1716a319156a34a64999756ed7dba1e603 Reviewed-on: https://skia-review.googlesource.com/4023 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
2016-10-26 21:19:03 +00:00
# "$_src/image/SkImage_Gpu.cpp",
Rename SkImage_Generator to SkImage_Lazy This removes a long-standing source of confusion: SkImage_Generator was an image that wrapped an SkImageGenerator (with an SkImageCacherator stuck in the middle). We could choose to rename either one, but SkImageGenerator is public, so take the easy road and rename the private image subclass. Given the existence of SkImage::isLazyGenerated, this name seems appropriate. Bug: skia: Change-Id: I061ece94f48538efb1dc5548010f6ca7d438a69b Reviewed-on: https://skia-review.googlesource.com/13979 Reviewed-by: Matt Sarett <msarett@google.com> Commit-Queue: Brian Osman <brianosman@google.com>
2017-04-20 17:43:23 +00:00
"$_src/image/SkImage_Lazy.cpp",
Remove SkImageCacherator entirely It was just the slice of SkImage_Lazy's API that we needed to expose to GrImageTextureMaker. Instead, give SkImage_Lazy a header, so that the maker can use it directly. Change-Id: Iea6198f63e8065b8c987f7c07f3222409cdda439 Reviewed-on: https://skia-review.googlesource.com/153546 Reviewed-by: Mike Klein <mtklein@google.com> Commit-Queue: Brian Osman <brianosman@google.com>
2018-09-11 14:03:19 +00:00
"$_src/image/SkImage_Lazy.h",
gypi -> gni: core, effects, android framework defines BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4023 Change-Id: I29a26c1716a319156a34a64999756ed7dba1e603 Reviewed-on: https://skia-review.googlesource.com/4023 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
2016-10-26 21:19:03 +00:00
"$_src/image/SkImage_Raster.cpp",
Reland "Add async rescale and read APIs to SkImage." This reverts commit 1caf3789f8c6e7e8d50f08cd56a5b725922aa044. Makes the image GMs detect an abandoned context just like the surface GMs. Bug: skia:10431 Change-Id: I56a3631a75e6b0383f96a73f461cfa314ee29afa Reviewed-on: https://skia-review.googlesource.com/c/skia/+/299379 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
2020-06-26 17:32:09 +00:00
"$_src/image/SkRescaleAndReadPixels.cpp",
"$_src/image/SkRescaleAndReadPixels.h",
gypi -> gni: core, effects, android framework defines BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4023 Change-Id: I29a26c1716a319156a34a64999756ed7dba1e603 Reviewed-on: https://skia-review.googlesource.com/4023 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
2016-10-26 21:19:03 +00:00
"$_src/image/SkSurface.cpp",
"$_src/image/SkSurface_Base.h",
# "$_src/image/SkSurface_Gpu.cpp",
"$_src/image/SkSurface_Raster.cpp",
harmonize rewrite-includes and gn-format checks The CheckGeneratedFiles bot only required rewriting .gn files, while the presubmit wants both .gn and .gni files. It also appears that the #includes rewrite script runs on both the presubmit and CheckGeneratedFiles bots. These presubmits run on the CQ before landing right? If so, no need for them in the CheckGeneratedFIles bot at all. And of course, format .gni files. Change-Id: Icd4526d62f85088862ad93566cc9ace11dc3e33f Reviewed-on: https://skia-review.googlesource.com/c/skia/+/281505 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Mike Klein <mtklein@google.com>
2020-04-03 15:59:37 +00:00
"$_src/opts/SkBlitMask_opts.h",
"$_src/opts/SkBlitRow_opts.h",
"$_src/opts/SkChecksum_opts.h",
"$_src/opts/SkRasterPipeline_opts.h",
"$_src/opts/SkSwizzler_opts.h",
"$_src/opts/SkUtils_opts.h",
Add missing headers to .gn files. Change-Id: Id2f3ed80c76c4c409afdd2fa86c9b8e7fd1266ab Reviewed-on: https://skia-review.googlesource.com/c/skia/+/312485 Commit-Queue: John Stiles <johnstiles@google.com> Commit-Queue: Brian Osman <brianosman@google.com> Auto-Submit: John Stiles <johnstiles@google.com> Reviewed-by: Brian Osman <brianosman@google.com>
2020-08-21 16:52:03 +00:00
"$_src/opts/SkVM_opts.h",
harmonize rewrite-includes and gn-format checks The CheckGeneratedFiles bot only required rewriting .gn files, while the presubmit wants both .gn and .gni files. It also appears that the #includes rewrite script runs on both the presubmit and CheckGeneratedFiles bots. These presubmits run on the CQ before landing right? If so, no need for them in the CheckGeneratedFIles bot at all. And of course, format .gni files. Change-Id: Icd4526d62f85088862ad93566cc9ace11dc3e33f Reviewed-on: https://skia-review.googlesource.com/c/skia/+/281505 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Mike Klein <mtklein@google.com>
2020-04-03 15:59:37 +00:00
"$_src/opts/SkXfermode_opts.h",
[Reland] Relocate shaders to own dir Consolidate all shader impls under src/shaders/. (reland of https://skia-review.googlesource.com/c/17927/) Change-Id: I7918bdc1aafe842ed194412ba95b9ae53a2ec1d7 Reviewed-on: https://skia-review.googlesource.com/18146 Reviewed-by: Florin Malita <fmalita@chromium.org> Commit-Queue: Florin Malita <fmalita@chromium.org>
2017-05-30 20:39:47 +00:00
"$_src/shaders/SkBitmapProcShader.cpp",
"$_src/shaders/SkBitmapProcShader.h",
"$_src/shaders/SkColorFilterShader.cpp",
"$_src/shaders/SkColorFilterShader.h",
"$_src/shaders/SkColorShader.cpp",
"$_src/shaders/SkColorShader.h",
"$_src/shaders/SkComposeShader.cpp",
"$_src/shaders/SkComposeShader.h",
"$_src/shaders/SkEmptyShader.h",
"$_src/shaders/SkImageShader.cpp",
"$_src/shaders/SkImageShader.h",
"$_src/shaders/SkLocalMatrixShader.cpp",
"$_src/shaders/SkLocalMatrixShader.h",
"$_src/shaders/SkShader.cpp",
"$_src/shaders/SkShaderBase.h",
gypi -> gni: core, effects, android framework defines BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4023 Change-Id: I29a26c1716a319156a34a64999756ed7dba1e603 Reviewed-on: https://skia-review.googlesource.com/4023 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
2016-10-26 21:19:03 +00:00
# private
"$_include/private/SkChecksum.h",
Add SkColorData.h to gn. Allows IDEs to find it, brings us a bit closer to getting gn check to work. Change-Id: I1e0c8d01f272c41c97dbbf40402b64f44a6c3c48 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/249421 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Ben Wagner <bungeman@google.com>
2019-10-18 14:26:45 +00:00
"$_include/private/SkColorData.h",
move SkDeque.h into private Perhaps just make this SkTStack... Change-Id: Iefdbb1e33acec96aec5f885e3e16ac2d97fd5f73 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/271320 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Reed <reed@google.com>
2020-02-17 21:51:14 +00:00
"$_include/private/SkDeque.h",
gypi -> gni: core, effects, android framework defines BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4023 Change-Id: I29a26c1716a319156a34a64999756ed7dba1e603 Reviewed-on: https://skia-review.googlesource.com/4023 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
2016-10-26 21:19:03 +00:00
"$_include/private/SkFixed.h",
"$_include/private/SkFloatBits.h",
"$_include/private/SkFloatingPoint.h",
Move files in GN Change-Id: I9873a1fb6e72cc0d567bb994b11c1af493ad3dd4 Reviewed-on: https://skia-review.googlesource.com/c/165901 Commit-Queue: Herb Derby <herb@google.com> Commit-Queue: Mike Klein <mtklein@google.com> Reviewed-by: Mike Klein <mtklein@google.com>
2018-10-29 17:17:34 +00:00
"$_include/private/SkHalf.h",
Prevent unbounded listener growth on SkPixelRefs. Use SkIDChangeListener and update GrBitmapTextureMaker to add listener to key to deregister if texture is purged before genID changes. Add a common listener list implementation and replace existing lists. Change-Id: Ib0c78241eaf59b59b892d8b004b2bb095140bc6d Reviewed-on: https://skia-review.googlesource.com/c/skia/+/274549 Commit-Queue: Brian Salomon <bsalomon@google.com> Reviewed-by: Brian Osman <brianosman@google.com>
2020-03-02 21:59:40 +00:00
"$_include/private/SkIDChangeListener.h",
Remove SK_REQUIRE_LOCAL_VAR macro. The ClangTidy check `bugprone-unused-raii` has been enabled at review.skia.org/306838; this check provides equivalent protection. Change-Id: I9f3858bfd2bede107d509a5a206a08293d5f914c Reviewed-on: https://skia-review.googlesource.com/c/skia/+/306953 Reviewed-by: Mike Klein <mtklein@google.com> Commit-Queue: Mike Klein <mtklein@google.com> Auto-Submit: John Stiles <johnstiles@google.com>
2020-07-31 01:48:57 +00:00
"$_include/private/SkMacros.h",
Change SkMemory to the more accurately named SkMalloc. Change-Id: I6b08a74234b99bac866bad71014b94f7ec2d4bc8 Reviewed-on: https://skia-review.googlesource.com/10188 Commit-Queue: Herb Derby <herb@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com>
2017-03-27 17:35:15 +00:00
"$_include/private/SkMalloc.h",
gypi -> gni: core, effects, android framework defines BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4023 Change-Id: I29a26c1716a319156a34a64999756ed7dba1e603 Reviewed-on: https://skia-review.googlesource.com/4023 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
2016-10-26 21:19:03 +00:00
"$_include/private/SkMutex.h",
Move SkNoncopyable to include/private. Change-Id: I62f60ea52faeebddecacf03d9429ac3f7c516b8e Reviewed-on: https://skia-review.googlesource.com/141823 Commit-Queue: Ben Wagner <bungeman@google.com> Reviewed-by: Ben Wagner <bungeman@google.com>
2018-07-16 21:44:06 +00:00
"$_include/private/SkNoncopyable.h",
Move files in GN Change-Id: I9873a1fb6e72cc0d567bb994b11c1af493ad3dd4 Reviewed-on: https://skia-review.googlesource.com/c/165901 Commit-Queue: Herb Derby <herb@google.com> Commit-Queue: Mike Klein <mtklein@google.com> Reviewed-by: Mike Klein <mtklein@google.com>
2018-10-29 17:17:34 +00:00
"$_include/private/SkNx.h",
"$_include/private/SkNx_neon.h",
"$_include/private/SkNx_sse.h",
gypi -> gni: core, effects, android framework defines BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4023 Change-Id: I29a26c1716a319156a34a64999756ed7dba1e603 Reviewed-on: https://skia-review.googlesource.com/4023 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
2016-10-26 21:19:03 +00:00
"$_include/private/SkOnce.h",
move SkPathRef.h into private Bug: skia: Change-Id: I3370c594301ae833ec1fe3cb16ac544e5b2128e8 Reviewed-on: https://skia-review.googlesource.com/18982 Commit-Queue: Mike Reed <reed@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com>
2017-06-07 14:57:22 +00:00
"$_include/private/SkPathRef.h",
gypi -> gni: core, effects, android framework defines BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4023 Change-Id: I29a26c1716a319156a34a64999756ed7dba1e603 Reviewed-on: https://skia-review.googlesource.com/4023 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
2016-10-26 21:19:03 +00:00
"$_include/private/SkSemaphore.h",
Split ShadowMaskFilter into separate ambient and spot mask filters This does not change the public API. BUG=skia:6119 Change-Id: Ibdcd2f8611bc2eec332d8a65e5d51246b89a0a90 Reviewed-on: https://skia-review.googlesource.com/7083 Commit-Queue: Jim Van Verth <jvanverth@google.com> Reviewed-by: Jim Van Verth <jvanverth@google.com> Reviewed-by: Robert Phillips <robertphillips@google.com>
2017-01-16 18:03:37 +00:00
"$_include/private/SkShadowFlags.h",
gypi -> gni: core, effects, android framework defines BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4023 Change-Id: I29a26c1716a319156a34a64999756ed7dba1e603 Reviewed-on: https://skia-review.googlesource.com/4023 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
2016-10-26 21:19:03 +00:00
"$_include/private/SkSpinlock.h",
"$_include/private/SkTArray.h",
"$_include/private/SkTDArray.h",
"$_include/private/SkTFitsIn.h",
"$_include/private/SkTHash.h",
harmonize rewrite-includes and gn-format checks The CheckGeneratedFiles bot only required rewriting .gn files, while the presubmit wants both .gn and .gni files. It also appears that the #includes rewrite script runs on both the presubmit and CheckGeneratedFiles bots. These presubmits run on the CQ before landing right? If so, no need for them in the CheckGeneratedFIles bot at all. And of course, format .gni files. Change-Id: Icd4526d62f85088862ad93566cc9ace11dc3e33f Reviewed-on: https://skia-review.googlesource.com/c/skia/+/281505 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Mike Klein <mtklein@google.com>
2020-04-03 15:59:37 +00:00
"$_include/private/SkTLogic.h",
"$_include/private/SkTemplates.h",
Add thread safety annotations. Start out with spinlock. I tried to be more extensive, but some of our abstractions confused the analysis. Will expand further in following CLs. Change-Id: I3e320c957d8ef427065a2b7e7d2187b7c6b0aef1 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/213060 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Herb Derby <herb@google.com>
2019-05-09 20:59:18 +00:00
"$_include/private/SkThreadAnnotations.h",
gypi -> gni: core, effects, android framework defines BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4023 Change-Id: I29a26c1716a319156a34a64999756ed7dba1e603 Reviewed-on: https://skia-review.googlesource.com/4023 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
2016-10-26 21:19:03 +00:00
"$_include/private/SkThreadID.h",
Add SkVx.h to core.gni Trying to run Chrome trybots on changes to SkVx.h, but it's deciding to skip the build... Change-Id: Ic40cc2eec5db00c4f6eacc72e0e50101a8478e99 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/317596 Reviewed-by: Mike Klein <mtklein@google.com> Commit-Queue: Mike Klein <mtklein@google.com>
2020-09-17 14:58:03 +00:00
"$_include/private/SkVx.h",
gypi -> gni: core, effects, android framework defines BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4023 Change-Id: I29a26c1716a319156a34a64999756ed7dba1e603 Reviewed-on: https://skia-review.googlesource.com/4023 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
2016-10-26 21:19:03 +00:00
"$_include/private/SkWeakRefCnt.h",
Have pathkit use libpathkit.a for faster builds Of note, it is very important for the -DSK_RELEASE/-DSK_DEBUG to match between libskia.a and the WASM bindings, otherwise things like SKDEBUGCODE are sometimes compiled in and sometimes not, which can cause headaches like sizeof() mismatching between .cpp files and .h files. Bug: skia: Change-Id: Id6ef58c44a7c10014a243b36708e0891514f6008 Reviewed-on: https://skia-review.googlesource.com/158341 Reviewed-by: Mike Klein <mtklein@google.com>
2018-10-02 13:02:18 +00:00
]
gypi -> gni: core, effects, android framework defines BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4023 Change-Id: I29a26c1716a319156a34a64999756ed7dba1e603 Reviewed-on: https://skia-review.googlesource.com/4023 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
2016-10-26 21:19:03 +00:00
Remove SkColorSpaceXformCanvas, and supporting code: - SkColorSpaceXformer - makeColorSpace on SkShader, SkColorFilter, SkImageFilter, SkDrawLooper, and SkLights - DM support and some bot configs Bug: skia:8773 Change-Id: I16ef8f487de6c35329b3b0474c1d66d7fa0a6220 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/202430 Commit-Queue: Brian Osman <brianosman@google.com> Reviewed-by: Mike Klein <mtklein@google.com> Reviewed-by: Mike Reed <reed@google.com>
2019-03-21 16:35:02 +00:00
skia_pathops_public = [ "$_include/pathops/SkPathOps.h" ]
gypi -> gni: core, effects, android framework defines BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4023 Change-Id: I29a26c1716a319156a34a64999756ed7dba1e603 Reviewed-on: https://skia-review.googlesource.com/4023 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
2016-10-26 21:19:03 +00:00
GN: split out skia_*_public from skia_*_sources `gn check` passes. We will work towards removing `check_includes = false`. Change-Id: I0ab396fadaf31a166921bdea334b2cfedca23dcd Reviewed-on: https://skia-review.googlesource.com/c/skia/+/195363 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Hal Canary <halcanary@google.com>
2019-02-26 16:54:25 +00:00
skia_pathops_sources = [
gypi -> gni: core, effects, android framework defines BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4023 Change-Id: I29a26c1716a319156a34a64999756ed7dba1e603 Reviewed-on: https://skia-review.googlesource.com/4023 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
2016-10-26 21:19:03 +00:00
"$_src/pathops/SkAddIntersections.cpp",
harmonize rewrite-includes and gn-format checks The CheckGeneratedFiles bot only required rewriting .gn files, while the presubmit wants both .gn and .gni files. It also appears that the #includes rewrite script runs on both the presubmit and CheckGeneratedFiles bots. These presubmits run on the CQ before landing right? If so, no need for them in the CheckGeneratedFIles bot at all. And of course, format .gni files. Change-Id: Icd4526d62f85088862ad93566cc9ace11dc3e33f Reviewed-on: https://skia-review.googlesource.com/c/skia/+/281505 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Mike Klein <mtklein@google.com>
2020-04-03 15:59:37 +00:00
"$_src/pathops/SkAddIntersections.h",
gypi -> gni: core, effects, android framework defines BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4023 Change-Id: I29a26c1716a319156a34a64999756ed7dba1e603 Reviewed-on: https://skia-review.googlesource.com/4023 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
2016-10-26 21:19:03 +00:00
"$_src/pathops/SkDConicLineIntersection.cpp",
"$_src/pathops/SkDCubicLineIntersection.cpp",
"$_src/pathops/SkDCubicToQuads.cpp",
"$_src/pathops/SkDLineIntersection.cpp",
"$_src/pathops/SkDQuadLineIntersection.cpp",
harmonize rewrite-includes and gn-format checks The CheckGeneratedFiles bot only required rewriting .gn files, while the presubmit wants both .gn and .gni files. It also appears that the #includes rewrite script runs on both the presubmit and CheckGeneratedFiles bots. These presubmits run on the CQ before landing right? If so, no need for them in the CheckGeneratedFIles bot at all. And of course, format .gni files. Change-Id: Icd4526d62f85088862ad93566cc9ace11dc3e33f Reviewed-on: https://skia-review.googlesource.com/c/skia/+/281505 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Mike Klein <mtklein@google.com>
2020-04-03 15:59:37 +00:00
"$_src/pathops/SkIntersectionHelper.h",
gypi -> gni: core, effects, android framework defines BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4023 Change-Id: I29a26c1716a319156a34a64999756ed7dba1e603 Reviewed-on: https://skia-review.googlesource.com/4023 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
2016-10-26 21:19:03 +00:00
"$_src/pathops/SkIntersections.cpp",
harmonize rewrite-includes and gn-format checks The CheckGeneratedFiles bot only required rewriting .gn files, while the presubmit wants both .gn and .gni files. It also appears that the #includes rewrite script runs on both the presubmit and CheckGeneratedFiles bots. These presubmits run on the CQ before landing right? If so, no need for them in the CheckGeneratedFIles bot at all. And of course, format .gni files. Change-Id: Icd4526d62f85088862ad93566cc9ace11dc3e33f Reviewed-on: https://skia-review.googlesource.com/c/skia/+/281505 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Mike Klein <mtklein@google.com>
2020-04-03 15:59:37 +00:00
"$_src/pathops/SkIntersections.h",
"$_src/pathops/SkLineParameters.h",
gypi -> gni: core, effects, android framework defines BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4023 Change-Id: I29a26c1716a319156a34a64999756ed7dba1e603 Reviewed-on: https://skia-review.googlesource.com/4023 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
2016-10-26 21:19:03 +00:00
"$_src/pathops/SkOpAngle.cpp",
harmonize rewrite-includes and gn-format checks The CheckGeneratedFiles bot only required rewriting .gn files, while the presubmit wants both .gn and .gni files. It also appears that the #includes rewrite script runs on both the presubmit and CheckGeneratedFiles bots. These presubmits run on the CQ before landing right? If so, no need for them in the CheckGeneratedFIles bot at all. And of course, format .gni files. Change-Id: Icd4526d62f85088862ad93566cc9ace11dc3e33f Reviewed-on: https://skia-review.googlesource.com/c/skia/+/281505 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Mike Klein <mtklein@google.com>
2020-04-03 15:59:37 +00:00
"$_src/pathops/SkOpAngle.h",
gypi -> gni: core, effects, android framework defines BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4023 Change-Id: I29a26c1716a319156a34a64999756ed7dba1e603 Reviewed-on: https://skia-review.googlesource.com/4023 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
2016-10-26 21:19:03 +00:00
"$_src/pathops/SkOpBuilder.cpp",
"$_src/pathops/SkOpCoincidence.cpp",
harmonize rewrite-includes and gn-format checks The CheckGeneratedFiles bot only required rewriting .gn files, while the presubmit wants both .gn and .gni files. It also appears that the #includes rewrite script runs on both the presubmit and CheckGeneratedFiles bots. These presubmits run on the CQ before landing right? If so, no need for them in the CheckGeneratedFIles bot at all. And of course, format .gni files. Change-Id: Icd4526d62f85088862ad93566cc9ace11dc3e33f Reviewed-on: https://skia-review.googlesource.com/c/skia/+/281505 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Mike Klein <mtklein@google.com>
2020-04-03 15:59:37 +00:00
"$_src/pathops/SkOpCoincidence.h",
gypi -> gni: core, effects, android framework defines BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4023 Change-Id: I29a26c1716a319156a34a64999756ed7dba1e603 Reviewed-on: https://skia-review.googlesource.com/4023 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
2016-10-26 21:19:03 +00:00
"$_src/pathops/SkOpContour.cpp",
harmonize rewrite-includes and gn-format checks The CheckGeneratedFiles bot only required rewriting .gn files, while the presubmit wants both .gn and .gni files. It also appears that the #includes rewrite script runs on both the presubmit and CheckGeneratedFiles bots. These presubmits run on the CQ before landing right? If so, no need for them in the CheckGeneratedFIles bot at all. And of course, format .gni files. Change-Id: Icd4526d62f85088862ad93566cc9ace11dc3e33f Reviewed-on: https://skia-review.googlesource.com/c/skia/+/281505 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Mike Klein <mtklein@google.com>
2020-04-03 15:59:37 +00:00
"$_src/pathops/SkOpContour.h",
gypi -> gni: core, effects, android framework defines BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4023 Change-Id: I29a26c1716a319156a34a64999756ed7dba1e603 Reviewed-on: https://skia-review.googlesource.com/4023 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
2016-10-26 21:19:03 +00:00
"$_src/pathops/SkOpCubicHull.cpp",
"$_src/pathops/SkOpEdgeBuilder.cpp",
harmonize rewrite-includes and gn-format checks The CheckGeneratedFiles bot only required rewriting .gn files, while the presubmit wants both .gn and .gni files. It also appears that the #includes rewrite script runs on both the presubmit and CheckGeneratedFiles bots. These presubmits run on the CQ before landing right? If so, no need for them in the CheckGeneratedFIles bot at all. And of course, format .gni files. Change-Id: Icd4526d62f85088862ad93566cc9ace11dc3e33f Reviewed-on: https://skia-review.googlesource.com/c/skia/+/281505 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Mike Klein <mtklein@google.com>
2020-04-03 15:59:37 +00:00
"$_src/pathops/SkOpEdgeBuilder.h",
gypi -> gni: core, effects, android framework defines BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4023 Change-Id: I29a26c1716a319156a34a64999756ed7dba1e603 Reviewed-on: https://skia-review.googlesource.com/4023 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
2016-10-26 21:19:03 +00:00
"$_src/pathops/SkOpSegment.cpp",
harmonize rewrite-includes and gn-format checks The CheckGeneratedFiles bot only required rewriting .gn files, while the presubmit wants both .gn and .gni files. It also appears that the #includes rewrite script runs on both the presubmit and CheckGeneratedFiles bots. These presubmits run on the CQ before landing right? If so, no need for them in the CheckGeneratedFIles bot at all. And of course, format .gni files. Change-Id: Icd4526d62f85088862ad93566cc9ace11dc3e33f Reviewed-on: https://skia-review.googlesource.com/c/skia/+/281505 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Mike Klein <mtklein@google.com>
2020-04-03 15:59:37 +00:00
"$_src/pathops/SkOpSegment.h",
gypi -> gni: core, effects, android framework defines BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4023 Change-Id: I29a26c1716a319156a34a64999756ed7dba1e603 Reviewed-on: https://skia-review.googlesource.com/4023 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
2016-10-26 21:19:03 +00:00
"$_src/pathops/SkOpSpan.cpp",
harmonize rewrite-includes and gn-format checks The CheckGeneratedFiles bot only required rewriting .gn files, while the presubmit wants both .gn and .gni files. It also appears that the #includes rewrite script runs on both the presubmit and CheckGeneratedFiles bots. These presubmits run on the CQ before landing right? If so, no need for them in the CheckGeneratedFIles bot at all. And of course, format .gni files. Change-Id: Icd4526d62f85088862ad93566cc9ace11dc3e33f Reviewed-on: https://skia-review.googlesource.com/c/skia/+/281505 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Mike Klein <mtklein@google.com>
2020-04-03 15:59:37 +00:00
"$_src/pathops/SkOpSpan.h",
fixup winding contours Add AsWinding to convert SkPath with even odd fill to winding fill. This basic implementation works for simple non-intersecting paths. It may fail if contours in paths touch, specifically when the leftmost point in a contour is shared with another contour. The incomplete parts are marked with TODO in the code. If this interface and implementation look promising, I will continue to tackle the more difficult cases. R=reed@google.com,bungeman@google.com Bug: skia:7682 Change-Id: I479fba60072eb1391b451fcb819504245da2e2a9 Reviewed-on: https://skia-review.googlesource.com/147044 Commit-Queue: Cary Clark <caryclark@google.com> Reviewed-by: Mike Reed <reed@google.com>
2018-08-16 15:53:54 +00:00
"$_src/pathops/SkPathOpsAsWinding.cpp",
harmonize rewrite-includes and gn-format checks The CheckGeneratedFiles bot only required rewriting .gn files, while the presubmit wants both .gn and .gni files. It also appears that the #includes rewrite script runs on both the presubmit and CheckGeneratedFiles bots. These presubmits run on the CQ before landing right? If so, no need for them in the CheckGeneratedFIles bot at all. And of course, format .gni files. Change-Id: Icd4526d62f85088862ad93566cc9ace11dc3e33f Reviewed-on: https://skia-review.googlesource.com/c/skia/+/281505 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Mike Klein <mtklein@google.com>
2020-04-03 15:59:37 +00:00
"$_src/pathops/SkPathOpsBounds.h",
gypi -> gni: core, effects, android framework defines BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4023 Change-Id: I29a26c1716a319156a34a64999756ed7dba1e603 Reviewed-on: https://skia-review.googlesource.com/4023 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
2016-10-26 21:19:03 +00:00
"$_src/pathops/SkPathOpsCommon.cpp",
harmonize rewrite-includes and gn-format checks The CheckGeneratedFiles bot only required rewriting .gn files, while the presubmit wants both .gn and .gni files. It also appears that the #includes rewrite script runs on both the presubmit and CheckGeneratedFiles bots. These presubmits run on the CQ before landing right? If so, no need for them in the CheckGeneratedFIles bot at all. And of course, format .gni files. Change-Id: Icd4526d62f85088862ad93566cc9ace11dc3e33f Reviewed-on: https://skia-review.googlesource.com/c/skia/+/281505 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Mike Klein <mtklein@google.com>
2020-04-03 15:59:37 +00:00
"$_src/pathops/SkPathOpsCommon.h",
gypi -> gni: core, effects, android framework defines BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4023 Change-Id: I29a26c1716a319156a34a64999756ed7dba1e603 Reviewed-on: https://skia-review.googlesource.com/4023 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
2016-10-26 21:19:03 +00:00
"$_src/pathops/SkPathOpsConic.cpp",
harmonize rewrite-includes and gn-format checks The CheckGeneratedFiles bot only required rewriting .gn files, while the presubmit wants both .gn and .gni files. It also appears that the #includes rewrite script runs on both the presubmit and CheckGeneratedFiles bots. These presubmits run on the CQ before landing right? If so, no need for them in the CheckGeneratedFIles bot at all. And of course, format .gni files. Change-Id: Icd4526d62f85088862ad93566cc9ace11dc3e33f Reviewed-on: https://skia-review.googlesource.com/c/skia/+/281505 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Mike Klein <mtklein@google.com>
2020-04-03 15:59:37 +00:00
"$_src/pathops/SkPathOpsConic.h",
gypi -> gni: core, effects, android framework defines BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4023 Change-Id: I29a26c1716a319156a34a64999756ed7dba1e603 Reviewed-on: https://skia-review.googlesource.com/4023 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
2016-10-26 21:19:03 +00:00
"$_src/pathops/SkPathOpsCubic.cpp",
harmonize rewrite-includes and gn-format checks The CheckGeneratedFiles bot only required rewriting .gn files, while the presubmit wants both .gn and .gni files. It also appears that the #includes rewrite script runs on both the presubmit and CheckGeneratedFiles bots. These presubmits run on the CQ before landing right? If so, no need for them in the CheckGeneratedFIles bot at all. And of course, format .gni files. Change-Id: Icd4526d62f85088862ad93566cc9ace11dc3e33f Reviewed-on: https://skia-review.googlesource.com/c/skia/+/281505 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Mike Klein <mtklein@google.com>
2020-04-03 15:59:37 +00:00
"$_src/pathops/SkPathOpsCubic.h",
gypi -> gni: core, effects, android framework defines BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4023 Change-Id: I29a26c1716a319156a34a64999756ed7dba1e603 Reviewed-on: https://skia-review.googlesource.com/4023 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
2016-10-26 21:19:03 +00:00
"$_src/pathops/SkPathOpsCurve.cpp",
harmonize rewrite-includes and gn-format checks The CheckGeneratedFiles bot only required rewriting .gn files, while the presubmit wants both .gn and .gni files. It also appears that the #includes rewrite script runs on both the presubmit and CheckGeneratedFiles bots. These presubmits run on the CQ before landing right? If so, no need for them in the CheckGeneratedFIles bot at all. And of course, format .gni files. Change-Id: Icd4526d62f85088862ad93566cc9ace11dc3e33f Reviewed-on: https://skia-review.googlesource.com/c/skia/+/281505 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Mike Klein <mtklein@google.com>
2020-04-03 15:59:37 +00:00
"$_src/pathops/SkPathOpsCurve.h",
gypi -> gni: core, effects, android framework defines BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4023 Change-Id: I29a26c1716a319156a34a64999756ed7dba1e603 Reviewed-on: https://skia-review.googlesource.com/4023 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
2016-10-26 21:19:03 +00:00
"$_src/pathops/SkPathOpsDebug.cpp",
harmonize rewrite-includes and gn-format checks The CheckGeneratedFiles bot only required rewriting .gn files, while the presubmit wants both .gn and .gni files. It also appears that the #includes rewrite script runs on both the presubmit and CheckGeneratedFiles bots. These presubmits run on the CQ before landing right? If so, no need for them in the CheckGeneratedFIles bot at all. And of course, format .gni files. Change-Id: Icd4526d62f85088862ad93566cc9ace11dc3e33f Reviewed-on: https://skia-review.googlesource.com/c/skia/+/281505 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Mike Klein <mtklein@google.com>
2020-04-03 15:59:37 +00:00
"$_src/pathops/SkPathOpsDebug.h",
gypi -> gni: core, effects, android framework defines BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4023 Change-Id: I29a26c1716a319156a34a64999756ed7dba1e603 Reviewed-on: https://skia-review.googlesource.com/4023 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
2016-10-26 21:19:03 +00:00
"$_src/pathops/SkPathOpsLine.cpp",
harmonize rewrite-includes and gn-format checks The CheckGeneratedFiles bot only required rewriting .gn files, while the presubmit wants both .gn and .gni files. It also appears that the #includes rewrite script runs on both the presubmit and CheckGeneratedFiles bots. These presubmits run on the CQ before landing right? If so, no need for them in the CheckGeneratedFIles bot at all. And of course, format .gni files. Change-Id: Icd4526d62f85088862ad93566cc9ace11dc3e33f Reviewed-on: https://skia-review.googlesource.com/c/skia/+/281505 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Mike Klein <mtklein@google.com>
2020-04-03 15:59:37 +00:00
"$_src/pathops/SkPathOpsLine.h",
gypi -> gni: core, effects, android framework defines BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4023 Change-Id: I29a26c1716a319156a34a64999756ed7dba1e603 Reviewed-on: https://skia-review.googlesource.com/4023 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
2016-10-26 21:19:03 +00:00
"$_src/pathops/SkPathOpsOp.cpp",
harmonize rewrite-includes and gn-format checks The CheckGeneratedFiles bot only required rewriting .gn files, while the presubmit wants both .gn and .gni files. It also appears that the #includes rewrite script runs on both the presubmit and CheckGeneratedFiles bots. These presubmits run on the CQ before landing right? If so, no need for them in the CheckGeneratedFIles bot at all. And of course, format .gni files. Change-Id: Icd4526d62f85088862ad93566cc9ace11dc3e33f Reviewed-on: https://skia-review.googlesource.com/c/skia/+/281505 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Mike Klein <mtklein@google.com>
2020-04-03 15:59:37 +00:00
"$_src/pathops/SkPathOpsPoint.h",
gypi -> gni: core, effects, android framework defines BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4023 Change-Id: I29a26c1716a319156a34a64999756ed7dba1e603 Reviewed-on: https://skia-review.googlesource.com/4023 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
2016-10-26 21:19:03 +00:00
"$_src/pathops/SkPathOpsQuad.cpp",
harmonize rewrite-includes and gn-format checks The CheckGeneratedFiles bot only required rewriting .gn files, while the presubmit wants both .gn and .gni files. It also appears that the #includes rewrite script runs on both the presubmit and CheckGeneratedFiles bots. These presubmits run on the CQ before landing right? If so, no need for them in the CheckGeneratedFIles bot at all. And of course, format .gni files. Change-Id: Icd4526d62f85088862ad93566cc9ace11dc3e33f Reviewed-on: https://skia-review.googlesource.com/c/skia/+/281505 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Mike Klein <mtklein@google.com>
2020-04-03 15:59:37 +00:00
"$_src/pathops/SkPathOpsQuad.h",
gypi -> gni: core, effects, android framework defines BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4023 Change-Id: I29a26c1716a319156a34a64999756ed7dba1e603 Reviewed-on: https://skia-review.googlesource.com/4023 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
2016-10-26 21:19:03 +00:00
"$_src/pathops/SkPathOpsRect.cpp",
harmonize rewrite-includes and gn-format checks The CheckGeneratedFiles bot only required rewriting .gn files, while the presubmit wants both .gn and .gni files. It also appears that the #includes rewrite script runs on both the presubmit and CheckGeneratedFiles bots. These presubmits run on the CQ before landing right? If so, no need for them in the CheckGeneratedFIles bot at all. And of course, format .gni files. Change-Id: Icd4526d62f85088862ad93566cc9ace11dc3e33f Reviewed-on: https://skia-review.googlesource.com/c/skia/+/281505 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Mike Klein <mtklein@google.com>
2020-04-03 15:59:37 +00:00
"$_src/pathops/SkPathOpsRect.h",
gypi -> gni: core, effects, android framework defines BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4023 Change-Id: I29a26c1716a319156a34a64999756ed7dba1e603 Reviewed-on: https://skia-review.googlesource.com/4023 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
2016-10-26 21:19:03 +00:00
"$_src/pathops/SkPathOpsSimplify.cpp",
"$_src/pathops/SkPathOpsTSect.cpp",
harmonize rewrite-includes and gn-format checks The CheckGeneratedFiles bot only required rewriting .gn files, while the presubmit wants both .gn and .gni files. It also appears that the #includes rewrite script runs on both the presubmit and CheckGeneratedFiles bots. These presubmits run on the CQ before landing right? If so, no need for them in the CheckGeneratedFIles bot at all. And of course, format .gni files. Change-Id: Icd4526d62f85088862ad93566cc9ace11dc3e33f Reviewed-on: https://skia-review.googlesource.com/c/skia/+/281505 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Mike Klein <mtklein@google.com>
2020-04-03 15:59:37 +00:00
"$_src/pathops/SkPathOpsTSect.h",
gypi -> gni: core, effects, android framework defines BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4023 Change-Id: I29a26c1716a319156a34a64999756ed7dba1e603 Reviewed-on: https://skia-review.googlesource.com/4023 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
2016-10-26 21:19:03 +00:00
"$_src/pathops/SkPathOpsTightBounds.cpp",
"$_src/pathops/SkPathOpsTypes.cpp",
harmonize rewrite-includes and gn-format checks The CheckGeneratedFiles bot only required rewriting .gn files, while the presubmit wants both .gn and .gni files. It also appears that the #includes rewrite script runs on both the presubmit and CheckGeneratedFiles bots. These presubmits run on the CQ before landing right? If so, no need for them in the CheckGeneratedFIles bot at all. And of course, format .gni files. Change-Id: Icd4526d62f85088862ad93566cc9ace11dc3e33f Reviewed-on: https://skia-review.googlesource.com/c/skia/+/281505 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Mike Klein <mtklein@google.com>
2020-04-03 15:59:37 +00:00
"$_src/pathops/SkPathOpsTypes.h",
gypi -> gni: core, effects, android framework defines BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4023 Change-Id: I29a26c1716a319156a34a64999756ed7dba1e603 Reviewed-on: https://skia-review.googlesource.com/4023 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
2016-10-26 21:19:03 +00:00
"$_src/pathops/SkPathOpsWinding.cpp",
"$_src/pathops/SkPathWriter.cpp",
"$_src/pathops/SkPathWriter.h",
harmonize rewrite-includes and gn-format checks The CheckGeneratedFiles bot only required rewriting .gn files, while the presubmit wants both .gn and .gni files. It also appears that the #includes rewrite script runs on both the presubmit and CheckGeneratedFiles bots. These presubmits run on the CQ before landing right? If so, no need for them in the CheckGeneratedFIles bot at all. And of course, format .gni files. Change-Id: Icd4526d62f85088862ad93566cc9ace11dc3e33f Reviewed-on: https://skia-review.googlesource.com/c/skia/+/281505 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Mike Klein <mtklein@google.com>
2020-04-03 15:59:37 +00:00
"$_src/pathops/SkReduceOrder.cpp",
gypi -> gni: core, effects, android framework defines BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4023 Change-Id: I29a26c1716a319156a34a64999756ed7dba1e603 Reviewed-on: https://skia-review.googlesource.com/4023 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
2016-10-26 21:19:03 +00:00
"$_src/pathops/SkReduceOrder.h",
]
Turn on SkJumper all the time, try 2. Rebased on top of _win.S change, which I hope lands first. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel,win_chrome_official,win_chromium_dbg_ng,win_chromium_rel_ng,win_chromium_compile_dbg_ng,win_chromium_compile_rel_ng,win_clang;master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: I30e97dbb55b8a42251b46f5607096ca12bc670b9 Reviewed-on: https://skia-review.googlesource.com/10462 Commit-Queue: Mike Klein <mtklein@chromium.org> Reviewed-by: Herb Derby <herb@google.com>
2017-03-29 21:32:50 +00:00
GN: split out skia_*_public from skia_*_sources `gn check` passes. We will work towards removing `check_includes = false`. Change-Id: I0ab396fadaf31a166921bdea334b2cfedca23dcd Reviewed-on: https://skia-review.googlesource.com/c/skia/+/195363 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Hal Canary <halcanary@google.com>
2019-02-26 16:54:25 +00:00
skia_skpicture_public = [
"$_include/core/SkPicture.h",
"$_include/core/SkPictureRecorder.h",
]
[canvaskit] Slice out SkPicture Removes about 120k uncompressed, 40k gzipped Bug: skia: Change-Id: I7e0b404f18fc3c6d4ff6b01d2c9bcd657b7d5e07 Reviewed-on: https://skia-review.googlesource.com/c/163246 Commit-Queue: Kevin Lubick <kjlubick@google.com> Reviewed-by: Mike Klein <mtklein@google.com>
2018-10-18 13:47:01 +00:00
skia_skpicture_sources = [
"$_include/core/SkPicture.h",
"$_include/core/SkPictureRecorder.h",
"$_src/core/SkBigPicture.cpp",
"$_src/core/SkPicture.cpp",
"$_src/core/SkPictureCommon.h",
"$_src/core/SkPictureData.cpp",
"$_src/core/SkPictureData.h",
"$_src/core/SkPictureFlat.cpp",
"$_src/core/SkPictureFlat.h",
"$_src/core/SkPictureImageGenerator.cpp",
"$_src/core/SkPicturePlayback.cpp",
"$_src/core/SkPicturePlayback.h",
"$_src/core/SkPictureRecord.cpp",
"$_src/core/SkPictureRecord.h",
"$_src/core/SkPictureRecorder.cpp",
"$_src/core/SkRecordedDrawable.cpp",
"$_src/core/SkRecorder.cpp",
"$_src/shaders/SkPictureShader.cpp",
"$_src/shaders/SkPictureShader.h",
]
Have pathkit use libpathkit.a for faster builds Of note, it is very important for the -DSK_RELEASE/-DSK_DEBUG to match between libskia.a and the WASM bindings, otherwise things like SKDEBUGCODE are sometimes compiled in and sometimes not, which can cause headaches like sizeof() mismatching between .cpp files and .h files. Bug: skia: Change-Id: Id6ef58c44a7c10014a243b36708e0891514f6008 Reviewed-on: https://skia-review.googlesource.com/158341 Reviewed-by: Mike Klein <mtklein@google.com>
2018-10-02 13:02:18 +00:00
skia_core_sources += skia_pathops_sources
[canvaskit] Slice out SkPicture Removes about 120k uncompressed, 40k gzipped Bug: skia: Change-Id: I7e0b404f18fc3c6d4ff6b01d2c9bcd657b7d5e07 Reviewed-on: https://skia-review.googlesource.com/c/163246 Commit-Queue: Kevin Lubick <kjlubick@google.com> Reviewed-by: Mike Klein <mtklein@google.com>
2018-10-18 13:47:01 +00:00
skia_core_sources += skia_skpicture_sources
Have pathkit use libpathkit.a for faster builds Of note, it is very important for the -DSK_RELEASE/-DSK_DEBUG to match between libskia.a and the WASM bindings, otherwise things like SKDEBUGCODE are sometimes compiled in and sometimes not, which can cause headaches like sizeof() mismatching between .cpp files and .h files. Bug: skia: Change-Id: Id6ef58c44a7c10014a243b36708e0891514f6008 Reviewed-on: https://skia-review.googlesource.com/158341 Reviewed-by: Mike Klein <mtklein@google.com>
2018-10-02 13:02:18 +00:00
GN: split out skia_*_public from skia_*_sources `gn check` passes. We will work towards removing `check_includes = false`. Change-Id: I0ab396fadaf31a166921bdea334b2cfedca23dcd Reviewed-on: https://skia-review.googlesource.com/c/skia/+/195363 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Hal Canary <halcanary@google.com>
2019-02-26 16:54:25 +00:00
skia_core_public += skia_pathops_public
skia_core_public += skia_skpicture_public
Reland "Reland "make SkJumper stages normal Skia code"" This is a reland of 78cb579f33943421afc8423a39867fcfd69fed44 This time, lowp stages are controlled by !defined(JUMPER_IS_SCALAR), not by defined(__clang__). The two are usually the same, except when we opt Clang builds into JUMPER_IS_SCALAR artificially. Some Google3 builds use compilers old enough that they barf when compiling our NEON code. It's conceivably also possible to define JUMPER_IS_SCALAR yourself, but I don't think anyone does that. Original change's description: > Reland "make SkJumper stages normal Skia code" > > This is a reland of 22e536e3a1a09405d1c0e6f071717a726d86e8d4 > > Now with fixed #include paths in SkRasterPipeline_opts.h, > and -ffp-contract=fast for the :hsw target to minimize > diffs on non-Windows Clang AVX2/AVX-512 bots. > > Original change's description: > > make SkJumper stages normal Skia code > > > > Enough clients are using Clang now that we can say, use Clang to build > > if you want these software pipeline stages to go fast. > > > > This lets us drop the offline build aspect of SkJumper stages, instead > > building as part of Skia using the SkOpts framework. > > > > I think everything should work, except I've (temporarily) removed > > AVX-512 support. I will put this back in a follow up. > > > > I have had to drop Windows down to __vectorcall and our narrower > > stage calling convention that keeps the d-registers on the stack. > > I tried forcing sysv_abi, but that crashed Clang. :/ > > > > Added a TODO to up the same narrower stage calling convention > > for lowp stages... we just *don't* today, for no good reason. > > > > Change-Id: Iaaa792ffe4deab3508d2dc5d0008c163c24b3383 > > Reviewed-on: https://skia-review.googlesource.com/110641 > > Commit-Queue: Mike Klein <mtklein@chromium.org> > > Reviewed-by: Herb Derby <herb@google.com> > > Reviewed-by: Florin Malita <fmalita@chromium.org> > > Change-Id: I44f2c03d33958e3807747e40904b6351957dd448 > Reviewed-on: https://skia-review.googlesource.com/112742 > Reviewed-by: Mike Klein <mtklein@chromium.org> Change-Id: I3d71197d4bbb19ca4a94961a97fa2e54d5cbfb0d Reviewed-on: https://skia-review.googlesource.com/112744 Reviewed-by: Mike Klein <mtklein@google.com> Commit-Queue: Mike Klein <mtklein@google.com>
2018-02-27 15:37:40 +00:00
skia_core_defines = [] # Used to be used by Chromium, but no longer.
Reference in New Issue Copy Permalink