AuroraMiddleware/skia2
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
c2f47190c1
skia2/bazel/Makefile

64 lines
3.4 KiB
Makefile
Raw Normal View History

[bazel] Sketching out HelloWorld sk_app using GL bazel run //example:hello_world --config=clang causes a window to open and draws a circle and a square. Text to follow in a future CL. To make this work, I had to get rid of musl and use glibc. All the shared libraries (.so files) that were pre-built and available for download (e.g. from https://packages.debian.org/bullseye/amd64/libgl1/download) were compiled against glibc. When I tried to run a program statically linked with musl and dynamically linked against things using glibc, I got a segmentation fault on things like calloc(). Initial attempts to use glibc had failed because it was thought that the libc.so.6 file could only be referred to by absolute path (and thus Bazel would not be happy about it). As it turns out, that was simply a misconfiguration of the builtin_sysroot parameter to cc_common.create_cc_toolchain_config_info (see //toolchain/clang_toolchain_config.bzl). By setting that to `external/clang_linux_amd64` and not `external/clang_linux_amd64/usr`, the libc binary which had been extracted to `external/clang_linux_amd64/lib/x86_64-linux-gnu` was perfectly reachable from `external/clang_linux_amd64/usr/usr/lib/x86_64-linux-gnu/libc.so` To bring in the shared libraries to link against (e.g. X11, GL) I made build_toolchain.bzl easier to modify in that we simply need to add a debian download url and sha256 hash to a list (rather than having to plumb this through via arguments). Recommended Review Order: - example/BUILD.bazel (not sure if we always want to set bare link arguments like that or if we want to use "features" to pass those along to the toolchain). - tools/sk_app/BUILD.bazel to see initial cc_library for wrapping sk_app code. - toolchain/build_toolchain.bzl to see removal of musl and new list of debs. - toolchain/clang_toolchain_config.bzl (where use of the no-canonical-prefixes was key to compilation success). Notice also that we statically linked libc++ (I did not have any shared libraries for it locally, so I guessed a typical developer might not either). - Rest of toolchain/ for trivial renames. - bazel/Makefile to see extra docs on those targets and a new target that compiles all the exes so far for a quick way to test the build. - third_party/BUILD.bazel and src/gpu/BUILD.bazel which have non-generated changes. (all other BUILD.bazel files do). - go.mod, which needed to update the infra repo version in order to pick up http://review.skia.org/491736). Change-Id: I8687bd227353040eca2dffa9465798d8bd395027 Bug: skia:12541 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/492117 Reviewed-by: Ben Wagner <bungeman@google.com> Reviewed-by: Leandro Lovisolo <lovisolo@google.com> Commit-Queue: Kevin Lubick <kjlubick@google.com>
2022-01-11 12:35:26 +00:00
# This target should be run when new files are added or includes changed.
[bazel] Add go/gazelle to WORKSPACE and use c++ extension. This adds a simple go program to test the installed go toolchain, and a Make rule to codify the arguments to our gazelle binary, built with extensions. I could not figure out how to get the .json file to work with the gazelle() Bazel rule, but this works ok for now. Bug: skia:12541 Change-Id: I5067b15c7518951aeb69559d3871799d3b5745f4 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/475716 Reviewed-by: Leandro Lovisolo <lovisolo@google.com>
2021-11-23 19:58:20 +00:00
generate:
Update Bazel files - Use latest emscripten toolchain (3.1.0) - Autogenerate the atoms and manually fix some of the file lists. - Add a known_good_builds target to bazel/Makefile to help check the things we expect to work with Bazel. Change-Id: Ia5f51e7b9eb5c108386820ad59180c8f862f5a70 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/491438 Reviewed-by: Ben Wagner <bungeman@google.com>
2022-01-06 16:19:22 +00:00
bazelisk build @org_skia_go_infra//bazel/gazelle:gazelle_cpp
[bazel] Add go/gazelle to WORKSPACE and use c++ extension. This adds a simple go program to test the installed go toolchain, and a Make rule to codify the arguments to our gazelle binary, built with extensions. I could not figure out how to get the .json file to work with the gazelle() Bazel rule, but this works ok for now. Bug: skia:12541 Change-Id: I5067b15c7518951aeb69559d3871799d3b5745f4 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/475716 Reviewed-by: Leandro Lovisolo <lovisolo@google.com>
2021-11-23 19:58:20 +00:00
cd .. && bazel-bin/external/org_skia_go_infra/bazel/gazelle/gazelle_cpp_/gazelle_cpp update \
--third_party_file_map="third_party/file_map_for_bazel.json" \
[bazel] Compile gms for wasm and WebGL PS 1 is re-generating existing BUILD.bazel files PS 2 is generating BUILD.bazel files for tests/gms PS 3+ makes modifications to build all of the gms and tests. It is recommended to view this CL with just a diff between PS 2 and the end, due to the large amount of generated changes in PS 1 and 2. We make a filegroup for the gms and tests because they need to be compiled as one large blob in order for the registries to work. Maybe in the future we will break these up, but at least for WASM/JS, the overhead of starting a browser for each new test would likely grind things to a halt, so we just group them all together for now. It's also the most similar to what we currently do. In gm/BUILD.bazel and tests/BUILD.bazel, we add a cc_library that encapsulates all of the deps of the tests, so we can easily include that the build. These were discovered via trial and error, not anything automatic or systematic. The is_skia_dev_build config_setting is very similar to the GN equivalent from which it was based. The list of gms and tests to skip (e.g. which are incompatible with WASM) was determined by building the wasm bundle: modules/canvaskit$ make bazel_gms_release tools/run-wasm-gm-tests$ make run_local_debug # Don't forget to click the button on the screen after the # browser loads This way of invoking the tests will be replace soon with `bazel test <something>`. As such, I didn't bother fully documenting the current way. Suggested review order: - modules/canvaskit/BUILD.bazel taking note that we always use profiling-funcs to make the stacktraces human readable. - gm/BUILD.bazel and tests/BUILD.bazel to see the lists of gms/tests. Notice the tests are roughly partitioned because we don't support things like vulkan/PDF in the wasm build and we will want a way to not build certain tests for certain configurations - tools/* noting some of the cc_libraries added to make dependencies easier to add when needed. - All other files. Change-Id: I43059cd93c28af1c4c12b93d6ebd9c46a12d381f Bug: skia:12541 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/506256 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Kevin Lubick <kjlubick@google.com>
2022-02-09 18:14:25 +00:00
include src tools gm tests \
[infra] Add SkParagraph (harfbuzz, ICU) to Canvaskit Bazel build. As a follow-up to https://skia-review.googlesource.com/c/skia/+/476219, this sketches out how we can maybe use cc_library for the things in //modules to make sure something in //src doesn't depend on anything in //modules, for example. The following succeeds: bazel build //modules/skparagraph:skparagraph --config=clang \ --shaper_backend=harfbuzz_shaper --with_icu As does `make bazel_canvaskit_debug` in //modules/canvaskit Suggested Review Order: - third_party/BUILD.bazel for ICU and harfbuzz rules. Pay special attention to the genrules used to call the python script for turning the icu .dat file into .S or .cpp. - bazelrc and bazel/ for new flags and defines that control use of ICU and harfbuzz. Unlike GN, with the public_defines that get added in automatically if icu or harfbuzz is depended upon, we need to set the defines at the top level. This necessity might go away if we change the atoms to depend on //modules/skshaper, which could define that flag. - Top level BUILD.bazel files in //modules/skparagraph, //modules/skshaper, //modules/skunicode, //modules/canvaskit - All other .bazel file changes are automatic. Bug: skia:12541 Change-Id: I38a9e0a9261d7e142eeb271c2ddb23f362f91473 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/478116 Reviewed-by: Ben Wagner <bungeman@google.com> Reviewed-by: Leandro Lovisolo <lovisolo@google.com>
2021-11-30 20:59:32 +00:00
modules/skshaper modules/svg modules/skresources modules/skparagraph modules/skunicode \
[canvaskit] Add skottie to Bazel build PS 1 regenerates existing Bazel files PS 2 adds generated Bazel files to skottie and its dependencies, as well as incorporating it into CanvasKit. This changes the version of Bazel we use to 5.0.0 (recently released).We had been using a pre-release of 6.0 because we wanted the new features in one of the 5.0 release candidates, but not the regression that was there (and reverted before the full 5.0 release). I'd like to stick to the latest stable Bazel release where possible. Suggested Review Order: - //modules/skottie/BUILD.bazel (this was hand written to encapsulate the skottie library). The files in the deps are based on skottie.gni. - //modules/skresources/BUILD.bazel and //modules/sksg/BUILD.bazel which expose all sources - //third_party/file_map_for_bazel.json which ignores the ffmpeg libraries (we won't actually build the SkVideoDecoder stuff because HAVE_VIDEO_DECODER is not set). - //modules/canvaskit/BUILD.bazel which makes use of the skottie library and includes the interface skottie.js file. - .bazelversion which changes the Bazel version used (e.g. by Bazelisk). - All other changes should be auto-generated or related to deleted files. Change-Id: Ic26f9a9dea5310f2cbd9cda7d701847924a39a22 Bug: skia:12541 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/503828 Reviewed-by: Ben Wagner <bungeman@google.com> Reviewed-by: Jorge Betancourt <jmbetancourt@google.com>
2022-02-04 15:05:29 +00:00
modules/skottie modules/skresources modules/sksg experimental/ffmpeg \
[canvaskit] Add more features to Bazel build PS 1 adds particles to the build PS 2+ ports many of the options from //modules/canvaskit/compile.sh With this CL, all the CanvasKit tests pass with both the debug and release build. Change-Id: Id70f0c16a087109c56949417f940849f2e3b5200 Bug: skia:12541 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/504537 Reviewed-by: Brian Osman <brianosman@google.com> Reviewed-by: Ben Wagner <bungeman@google.com>
2022-02-04 20:04:15 +00:00
modules/particles \
Reland "[graphite] Move Graphite into Skia base directories." This is a reland of commit ae5e84604724726bce6704e5c69ec9b4ae3c8e98 Original change's description: > [graphite] Move Graphite into Skia base directories. > > Change-Id: Ie0fb74f3766a8b33387c145bd1151344c25808cb > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/528708 > Reviewed-by: Kevin Lubick <kjlubick@google.com> > Reviewed-by: Greg Daniel <egdaniel@google.com> > Commit-Queue: Jim Van Verth <jvanverth@google.com> Change-Id: Ia575fd49206ad0b665a6a9153317e738bb321446 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/529059 Reviewed-by: Kevin Lubick <kjlubick@google.com> Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Jim Van Verth <jvanverth@google.com>
2022-04-11 15:48:46 +00:00
experimental/bazel_test example \
[bazel] Use bazel to build task drivers One very important, but agonizing to discover, change was to go_repositories.bzl. Without it, we see cryptic errors like: external/org_chromium_go_luci/cipd/api/cipd/v1/BUILD.bazel:22:17: no such package '@org_chromium_go_luci//go.chromium.org/luci/cipd/api/cipd/v1': BUILD file not found in directory 'go.chromium.org/luci/cipd/api/cipd/v1' of external repository @org_chromium_go_luci. Add a BUILD file to a directory to mark it as a package. and referenced by '@org_chromium_go_luci//cipd/api/cipd/v1:api_go_proto' The rest of these changes are very similar to https://skia-review.googlesource.com/c/buildbot/+/514074 which also has justification for the use of task drivers, even in a Bazel-driven world. All the BUILD.bazel files under infra/bots/task_drivers were generated by Gazelle. Note that the infra/bots/BUILD.bazel can happily build and package up the task drivers from the infra repo. The old build_task_drivers tasks did this too, because we have some task drivers that are used in both repos. Change-Id: I13c46c62bc7a6a4bfe7935b28efbfb34caabb6f2 Bug: skia:12541 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/515296 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Kevin Lubick <kjlubick@google.com>
2022-03-03 15:42:57 +00:00
modules/canvaskit/go \
infra/bots/task_drivers
[bazel] Add go/gazelle to WORKSPACE and use c++ extension. This adds a simple go program to test the installed go toolchain, and a Make rule to codify the arguments to our gazelle binary, built with extensions. I could not figure out how to get the .json file to work with the gazelle() Bazel rule, but this works ok for now. Bug: skia:12541 Change-Id: I5067b15c7518951aeb69559d3871799d3b5745f4 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/475716 Reviewed-by: Leandro Lovisolo <lovisolo@google.com>
2021-11-23 19:58:20 +00:00
[bazel] Sketching out HelloWorld sk_app using GL bazel run //example:hello_world --config=clang causes a window to open and draws a circle and a square. Text to follow in a future CL. To make this work, I had to get rid of musl and use glibc. All the shared libraries (.so files) that were pre-built and available for download (e.g. from https://packages.debian.org/bullseye/amd64/libgl1/download) were compiled against glibc. When I tried to run a program statically linked with musl and dynamically linked against things using glibc, I got a segmentation fault on things like calloc(). Initial attempts to use glibc had failed because it was thought that the libc.so.6 file could only be referred to by absolute path (and thus Bazel would not be happy about it). As it turns out, that was simply a misconfiguration of the builtin_sysroot parameter to cc_common.create_cc_toolchain_config_info (see //toolchain/clang_toolchain_config.bzl). By setting that to `external/clang_linux_amd64` and not `external/clang_linux_amd64/usr`, the libc binary which had been extracted to `external/clang_linux_amd64/lib/x86_64-linux-gnu` was perfectly reachable from `external/clang_linux_amd64/usr/usr/lib/x86_64-linux-gnu/libc.so` To bring in the shared libraries to link against (e.g. X11, GL) I made build_toolchain.bzl easier to modify in that we simply need to add a debian download url and sha256 hash to a list (rather than having to plumb this through via arguments). Recommended Review Order: - example/BUILD.bazel (not sure if we always want to set bare link arguments like that or if we want to use "features" to pass those along to the toolchain). - tools/sk_app/BUILD.bazel to see initial cc_library for wrapping sk_app code. - toolchain/build_toolchain.bzl to see removal of musl and new list of debs. - toolchain/clang_toolchain_config.bzl (where use of the no-canonical-prefixes was key to compilation success). Notice also that we statically linked libc++ (I did not have any shared libraries for it locally, so I guessed a typical developer might not either). - Rest of toolchain/ for trivial renames. - bazel/Makefile to see extra docs on those targets and a new target that compiles all the exes so far for a quick way to test the build. - third_party/BUILD.bazel and src/gpu/BUILD.bazel which have non-generated changes. (all other BUILD.bazel files do). - go.mod, which needed to update the infra repo version in order to pick up http://review.skia.org/491736). Change-Id: I8687bd227353040eca2dffa9465798d8bd395027 Bug: skia:12541 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/492117 Reviewed-by: Ben Wagner <bungeman@google.com> Reviewed-by: Leandro Lovisolo <lovisolo@google.com> Commit-Queue: Kevin Lubick <kjlubick@google.com>
2022-01-11 12:35:26 +00:00
# This target should be run after the go.mod file is updated (e.g. version rolls or new updates)
[bazel] Add go/gazelle to WORKSPACE and use c++ extension. This adds a simple go program to test the installed go toolchain, and a Make rule to codify the arguments to our gazelle binary, built with extensions. I could not figure out how to get the .json file to work with the gazelle() Bazel rule, but this works ok for now. Bug: skia:12541 Change-Id: I5067b15c7518951aeb69559d3871799d3b5745f4 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/475716 Reviewed-by: Leandro Lovisolo <lovisolo@google.com>
2021-11-23 19:58:20 +00:00
gazelle_update_repo:
Update Bazel files - Use latest emscripten toolchain (3.1.0) - Autogenerate the atoms and manually fix some of the file lists. - Add a known_good_builds target to bazel/Makefile to help check the things we expect to work with Bazel. Change-Id: Ia5f51e7b9eb5c108386820ad59180c8f862f5a70 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/491438 Reviewed-by: Ben Wagner <bungeman@google.com>
2022-01-06 16:19:22 +00:00
cd .. && bazelisk run //:gazelle -- update-repos -from_file=go.mod -to_macro=go_repositories.bzl%go_repositories
# Run this target to test all known working Bazel builds
known_good_builds:
[includes] Enforce IWYU for //tools/debugger/... This moves the Build-Debian10-BazelClang-x86_64-Release-IWYU job from experimental to on when a file in one of the folders that we enforce IWYU is modified (currently for svg, sksl, and now, debugger). Change-Id: Ia6fe1e7b30fc486db3eb081b6a64bc4c250cbf0b Bug: skia:13052 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/525796 Reviewed-by: Derek Sollenberger <djsollen@google.com> Commit-Queue: Kevin Lubick <kjlubick@google.com>
2022-03-30 13:00:12 +00:00
bazelisk build //experimental/bazel_test/... --config=clang
bazelisk run //experimental/bazel_test:bazel_test_exe --config=clang
bazelisk build //:skia_core --config=clang
bazelisk build //src/sksl/lex:sksllex --config=clang
bazelisk build //tools/skdiff --config=clang
[bazel] Add executable for skslc This ports the GN skia_executable [1] and adds third_party Bazel rules for spirv_cross, translated from [2]. spirv_cross, unlike spirv_tools, did not have pre-made Bazel rules. This binary compiles and links with bazelisk build //tools/skslc --config=clang [1] https://github.com/google/skia/blob/ad324a31e6df626da4f566dff7529c9457679758/BUILD.gn#L712 [2] https://github.com/google/skia/blob/ad324a31e6df626da4f566dff7529c9457679758/third_party/spirv-cross/BUILD.gn#L10 Change-Id: I4abd51889552153fc7e64a5f7f3d9f0f597524e7 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/528044 Reviewed-by: John Stiles <johnstiles@google.com> Commit-Queue: Kevin Lubick <kjlubick@google.com>
2022-04-08 15:29:33 +00:00
bazelisk build //tools/skslc --config=clang
[bazel] Fix/update rules This regenerates the files and fixes the harfbuzz rule so CanvasKit compiles. Change-Id: I2db2bddaabf793f360e8a4fa1a6a2b96222dfdf8 Bug: skia:12541 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/522816 Reviewed-by: Ben Wagner <bungeman@google.com>
2022-03-21 13:11:28 +00:00
bazelisk build //modules/canvaskit:canvaskit_wasm --compilation_mode opt --sandbox_base=/dev/shm
[bazel] Test enforcement of IWYU on SkSVG backend. This will use the recently added Bazel toolchain feature to enforce proper includes for all files in //src/svg/... In the future, I envision a CI/CQ job that will run bazel build with a few different configurations and the --feature skia_enforce_iwyu on to make sure we don't regress. Change-Id: Ibb9f816ab626415c11bd2b9b74c503297c4b0723 Bug: skia:13052 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/521036 Reviewed-by: Ben Wagner <bungeman@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Kevin Lubick <kjlubick@google.com>
2022-03-15 18:18:53 +00:00
# Test the enforcement of include what you use
[includes] Enforce IWYU for //tools/debugger/... This moves the Build-Debian10-BazelClang-x86_64-Release-IWYU job from experimental to on when a file in one of the folders that we enforce IWYU is modified (currently for svg, sksl, and now, debugger). Change-Id: Ia6fe1e7b30fc486db3eb081b6a64bc4c250cbf0b Bug: skia:13052 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/525796 Reviewed-by: Derek Sollenberger <djsollen@google.com> Commit-Queue: Kevin Lubick <kjlubick@google.com>
2022-03-30 13:00:12 +00:00
bazelisk build //example:hello_world_gl --config=clang --features skia_enforce_iwyu
[bazel] Test enforcement of IWYU on SkSVG backend. This will use the recently added Bazel toolchain feature to enforce proper includes for all files in //src/svg/... In the future, I envision a CI/CQ job that will run bazel build with a few different configurations and the --feature skia_enforce_iwyu on to make sure we don't regress. Change-Id: Ibb9f816ab626415c11bd2b9b74c503297c4b0723 Bug: skia:13052 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/521036 Reviewed-by: Ben Wagner <bungeman@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Kevin Lubick <kjlubick@google.com>
2022-03-15 18:18:53 +00:00
# Both with and without a GPU backend should be error free (i.e. IWYU should let us
# conditionally import things.
[includes] Enforce IWYU for //tools/debugger/... This moves the Build-Debian10-BazelClang-x86_64-Release-IWYU job from experimental to on when a file in one of the folders that we enforce IWYU is modified (currently for svg, sksl, and now, debugger). Change-Id: Ia6fe1e7b30fc486db3eb081b6a64bc4c250cbf0b Bug: skia:13052 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/525796 Reviewed-by: Derek Sollenberger <djsollen@google.com> Commit-Queue: Kevin Lubick <kjlubick@google.com>
2022-03-30 13:00:12 +00:00
bazelisk build //src/svg/... --config=clang --features skia_enforce_iwyu \
--gpu_backend=gl_backend --include_decoder=jpeg_decode_codec
bazelisk build //src/svg/... --config=clang --features skia_enforce_iwyu
bazelisk build //tools/debugger --config=clang --gpu_backend=gl_backend \
[bazel] Add RBE support using hermetic Linux Clang toolchain A new RBE worker-pool called gce_linux was created in conjunction with this CL. See https://docs.google.com/document/d/14xMZCKews69SSTfULhE8HDUzT5XvPwZ4CvRufEvcZ74/edit# for some details on that. Note: everything under bazel/rbe/gce_linux was autogenerated and can be ignored from manual review. It basically specifies what files are on the RBE image that are necessary for running Bazel. Testing it out can be done by authenticating for RBE gcloud auth application-default login --no-browser Then, run make -C bazel rbe_known_good_builds to test it out. On my 4 core laptop with an empty local cache, but a warm remote cache, the build took <2 min instead of the 10+ minutes it would have [1]. The folder structure in //bazel/rbe is meant to let us have multiple remote configurations there, e.g. //bazel/rbe/gce_windows. Suggested Review Order: - bazel/rbe/README.md - bazel/rbe/gce_linux_container/Dockerfile to see the bare-bones RBE image. - bazel/rbe/BUILD.bazel to see a custom platform defined. It is nearly identical to the autogenerated one in bazel/rbe/gce_linux/config/BUILD, with one extra field to force the gce_linux pool to be used. - .bazelrc to see the settings needed to make --config=linux-rbe work. The naming convention was inspired by SkCMS's setup [2], and allows us to have some common RBE settings (i.e. config:remote) and some specialized ones for the given host machine (e.g. config:linux-rbe) A very important, but subtle configuration, is on line 86 of .bazelrc where we say to use our hermetic toolchain and not whatever C++ compiler and headers are on the host machine (aka the RBE container). - toolchain/build_toolchain.bzl to see some additional dependencies needed in the toolchain (to run IWYU) which I had installed locally but didn't realize were important. - third_party/BUILD.bazel to see an example of how failing to specify all files can result in something that works locally, but fails remotely. --execution_log_json_file=/tmp/execlog.json helped debug these issues. - All other files. [1] http://go/scrcast/NjM1ODE4MDI0NzM3MTc3Nnw3ODViZmFkMi1iOA [2] https://skia.googlesource.com/skcms/+/30c8e303800c256febb03a09fdcda7f75d119b1b/.bazelrc#20 Change-Id: Ia0a9e6a06c1a13071949ab402dc5d897df6b12e1 Bug: skia:12541 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/524359 Reviewed-by: Leandro Lovisolo <lovisolo@google.com>
2022-03-25 18:59:33 +00:00
--features skia_enforce_iwyu
[includes] Add pragma for SkTypes.h IWYU doesn't always understand that we want defines to come from certain files, so we add a pragma to force it. This also adds an extra entry to known_good_builds so I don't miss this type of thing again when building locally. Change-Id: I2321ea95edfc6a4506d51a011983965eb9bdf1c0 Bug: skia:13052 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/528164 Reviewed-by: John Stiles <johnstiles@google.com> Owners-Override: Kevin Lubick <kjlubick@google.com>
2022-04-07 13:03:48 +00:00
bazelisk build //:skia_core --config=clang --features skia_enforce_iwyu
[includes] Enforce IWYU on src/utils Client changes: - cl/443664347 - cl/444232853 - http://ag/17915718 - http://ag/17913178 - https://crrev.com/c/3602239 Change-Id: I16bcdbbe2b13bbf52f007b0f131e9ee0c14ed237 Bug: skia:13052 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/532257 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Kevin Lubick <kjlubick@google.com>
2022-04-28 15:04:30 +00:00
bazelisk build //src/utils/... --config=clang --features skia_enforce_iwyu
bazelisk build //src/utils/... --config=clang --gpu_backend=gl_backend \
--features skia_enforce_iwyu
[bazel] Add RBE support using hermetic Linux Clang toolchain A new RBE worker-pool called gce_linux was created in conjunction with this CL. See https://docs.google.com/document/d/14xMZCKews69SSTfULhE8HDUzT5XvPwZ4CvRufEvcZ74/edit# for some details on that. Note: everything under bazel/rbe/gce_linux was autogenerated and can be ignored from manual review. It basically specifies what files are on the RBE image that are necessary for running Bazel. Testing it out can be done by authenticating for RBE gcloud auth application-default login --no-browser Then, run make -C bazel rbe_known_good_builds to test it out. On my 4 core laptop with an empty local cache, but a warm remote cache, the build took <2 min instead of the 10+ minutes it would have [1]. The folder structure in //bazel/rbe is meant to let us have multiple remote configurations there, e.g. //bazel/rbe/gce_windows. Suggested Review Order: - bazel/rbe/README.md - bazel/rbe/gce_linux_container/Dockerfile to see the bare-bones RBE image. - bazel/rbe/BUILD.bazel to see a custom platform defined. It is nearly identical to the autogenerated one in bazel/rbe/gce_linux/config/BUILD, with one extra field to force the gce_linux pool to be used. - .bazelrc to see the settings needed to make --config=linux-rbe work. The naming convention was inspired by SkCMS's setup [2], and allows us to have some common RBE settings (i.e. config:remote) and some specialized ones for the given host machine (e.g. config:linux-rbe) A very important, but subtle configuration, is on line 86 of .bazelrc where we say to use our hermetic toolchain and not whatever C++ compiler and headers are on the host machine (aka the RBE container). - toolchain/build_toolchain.bzl to see some additional dependencies needed in the toolchain (to run IWYU) which I had installed locally but didn't realize were important. - third_party/BUILD.bazel to see an example of how failing to specify all files can result in something that works locally, but fails remotely. --execution_log_json_file=/tmp/execlog.json helped debug these issues. - All other files. [1] http://go/scrcast/NjM1ODE4MDI0NzM3MTc3Nnw3ODViZmFkMi1iOA [2] https://skia.googlesource.com/skcms/+/30c8e303800c256febb03a09fdcda7f75d119b1b/.bazelrc#20 Change-Id: Ia0a9e6a06c1a13071949ab402dc5d897df6b12e1 Bug: skia:12541 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/524359 Reviewed-by: Leandro Lovisolo <lovisolo@google.com>
2022-03-25 18:59:33 +00:00
rbe_known_good_builds:
bazelisk build //experimental/bazel_test/... --config=linux-rbe
bazelisk run //experimental/bazel_test:bazel_test_exe --config=linux-rbe
bazelisk build //:skia_core --config=linux-rbe
bazelisk build //src/sksl/lex:sksllex --config=linux-rbe
bazelisk build //tools/skdiff --config=linux-rbe
[bazel] Add executable for skslc This ports the GN skia_executable [1] and adds third_party Bazel rules for spirv_cross, translated from [2]. spirv_cross, unlike spirv_tools, did not have pre-made Bazel rules. This binary compiles and links with bazelisk build //tools/skslc --config=clang [1] https://github.com/google/skia/blob/ad324a31e6df626da4f566dff7529c9457679758/BUILD.gn#L712 [2] https://github.com/google/skia/blob/ad324a31e6df626da4f566dff7529c9457679758/third_party/spirv-cross/BUILD.gn#L10 Change-Id: I4abd51889552153fc7e64a5f7f3d9f0f597524e7 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/528044 Reviewed-by: John Stiles <johnstiles@google.com> Commit-Queue: Kevin Lubick <kjlubick@google.com>
2022-04-08 15:29:33 +00:00
bazelisk build //tools/skslc --config=linux-rbe
[canvaskit] Can build debug mode with RBE Release mode requires https://github.com/emscripten-core/emscripten/pull/16640 to land Change-Id: I70295d4c2f884ebeb400bd30f4ef28d7695e48df Bug: skia:12541 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/526047 Reviewed-by: Joe Gregorio <jcgregorio@google.com>
2022-03-31 13:44:41 +00:00
# TODO(kjlubick) CanvasKit in release mode (i.e. with Closure) requires
# https://github.com/emscripten-core/emscripten/pull/16640 to land
bazelisk build //modules/canvaskit:canvaskit_wasm --compilation_mode dbg --config=linux-rbe \
--jobs 100
[bazel] Add RBE support using hermetic Linux Clang toolchain A new RBE worker-pool called gce_linux was created in conjunction with this CL. See https://docs.google.com/document/d/14xMZCKews69SSTfULhE8HDUzT5XvPwZ4CvRufEvcZ74/edit# for some details on that. Note: everything under bazel/rbe/gce_linux was autogenerated and can be ignored from manual review. It basically specifies what files are on the RBE image that are necessary for running Bazel. Testing it out can be done by authenticating for RBE gcloud auth application-default login --no-browser Then, run make -C bazel rbe_known_good_builds to test it out. On my 4 core laptop with an empty local cache, but a warm remote cache, the build took <2 min instead of the 10+ minutes it would have [1]. The folder structure in //bazel/rbe is meant to let us have multiple remote configurations there, e.g. //bazel/rbe/gce_windows. Suggested Review Order: - bazel/rbe/README.md - bazel/rbe/gce_linux_container/Dockerfile to see the bare-bones RBE image. - bazel/rbe/BUILD.bazel to see a custom platform defined. It is nearly identical to the autogenerated one in bazel/rbe/gce_linux/config/BUILD, with one extra field to force the gce_linux pool to be used. - .bazelrc to see the settings needed to make --config=linux-rbe work. The naming convention was inspired by SkCMS's setup [2], and allows us to have some common RBE settings (i.e. config:remote) and some specialized ones for the given host machine (e.g. config:linux-rbe) A very important, but subtle configuration, is on line 86 of .bazelrc where we say to use our hermetic toolchain and not whatever C++ compiler and headers are on the host machine (aka the RBE container). - toolchain/build_toolchain.bzl to see some additional dependencies needed in the toolchain (to run IWYU) which I had installed locally but didn't realize were important. - third_party/BUILD.bazel to see an example of how failing to specify all files can result in something that works locally, but fails remotely. --execution_log_json_file=/tmp/execlog.json helped debug these issues. - All other files. [1] http://go/scrcast/NjM1ODE4MDI0NzM3MTc3Nnw3ODViZmFkMi1iOA [2] https://skia.googlesource.com/skcms/+/30c8e303800c256febb03a09fdcda7f75d119b1b/.bazelrc#20 Change-Id: Ia0a9e6a06c1a13071949ab402dc5d897df6b12e1 Bug: skia:12541 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/524359 Reviewed-by: Leandro Lovisolo <lovisolo@google.com>
2022-03-25 18:59:33 +00:00
# Test the enforcement of include what you use
bazelisk build //example:hello_world_gl --config=linux-rbe --features skia_enforce_iwyu
# Both with and without a GPU backend should be error free (i.e. IWYU should let us
# conditionally import things.
bazelisk build //src/svg/... --config=linux-rbe --features skia_enforce_iwyu \
--gpu_backend=gl_backend --include_decoder=jpeg_decode_codec
bazelisk build //src/svg/... --config=linux-rbe --features skia_enforce_iwyu
[includes] Enforce IWYU for //tools/debugger/... This moves the Build-Debian10-BazelClang-x86_64-Release-IWYU job from experimental to on when a file in one of the folders that we enforce IWYU is modified (currently for svg, sksl, and now, debugger). Change-Id: Ia6fe1e7b30fc486db3eb081b6a64bc4c250cbf0b Bug: skia:13052 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/525796 Reviewed-by: Derek Sollenberger <djsollen@google.com> Commit-Queue: Kevin Lubick <kjlubick@google.com>
2022-03-30 13:00:12 +00:00
bazelisk build //tools/debugger --config=linux-rbe --gpu_backend=gl_backend \
[includes] Add pragma for SkTypes.h IWYU doesn't always understand that we want defines to come from certain files, so we add a pragma to force it. This also adds an extra entry to known_good_builds so I don't miss this type of thing again when building locally. Change-Id: I2321ea95edfc6a4506d51a011983965eb9bdf1c0 Bug: skia:13052 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/528164 Reviewed-by: John Stiles <johnstiles@google.com> Owners-Override: Kevin Lubick <kjlubick@google.com>
2022-04-07 13:03:48 +00:00
--features skia_enforce_iwyu
bazelisk build //:skia_core --config=linux-rbe --features skia_enforce_iwyu
Reference in New Issue Copy Permalink