reed
026beb52a2
SkPath::Direction serves two masters:
...
- input param to addFoo (e.g. addRect), where only CW or CCW are valid)
- output param from computing functions, that sometimes return kUnknown
This CL's intent is to split these into distinct enums/features:
- Direction (public) loses kUnknown, and is only used for input
- FirstDirection (private) is used for computing the first direction we see when analyzing a contour
BUG=skia:
Review URL: https://codereview.chromium.org/1176953002
2015-06-10 14:23:15 -07:00
Derek Sollenberger
de50d9b942
fix broken build by not passing the verbose flag through
...
Review URL: https://codereview.chromium.org/1176543004
2015-06-10 15:58:48 -04:00
djsollen
46409de6ab
Remove verbose bash logging
...
Review URL: https://codereview.chromium.org/1170283004
2015-06-10 12:37:56 -07:00
ethannicholas
1a1b3ac0d4
Added GrAAFlatteningConvexPathRenderer.
...
This is an alternate version of GrAAConvexPathRenderer which handles
curves by first flattening them to straight lines.
BUG=skia:
Review URL: https://codereview.chromium.org/1158803002
2015-06-10 12:11:17 -07:00
fmalita
523beb7fd9
Label some unused static vars as SK_UNUSED
...
Makes my gcc 5.1.1 much happier.
R=mtklein@google.com ,scroggo@google.com
[ mtklein mischief below here ]
No public API changes.
TBR=reed@google.com
Review URL: https://codereview.chromium.org/1170863006
2015-06-10 10:46:50 -07:00
caryclark
d3c162200f
turn on antialiased text
...
Aliased text didn't work with msaa16, so make it all
antialiased.
TBR=reed@google.com
Review URL: https://codereview.chromium.org/1169173006
2015-06-10 10:34:08 -07:00
caryclark
83ca628cb6
Today's gm include many differences caused by platform font implementations.
...
This experiment replaces the label used in the aaxfermodes gm with
aliased text generated from paths common to all platforms.
Since there is no way today to generate all dm output from trybots,
this will be checked in to confirm that this strategy provides simpler
output across devices.
This does not introduce a new public interface; instead, dm uses
a extern backdoor to install the SkTypeface::CreateFromName
handler.
Review URL: https://codereview.chromium.org/1163283002
2015-06-10 09:31:09 -07:00
djsollen
e21585eabf
Update flags passed to Android GPU bots to exclude running skps and image sources.
...
Review URL: https://codereview.chromium.org/1176923003
2015-06-10 09:05:14 -07:00
mtklein
f2fe0e0320
Remove overly-promiscuous SkNx syntax sugar.
...
I haven't figured out a pithy way to have these apply to only classes
originating from SkNx, so let's just remove them. There aren't too
many use cases, and it's not really any less readable without them.
Semantically, this is a no-op.
BUG=skia:
Review URL: https://codereview.chromium.org/1167153002
2015-06-10 08:57:28 -07:00
bsalomon
55812362f1
Towards removing getTexture() on SkImage
...
Review URL: https://codereview.chromium.org/1166993002
2015-06-10 08:49:28 -07:00
mtklein
519580553a
Use SkMScalar as float by default to match Chromium.
...
Tweak some test values to pass with floats.
As expected, this regresses matrix44_setconcat_general by about 2x.
BUG=skia:
Review URL: https://codereview.chromium.org/1169813006
2015-06-09 15:06:22 -07:00
msarett
b23e6aa676
Subset decoding benchmarks
...
It was my goal to create benchmarks that could measure all
of the use cases that we have identified. I think single
subsets, translating, and scaling are the important ones.
It might be a good idea to discuss the document in greater
detail as well. I just wanted to share this to aid the
discussion.
https://docs.google.com/a/google.com/document/d/1OxW96GDMAlw6dnzNXmiNX-F9oDBBlGXzSsgd0DMIkbI/edit?usp=sharing
BUG=skia:
Review URL: https://codereview.chromium.org/1160953002
2015-06-09 13:56:10 -07:00
reed
c15d9579d6
add copyright
...
BUG=skia:
NOTRY=True
TBR=
Review URL: https://codereview.chromium.org/1170343002
2015-06-09 13:13:16 -07:00
joshualitt
cf94c74fef
Add android native_app_glue to platform_tools/android/third_party
...
BUG=skia:
Review URL: https://codereview.chromium.org/1175673002
2015-06-09 12:33:13 -07:00
reed
41e010cb90
Revert[2] SkDraw and all Blitters to use pixmap instead of bitmapi
...
This reverts commit b3f0ec9f99
.
BUG=skia:
Review URL: https://codereview.chromium.org/1168303006
2015-06-09 12:16:53 -07:00
mtklein
1831f990c3
A bunch of little SkMScalar-as-float build fixes.
...
Landing this before http://crrev.com/1169813006 so the test changes needed
there are clearer. This just lets things build with floats, and is a no-op for
doubles.
No public API changes we didn't intend to already have...
TBR=reed@google.com
BUG=skia:
Review URL: https://codereview.chromium.org/1173673003
2015-06-09 11:47:01 -07:00
smcgruer
1aca864904
Fix build for UCLIBC platforms (newlocale/freelocale)
...
UCLIBC does not have locale support by default.
BUG=skia:
Review URL: https://codereview.chromium.org/1162953003
2015-06-09 10:18:50 -07:00
mtklein
257918898a
Pump up matrix44_setconcat benches 1000x so they can be timed on Android.
...
BUG=skia:
Review URL: https://codereview.chromium.org/1174583002
2015-06-09 09:29:12 -07:00
bungeman
6bd8d1c44b
Fill capHeight and maxCharWidth on Mac.
...
BUG=skia:3924
Review URL: https://codereview.chromium.org/1164423006
2015-06-09 08:40:51 -07:00
reed
2c55d7b7f3
remove subclassing from ImageFilter::Proxy
...
BUG=skia:
Review URL: https://codereview.chromium.org/1172693002
2015-06-09 08:18:40 -07:00
reed
ded9a6f794
remove Proxy entrypoints for canHandleFilter
...
BUG=skia:
Review URL: https://codereview.chromium.org/1169923002
2015-06-09 06:38:49 -07:00
mtklein
c6c6a91ff2
Split SetConcatMatrix44Bench to cover both internal paths.
...
The existing bench only tests the fast path, but we're looking to speed
up the general case. It'd be nice to be able to measure that speedup.
BUG=skia:
Review URL: https://codereview.chromium.org/1146953003
2015-06-09 04:44:07 -07:00
reed
b3f0ec9f99
Revert of change SkDraw and all Blitters to use pixmap instead of bitmap (patchset #6 id:100001 of https://codereview.chromium.org/1148793007/ )
...
Reason for revert:
speculative revert to try to unblock DEPS roll
Original issue's description:
> change SkDraw and all Blitters to use pixmap instead of bitmap
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/c31af44336f5eb4a50e83e76e51962d46c3ed458
TBR=scroggo@google.com ,jvanverth@google.com,reed@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/1164373003
2015-06-08 19:58:07 -07:00
cdalton
86ae0a9e46
Add mixed samples support to XPs
...
BUG=skia:
Review URL: https://codereview.chromium.org/1164973002
2015-06-08 15:11:04 -07:00
bungeman
d6e9fc7f1f
Restore support for 10.6 SDK in header.
...
Must use ApplicationServices, can't use CoreText directly.
2015-06-08 17:47:06 -04:00
bungeman
1b5f25c5d7
Remove attempted bug mitigation in Mac typeface.
...
An attempt was made to hold onto the 'sbix' table when it existed
when drawing to mitigate an issue with vanishing font data. This
code has not affected the crash rate, so remove it.
Review URL: https://codereview.chromium.org/1168793003
2015-06-08 14:32:24 -07:00
cdalton
827bae10f2
Fix regression in GrXferProcessor
...
Fix segfault introduced in https://codereview.chromium.org/1170553002/
BUG=skia:
Review URL: https://codereview.chromium.org/1167243002
2015-06-08 13:43:33 -07:00
bungeman
788840168f
Provide tag-along for SkCreateTypefaceFromCTFont.
...
This provides a means of keeping an object alive for the entire
lifetime of an SkTypeface.
Review URL: https://codereview.chromium.org/1163573007
2015-06-08 13:39:13 -07:00
halcanary
8ca89e18f5
SkPDF: fix name escape code
...
BUG=494913
Review URL: https://codereview.chromium.org/1152283014
2015-06-08 12:14:56 -07:00
cdalton
edbb31f7dd
Apply coverage in XP base class when using dst reads
...
Moves the coverage logic into GrGLXferProcessor for XPs that perform
dst reads. XPs that don't use a dst read are still responsible to
handle coverage on their own.
BUG=skia:
Review URL: https://codereview.chromium.org/1170553002
2015-06-08 12:14:44 -07:00
reed
c31af44336
change SkDraw and all Blitters to use pixmap instead of bitmap
...
BUG=skia:
Review URL: https://codereview.chromium.org/1148793007
2015-06-08 10:47:13 -07:00
rmistry
77dcbdeb19
Add benjaminwagner@ to CQ_COMMITTERS.
...
BUG=skia:
NOTRY=true
Review URL: https://codereview.chromium.org/1164933007
2015-06-08 10:22:34 -07:00
reed
7aefe03211
Revert "Revert of move erase into SkPixmap (patchset #1 id:1 of https://codereview.chromium.org/1161033005/ )"
...
This reverts commit cca9b3ac90
.
BUG=skia:
TBR=
Review URL: https://codereview.chromium.org/1153473012
2015-06-08 10:22:22 -07:00
djsollen
cca9b3ac90
Revert of move erase into SkPixmap (patchset #1 id:1 of https://codereview.chromium.org/1161033005/ )
...
Reason for revert:
broken builds
Original issue's description:
> move erase into SkPixmap
>
> harvested from https://codereview.chromium.org/1148793007
>
> BUG=skia:
> TBR=
>
> Committed: https://skia.googlesource.com/skia/+/0963f5dab079627c5523ce6a443af27a33e361f7
TBR=reed@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/1157303008
2015-06-08 10:03:49 -07:00
reed
0963f5dab0
move erase into SkPixmap
...
harvested from https://codereview.chromium.org/1148793007
BUG=skia:
TBR=
Review URL: https://codereview.chromium.org/1161033005
2015-06-08 09:16:54 -07:00
robertphillips
28937843f4
Cap color index values
...
In the provided example the color table has 10 entries but some of the pixels in the bitmap overflow. This CL goes through the pixel values and caps them to the max index.
An alternate approach would be to just have the color table always have 256 entries but zero out the unused ones.
BUG=492265
Review URL: https://codereview.chromium.org/1165493003
2015-06-08 07:10:49 -07:00
robertphillips
63195181d1
Add bigtileimagefilter GM & improvements to toString
...
This is all the ancillary code from https://codereview.chromium.org/1152553006/ (Fix dst bound reported by SkTileImageFilter).
TBR=reed@google.com , senorblanco@google.com
Review URL: https://codereview.chromium.org/1169713003
2015-06-08 06:21:14 -07:00
sergiyb
2baef5a1e1
Added CQ config to skia repo
...
This must land in sync with https://chromereviews.googleplex.com/204307013 and
revert in sync.
R=rmistry@chromium.org , tandrii@chromium.org
NOTRY=true
NOTREECHECKS=true
BUG=chromium:471767
Review URL: https://codereview.chromium.org/1153093004
2015-06-08 05:12:56 -07:00
skia.buildbots
79d6a4f827
Update SKP version
...
Automatic commit by the RecreateSKPs bot.
TBR=
NO_MERGE_BUILDS
Review URL: https://codereview.chromium.org/1167563004
2015-06-07 00:20:33 -07:00
reed
183b57f309
add extractSubset and SkAutoPixmapStorage
...
extracted from larger CL in progress: https://codereview.chromium.org/1148793007
BUG=skia:
TBR=
Review URL: https://codereview.chromium.org/1162013008
2015-06-05 14:33:17 -07:00
reed
6e764859da
clarify that accessPixels is for write-access, and peekPixels is RO
...
BUG=skia:
TBR=
Review URL: https://codereview.chromium.org/1162203005
2015-06-05 14:11:32 -07:00
bungeman
726cf9038a
Add cmap 3,0 (symbol) as Unicode fallback.
...
FreeType automatically selects the 'most Unicode' cmap available,
otherwise the default cmap is NULL. When this happens the fallback
should include the 3,0 symbol cmap, as is outlined in the Apple
TrueType documentation. This cmap should effectively be a Unicode
mapping, but exclusively in the private use area.
BUG=skia:1873,chromium:489452
Review URL: https://codereview.chromium.org/1163833003
2015-06-05 13:38:12 -07:00
cdalton
f0df189aa2
Opt for advanced blend at creation time in CrCustomXfermode
...
Modifies GrCustomXfermode to decide at creation time whether it will
use advanced blend, instead of deciding during getOptimizations.
BUG=skia:
Review URL: https://codereview.chromium.org/1161913003
2015-06-05 13:26:20 -07:00
reed
56263c78d8
delete (unused) TransparentShader
...
BUG=skia:
TBR=
Review URL: https://codereview.chromium.org/1153193014
2015-06-05 11:31:26 -07:00
djsollen
b500ffa1a2
Add ColorMatrix filter tests from Android CTS.
...
BUG=skia:3848
Review URL: https://codereview.chromium.org/1134753008
2015-06-05 09:41:18 -07:00
djsollen
fe79007a13
Update how we package skia resource for android testing
...
Review URL: https://codereview.chromium.org/1119283004
2015-06-05 09:39:30 -07:00
reed
cb67414454
use pixmaps for dst in sprites -- NO BITMAPS
...
BUG=skia:
TBR=scroggo@google.com
Review URL: https://codereview.chromium.org/1143173011
2015-06-05 06:58:22 -07:00
bsalomon
89d59883f3
Remove memcmp from GrProgramDesc op== and Less
...
Works around an ASAN complaint.
BUG=skia:3891
Review URL: https://codereview.chromium.org/1154773007
2015-06-04 15:34:34 -07:00
borenet
af6005c8a2
Presubmit: add PRESUBMIT=false to non-master branch changes
...
BUG=skia:
Review URL: https://codereview.chromium.org/1161973005
2015-06-04 15:15:42 -07:00
bsalomon
0bb8c1f2b6
Stop running tiles_rt-gpu on the bots
...
BUG=skia:
Review URL: https://codereview.chromium.org/1152003009
2015-06-04 15:10:45 -07:00