Commit Graph

35946 Commits

Author SHA1 Message Date
swiftshader-skia-autoroll
042e41debd Roll third_party/externals/swiftshader 9e22c542d6be..dd4c8631343f (1 commits)
https://swiftshader.googlesource.com/SwiftShader.git/+log/9e22c542d6be..dd4c8631343f


git log 9e22c542d6be..dd4c8631343f --date=short --no-merges --format='%ad %ae %s'
2018-08-02 capn@google.com Fix gl_FrontFacing to take GL_FRONT_FACE into account.


Created with:
  gclient setdep -r third_party/externals/swiftshader@dd4c8631343f

The AutoRoll server is located here: https://swiftshader-skia-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Test-Debian9-Clang-GCE-GPU-SwiftShader-x86_64-Debug-All-SwiftShader
TBR=scroggo@google.com

Change-Id: Ia9278d6bfb9415a52489a49fae9b3e57e15181ca
Reviewed-on: https://skia-review.googlesource.com/145120
Reviewed-by: swiftshader-skia-autoroll <swiftshader-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: swiftshader-skia-autoroll <swiftshader-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
2018-08-02 15:55:53 +00:00
Jim Van Verth
eddb3d98c6 Fix minimization function for offset code
The old code depended on a bug to work properly -- namely we could
still access edges that were marked invalid in order to do the
minimization check. Switching to linked lists removes these edges
from the list. The fix is to prioritize moving along edges that are
part of the same contour in the case of two negative results (which
represent an intersection on the testing segment).

Bug: skia:
Change-Id: I6e44e32887faa2f92dddbc204a38ffa2171ea0c6
Reviewed-on: https://skia-review.googlesource.com/143105
Reviewed-by: Robert Phillips <robertphillips@google.com>
Commit-Queue: Jim Van Verth <jvanverth@google.com>
2018-08-02 15:43:26 +00:00
Ben Wagner
e0e41efe44 [infra] Ensure Mac xSAN backfill tasks can find Xcode.
This CL prepares for installing Xcode in a Swarming cache dir from a
CIPD package. https://skia-review.googlesource.com/c/skia/+/144608

After that, I hope to isolate the xSAN libs in the Build task so that
we don't need Xcode on the xSAN test bots. Baby steps.

Change-Id: I61dbe9474eceff42cbfd824c429db382b68a8c35
Reviewed-on: https://skia-review.googlesource.com/145143
Auto-Submit: Ben Wagner <benjaminwagner@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
2018-08-02 15:35:12 +00:00
Brian Salomon
dfec99f835 Move mip map regen from GrGLProgram to GrGLGpu
Change-Id: I056d5af13aeb5c2d481286ccb06947d4ef3b948f
Reviewed-on: https://skia-review.googlesource.com/145141
Commit-Queue: Brian Salomon <bsalomon@google.com>
Commit-Queue: Greg Daniel <egdaniel@google.com>
Auto-Submit: Brian Salomon <bsalomon@google.com>
Reviewed-by: Greg Daniel <egdaniel@google.com>
2018-08-02 15:21:14 +00:00
Greg Daniel
a31f4e51d5 Make sure we check the version number of Vulkan Extensions.
Bug: skia:
Change-Id: Iff02911491cc61e39f94370c644b6666e5f9118f
Reviewed-on: https://skia-review.googlesource.com/137881
Commit-Queue: Greg Daniel <egdaniel@google.com>
Reviewed-by: Jim Van Verth <jvanverth@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
2018-08-02 14:57:45 +00:00
Ben Wagner
174d7f61ba [infra] Ensure Build-Mac backfill tasks can find Xcode.
This CL prepares for installing Xcode in a Swarming cache dir from a
CIPD package. https://skia-review.googlesource.com/c/skia/+/144608

Change-Id: I123a409f97397cc0e87de0dcd05d7ea08d3c0524
Reviewed-on: https://skia-review.googlesource.com/144903
Commit-Queue: Eric Boren <borenet@google.com>
Auto-Submit: Ben Wagner <benjaminwagner@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
2018-08-02 11:08:30 +00:00
Stephan Altmüller
64cc576b1f [infra] Make GS buckets for images and hash file URL configurable
This is necessary for lottie-ci so we can upload to different
buckets and fetch different hash files.

Bug: skia:
Change-Id: I98b4d551df34473e2b5fc04284b0de04fbc097f3
Reviewed-on: https://skia-review.googlesource.com/144840
Commit-Queue: Stephan Altmueller <stephana@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
2018-08-02 07:17:21 +00:00
angle-skia-autoroll
e43024a5ba Roll third_party/externals/angle2 038e725af257..cc73f241145d (11 commits)
038e725af2..cc73f24114


git log 038e725af257..cc73f241145d --date=short --no-merges --format='%ad %ae %s'
2018-08-01 jmadill@chromium.org Micro-optimize some validation checks.
2018-08-01 jmadill@chromium.org Final cleanup to ValidateDrawAttribs.
2018-08-01 jmadill@chromium.org Context: Cache VAO element limits.
2018-08-01 geofflang@chromium.org Remove the proxy context.
2018-08-01 geofflang@chromium.org Don't store a ref from an EGL image to its source.
2018-08-01 geofflang@chromium.org Store egl::Image size/format information at initialization time.
2018-08-01 jmadill@chromium.org Context: Use Observer pattern for container objects.
2018-08-01 jmadill@chromium.org Use ANGLE_UNLIKELY in ANGLE_TRY_HANDLE.
2018-08-01 geofflang@chromium.org Refactor RefCountObject and Binding pointer into the angle namespace.
2018-08-01 jmadill@chromium.org VertexArray: Cache element limit for buffer checks.
2018-08-01 jmadill@chromium.org D3D11: Use angle::Result error pattern. 3/3


Created with:
  gclient setdep -r third_party/externals/angle2@cc73f241145d

The AutoRoll server is located here: https://angle-skia-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE
TBR=scroggo@google.com

Change-Id: Ic44e449702d0c3f719179ef155aa8e41526f7ebe
Reviewed-on: https://skia-review.googlesource.com/144980
Reviewed-by: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
2018-08-02 01:58:50 +00:00
Ravi Mistry
ed8bc196bd Add LICENSE to third_party/vulcan
NoTry: true
Bug: skia:8217
Change-Id: I74212c3868b57cc002389277213d16ceb7604d60
Reviewed-on: https://skia-review.googlesource.com/144906
Reviewed-by: Ravi Mistry <rmistry@google.com>
Commit-Queue: Ravi Mistry <rmistry@google.com>
2018-08-01 22:48:44 +00:00
Herb Derby
049b5d9923 Combine the append glyphs
Change-Id: Iaf6341145bfe8faf2d42b4955da495d82140d281
Reviewed-on: https://skia-review.googlesource.com/144791
Reviewed-by: Herb Derby <herb@google.com>
Commit-Queue: Herb Derby <herb@google.com>
2018-08-01 21:00:47 +00:00
Brian Osman
04ae8eef82 Add color space to SkColorFilter::filterColor4f
We can assume sRGB in filterColor, but with filterColor4f, we're often
passing a color that's in a different space. We need to plumb that
through, so that mode color filter (eg) converts and works in the right
space. This color space argument is both the space of the SkColor4f
being passed, and the space that the filter operates in.

Fixes several more GMs so they render the same in glp3 and p3-gl.

Bug: skia:
Change-Id: Ia80e0f48459c3ecc9b9f86681006fe44c3009f51
Reviewed-on: https://skia-review.googlesource.com/144787
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
2018-08-01 20:45:50 +00:00
Robert Phillips
96d275a3b0 Move GrTextureStripAtlas to its own file
This is a purely mechanical change and intended to make the diff of
https://skia-review.googlesource.com/c/skia/+/144305(Update GrTextureStripAtlas for DDLs) comprehensible.

Change-Id: I85fe54dd26aef6c86536702c2e19bd3226d44ba2
Reviewed-on: https://skia-review.googlesource.com/144788
Commit-Queue: Robert Phillips <robertphillips@google.com>
Reviewed-by: Greg Daniel <egdaniel@google.com>
2018-08-01 19:41:14 +00:00
Greg Daniel
98bffae9c1 Reland "Reland "Let client pass in full extension to GrVkBackendContext.""
This reverts commit dc13c21b1e.

Reason for revert: fuchsia should be fixed

Original change's description:
> Revert "Reland "Let client pass in full extension to GrVkBackendContext.""
> 
> This reverts commit a782dcb3c4.
> 
> Reason for revert: fuchsia changes reverted
> 
> Original change's description:
> > Reland "Let client pass in full extension to GrVkBackendContext."
> > 
> > This reverts commit cb92b26e5c.
> > 
> > Reason for revert: <INSERT REASONING HERE>
> > 
> > Original change's description:
> > > Revert "Let client pass in full extension to GrVkBackendContext."
> > > 
> > > This reverts commit 45c9dab4c3.
> > > 
> > > Reason for revert: fucshia uses GrVkBackendContext. Need to revert earlier changes
> > > 
> > > Original change's description:
> > > > Let client pass in full extension to GrVkBackendContext.
> > > > 
> > > > Bug: skia:
> > > > Change-Id: I772ab4ccbca0f4f7e7d429d6c421b07d97f0606f
> > > > Reviewed-on: https://skia-review.googlesource.com/131880
> > > > Reviewed-by: Jim Van Verth <jvanverth@google.com>
> > > > Commit-Queue: Greg Daniel <egdaniel@google.com>
> > > 
> > > TBR=egdaniel@google.com,jvanverth@google.com,bsalomon@google.com
> > > 
> > > Change-Id: I1a765ff406c83cb234c3614b804fbed677d5a382
> > > No-Presubmit: true
> > > No-Tree-Checks: true
> > > No-Try: true
> > > Bug: skia:
> > > Reviewed-on: https://skia-review.googlesource.com/137901
> > > Reviewed-by: Greg Daniel <egdaniel@google.com>
> > > Commit-Queue: Greg Daniel <egdaniel@google.com>
> > 
> > TBR=egdaniel@google.com,jvanverth@google.com,bsalomon@google.com
> > 
> > # Not skipping CQ checks because original CL landed > 1 day ago.
> > 
> > Bug: skia:
> > Change-Id: I0af797c51dde705473e9afaccb1d4b4423e8c41e
> > Reviewed-on: https://skia-review.googlesource.com/138302
> > Commit-Queue: Greg Daniel <egdaniel@google.com>
> > Reviewed-by: Greg Daniel <egdaniel@google.com>
> 
> TBR=egdaniel@google.com,jvanverth@google.com,bsalomon@google.com
> 
> Change-Id: Idf760d5ac6b82df33a4408079a0223be833058ad
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: skia:
> Reviewed-on: https://skia-review.googlesource.com/138420
> Reviewed-by: Greg Daniel <egdaniel@google.com>
> Commit-Queue: Greg Daniel <egdaniel@google.com>

TBR=egdaniel@google.com,jvanverth@google.com,bsalomon@google.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: skia:
Change-Id: Ied1323b7197b600e895d85ac7e85d6f65985dabc
Reviewed-on: https://skia-review.googlesource.com/139002
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Greg Daniel <egdaniel@google.com>
2018-08-01 19:40:45 +00:00
Greg Daniel
def554697b Include windows.h in debug windows vulkan to fix build.
Bug: skia:
Change-Id: Iffe16e9d179fe63c68851bc2d421f56113c302ad
Reviewed-on: https://skia-review.googlesource.com/144789
Commit-Queue: Greg Daniel <egdaniel@google.com>
Commit-Queue: Ben Wagner <bungeman@google.com>
Reviewed-by: Ben Wagner <bungeman@google.com>
Auto-Submit: Greg Daniel <egdaniel@google.com>
2018-08-01 17:57:08 +00:00
Chris Dalton
b91c46616a Don't change the front face direction in Vulkan
This fixed a similar regression in GL, so it will probably fix the Vk
one as well.

Bug: skia:
Change-Id: I37a65cb2d1d2ba5e43015c7a6133a7aa9a4f8512
Reviewed-on: https://skia-review.googlesource.com/144832
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Chris Dalton <csmartdalton@google.com>
2018-08-01 17:47:47 +00:00
swiftshader-skia-autoroll
120517154c Roll third_party/externals/swiftshader 7f1c3d07e961..9e22c542d6be (1 commits)
https://swiftshader.googlesource.com/SwiftShader.git/+log/7f1c3d07e961..9e22c542d6be


git log 7f1c3d07e961..9e22c542d6be --date=short --no-merges --format='%ad %ae %s'
2018-08-01 sugoi@google.com TSAN fix


Created with:
  gclient setdep -r third_party/externals/swiftshader@9e22c542d6be

The AutoRoll server is located here: https://swiftshader-skia-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Test-Debian9-Clang-GCE-GPU-SwiftShader-x86_64-Debug-All-SwiftShader
TBR=scroggo@google.com

Change-Id: I666dbc40e20ee47630c981b156f69fae9bcfb96b
Reviewed-on: https://skia-review.googlesource.com/144861
Reviewed-by: swiftshader-skia-autoroll <swiftshader-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: swiftshader-skia-autoroll <swiftshader-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
2018-08-01 17:42:27 +00:00
Brian Salomon
e632dfcb36 Use GrTextureType to determine highest supported filter
Change-Id: I8deaa5dea45a2dcc743f781e9ef8f624da1d16c0
Reviewed-on: https://skia-review.googlesource.com/144786
Commit-Queue: Brian Salomon <bsalomon@google.com>
Commit-Queue: Greg Daniel <egdaniel@google.com>
Auto-Submit: Brian Salomon <bsalomon@google.com>
Reviewed-by: Greg Daniel <egdaniel@google.com>
2018-08-01 17:24:52 +00:00
Hal Canary
972eba3c5c sk_tool::Registry: make an iterator.
Change-Id: Icf4e31b50bbd91b7ea330a1300f736d6dfd0a41c
Reviewed-on: https://skia-review.googlesource.com/144500
Commit-Queue: Ben Wagner <bungeman@google.com>
Reviewed-by: Ben Wagner <bungeman@google.com>
Auto-Submit: Hal Canary <halcanary@google.com>
2018-08-01 16:59:19 +00:00
Greg Daniel
da16cce7d9 Use our own checked in Vulkan header to build skia source code.
Core Skia will always include our own SkiaVulkan.h which basically just
includes vulkan_core.h. All platform vulkan specific stuff must be
include by the client in their own vulkan.h file. Our public interface
is set up that we only use vulkan objects that will be present in all
versions of vulkan headers that the client could include.

Bug: skia:
Change-Id: I6673fd91498eabcc923d65d20f2b5e0a89b4ccf6
Reviewed-on: https://skia-review.googlesource.com/142985
Commit-Queue: Greg Daniel <egdaniel@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
2018-08-01 16:52:20 +00:00
angle-skia-autoroll
7e26aa235f Roll third_party/externals/angle2 ad63728be30d..038e725af257 (1 commits)
ad63728be3..038e725af2


git log ad63728be30d..038e725af257 --date=short --no-merges --format='%ad %ae %s'
2018-08-01 jmadill@chromium.org D3D11: Use angle::Result error pattern. 2/3


Created with:
  gclient setdep -r third_party/externals/angle2@038e725af257

The AutoRoll server is located here: https://angle-skia-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE
TBR=scroggo@google.com

Change-Id: I02d426615485dbc9f5ecb5d103ff2f88111a4622
Reviewed-on: https://skia-review.googlesource.com/144860
Reviewed-by: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
2018-08-01 16:33:58 +00:00
Brian Salomon
ee783966d4 templatize GrSurfaceProxyRef
Change-Id: I23e848d852a0c126a6581d2682af3f9e927e876f
Reviewed-on: https://skia-review.googlesource.com/144607
Reviewed-by: Robert Phillips <robertphillips@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
2018-08-01 15:15:56 +00:00
Bruce Wang
77bf48ab5f Generate Emoji rendering test using typeface created by different font files.
Change-Id: Iab1c5c19a8fe9dfdaaf0cc95f24718f5ad08c61f
Reviewed-on: https://skia-review.googlesource.com/142172
Reviewed-by: Ben Wagner <bungeman@google.com>
Commit-Queue: Ben Wagner <bungeman@google.com>
2018-08-01 14:51:25 +00:00
skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com
d27620d6a2 Roll skia/third_party/skcms dc97dc542b6d..95d1987a561d (1 commits)
https://skia.googlesource.com/skcms.git/+log/dc97dc542b6d..95d1987a561d

2018-08-01 mtklein@google.com pay some attention to apply_tf()


The AutoRoll server is located here: https://skcms-skia-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
TBR=scroggo@google.com

Change-Id: I4ac39555011685f177143758bdb4de8060221a1d
Reviewed-on: https://skia-review.googlesource.com/144764
Commit-Queue: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
2018-08-01 14:30:04 +00:00
Florin Malita
5d3ff438fe Fix !defined(SK_XML) builds
Add guards for dependent code.

TBR=
Change-Id: I49c0c90a2defc6f39589721f95562e9e0f17db13
Reviewed-on: https://skia-review.googlesource.com/144610
Reviewed-by: Florin Malita <fmalita@chromium.org>
Commit-Queue: Florin Malita <fmalita@chromium.org>
2018-08-01 14:28:56 +00:00
Timothy Liang
70c787ae5b implemented copy surface as draw then blit for metal gpu backend
Bug: skia:
Change-Id: Ifa2d7ced7c22f74c2829d11b24557dbe851e3473
Reviewed-on: https://skia-review.googlesource.com/142691
Commit-Queue: Timothy Liang <timliang@google.com>
Reviewed-by: Greg Daniel <egdaniel@google.com>
2018-08-01 14:22:45 +00:00
Ben Wagner
722efde79c [Bazel] Add lottie as dm source.
Depends on internal CL.

No-Try: true
Change-Id: I816e003b36799c5f188189bba6b0d0cacd933c45
Reviewed-on: https://skia-review.googlesource.com/144643
Reviewed-by: Florin Malita <fmalita@chromium.org>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
2018-08-01 13:53:00 +00:00
Greg Daniel
d3e65aa758 Move GrVkInterface out of public API.
Bug: skia:
Change-Id: I8b73982e4c9372af1c35bfc5e665c2c146d7d9f5
Reviewed-on: https://skia-review.googlesource.com/141121
Commit-Queue: Greg Daniel <egdaniel@google.com>
Reviewed-by: Jim Van Verth <jvanverth@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
2018-08-01 13:45:55 +00:00
Nigel Tao
9b9453e907 Have CodecTest's check not skip 'complete' tests
As currently written, some code paths trigger a return, which
inadvertently avoids the "let's run the same test again on full decodes"
at the bottom of the function.

Bug: skia:
Change-Id: I89a06ec6398099d2bfa3b0e81bb9077a28a7f096
Reviewed-on: https://skia-review.googlesource.com/144241
Reviewed-by: Leon Scroggins <scroggo@google.com>
Commit-Queue: Leon Scroggins <scroggo@google.com>
2018-08-01 13:44:35 +00:00
Nigel Tao
afea9c32ac Avoid infinite loop in Codec_requiredFrame test
Prior to this commit, the test would finish (and pass) with a correct
SkCodec implementation, but could infinite loop (instead of finish with
failure) with an incorrect implementation.

Bug: skia:
Change-Id: I89e8cfef9837c50e83a23e67a40204a9478a17cb
Reviewed-on: https://skia-review.googlesource.com/144740
Reviewed-by: Leon Scroggins <scroggo@google.com>
Commit-Queue: Leon Scroggins <scroggo@google.com>
2018-08-01 13:29:21 +00:00
Brian Salomon
fd98c2c871 Make some GrSurfaceProxy and GrTextureProxy methods easier to access
Move peek[Surface|Texture|RenderTarget]() from GrSurfaceProxyPriv to
to GrSurfaceProxy.

Move proxyMipMapped(), textureType(), and hasRestrictedSampling()
from GrTextureProxyPriv to GrTextureProxy.

Change-Id: I259114d0508c4613d55f7f1faccac362fa6fb281
Reviewed-on: https://skia-review.googlesource.com/144641
Commit-Queue: Robert Phillips <robertphillips@google.com>
Reviewed-by: Robert Phillips <robertphillips@google.com>
2018-08-01 12:00:47 +00:00
angle-skia-autoroll
f4bf7fc35d Roll third_party/externals/angle2 2eb65034db71..ad63728be30d (6 commits)
2eb65034db..ad63728be3


git log 2eb65034db71..ad63728be30d --date=short --no-merges --format='%ad %ae %s'
2018-07-31 jmadill@chromium.org VertexArray: Store bound attributes mask in binding.
2018-07-31 jmadill@chromium.org Refactor client check from ValidateDrawAttribs.
2018-07-31 courtneygo@google.com Update name of ANGLE Android apk to match expectations
2018-07-31 jmadill@chromium.org Context: Cache attributes masks.
2018-07-31 ianelliott@google.com Add Android-specific version struct to GetSystemInfo results.
2018-07-31 oetuaho@nvidia.com Allow reads from a multiview framebuffer with one view


Created with:
  gclient setdep -r third_party/externals/angle2@ad63728be30d

The AutoRoll server is located here: https://angle-skia-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE
TBR=scroggo@google.com

Change-Id: I6266c2bb41d6455ccc172edd1b17a0a1afe5d059
Reviewed-on: https://skia-review.googlesource.com/144700
Reviewed-by: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
2018-08-01 02:11:57 +00:00
recipe-roller
c1de8bd2ba Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
depot_tools:
  https://crrev.com/6f812e132d25df1b561f7182b04903004a3055e4 metrics: Separate metrics collection and print notice logic. (ehmaldonado@chromium.org)


TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ibd0c49925bb806e24a92ee3edc77318c0e59d592
Reviewed-on: https://skia-review.googlesource.com/144644
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
2018-07-31 23:15:26 +00:00
Mike Reed
6cfa297382 remove conditional flags for sksg -- not needed for a module
Bug: skia:
Change-Id: I1b73379bd8a1ba2cd4293180052ba7ad59dfe96f
Reviewed-on: https://skia-review.googlesource.com/144642
Reviewed-by: Florin Malita <fmalita@chromium.org>
Commit-Queue: Mike Reed <reed@google.com>
2018-07-31 22:27:20 +00:00
Christopher Cameron
e2da5f90ac Revert "Disable GPU clip masks"
This reverts commit 2272ea2a4b.

Reason for revert: https://crbug.com/863817
- We are experiencing GPU process instability on Mac
- Crash is in GL driver
- The instability only happens with GPU raster enabled
- This is in the culprit range and affect GL calls made

Original change's description:
> Disable GPU clip masks
> 
> Bug: skia:
> Change-Id: I3abacfd17ea6247d0bdb2ab8a2584a88bf468dad
> Reviewed-on: https://skia-review.googlesource.com/140776
> Reviewed-by: Stephen White <senorblanco@chromium.org>
> Reviewed-by: Brian Salomon <bsalomon@google.com>
> Commit-Queue: Chris Dalton <csmartdalton@google.com>

TBR=bsalomon@google.com,robertphillips@google.com,senorblanco@chromium.org,csmartdalton@google.com,senorblanco@google.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: skia:
Change-Id: Ia6c0e6f5dcede2aff7b0c3c6e19d47c255bb3991
Reviewed-on: https://skia-review.googlesource.com/144660
Reviewed-by: Christopher Cameron <ccameron@google.com>
Commit-Queue: Christopher Cameron <ccameron@google.com>
2018-07-31 21:58:16 +00:00
Ben Wagner
144113774a Remove SK_IGNORE_SUBPIXEL_EMOJI_FIX.
No longer needed as users have been rebaselined.

Change-Id: Ie61d6ab8567685039ba11d9390ea8db8deefa954
Reviewed-on: https://skia-review.googlesource.com/144640
Auto-Submit: Ben Wagner <bungeman@google.com>
Reviewed-by: Ben Wagner <bungeman@google.com>
Commit-Queue: Ben Wagner <bungeman@google.com>
2018-07-31 21:36:54 +00:00
Benjamin Barenblat
fd10d170ee Set -Wno-implicit-fallthrough when building for iOS
Change-Id: I281336e4b0639c25ea98402b5dd194aa21bf560f
Reviewed-on: https://skia-review.googlesource.com/144611
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
2018-07-31 21:27:56 +00:00
Herb Derby
0ab5ce151c Move path leaf loop to drawer
This CL makes GPU and Raster use the same path drawing interface. When
I get the main body of regenerate over into the glyph run system, I
I can refactor a lot of annoyingly similar code away.

Change-Id: I6bd2e6119570062695d6943565749d85555b03fa
Reviewed-on: https://skia-review.googlesource.com/144350
Reviewed-by: Jim Van Verth <jvanverth@google.com>
Commit-Queue: Herb Derby <herb@google.com>
2018-07-31 20:51:18 +00:00
Joe Gregorio
a83bb57bfe Use a larger machine for our cloud build.
Bug: skia:
Change-Id: I51ea222fb36f521f34f7a870a225423f8a46c887
Reviewed-on: https://skia-review.googlesource.com/144609
Auto-Submit: Joe Gregorio <jcgregorio@google.com>
Reviewed-by: Ravi Mistry <rmistry@google.com>
Commit-Queue: Ravi Mistry <rmistry@google.com>
2018-07-31 20:40:33 +00:00
Hal Canary
f107a2fd01 SkUTF
Create new header and namespace, `SkUTF` where we are putting all of our
robust, well documented UTF-8, UTF-16, and UTF-32 functions:
`SkUTF::{Count,Next,To}UTF{8,16,32}()`.

SkUTF.h and SkUTF.cpp do not depend on the rest of Skia and are suitable
for re-use in other modules.

Some of the old UTF-{8,16} functions still live in SkUtils.h; their use
will be phased out in future CLs.

Also added more unit testing and cleaned up old tests.

Removed functions that were unused outside of tests or used only once.

Change-Id: Iaa59b8705abccf9c4ba082f855da368a0bad8380
Reviewed-on: https://skia-review.googlesource.com/143306
Reviewed-by: Ben Wagner <bungeman@google.com>
Commit-Queue: Hal Canary <halcanary@google.com>
2018-07-31 20:11:19 +00:00
skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com
1935aa3d27 Roll skia/third_party/skcms f80f027f8ac9..dc97dc542b6d (1 commits)
https://skia.googlesource.com/skcms.git/+log/f80f027f8ac9..dc97dc542b6d

2018-07-31 mtklein@google.com turn on -fsanitize=integer on portable bot


The AutoRoll server is located here: https://skcms-skia-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
TBR=scroggo@google.com

Change-Id: Ided624d7a976be030f278d86d1ef91c57b1d4ad0
Reviewed-on: https://skia-review.googlesource.com/144623
Commit-Queue: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
2018-07-31 19:30:48 +00:00
Brian Salomon
e782f8472f Remove GrResourceIOProcessor.
Fold its functionality into GrPrimitiveProcessor and GrFragmentProcessor.

Make each have its own TextureSampler nested class. Currently the only
difference is that fragment processors lose the ability to inject their
samplers into the vertex shader. However, this facilitates refactoring
GrPrimitiveProcessor's TextureSampler class such that the textures are
specified separately from the TextureSampler.

Bug: skia:
Change-Id: I1e590187e7a6ae79ee3147155d397fcdcf5e4619
Reviewed-on: https://skia-review.googlesource.com/142814
Commit-Queue: Brian Salomon <bsalomon@google.com>
Reviewed-by: Robert Phillips <robertphillips@google.com>
2018-07-31 18:16:11 +00:00
skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com
990ec990a6 Roll skia/third_party/skcms 2925dc93401c..f80f027f8ac9 (1 commits)
https://skia.googlesource.com/skcms.git/+log/2925dc93401c..f80f027f8ac9

2018-07-31 mtklein@google.com add portable *SAN bot


The AutoRoll server is located here: https://skcms-skia-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
TBR=scroggo@google.com

Change-Id: I431d3d2be5ed72232779b954e3c18df49ea2af70
Reviewed-on: https://skia-review.googlesource.com/144590
Commit-Queue: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
2018-07-31 17:36:55 +00:00
Ben Wagner
b303a427c0 [Bazel] Reformat public.bzl with buildifier.
Bug: skia:8210
No-Try: true
Change-Id: I259fa3ee0bccdfb8999366596a0b210626ee26aa
Reviewed-on: https://skia-review.googlesource.com/144501
Commit-Queue: Mike Klein <mtklein@google.com>
Auto-Submit: Ben Wagner <benjaminwagner@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
2018-07-31 17:10:00 +00:00
Brian Salomon
ae5f9534b1 Remove unused GrGpuResourceRef and GrTGpuResourceRef
Change-Id: I8b4b323549f51e4601ccb6612f65d354e163e93c
Reviewed-on: https://skia-review.googlesource.com/144504
Auto-Submit: Brian Salomon <bsalomon@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>
Reviewed-by: Robert Phillips <robertphillips@google.com>
2018-07-31 16:55:26 +00:00
angle-skia-autoroll
2f67915105 Roll third_party/externals/angle2 67c388e6c04e..2eb65034db71 (1 commits)
67c388e6c0..2eb65034db


git log 67c388e6c04e..2eb65034db71 --date=short --no-merges --format='%ad %ae %s'
2018-07-31 jmadill@chromium.org Add Context::getActiveBufferedAttribsMask.


Created with:
  gclient setdep -r third_party/externals/angle2@2eb65034db71

The AutoRoll server is located here: https://angle-skia-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE
TBR=scroggo@google.com

Change-Id: I6722e3c9d7d243344a300a8d4d63f8f6c1f2be0b
Reviewed-on: https://skia-review.googlesource.com/144560
Reviewed-by: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
2018-07-31 16:44:23 +00:00
Timothy Liang
e30739a1e1 implemented copy surface as draw for metal gpu backend
Bug: skia:
Change-Id: Ie61bd6ad9f288b8a025d44f887a0954101a7d710
Reviewed-on: https://skia-review.googlesource.com/142687
Commit-Queue: Timothy Liang <timliang@google.com>
Reviewed-by: Greg Daniel <egdaniel@google.com>
2018-07-31 16:25:55 +00:00
Chris Dalton
c8ece3d5f8 Don't use glFrontFace
This is an exploratory commit to see if glFrontFace is the cause of
a recent perf regression. Instead we invert gl_FrontFacing in SkSL.

Bug: skia:
Change-Id: Ida6f6435785e814c089ad34ba2f32793c4ac23c4
Reviewed-on: https://skia-review.googlesource.com/144410
Reviewed-by: Ethan Nicholas <ethannicholas@google.com>
Commit-Queue: Chris Dalton <csmartdalton@google.com>
2018-07-31 16:19:12 +00:00
swiftshader-skia-autoroll
5cfb04a684 Roll third_party/externals/swiftshader be5fe7797f1e..7f1c3d07e961 (1 commits)
https://swiftshader.googlesource.com/SwiftShader.git/+log/be5fe7797f1e..7f1c3d07e961


git log be5fe7797f1e..7f1c3d07e961 --date=short --no-merges --format='%ad %ae %s'
2018-07-31 capn@google.com Fix validation of uniform block size.


Created with:
  gclient setdep -r third_party/externals/swiftshader@7f1c3d07e961

The AutoRoll server is located here: https://swiftshader-skia-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Test-Debian9-Clang-GCE-GPU-SwiftShader-x86_64-Debug-All-SwiftShader
TBR=scroggo@google.com

Change-Id: I8e2da3a613114e9287a1adfab4432b746348652d
Reviewed-on: https://skia-review.googlesource.com/144520
Reviewed-by: swiftshader-skia-autoroll <swiftshader-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: swiftshader-skia-autoroll <swiftshader-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
2018-07-31 15:37:56 +00:00
Ethan Nicholas
0054311bf3 Re-re-land "added GrSkSLFP and converted DitherEffect to use it"
This reverts commit 6c48e4d11c.

Bug: skia:
Change-Id: I7ee78990fc30eec545d1856e59eb6e0573089426
Reviewed-on: https://skia-review.googlesource.com/144348
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
2018-07-31 15:18:03 +00:00
skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com
ce3c7bbd0d Roll skia/third_party/skcms c663954a7567..2925dc93401c (1 commits)
https://skia.googlesource.com/skcms.git/+log/c663954a7567..2925dc93401c

2018-07-31 mtklein@google.com more C++


The AutoRoll server is located here: https://skcms-skia-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
TBR=scroggo@google.com

Change-Id: I7d4c2c447aa68415d1e1bd65b14902521342d8aa
Reviewed-on: https://skia-review.googlesource.com/144483
Reviewed-by: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
2018-07-31 15:15:43 +00:00