Commit Graph

5830 Commits

Author SHA1 Message Date
humper@google.com
05af1afd42 eliminate all warnings in non-thirdparty code on mac
Most of these issues were due to functions whose definitions appear in header files; I changed those functions to be 'static inline' instead of just 'static' or 'inline', which kills the warning for such functions.

Other functions that were static or anonymous-namespaced but were unused in cpp files were probably called at some point but are no longer; someone who knows more than I do should probably scrub all the functions I either deleted or #if 0'ed out and make sure that the right thing is happening here.

Lots of unused variables removed, and one nasty const issue handled.

There remains a single warning in thirdparty/externals/cityhash/src/city.cc on line 146 related to a signed/unsigned mismatch.  I don't know if we have control over this library so I didn't fix this one, but perhaps someone could do something about that one.

BUG=

Review URL: https://codereview.appspot.com/7067044

git-svn-id: http://skia.googlecode.com/svn/trunk@7051 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-07 16:47:43 +00:00
rmistry@google.com
30454293fd Rebaselined webpage image GMs for ['base-android-xoom'] on Google Storage.
git-svn-id: http://skia.googlecode.com/svn/trunk@7050 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-07 16:30:35 +00:00
rmistry@google.com
97c982db07 Rebaselined webpage image GMs for %s on Google Storage.
git-svn-id: http://skia.googlecode.com/svn/trunk@7049 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-07 16:27:33 +00:00
humper@google.com
f515ffc3d4 Show the paint's typeface information in the details pane of the debugger.
Also add a convenience constructor for SkMemoryStream that takes the SkData directly
(instead of having to construct an empty one and call setData).
Review URL: https://codereview.appspot.com/7065045

git-svn-id: http://skia.googlecode.com/svn/trunk@7048 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-07 15:48:19 +00:00
sugoi@google.com
e3453cbd20 This CL introduces a new path renderer.
Here are the characteristics :
- It uses the original path, before stroking
- It supports traight lines only (no curves)
- It supports butt or square caps only
- It supports miter or bevel joins only
- No AA support
Support for these will be added step by step later on.

A first pass at the benchmarks on my linux machine gave me these approximate speed improvements (running all bench with the option '--forceAA 0') :
path_stroke_small_long_line 4X
path_stroke_small_sawtooth 4X
path_stroke_big_rect 4X
path_stroke_small_rect 6X
path_stroke_big_triangle 4X
path_stroke_small_triangle 10X
lines_1_BW 1.5X
dashline_2_square 1.5X
dashline_1_square 1.5X

Also note that I can't submit this code until GrDrawTarget::isOpaque() is implemented, unless I just disable my renderer completely for now.

BUG=chromium:135111
TEST=The following gms are affected and may require rebaselining : lineclosepath, linepath, strokes_poly
Review URL: https://codereview.appspot.com/7026049

git-svn-id: http://skia.googlecode.com/svn/trunk@7047 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-07 14:26:40 +00:00
caryclark@google.com
d68bc309bb shape ops work in progress
cubic to quadratic experiment

git-svn-id: http://skia.googlecode.com/svn/trunk@7046 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-07 13:17:18 +00:00
robertphillips@google.com
2b4e5445d2 re-add SkRefPtr to SkRefCnt.h until all uses of it have been removed from Chrome
git-svn-id: http://skia.googlecode.com/svn/trunk@7044 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-07 00:58:00 +00:00
rmistry@google.com
13d8d09685 Whitespace change to trigger rebuilds
git-svn-id: http://skia.googlecode.com/svn/trunk@7043 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-06 02:06:03 +00:00
reed@google.com
ce1f3cc1e2 Fix the computed (new) inverse matrix when we detect that a shader's matrix
can effectively be consider translate-only.
Review URL: https://codereview.appspot.com/7060043

git-svn-id: http://skia.googlecode.com/svn/trunk@7039 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-05 14:37:48 +00:00
skia.committer@gmail.com
8ae714b186 Sanitizing source files in Skia_Periodic_House_Keeping
git-svn-id: http://skia.googlecode.com/svn/trunk@7038 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-05 02:02:05 +00:00
reed@google.com
ac0d47ecb8 move include of src/effects into general, and out of gpu-specific
git-svn-id: http://skia.googlecode.com/svn/trunk@7037 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-04 23:06:44 +00:00
reed@google.com
697c1e1724 disable some new tests until we debug an rtree failure
git-svn-id: http://skia.googlecode.com/svn/trunk@7036 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-04 23:02:50 +00:00
humper@google.com
7c7292c607 Added a new function to directly generate a blurred rectangle analytically.
Added two new microbenchmarks to demonstrate speedup over existing BlurSeparable approach.

Added new GM tests for blurred rectangles. 
Review URL: https://codereview.appspot.com/7037050

git-svn-id: http://skia.googlecode.com/svn/trunk@7034 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-04 20:29:03 +00:00
vandebo@chromium.org
f7b62d6ff2 Remove unused variable.
Review URL: https://codereview.appspot.com/7035062

git-svn-id: http://skia.googlecode.com/svn/trunk@7032 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-04 19:42:39 +00:00
caryclark@google.com
6d0032a8ec shape ops work in progress
git-svn-id: http://skia.googlecode.com/svn/trunk@7031 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-04 19:41:13 +00:00
vandebo@chromium.org
d96d17b9c1 Remove SkRefPtr
(resubmit of https://codereview.appspot.com/7030059/)
TBR=junov@google.com

Review URL: https://codereview.appspot.com/7030065

git-svn-id: http://skia.googlecode.com/svn/trunk@7030 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-04 19:31:24 +00:00
reed@google.com
4a1362a3c9 add SK_IGNORE_FAST_SCALEMATRIX_INVERT guard for new invert code
git-svn-id: http://skia.googlecode.com/svn/trunk@7025 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-04 18:52:16 +00:00
bsalomon@google.com
34cccde630 Allow GrEffects with multiple textures.
It will work as long as the total number of textures sis less than GrDrawState::kNumStages. That will be fixed in a follow up CL.
Review URL: https://codereview.appspot.com/7040052

git-svn-id: http://skia.googlecode.com/svn/trunk@7023 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-04 18:34:30 +00:00
vandebo@chromium.org
6eb549e8ca Revert "Remove SkRefPtr" - r7021
samplecode/ still needs to be updated.

Review URL: https://codereview.appspot.com/7032048

git-svn-id: http://skia.googlecode.com/svn/trunk@7022 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-04 18:11:21 +00:00
vandebo@chromium.org
e8a76ae8ed Remove SkRefPtr
Review URL: https://codereview.appspot.com/7030059

git-svn-id: http://skia.googlecode.com/svn/trunk@7021 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-04 17:59:42 +00:00
reed@google.com
2fb96cc5d7 special-case matrix invert for translate and scale
update unittest to use diff scale-x and scale-y values, and tests for non-invertible scale matrices
Review URL: https://codereview.appspot.com/7027055

git-svn-id: http://skia.googlecode.com/svn/trunk@7019 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-04 17:02:33 +00:00
robertphillips@google.com
be61c05d89 Fix Android texture cacheID issue (npot flag not generated correctly)
https://codereview.appspot.com/7042046/



git-svn-id: http://skia.googlecode.com/svn/trunk@7018 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-04 16:33:44 +00:00
reed@google.com
90533be035 add matrixbench for invert_translate
git-svn-id: http://skia.googlecode.com/svn/trunk@7015 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-04 15:46:42 +00:00
djsollen@google.com
ade109f57c Fix Android compiler warnings.
Review URL: https://codereview.appspot.com/7040053

git-svn-id: http://skia.googlecode.com/svn/trunk@7014 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-04 15:29:06 +00:00
reed@google.com
fb2cd425c2 add --exclude-config to opt out of 1 or more configs. This always is respected,
regardless of the ordering of --config and --exclude-config.

add --verbose [-v] to dump extra info, e.g. what configs are being run

changed --config to enforce a unique set of configs to be run, such that
--config 8888 --config 8888 results in just 1 run of 8888.
Review URL: https://codereview.appspot.com/7027053

git-svn-id: http://skia.googlecode.com/svn/trunk@7013 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-04 14:43:03 +00:00
reed@google.com
82bf8bbcbc use DEF_BENCH to simplify registration
git-svn-id: http://skia.googlecode.com/svn/trunk@7012 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-04 14:04:08 +00:00
skia.committer@gmail.com
d9f65e3df4 Sanitizing source files in Skia_Periodic_House_Keeping
git-svn-id: http://skia.googlecode.com/svn/trunk@7010 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-04 12:07:46 +00:00
mike@reedtribe.org
b16033a25b reorder internal files, in preparation for refactoring. no functional change.
git-svn-id: http://skia.googlecode.com/svn/trunk@7009 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-04 03:16:52 +00:00
mike@reedtribe.org
5d688fb273 remove dead code from SkPath::addOval
git-svn-id: http://skia.googlecode.com/svn/trunk@7008 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-04 02:56:10 +00:00
caryclark@google.com
8f9f468b05 shape ops work in progress
basic functionality works at this point

git-svn-id: http://skia.googlecode.com/svn/trunk@7004 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-03 21:18:16 +00:00
rmistry@google.com
ee5a5eee12 * Extended skdiff to report alpha channel differences.
* Created a tools/tests/rebaseline.sh to copy output-actual into output-expected.
* Sample results are available here: http://www.corp.google.com/~rmistry/skia/gm-playback-windows/images-skdiff/
Review URL: https://codereview.appspot.com/7038048

git-svn-id: http://skia.googlecode.com/svn/trunk@7003 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-03 19:23:22 +00:00
reed@google.com
57cf9a6f25 ran gm/tests/rebaseline.sh 5-6 times to update the self-test after 6984
git-svn-id: http://skia.googlecode.com/svn/trunk@6995 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-03 15:29:03 +00:00
reed@google.com
ae57358447 use SkTreatAsSprite in SkDraw (with guard for chrome if needed)
git-svn-id: http://skia.googlecode.com/svn/trunk@6994 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-03 15:22:40 +00:00
jvanverth@google.com
9c81bd5540 Fix Windows warning: Changed implicit int32_t to SkScalar cast to explicit SkIntToScalar call.
git-svn-id: http://skia.googlecode.com/svn/trunk@6993 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-03 14:46:41 +00:00
borenet@google.com
b9ec7d0880 Yet another whitespace change
git-svn-id: http://skia.googlecode.com/svn/trunk@6991 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-03 13:55:15 +00:00
borenet@google.com
0c7d718f48 Another Whitespace Change...
git-svn-id: http://skia.googlecode.com/svn/trunk@6988 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-03 13:48:08 +00:00
borenet@google.com
262891ae55 Whitespace change to trigger rebuild
git-svn-id: http://skia.googlecode.com/svn/trunk@6986 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-03 13:37:29 +00:00
reed@google.com
5408a30c8d #undef SK_IGNORE_QUAD_STROKE_FIX, to enable the fix for stroked quads.
chrome may need to define this in preparation for rebaselining.



git-svn-id: http://skia.googlecode.com/svn/trunk@6984 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-03 13:03:30 +00:00
skia.committer@gmail.com
422188f3c6 Sanitizing source files in Skia_Periodic_House_Keeping
git-svn-id: http://skia.googlecode.com/svn/trunk@6982 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-03 02:01:32 +00:00
rmistry@google.com
7d474f8a84 The motivation for this changeset is to fix the following build failure in google3-
third_party/skia/src/core/SkCanvas.cpp:1711:61: error: non-constant-expression cannot be narrowed from type 'int32_t' (aka 'int') to 'SkScalar' (aka 'float') in initializer list [-Wc++11-narrowing]
        0, SkIntToScalar(c.fLeft), SkIntToScalar(c.fRight), w
                                                            ^
third_party/skia/src/core/SkCanvas.cpp:1711:61: note: override this message by inserting an explicit cast
        0, SkIntToScalar(c.fLeft), SkIntToScalar(c.fRight), w
                                                            ^
                                                            static_cast<SkScalar>( )
Review URL: https://codereview.appspot.com/7041044

git-svn-id: http://skia.googlecode.com/svn/trunk@6979 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-02 22:03:54 +00:00
bsalomon@google.com
672d5c2014 Fix warnings about unused function on Mac.
Review URL: https://codereview.appspot.com/6826074/



git-svn-id: http://skia.googlecode.com/svn/trunk@6976 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-02 20:33:18 +00:00
robertphillips@google.com
67baba4892 Fixed debugger for addition of drawRRect, clipRRect & drawOval
https://codereview.appspot.com/7035051/



git-svn-id: http://skia.googlecode.com/svn/trunk@6975 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-02 20:20:31 +00:00
reed@google.com
ad51430215 add unittest for SkTreatAsSprite
Review URL: https://codereview.appspot.com/7042044

git-svn-id: http://skia.googlecode.com/svn/trunk@6974 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-02 20:19:45 +00:00
bsalomon@google.com
11f20d6270 Remove GrInstanceCounter.
R=reed@google.com
Review URL: https://codereview.appspot.com/6849125

git-svn-id: http://skia.googlecode.com/svn/trunk@6972 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-02 19:57:10 +00:00
bsalomon@google.com
10a9fb86a9 Ensure that GrCacheID::Key instances are fully initialized.
R=robertphillips@google.com
Review URL: https://codereview.appspot.com/7036046

git-svn-id: http://skia.googlecode.com/svn/trunk@6971 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-02 19:29:57 +00:00
epoger@google.com
a59df04b68 Delete no-longer compiled SkRectShape.cpp
(This should have been removed in https://code.google.com/p/skia/source/detail?r=5033 )
Review URL: https://codereview.appspot.com/7035052

git-svn-id: http://skia.googlecode.com/svn/trunk@6969 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-02 18:32:53 +00:00
djsollen@google.com
a44de9617a Update documentation around picture playback.
Review URL: https://codereview.appspot.com/7034045

git-svn-id: http://skia.googlecode.com/svn/trunk@6967 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-02 16:59:19 +00:00
epoger@google.com
3aa3358c03 Add more warnings about https://code.google.com/p/skia/issues/detail?id=677 ('make tools/tests/run.sh work cross-platform')
git-svn-id: http://skia.googlecode.com/svn/trunk@6965 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-02 15:53:25 +00:00
reed@google.com
df194a47d2 remove #ifdef for scalar==float, since it always is
git-svn-id: http://skia.googlecode.com/svn/trunk@6964 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-02 15:49:25 +00:00
mike@reedtribe.org
e78dd4b529 add metadata to Click for views
git-svn-id: http://skia.googlecode.com/svn/trunk@6963 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-02 04:10:33 +00:00