Commit Graph

9845 Commits

Author SHA1 Message Date
mtklein@google.com
09f2579109 DM: add --tileGrid
BUG=
R=epoger@google.com

Review URL: https://codereview.chromium.org/88563003

git-svn-id: http://skia.googlecode.com/svn/trunk@12408 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-26 23:36:51 +00:00
bungeman@google.com
49360dfa61 Remove unused fields from SkGlyphCache.
Review URL: https://codereview.chromium.org/89423003

git-svn-id: http://skia.googlecode.com/svn/trunk@12407 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-26 23:17:46 +00:00
bungeman@google.com
4d9f094349 Yet even more rebaslines for r12400.
git-svn-id: http://skia.googlecode.com/svn/trunk@12406 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-26 23:15:51 +00:00
bungeman@google.com
8e637f0b7e Even more rebaslines for r12400.
git-svn-id: http://skia.googlecode.com/svn/trunk@12405 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-26 22:58:30 +00:00
bungeman@google.com
91ddcb365d More rebaslines for r12400.
git-svn-id: http://skia.googlecode.com/svn/trunk@12404 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-26 22:26:51 +00:00
bungeman@google.com
60b19b5dae Rebasline for r12400.
git-svn-id: http://skia.googlecode.com/svn/trunk@12403 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-26 22:15:49 +00:00
mtklein@google.com
ca5bb87a31 DM: write failed comparison mode .pngs one more level deep in the tree.
E.g.  instead of having to compare
    /tmp/dm/565/optimizations.png
vs.
    /tmp/dm/replay/optimizations_565.png

it's now

    /tmp/dm/565/optimizations.png
vs.
    /tmp/dm/replay/565/optimizations.png

This lets working with skdiff go a lot more smoothly.

BUG=
R=bsalomon@google.com

Review URL: https://codereview.chromium.org/88773002

git-svn-id: http://skia.googlecode.com/svn/trunk@12402 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-26 22:06:12 +00:00
senorblanco@chromium.org
d8f82a4c44 Enhance SkDropShadowImageFilter to support separate X & Y sigmas, and crop rect. This required a new flavour of the constructor.
This is driven by the feDropShadow filter effect in SVG, which unlike the shorthand version accepts separate X & Y sigmas.

Covered by new GM dropshadowimagefilter.

R=reed@google.com

Review URL: https://codereview.chromium.org/88243004

git-svn-id: http://skia.googlecode.com/svn/trunk@12401 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-26 21:52:38 +00:00
bungeman@google.com
7435f34b47 Minimal changes to not crash GPU with color fonts.
Review URL: https://codereview.chromium.org/88993003

git-svn-id: http://skia.googlecode.com/svn/trunk@12400 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-26 20:43:27 +00:00
commit-bot@chromium.org
3daa1aed7a Support linking skia statically on Android
Support linking skia statically on Android. Skia symbols should be
exported by the app library, to the extent that skia_launcher needs
them.

Syncs libskia_android.so to the device only if it exists.

R=djsollen@google.com

Author: kkinnunen@nvidia.com

Review URL: https://codereview.chromium.org/61893008

git-svn-id: http://skia.googlecode.com/svn/trunk@12399 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-26 20:39:11 +00:00
mtklein@google.com
ee21a3e395 DM: some refactoring
- rename ComparisonTask to ChecksumTask
  - have ChecksumTask handle all the checksum-checking
  - turn on all extra modes by default
  - simplify progress output to a countdown

BUG=
R=bsalomon@google.com

Review URL: https://codereview.chromium.org/88543002

git-svn-id: http://skia.googlecode.com/svn/trunk@12398 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-26 18:52:31 +00:00
epoger@google.com
d7255b6ae4 rebaseline_server: make --reload work in git checkout
(SkipBuildbotRuns)

R=rmistry@google.com

Review URL: https://codereview.chromium.org/86343002

git-svn-id: http://skia.googlecode.com/svn/trunk@12397 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-26 17:59:28 +00:00
rmistry@google.com
7affd1fd6a Removing 3 more SKPs to fix BenchPictures in Debug
git-svn-id: http://skia.googlecode.com/svn/trunk@12396 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-26 17:29:49 +00:00
rmistry@google.com
69968a3e84 Removed 3 more SKPs that were failing in Debug
git-svn-id: http://skia.googlecode.com/svn/trunk@12395 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-26 16:26:16 +00:00
rmistry@google.com
c56b179c7c Removed desk_wowwiki.skp. Whitespace change to trigger rebuilds.
git-svn-id: http://skia.googlecode.com/svn/trunk@12394 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-26 15:46:14 +00:00
rmistry@google.com
560cfc4877 Buildbot SKPs have been refreshed. Whitespace change to trigger rebuilds.
git-svn-id: http://skia.googlecode.com/svn/trunk@12393 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-26 14:43:01 +00:00
commit-bot@chromium.org
11f392ed53 Revert "Revert "remove kA1_Config, as it is no longer supported""
This reverts commit 36d712f2d4c5c79719280ad95523e6aaa88b068e.

BUG=
R=rmistry@google.com, mtklein@google.com

Author: reed@google.com

Review URL: https://codereview.chromium.org/86483002

git-svn-id: http://skia.googlecode.com/svn/trunk@12392 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-26 12:51:57 +00:00
commit-bot@chromium.org
6300f4d1f3 Add 'skiapict' magic bytes to SkPicture format.
Testing: out/Debug/tests && out/Release/gm --replay --serialize


BUG=
R=fmalita@google.com, reed@google.com, fmalita@chromium.org

Author: mtklein@google.com

Review URL: https://codereview.chromium.org/27408002

git-svn-id: http://skia.googlecode.com/svn/trunk@12391 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-26 12:46:59 +00:00
commit-bot@chromium.org
7f78611271 Clean up 4 old bytes per paint.
BUG=
R=reed@google.com

Author: mtklein@google.com

Review URL: https://codereview.chromium.org/27370003

git-svn-id: http://skia.googlecode.com/svn/trunk@12390 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-26 12:46:52 +00:00
skia.committer@gmail.com
ec18ce7df6 Sanitizing source files in Housekeeper-Nightly
git-svn-id: http://skia.googlecode.com/svn/trunk@12389 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-26 07:02:21 +00:00
commit-bot@chromium.org
ce33d60187 Adding more validation
- Added a way to check that the number of inputs of a filter is not more than a filter expects
- Added validation of reftype in SkBitmap::unflatten()
- Added validation on fKD (diffuse lighting constant) and fKS (specular lighting constant) to make sure that they are always non-negative numbers
- Added validation of SkPerlinNoiseShader::fType and SkPerlinNoiseShader::fNumOctaves

BUG=
R=reed@google.com, senorblanco@google.com, mtklein@google.com, senorblanco@chromium.org, sugoi@google.com

Author: sugoi@chromium.org

Review URL: https://codereview.chromium.org/83343003

git-svn-id: http://skia.googlecode.com/svn/trunk@12388 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-25 21:46:31 +00:00
reed@google.com
72e7808d62 Revert "remove kA1_Config, as it is no longer supported"
This reverts commit 2d72d8b242eac6e9d30228f5b0a407236491c369.

git-svn-id: http://skia.googlecode.com/svn/trunk@12387 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-25 20:54:56 +00:00
commit-bot@chromium.org
aae7c2a5b7 Export GrGLCreateNullInterface for use in Chromium compositor unit tests.
R=bsalomon@google.com

Author: mvujovic@adobe.com

Review URL: https://codereview.chromium.org/86353002

git-svn-id: http://skia.googlecode.com/svn/trunk@12386 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-25 20:39:27 +00:00
commit-bot@chromium.org
4b413c8bb1 remove SkFloatToScalar macro
BUG=
R=reed@google.com, djsollen@google.com

Author: caryclark@google.com

Review URL: https://codereview.chromium.org/85463005

git-svn-id: http://skia.googlecode.com/svn/trunk@12385 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-25 19:44:07 +00:00
reed@google.com
2a1f4464d1 remove kA1_Config, as it is no longer supported
BUG=
R=djsollen@google.com

Review URL: https://codereview.chromium.org/83093005

git-svn-id: http://skia.googlecode.com/svn/trunk@12384 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-25 18:58:29 +00:00
commit-bot@chromium.org
7578b3efc6 Add logan to android_setup.sh
R=djsollen@google.com, bsalomon@google.com, robertphillips@google.com

Author: borenet@google.com

Review URL: https://codereview.chromium.org/82523006

git-svn-id: http://skia.googlecode.com/svn/trunk@12383 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-25 18:54:44 +00:00
robertphillips@google.com
c1ca941ff1 Rebaseline lingering (Ubuntu13) image for r12357
https://codereview.chromium.org/85203004/



git-svn-id: http://skia.googlecode.com/svn/trunk@12382 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-25 18:13:33 +00:00
epoger@google.com
b063e13428 rebaseline_server: remove deprecated-expectations-dir option
followup to https://codereview.chromium.org/81243002/ ('rebaseline_server:
deprecate --expectations-dir option in advance of git transition')

(SkipBuildbotRuns)

R=borenet@google.com

Review URL: https://codereview.chromium.org/86043002

git-svn-id: http://skia.googlecode.com/svn/trunk@12381 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-25 18:06:29 +00:00
commit-bot@chromium.org
eddb02c82d Adding SkDeferredCanvas::NoticifationClient to the exported API.
R=reed@android.com, robertphillips@google.com, reed, robertphillips
BUG=1861

Author: schenney@chromium.org

Review URL: https://codereview.chromium.org/83383007

git-svn-id: http://skia.googlecode.com/svn/trunk@12380 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-25 15:44:37 +00:00
caryclark@google.com
02352d14d4 remove more unused static functions
git-svn-id: http://skia.googlecode.com/svn/trunk@12379 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-25 15:05:05 +00:00
caryclark@google.com
111417aae9 remove unused static function
git-svn-id: http://skia.googlecode.com/svn/trunk@12378 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-25 14:36:58 +00:00
caryclark@google.com
927b7028d4 remove unused reduce order code
BUG=

Review URL: https://codereview.chromium.org/85763002

git-svn-id: http://skia.googlecode.com/svn/trunk@12377 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-25 14:18:21 +00:00
commit-bot@chromium.org
6fcb0cdaa2 Revert of https://codereview.chromium.org/85343004/
Reason for revert: Reverting the temporary CL

TBR=
NOTREECHECKS=true
NOTRY=true

Author: rmistry@google.com

Review URL: https://codereview.chromium.org/85823002

git-svn-id: http://skia.googlecode.com/svn/trunk@12376 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-25 14:03:52 +00:00
commit-bot@chromium.org
9df6215aaf Temporary changes to test one-click revert.
(SkipBuildbotRuns)

BUG=
NOTRY=true
TBR=borenet@google.com

Author: rmistry@google.com

Review URL: https://codereview.chromium.org/85343004

git-svn-id: http://skia.googlecode.com/svn/trunk@12375 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-25 14:02:01 +00:00
caryclark@google.com
28d219c568 fix pathops quad line intersection
git-svn-id: http://skia.googlecode.com/svn/trunk@12374 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-25 13:39:12 +00:00
commit-bot@chromium.org
27346f52cb Revert of https://1215-da983df0eebc.chromiumcodereview-hr.appspot.com/84603002/
Reason for revert: Testing one-click revert

TBR=
NOTREECHECKS=true
NOTRY=true

Author: rmistry@google.com

Review URL: https://codereview.chromium.org/84523003

git-svn-id: http://skia.googlecode.com/svn/trunk@12373 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-24 03:50:22 +00:00
commit-bot@chromium.org
4c8f4012b5 Whitespace change to test CQ and one-click revert.
TBR=borenet@google.com

(SkipBuildbotRuns)

BUG=

Author: rmistry@google.com

Review URL: https://codereview.chromium.org/84603002

git-svn-id: http://skia.googlecode.com/svn/trunk@12372 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-24 03:47:03 +00:00
mtklein@google.com
9b8c036eda Inline performance-critical methods on SkAlphaRuns.
Clang needs to be forced to inline add, so we do that.

GCC on desktop
              bench conf time        old        new       diff    diffP
draw_coverage_false 8888 c        236.08     212.01     +24.07   +10.2%
 draw_coverage_true 8888 c        125.67     104.49     +21.18   +16.9%

GCC on N5
              bench conf time        old        new       diff    diffP
draw_coverage_false 8888 c        566.33     529.96     +36.37    +6.4%
 draw_coverage_true 8888 c        315.39     293.85     +21.54    +6.8%

Clang on desktop
              bench conf time        old        new       diff    diffP
draw_coverage_false 8888 c        337.37     330.63      +6.74    +2.0%
 draw_coverage_true 8888 c        126.87     119.32      +7.55    +6.0%

BUG=
R=reed@google.com

Review URL: https://codereview.chromium.org/83243005

git-svn-id: http://skia.googlecode.com/svn/trunk@12370 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-22 21:25:55 +00:00
mtklein@google.com
6e223af090 I feel like my clang is especially sensitive to unused variables.
BUG=

Review URL: https://codereview.chromium.org/82913006

git-svn-id: http://skia.googlecode.com/svn/trunk@12369 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-22 20:43:54 +00:00
commit-bot@chromium.org
d6ca4ac1ee [GPU] Use view matrix + rect to implement subrect for drawBitmap when there is a mask filter and bleed.
R=robertphillips@google.com, reed@google.com

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/65133003

git-svn-id: http://skia.googlecode.com/svn/trunk@12368 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-22 20:34:59 +00:00
commit-bot@chromium.org
44e86572eb Disable the save/clip/restore peephole optimization when a bounding hierarchy is used
This optimization is redundant with the state traversal optimization that is
performed by SkPictureStateTree and it introduces significant record time
overhead.  Therefore it is better not to perform this optimization when using
a BBoxHierarchy.

BUG=1852
R=tomhudson@google.com, robertphillips@google.com, reed@google.com

Author: junov@chromium.org

Review URL: https://codereview.chromium.org/79313003

git-svn-id: http://skia.googlecode.com/svn/trunk@12367 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-22 19:42:13 +00:00
epoger@google.com
214a024e8c rebaseline_server: improve pixel diff reporting
- fix differing pixels count (we weren't always doing this right)
- report number of differing pixels, as well as percentage
- report worst difference per RGB channel
- apply alpha mask to difference image (changed pixels = opaque, unchanged = transparent)
- add tooltips with further explanation of pixel diffs
(SkipBuildbotRuns)

R=mtklein@google.com

Review URL: https://codereview.chromium.org/82823005

git-svn-id: http://skia.googlecode.com/svn/trunk@12366 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-22 19:26:18 +00:00
mtklein@google.com
1950d5f58f Add SK_ALWAYS_INLINE.
I'm working on some code that's much faster when compiled by GCC than by Clang
because GCC inlines more aggressively.  Using SK_ATTRIBUTE(always_inline) on
the appropriate methods narrows the performance gap considerably.

This should work for MSVC, GCC, and Clang, otherwise falling back to "inline".

BUG=
R=reed@google.com

Review URL: https://codereview.chromium.org/83333005

git-svn-id: http://skia.googlecode.com/svn/trunk@12364 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-22 16:56:22 +00:00
commit-bot@chromium.org
46a9bb8d71 Fixing issues found by fuzzer
BUG=321802,321790
R=reed@google.com, senorblanco@google.com

Author: sugoi@chromium.org

Review URL: https://codereview.chromium.org/83073005

git-svn-id: http://skia.googlecode.com/svn/trunk@12362 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-22 16:43:14 +00:00
robertphillips@google.com
da095e9a3b Laggard rebaselines for r12357
https://codereview.chromium.org/82733005/



git-svn-id: http://skia.googlecode.com/svn/trunk@12360 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-22 14:32:27 +00:00
robertphillips@google.com
172f28c9c5 Rebaseline dashing3 GMs for r12357
https://codereview.chromium.org/83543002/



git-svn-id: http://skia.googlecode.com/svn/trunk@12359 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-22 13:40:48 +00:00
skia.committer@gmail.com
f61ebc0927 Sanitizing source files in Housekeeper-Nightly
git-svn-id: http://skia.googlecode.com/svn/trunk@12358 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-22 07:02:24 +00:00
commit-bot@chromium.org
e0a868c84e Apply hairline optimization only if the path renderer wants it
Make the decision to convert thin, non-hairline paths to hairline
paths at the renderer level.

The current nv_path_rendering implementation does not render
hairlines. Rendering the hairlines with normal renderers cause
unneccessary gl program changes, which is quite slow.

Changes the behavior of non-nv_path_rendering paths to always perform
the optimization if the shape ends up being painted by a renderer that
wants the optimization. Previously the optimization was applied only
when callgraph started with SkCanvas::drawPath.

Applies the optimization for GrAAHairLineRenderer and
GrDefaultPathRenderer.

This changes gm results for dashing3_{msaa4,gpu} and drawlooper_msaa4.

R=bsalomon@google.com, jvanverth@google.com, rmistry@google.com

Author: kkinnunen@nvidia.com

Review URL: https://codereview.chromium.org/38573007

git-svn-id: http://skia.googlecode.com/svn/trunk@12357 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-22 07:02:11 +00:00
reed@google.com
52314f82ba move SkProcCoeffXfermode unflatten constructor into .cpp, and range-check its mode
BUG=

Review URL: https://codereview.chromium.org/79543009

git-svn-id: http://skia.googlecode.com/svn/trunk@12355 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-21 21:05:06 +00:00
scroggo@google.com
56d11f6a2f Update ChromeOS expectations after warning changes
The diffs are tiny. They resulted from changes in between revisions
12307 and 12334, inclusive. We suspect the change is from r12314.

Would have gone in along with r12318, except the ChromeOS bots were
down at the time, and not generating new images.

Review URL: https://codereview.chromium.org/77453011

git-svn-id: http://skia.googlecode.com/svn/trunk@12354 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-21 20:12:37 +00:00