senorblanco@chromium.org
0cb6e5355b
Turn on the separable blur (release the hounds!). This will require rebaselines of the following Skia tests: tilemodes, texteffects, shadows, drawlooper, drawbitmaprect, circles, blurrect_grad, blurrect, blurs, drawbitmapmatrix (max. pixel change in 8888 is 5).
...
NOTE: This will require adding SK_DISABLE_SEPARABLE_MASK_BLUR to skia.gyp on the next roll into Chrome, until the Chrome rebaselines are done.
Review URL: https://codereview.appspot.com/6845111
git-svn-id: http://skia.googlecode.com/svn/trunk@6606 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-11-29 19:00:22 +00:00
bsalomon@google.com
9128edc700
Rename SkClipStack::Rec to SkClipStack::Element
...
R=robertphillips@google.com
Review URL: https://codereview.appspot.com/6854115
git-svn-id: http://skia.googlecode.com/svn/trunk@6605 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-11-29 18:58:19 +00:00
bsalomon@google.com
83a853aa65
Fix the gr/gl destruction order in Test.cpp
...
R=djsollen@google.com
Review URL: https://codereview.appspot.com/6851126
git-svn-id: http://skia.googlecode.com/svn/trunk@6602 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-11-29 17:27:37 +00:00
senorblanco@chromium.org
91f489a65d
Modify the blur bench to add tests for high-quality blurs, and large non-integer blurs. Change the Coarse flag (which just turns on separable blurs) to an #ifdef, since separable is no longer just Coarse. (This #ifdef will hopefully be shortlived, once Chrome has switched).
...
The separable blur algorithm gives +45% on SampleBlur, +84% on SampleBigBlur, +31% on TheVerge, +35 to +85% on blurbench in HQ (depending on size), +8 to +35% in low quality. (All of these on 32bit MacPro).
Review URL: https://codereview.appspot.com/6851117
git-svn-id: http://skia.googlecode.com/svn/trunk@6601 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-11-29 17:09:27 +00:00
djsollen@google.com
f4d1b39118
Remove legacy flag for android from tests
...
Review URL: https://codereview.appspot.com/6782133
git-svn-id: http://skia.googlecode.com/svn/trunk@6600 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-11-29 16:29:58 +00:00
djsollen@google.com
0945bde599
Fix test app to ensure that we destroy our GPU resources.
...
The problem arises on devices like the Nexus 10 where we allow the
destruction of resources using the destructor of a static variable.
However, we have no guarentee that the GPU driver has not already
cleaned up it's resources prior to our static destructor.
Review URL: https://codereview.appspot.com/6851124
git-svn-id: http://skia.googlecode.com/svn/trunk@6599 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-11-29 15:28:45 +00:00
djsollen@google.com
5afbbc47df
Enable profiling options to be selectively enabled for a given build
...
Review URL: https://codereview.appspot.com/6858089
git-svn-id: http://skia.googlecode.com/svn/trunk@6598 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-11-29 15:09:58 +00:00
caryclark@google.com
7fce0de0b9
shape ops work in progress
...
Complete rewrite of binary logic makes the result
work and much easier to understand.
git-svn-id: http://skia.googlecode.com/svn/trunk@6597 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-11-29 14:31:50 +00:00
robertphillips@google.com
852030103e
Add newline at end of SkRRect.h
...
git-svn-id: http://skia.googlecode.com/svn/trunk@6596 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-11-29 13:49:33 +00:00
robertphillips@google.com
5985e7c4d1
SkRoundRect start
...
https://codereview.appspot.com/6815058/
git-svn-id: http://skia.googlecode.com/svn/trunk@6595 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-11-29 13:24:55 +00:00
skia.committer@gmail.com
687c57c7d5
Sanitizing source files in Skia_Periodic_House_Keeping
...
git-svn-id: http://skia.googlecode.com/svn/trunk@6594 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-11-29 02:01:19 +00:00
bungeman@google.com
ffd7907ba3
Remove what turns out to be a bogus assert.
...
Any problems with size are already handled by checking the return value of CFNumberGetValue.
git-svn-id: http://skia.googlecode.com/svn/trunk@6592 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-11-28 22:13:32 +00:00
reed@google.com
5e5885a63d
update dox
...
git-svn-id: http://skia.googlecode.com/svn/trunk@6591 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-11-28 21:28:57 +00:00
bungeman@google.com
d59a3fed3f
Write correct type of sfnt file in mac coretext open stream.
...
https://codereview.appspot.com/6844105/
git-svn-id: http://skia.googlecode.com/svn/trunk@6590 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-11-28 21:09:18 +00:00
bensong@google.com
661aeee423
Update bench_expectations.txt with new codes in issue 6842112.
...
Rev range is [6580, 6585].
Review URL: https://codereview.appspot.com/6858091
git-svn-id: http://skia.googlecode.com/svn/trunk@6589 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-11-28 20:23:49 +00:00
epoger@google.com
570aafe9c1
Update gm self-test to pass again after r6585
...
Now depends on only "dashing2" test, not all tests whose name starts with "dashing",
so it should be more resilient in the face of further changes.
TBR=borenet,robertphillips
Review URL: https://codereview.appspot.com/6844104
git-svn-id: http://skia.googlecode.com/svn/trunk@6588 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-11-28 20:08:32 +00:00
robertphillips@google.com
629ab54066
Added dashing fast path
...
https://codereview.appspot.com/6844067/
git-svn-id: http://skia.googlecode.com/svn/trunk@6585 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-11-28 17:18:11 +00:00
bsalomon@google.com
edb26fdb83
Set empty/wide-open genID on clip stack in more places and fix a bug in GrReduceClipStack.
...
R=robertphillips@google.com
Review URL: https://codereview.appspot.com/6847116
git-svn-id: http://skia.googlecode.com/svn/trunk@6579 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-11-28 14:42:41 +00:00
djsollen@google.com
ab5e91184b
Update gyp to allow alternative out directories
...
If the enviroment variable SKIA_OUT is set the output of both
gyp and make will be redirected to that directory.
Review URL: https://codereview.appspot.com/6782095
git-svn-id: http://skia.googlecode.com/svn/trunk@6578 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-11-28 14:11:41 +00:00
skia.committer@gmail.com
ab38f7acb3
Sanitizing source files in Skia_Periodic_House_Keeping
...
git-svn-id: http://skia.googlecode.com/svn/trunk@6577 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-11-28 02:02:11 +00:00
senorblanco@chromium.org
9b0d4d79f0
Implement radius interpolation for separable blur. Unroll both separable implementations, which yields up to 2X perf improvement.
...
Review URL: https://codereview.appspot.com/6850088
git-svn-id: http://skia.googlecode.com/svn/trunk@6576 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-11-27 22:57:41 +00:00
bensong@google.com
dc2dd2e72f
update bench_expectations with wider range before further investigations and discussions; change precision of bench values to 0.001.
...
git-svn-id: http://skia.googlecode.com/svn/trunk@6575 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-11-27 21:52:32 +00:00
reed@google.com
e2f8c7c876
capture repro case for gradient bug (inside if-false for now)
...
git-svn-id: http://skia.googlecode.com/svn/trunk@6574 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-11-27 21:11:05 +00:00
reed@google.com
68d6bb0c11
revert prev change to reset
...
git-svn-id: http://skia.googlecode.com/svn/trunk@6571 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-11-27 18:37:52 +00:00
bensong@google.com
fa1d4ea044
add skp bench expectations and watch for alerts.
...
git-svn-id: http://skia.googlecode.com/svn/trunk@6570 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-11-27 17:30:26 +00:00
reed@google.com
4efd9d9872
guard for self-assignment in reset()
...
git-svn-id: http://skia.googlecode.com/svn/trunk@6568 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-11-27 17:20:39 +00:00
bsalomon@google.com
26daa8bbee
Temporarily disable clip stack reduce test while working on fix.
...
git-svn-id: http://skia.googlecode.com/svn/trunk@6567 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-11-27 16:50:14 +00:00
tomhudson@google.com
0699e02101
Close pending save() calls in QT debugger to avoid saveLayer() corruption.
...
http://codereview.appspot.com/6856076/
git-svn-id: http://skia.googlecode.com/svn/trunk@6565 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-11-27 16:09:42 +00:00
robertphillips@google.com
e174a8bd74
Address debugger profiling issue in tile mode
...
https://codereview.appspot.com/6843113/
git-svn-id: http://skia.googlecode.com/svn/trunk@6564 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-11-27 16:04:42 +00:00
bsalomon@google.com
705e840944
Make the clip stack reduction test generate inverse filled paths.
...
Also adds some comments to GrReduceClipStack.
R=robertphillips@google.com
Review URL: https://codereview.appspot.com/6847109
git-svn-id: http://skia.googlecode.com/svn/trunk@6561 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-11-27 15:43:57 +00:00
reed@google.com
d198a5b8a7
don't leak *every* src mask in the ninepatch case. doh.
...
git-svn-id: http://skia.googlecode.com/svn/trunk@6560 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-11-27 15:18:04 +00:00
reed@google.com
7775d66aa0
add onOnceBeforeDraw() virtual, so gm's can easily perform lazy initialization
...
git-svn-id: http://skia.googlecode.com/svn/trunk@6559 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-11-27 15:15:58 +00:00
reed@google.com
631940c8c4
don't use bit-wise test for equality when using floats.
...
git-svn-id: http://skia.googlecode.com/svn/trunk@6557 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-11-27 13:13:22 +00:00
skia.committer@gmail.com
8ccf590b89
Sanitizing source files in Skia_Periodic_House_Keeping
...
git-svn-id: http://skia.googlecode.com/svn/trunk@6556 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-11-27 02:01:19 +00:00
bsalomon@google.com
e7b3d29a12
Actually fix GPU-less build.
...
git-svn-id: http://skia.googlecode.com/svn/trunk@6555 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-11-26 21:42:32 +00:00
bsalomon@google.com
a4e13c85b2
Fix GPU-less build.
...
Unreviewed.
git-svn-id: http://skia.googlecode.com/svn/trunk@6554 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-11-26 21:38:37 +00:00
bsalomon@google.com
51a6286c24
Add a function that computes a reduced representation of the clip stack.
...
Also adds a unit test. The function is not yet used other than in the test.
Review URL: https://codereview.appspot.com/6855098
git-svn-id: http://skia.googlecode.com/svn/trunk@6553 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-11-26 21:19:43 +00:00
reed@google.com
971aca7557
change SkDrawFilter::filter to return a bool, where false means don't-draw
...
Review URL: https://codereview.appspot.com/6851111
git-svn-id: http://skia.googlecode.com/svn/trunk@6551 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-11-26 20:26:54 +00:00
reed@google.com
db3f0fda68
must always include another skia header (unless you're SkTypes.h). In this case,
...
we need SkScalar.h earlier so we can be sure to have int32_t defined.
inspired by https://codereview.appspot.com/6782122/
git-svn-id: http://skia.googlecode.com/svn/trunk@6548 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-11-26 20:18:00 +00:00
reed@google.com
a8a3b3d9a0
check for bad enum use when adding contours
...
Review URL: https://codereview.appspot.com/6849103
git-svn-id: http://skia.googlecode.com/svn/trunk@6547 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-11-26 18:16:27 +00:00
reed@google.com
5f0add3ad6
remove legacy build-guards, now that webkit has rebaselined these.
...
SK_DISABLE_FAST_AA_STROKE_RECT
SK_IGNORE_FAST_BLURRECT
SK_DISABLE_EXTRACTSUBSET_OPAQUE_FIX
SK_IGNORE_CF_OPTIMIZATION
SK_IGNORE_NEW_STROKERECT
SK_DISABLE_GPU_BLUR
SK_IGNORE_ROTATED_FREETYPE_FIX
The changes should all be:
remove code for #ifdef
remove guard for #ifndef
Review URL: https://codereview.appspot.com/6858073
git-svn-id: http://skia.googlecode.com/svn/trunk@6546 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-11-26 16:47:10 +00:00
reed@google.com
53007a2b17
choose correct blitrow proc based on global alpha
...
fixes https://bugs.webkit.org/show_bug.cgi?id=103062
add gm to exercise this new fix
git-svn-id: http://skia.googlecode.com/svn/trunk@6544 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-11-26 14:39:50 +00:00
robertphillips@google.com
53ec73d1e6
Visualize bitmaps in debugger
...
https://codereview.appspot.com/6847084/
git-svn-id: http://skia.googlecode.com/svn/trunk@6541 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-11-26 13:09:17 +00:00
skia.committer@gmail.com
1c9c0d3711
Sanitizing source files in Skia_Periodic_House_Keeping
...
git-svn-id: http://skia.googlecode.com/svn/trunk@6540 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-11-22 02:02:41 +00:00
tfarina@chromium.org
223137f49d
Remove GrRandom API in favor of SkRandom.
...
TEST=tests
R=bsalomon@google.com
Review URL: https://codereview.appspot.com/6855062
git-svn-id: http://skia.googlecode.com/svn/trunk@6539 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-11-21 22:38:36 +00:00
caryclark@google.com
729e1c46ce
shape ops work in progress
...
git-svn-id: http://skia.googlecode.com/svn/trunk@6537 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-11-21 21:36:34 +00:00
epoger@google.com
f74dd16e9a
Add self-test that reveals SkChecksum weakness
...
Review URL: https://codereview.appspot.com/6845064
git-svn-id: http://skia.googlecode.com/svn/trunk@6535 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-11-21 19:04:17 +00:00
rmistry@google.com
44737654c3
Fixed some compilation problems with debugger with robertphillips
...
git-svn-id: http://skia.googlecode.com/svn/trunk@6534 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-11-21 18:37:58 +00:00
reed@google.com
c19468e4bb
add default: to fix warning
...
git-svn-id: http://skia.googlecode.com/svn/trunk@6533 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-11-21 18:34:15 +00:00
robertphillips@google.com
6dec8fcb44
Add drawing of paths to debugger
...
https://codereview.appspot.com/6850082/
git-svn-id: http://skia.googlecode.com/svn/trunk@6532 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-11-21 17:11:02 +00:00