bsalomon
e1593862fe
Revert of Remove the AA requirement for selecting GrEffect-based clipping. ( https://codereview.chromium.org/367013003/ )
...
Reason for revert:
Assertion failing.
Original issue's description:
> Remove the AA requirement for selecting GrEffect-based clipping.
>
> Also, optionally use the scissor for a bw clip rect element instead of an effect.
>
> Committed: https://skia.googlesource.com/skia/+/a73218bbbdcbe458651d10815e8d3b73d71b8e11
R=robertphillips@google.com
TBR=robertphillips@google.com
NOTREECHECKS=true
NOTRY=true
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/369613002
2014-07-02 11:11:30 -07:00
bsalomon
a73218bbbd
Remove the AA requirement for selecting GrEffect-based clipping.
...
Also, optionally use the scissor for a bw clip rect element instead of an effect.
R=robertphillips@google.com
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/367013003
2014-07-02 10:40:52 -07:00
borenet
1c0acee19b
Revert of Update SKP version to 39 ( https://codereview.chromium.org/367863003/ )
...
Reason for revert:
Deleted expectations again. https://code.google.com/p/skia/issues/detail?id=2714
Original issue's description:
> Update SKP version to 39
>
> Automatic commit by the RecreateSKPs bot.
>
> TBR=
>
> Committed: https://skia.googlesource.com/skia/+/50b3dab100a6537ace504357d38e49ba0a14de43
TBR=
NOTREECHECKS=true
NOTRY=true
Author: borenet@google.com
Review URL: https://codereview.chromium.org/367983002
2014-07-02 06:54:31 -07:00
egdaniel
f767e792b9
Add the ability for gpu to render dotted lines (dashed line, 0 on interval, round caps)
...
BUG=skia:
R=bsalomon@google.com
Author: egdaniel@google.com
Review URL: https://codereview.chromium.org/345113003
2014-07-02 06:21:34 -07:00
borenet
50b3dab100
Update SKP version to 39
...
Automatic commit by the RecreateSKPs bot.
TBR=
Author: borenet@google.com
Review URL: https://codereview.chromium.org/367863003
2014-07-01 23:46:11 -07:00
jvanverth
dc1cf66483
Remove A8_LCD luminance hack.
...
It no longer appears to be necessary, and the powf function is slowing down
Android text rendering.
R=bungeman@google.com , bsalomon@google.com
Author: jvanverth@google.com
Review URL: https://codereview.chromium.org/337603008
2014-07-01 13:43:00 -07:00
Eric Boren
e8e8d0226c
Revert of Update SKP version to 34 ( https://codereview.chromium.org/347303003/ )
...
Reason for revert:
This removed all bench expectations!
Original issue's description:
> Update SKP version to 34
>
> Automatic commit by the RecreateSKPs bot.
>
> TBR=
>
> Committed: https://skia.googlesource.com/skia/+/0808c82e83749c24183af92a43c2e0e69b35d745
TBR=
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/362753002
2014-07-01 09:39:00 -04:00
Ben Wagner
529b7f6d62
Expectations updates for DirectWrite change 761b25.
2014-06-30 16:18:24 -04:00
reed
4eec156659
rebaseline srcmode for gpus -- now pass samplecount
...
TBR=
NOTRY=True
BUG=skia:
Author: reed@google.com
Review URL: https://codereview.chromium.org/357393002
2014-06-30 10:59:48 -07:00
senorblanco
d4fa483504
Some straggler rebaselines for imagefiltersclipped.
...
NOTRY=true
NOTREECHECKS=true
R=rmistry@google.com
TBR=rmistry
BUG=skia:
Author: senorblanco@chromium.org
Review URL: https://codereview.chromium.org/348313006
2014-06-27 16:20:03 -07:00
senorblanco
d297d0f2c2
New baselines for imagefiltersclipped GM after perlin noise change.
...
R=rmistry@google.com
TBR=rmistry
NOTRY=true
NOTREECHECKS=true
BUG=skia:
Author: senorblanco@chromium.org
Review URL: https://codereview.chromium.org/361523003
2014-06-27 14:45:30 -07:00
senorblanco
ca6a7c2945
Make perlin noise do CTM-correct scaling.
...
When drawing perlin noise, generate noise at the resolution determined
by CTM, not by the resolution at construction time. This required moving
the generation of PaintingData to getContext() and asNewEffect() for the
raster and GPU paths, respectively.
It also required adjusting the matrices used during rendering
to be translate-only.
R=sugoi@chromium.org , bsalomon@google.com
Author: senorblanco@chromium.org
Review URL: https://codereview.chromium.org/358903002
2014-06-27 13:35:52 -07:00
borenet
0808c82e83
Update SKP version to 34
...
Automatic commit by the RecreateSKPs bot.
TBR=
Author: borenet@google.com
Review URL: https://codereview.chromium.org/347303003
2014-06-27 01:02:30 -07:00
rmistry
8ba8d923da
Rebaseline Test-Android-Logan-Nvidia-Arm7-*
...
Reviewed both by mtklein and bsalomon in skia:2695.
TBR=
BUG=skia:2695
NOTREECHECKS=true
NOTRY=true
Author: rmistry@google.com
Review URL: https://codereview.chromium.org/352353004
2014-06-26 11:35:33 -07:00
borenet
1ea04a0a4d
Update SKP version to 33
...
Automatic commit by the RecreateSKPs bot.
TBR=
Author: borenet@google.com
Review URL: https://codereview.chromium.org/336613005
2014-06-25 23:53:02 -07:00
senorblanco
7bf1068473
Remove SkBicubicImageFilter, and all related tests.
...
Now that we have SkResizeImageFilter, and the bicubic
resizing is part of skia proper, there's no need for a
specialized image filter.
BUG=skia:
R=bsalomon@google.com
Author: senorblanco@chromium.org
Review URL: https://codereview.chromium.org/357793002
2014-06-25 14:39:06 -07:00
Mike Klein
85a08789c0
Rebase Test-Ubuntu12-ShuttleA-GTX660-x86-Release.
...
BUG=skia:2575
Review URL: https://codereview.chromium.org/353883002
2014-06-25 13:21:56 -04:00
kkinnunen
55106da359
Ignore degeneratesegments for nvprmsaa4 to unbreak the build
...
Ignore degeneratesegments for nvprmsaa4 to unbreak the build. The result image
seems to be inconsistent with different Linux GTX660 builds. Ignore the test for
Test-Ubuntu12-ShuttleA-GTX660-x86_64-Release.
BUG=skia:2689
R=rmistry@google.com
Author: kkinnunen@nvidia.com
Review URL: https://codereview.chromium.org/345423006
2014-06-25 04:30:38 -07:00
borenet
669a121e7e
Update SKP version to 32
...
Automatic commit by the RecreateSKPs bot.
TBR=
Author: borenet@google.com
Review URL: https://codereview.chromium.org/352073002
2014-06-25 00:29:51 -07:00
Brian Salomon
20fa0c3238
rebase GMs
...
BUG=skia:
Review URL: https://codereview.chromium.org/351973003
2014-06-24 18:08:09 -04:00
kkinnunen
68dd81bde9
Rebaseline gm results after "Implement text rendering with NVPR"
...
Rebaseline gm results after "Implement text rendering with NVPR". The text is
rasterized by NV_path_rendering extension, so pixels are expected to be a bit
different.
NOTRY=true
R=rmistry@google.com
Author: kkinnunen@nvidia.com
Review URL: https://codereview.chromium.org/346413002
2014-06-24 04:45:58 -07:00
rmistry
798496c66f
Rebaseline shadertext2_{gpu,8888} after SkPaint::measureText changes
...
These two GMs were missing from https://codereview.chromium.org/347393002/ .
This CL is to fix http://108.170.220.121:10117/static/view.html#/view.html?resultsToLoad=%2Fresults%2Ffailures&displayLimitPending=50&showThumbnailsPending&mergeIdenticalRowsPending&imageSizePending=100&sortColumnSubdict=differenceData&sortColumnKey=perceptualDifference&hiddenResultTypes=failure-ignored,no-comparison,succeeded&hiddenConfigs=&builder=Test-Win7-ShuttleA-HD2000-x86-Release&test=
BUG=skia:
R=kkinnunen@nvidia.com , jvanverth@google.com , mtklein@google.com
Author: rmistry@google.com
Review URL: https://codereview.chromium.org/333193003
2014-06-23 10:32:29 -07:00
robertphillips
c8fd7b58c5
Remove suppression of distantclip image differences
...
R=rmistry@google.com , rmistry@chromium.org
Author: robertphillips@google.com
Review URL: https://codereview.chromium.org/349233004
2014-06-23 09:01:52 -07:00
kkinnunen
0156c7646c
Rebaseline shadertext2 after SkPaint::measureText changes
...
Rebaseline shadertext2 after commit "Fix SkPaint::measureText for stroked
hairline text".
Unignore ignored shadertext2 for Test-Ubuntu13.10-ShuttleA-NoGPU-x86_64-Debug
pdf-poppler.
The label "Filled" in the test moves to the left due to the changes in the
measurement. The SkPaint::measureText will use the "use paths" code path,
similar to the drawing code. This results in different length for the string
"Filled".
As a side-note, the test probably measures either wrong text or uses wrong
paint. This can be fixed separately.
NOTREECHECKS=true
NOTRY=true
R=jvanverth@google.com , mtklein@google.com , rmistry@google.com
Author: kkinnunen@nvidia.com
Review URL: https://codereview.chromium.org/347393002
2014-06-23 06:59:46 -07:00
rmistry
c4b84aef1a
Revert of Revert of Fix SkPaint::measureText for stroked hairline text ( https://codereview.chromium.org/354433002/ )
...
Reason for revert:
Rebaseline CL is ready to be submitted
Original issue's description:
> Revert of Fix SkPaint::measureText for stroked hairline text (https://codereview.chromium.org/335603003/ )
>
> Reason for revert:
> Caused many shadertext GM failures
>
> Original issue's description:
> > Fix SkPaint::measureText for stroked hairline text
> >
> > SkPaint::measureText and text drawing used different criteria for
> > determining whether text should be drawn as paths or not.
> >
> > Adds tests glyph_pos_(h/n)_(s/f/b) to test the text rendering and the glyph
> > positioning in the rendering. Mainly added in order to define what is the
> > expected text rendering when hairline stroke is used with various transform
> > options.
> >
> > The testcase also tries to note or highlight the fact that SkPaint::measureText
> > is not expected to produce intuitively matching results when compared to a
> > rendering, if the rendering is done so that the device ends up having a device
> > transform.
> >
> > This fixes the glyph_pos_h_s (hairline, stroked) test-case.
> >
> > Ignore shadertext2_pdf-poppler.png gm on
> > Test-Ubuntu13.10-ShuttleA-NoGPU-x86_64-Debug temporarily, as that fails.
> >
> > Committed: https://skia.googlesource.com/skia/+/196af738027c5e18c3eb792dbcaf90ef27821793
>
> TBR=jvanverth@google.com ,reed@google.com,kkinnunen@nvidia.com
> NOTREECHECKS=true
> NOTRY=true
>
> Committed: https://skia.googlesource.com/skia/+/abc9bb55ddfeb4b1a7acc335a34841fddcd22d27
R=jvanverth@google.com , reed@google.com , kkinnunen@nvidia.com
TBR=jvanverth@google.com , kkinnunen@nvidia.com , reed@google.com
NOTREECHECKS=true
NOTRY=true
Author: rmistry@google.com
Review URL: https://codereview.chromium.org/349153005
2014-06-23 06:59:15 -07:00
rmistry
abc9bb55dd
Revert of Fix SkPaint::measureText for stroked hairline text ( https://codereview.chromium.org/335603003/ )
...
Reason for revert:
Caused many shadertext GM failures
Original issue's description:
> Fix SkPaint::measureText for stroked hairline text
>
> SkPaint::measureText and text drawing used different criteria for
> determining whether text should be drawn as paths or not.
>
> Adds tests glyph_pos_(h/n)_(s/f/b) to test the text rendering and the glyph
> positioning in the rendering. Mainly added in order to define what is the
> expected text rendering when hairline stroke is used with various transform
> options.
>
> The testcase also tries to note or highlight the fact that SkPaint::measureText
> is not expected to produce intuitively matching results when compared to a
> rendering, if the rendering is done so that the device ends up having a device
> transform.
>
> This fixes the glyph_pos_h_s (hairline, stroked) test-case.
>
> Ignore shadertext2_pdf-poppler.png gm on
> Test-Ubuntu13.10-ShuttleA-NoGPU-x86_64-Debug temporarily, as that fails.
>
> Committed: https://skia.googlesource.com/skia/+/196af738027c5e18c3eb792dbcaf90ef27821793
R=jvanverth@google.com , reed@google.com , kkinnunen@nvidia.com
TBR=jvanverth@google.com , kkinnunen@nvidia.com , reed@google.com
NOTREECHECKS=true
NOTRY=true
Author: rmistry@google.com
Review URL: https://codereview.chromium.org/354433002
2014-06-23 05:39:26 -07:00
borenet
32956400b4
Update SKP version to 29
...
Automatic commit by the RecreateSKPs bot.
TBR=
Author: borenet@google.com
Review URL: https://codereview.chromium.org/352473002
2014-06-22 22:18:34 -07:00
kkinnunen
196af73802
Fix SkPaint::measureText for stroked hairline text
...
SkPaint::measureText and text drawing used different criteria for
determining whether text should be drawn as paths or not.
Adds tests glyph_pos_(h/n)_(s/f/b) to test the text rendering and the glyph
positioning in the rendering. Mainly added in order to define what is the
expected text rendering when hairline stroke is used with various transform
options.
The testcase also tries to note or highlight the fact that SkPaint::measureText
is not expected to produce intuitively matching results when compared to a
rendering, if the rendering is done so that the device ends up having a device
transform.
This fixes the glyph_pos_h_s (hairline, stroked) test-case.
Ignore shadertext2_pdf-poppler.png gm on
Test-Ubuntu13.10-ShuttleA-NoGPU-x86_64-Debug temporarily, as that fails.
R=jvanverth@google.com , reed@google.com
Author: kkinnunen@nvidia.com
Review URL: https://codereview.chromium.org/335603003
2014-06-22 22:18:14 -07:00
borenet
830f356135
Update SKP version to 28
...
Automatic commit by the RecreateSKPs bot.
TBR=
Author: borenet@google.com
Review URL: https://codereview.chromium.org/345933004
2014-06-21 23:26:40 -07:00
borenet
4856ac9a4d
Update SKP version to 27
...
Automatic commit by the RecreateSKPs bot.
TBR=
Author: borenet@google.com
Review URL: https://codereview.chromium.org/348183003
2014-06-20 23:51:47 -07:00
krajcevski
61843107f6
Rebaseline clip on Win7 ShuttleA HD2000
...
BUG=skia:
R=bsalomon@google.com
TBR=bsalomon@google.com
Author: krajcevski@google.com
Review URL: https://codereview.chromium.org/342403002
2014-06-20 13:07:15 -07:00
Ben Wagner
909f91dc4c
Rebaselines for DirectWrite non-rounding.
...
Review URL: https://codereview.chromium.org/337923004
2014-06-20 14:41:35 -04:00
krajcevski
bbf93efdd0
Restore bug numbers
...
BUG=skia:
R=bsalomon@google.com
TBR=bsalomon@google.com
Author: krajcevski@google.com
Review URL: https://codereview.chromium.org/341313002
2014-06-20 11:39:27 -07:00
krajcevski
912d809a85
Rebaseline after dithering change
...
TBR=bsalomon@google.com
BUG=skia:
Author: krajcevski@google.com
Review URL: https://codereview.chromium.org/347103003
2014-06-20 09:02:16 -07:00
egdaniel
6b8f1ba1ef
Rebaseline win7-HD2000 for flaky dashing4 gm
...
R=bsalomon@google.com
TBR=bsalomon@google.com
BUG=skia:
Author: egdaniel@google.com
Review URL: https://codereview.chromium.org/344853005
2014-06-20 06:33:05 -07:00
krajcevski
f461a8fdf6
Simple GPU based dithering:
...
If dithering is turned on, apply an effect that filters the pixel through
the following pipeline:
for each channel c:
1. Compute quantized colors [low, high] that c is between
2. Pick high by flipping a coin weighted by (c - low)
R=bsalomon@google.com , egdaniel@google.com , robertphillips@google.com
Author: krajcevski@google.com
Review URL: https://codereview.chromium.org/321253002
2014-06-19 14:14:06 -07:00
senorblanco
373dd9b52f
New Nexus4 baselines for imagefiltersclipped, GPU path.
...
R=reed@google.com
TBR=reed@google.com
NOTRY=True
BUG=skia:
Author: senorblanco@chromium.org
Review URL: https://codereview.chromium.org/347693002
2014-06-18 16:26:39 -07:00
egdaniel
de10fdeee5
Add additional dashing rebaselines
...
NOTRY=True
NOTREECHECK=True
R=bsalomon@google.com
TBR=bsalomon@google.com
BUG=skia:
Author: egdaniel@google.com
Review URL: https://codereview.chromium.org/347543003
2014-06-18 07:31:08 -07:00
egdaniel
00fb42704a
Rebaslines from recent dashing changes
...
R=bsalomon@google.com
TBR=bsalomon@google.com
BUG=skia:
Author: egdaniel@google.com
Review URL: https://codereview.chromium.org/339203003
2014-06-18 06:56:19 -07:00
reed
1777f233bd
unignore canvas-layer-state
...
TBR=
NOTRY=True
Author: reed@google.com
Review URL: https://codereview.chromium.org/336273005
2014-06-18 05:47:45 -07:00
borenet
69b61412e9
Update SKP version to 26
...
Automatic commit by the RecreateSKPs bot.
TBR=
Author: borenet@google.com
Review URL: https://codereview.chromium.org/342653002
2014-06-18 00:31:16 -07:00
Ben Wagner
60741912fd
Rebaseline ANGLE bots.
2014-06-17 18:39:09 -04:00
humper
4a24cd8ff4
Fifth attempt to land faster rect blur. Remove unnecessary conditionals from the shader.
...
approved over in https://codereview.chromium.org/331863006/ ; reuploading
because it had the wrong base url
BUG=skia:2095
R=bsalomon@google.com
TBR=bsalomon
Author: humper@google.com
Review URL: https://codereview.chromium.org/341543005
2014-06-17 13:39:31 -07:00
Ben Wagner
9323b01e90
Update Windows baselines due to VS2013 update.
...
Floating point operations now differ in the low bits from before.
2014-06-17 16:28:20 -04:00
reed
0992d0764b
rebaseline after changing labels in bitmapfilters
...
TBR=
NOTRY=True
NOTREECHECKS=True
Author: reed@google.com
Review URL: https://codereview.chromium.org/340583004
2014-06-17 12:31:49 -07:00
dandov
baa860c297
* Removed bitmapshaders from expectations/gm/ignored-tests.txt.
...
* Rebaseline bitmapshaders, gpu didn't produce the same images when using only alpha bitmaps
because it didn't consider the skpaint's color.
BUG=skia:2293
R=jvanverth@google.com
Author: dandov@google.com
Review URL: https://codereview.chromium.org/339923004
2014-06-17 11:21:46 -07:00
reed
057ef35280
rebaseline after GM change to bitmapfilters
...
TBR=
NOTRY=True
NOTREECHECKS=True
Author: reed@google.com
Review URL: https://codereview.chromium.org/341593003
2014-06-17 10:32:31 -07:00
reed
12d4aa69b5
ignore bitmapfilters failures until we can rebaseline
...
TBR=
NOTRY=True
NOTREECHECKS=True
Author: reed@google.com
Review URL: https://codereview.chromium.org/339153004
2014-06-17 10:28:08 -07:00
kevin.petit
cf2187267b
Armv8/64bit doesn't (apparently) need rebaselining
...
BUG=skia:
R=reed@google.com
NOTRY=True
Author: kevin.petit@arm.com
Review URL: https://codereview.chromium.org/334743009
2014-06-16 10:05:41 -07:00
borenet
d6e614c0aa
Update SKP version to 24
...
Automatic commit by the RecreateSKPs bot.
TBR=
Author: borenet@google.com
Review URL: https://codereview.chromium.org/332983003
2014-06-15 23:52:57 -07:00
borenet
09b187c9bd
Update SKP version to 23
...
Automatic commit by the RecreateSKPs bot.
TBR=
Author: borenet@google.com
Review URL: https://codereview.chromium.org/332843006
2014-06-14 23:47:32 -07:00
borenet
c6dbd6f95e
Update SKP version to 22
...
Automatic commit by the RecreateSKPs bot.
TBR=
Author: borenet@google.com
Review URL: https://codereview.chromium.org/332013002
2014-06-14 04:50:12 -07:00
senorblanco
9a8699f45c
New baselines for perlin noise tests affected by ce6a35.
...
New baselines for perlinnoise, imagefiltersclipped and
imagefiltersscaled GMs.
R=scroggo@google.com
TBR=scroggo
NOTRY=true
Author: senorblanco@chromium.org
Review URL: https://codereview.chromium.org/336703002
2014-06-12 14:31:57 -07:00
reed
2526f0e5fd
rebaselines for removal of unitmapper
...
TBR=
NOTRY=True
Author: reed@google.com
Review URL: https://codereview.chromium.org/330513005
2014-06-12 12:53:01 -07:00
Stephen White
1b5e04ec5f
Add more tests to ignore-tests.txt.
...
Add imagefiltersclipped and imagefiltersscaled to ignored-tests.txt
until they can be rebaselined, since they're failing on Android after
https://codereview.chromium.org/332523006/ .
TBR=scroggo
BUG=skia:
Review URL: https://codereview.chromium.org/336663002
2014-06-12 15:51:46 -04:00
scroggo
e07c1ab408
Revert of third try at landing improved blur rect; this time with more correctness ( https://codereview.chromium.org/331443003/ )
...
Reason for revert:
Failing layout test: https://storage.googleapis.com/chromium-layout-test-archives/WebKit_Linux/32762/layout-test-results/virtual/gpu/fast/canvas/canvas-draw-canvas-on-canvas-shadow-pretty-diff.html
Original issue's description:
> third try at landing improved blur rect; this time with more correctness
>
> BUG=skia:2095
> R=bsalomon@google.com
> TBR=bsalomon
>
> Committed: https://skia.googlesource.com/skia/+/72abfc2b4e7caead660f6b6a05e60d05eaf1a66f
R=bsalomon@google.com , reed@google.com , humper@google.com
TBR=bsalomon@google.com , humper@google.com , reed@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:2095
Author: scroggo@google.com
Review URL: https://codereview.chromium.org/333763002
2014-06-12 12:10:24 -07:00
egdaniel
8b6fee1eb9
Add another fail-ignore for flaky dashing4 gm
...
NOTREECHECKS=True
NOTRY=True
TBR=bsalomon@google.com
BUG=skia:
Author: egdaniel@google.com
Review URL: https://codereview.chromium.org/329223007
2014-06-12 11:58:16 -07:00
bensong
a440e0065a
Greenify bench bot Perf-Ubuntu12-ShuttleA-GTX660-x86-Release at build 968
...
R=bsalomon@google.com
TBR=scroggo@google.com
Bypassing trybots:
NOTRY=true
Author: bensong@google.com
Review URL: https://codereview.chromium.org/338453004
2014-06-12 11:36:53 -07:00
senorblanco
ce6a354e12
Fix tiled perlin noise.
...
It turns out that the perlin implementation we inherited from WebKit
does not actually generate tileable noise (see Chromium bug
http://crbug.com/383495 ).
The main problem is that when generating coordinates for gradient
interpolation, it was attempting to wrap both x and (x + 1)
simultaneously at the tile boundary (that is, either both or neither
are wrapped). This obviously won't work, since along the tile seams,
(x + 1) should be wrapped, but x should not. The same is true in y.
This patch fixes both the CPU and GPU paths, renames some variables to
more closely match the spec, and modifies the perlin noise GM to
actually test tiling. (Note that the clipping the GM was doing was
removed, since it's superfluous: it used to be necessary for image
filters, but isn't anymore, and this isn't an image filter GM anyway.)
R=sugoi@google.com , sugoi
TBR=senorblanco
Author: senorblanco@chromium.org
Review URL: https://codereview.chromium.org/332523006
2014-06-12 11:24:20 -07:00
egdaniel
e61c411c12
Use vertex attributes for dash effect in gpu
...
This will allow us to batch dashed lines together when drawing. Also, this removes the need for
a coord transform matrix in the shader, thus we save the cost of uploading a new matrix uniform
everytime we do a simple transform to the dashed line we are drawing.
BUG=skia:
R=bsalomon@google.com
Author: egdaniel@google.com
Review URL: https://codereview.chromium.org/326103002
2014-06-12 10:24:21 -07:00
bensong
b205d09b29
manual bench rebase after 679426c
using old algorithm
...
R=robertphillips@google.com
TBR=borenet@google.com , robertphillips@google.com
Bypassing trybots:
NOTRY=true
Author: bensong@google.com
Review URL: https://codereview.chromium.org/330103002
2014-06-12 09:40:47 -07:00
egdaniel
b5dcdf1e7e
Rebase flakey windows dash4 gm
...
NOTREECHECKS=True
NOTRY=True
TBR=bsalomon@google.com
BUG=skia:2667
Author: egdaniel@google.com
Review URL: https://codereview.chromium.org/335443003
2014-06-12 08:02:43 -07:00
egdaniel
aea9cfbe8a
Add expectations for dashing gm
...
TBR=bsalomon@google.com
BUG=skia:
Author: egdaniel@google.com
Review URL: https://codereview.chromium.org/330033002
2014-06-12 06:26:16 -07:00
scroggo
cfe56bf3c5
manual bench rebase after 679426c
...
In response to:
- new SKPs
- Kelvin's changes around regression testing
R=robertphillips@google.com , kelvinly@google.com
TBR=robertphillips@google.com
Bypassing trybots:
NOTRY=true
Author: scroggo@google.com
Review URL: https://codereview.chromium.org/332483004
2014-06-12 05:54:37 -07:00
borenet
679426c0b4
Update SKP version to 21
...
Automatic commit by the RecreateSKPs bot.
TBR=
Author: borenet@google.com
Review URL: https://codereview.chromium.org/327213004
2014-06-12 00:43:39 -07:00
humper
72abfc2b4e
third try at landing improved blur rect; this time with more correctness
...
BUG=skia:2095
R=bsalomon@google.com
TBR=bsalomon
Author: humper@google.com
Review URL: https://codereview.chromium.org/331443003
2014-06-11 12:42:49 -07:00
reed
b0b1aa04ed
Revert of second try at landing improved blur rect ( https://codereview.chromium.org/325703002/ )
...
Reason for revert:
broke some fast/canvas layout tests
Original issue's description:
> second try at landing improved blur rect
>
> BUG=skia:2095
> TBR=bsalomon
>
> Committed: https://skia.googlesource.com/skia/+/e9ea0d6b7d59ac3b7e257281e545b24bcc0d2a76
R=bsalomon@google.com , reed@chromium.org , humper@google.com
TBR=bsalomon@google.com , humper@google.com , reed@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=skia:2095
Author: reed@google.com
Review URL: https://codereview.chromium.org/322423002
2014-06-11 07:26:23 -07:00
borenet
b621a05c49
Update SKP version to 20
...
Automatic commit by the RecreateSKPs bot.
TBR=
Author: borenet@google.com
Review URL: https://codereview.chromium.org/329043002
2014-06-11 01:52:00 -07:00
dandov
9de5b514d3
SkShader::asNewEffect Refactoring
...
The new signature is:
bool asNewEffect(GrContext* context, const SkPaint& paint, GrColor* grColor, GrEffectRef** grEffect, const SkMatrix* localMatrixOrNull) const;
It will fix the hack for skcolorshader by modifying the GrColor parameter in SkGr::SkPaint2GrPaintShader.
BUG=skia:2646
R=jvanverth@google.com , bsalomon@google.com
Author: dandov@google.com
Review URL: https://codereview.chromium.org/318923005
2014-06-10 14:38:28 -07:00
borenet
323c1f925a
Update SKP version to 19
...
Automatic commit by the RecreateSKPs bot.
TBR=
Author: borenet@google.com
Review URL: https://codereview.chromium.org/322943003
2014-06-10 02:04:03 -07:00
humper
e9ea0d6b7d
second try at landing improved blur rect
...
BUG=skia:2095
R=bsalomon@google.com
TBR=bsalomon
Author: humper@google.com
Review URL: https://codereview.chromium.org/325703002
2014-06-09 14:35:21 -07:00
krajcevski
9193e77db3
New etcbitmap baselines
...
R=robertphillips@google.com
Author: krajcevski@google.com
Review URL: https://codereview.chromium.org/325783003
2014-06-09 10:54:04 -07:00
robertphillips
9f1c241e0d
Remove SkPicture::kUsePathBoundsForClip_RecordingFlag
...
The real question is whether we ever want to record a picture without using the path bounds for a conservative (but faster) clip answer?
R=reed@google.com , mtklein@google.com , djsollen@google.com , scroggo@google.com
Author: robertphillips@google.com
Review URL: https://codereview.chromium.org/316143003
2014-06-09 06:25:34 -07:00
jvanverth
d78a2fac37
Rollback of fe689c46
and all subsequent changes
...
BUG=skia:
R=humper@google.com
TBR=humper@google.com
NOTRY=True
NOTREECHECKS=True
Author: jvanverth@google.com
Review URL: https://codereview.chromium.org/324463005
2014-06-06 13:40:36 -07:00
jvanverth
a07213ac83
Disable bigblurs GM (for fe689c46a7
)
...
BUG=skia:
R=humper@google.com
TBR=humper@google.com
NOTRY=True
NOTREECHECKS=True
Author: jvanverth@google.com
Review URL: https://codereview.chromium.org/325453002
2014-06-06 11:59:26 -07:00
humper
ede6cfc0f5
Revert of Revert of another GM to ignore for blur rebaseline ( https://codereview.chromium.org/319943004/ )
...
Reason for revert:
Hopefully working now
Original issue's description:
> Revert of another GM to ignore for blur rebaseline (https://codereview.chromium.org/319203002/ )
>
> Reason for revert:
> Follow-on to fe689c46a7
, which needs to be reverted due to bot failures.
>
> Original issue's description:
> > another GM to ignore for blur rebaseline
> >
> > BUG=skia:
> > TBR=jvanverth
> > NOTRY=True
> > NOTREECHECKS=True
> >
> > Committed: https://skia.googlesource.com/skia/+/f131055929afb9c9671aee3e575c380d48c5ee4d
>
> TBR=humper@google.com
> NOTREECHECKS=true
> NOTRY=true
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/f255de0fe160e33b340301859be1d9374c5607fe
R=jvanverth@google.com
TBR=jvanverth@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Author: humper@google.com
Review URL: https://codereview.chromium.org/324453004
2014-06-06 11:18:17 -07:00
jvanverth
f255de0fe1
Revert of another GM to ignore for blur rebaseline ( https://codereview.chromium.org/319203002/ )
...
Reason for revert:
Follow-on to fe689c46a7
, which needs to be reverted due to bot failures.
Original issue's description:
> another GM to ignore for blur rebaseline
>
> BUG=skia:
> TBR=jvanverth
> NOTRY=True
> NOTREECHECKS=True
>
> Committed: https://skia.googlesource.com/skia/+/f131055929afb9c9671aee3e575c380d48c5ee4d
R=humper@google.com
TBR=humper@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Author: jvanverth@google.com
Review URL: https://codereview.chromium.org/319943004
2014-06-06 10:59:13 -07:00
humper
f131055929
another GM to ignore for blur rebaseline
...
BUG=skia:
TBR=jvanverth
NOTRY=True
NOTREECHECKS=True
Author: humper@google.com
Review URL: https://codereview.chromium.org/319203002
2014-06-06 10:36:02 -07:00
humper
fe689c46a7
Faster GPU rect blur that doesn't require computing vertical and horizontal
...
scanlines on the CPU first. Should make extremely large drop shadows fast
again.
BUG=skia:
R=bsalomon@google.com
Author: humper@google.com
Review URL: https://codereview.chromium.org/316273004
2014-06-06 09:48:40 -07:00
kevin.petit
ea6b46b6c0
ARM Skia NEON patches - 39 - arm64 565 blitters
...
This enables all 565 blitters except S32A_D565_Opaque.
Here are some performance results:
S32_D565_Opaque:
================
+-------+------------+------------+
| count | Cortex-A53 | Cortex-A57 |
+-------+------------+------------+
| 1 | -18.37% | -13.04% |
+-------+------------+------------+
| 2 | -9.90% | -13.78% |
+-------+------------+------------+
| 4 | -8.28% | -6.77% |
+-------+------------+------------+
| 8 | 157.63% | 78.15% |
+-------+------------+------------+
| 16 | 72.67% | 44.81% |
+-------+------------+------------+
| 64 | 76.78% | 40.89% |
+-------+------------+------------+
| 256 | 73.85% | 36.05% |
+-------+------------+------------+
| 1024 | 75.73% | 36.70% |
+-------+------------+------------+
S32_D565_Blend:
===============
+-------+------------+------------+
| count | Cortex-A53 | Cortex-A57 |
+-------+------------+------------+
| 1 | -9.99% | -13.79% |
+-------+------------+------------+
| 2 | -9.17% | -6.74% |
+-------+------------+------------+
| 4 | -6.73% | -4.42% |
+-------+------------+------------+
| 8 | 163.31% | 112.82% |
+-------+------------+------------+
| 16 | 55.21% | 44.68% |
+-------+------------+------------+
| 64 | 54.09% | 41.99% |
+-------+------------+------------+
| 256 | 52.63% | 40.64% |
+-------+------------+------------+
| 1024 | 52.46% | 40.45% |
+-------+------------+------------+
S32A_D565_Blend:
================
+-------+------------+------------+
| count | Cortex-A53 | Cortex-A57 |
+-------+------------+------------+
| 1 | -5.88% | -6.06% |
+-------+------------+------------+
| 2 | -4.74% | -0.01% |
+-------+------------+------------+
| 4 | -5.42% | -3.03% |
+-------+------------+------------+
| 8 | 78.78% | 77.96% |
+-------+------------+------------+
| 16 | 98.19% | 79.61% |
+-------+------------+------------+
| 64 | 111.56% | 72.60% |
+-------+------------+------------+
| 256 | 113.80% | 69.96% |
+-------+------------+------------+
| 1024 | 114.42% | 70.85% |
+-------+------------+------------+
S32_D565_Opaque_Dither:
=======================
+-------+------------+------------+
| count | Cortex-A53 | Cortex-A57 |
+-------+------------+------------+
| 1 | -4.18% | -0.93% |
+-------+------------+------------+
| 2 | -2.43% | -2.04% |
+-------+------------+------------+
| 4 | -1.09% | -1.23% |
+-------+------------+------------+
| 8 | 184.89% | 136.53% |
+-------+------------+------------+
| 16 | 128.64% | 89.11% |
+-------+------------+------------+
| 64 | 132.68% | 100.98% |
+-------+------------+------------+
| 256 | 157.02% | 100.86% |
+-------+------------+------------+
| 1024 | 163.85% | 103.62% |
+-------+------------+------------+
S32_D565_Blend_Dither:
======================
+-------+------------+------------+
| count | Cortex-A53 | Cortex-A57 |
+-------+------------+------------+
| 1 | -4.87% | 0.01% |
+-------+------------+------------+
| 2 | -2.71% | 2.97% |
+-------+------------+------------+
| 4 | -2.20% | 0.28% |
+-------+------------+------------+
| 8 | 149.76% | 146.80% |
+-------+------------+------------+
| 16 | 85.69% | 95.77% |
+-------+------------+------------+
| 64 | 88.81% | 101.39% |
+-------+------------+------------+
| 256 | 97.32% | 107.22% |
+-------+------------+------------+
| 1024 | 98.08% | 115.71% |
+-------+------------+------------+
S32A_D565_Opaque_Dither:
========================
+-------+------------+------------+
| count | Cortex-A53 | Cortex-A57 |
+-------+------------+------------+
| 1 | -1.86% | 0.02% |
+-------+------------+------------+
| 2 | -0.58% | -1.52% |
+-------+------------+------------+
| 4 | -0.75% | 1.16% |
+-------+------------+------------+
| 8 | 240.74% | 155.16% |
+-------+------------+------------+
| 16 | 181.97% | 132.15% |
+-------+------------+------------+
| 64 | 203.11% | 136.48% |
+-------+------------+------------+
| 256 | 223.45% | 133.05% |
+-------+------------+------------+
| 1024 | 225.96% | 134.05% |
+-------+------------+------------+
Signed-off-by: Kévin PETIT <kevin.petit@arm.com>
BUG=skia:
R=djsollen@google.com , mtklein@google.com
Author: kevin.petit@arm.com
Review URL: https://codereview.chromium.org/317193003
2014-06-06 08:45:36 -07:00
mtklein
1b918af0d8
Rename skimage expectations for ASAN bot to match bot renaming.
...
BUG=skia:
R=borenet@google.com , mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/316063004
2014-06-05 08:51:26 -07:00
bsalomon
93c2fb02f1
Rebaselines for drrect GM on GPU
...
TBR=
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/318773007
2014-06-05 07:56:56 -07:00
bungeman
30bcaa0c57
Update expectations for gyp change.
...
It appears that with the gyp update, floating point operations
on x86_32 are ever so slightly different when drawing some paths.
R=jvanverth@google.com
TBR=jvanverth@google.com
NOTRY=True
Author: bungeman@google.com
Review URL: https://codereview.chromium.org/315043006
2014-06-04 15:04:11 -07:00
borenet
e2d543a882
Update SKP version to 17
...
Automatic commit by the RecreateSKPs bot.
TBR=
Author: borenet@google.com
Review URL: https://codereview.chromium.org/312043004
2014-06-03 23:13:08 -07:00
jvanverth
1800b1f51e
manual bench rebase after 55ada06
...
R=robertphillips@google.com
TBR=robertphillips@google.com
Bypassing trybots:
NOTRY=true
Author: jvanverth@google.com
Review URL: https://codereview.chromium.org/315683004
2014-06-03 11:46:30 -07:00
humper
2db11d18af
a few rebaseline stragglers from image scaling change
...
BUG=skia:
NOTRY=True
NOTREECHECKS=True
TBR=jvanverth
Author: humper@google.com
Review URL: https://codereview.chromium.org/311853004
2014-06-03 10:20:49 -07:00
borenet
66aa609a49
Update SKP version to 16
...
Automatic commit by the RecreateSKPs bot.
TBR=
Author: borenet@google.com
Review URL: https://codereview.chromium.org/313593002
2014-06-03 09:38:11 -07:00
Brian Salomon
c7671bec73
Rebase a few GMs and remove some tests from ignored-tests.txt
...
Review URL: https://codereview.chromium.org/311813003
2014-06-03 10:01:47 -04:00
bsalomon
8af0523b38
Fall back to using clip effect for outer rect in drawdrrect
...
R=jvanverth@google.com
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/310483010
2014-06-03 06:34:59 -07:00
commit-bot@chromium.org
6175d50a25
more rebaselines for filterbitmap and downsamplebitmap.
...
BUG=
R=epoger@google.com
TBR=epoger
NOTRY=True
NOTREECHECKS=True
Author: humper@google.com
Review URL: https://codereview.chromium.org/304353007
git-svn-id: http://skia.googlecode.com/svn/trunk@14995 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-30 15:11:28 +00:00
bsalomon@google.com
ecc8649204
Mark remaining Ubuntu msaa shadertext2 images as ignore-failure.
...
BUG=skia:2619
Review URL: https://codereview.chromium.org/304323002
git-svn-id: http://skia.googlecode.com/svn/trunk@14969 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-29 18:10:46 +00:00
bsalomon@google.com
0b8bbf685b
Rebaseline stragglers, mark shadertext2 as ignore on ubunutu for msaa configs.
...
BUG=skia:2619
Review URL: https://codereview.chromium.org/308723002
git-svn-id: http://skia.googlecode.com/svn/trunk@14964 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-29 16:56:53 +00:00
bsalomon@google.com
97415aa6fc
Rebase shadertext2,3 and stroketext on gpu configs
...
Review URL: https://codereview.chromium.org/304203003
git-svn-id: http://skia.googlecode.com/svn/trunk@14955 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-29 15:45:19 +00:00
senorblanco@chromium.org
f970b70db5
New baselines for imagefilter GMs in perspective mode post-r14920.
...
TBR=bsalomon@google.com
Review URL: https://codereview.chromium.org/301183002
git-svn-id: http://skia.googlecode.com/svn/trunk@14954 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-29 15:36:09 +00:00
commit-bot@chromium.org
c4be1462df
re-enable downsample and filterbitmap GMs
...
BUG=
R=epoger@google.com
TBR=epoger
NOTRY=True
NOTREECHECKS=True
Author: humper@google.com
Review URL: https://codereview.chromium.org/301963003
git-svn-id: http://skia.googlecode.com/svn/trunk@14953 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-29 14:53:24 +00:00
commit-bot@chromium.org
0e59c3a2e7
rebaselines for ignored filterbitmap / downsamplebitmap tests
...
BUG=
R=epoger@google.com
TBR=epoger
NOTRY=True
NOTREECHECKS=True
Author: humper@google.com
Review URL: https://codereview.chromium.org/305933002
git-svn-id: http://skia.googlecode.com/svn/trunk@14952 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-29 14:42:32 +00:00
bsalomon@google.com
5bf38e24ca
Rebaseline GMs with missing expectated images and shadertext2 msaa
...
Review URL: https://codereview.chromium.org/308673002
git-svn-id: http://skia.googlecode.com/svn/trunk@14950 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-29 14:27:16 +00:00
commit-bot@chromium.org
0a92d8e1dc
ignore failing pdf-native for shadertext
...
TBR=
NOTRY=True
NOTREECHECKS=True
Author: reed@google.com
Review URL: https://codereview.chromium.org/304923002
git-svn-id: http://skia.googlecode.com/svn/trunk@14949 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-29 14:05:56 +00:00
commit-bot@chromium.org
f87f1e31c5
rebaselines for shadertext after unitmapper removal
...
TBR=
NOTRY=True
NOTREECHECKS=True
Author: reed@google.com
Review URL: https://codereview.chromium.org/308653002
git-svn-id: http://skia.googlecode.com/svn/trunk@14948 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-29 13:56:19 +00:00
commit-bot@chromium.org
7ac83bb9d6
ignore failures for acutals that never appear
...
TBR=
NOTRY=True
NOTREECHECKS=True
Author: reed@google.com
Review URL: https://codereview.chromium.org/304153003
git-svn-id: http://skia.googlecode.com/svn/trunk@14947 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-29 13:43:05 +00:00