mtklein
14ed0fd498
Pre-cache fDirection and fConvexity for recorded SkPaths too.
...
http://build.chromium.org/p/client.skia/builders/Test-Ubuntu13.10-GCE-NoGPU-x86_64-Release-TSAN/builds/1211/steps/dm/logs/stdio
I don't see any big perf hit locally:
desk_googlespreadsheetdashed.skp 1.68ms -> 1.74ms 1.04x
desk_mobilenews.skp 643us -> 665us 1.04x
desk_tigersvg.skp 51.1us -> 52.5us 1.03x
desk_jsfiddlehumperclip.skp 37us -> 37.9us 1.02x
desk_samoasvg.skp 373us -> 380us 1.02x
desk_wordpress.skp 697us -> 708us 1.02x
desk_mapsvg.skp 698us -> 708us 1.02x
tabl_googleblog.skp 553us -> 560us 1.01x
desk_wowwiki.skp 1.31ms -> 1.32ms 1.01x
tabl_mozilla.skp 1.44ms -> 1.45ms 1.01x
desk_sfgate.skp 156us -> 157us 1.01x
desk_chalkboard.skp 376us -> 378us 1x
desk_baidu.skp 101us -> 101us 1x
desk_gmailthread.skp 231us -> 231us 1x
desk_carsvg.skp 379us -> 379us 1x
desk_googlehome.skp 38.1us -> 38.1us 1x
desk_css3gradients.skp 89.6us -> 89.2us 1x
desk_googlespreadsheet.skp 549us -> 546us 0.99x
desk_pokemonwiki.skp 8.67ms -> 8.62ms 0.99x
tabl_mlb.skp 294us -> 291us 0.99x
tabl_gamedeksiam.skp 700us -> 692us 0.99x
tabl_worldjournal.skp 143us -> 142us 0.99x
desk_blogger.skp 441us -> 436us 0.99x
desk_twitter.skp 452us -> 446us 0.99x
desk_gws.skp 152us -> 150us 0.99x
tabl_gmail.skp 24.2us -> 23.9us 0.99x
tabl_sahadan.skp 84.7us -> 83.5us 0.99x
tabl_cnn.skp 1.24ms -> 1.22ms 0.99x
tabl_ukwsj.skp 543us -> 535us 0.99x
desk_yahooanswers.skp 124us -> 123us 0.99x
desk_booking.skp 905us -> 891us 0.98x
tabl_androidpolice.skp 1.76ms -> 1.73ms 0.98x
desk_ugamsolutions.skp 281us -> 276us 0.98x
desk_nytimes.skp 209us -> 204us 0.98x
tabl_techmeme.skp 98.4us -> 96.1us 0.98x
tabl_nofolo.skp 59.2us -> 57.8us 0.98x
desk_weather.skp 244us -> 238us 0.98x
desk_facebook.skp 546us -> 531us 0.97x
desk_linkedin.skp 321us -> 311us 0.97x
tabl_digg.skp 801us -> 770us 0.96x
tabl_culturalsolutions.skp 332us -> 319us 0.96x
desk_amazon.skp 103us -> 99us 0.96x
tabl_engadget.skp 610us -> 579us 0.95x
tabl_cnet.skp 144us -> 136us 0.95x
desk_fontwipe.skp 36.6us -> 34.7us 0.95x
desk_ebay.skp 173us -> 164us 0.94x
tabl_hsfi.skp 5.95us -> 5.58us 0.94x
tabl_deviantart.skp 134us -> 126us 0.94x
desk_espn.skp 261us -> 243us 0.93x
BUG=skia:
Review URL: https://codereview.chromium.org/861853002
2015-01-20 13:47:19 -08:00
mtklein
19f306013e
Allow pdf as a --config.
...
We just can't run this on the bots yet. It's fine locally.
BUG=skia:3255
Review URL: https://codereview.chromium.org/857373002
2015-01-20 13:34:39 -08:00
mtklein
59c69479d4
Upstream support for giflib >= 5.1.
...
DGifCloseFile now takes two arugments. The second argument appears to be an
optional out-param with more information on failures.
( c.f. http://giflib.sourceforge.net/gif_lib.html )
PS 1 is the original patch we received from google3. I've updated it a bit to
be pedantically legal C++98.
BUG=skia:
Review URL: https://codereview.chromium.org/860853003
2015-01-20 12:38:06 -08:00
bungeman
e1a828c555
Move SkFontMgr and SkFontStyle impls to own cpp.
...
SkFontMgr and SkFontStyle implementations are currently burried in the
old SkFontHost.cpp file. Move these implementations to their own file
so that the implementations are easier to find, and to make clearer that
SkFontHost.cpp needs to be removed.
Review URL: https://codereview.chromium.org/799533004
2015-01-20 11:15:37 -08:00
scroggo
8fd8d38626
Add ability to specify gyp dir to gyp_to_android.
...
When running gyp_to_android inside a Skia tree, it uses the gyp program
in third_party/externals. Inside an Android tree, we need to use a
different location for gyp (the Android copy of Skia, in external/skia,
does not contain third_party/externals).
The bot handles this by importing gyp_to_android and running its main
function directly.
Add command line arguments so a human can directly run gyp_to_android.
Review URL: https://codereview.chromium.org/864503002
2015-01-20 10:39:25 -08:00
halcanary
211fcc6831
convert pdf design document to markdown
...
Review URL: https://codereview.chromium.org/849133002
2015-01-20 10:39:06 -08:00
bsalomon
3886046f00
Revert "Revert "delete old things!""
...
This reverts commit 8b4489b6e6
.
Delete gm and other unused files
TBR=mtklien@google.com
Review URL: https://codereview.chromium.org/856103002
2015-01-20 10:23:02 -08:00
egdaniel
58136167fc
Do more cleanup from xp changes
...
BUG=skia:
Review URL: https://codereview.chromium.org/811903004
2015-01-20 10:19:22 -08:00
mtklein
9264a95608
Image subsets as part of the name instead of a separate source type.
...
This will hold us closer to the principle that the test name (and only the test
name) should correspond to expected output. By the same reasoning, mix in the
number of subsets: if that changes, the expected output also changes.
BUG=skia:3255
Review URL: https://codereview.chromium.org/863723002
2015-01-20 10:11:53 -08:00
halcanary
87f3ba4847
Simplify skiatest framework.
...
skiatest::Test class is now a simple struct. Some
functionalty, such as counting errors or timing is now
handled elsewhere.
skiatest:Reporter is now a simpler abstract class. The two
implementations handle test errors.
DM and pathops_unittest updated.
Review URL: https://codereview.chromium.org/830513004
2015-01-20 09:30:20 -08:00
joshualitt
873ad0e0b4
BUG=skia:
...
Review URL: https://codereview.chromium.org/815643005
2015-01-20 09:08:52 -08:00
reed
94443b8718
remove dead code after HQ change
...
BUG=skia:
Review URL: https://codereview.chromium.org/845303005
2015-01-20 08:50:37 -08:00
scroggo
c7bfd5b441
Stop building gm in Android framework build.
...
Allows us to delete gm.
Review URL: https://codereview.chromium.org/860803004
2015-01-20 08:25:36 -08:00
reed
83c8dec46a
remove legacy flags for old image filtering
...
BUG=skia:
TBR=
Review URL: https://codereview.chromium.org/857193003
2015-01-20 07:41:24 -08:00
Mike Klein
2babfd96ae
force a build with new --config flags
...
BUG=skia:
Review URL: https://codereview.chromium.org/798463005
2015-01-20 10:24:19 -05:00
egdaniel
71e236c03e
Remove willReadDst from GrFragmentProcessor.
...
Since only XP's can read dst now, there is no reason to have this query on GrFP.
This also triggered a chain reaction of cleaning up/removing unnecessary code
elsewhere.
BUG=skia:
Review URL: https://codereview.chromium.org/851143003
2015-01-20 06:34:51 -08:00
scroggo
b2b416d384
Revert of remove unused SkAvoidXfermode (patchset #2 id:20001 of https://codereview.chromium.org/860583002/ )
...
Reason for revert:
Breaking Android framework build, which still uses AvoidXfermode. (failure shown here: 565b76b4bd/logs/build_error.log
)
Here is the Java class that uses it: https://cs.corp.google.com/#android/frameworks/base/graphics/java/android/graphics/AvoidXfermode.java&sq=package:android
It has been deprecated. The glue code (which actually references the Skia file) is here: https://cs.corp.google.com/#android/frameworks/base/core/jni/android/graphics/Xfermode.cpp&q=Xfermode.cpp&sq=package:android
Mike suggested we move the implementation into Android, which is fine with me.
Original issue's description:
> remove unused SkAvoidXfermode
>
> BUG=skia:
> TBR=
> NOTRY=True
>
> Committed: https://skia.googlesource.com/skia/+/2d02df7a9a50217dac8c1d11681832a927ed79ce
TBR=bsalomon@google.com ,reed@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/822953003
2015-01-20 06:33:14 -08:00
weiliangc
07f26976f7
Remove unused TileGridInfo
...
Chromium no longer uses TileGridInfo as of CL 856853003 and remove this
from skia.
BUG=chromium:447662
Review URL: https://codereview.chromium.org/828503004
2015-01-20 05:57:06 -08:00
rmistry
6a93900f06
Remove roll_deps and trybots_to_run.
...
BUG=skia:
Review URL: https://codereview.chromium.org/859963003
2015-01-20 05:44:46 -08:00
skia.buildbots
58b27523ce
Update SKP version
...
Automatic commit by the RecreateSKPs bot.
TBR=
Review URL: https://codereview.chromium.org/786403004
2015-01-19 23:14:06 -08:00
cwallez
2467d71346
Remove a few unused statements.
...
BUG=
Review URL: https://codereview.chromium.org/837643003
2015-01-19 13:57:17 -08:00
sugoi
4043d17c63
Broken dm fix
...
BUG=skia:
Review URL: https://codereview.chromium.org/855953005
2015-01-19 10:31:35 -08:00
sugoi
692135f968
YUV planes cache
...
- Added new classes to contain YUV planes of memory, along with the associated data.
- Used these classes in load_yuv_texture() to enable YUV planes caching
- Added a unit test for the new cache
BUG=450021
Review URL: https://codereview.chromium.org/851273003
2015-01-19 10:10:27 -08:00
skia.buildbots
89499d76b9
Update SKP version
...
Automatic commit by the RecreateSKPs bot.
TBR=
Review URL: https://codereview.chromium.org/860613003
2015-01-18 22:42:54 -08:00
reed
e76de5ac15
remove dead header
...
BUG=skia:
TBR=
NOTRY=True
NOTREECHECKS=True
Review URL: https://codereview.chromium.org/858813002
2015-01-18 20:12:26 -08:00
reed
2d02df7a9a
remove unused SkAvoidXfermode
...
BUG=skia:
TBR=
NOTRY=True
Review URL: https://codereview.chromium.org/860583002
2015-01-18 20:01:30 -08:00
reed
bc4f6adeba
remove dead code for scalar type
...
BUG=skia:
TBR=
Review URL: https://codereview.chromium.org/855273003
2015-01-18 11:19:33 -08:00
halcanary
03758b8c4a
tool --help alphabetizes command line flags
...
Review URL: https://codereview.chromium.org/854193003
2015-01-18 10:39:25 -08:00
robertphillips
46d36f0e7b
Refactor position computation to enable device space "nudge"
...
To match raster's handling of BW geometry we want to be able to perform a device space "nudge" on all geometry. This CL sets us up to be able to do that in GrGLVertexBuilder::transformToNormalizedDeviceSpace.
BUG=423834
TBR=bsalomon@google.com
Review URL: https://codereview.chromium.org/854013002
2015-01-18 08:14:14 -08:00
mtklein
75d98fd6f2
DM: Don't hold onto data longer than needed.
...
On my laptop, this cuts peak memory usage by more than half.
BUG=skia:3255
Review URL: https://codereview.chromium.org/859623002
2015-01-18 07:05:01 -08:00
skia.buildbots
c9b62ad60c
Update SKP version
...
Automatic commit by the RecreateSKPs bot.
TBR=
Review URL: https://codereview.chromium.org/836123008
2015-01-17 22:46:36 -08:00
reed
09519db20c
fatbits for all 4 views
...
BUG=skia:
TBR=
Review URL: https://codereview.chromium.org/829043005
2015-01-17 19:36:08 -08:00
skia.buildbots
95d755dbf9
Update SKP version
...
Automatic commit by the RecreateSKPs bot.
TBR=
Review URL: https://codereview.chromium.org/839673006
2015-01-16 23:04:02 -08:00
reed
a9cb871de8
fix labels on image-surface gm
...
BUG=skia:
TBR=
Review URL: https://codereview.chromium.org/834903003
2015-01-16 14:21:40 -08:00
fmalita
a709d24226
Rebaseline pictureshader GM after http://crrev.com/852213002
...
BUG=chromium:447707
TBR=egdaniel@google.com
Review URL: https://codereview.chromium.org/853243002
2015-01-16 14:15:28 -08:00
Brian Salomon
8b4489b6e6
Revert "delete old things!"
...
This reverts commit 15b125d401
.
NOTREECHECKS=true
original change breaks android tree
BUG=skia:
Review URL: https://codereview.chromium.org/848073005
2015-01-16 16:26:32 -05:00
bsalomon
15b125d401
delete old things!
...
NOTREECHECKS=true
Review URL: https://codereview.chromium.org/855003006
2015-01-16 12:08:54 -08:00
reed
f7094c4ed0
reorg filter quality cascade
...
BUG=skia:
NOTREECHECKS=True
Review URL: https://codereview.chromium.org/844913004
2015-01-16 12:05:19 -08:00
rmistry
e1f630dc8b
* Add nytimes_desktop pageset.
...
* Delete cuteoverload, frantzen, transformice and nytimes_tabl.
* Increase wait time for forecastio.
BUG=skia:3320
NOTRY=true
NOTREECHECKS=true
Review URL: https://codereview.chromium.org/808843004
2015-01-16 11:41:26 -08:00
jcgregorio
d4646f29c1
Add robots.txt
...
BUG=skia:
NOTREECHECKS=true
Review URL: https://codereview.chromium.org/851793004
2015-01-16 11:13:53 -08:00
Brian Salomon
a2d9478e92
Fix debugger wrt to new SkGpuDevice factory signature'
...
Review URL: https://codereview.chromium.org/855083003
2015-01-16 14:01:44 -05:00
reed
753c2af6bc
add more suppressions for mipmap fix
...
BUG=skia:
TBR=
NOTRY=True
NOTREECHECKS=True
Review URL: https://codereview.chromium.org/828633003
2015-01-16 09:31:13 -08:00
reed
7729e56a29
use log2(scale) to compute mip level
...
now w/ expanded suppressions
This reverts commit b50ced7030
.
BUG=skia:
TBR=
NOTRY=True
NOTREECHECKS=True
Review URL: https://codereview.chromium.org/856723003
2015-01-16 08:35:09 -08:00
bsalomon
afe3005be3
Require budget decision when creating a RenderTarget SkSurface.
...
Restructure SkGpuDevice creation:
*SkSurfaceProps are optional.
*Use SkSurfaceProps to communicate DF text rather than a flag.
*Tell SkGpuDevice::Create whether RT comes from cache or not.
Review URL: https://codereview.chromium.org/848903004
2015-01-16 07:32:33 -08:00
reed
b50ced7030
Revert of use log2(scale) to compute mip level (patchset #7 id:120001 of https://codereview.chromium.org/849333002/ )
...
Reason for revert:
need more suppressions
Original issue's description:
> use log2(scale) to compute mip level
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/15fd47f8a07615a7f5d78581aee4c80ff9f17fd9
TBR=robertphillips@google.com ,jvanverth@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/856783004
2015-01-16 07:27:46 -08:00
reed
15fd47f8a0
use log2(scale) to compute mip level
...
BUG=skia:
Review URL: https://codereview.chromium.org/849333002
2015-01-16 07:18:10 -08:00
caryclark
45fa447460
new files for pathops geometric intersection
...
There's no gyp references to these new files,
so this should only have the effect of reducing
the size of the commit that turns this code on.
TBR=
Review URL: https://codereview.chromium.org/853223002
2015-01-16 07:04:10 -08:00
egdaniel
40248f365b
Update ignore file
...
NOTRY=True
TBR=
BUG=skia:
Review URL: https://codereview.chromium.org/844813004
2015-01-16 06:44:18 -08:00
egdaniel
54f0e9d784
Add Xfer Processor for GrCustomXfermodes
...
BUG=skia:
Review URL: https://codereview.chromium.org/852203003
2015-01-16 06:29:47 -08:00
kkinnunen
678c1b019a
Fold alpha to the draw in savelayer-draw-restore patterns with non-opaque draw
...
Fold alpha of a save layer call to the subsequent draw call paint, even when
the draw call paint color is already non-opaque.
Comparing the difference of the unoptimized and the optimized call pattern
with all (layer alpha, draw alpha) combinations, this produces
off-by-one pixels ~50% of the time.
Reduces layers of current desk_carsvg.skp (recorded with cross-process
picture image filters allowed) from 122 to 115.
BUG=skia:3119
Review URL: https://codereview.chromium.org/840483005
2015-01-16 05:04:36 -08:00