AuroraMiddleware/skia2
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
41,518 Commits 1 Branch 0 Tags 544 MiB
1659d48b38
Commit Graph

467 Commits

Author SHA1 Message Date
benjaminwagner
d48e5b8640 Check for empty output in adb_wait_for_charge. 
Example error in https://chromium-swarm.appspot.com/user/task/2f96d6439584e411

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2105813003

Review-Url: https://codereview.chromium.org/2105813003
 2016-06-29 07:02:54 -07:00
rmistry
7bde5659d3 Revert of Remove Android SampleApp (patchset #5 id:80001 of https://codereview.chromium.org/2096683002/ ) 
Reason for revert:
Testing to see if this CL caused the failures in Build-Mac-Clang-Arm7-Debug-Android

Original issue's description:
> Remove Android SampleApp
>
> BUG=skia:
> GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2096683002
>
> Committed: https://skia.googlesource.com/skia/+/41bb5b40e71411ee39538399ea125986ec760a90

TBR=djsollen@google.com,liyuqian@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Review-Url: https://codereview.chromium.org/2099693002
 2016-06-24 05:24:16 -07:00
liyuqian
41bb5b40e7 Remove Android SampleApp 
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2096683002

Review-Url: https://codereview.chromium.org/2096683002
 2016-06-23 12:08:06 -07:00
stani
a80bb676d3 Remove check for cmake in android make script. 
Update docs explaining how to setup Android SDK.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2084763003
DOCS_PREVIEW= https://skia.org/?cl=2084763003

Review-Url: https://codereview.chromium.org/2084763003
 2016-06-21 13:13:20 -07:00
liyuqian
ea1fb74389 Keep drawer open in xlarge-land and add float fps 
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2071333002

Review-Url: https://codereview.chromium.org/2071333002
 2016-06-17 11:04:44 -07:00
liyuqian
71491dc14c Support resize in Android Viewer App 
Previously, we took out resize because Vulkan didn't support it in
Android. Now Android nyc-dev builds >= 2937079 and nyc-release builds >=
NRD66 supports it so we add it back.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2050613003

Review-Url: https://codereview.chromium.org/2050613003
 2016-06-09 12:02:34 -07:00
brianosman
28215d44b3 Support running Viewer via android_gdb_app 
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2055453003

Review-Url: https://codereview.chromium.org/2055453003
 2016-06-08 13:07:08 -07:00
liyuqian
2a437e6459 Provide filter when there are many options 
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2047233003

Review-Url: https://codereview.chromium.org/2047233003
 2016-06-08 11:17:09 -07:00
liyuqian
d94ad5823b Implement Raster Backend on Android Viewer App 
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2041193004

Review-Url: https://codereview.chromium.org/2041193004
 2016-06-07 14:22:38 -07:00
liyuqian
1f508fd0fe Show FPS in UI state 
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2043793002

Review-Url: https://codereview.chromium.org/2043793002
 2016-06-07 06:57:40 -07:00
brianosman
0dd9f2cbc4 Fix argument parsing in android app launcher script 
Makes the argument match the error message that gets printed (and users'
expectations).

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2030123002

Review-Url: https://codereview.chromium.org/2030123002
 2016-06-02 11:44:06 -07:00
liyuqian
e5a6cd9832 Now we can use drawer to view the state information of the native app, and set its state using the spinner. 
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2004633002

Committed: https://skia.googlesource.com/skia/+/4e4e30823fba0047b93a56bfcf05c04ca57e82ec

Review-Url: https://codereview.chromium.org/2004633002
 2016-05-27 08:52:52 -07:00
kjlubick
9ad0949338 Revert of Add drawer with state information (patchset #8 id:140001 of https://codereview.chromium.org/2004633002/ ) 
Reason for revert:
Broke Build-Ubuntu-GCC-Arm7-Debug-Android_Vulkan.  See https://uberchromegw.corp.google.com/i/client.skia.compile/builders/Build-Ubuntu-GCC-Arm7-Debug-Android_Vulkan/builds/134/steps/compile_skia%20on%20Ubuntu/logs/stdio.

Original issue's description:
> Now we can use drawer to view the state information of the native app, and set its state using the spinner.
>
> BUG=skia:
> GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2004633002
>
> Committed: https://skia.googlesource.com/skia/+/4e4e30823fba0047b93a56bfcf05c04ca57e82ec

TBR=djsollen@google.com,jvanverth@google.com,liyuqian@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Review-Url: https://codereview.chromium.org/2016343002
 2016-05-27 06:22:01 -07:00
djsollen
4145792736 Remove VisualBench and its Android implementation. 
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2018603003

Review-Url: https://codereview.chromium.org/2018603003
 2016-05-27 05:39:29 -07:00
liyuqian
4e4e30823f Now we can use drawer to view the state information of the native app, and set its state using the spinner. 
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2004633002

Review-Url: https://codereview.chromium.org/2004633002
 2016-05-26 12:43:43 -07:00
stephana
de8af07e41 Remove custom bundle ID for iOS 
BUG=skia:
R=borenet
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=1998273002

Review-Url: https://codereview.chromium.org/1998273002
 2016-05-20 11:20:38 -07:00
djsollen
3be9923105 Fix android scripts now that the $HOST is always lowercase. 
BUG=skia:5309
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1992873003

Review-Url: https://codereview.chromium.org/1992873003
 2016-05-20 07:03:17 -07:00
liyuqian
d3cdbcad65 Implement touch control 
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1982643004

Review-Url: https://codereview.chromium.org/1982643004
 2016-05-17 12:44:20 -07:00
liyuqian
36632f46a6 Change Android activity title from JNI call 
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1978843002

Review-Url: https://codereview.chromium.org/1978843002
 2016-05-13 09:57:44 -07:00
liyuqian
6ce4b003a2 Use title buttons to switch slides 
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1975723004

Review-Url: https://codereview.chromium.org/1975723004
 2016-05-13 06:45:21 -07:00
bungeman
b11cf50b4a Fix typo in SkOSWindow_AndroidNative. 
This allows the 'most' target to be built on Android.

Review-Url: https://codereview.chromium.org/1973043002
 2016-05-12 10:48:59 -07:00
liyuqian
7bde8f813f Warning instead of exception for cmake 
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1971953003

Review-Url: https://codereview.chromium.org/1971953003
 2016-05-12 10:21:17 -07:00
liyuqian
40d21de8b6 Use swipe gesture to switch between slides on Android 
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1965013007

Review-Url: https://codereview.chromium.org/1965013007
 2016-05-12 09:17:04 -07:00
liyuqian
796c5bb465 Initial commit of our new Android app to demo Skia. 
Currently, there's only a simple Activity with a title bar and a surface view
that connects with Skia viewer native application.

Before integrating user action events, I want to make sure that the design and
implementation so far are good.  Note that the old NativeApplication-based
Activity (ViewerActivity) is still there for reference and test purposes. It
will be removed eventually.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1952323004

Review-Url: https://codereview.chromium.org/1952323004
 2016-05-09 08:49:29 -07:00
brianosman
2d1ee7936e Added --deepColor option to SampleApp, triggers creation of a ten-bit/channel 
buffer. (Only on Windows at the moment). Uses new effect to do the final
gamma adjustment

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1919993002

Review-Url: https://codereview.chromium.org/1919993002
 2016-05-05 12:24:31 -07:00
mtklein
809ccf37ec Remove NEON runtime detection support. 
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1952953004
CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot

Review-Url: https://codereview.chromium.org/1952953004
 2016-05-05 10:58:39 -07:00
jvanverth
3452426715 Rename VulkanViewer to Viewer, take 2. 
Also puts Window and Application in sk_app namespace.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1945103003

Review-Url: https://codereview.chromium.org/1945103003
 2016-05-04 13:49:13 -07:00
djsollen
4b38938db8 Fix VulkanViewer package name 
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1941813002

Review-Url: https://codereview.chromium.org/1941813002
 2016-05-02 09:45:04 -07:00
djsollen
3a6aa4ceda Update gdb_app script to work with NDK r11c 
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1936163002

Review-Url: https://codereview.chromium.org/1936163002
 2016-05-02 09:19:59 -07:00
liyuqian
2275017e45 Add CMake path to gradle 
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1921553009

Review-Url: https://codereview.chromium.org/1921553009
 2016-05-02 05:33:20 -07:00
borenet
43bf511ead Delete ChromeOS code 
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1926163002

Review-Url: https://codereview.chromium.org/1926163002
 2016-04-29 14:01:34 -07:00
djsollen
affacce4c6 Require Android SDK copy of CMake to build Vulkan on Android. 
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1930423002

Review-Url: https://codereview.chromium.org/1930423002
 2016-04-29 08:09:43 -07:00
borenet
8795962baf Stop printing warnings about ADB version 
BUG=skia:5156
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1927973002

Review-Url: https://codereview.chromium.org/1927973002
 2016-04-28 09:31:38 -07:00
borenet
ef77ce9000 adb_wait_for_charge: Don't download toolchains 
BUG=skia:5156
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1926833003

Review-Url: https://codereview.chromium.org/1926833003
 2016-04-27 13:44:57 -07:00
djsollen
d574c98c7d Make the default android build be release_developer. 
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1929663002

Review-Url: https://codereview.chromium.org/1929663002
 2016-04-27 13:44:28 -07:00
djsollen
f62b2354b3 Upgrade Android Gradle plugins 
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1926743002

Review-Url: https://codereview.chromium.org/1926743002
 2016-04-27 08:48:56 -07:00
djsollen
460f40507e Make clang the default Android compiler. 
BUG=skia:5215
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1919873003

Review URL: https://codereview.chromium.org/1919873003
 2016-04-25 11:45:35 -07:00
djsollen
12d62a7d51 VulkanViewer on Android 
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1903253003

Review URL: https://codereview.chromium.org/1903253003
 2016-04-21 07:59:44 -07:00
djsollen
9df5d07209 Cleanup android build files and tools 
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1898793004

Review URL: https://codereview.chromium.org/1898793004
 2016-04-18 12:57:35 -07:00
djsollen
382949db14 Update android toolchain variable to point to root dir and not the bin 
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1900773002

Review URL: https://codereview.chromium.org/1900773002
 2016-04-18 11:01:02 -07:00
borenet
2892668f1b Fix ChromeOS Swarming bot compile 
BUG=skia:5158
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1886573004

Review URL: https://codereview.chromium.org/1886573004
 2016-04-13 09:37:26 -07:00
borenet
ac8681b0a1 iOS: Tweak xcodebuild location 
BUG=skia:5155
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1879513002

Review URL: https://codereview.chromium.org/1879513002
 2016-04-12 06:21:47 -07:00
kjlubick
312398159c Add support for pyadb to setup_adb.sh 
BUG=skia:5156
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1869813002

Review URL: https://codereview.chromium.org/1869813002
 2016-04-07 10:57:27 -07:00
borenet
b0070197ff More iOS swarming bot fixes 
- Copy the packaged app into xcodebuild/...
- Isolate ios/bin directory

BUG=skia:5155
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1860333002

Review URL: https://codereview.chromium.org/1860333002
 2016-04-06 11:38:55 -07:00
mtklein
8c13cd1aba Another NDK release. Still just bug fixes. 
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1864073002

Review URL: https://codereview.chromium.org/1864073002
 2016-04-06 06:12:01 -07:00
borenet
d0c57a5396 Fixes for iOS Swarming bot 
BUG=skia:5155
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1855223002

Review URL: https://codereview.chromium.org/1855223002
 2016-04-04 12:39:32 -07:00
halcanary
9d524f22bf Style bikeshed - remove extraneous whitespace 
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1842753002

Review URL: https://codereview.chromium.org/1842753002
 2016-03-29 09:03:53 -07:00
kjlubick
e577693b3b Prevent waiting for charge twice 
BUG=skia:5111
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1840003002

Review URL: https://codereview.chromium.org/1840003002
 2016-03-29 05:50:41 -07:00
rmistry
8ce5912fe3 Skip toolchain downloads for a few android tools. 
This is an attempt to avoid downloading the android toolchain when not required.
I went through all binaries listed in https://code.google.com/p/chromium/codesearch#chromium/build/scripts/slave/recipe_modules/skia/android_flavor.py except for android_ninja.

BUG=skia:5119
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1832883002

Review URL: https://codereview.chromium.org/1832883002
 2016-03-28 09:35:41 -07:00
kjlubick
face88a8ce Forward serial (fixes charging) 
NOTRY=true
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1832103002

Review URL: https://codereview.chromium.org/1832103002
 2016-03-25 09:47:55 -07:00
kjlubick
73233a7575 patch battery charging until recipe is updated 
BUG=skia:5111
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1834793003

Review URL: https://codereview.chromium.org/1834793003
 2016-03-25 05:53:58 -07:00
kjlubick
2e59f1f2fd Splitting up wait_for_device into two pieces 
BUG=skia:5111
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1829753004

Review URL: https://codereview.chromium.org/1829753004
 2016-03-25 05:22:40 -07:00
mtklein
1215c6ac94 NDK: r11 -> r11b 
Just bug fixes.  Nothing terribly exciting.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1825213007

Review URL: https://codereview.chromium.org/1825213007
 2016-03-24 06:44:03 -07:00
djsollen
42d95a0afb Fix gdb debugging for the latest NDK release. 
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1806343003

Review URL: https://codereview.chromium.org/1806343003
 2016-03-17 10:45:47 -07:00
mtklein
18300a3aa7 detach -> release 
The C++ standard library uses the name "release" for the operation we call "detach".

Rewriting each "detach(" to "release(" brings us a step closer to using standard library types directly (e.g. std::unique_ptr instead of SkAutoTDelete).

This was a fairly blind transformation.  There may have been unintentional conversions in here, but it's probably for the best to have everything uniformly say "release".

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1809733002

Review URL: https://codereview.chromium.org/1809733002
 2016-03-16 13:53:35 -07:00
djsollen
b3b6beae04 Cleanup download scripts related to new Android NDK. 
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1810603002

Review URL: https://codereview.chromium.org/1810603002
 2016-03-16 08:48:58 -07:00
mtklein
e2a88f244a Android NDK: r10e -> r11 
I have tested that skia_lib builds with {gcc,clang} x {arm_v7_neon,arm64} on my Mac.
Bots seem happy.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1780223002

Review URL: https://codereview.chromium.org/1780223002
 2016-03-10 08:41:34 -08:00
djsollen
f9deeb66d0 Update android_make to support both --gcc and --clang options. 
This CL also fixes all the errors that resulted from compiling
with clang and ccache.

BUG=skia:4948
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1774503004

Review URL: https://codereview.chromium.org/1774503004
 2016-03-07 12:30:47 -08:00
djsollen
e71dc3fd0d Use a statically linked libhwui for testing. 
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1688383005

Review URL: https://codereview.chromium.org/1688383005
 2016-02-16 09:19:36 -08:00
mtklein
c34940ec16 Remove check for platform_tools/android/third_party/externals. 
We don't sync anything into it anymore, so a fresh gclient sync won't create it.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1694813004

Review URL: https://codereview.chromium.org/1694813004
 2016-02-12 12:54:15 -08:00
djsollen
2a8fcb4647 Update Android framework makefile to build static and shared libs 
Also use static lib for testing tools and expose includes needed for
other framework testing tools to statically link in Skia.
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1696483002

Review URL: https://codereview.chromium.org/1696483002
 2016-02-12 08:44:39 -08:00
mtklein
4e79f33452 msan: build expat from source 
This should let us test it on the MSAN bot.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1674053002

CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-MSAN-Trybot

Review URL: https://codereview.chromium.org/1674053002
 2016-02-07 13:31:23 -08:00
kkinnunen
3ca7336049 SampleApp: remove SkWindow::onPDFSaved, it does not work 
Remove SkWindow::onPDFSaved, it does not work and it is not used anymore.

Also, it is very SampleApp -specific feature implemented in SkWindow class.
SkWindow class is probably intended to be more app-agnosting than
what this method implies.

Presumably the idea of the callback was to inform the user of
SampleApp that the PDF was saved to a certain location.

For Android SampleApp, show a hardcoded toast that the PDF was saved to
/sdcard.

BUG=skia:4733
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1547923002

Review URL: https://codereview.chromium.org/1547923002
 2016-01-18 00:47:14 -08:00
kkinnunen
721772ec49 VisualBench: Make the Android SDL app start without cmdline arguments 
Make the Android SDL VisualBench start even if it is started without
command-line arguments.

Also makes it start when started by pressing the icon.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1573913008

Review URL: https://codereview.chromium.org/1573913008
 2016-01-14 11:54:13 -08:00
kkinnunen
fe09119dd2 VisualBench: Use first succeeding EGL API 
Fix initialization of the app window by
using the first EGL context that succeeds, not the last one.

Fixes the window creation in some cases on devices that support
OpenGL and OpenGL ES.

Also check EGL call results.

BUG=skia:4733
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1582313002

Review URL: https://codereview.chromium.org/1582313002
 2016-01-14 09:12:01 -08:00
kkinnunen
4c7040bf8a SampleApp: Make android_install_app and android_launch_app work consistently 
Make android_install_app work more consistently:
* App can be "SampleApp" or "VisualBench"

Make android_launch_app work more consistently:
* Parameters to SampleApp are passed correctly
* SampleApp is actually launched

The parameters to "am" need to be quoted, since the command
is run on the device shell.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1589883002

Review URL: https://codereview.chromium.org/1589883002
 2016-01-14 06:07:40 -08:00
kkinnunen
7ddfeeddf7 Make android scripts not warn about ADB in newer SDKs 
The older SDK says:
$ adb version
Android Debug Bridge version 1.0.32

The newer SDK says:
$ adb version
Android Debug Bridge version 1.0.32
Revision eac51f2bb6a8-android

Removes the shebang as the file is not intended to be
run, and the copyright would render it useless.
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1583793002

Review URL: https://codereview.chromium.org/1583793002
 2016-01-13 22:53:55 -08:00
borenet
f8d4d5c995 Android bots: set battery threshold to 80% 
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1559913003

Review URL: https://codereview.chromium.org/1559913003
 2016-01-04 12:33:26 -08:00
borenet
50850b152f Android devices: wait for 100% charge 
Some devices are getting pretty low by the end of the build (3%).  No reason to cut it close, bump to 100% charge.  This will cause some devices to sit for a while as they charge up.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1556023002

Review URL: https://codereview.chromium.org/1556023002
 2016-01-04 10:44:03 -08:00
borenet
f64be44667 adb_wait_for_device: More fixes 
BUG=skia:4690

Review URL: https://codereview.chromium.org/1527713002
 2015-12-15 04:25:39 -08:00
borenet
c9730831fc adb_wait_for_device: Add battery fallback, support no battery 
BUG=skia:4690
TBR=rmistry

Review URL: https://codereview.chromium.org/1528563002
 2015-12-14 10:07:37 -08:00
borenet
b11c4ff668 adb_wait_for_device: If we can't get the battery level, just exit 
BUG=skia:4606
TBR=rmistry
NOTREECHECKS=true

Review URL: https://codereview.chromium.org/1529453002
 2015-12-14 06:48:43 -08:00
borenet
0b29b728ca Add minimum battery level to adb_wait_for_device 
This should prevent the Android bots running out of battery at the
expense of extra time spent waiting at the end of the build.

BUG=skia:4606

Review URL: https://codereview.chromium.org/1522013002
 2015-12-14 05:56:46 -08:00
aam
419c37269f Fix 'debugging on Android' android_gdb_app script. 
1) com.skia -> com.skia.sample_app
2) pass arguments to android_gdb_app to android_setup.sh so you can build gdbserver binaries for your actual device(rather than default arm64). This allows you to run it like this for example:

  ./platform_tools/android/bin/android_gdb_app -d nexus_6

BUG=skia:
DOCS_PREVIEW= https://skia.org/?cl=1509853006

Review URL: https://codereview.chromium.org/1509853006
 2015-12-10 14:14:56 -08:00
borenet
41cbf3f807 Add android_skp_capture.py, JSON file for geniewidget 
The script runs through the directory of JSON files, capturing SKPs from
the apps specified by the JSON files.

BUG=skia:

Review URL: https://codereview.chromium.org/1483063006
 2015-12-04 06:59:31 -08:00
stephana
c60b310af7 Modify iOSShell-gyp to generate unique bundle identifier 
BUG=skia:

Review URL: https://codereview.chromium.org/1483143002
 2015-12-02 09:45:30 -08:00
joshualitt
43f610f693 Parse command line arguments for sdl + android 
TBR=
BUG=skia:

Review URL: https://codereview.chromium.org/1432983002
 2015-11-10 08:27:22 -08:00
joshualitt
01f4a9e7bf Fixes for building with sdl on android 
BUG=skia:
TBR=bsalomon@google.com

Review URL: https://codereview.chromium.org/1437613002
 2015-11-10 07:36:18 -08:00
msarett
b747b90501 Remove dependencies on Android's forked decoder libraries 
Disable SkImageDecoder's code which relies on Android's customized
libpng and libjpeg. Build standard versions of libpng and libjpeg-turbo
everywhere. The SkImageDecoder code has been replaced with SkCodec, which
can decode subsets using standard library APIs

BUG=skia:

Review URL: https://codereview.chromium.org/1406153015
 2015-11-06 11:15:49 -08:00
joshualitt
474a9ea051 Wire up SDL on Android 
BUG=skia:

Committed: https://skia.googlesource.com/skia/+/a4d3797c3b0f0cac8493c46cb334ca88a5d6ccf6

Review URL: https://codereview.chromium.org/1415453009
 2015-11-05 11:49:35 -08:00
joshualitt
5d7a7fe563 Revert of Wire up SDL on Android (patchset #4 id:60001 of https://codereview.chromium.org/1415453009/ ) 
Reason for revert:
breaks appurify

Original issue's description:
> Wire up SDL on Android
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/a4d3797c3b0f0cac8493c46cb334ca88a5d6ccf6

TBR=bsalomon@google.com,robertphillips@google.com,joshualitt@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Review URL: https://codereview.chromium.org/1410703009
 2015-11-05 10:48:41 -08:00
joshualitt
a4d3797c3b Wire up SDL on Android 
BUG=skia:

Review URL: https://codereview.chromium.org/1415453009
 2015-11-05 08:35:31 -08:00
joshualitt
6db78d74fa Fix visualbench exiting on startup on android 
BUG=skia:

Review URL: https://codereview.chromium.org/1416123003
 2015-10-26 12:00:42 -07:00
jvanverth
338047e21f Clean up iOS build files 
Review URL: https://codereview.chromium.org/1409663002
 2015-10-15 13:20:35 -07:00
mtklein
e14937e7c4 Update Android toolchains and streamline process. 
- This updates to r10e / API v21 everywhere.
  - This has each host machine fetch the NDK,
    run make-standalone-toolchain.sh, and copy gdbserver itself.

(It will do all this once per $ARCH, which is a little inefficient, but it
washes out in steady state.)

BUG=skia:

Review URL: https://codereview.chromium.org/1385463002
 2015-10-01 13:24:23 -07:00
halcanary
ab26a9b427 android/apps: Add CanvasProof App; 
Compare Ganesh and HWUI canvas rendering of SKPs on android.

Put SKP files in .../canvasproof/src/main/assets/skps

Run on a Marshmallow device.

NOTREECHECKS=true

Review URL: https://codereview.chromium.org/1258123004
 2015-09-23 12:40:34 -07:00
borenet
ad54ffc235 adb_wait_for_device: Skip adb wait-for-device 
This should still wait for the device to be attached and finished
booting, but will prevent no-output timeouts due to
`adb wait-for-device` never finishing.

The effect should be that, when an Android device is disconnected, the
"wait for device" step will run forever, or until the device
reconnects. This should prevent a disconnected device from spreading
purple all over the status page.

BUG=skia:

Review URL: https://codereview.chromium.org/1315753010
 2015-09-03 10:41:07 -07:00
borenet
e5a38f0ad2 VisualBenchTest: Read nanobench_flags.txt 
BUG=skia:4093

Review URL: https://codereview.chromium.org/1314873005
 2015-09-02 06:04:29 -07:00
borenet
5e04bcfddd Run Appurify bot in release mode 
BUG=skia:4093

Review URL: https://codereview.chromium.org/1306953006
 2015-08-31 09:30:57 -07:00
borenet
89971d4537 Use a different download URL for Android toolchains 
The current one isn't working on the Appurify bot

BUG=skia:4093

Review URL: https://codereview.chromium.org/1311533006
 2015-08-31 08:35:32 -07:00
halcanary
96fcdcc219 Style Change: NULL->nullptr 
DOCS_PREVIEW= https://skia.org/?cl=1316233002

Review URL: https://codereview.chromium.org/1316233002
 2015-08-27 07:41:16 -07:00
halcanary
385fe4d4b6 Style Change: SkNEW->new; SkDELETE->delete 
DOCS_PREVIEW= https://skia.org/?cl=1316123003

Review URL: https://codereview.chromium.org/1316123003
 2015-08-26 13:07:49 -07:00
borenet
877a52ae61 VisualBenchTest: Write JSON output 
BUG=skia:4093

Review URL: https://codereview.chromium.org/1302103002
 2015-08-20 09:12:39 -07:00
borenet
e5e6c6069f Add VisualBenchTestActivity for instrumentation-testing VisualBench 
BUG=skia:4093

Review URL: https://codereview.chromium.org/1295823004
 2015-08-19 12:06:47 -07:00
msarett
3011711d5d Revert of Update skia to test with libpng to 1.6.10 (patchset #3 id:60001 of https://codereview.chromium.org/1301523005/ ) 
Reason for revert:
DM is failing on gm tests on Android bots.  Cause is not yet clear.

Original issue's description:
> Update skia to test with libpng to 1.6.10
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/f272bb03df9b86e7ea2cf23fb4d5cc56624e0118

TBR=djsollen@google.com,scroggo@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Review URL: https://codereview.chromium.org/1298223002
 2015-08-18 11:36:44 -07:00
msarett
f272bb03df Update skia to test with libpng to 1.6.10 
BUG=skia:

Review URL: https://codereview.chromium.org/1301523005
 2015-08-18 10:46:01 -07:00
msarett
fcaaadee71 Switching Skia to chromium's libjpeg-turbo 
Compile SkJpegCodec and SkImageDecoder_libjpeg with
chromium's libjpeg-turbo.  SkImageDecoder_libjpeg still uses
libjpeg on Android and the Android framework.  SkJpegCodec is
still not compiled on the Android framework.

BUG=skia:

Review URL: https://codereview.chromium.org/1275773004
 2015-08-11 13:32:54 -07:00
djsollen
3a26fc8e9a Ensure that android "release" apps are signed with debug key 
Review URL: https://codereview.chromium.org/1275223003
 2015-08-10 08:58:04 -07:00
djsollen
5119ac069e Update Android Testing apps to support release mode 
BUG=skia:4152

Review URL: https://codereview.chromium.org/1259123003
 2015-07-31 10:25:17 -07:00
bungeman
15bde1697a Fix repeat builds with Android. 
Currently the SampleApp and VisualBench builds for Android don't work
for rebuilds. The code is re-built, but the apks are not. This
results from the use of a directory as 'output' and the action to
build the apk not depending on the copied libraries.

Review URL: https://codereview.chromium.org/1270643005
 2015-07-31 06:33:21 -07:00
borenet
850bbf1bb6 Add android_run_app.go 
Launches an app, pipes its output, and exits when the app exits.

Loosely based on the old buildbot code in python:
https://skia.googlesource.com/buildbot/+/ac0663c599a443a4958c8cad5aefd25eb09eff58/slave/skia_slave_scripts/utils/android_utils.py

BUG=skia:4093

Review URL: https://codereview.chromium.org/1256353002
 2015-07-31 04:13:38 -07:00
borenet
b2c07364a3 Fix android_launch_app after Gradle change 
NOTRY=true
TBR=djsollen
BUG=skia:

Review URL: https://codereview.chromium.org/1258253002
 2015-07-28 06:00:36 -07:00
borenet
5f4dc38325 android_install_app: Use lower-cased app name 
NOTRY=true
BUG=skia:

Review URL: https://codereview.chromium.org/1261873002
 2015-07-28 05:13:41 -07:00
Brian Salomon
4239fc2f69 Remove skia_arch_width, fold into skia_arch_type. 
DOCS_PREVIEW= https://skia.org/?cl=1228553010

BUG=skia:4042
R=borenet@google.com, mtklein@google.com

Review URL: https://codereview.chromium.org/1228553010
 2015-07-27 09:10:36 -04:00
djsollen
d18b861061 Update Android Apps to use gradle 
This CL replaces ant with gradle for the task of building APKs.
The primary driver of this change is that it now allow us to
develop and test our apps using Android Studio.
DOCS_PREVIEW= https://skia.org/?cl=1215023017

Committed: https://skia.googlesource.com/skia/+/425535f1626932e4e22f61a2571f9c3c2b1c5977

Review URL: https://codereview.chromium.org/1215023017
 2015-07-24 13:15:59 -07:00
joshualitt
9efef7b56f Revert "Update Android Apps to use gradle" 
This reverts commit 425535f162.

NOTRY=true
NOTREECHECKS=true
TBR=djsollen@google.com
BUG=skia:
DOCS_PREVIEW= https://skia.org/?cl=1250233002

Review URL: https://codereview.chromium.org/1250233002
 2015-07-23 08:00:33 -07:00
djsollen
425535f162 Update Android Apps to use gradle 
This CL replaces ant with gradle for the task of building APKs.
The primary driver of this change is that it now allow us to
develop and test our apps using Android Studio.
DOCS_PREVIEW= https://skia.org/?cl=1215023017

Review URL: https://codereview.chromium.org/1215023017
 2015-07-22 11:33:25 -07:00
msarett
cf2a6a47e4 Reenable yasm for Android x86 and x86-64 on Linux host 
It turns out that gyp (kind of) has support for cross
compiling with a different host and target.  We simply
need to specify CC_host and CC_target instead of CC.

Making this change allows us to compile yasm on a Linux
host for Android.

We run into problems on Mac because
the linker on a Mac host requires different command line
arguments than the linker on the Android target.  In
looking through the code for gyp itself and speaking to
Ben, it doesn't appear to me that gyp supports passing
different arguments to host and target linkers.

I would imagine that we would have similar problems on
Windows.

Below is a link to a CL that would fix this issue in gyp.
It looks like it has been dropped for a long time.
Thanks to Ben for this link!
https://chromiumcodereview.appspot.com/10795044/

Also I'm adding a link to the build instructions for Chrome
(thanks again Ben).  It looks like they only support
building for Android from Linux.
https://code.google.com/p/chromium/wiki/AndroidBuildInstructions

My next steps are:
1) Getting in touch with Torne or someone else with gyp to
see if people are aware of this issue or interested in
fixing it.
2) Deciding if skia should care about this issue.
3) Deciding if skia should work around this issue.

It'd be really great to hear your thoughts on (2) and (3).
My first thought is that we shouldn't care because, as
long as we always compile the production copy of skia for
Android on Linux, we will get the fast code.  Is this
a valid conclusion?  Is there a way to write Android apps
on Mac that accidentally use the slower code?

If we do care, there are workarounds:
For Mac, we can check in a yasm binary - it's a little
smaller than the one I am deleting in this CL :-/
For Windows, we *might* be able to use the yasm.exe binary
already in externals (we get this from DEPS because this is
how chromium uses yasm on Windows).
Are there other platforms that we care about?

Let me know what you think!

BUG=skia:4028
DOCS_PREVIEW= https://skia.org/?cl=1239333002

Review URL: https://codereview.chromium.org/1239333002
 2015-07-21 12:01:48 -07:00
joshualitt
dcd56e2f0e Fix for android command line arguments to VisualBench 
BUG=skia:

Review URL: https://codereview.chromium.org/1241923002
 2015-07-15 10:17:21 -07:00
scroggo
33d35263bf Move android_gdb_tmp into out/ 
This way it will be ignored.

Review URL: https://codereview.chromium.org/1230773003
 2015-07-10 11:05:10 -07:00
scroggo
139491fbaa Use the upstream version of libwebp, v0.4.3. 
DEPS:
Update to pull v0.4.3 of libwebp from upstream

gyp/libwebp.gyp:
Add new files, as referenced by the gyp file used by Chromium.

resource/tests:
Add regression tests for particular images.

BUG=skia:3442
BUG=skia:3315
BUG=skia:3429

Committed: https://skia.googlesource.com/skia/+/3aa0fb4d80c76b559ff4b82d5e569993aea06da1

Review URL: https://codereview.chromium.org/1178013008
 2015-07-10 09:32:09 -07:00
djsollen
8de81806db Add gradle wrappers for Android app builds 
These wrappers are approxiately 56K in size and are the recommened
way to use Gradle.  It also ensures that developers wanting to
build the app don't need install an additional dependency.

Review URL: https://codereview.chromium.org/1227723002
 2015-07-08 10:50:42 -07:00
joshualitt
91b6f32e07 Move visualbench to its own folder 
BUG=skia:

Review URL: https://codereview.chromium.org/1216973002
 2015-06-30 06:50:10 -07:00
djsollen
4e7956147d Android scripts now notify gyp that your building with clang 
Review URL: https://codereview.chromium.org/1217443004
 2015-06-26 11:03:56 -07:00
joshualitt
fef3fad272 fix spurious init on VisualBench startup 
BUG=skia:

Review URL: https://codereview.chromium.org/1202023002
 2015-06-22 10:44:46 -07:00
joshualitt
01f38915e1 Fixup android launch script to launch VisualBench as well as SampleApp 
BUG=skia:

Review URL: https://codereview.chromium.org/1185473003
 2015-06-22 05:39:32 -07:00
joshualitt
b7134b64c6 Fix for assert in VisualBench 
BUG=skia:

Review URL: https://codereview.chromium.org/1198433004
 2015-06-19 12:46:33 -07:00
joshualitt
74953c388c Modify android_install_app to install VisualBench 
BUG=skia:

Review URL: https://codereview.chromium.org/1181973008
 2015-06-18 13:08:26 -07:00
msarett
b3ec76b34f Update android perf script 
BUG=skia:

Review URL: https://codereview.chromium.org/1185293006
 2015-06-18 06:29:48 -07:00
joshualitt
030dc847dc Visual bench on native android 
BUG=skia:

Review URL: https://codereview.chromium.org/1164403002
 2015-06-12 12:51:44 -07:00
djsollen
f793cd0913 Print command to be executed in verbose mode 
Review URL: https://codereview.chromium.org/1180163002
 2015-06-12 10:50:53 -07:00
msarett
78d79cc575 Eliminate the check for ANDROID_LARGE_MEMORY in jpeg decoders 
BUG=skia:1282

Review URL: https://codereview.chromium.org/1103313002
 2015-06-11 10:13:03 -07:00
Derek Sollenberger
de50d9b942 fix broken build by not passing the verbose flag through 
Review URL: https://codereview.chromium.org/1176543004
 2015-06-10 15:58:48 -04:00
djsollen
46409de6ab Remove verbose bash logging 
Review URL: https://codereview.chromium.org/1170283004
 2015-06-10 12:37:56 -07:00
joshualitt
cf94c74fef Add android native_app_glue to platform_tools/android/third_party 
BUG=skia:

Review URL: https://codereview.chromium.org/1175673002
 2015-06-09 12:33:13 -07:00
djsollen
fe79007a13 Update how we package skia resource for android testing 
Review URL: https://codereview.chromium.org/1119283004
 2015-06-05 09:39:30 -07:00
borenet
5aa5ea3831 Add adb_wait_for_device script 
BUG=skia:3718

Review URL: https://codereview.chromium.org/1149163003
 2015-06-02 12:38:16 -07:00
stephana
c9b8276bc9 BUG=skia: 
NOTRY=true
TBR=borenet

Review URL: https://codereview.chromium.org/1153783003
 2015-05-22 10:55:33 -07:00
stephana
c13a7738fb Unmount before app-install 
TBR=borenet

NOTRY=true
BUG=skia:

Review URL: https://codereview.chromium.org/1145093005
 2015-05-20 07:31:32 -07:00
stephana
9b4b91f5c2 This allows to restart the device. 
BUG=skia:
TBR=borenet

Review URL: https://codereview.chromium.org/1137873007
 2015-05-19 06:27:09 -07:00
stephana
4f2dba625d Making mount more robust 
BUG=skia:
TBR=borenet

Review URL: https://codereview.chromium.org/1131933007
 2015-05-18 13:50:05 -07:00
borenet
7ae68a8f8d Android scripts: add --verbose, fix missing 'source android_setup' 
BUG=skia:3836
TBR=djsollen

Review URL: https://codereview.chromium.org/1145473002
 2015-05-14 06:37:23 -07:00
Derek Sollenberger
7c722197b3 Add android_launch_app script to allow command line options to be passed to the sampleApp when starting. 
BUG=skia:3815
DOCS_PREVIEW= https://skia.org/?cl=1136753003
R=bungeman@google.com, tomhudson@google.com

Review URL: https://codereview.chromium.org/1136753003
 2015-05-11 08:54:19 -04:00
bungeman
4a8d622e1d Add default resourcePath to SampleApp on Android. 
Currently SampleApp on Android cannot find resources. This sets the
resourcePath to /data/local/tmp/skia/resources/ which is the path
used in documentationo. A future change will allow this default to be
overridden.

BUG=skia:3815

Review URL: https://codereview.chromium.org/1125363004
 2015-05-07 10:57:02 -07:00
stephana
deee2980f4 cleanup 
BUG=skia:

Review URL: https://codereview.chromium.org/1085583006
 2015-05-05 07:55:06 -07:00
borenet
f15132fdcf Support SKIA_OUT on Mac and ChromeOS 
BUG=skia:3774

Review URL: https://codereview.chromium.org/1122593003
 2015-05-04 08:04:28 -07:00
msarett
a3a8eb6f63 Make Skia for Android libjpeg use ashmem 
BUG=skia:1282

Review URL: https://codereview.chromium.org/1108013002
 2015-04-27 10:57:22 -07:00
mtklein
5ae0e2b563 Default to arm_v7_neon. 
This aliases all devices we know have NEON over to that too.

BUG=skia:

Review URL: https://codereview.chromium.org/1095953007
 2015-04-21 14:25:34 -07:00
mtklein
d8afd50b5a Android's Clang toolchain can't assemble the JPEG's .S files. 
Only affecting Build-Mac10.8-Clang-Arm7-Debug-Android.

BUG=skia:

Review URL: https://codereview.chromium.org/1093423003
 2015-04-21 12:07:38 -07:00
stephana
cdec56e72b Landing directly for testing the ios buildbot code. 
BUG=skia:
TBR=borenet

Review URL: https://codereview.chromium.org/1087653005
 2015-04-21 08:31:59 -07:00
Derek Sollenberger
a0219f1565 Fail gracefully when dm.json is not present 
Review URL: https://codereview.chromium.org/1073593002
 2015-04-08 15:20:25 -04:00
mtklein
ac813d8a12 Try ARMv7 and NEON for Daisy. 
I think Daisy's color order problems are in non-NEON ARM assembly.
NEON might actually be fine.

BUG=skia:1843

Committed: https://skia.googlesource.com/skia/+/a121c0ee6b911dd7004c6054a8692d37084b6b3d

CQ_EXTRA_TRYBOTS=client.skia.compile:Build-Ubuntu-GCC-Arm7-Debug-CrOS_Daisy-Trybot,Build-Ubuntu-GCC-Arm7-Debug-Android_Neon-Trybot,Build-Ubuntu-GCC-Arm7-Debug-Android-Trybot,Build-Ubuntu-GCC-Arm64-Debug-Android-Trybot

Review URL: https://codereview.chromium.org/1054233002
 2015-04-03 08:27:37 -07:00
mtklein
fb806dd27d Revert of Try ARMv7 and NEON for Daisy. (patchset #1 id:1 of https://codereview.chromium.org/1054233002/) 
Reason for revert:
whatever compiler we're using can't handle array subscripts for neon vectors

Original issue's description:
> Try ARMv7 and NEON for Daisy.
>
> I think Daisy's color order problems are in non-NEON ARM assembly.
> NEON might actually be fine.
>
> BUG=skia:1843
>
> Committed: https://skia.googlesource.com/skia/+/a121c0ee6b911dd7004c6054a8692d37084b6b3d

TBR=mtklein@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:1843

Review URL: https://codereview.chromium.org/1058173002
 2015-04-02 15:41:25 -07:00
Mike Klein
a121c0ee6b Try ARMv7 and NEON for Daisy. 
I think Daisy's color order problems are in non-NEON ARM assembly.
NEON might actually be fine.

BUG=skia:1843

Review URL: https://codereview.chromium.org/1054233002
 2015-04-02 18:32:54 -04:00
Mike Klein
a41699271f back to plain arm for the night 
It's looking like the previous CL did not fix the Daisy bot GMs,
even though that's still the only bit of code I can find that was
ignoring color order.  Puzzled.  Reverting arm_version=7 for now.

BUG=skia:1843

Review URL: https://codereview.chromium.org/1051423002
 2015-04-02 17:35:25 -04:00
borenet
4808757d7a Remove all code related to NaCl 
BUG=skia:3600
DOCS_PREVIEW= https://skia.org/?cl=1036283002

Review URL: https://codereview.chromium.org/1036283002
 2015-04-02 12:16:36 -07:00
mtklein
2d33a1d0b0 Streamline Thumb config. 
Enable Thumb2 iff ARM v7.  (We don't turn it on today for ARM <v7, and ARM v8 doesn't support it.)

BUG=skia:

Review URL: https://codereview.chromium.org/1054993002
 2015-04-02 10:47:57 -07:00
mtklein
83c6459228 Make Daisy ARMv7. 
This should be a ~noop as far as gold.skia.org goes.
After this, I'll try out NEON.

BUG=skia:1843

Review URL: https://codereview.chromium.org/1056793004
 2015-04-02 10:24:23 -07:00
mtklein
cb49c07b73 tidy up chromeos_setup.sh 
- remove unused alex
- streamline Link's config
- remove misleading Daisy config:
  1) armv7=1 does nothing.  We meant to type arm_version=7 here.
  2) arm_neon=1 does nothing unless arm_version == 7.
  3) arm_thumb=0 is the default when arm_version <= 7.
  4) skia_arch_width=32 is the default when skia_arch_type=arm.

I'd just fix this to make Daisy arm_version=7 and arm_neon=1 (and
arm_thumb=1, which I'm going to separately make the default for
arm_version=7), but there are known color-order bugs with our
NEON procs that would make Daisy start pushing bad images to
Gold.  Going to take baby steps here...

BUG=skia:1843

Committed: https://skia.googlesource.com/skia/+/3c2809bc612f4a265770914f860d214c9665dc4a

CQ_EXTRA_TRYBOTS=client.skia.compile:Build-Ubuntu-GCC-Arm7-Debug-CrOS_Daisy-Trybot

Review URL: https://codereview.chromium.org/1051253002
 2015-04-02 09:27:57 -07:00
mtklein
192945e92e Revert of tidy up chromeos_setup.sh (patchset #1 id:1 of https://codereview.chromium.org/1051253002/) 
Reason for revert:
arm_thumb not defined

Original issue's description:
> tidy up chromeos_setup.sh
>
> - remove unused alex
> - streamline Link's config
> - remove misleading Daisy config:
>   1) armv7=1 does nothing.  We meant to type arm_version=7 here.
>   2) arm_neon=1 does nothing unless arm_version == 7.
>   3) arm_thumb=0 is the default when arm_version <= 7.
>   4) skia_arch_width=32 is the default when skia_arch_type=arm.
>
> I'd just fix this to make Daisy arm_version=7 and arm_neon=1 (and
> arm_thumb=1, which I'm going to separately make the default for
> arm_version=7), but there are known color-order bugs with our
> NEON procs that would make Daisy start pushing bad images to
> Gold.  Going to take baby steps here...
>
> BUG=skia:1843
>
> Committed: https://skia.googlesource.com/skia/+/3c2809bc612f4a265770914f860d214c9665dc4a

TBR=borenet@google.com,mtklein@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:1843

Review URL: https://codereview.chromium.org/1059443002
 2015-04-02 09:02:12 -07:00