Commit Graph

47935 Commits

Author SHA1 Message Date
Ethan Nicholas
5a9e7fba1e Prefixed the names of SkSL token constants.
This is to avoid conflicts with macros defined by Windows include files.
We were previously #undefing these macros, but that ended up causing its
own problems.

Change-Id: Ib16dd93bd5dbdb4ffd87d560c21c5b344bf67a9d
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/284277
Commit-Queue: Greg Daniel <egdaniel@google.com>
Reviewed-by: Greg Daniel <egdaniel@google.com>
2020-04-21 17:39:34 +00:00
Kevin Lubick
67c905ce6b Fixing a bug in SkOpEdgeBuilder::walk that causes pathOps to fail when cubic segment is reducable
Inside SkOpEdgeBuilder::walk(), when current segment is cubic curve, its shape may be reduced, therefore, the curve points should be determined by the reduction result ‘split->fVerb’ instead of ‘verb’.

Actually, inside this switch case, ‘verb’ is always ‘SkPath::kCubic_Verb’, which makes the ‘fCanAdd’ always true. The outcome of this bug makes the subsequent logic which depends on ‘fCanAdd’ (L301-332) incorrect, and in some cases, fails the whole boolean operation at L329.

The Fiddle below demonstrates how this bug fails a union operation of two paths, by returning an empty path.
https://fiddle.skia.org/c/e528567b62bc338cd99f4a89f0c5342e

Screen shot of the fiddle:
https://www.dropbox.com/s/4bnzlponq6gen27/pathOpsBug.png?dl=0

2nd Fiddle drawing the results (larger)
https://fiddle.skia.org/c/1f2a513c2ee0395b9d05fb1eb987b01f

Change-Id: If07f54cef1b9409f9b6db27d6294a3e3461b0181
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/284426
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Commit-Queue: Mike Reed <reed@google.com>
Reviewed-by: Mike Reed <reed@google.com>
Reviewed-by: Kevin Lubick <kjlubick@google.com>
2020-04-21 16:56:54 +00:00
Brian Salomon
777f239a65 Revert "Notify RTC when OpsTask is closed so it can drop ownership"
This reverts commit 198393b2de.

Reason for revert: android crash

Original change's description:
> Notify RTC when OpsTask is closed so it can drop ownership
> 
> Change-Id: I95d32ed89447995541f33bf80730876ce9c0747a
> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/284519
> Reviewed-by: Greg Daniel <egdaniel@google.com>
> Commit-Queue: Brian Salomon <bsalomon@google.com>

TBR=egdaniel@google.com,bsalomon@google.com,robertphillips@google.com

Change-Id: I5133fa1b8f90182864ffbee3b60bfd5781dc16bd
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/284728
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
2020-04-21 16:38:21 +00:00
Brian Osman
efb2133b0d Update CK particle examples
Change-Id: I5e2ee549654e105b00f8a8770c211c464c97e6c8
Docs-Preview: https://skia.org/?cl=284726
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/284726
Reviewed-by: Kevin Lubick <kjlubick@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
2020-04-21 15:48:04 +00:00
Brian Salomon
198393b2de Notify RTC when OpsTask is closed so it can drop ownership
Change-Id: I95d32ed89447995541f33bf80730876ce9c0747a
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/284519
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
2020-04-21 15:38:54 +00:00
Greg Daniel
690a450cdc Create a shared spirv uniform and varying handling class.
This moves the dawn spirv implementation of these classes into a shared
class that will be used by d3d backend. We can look into further extending
the class to see if it can be shared with vulkan as well.

Change-Id: I138d403dd55053f534d0c97a55c0fa5d2c5171f0
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/284525
Reviewed-by: Jim Van Verth <jvanverth@google.com>
Commit-Queue: Greg Daniel <egdaniel@google.com>
2020-04-21 15:25:14 +00:00
Robert Phillips
d81379d5aa Add path renderer selection spew
Change-Id: If39963605dfa24cc14548e2abdd965ad55a1a561
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/284736
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>
2020-04-21 15:19:14 +00:00
Jim Van Verth
ba7f22954d Implement GrD3DGpu::onReadPixels and GrD3DGpu::onWritePixels.
* Add resource copy routines to command list
* Be sure to release resources from command list

Change-Id: I174c5a026d5e2289e6db56215b0d140c19ccf39e
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/284156
Commit-Queue: Jim Van Verth <jvanverth@google.com>
Reviewed-by: Greg Daniel <egdaniel@google.com>
2020-04-21 15:05:34 +00:00
Lepton Wu
1ba00c7121 Allow empty rendertests commandline flags.
When it's empty, just use default rendertests file.

Bug: skia:10156
Change-Id: I406d381570bbd6b348e6364d649d39af5817a56e
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/284523
Reviewed-by: Tyler Denniston <tdenniston@google.com>
Commit-Queue: Tyler Denniston <tdenniston@google.com>
Auto-Submit: Lepton Wu <lepton@chromium.org>
2020-04-21 14:52:54 +00:00
Lepton Wu
e59f718fc2 SkQP: Fix document about running as native executable
Bug: skia:10156
Change-Id: Ic0d89ef4bf01ccadb23a5d123c578dc772bc945a
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/284522
Reviewed-by: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Tyler Denniston <tdenniston@google.com>
Commit-Queue: Tyler Denniston <tdenniston@google.com>
Auto-Submit: Lepton Wu <lepton@chromium.org>
2020-04-21 14:48:54 +00:00
Florin Malita
24ea293cd2 [skottie] Suppress ubsan div-by-zero VenetialBlindsAdapter crash
It's fine to allow -/+ inf because we immediately clamp to 0/1.

Fixed: oss-fuzz:15927
Change-Id: Ic9c866e78c9b79ea2055d2dbf403c26b29031622
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/284481
Reviewed-by: Kevin Lubick <kjlubick@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Auto-Submit: Florin Malita <fmalita@chromium.org>
2020-04-21 11:15:15 +00:00
skia-recreate-skps
607a489345 Update Go Deps
Change-Id: I5db9c1b9fca817565817e842769b733823bd69e7
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/284636
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
2020-04-21 05:32:13 +00:00
skia-autoroll
0a618bf20b Roll third_party/externals/dawn 99655bcf85ca..be08000cb52e (9 commits)
https://dawn.googlesource.com/dawn.git/+log/99655bcf85ca..be08000cb52e

git log 99655bcf85ca..be08000cb52e --date=short --first-parent --format='%ad %ae %s'
2020-04-21 rharrison@chromium.org Roll third_party/shaderc/ a10a0b334..ced9c72d0 (2 commits)
2020-04-21 jiawei.shao@intel.com Validate texture usage scope with storage textures in one render pass
2020-04-21 jiawei.shao@intel.com Allow using write-only storage textures in fragment shader stage
2020-04-20 enga@chromium.org Reland "Add ComparisonSampler binding type and validation tests"
2020-04-20 rafael.cintron@microsoft.com Move and improve RefCounted
2020-04-20 cwallez@chromium.org Revert "Add ComparisonSampler binding type and validation tests"
2020-04-20 rharrison@chromium.org Rolling 3 dependencies
2020-04-20 cwallez@chromium.org Revert "Special-case GetDefaultQueue in the wire"
2020-04-20 cwallez@chromium.org Deprecate BGLEntry::textureDimension in favor of viewDimension

Also rolling transitive DEPS:
  https://chromium.googlesource.com/chromium/src/third_party/jinja2 b41863e42637..b41863e42637
  https://chromium.googlesource.com/chromium/src/third_party/markupsafe 8f45f5cfa000..8f45f5cfa000
  https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang 4d2298bfd78a..3f4e5c456306
  https://chromium.googlesource.com/external/github.com/google/shaderc 1926de0638b6..ced9c72d005e

Created with:
  gclient setdep -r third_party/externals/dawn@be08000cb52e

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dawn-skia-autoroll
Please CC cwallez@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: cwallez@google.com
Change-Id: I924eb169cf029290879ea4dff3f259977a017e58
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/284556
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2020-04-21 04:47:35 +00:00
skia-autoroll
1ce5497756 Roll third_party/externals/angle2 33b58ebb7ea8..8f48ba9f256f (14 commits)
33b58ebb7e..8f48ba9f25

git log 33b58ebb7ea8..8f48ba9f256f --date=short --first-parent --format='%ad %ae %s'
2020-04-21 cnorthrop@google.com Capture/Replay: Use TexStorage for immutable images
2020-04-20 tobine@google.com Vulkan: Suppress VUID-vkCmdClearColorImage-image-01993
2020-04-20 cclao@google.com Vulkan: Use DontCare for the presentable surface's last renderpass depth/stencil storeOp
2020-04-20 tobine@google.com doc: Update ANGLE Try Waterfall links
2020-04-20 cclao@google.com Vulkan: Use renderpass' finalLayout to transit to ImageLayout::Present
2020-04-20 timvp@google.com Vulkan: Suppress VUID-vkCmdCopyImageToBuffer-srcImage-01998
2020-04-20 timvp@google.com Add cclao@ and timvp@ to watch for vulkan CLs
2020-04-20 geofflang@google.com GL: Re-enable emulatePrimitiveRestartFixedIndex
2020-04-20 ianelliott@google.com Vulkan: glDrawElements used old offset into index buffer
2020-04-20 lexa.knyazev@gmail.com Add PackedEnums for blend state parameters
2020-04-20 jmadill@chromium.org Vulkan: Store ImageType in ImageHelper.
2020-04-20 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/vulkan-tools/src 454ab259c1b8..8824107d57d3 (1 commits)
2020-04-20 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/SwiftShader d25ce8725224..068611f07d28 (8 commits)
2020-04-20 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/glslang/src 4d2298bfd78a..3f4e5c456306 (2 commits)

Created with:
  gclient setdep -r third_party/externals/angle2@8f48ba9f256f

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-skia-autoroll
Please CC jcgregorio@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: skia/skia.primary:Build-Debian10-Clang-x86_64-Release-ANGLE;skia/skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-Golo-GPU-QuadroP400-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC8i5BEK-GPU-IntelIris655-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE
Bug: None
Tbr: jcgregorio@google.com
Change-Id: Ibfc826c06f2737f82b186e198e75be52369ce092
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/284558
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2020-04-21 04:46:16 +00:00
skia-autoroll
9d4b3185a2 Roll third_party/externals/swiftshader 068611f07d28..ff772a7bcc98 (1 commits)
https://swiftshader.googlesource.com/SwiftShader.git/+log/068611f07d28..ff772a7bcc98

git log 068611f07d28..ff772a7bcc98 --date=short --first-parent --format='%ad %ae %s'
2020-04-20 capn@google.com Don't use deprecated llvm::Type::getVectorNumElements()

Created with:
  gclient setdep -r third_party/externals/swiftshader@ff772a7bcc98

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-skia-autoroll
Please CC jcgregorio@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: skia/skia.primary:Test-Debian10-Clang-GCE-GPU-SwiftShader-x86_64-Debug-All-SwiftShader
Bug: None
Tbr: jcgregorio@google.com
Change-Id: I1590c2c41288c490d5d0a83f46588d0cd8780e4e
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/284557
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2020-04-21 04:40:46 +00:00
skia-autoroll
f1c5c8788e Roll ../src 290e9f6d58db..91a975d4e6e0 (433 commits)
290e9f6d58..91a975d4e6


Created with:
  gclient setdep -r ../src@91a975d4e6

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-skia-autoroll
Please CC jcgregorio@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: skia/skia.primary:Perf-Mac10.13-Clang-MacBookPro11.5-GPU-RadeonHD8870M-x86_64-Release-All-CommandBuffer;skia/skia.primary:Test-Mac10.13-Clang-MacBookPro11.5-GPU-RadeonHD8870M-x86_64-Debug-All-CommandBuffer
Bug: None
Tbr: jcgregorio@google.com
Change-Id: I641e8b984629ac09ca3b682de772f4076fd6e22d
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/284555
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2020-04-21 04:35:07 +00:00
Michael Ludwig
76312fbf97 Add conservative round rect intersect function
Change-Id: I1012a4b6c6eb67e01923f767baeb78ebc18a0fd5
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/284477
Commit-Queue: Michael Ludwig <michaelludwig@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
2020-04-20 22:53:16 +00:00
Mike Klein
57ed6b8f12 remove LabelAndReg
The .reg part of this struct is unused (since removing
some of those old complex instructions).

Change-Id: I35a8344286e22d4acac4707d31eaf3794ae2fae4
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/284547
Reviewed-by: Herb Derby <herb@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
2020-04-20 21:54:16 +00:00
Mike Reed
7d45a7ac9c rm unneeded SK_SUPPORT_LEGACY_DIDCONCAT44
Change-Id: I65cec59749f0e7f5fb13675293720afecffa6a80
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/284321
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Mike Reed <reed@google.com>
2020-04-20 20:44:35 +00:00
Mike Klein
21e85eb549 Reland "Reland "gather8/16 JIT support""
This is a reland of 1283d55f35

... this time, also checking for HSW feature set.

Original change's description:
> Reland "gather8/16 JIT support"
>
> This is a reland of 54659e51bc
>
> ... now expecting not to JIT when under ASAN/MSAN.
>
> Original change's description:
> > gather8/16 JIT support
> >
> > The basic strategy is one at a time, inserting 8- or 16-bit values
> > into an Xmm register, then expanding to 32-bit in a Ymm at the end
> > using vpmovzx{b,w}d instructions.
> >
> > Somewhat annoyingly we can only pull indices from an Xmm register,
> > so we grab the first four then shift down the top before the rest.
> >
> > Added a unit test to get coverage where the indices are reused and
> > not consumed directly by the gather instruction.  It's an important
> > case, needing to find another register for accum that can't just be
> > dst(), but there's no natural coverage of that anywhere.
> >
> > Change-Id: I8189ead2364060f10537a2f9364d63338a7e596f
> > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/284311
> > Reviewed-by: Herb Derby <herb@google.com>
> > Commit-Queue: Mike Klein <mtklein@google.com>
>
> Change-Id: I67f441615b312b47e7a3182e85e0f787286d7717
> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/284472
> Reviewed-by: Herb Derby <herb@google.com>
> Commit-Queue: Mike Klein <mtklein@google.com>

Change-Id: Id0e53ab67f7a70fe42dccca1d9912b07ec11b54d
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/284504
Reviewed-by: Herb Derby <herb@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
2020-04-20 20:25:06 +00:00
Mike Reed
1174cf82f3 add gm to test pathops bug
Bug: skia:10155
Change-Id: I1e7eb28eb7ea641794adab869d1bca537bdfa30b
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/284516
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Mike Reed <reed@google.com>
2020-04-20 18:31:51 +00:00
Mike Klein
7d5342d9ac Revert "Reland "gather8/16 JIT support""
This reverts commit 1283d55f35.

Reason for revert: one more try...

Original change's description:
> Reland "gather8/16 JIT support"
> 
> This is a reland of 54659e51bc
> 
> ... now expecting not to JIT when under ASAN/MSAN.
> 
> Original change's description:
> > gather8/16 JIT support
> >
> > The basic strategy is one at a time, inserting 8- or 16-bit values
> > into an Xmm register, then expanding to 32-bit in a Ymm at the end
> > using vpmovzx{b,w}d instructions.
> >
> > Somewhat annoyingly we can only pull indices from an Xmm register,
> > so we grab the first four then shift down the top before the rest.
> >
> > Added a unit test to get coverage where the indices are reused and
> > not consumed directly by the gather instruction.  It's an important
> > case, needing to find another register for accum that can't just be
> > dst(), but there's no natural coverage of that anywhere.
> >
> > Change-Id: I8189ead2364060f10537a2f9364d63338a7e596f
> > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/284311
> > Reviewed-by: Herb Derby <herb@google.com>
> > Commit-Queue: Mike Klein <mtklein@google.com>
> 
> Change-Id: I67f441615b312b47e7a3182e85e0f787286d7717
> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/284472
> Reviewed-by: Herb Derby <herb@google.com>
> Commit-Queue: Mike Klein <mtklein@google.com>

TBR=mtklein@google.com,herb@google.com

Change-Id: I953fcd2aef308fd901880618fa540ac9f6d88e84
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/284503
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
2020-04-20 17:05:52 +00:00
Mike Klein
1283d55f35 Reland "gather8/16 JIT support"
This is a reland of 54659e51bc

... now expecting not to JIT when under ASAN/MSAN.

Original change's description:
> gather8/16 JIT support
>
> The basic strategy is one at a time, inserting 8- or 16-bit values
> into an Xmm register, then expanding to 32-bit in a Ymm at the end
> using vpmovzx{b,w}d instructions.
>
> Somewhat annoyingly we can only pull indices from an Xmm register,
> so we grab the first four then shift down the top before the rest.
>
> Added a unit test to get coverage where the indices are reused and
> not consumed directly by the gather instruction.  It's an important
> case, needing to find another register for accum that can't just be
> dst(), but there's no natural coverage of that anywhere.
>
> Change-Id: I8189ead2364060f10537a2f9364d63338a7e596f
> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/284311
> Reviewed-by: Herb Derby <herb@google.com>
> Commit-Queue: Mike Klein <mtklein@google.com>

Change-Id: I67f441615b312b47e7a3182e85e0f787286d7717
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/284472
Reviewed-by: Herb Derby <herb@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
2020-04-20 16:47:04 +00:00
Tyler Denniston
df1b014005 [svg] Reapply currentColor to fill/stroke
For the scenario in color-prop-05-t:
  <g fill="currentColor" color="lime">
    <rect x="120" y="60" width="150" height="150" color="red"/>
  </g>
(rectangle should be rendered red according to CSS spec)

The sequence of events is:
  <g>
    - fInherited.fColor = lime
    - fInherited.fFill = kCurrentColor
    - commit fFill to paint (paint.setColor(lime))
    <rect>
      - fInherited.fColor = red
      - BUG: fFill not re-committed to paint because it is 'inherit'

This CL fixes the bug by recommitting to the fill and stroke paint
if the fill/stroke attribute values are currentColor.

Change-Id: Icecd498eb0122513e0241740536e239eed335ef3
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/284377
Reviewed-by: Florin Malita <fmalita@chromium.org>
Commit-Queue: Tyler Denniston <tdenniston@google.com>
2020-04-20 16:39:31 +00:00
Ben Wagner
b1acff60fb Roll testing expat to tip of tree.
We currently mirror Android's mirror, which is out of date and only
rolled to tagged revisions. Roll to Chromium's mirror which is actually
up to date.

Change-Id: I754dc58149526e0c820bd7bcff1693d2d851a084
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/282039
Reviewed-by: Derek Sollenberger <djsollen@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Ben Wagner <bungeman@google.com>
2020-04-20 16:14:11 +00:00
Jim Van Verth
9b5e16c09e Add capture routines for D3D
Bug: skia:9935
Change-Id: I8149a5c04be5be44f129a7d66656182cb2f5babb
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/284045
Commit-Queue: Jim Van Verth <jvanverth@google.com>
Reviewed-by: Greg Daniel <egdaniel@google.com>
2020-04-20 15:31:18 +00:00
Mike Klein
86975cd168 Revert "gather8/16 JIT support"
This reverts commit 54659e51bc.

Reason for revert: ASAN

Original change's description:
> gather8/16 JIT support
> 
> The basic strategy is one at a time, inserting 8- or 16-bit values
> into an Xmm register, then expanding to 32-bit in a Ymm at the end
> using vpmovzx{b,w}d instructions.
> 
> Somewhat annoyingly we can only pull indices from an Xmm register,
> so we grab the first four then shift down the top before the rest.
> 
> Added a unit test to get coverage where the indices are reused and
> not consumed directly by the gather instruction.  It's an important
> case, needing to find another register for accum that can't just be
> dst(), but there's no natural coverage of that anywhere.
> 
> Change-Id: I8189ead2364060f10537a2f9364d63338a7e596f
> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/284311
> Reviewed-by: Herb Derby <herb@google.com>
> Commit-Queue: Mike Klein <mtklein@google.com>

TBR=mtklein@google.com,herb@google.com

Change-Id: I912273e6ffc9258537ba806951a5964be0218d58
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/284471
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
2020-04-20 15:27:49 +00:00
Mike Klein
54659e51bc gather8/16 JIT support
The basic strategy is one at a time, inserting 8- or 16-bit values
into an Xmm register, then expanding to 32-bit in a Ymm at the end
using vpmovzx{b,w}d instructions.

Somewhat annoyingly we can only pull indices from an Xmm register,
so we grab the first four then shift down the top before the rest.

Added a unit test to get coverage where the indices are reused and
not consumed directly by the gather instruction.  It's an important
case, needing to find another register for accum that can't just be
dst(), but there's no natural coverage of that anywhere.

Change-Id: I8189ead2364060f10537a2f9364d63338a7e596f
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/284311
Reviewed-by: Herb Derby <herb@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
2020-04-20 15:19:37 +00:00
Robert Phillips
f95e2f42a8 Handle mipmap creation failure in DDL test harness
SkMipMap::Build fails surprisingly often. Fall back to unmipped promise images in that case.

The prior approach created the mipMaps too late (i.e., at backendTexture creation time) for the test harness to change its mind about the mip status of a promise image. This approach moves the mipmap creation earlier - to when the PromiseImageInfos are created (i.e., at SKP deflation time).

Change-Id: Id3c67a44cc84da7ee76d02f4d44d7f27ce8e39d6
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/284136
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>
2020-04-20 14:11:50 +00:00
Michael Ludwig
eaeb996253 Add inner bounds of round rect function
Change-Id: I6d48d4aebfffcf106ab22b511e43f76a4f8972c6
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/284276
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Michael Ludwig <michaelludwig@google.com>
2020-04-20 13:58:10 +00:00
Brian Osman
449b1157a7 Plumb SkMatrixProvider throughout Ganesh
Renames the provider to SkMatrixProvider, which is now also able to
provide the local-to-device matrix. Everywhere that does paint
conversion and FP generation now has access to the entire matrix
provider, instead of just the CTM.

This will allow the SkSL FP (and others) to fetch other matrix state.

Change-Id: Iffb00bae0d438da0e8de3eebe75183ed6d440fd6
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/284040
Reviewed-by: Brian Salomon <bsalomon@google.com>
Reviewed-by: Michael Ludwig <michaelludwig@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
2020-04-20 13:48:40 +00:00
skia-recreate-skps
5d440647d3 Update Go Deps
Change-Id: I929983744be414d2fcac1f136cafbb4dafd17660
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/284436
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
2020-04-20 05:38:17 +00:00
skia-autoroll
8835d41e50 Roll third_party/externals/swiftshader d25ce8725224..068611f07d28 (8 commits)
https://swiftshader.googlesource.com/SwiftShader.git/+log/d25ce8725224..068611f07d28

git log d25ce8725224..068611f07d28 --date=short --first-parent --format='%ad %ae %s'
2020-04-17 capn@google.com Fix JIT on separate thread
2020-04-17 bclayton@google.com Use Thread Safety Analysis annotations throughout SwiftShader.
2020-04-17 digit@google.com CMakeLists: Fix Fuchsia build.
2020-04-17 bclayton@google.com Merge changes Ia8226c11,If413b9d6
2020-04-17 bclayton@google.com LLVMReactor: Drop codegenMutex, now thread safe.
2020-04-17 bclayton@google.com LLVMJIT: Remove the TargetMachine cache.
2020-04-17 bclayton@google.com LLVM 7: Set LLVM_ENABLE_THREADS to 1
2020-04-17 bclayton@google.com SpirvShader: Fix ASSERT firing in debugger

Created with:
  gclient setdep -r third_party/externals/swiftshader@068611f07d28

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-skia-autoroll
Please CC jcgregorio@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: skia/skia.primary:Test-Debian10-Clang-GCE-GPU-SwiftShader-x86_64-Debug-All-SwiftShader
Bug: None
Tbr: jcgregorio@google.com
Change-Id: I2d3043abc2ccb367181a5a30b017c6baaf53bbac
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/284429
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2020-04-20 04:41:08 +00:00
skia-autoroll
21b18046bb Roll ../src 41c6b825e65f..290e9f6d58db (453 commits)
41c6b825e6..290e9f6d58


Created with:
  gclient setdep -r ../src@290e9f6d58

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-skia-autoroll
Please CC jcgregorio@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: skia/skia.primary:Perf-Mac10.13-Clang-MacBookPro11.5-GPU-RadeonHD8870M-x86_64-Release-All-CommandBuffer;skia/skia.primary:Test-Mac10.13-Clang-MacBookPro11.5-GPU-RadeonHD8870M-x86_64-Debug-All-CommandBuffer
Bug: None
Tbr: jcgregorio@google.com
Change-Id: Ib914ee017f5fd63db23b89a0955e8c03c5fc0fbe
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/284427
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2020-04-20 04:41:07 +00:00
skia-autoroll
2657867e1f Roll third_party/externals/dawn 53f694b34a8d..99655bcf85ca (11 commits)
https://dawn.googlesource.com/dawn.git/+log/53f694b34a8d..99655bcf85ca

git log 53f694b34a8d..99655bcf85ca --date=short --first-parent --format='%ad %ae %s'
2020-04-18 yunchao.he@intel.com Add validation tests for resource usage tracking - 3
2020-04-17 cwallez@chromium.org Use python3 for all of Dawn's python scripts
2020-04-17 enga@chromium.org Add ComparisonSampler binding type and validation tests
2020-04-17 enga@chromium.org Add default Undefined sampler compare function
2020-04-17 cwallez@chromium.org Special-case GetDefaultQueue in the wire
2020-04-17 cwallez@chromium.org Introduce Device::GetDefaultQueue and deprecate CreateQueue
2020-04-17 cwallez@chromium.org BUILD.gn: Remove leftover temporary test target.
2020-04-17 cwallez@chromium.org Rolling 2 dependencies
2020-04-17 cwallez@chromium.org Roll third_party/swiftshader/ 63ed0e445..d25ce8725 (48 commits)
2020-04-17 cwallez@chromium.org Vulkan: Use VK_LAYER_KHRONOS_validation
2020-04-17 cwallez@chromium.org Add the Vulkan loader as an optional dependency and use it on Mac

Also rolling transitive DEPS:
  https://chromium.googlesource.com/chromium/src/third_party/markupsafe 8f45f5cfa000..8f45f5cfa000
  https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang 4d2298bfd78a..4d2298bfd78a
  https://chromium.googlesource.com/external/github.com/google/shaderc 1926de0638b6..1926de0638b6
  https://chromium.googlesource.com/chromium/src/third_party/jinja2 b41863e42637..b41863e42637

Created with:
  gclient setdep -r third_party/externals/dawn@99655bcf85ca

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dawn-skia-autoroll
Please CC cwallez@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: cwallez@google.com
Change-Id: I34ceb5f3578c2cb10b9b56c7036516b075ad02d1
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/284428
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2020-04-20 04:34:48 +00:00
skia-recreate-skps
0c9327e48e Update SKP version
Automatic commit by the RecreateSKPs bot.

TBR=rmistry@google.com
NO_MERGE_BUILDS

Change-Id: I3abea4757b5eebc1879f2b65a7c1636c7e7c9884
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/284422
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
2020-04-19 08:28:19 +00:00
skia-recreate-skps
62687b1ec3 Update Go Deps
Change-Id: I4bfaab405f30878b43452beb0cdc3beab7209166
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/284417
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
2020-04-19 05:32:09 +00:00
skia-autoroll
ae28b321d0 Roll third_party/externals/angle2 49ad8eaae192..33b58ebb7ea8 (24 commits)
49ad8eaae1..33b58ebb7e

git log 49ad8eaae192..33b58ebb7ea8 --date=short --first-parent --format='%ad %ae %s'
2020-04-18 timvp@google.com Vulkan: Give unsized arrays at least 1 entry
2020-04-17 jmadill@chromium.org Minor angle_end2end_tests cleanups.
2020-04-17 lehoangq@gmail.com Separate GLES1's state enum switch code from GLES2+
2020-04-17 cclao@google.com Vulkan: store ImageLayout in PackedAttachmentOpsDesc
2020-04-17 geofflang@google.com Remove more bad files before rolling into AOSP.
2020-04-17 geofflang@chromium.org Accept b/ for bug IDs in ANGLE CLs.
2020-04-17 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/vulkan-loader/src 3682237cb326..50eaecd721a2 (1 commits)
2020-04-17 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/vulkan-headers/src e01f13e1f777..382bf3de06fc (1 commits)
2020-04-17 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/SwiftShader 2430d665d3f2..d25ce8725224 (18 commits)
2020-04-17 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/vulkan-tools/src 0d4857ea576a..454ab259c1b8 (1 commits)
2020-04-16 timvp@google.com Vulkan: Skip failing BlendIntegerTest tests
2020-04-16 jmadill@chromium.org Vulkan: Make staged clears store aspect mask.
2020-04-16 jmadill@chromium.org Vulkan: Forward RenderBuffer/Surface dirty messages.
2020-04-16 jmadill@chromium.org Pass binding enum to Framebuffer::syncState.
2020-04-16 geofflang@chromium.org Remove the merge command from roll_aosp.sh
2020-04-16 geofflang@chromium.org Remove some bad files when generating an ANGLE roll into Android
2020-04-16 jian.li@arm.com Vulkan: Fix transform feedback on AMD platform
2020-04-16 geofflang@chromium.org Remove --preserve-root from roll_aosp.sh
2020-04-16 geofflang@chromium.org Roll VulkanMemoryAllocator into Android
2020-04-16 tobine@google.com doc: Discuss manual roll in note on Vulkan-Headers repo
2020-04-16 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/vulkan-tools/src 1be434141625..0d4857ea576a (1 commits)
2020-04-16 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/SwiftShader 81e08df29531..2430d665d3f2 (4 commits)
2020-04-16 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/vulkan-loader/src 3f7e3cbf33a7..3682237cb326 (1 commits)
2020-04-16 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/spirv-tools/src c018fc6ae667..61b7de3c39f0 (2 commits)

Created with:
  gclient setdep -r third_party/externals/angle2@33b58ebb7ea8

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-skia-autoroll
Please CC kjlubick@google.com,brianosman@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: skia/skia.primary:Build-Debian10-Clang-x86_64-Release-ANGLE;skia/skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-Golo-GPU-QuadroP400-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC8i5BEK-GPU-IntelIris655-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE
Bug: None
Tbr: kjlubick@google.com,brianosman@google.com
Change-Id: Ib6d9ea78dd379e3cecebc2d5fda0a743221dc7b0
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/284405
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2020-04-18 18:40:40 +00:00
Mike Reed
6a59affb2a flutter is ready for m44
Change-Id: I4531aa35cb4282a88bece97690bc55ea81d3a531
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/284322
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Mike Reed <reed@google.com>
2020-04-18 16:07:00 +00:00
John Stiles
0ebc69c9ef Fix modulo-by-zero crash during SPIR-V conversion.
Array-stride calculation did not check for zero-sized objects before
performing a modulo. This would lead to undefined behavior (crash)
while attempting to build the AST.

Change-Id: I84b4662978955d49a3ca28f6bb577d15c87cccb6
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/284354
Auto-Submit: John Stiles <johnstiles@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
2020-04-18 13:41:40 +00:00
skia-recreate-skps
fb490911a9 Update Go Deps
Change-Id: Iad339dc417d8367e89203083464c847d7433baf0
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/284355
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
2020-04-18 05:33:19 +00:00
Jim Van Verth
c632aa6337 Flesh out more D3D command list and barrier code.
* Adds command queue sync
* Adds resource state transitioning

Bug: skia:9935
Change-Id: I891ef288fd2b3a1b24d649f0958f1eb83ddea532
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/284317
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Jim Van Verth <jvanverth@google.com>
2020-04-17 21:36:08 +00:00
Michael Ludwig
2686d69bf0 Reland "Rename GrShape to GrStyledShape"
This reverts commit 73b86c1ade.

Reason for revert: wasn't the problem, relanding

Original change's description:
> Revert "Rename GrShape to GrStyledShape"
> 
> This reverts commit f3f08af010.
> 
> Reason for revert: maybe this is breaking the ios perf bot; it is the first CL that caused the bot to fail, but I can't really say why this would break them.
> 
> Original change's description:
> > Rename GrShape to GrStyledShape
> > 
> > Change-Id: Ic457e634b4b95356f5615cff3fce1ca7d7677c26
> > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/284036
> > Reviewed-by: Robert Phillips <robertphillips@google.com>
> > Commit-Queue: Michael Ludwig <michaelludwig@google.com>
> 
> TBR=bsalomon@google.com,robertphillips@google.com,michaelludwig@google.com
> 
> # Not skipping CQ checks because original CL landed > 1 day ago.
> 
> Change-Id: I2e5adbfc820811fbbde9cb57af28f86a7ba40bd9
> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/284231
> Reviewed-by: Michael Ludwig <michaelludwig@google.com>
> Commit-Queue: Michael Ludwig <michaelludwig@google.com>

TBR=bsalomon@google.com,robertphillips@google.com,michaelludwig@google.com

Change-Id: Ifdd52f8bacb5d66a7bf58efd328675c4c443ac8a
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/284376
Reviewed-by: Michael Ludwig <michaelludwig@google.com>
Commit-Queue: Michael Ludwig <michaelludwig@google.com>
2020-04-17 20:24:53 +00:00
Michael Ludwig
a17d2d502a Reland "Respect wrap mode when decimating for blur"
This reverts commit 57dbcd1fb2.

Reason for revert: this wasn't the problem, relanding

Original change's description:
> Revert "Respect wrap mode when decimating for blur"
> 
> This reverts commit 0dca280047.
> 
> Reason for revert: maybe this is the cause of the iOS failures.
> 
> Original change's description:
> > Respect wrap mode when decimating for blur
> > 
> > It used to be the case that bilerp wasn't supported for shader-based
> > repeats and mirrors, but that is no longer the case. If we switched
> > to ClampToBorder in those cases, we could introduce transparent black
> > into the decimated image that would then infect the final blur.
> > 
> > Bug: skia:10145
> > Change-Id: Ie273b4d64f082be3ddbdbf54acf201ff1fdfa133
> > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/283940
> > Commit-Queue: Michael Ludwig <michaelludwig@google.com>
> > Reviewed-by: Brian Salomon <bsalomon@google.com>
> 
> TBR=bsalomon@google.com,michaelludwig@google.com
> 
> Change-Id: Id672e9ce4d5418db0d7e58fd15fa1c3b5c80e07a
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: skia:10145
> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/284278
> Reviewed-by: Michael Ludwig <michaelludwig@google.com>
> Commit-Queue: Michael Ludwig <michaelludwig@google.com>

TBR=bsalomon@google.com,michaelludwig@google.com

Change-Id: I7f603b80385e29a182572576e62351f1c2ab24b2
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: skia:10145
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/284319
Reviewed-by: Michael Ludwig <michaelludwig@google.com>
Commit-Queue: Michael Ludwig <michaelludwig@google.com>
2020-04-17 20:21:30 +00:00
Brian Salomon
b0aab2c7d1 Reland "Revert "Revert "GrDisplacementEffect uses GrTextureEffect."""
This is a reland of 16abfa5e42

Original change's description:
> Revert "Revert "GrDisplacementEffect uses GrTextureEffect.""
> 
> Also further limits the number of FP stages on ANGLE D3D9 to avoid
> varying limit.
> 
> This reverts commit 0b406736c1.
> 
> Bug: skia:10139
> 
> Change-Id: Ifda0b932ab8ce176f1a1cd1ca9c2deaf1fda20bd
> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/284048
> Reviewed-by: Michael Ludwig <michaelludwig@google.com>
> Commit-Queue: Brian Salomon <bsalomon@google.com>

Bug: skia:10139
Change-Id: I542506a87fadeeb54e2f749b199806d2155c6cab
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/284230
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
2020-04-17 20:19:48 +00:00
Florin Malita
e35a7ea7a9 [skottie] Initial inner shadow layer style support
Implement drop and inner shadow styles using explicit image filters.

Remove existing style support from DropShadowEffect.cpp, as it now
has a new cozy place with its inner sibling.

Supported properties:

  - color
  - opacity
  - angle
  - distance
  - size (sigma)

Change-Id: I5b7e3c75678e036a20c1908b84c74a670a5aa196
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/283918
Reviewed-by: Michael Ludwig <michaelludwig@google.com>
Commit-Queue: Florin Malita <fmalita@chromium.org>
2020-04-17 19:57:08 +00:00
Michael Ludwig
73b86c1ade Revert "Rename GrShape to GrStyledShape"
This reverts commit f3f08af010.

Reason for revert: maybe this is breaking the ios perf bot; it is the first CL that caused the bot to fail, but I can't really say why this would break them.

Original change's description:
> Rename GrShape to GrStyledShape
> 
> Change-Id: Ic457e634b4b95356f5615cff3fce1ca7d7677c26
> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/284036
> Reviewed-by: Robert Phillips <robertphillips@google.com>
> Commit-Queue: Michael Ludwig <michaelludwig@google.com>

TBR=bsalomon@google.com,robertphillips@google.com,michaelludwig@google.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Change-Id: I2e5adbfc820811fbbde9cb57af28f86a7ba40bd9
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/284231
Reviewed-by: Michael Ludwig <michaelludwig@google.com>
Commit-Queue: Michael Ludwig <michaelludwig@google.com>
2020-04-17 19:38:34 +00:00
Ethan Nicholas
36a3e014e1 Revert "Converted texture and runtime effects to use GrMatrixEffect"
This reverts commit 4ab84eda53.

Reason for revert: Breaking some GMs.

Original change's description:
> Converted texture and runtime effects to use GrMatrixEffect
> 
> Change-Id: I6e769d52291dd29c2d06983dae5013b6058864cb
> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/283780
> Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
> Reviewed-by: Brian Salomon <bsalomon@google.com>
> Reviewed-by: Brian Osman <brianosman@google.com>

TBR=bsalomon@google.com,brianosman@google.com,ethannicholas@google.com

Change-Id: Idb2c782ae619689744e868bf38111cc4eaf0b40a
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/284233
Reviewed-by: Ethan Nicholas <ethannicholas@google.com>
Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
2020-04-17 19:00:36 +00:00
Brian Salomon
4e7ee6e0af Put top level FPs into their own functions
Change-Id: I59916af90c30b07faed1198a745383d648c29e0e
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/284080
Commit-Queue: Brian Salomon <bsalomon@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
2020-04-17 18:55:53 +00:00
Mike Klein
69080be5e9 support JITMode::Stack on ARM
Change-Id: I13fd1fef764591bc9e773aa1f29bfcace01f753b
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/284299
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
2020-04-17 17:51:44 +00:00