Commit Graph

58242 Commits

Author SHA1 Message Date
Jorge Betancourt
1bbc6e5cef add plumbing for color filter SkSL effect
Change-Id: I26b28ff4756cda921e4acef32f3da3b43b1fc28f
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/472936
Reviewed-by: Florin Malita <fmalita@google.com>
Commit-Queue: Jorge Betancourt <jmbetancourt@google.com>
2021-11-23 16:30:40 +00:00
Derek Sollenberger
ad9d774c1f Add public API support for SkImageFilters::RuntimeShader
This new image filter constructor enables SkRuntimeEffects to be
used as shaders within the ImageFilter DAG. The shader is created
lazily using the SkRuntimeShaderBuilder enabling the resulting
shader to consume the previous stage of the ImageFilter graph.

Change-Id: I5d6917e34a8e5fdd053399f15a1e2cc7409e686f
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/470459
Reviewed-by: Brian Osman <brianosman@google.com>
Reviewed-by: Michael Ludwig <michaelludwig@google.com>
Commit-Queue: Derek Sollenberger <djsollen@google.com>
2021-11-23 15:08:42 +00:00
Herb Derby
15ecccf0dd expand SkCanvas with doDrawSlug, etc.
Follow the ordinary pattern on SkCanvas for handling GrSlugs. This
should allow more flexibility in the future.

Change-Id: Ic498b5d081a1c7e44c2864439423910c452408b7
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/474899
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Herb Derby <herb@google.com>
2021-11-23 14:41:32 +00:00
recipe-roller
605343cc7d Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (depot_tools, recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8829768416704426657

depot_tools:
a91f399a8a~..a29f589a15b7f80edd3d0bbe4f3a2dbb1120316c
  a91f399 (iannucci@chromium.org)
      [led] Roll led to always use realms in `led launch`.
  671883d (ukai@google.com)
      Roll out new goma client binary VERSION=236
  ed2508a (dpranke@google.com)
      Add a fetch config for the new chromium website repo.
  266129c (sokcevic@google.com)
      Ignore comments from accounts with no email
  2df8443 (sokcevic@google.com)
      Remove retry_decorator from third_party
  c08f84e (sokcevic@google.com)
      Update git fetch refspecs on git migrate
  787f2f0 (victorvianna@google.com)
      [ninjalog uploader] Collect more performance-relevant GN args
  08a95d8 (bryner@google.com)
      cpython3 3.8.10.chromium.23 to depot_tools bleeding edge.
  7ca4f55 (ukai@google.com)
      Roll out new goma client binary VERSION=237
  b9e694c (agrieve@chromium.org)
      Make "git cl format" use Python 3 by default
  f7b8f8f (vadimsh@chromium.org)
      Fix bytes vs str error in DownloadGerritHook.
  dc3baaa (rmhasan@google.com)
      WebView: Add logging for files that already exist in the GCS bu...
  067f0e5 (bryner@google.com)
      cpython3 3.8.10.chromium.23 to depot_tools stable.
  2efe3d7 (iannucci@chromium.org)
      [windows_sdk] Make sdk json-finding more flexible.
  26bee44 (rmhasan@google.com)
      Update the regex used for searching for ETag's in gsutil's output
  99c78e1 (ukai@google.com)
      Roll out new goma client binary VERSION=238
  41ed834 (iannucci@chromium.org)
      [windows_sdk] Fix json finder arguments.
  d8c8459 (gavinmak@google.com)
      Use ort strategy when applying patch
  176a9e8 (yuanjunh@google.com)
      [cipd] Update bb tool
  1c7dec3 (ajgo@chromium.org)
      [windows_sdk] Use correct path within cipd package
  c40274f (yiwzhang@google.com)
      roll lucicfg to v1.30.4
  af6bc7c (apolito@google.com)
      add vpython3 to tests that run under vpython3
  11c32b5 (sokcevic@google.com)
      Run py3 compatible unit tests with py3
  6635baf (sokcevic@google.com)
      Make CannedChecksUnittest py3 compatible
  b6c1ed4 (sokcevic@google.com)
      Make presubmit_unittest py3 compatible
  a29f589 (sokcevic@google.com)
      Make fix_encoding_test py3 compatible

recipe_engine:
ecdeebb466~..0dc8afb3a9ed9de231183bf0bec0d60a3dba025e
  ecdeebb (iannucci@chromium.org)
      [doc] Add a small section about resources.
  a101699 (olivernewman@google.com)
      [recipes_cfg] Add a NO_LABELS_APPROVE option
  2d175f7 (chromium-autoroll@skia-public.iam.gserviceaccount.com)
      Roll CAS Client from 850560a1a20e to de048fb36dbb
  58d2894 (tikuta@chromium.org)
      swarming: do not use latest package
  5d9f8ec (chromium-autoroll@skia-public.iam.gserviceaccount.com)
      Roll CAS Client from 672cf8a2c1d3 to c133751cba7b
  8f36c29 (tikuta@chromium.org)
      swarming: use str type for exit_code
  cca5500 (chromium-autoroll@skia-public.iam.gserviceaccount.com)
      Roll CAS Client from 84fe15a25a01 to d3ee0d636a1b
  7afe8b1 (tikuta@chromium.org)
      swarming: do not allow changing server/version via properties
  2484519 (chromium-autoroll@skia-public.iam.gserviceaccount.com)
      Roll CAS Client from 3faad1994dbc to cefd07c708bf
  eab766b (gbeaty@chromium.org)
      Train twice when looking for non-trivial rolls.
  cad20c9 (tikuta@chromium.org)
      led: use hostname from test data in swarming recipe module
  cd746d1 (bryner@google.com)
      Update to fixed cryptography 3.3.1.
  32d7da9 (godofredoc@google.com)
      Allow overriding bot_id in the swarming test_api.
  b35cc6b (gbeaty@chromium.org)
      Don't enqueue the py3 version of a test until the py2 version c...
  4f0aa33 (godofredoc@google.com)
      Use bot_id from env if passed by test_api.
  47014f5 (tikuta@chromium.org)
      swarming: remove with_server
  23d00d2 (gbeaty@google.com)
      Revert "Train twice when looking for non-trivial rolls."
  c71d9e1 (olivernewman@google.com)
      [buildbucket] Allow setting empty gerrit_changes
  8c186df (chromium-autoroll@skia-public.iam.gserviceaccount.com)
      Roll CAS Client from ca1bc02f210c to bf56a119c5f0
  f097006 (iannucci@chromium.org)
      Remove use of "buildbucket" CLI tool.
  edd22ec (gbeaty@chromium.org)
      Don't execute the py3 queue if a py2 failure occurs with stop f...
  ec66d81 (chromium-autoroll@skia-public.iam.gserviceaccount.com)
      Roll CAS Client from 16053c76f603 to 4cf9fa8105d3
  9721120 (tikuta@chromium.org)
      cas: roll client manually
  05a4a96 (chromium-autoroll@skia-public.iam.gserviceaccount.com)
      Roll CAS Client from git_revision:66f417317e177d30487c33cf26884...
  2559268 (chromium-autoroll@skia-public.iam.gserviceaccount.com)
      Roll CAS Client from 9f354df62c53 to 2dfe2f218f03
  3ac241e (olivernewman@google.com)
      Include log name in unknown log type error
  a92ad28 (gbeaty@chromium.org)
      Fix typo that causes failures for PY2+3 tests with --py3-only.
  0f2cbbe (zhaoyangli@chromium.org)
      Add get sub invocation api to ResultDB recipe API
  03702df (iannucci@chromium.org)
      [engine] Make step names internally coerce to `str`.
  cb62e2a (vadimsh@chromium.org)
      Add a simple `golang` recipe module.
  0dc8afb (iannucci@chromium.org)
      [cipd] Move ensure_tool to non-cacheable directory

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ieb35cd7bd65fb0acd6abfe47fe600ad039fe8df3
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/475496
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
2021-11-23 14:02:41 +00:00
skia-autoroll
eb5580e63a Roll SK Tool from a18e552403e9 to 2a6261fa4406
https://skia.googlesource.com/buildbot.git/+log/a18e552403e9..2a6261fa4406

2021-11-22 rmistry@google.com Use ExternalChangeId in parent/gitiles.go
2021-11-22 lovisolo@google.com [bazel] Update RBE toolchain container with missing dep needed for uploading undeclared test outputs.
2021-11-22 jcgregorio@google.com [perf] Add Contact URL to Perf configs.
2021-11-22 jcgregorio@google.com [perf] Update command-line tool docs.
2021-11-22 rmistry@google.com Add GetContent and GetFilesToContent to go/gerrit
2021-11-22 rmistry@google.com Use ExternalChangeId in git_checkout_github
2021-11-22 rmistry@google.com Use ExternalChangeId to set topic in Android rolls
2021-11-22 jcgregorio@google.com [perf] Add --verbose output to 'perf-tool ingest validate'.
2021-11-22 jcgregorio@google.com [perf] v8 fixups and add frontend server.
2021-11-22 rmistry@google.com Add a ConfigAndroidNoCRNoPR config
2021-11-22 rmistry@google.com Display in canary commit msg when ExternalChangeId is specified
2021-11-22 jcgregorio@google.com [perf] Add V8 to backups.
2021-11-22 jcgregorio@google.com [perf] Add a config for the V8 instance.
2021-11-22 lovisolo@google.com [bazel] Do not generate runfile trees when running on RBE.
2021-11-22 borenet@google.com [git] Make "main" the default branch

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/sk-tool-skia
Please CC lovisolo@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Tbr: lovisolo@google.com
Change-Id: I478158dd6876692e9f91994eface74ec54bc6f96
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/475364
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2021-11-23 13:55:06 +00:00
Kevin Lubick
128e7e1e8f Remove circular dependency between SkStroke.h and SkStrokerPriv.h
Each includes the other, but the former doesn't appear to need
the latter.

Change-Id: Ie2447717edf6188825418ef129dc28a28508fb43
Bug: skia:12584
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/475097
Reviewed-by: Ben Wagner <bungeman@google.com>
2021-11-23 12:33:46 +00:00
skia-autoroll
b59d6fe7f0 Roll ANGLE from 647026fa49c2 to 5859bb106c10 (10 revisions)
647026fa49..5859bb106c

2021-11-22 shrekshao@google.com Make D3D11 non instanced draw path explict
2021-11-22 yuxinhu@google.com Revert the order of texture sync and frame buffer object sync
2021-11-22 syoussefi@chromium.org Vulkan: Fix draw with emulated xfb without xfb active
2021-11-22 geofflang@google.com GL: Fix share groups for display texture sharing.
2021-11-22 syoussefi@chromium.org Roll VK-GL-CTS from 234f8a066b4d to bfede065f419 (18 revisions)
2021-11-22 syoussefi@chromium.org Use AttributeMap in eglLockSurfaceKHR's validation
2021-11-22 gert.wollny@collabora.com Capture/Replay: Repeat logs for unexpected results
2021-11-22 angle-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from f2ad120142ed to 8e41c1d91f9d (4 revisions)
2021-11-22 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from f5cf2d08ff9c to 6e23c082b73a (4 revisions)
2021-11-22 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from ebb70a6ec0bc to 53373ae01d32 (460 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-skia-autoroll
Please CC lovisolo@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: skia/skia.primary:Build-Debian10-Clang-x86_64-Release-ANGLE;skia/skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-Golo-GPU-QuadroP400-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC8i5BEK-GPU-IntelIris655-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE
Tbr: lovisolo@google.com
Change-Id: Ia6a293d3490270c91792592b9651252957e9173d
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/475357
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2021-11-23 05:24:12 +00:00
skia-autoroll
9d83e173e9 Roll SwiftShader from 6e23c082b73a to 9e727fadeb66 (3 revisions)
https://swiftshader.googlesource.com/SwiftShader.git/+log/6e23c082b73a..9e727fadeb66

2021-11-22 capn@google.com Assert that the descriptor set is not null
2021-11-22 capn@google.com Implement Assert() for Reactor
2021-11-22 ari.suonpaa@siru.fi Fix green bits for R5G6B5_UNORM_PACK16

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-skia-autoroll
Please CC lovisolo@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: skia/skia.primary:Test-Debian10-Clang-GCE-GPU-SwiftShader-x86_64-Debug-All-SwiftShader
Bug: None
Tbr: lovisolo@google.com
Change-Id: Id8ee5ea1a6549046b24863979b97a80ce63a4aee
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/475358
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2021-11-23 05:13:38 +00:00
skia-autoroll
b3a26cad2f Roll Chromium from b779de51f5c9 to 3da1a655ea70 (431 revisions)
b779de51f5..3da1a655ea

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-skia-autoroll
Please CC lovisolo@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: skia/skia.primary:Perf-Mac10.13-Clang-MacBookPro11.5-GPU-RadeonHD8870M-x86_64-Release-All-CommandBuffer;skia/skia.primary:Test-Mac10.13-Clang-MacBookPro11.5-GPU-RadeonHD8870M-x86_64-Debug-All-CommandBuffer
Tbr: lovisolo@google.com
Change-Id: I7c0a2bd422adf8b37d866de11424fc394db95394
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/475356
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2021-11-23 04:58:40 +00:00
skia-autoroll
c3db55663e Roll Dawn from 4e3ddbd95589 to aaaf70aee209 (8 revisions)
https://dawn.googlesource.com/dawn.git/+log/4e3ddbd95589..aaaf70aee209

2021-11-23 shaobo.yan@intel.com Remove *-srgb formats from CopyTextureForBrowser() supporting lists
2021-11-23 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from d781ef09f664 to 5859bb106c10 (4 revisions)
2021-11-23 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll Tint from 1704fe53f59a to e85efca13f87 (17 revisions)
2021-11-23 bajones@chromium.org Add label tracking for several object types (pt 2)
2021-11-22 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 135362c9ce17 to d781ef09f664 (3 revisions)
2021-11-22 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from bf2d35a064fe to 135362c9ce17 (2 revisions)
2021-11-22 zhaoming.jiang@intel.com Add size parameter check in buffer mapAsync in wire server
2021-11-22 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 647026fa49c2 to bf2d35a064fe (1 revision)

Also rolling transitive DEPS:
  https://dawn.googlesource.com/tint from 1704fe53f59a to e85efca13f87

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dawn-skia-autoroll
Please CC shrekshao@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: skia/skia.primary:Build-Debian10-Clang-x86_64-Debug-Dawn
Bug: None
Tbr: shrekshao@google.com
Change-Id: I35ccb04dcd7d4d17c04762f202439b3a5a8488cf
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/475359
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2021-11-23 04:42:45 +00:00
Jim Van Verth
2f6c53ff72 [graphite] Add SkSL compiler support
Bug: skia:12466
Change-Id: Ie7414d7417e88249dd9f6421f8069be898adaece
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/474217
Commit-Queue: Jim Van Verth <jvanverth@google.com>
Reviewed-by: Robert Phillips <robertphillips@google.com>
2021-11-22 23:13:11 +00:00
Brian Salomon
3595c15c12 Rebind GrGLRenderTarget if there is a lazy stencil attachment change.
Bug: chromium:1271431
Change-Id: Ie5bef1a8f18d4d1e2d9a92afdf5c5305d3d9bdb2
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/475256
Commit-Queue: Brian Salomon <bsalomon@google.com>
Reviewed-by: Greg Daniel <egdaniel@google.com>
2021-11-22 23:08:11 +00:00
Michael Ludwig
1f224edb2c [graphite] Add vertex/instance attribute definition to RenderStep
Moves Attribute into its own header. I did not move AttributeSet/Iter
out of GraphicsPipelineDesc because RenderStep should be able to just
rely on SkSpan<Attribute>. Since they are fixed definitions, there
shouldn't be a need to support skipping over uninitialized attrs. Once
GraphicsPipelineDesc just points to a RenderStep, AttributeSet/Iter can
be deleted.

Bug: skia:12466
Change-Id: I3b01b6283669fc02dc9cd0521bb236a9d0daa5eb
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/474136
Auto-Submit: Michael Ludwig <michaelludwig@google.com>
Commit-Queue: Jim Van Verth <jvanverth@google.com>
Reviewed-by: Jim Van Verth <jvanverth@google.com>
2021-11-22 22:31:09 +00:00
Jim Van Verth
54feafc834 Change SkSL::ShaderCaps and GrShaderCaps to structs.
There's no need for these fields to be private, and it removes the
need for friend classes -- the Caps classes can now set them directly.

Change-Id: I9b03d2ba06b792141036770f19804f100c05eeab
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/475258
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Jim Van Verth <jvanverth@google.com>
2021-11-22 22:26:43 +00:00
Michael Ludwig
b8e36741e0 [graphite] Add DrawWriter type for auto merging consecutive vertex data into draws
Change-Id: I94ded218e822fe50687e1efff7d46bcc4c1f1293
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/471780
Commit-Queue: Michael Ludwig <michaelludwig@google.com>
Reviewed-by: Greg Daniel <egdaniel@google.com>
2021-11-22 21:16:42 +00:00
Brian Osman
d7ebf8604e Revert "Restrict where 'binding' and 'set' can appear"
This reverts commit 9372ef0228.

Reason for revert: Unhappy bots

Original change's description:
> Restrict where 'binding' and 'set' can appear
>
> In SPIRV, these are an error when applied to struct members. Some of our
> tests were triggering that because we had free-floating uniforms
> decorated this way (and we coalesce those into members of an interface
> block).
>
> Now, we only allow those layout qualifiers on variable types that will
> remain top-level constructs in the back-end.
>
> Bug: skia:12670
> Change-Id: I73e69cecf6237a1c1180ad38d9b5d52ea80316fb
> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/474218
> Commit-Queue: Brian Osman <brianosman@google.com>
> Reviewed-by: Ethan Nicholas <ethannicholas@google.com>

Bug: skia:12670
Change-Id: Ie518192d9a52fc896e615ec08ce0674ad683ec61
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/475099
Auto-Submit: Brian Osman <brianosman@google.com>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
2021-11-22 19:52:23 +00:00
Brian Salomon
e00afb0a1a drawVertices and drawPath apply blend between paint and primitive color.
Bug: skia:12662
Change-Id: Ic2924257fce3ea9a2df5e49d0ab26ad085693d30
Cq-Include-Trybots: luci.skia.skia.primary:Canary-Flutter
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/473676
Commit-Queue: Brian Salomon <bsalomon@google.com>
Reviewed-by: Michael Ludwig <michaelludwig@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
2021-11-22 19:09:33 +00:00
Herb Derby
2f64952d20 introduce the GrSlug API
Introduce the GrSlug that encapsulates an SkTextBlob along with
the origin, and paint to create a GrSlug. You can draw the slug
using the canvas, and it will obey the canvas's clip and mapping.

See the full working prototype at:
  https://skia-review.googlesource.com/c/skia/+/471157/17

Change-Id: I5731dce3dea316ad144baead154a68c8e4c5db9a
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/474040
Commit-Queue: Herb Derby <herb@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
2021-11-22 18:44:17 +00:00
Brian Osman
9372ef0228 Restrict where 'binding' and 'set' can appear
In SPIRV, these are an error when applied to struct members. Some of our
tests were triggering that because we had free-floating uniforms
decorated this way (and we coalesce those into members of an interface
block).

Now, we only allow those layout qualifiers on variable types that will
remain top-level constructs in the back-end.

Bug: skia:12670
Change-Id: I73e69cecf6237a1c1180ad38d9b5d52ea80316fb
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/474218
Commit-Queue: Brian Osman <brianosman@google.com>
Reviewed-by: Ethan Nicholas <ethannicholas@google.com>
2021-11-22 18:28:41 +00:00
Kevin Lubick
d4bcb486ef Change relative includes to be absolute
Having all includes to skia source will make generating
BAZEL rules easier.

Change-Id: I318dfc88e736a62da151098bebbee8d7b357d963
Bug: skia:12541
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/474736
Reviewed-by: Ben Wagner <bungeman@google.com>
2021-11-22 17:03:26 +00:00
Kevin Lubick
f9c68800a2 Use angle brackets for system includes
Not only is this a best practice, it will make generating
BAZEL.build files easier.

Change-Id: Ib77c7dac6167235ec1b73a93bfd3a9c44b42ca83
Bug: skia:12541
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/474756
Reviewed-by: Ben Wagner <bungeman@google.com>
2021-11-22 17:03:11 +00:00
Michael Ludwig
61c032ea1b [graphite] Keep baseVertex,baseInstance relative to offset specified when vertex buffers were bound
All of the draw variants except drawIndexed support all base arguments
as part of the draw call that is recorded. Updated drawIndexed to use
the "instance" version and draw 1 instance if the baseVertex is not 0.

Previously, if we bound the buffer at a non-zero offset, but then
passed in 0 for the base vertex/instance relative to that, it would
reset the vertex offset to 0. This also cuts down on the number of
commands recorded since draws will only correspond to one command.

Bug: skia:12466
Change-Id: I3eb95b02d33f2d1e9b36991a8b824012383bc192
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/474058
Reviewed-by: Jim Van Verth <jvanverth@google.com>
Commit-Queue: Jim Van Verth <jvanverth@google.com>
Auto-Submit: Michael Ludwig <michaelludwig@google.com>
2021-11-22 16:55:12 +00:00
Chris Dalton
616b4a6e63 Drop support for indirect draws on ES
Bug: skia:b/197500792
Change-Id: I0005469352cd44cf4c66aea11de98a0247afd747
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/474397
Commit-Queue: Jim Van Verth <jvanverth@google.com>
Reviewed-by: Jim Van Verth <jvanverth@google.com>
2021-11-22 16:54:38 +00:00
Herb Derby
e6f2dce084 replace GlyphRunList with its origin for draw()
This change will make unifying code easier in future CLs.

Change-Id: I981b99ba4da6762702adfcb26165c1d3065339f7
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/474896
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Herb Derby <herb@google.com>
2021-11-22 16:33:32 +00:00
Herb Derby
1d513f06d7 remove unused GrTextBlob* from calls
Change-Id: I750bf3103504e3ed12c93e3071950785128f7db5
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/474838
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Herb Derby <herb@google.com>
2021-11-22 16:32:56 +00:00
skia-autoroll
bfafc430e8 Roll SK Tool from d9ac550a85b9 to 338c865c411a
https://skia.googlesource.com/buildbot.git/+log/d9ac550a85b9..338c865c411a

2021-11-22 rmistry@google.com Add new ExternalChangeId field to ManualRollRequest and Revision.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/sk-tool-skia
Please CC lovisolo@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Tbr: lovisolo@google.com
Change-Id: I7875542d6fc21a4e75c729ae3ac54af0d9c48bb8
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/474816
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2021-11-22 15:26:11 +00:00
skia-autoroll
647bd84de7 Roll ANGLE from b9c0194c4e1e to 647026fa49c2 (39 revisions)
b9c0194c4e..647026fa49

2021-11-20 ynovikov@chromium.org Reland "Fix unused variable "useSwiftShader""
2021-11-20 ynovikov@chromium.org Revert "Fix unused variable "useSwiftShader""
2021-11-20 ynovikov@chromium.org Fix unused variable "useSwiftShader"
2021-11-19 jmadill@chromium.org GLES 1: Fix missing validation returns.
2021-11-19 jmadill@chromium.org MultithreadingTest: Initialize an atomic bool.
2021-11-19 jmadill@chromium.org Fix signed integer overflow in angle_end2end_tests.
2021-11-19 gert.wollny@collabora.com Capture/Replay: Add default return path for AccessParamValue
2021-11-19 timvp@google.com Enable RenderDoc capture for debug builds
2021-11-19 cnorthrop@google.com GLES1: Hard code integer values in the ubershader
2021-11-19 cnorthrop@google.com infra: Increase gles1_conformance_tests timeout
2021-11-19 lubosz.sarnecki@collabora.com mathutil: Add roundDownPow2.
2021-11-19 jmadill@chromium.org Vulkan: Fix CFI ignore config.
2021-11-19 jmadill@chromium.org GN: Ensure using_sanitizer is declared even without //build.
2021-11-19 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from c801e56b48b9 to ebb70a6ec0bc (399 revisions)
2021-11-19 jmadill@chromium.org infra: Enable flaky retries on Mac end2end_tests.
2021-11-19 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 4c687cc2f8ea to f5cf2d08ff9c (2 revisions)
2021-11-19 angle-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 478aa76e7d38 to f2ad120142ed (3 revisions)
2021-11-19 ianelliott@google.com Avoid Android vkEnumerateDeviceExtensionProperties() bug
2021-11-18 geofflang@google.com Roll chromium_revision 426f5c5607..c801e56b48 (941724:943107)
2021-11-18 jmadill@chromium.org Vulkan: Lock around handle counter.
2021-11-18 jmadill@chromium.org Vulkan: Lock around debug annotator.
2021-11-18 jmadill@chromium.org Updates to perf test running script.
2021-11-18 jmadill@chromium.org Vulkan: Add mutex around cache stats.
2021-11-18 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from f0e8ec2da282 to 4c687cc2f8ea (4 revisions)
2021-11-18 angle-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 50e341fc93fd to 478aa76e7d38 (7 revisions)
2021-11-18 gert.wollny@collabora.com Capture/Replay: Handle newly generated FBOs in tracker
2021-11-17 jmadill@chromium.org infra: Update NVIDIA to 1660 testing.
2021-11-17 geofflang@google.com Disable variable shadow warnings on more ES1 conformance tests
2021-11-17 lfy@google.com Add cpu time measurement to perf tests
2021-11-17 gert.wollny@collabora.com Capture/Replay: Capture GetTexLevelParameter return param
2021-11-17 syoussefi@chromium.org Fix typo in SystemInfo_libpci.cpp
2021-11-17 gert.wollny@collabora.com Capture/Replay: Additional tests that now compile
2021-11-17 jmadill@chromium.org GN: Add symbolizer data for sanitizer builds.
2021-11-17 angle-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 459e5e53952a to 50e341fc93fd (12 revisions)
2021-11-17 gert.wollny@collabora.com Capture/Replay: Capture GetProgramResourceLocation name param
2021-11-17 gert.wollny@collabora.com Capture/Replay: Capture GetProgramResource params correctly
2021-11-17 jmadill@chromium.org Test Runner: Print output snippet in test timeout.
2021-11-17 jmadill@chromium.org Vulkan: Generalize barrier VVL suppression.
2021-11-17 jmadill@chromium.org infra: Increase sharding on SwANGLE trace tests.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-skia-autoroll
Please CC lovisolo@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: skia/skia.primary:Build-Debian10-Clang-x86_64-Release-ANGLE;skia/skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-Golo-GPU-QuadroP400-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC8i5BEK-GPU-IntelIris655-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE
Tbr: lovisolo@google.com
Test: Test: BuiltinVariableVertexIdTest.LineLoop/ES3_Vulkan_SwiftShader
Test: Test: GLSLTest_ES3.GLVertexIDIntegerTextureDrawArrays/*
Test: Test: GLSLTest_ES3.GLVertexIDIntegerTextureDrawArrays/ES3_Vulkan_SwiftShader
Test: Test: end2end, perftests, gles1_conformance
Change-Id: I6ead1011700b663ea156ef9d709f3257d0cd0728
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/474697
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2021-11-22 05:23:09 +00:00
skia-autoroll
25724fc253 Roll SwiftShader from f5cf2d08ff9c to 6e23c082b73a (4 revisions)
https://swiftshader.googlesource.com/SwiftShader.git/+log/f5cf2d08ff9c..6e23c082b73a

2021-11-19 sugoi@google.com Make line stipple related tests pass
2021-11-19 capn@google.com Run clang-format-all.sh as a Bash script
2021-11-19 swiftshader.regress@gmail.com Regres: Update test lists @ 210fe010
2021-11-19 capn@google.com Update testslists to match the dEQP revision

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-skia-autoroll
Please CC lovisolo@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: skia/skia.primary:Test-Debian10-Clang-GCE-GPU-SwiftShader-x86_64-Debug-All-SwiftShader
Bug: None
Tbr: lovisolo@google.com
Change-Id: I1d1397c442299a9b409f5d06fbc13cdf90f11e6a
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/474698
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2021-11-22 05:11:41 +00:00
skia-autoroll
7af0e2dd36 Roll Chromium from e7ac7694e638 to b779de51f5c9 (534 revisions)
e7ac7694e6..b779de51f5

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-skia-autoroll
Please CC lovisolo@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: skia/skia.primary:Perf-Mac10.13-Clang-MacBookPro11.5-GPU-RadeonHD8870M-x86_64-Release-All-CommandBuffer;skia/skia.primary:Test-Mac10.13-Clang-MacBookPro11.5-GPU-RadeonHD8870M-x86_64-Debug-All-CommandBuffer
Tbr: lovisolo@google.com
Change-Id: I85cfc23ba408e97e1d4dc4678ca26b9984d44aa3
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/474696
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2021-11-22 04:56:15 +00:00
skia-autoroll
c8821bbe2f Roll Dawn from 53db01bf1e64 to 4e3ddbd95589 (10 revisions)
https://dawn.googlesource.com/dawn.git/+log/53db01bf1e64..4e3ddbd95589

2021-11-21 jiawei.shao@intel.com Add label to the trace events for pipeline and shader module creation
2021-11-21 jiawei.shao@intel.com Fix a warning in FirstIndexOffsetTests about "flat" interpolation
2021-11-20 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 98a492209070 to 647026fa49c2 (3 revisions)
2021-11-20 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 1cc5d096ffd7 to 98a492209070 (7 revisions)
2021-11-19 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 7e40d55651e7 to 1cc5d096ffd7 (5 revisions)
2021-11-19 shrekshao@google.com Refactor D3D12 shader define strings code
2021-11-19 lokokung@google.com Updates destroy in Vulkan's BindGroupLayout.
2021-11-19 bajones@chromium.org Add label tracking for several object types
2021-11-19 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 1f5eb6b8ede5 to 7e40d55651e7 (2 revisions)
2021-11-19 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 8700d9ccb795 to 1f5eb6b8ede5 (3 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dawn-skia-autoroll
Please CC bajones@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: skia/skia.primary:Build-Debian10-Clang-x86_64-Debug-Dawn
Bug: None
Tbr: bajones@google.com
Change-Id: I7bc4dafb3ca7da6c29e869b2a695714879ab4182
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/474699
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2021-11-22 04:40:11 +00:00
skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com
7ecacbc4c6 Update SKP version
Automatic commit by the RecreateSKPs bot.

Change-Id: I1af7049a6ea63869ce35b4975648bc79d12cb7a4
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/474604
Commit-Queue: skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Bot-Commit: skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
2021-11-21 08:11:09 +00:00
skia-autoroll
a6de6d2366 Roll SK Tool from 055155207d7e to 0024349d8141
https://skia.googlesource.com/buildbot.git/+log/055155207d7e..0024349d8141

2021-11-21 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update CIPD Packages

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/sk-tool-skia
Please CC rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Tbr: rmistry@google.com
Change-Id: Iaabda2527b14391a559f58ee36153835a030a6c6
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/474577
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2021-11-21 06:42:08 +00:00
Chris Dalton
37940afc0c Remove remaining "Gr" references outside of #ifdefs from tessellators
Bug: skia:12524
Change-Id: I2fb523495cfa72591a14b4ef03d32e3aad06fcf2
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/474396
Reviewed-by: Michael Ludwig <michaelludwig@google.com>
Commit-Queue: Chris Dalton <csmartdalton@google.com>
2021-11-20 02:52:52 +00:00
Chris Dalton
9f1719f7f7 Move GrVertexColor to skgpu::VertexColor
Bug: skia:12524
Change-Id: Iac60a99331fefe9e997b61c4b2b329e39b95ae6e
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/470197
Commit-Queue: Chris Dalton <csmartdalton@google.com>
Reviewed-by: Michael Ludwig <michaelludwig@google.com>
Reviewed-by: Greg Daniel <egdaniel@google.com>
2021-11-20 02:48:28 +00:00
Chris Dalton
fc0941003e Move tessellation-specific functions out of GrPathUtils
Bug: skia:12524
Change-Id: I2664c8ea707a40724bcf916e907fe28d1fa276d6
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/474357
Reviewed-by: Michael Ludwig <michaelludwig@google.com>
Commit-Queue: Chris Dalton <csmartdalton@google.com>
2021-11-20 02:47:40 +00:00
Chris Dalton
5cf4ed47f4 Move Ganesh-specific bits of StrokeTessellator into an #ifdef
Bug: skia:12524
Change-Id: I31ddee40fed6e57caafe7a51fdd90459bd29cd6a
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/474356
Commit-Queue: Chris Dalton <csmartdalton@google.com>
Reviewed-by: Michael Ludwig <michaelludwig@google.com>
2021-11-20 02:35:39 +00:00
Chris Dalton
1ce70dc2ce Convert StrokeTessellators to use PatchWriter
Bug: skia:12524
Change-Id: I99ade4b9f4fd442d9ddaa51651faf47321c06a5b
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/474296
Reviewed-by: Michael Ludwig <michaelludwig@google.com>
Commit-Queue: Chris Dalton <csmartdalton@google.com>
2021-11-20 01:57:42 +00:00
John Stiles
fb0fa24e31 Remove VarType from trace_var opcode.
This is redundant information now that we have SkVMSlotInfo.

Change-Id: Ia05b1eaa722023e719042c83255708aa9debed61
Bug: skia:12614
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/473777
Commit-Queue: John Stiles <johnstiles@google.com>
Auto-Submit: John Stiles <johnstiles@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
2021-11-20 01:52:40 +00:00
Erik Rose
9b35cd642f [infra] Update iOS provisioning profile.
* Remove 3 iPad Pro 9.7"s killed in the March 2020 Skolo flood.
* Add skia-iphone-8-03, which was mysteriously missing.

Change-Id: Idf3bbc553958a1327b0909183f85ab43dced3429
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/474020
Reviewed-by: Leandro Lovisolo <lovisolo@google.com>
Commit-Queue: Erik Rose <erikrose@google.com>
2021-11-19 20:45:39 +00:00
Chris Dalton
bdf4952a3d Extract a PatchWriter::Patch base class
Bug: skia:12524
Change-Id: I48bd7dabb7d169f3ac544f2b7a2e2a68f4b01e1b
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/474158
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Chris Dalton <csmartdalton@google.com>
2021-11-19 19:52:34 +00:00
Brian Osman
f72c919a9a Roll SPIRV-Headers and SPIRV-Tools
This adds new validation rules that we were breaking.
Binding and DescriptorSet can't be applied to push constants, nor to
struct members.

Bug: skia:12670
Bug: chromium:1270328
Change-Id: I332f77717b08d9945c8e5b79c5bf649a8f5f2043
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/474056
Commit-Queue: Brian Osman <brianosman@google.com>
Reviewed-by: Ethan Nicholas <ethannicholas@google.com>
2021-11-19 19:22:54 +00:00
Ben Wagner
0cdcf57f8c Cache FreeType glyph masks may need current color.
If a FreeType font has glyphs which may need the current color this is
non-changing information, so calculate it once at and cache it. This
information is needed on evert time a scaler context rec is created and
adding the overhead of looking through the font data (especially the
extra indirections from a ttc) can take a bit of time.

Bug: b/206120675
Change-Id: I92f2083a6bbd673fc148347c4e04ed81a441c3ba
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/474059
Reviewed-by: Derek Sollenberger <djsollen@google.com>
Commit-Queue: Ben Wagner <bungeman@google.com>
2021-11-19 18:50:47 +00:00
Michael Ludwig
940086c815 [graphite] Include offset in Writers returned by DrawBufferManager
Previously, while BindBufferInfo had the right offset for binding the
buffers, the writer would always overwrite the contents at the
beginning. Never encountered it because the CommandBufferTest made its
VertexWriters directly, and DrawPass isn't end-to-end yet.

Bug: skia:12466
Change-Id: Ib874006d80a7286fcc3710cd38b3c6141ff928ef
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/474057
Commit-Queue: Jim Van Verth <jvanverth@google.com>
Auto-Submit: Michael Ludwig <michaelludwig@google.com>
Reviewed-by: Jim Van Verth <jvanverth@google.com>
2021-11-19 17:57:52 +00:00
Herb Derby
fde5b838e8 refactor checking for direct glyph situations
Update the check for situations using the direct glyph drawing
method. Mostly renaming.

Change-Id: I9e2ad8b669e9868b5fffd4864fb4551fec11f19c
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/474038
Commit-Queue: Herb Derby <herb@google.com>
Reviewed-by: Robert Phillips <robertphillips@google.com>
2021-11-19 17:19:44 +00:00
Jim Van Verth
3b0eacc6ea Add SkSL::ShaderCaps and use as base class for GrShaderCaps
Bug: skia:12559
Change-Id: I76b225c9ca81264a15869324007d774d210053b5
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/473416
Commit-Queue: Jim Van Verth <jvanverth@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
Reviewed-by: John Stiles <johnstiles@google.com>
2021-11-19 16:35:39 +00:00
Leon Scroggins III
63dee7ef06 Add minimal GL support for protected backend textures
Bug: b/205516620

Internally, Skia does not have full GL support for protected backend
textures. But there are some clients who know that they need to create
one so that they can render a protected buffer into it. Plumb in support
for clients calling GrDirectContext::createBackendTexture.

GrGLDefines.h:
- Add macros for querying whether a context is protected

GrGLCaps:
- Check whether the GL_EXT_protected_textures extension is present and
the context supports protected.

GrGLGpu:
- Remove failure cases for GrProtected::kYes. Instead, pass the value
down to createTexture where we then set the parameter in GL.

Change-Id: I465442fc4b19ed32a65079a168124a067bcd66a6
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/472802
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Leon Scroggins <scroggo@google.com>
2021-11-19 16:08:16 +00:00
skia-autoroll
15ae48da5f Roll SwiftShader from 4c687cc2f8ea to f5cf2d08ff9c (2 revisions)
https://swiftshader.googlesource.com/SwiftShader.git/+log/4c687cc2f8ea..f5cf2d08ff9c

2021-11-18 swiftshader.regress@gmail.com Regres: Update test lists @ 4c687cc2
2021-11-18 ari.suonpaa@siru.fi Fix border color when sampling normalized texture formats

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-skia-autoroll
Please CC jlavrova@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: skia/skia.primary:Test-Debian10-Clang-GCE-GPU-SwiftShader-x86_64-Debug-All-SwiftShader
Bug: None
Tbr: jlavrova@google.com
Change-Id: I2ce5caeb818d2188d7f4edc25dea8c235fb7183c
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/473956
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2021-11-19 05:14:38 +00:00
skia-autoroll
cf48622d66 Roll Chromium from ca9862fcfe55 to e7ac7694e638 (463 revisions)
ca9862fcfe..e7ac7694e6

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-skia-autoroll
Please CC jlavrova@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: skia/skia.primary:Perf-Mac10.13-Clang-MacBookPro11.5-GPU-RadeonHD8870M-x86_64-Release-All-CommandBuffer;skia/skia.primary:Test-Mac10.13-Clang-MacBookPro11.5-GPU-RadeonHD8870M-x86_64-Debug-All-CommandBuffer
Tbr: jlavrova@google.com
Change-Id: I4315a1c8d9a949b6d5ff042597fda276038fd905
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/473959
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2021-11-19 04:59:12 +00:00
skia-autoroll
f91b6a83f1 Roll Dawn from 67e1e9c199cc to 53db01bf1e64 (5 revisions)
https://dawn.googlesource.com/dawn.git/+log/67e1e9c199cc..53db01bf1e64

2021-11-18 cwallez@chromium.org dawn.json changes for the upstream webgpu.h optional features
2021-11-18 shrekshao@google.com Pipeline overridable constants: D3D12 backend
2021-11-18 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 71bffb8af87f to 8700d9ccb795 (5 revisions)
2021-11-18 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll Tint from d018d2e5bca1 to 1704fe53f59a (1 revision)
2021-11-18 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 9a36c3b6f124 to 71bffb8af87f (1 revision)

Also rolling transitive DEPS:
  https://dawn.googlesource.com/tint from d018d2e5bca1 to 1704fe53f59a

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dawn-skia-autoroll
Please CC bajones@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: skia/skia.primary:Build-Debian10-Clang-x86_64-Debug-Dawn
Bug: None
Tbr: bajones@google.com
Change-Id: Iffc32d635be28b9fff8aa1395af5556c0cd587ef
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/473957
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2021-11-19 04:53:12 +00:00
Brian Osman
62392f624f Remove old (unused) values from LayoutToken enum
Change-Id: Idcedaf97d9036fc892bbfc4fa7be468dd7a11db9
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/473660
Commit-Queue: Brian Osman <brianosman@google.com>
Commit-Queue: John Stiles <johnstiles@google.com>
Auto-Submit: Brian Osman <brianosman@google.com>
Reviewed-by: John Stiles <johnstiles@google.com>
2021-11-18 22:35:09 +00:00