caryclark
bca19f7747
deal more consistently with unsortable edges
...
Improve line/curve coincident detection and resolution. This fixed the remaining simple failures.
When an edge is unsortable, use the ray intersection to determine the angles' winding.
Deal with degenerate segments.
TBR=reed@google.com
BUG=skia:3588,skia:3762
Review URL: https://codereview.chromium.org/1140813002
2015-05-13 08:23:48 -07:00
reed
80ea19ca4b
Revert of Revert of stop calling SkScalarDiv (patchset #1 id:1 of https://codereview.chromium.org/1138263002/ )
...
Reason for revert:
android patched, blink has rolled
Original issue's description:
> Revert of stop calling SkScalarDiv (patchset #4 id:60001 of https://codereview.chromium.org/1135053002/ )
>
> Reason for revert:
> need to wait for Blink roll (and patch android)
>
> Original issue's description:
> > stop calling SkScalarDiv
> >
> > BUG=skia:
> > TBR=
> >
> > Committed: https://skia.googlesource.com/skia/+/67d71c898249a7af3523b16c6a69895a63bfae0a
>
> TBR=
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/2629697933b5cc975e45d2a45c48f803fc6cbcec
TBR=
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/1135693003
2015-05-12 10:37:34 -07:00
reed
2629697933
Revert of stop calling SkScalarDiv (patchset #4 id:60001 of https://codereview.chromium.org/1135053002/ )
...
Reason for revert:
need to wait for Blink roll (and patch android)
Original issue's description:
> stop calling SkScalarDiv
>
> BUG=skia:
> TBR=
>
> Committed: https://skia.googlesource.com/skia/+/67d71c898249a7af3523b16c6a69895a63bfae0a
TBR=
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/1138263002
2015-05-12 10:28:06 -07:00
reed
67d71c8982
stop calling SkScalarDiv
...
BUG=skia:
TBR=
Review URL: https://codereview.chromium.org/1135053002
2015-05-12 09:47:22 -07:00
caryclark
7da2e55ccb
quickie tool to exercise chrome filter fuzz files
...
This is a quick Skia transcription of the Chromium tool at
src/skia/tools/filter_fuzz_stub.cc
to read and decode filters captured as .fil files.
R=joshualitt@google.com ,mtklein@google.com,reed@google.com,robertphillips@google.com
BUG=487213
Review URL: https://codereview.chromium.org/1126423005
2015-05-12 08:36:48 -07:00
caryclark
624637cc8e
Path ops formerly found the topmost unprocessed edge and determined its angle sort order to initialize the winding. This never worked correctly with cubics and was flaky with paths consisting mostly of vertical edges.
...
This replacement shoots axis-aligned rays through all intersecting edges to find the outermost one either horizontally or vertically. The resulting code is smaller and twice as fast.
To support this, most of the horizontal / vertical intersection code was rewritten and standardized, and old code supporting the top-directed winding was deleted.
Contours were pointed to by an SkTDArray. Instead, put them in a linked list, and designate the list head with its own class to ensure that methods that take lists of contours start at the top. This change removed a large percentage of memory allocations used by path ops.
TBR=reed@google.com
BUG=skia:3588
Review URL: https://codereview.chromium.org/1111333002
2015-05-11 07:21:28 -07:00
mtklein
32618cb857
Test sp-8888 mode on a few fast bots.
...
(It's not particularly slow, but this mode doesn't really need global coverage.)
BUG=skia:
Review URL: https://codereview.chromium.org/1129903003
2015-05-07 10:26:44 -07:00
borenet
d9b6be197f
Remove upright-matrix- configs from Android bots
...
The Android bots are flaking like crazy. I'm not sure if these configs
are hurting the situation, but let's see if this helps.
TBR=mtklein,halcanary
BUG=skia:
Review URL: https://codereview.chromium.org/1131603002
2015-05-06 08:33:51 -07:00
borenet
e3aeaec7dd
Add matrix configs to DM
...
BUG=skia:832
Review URL: https://codereview.chromium.org/1125793002
2015-05-05 13:11:27 -07:00
mtklein
e4b19c4593
Add presubmit to run {dm,nanobench}_flags.py test
when changed.
...
BUG=skia:
Review URL: https://codereview.chromium.org/1129443005
2015-05-05 10:28:44 -07:00
borenet
f4e0857fe9
Blacklist tiles_rt-gpu gm imagefilterscropped on GalaxyS4
...
BUG=skia:3802
Review URL: https://codereview.chromium.org/1115303004
2015-05-05 08:28:23 -07:00
stephana
deee2980f4
cleanup
...
BUG=skia:
Review URL: https://codereview.chromium.org/1085583006
2015-05-05 07:55:06 -07:00
mtklein
19e259b1ee
ignore_result()
...
BUG=skia:3801
Review URL: https://codereview.chromium.org/1127603003
2015-05-04 10:54:48 -07:00
bsalomon
d309e7aa0e
This replaces the texture creation/caching functions on GrContext with a GrTextureProvider interface. The goal is to pass this narrowly focused object in places that currently take a GrContext but don't need and shouldn't use its other methods. It also has an extended private interface for interacting with non-texture resource types.
...
Review URL: https://codereview.chromium.org/1107973004
2015-04-30 14:18:54 -07:00
bungeman
3ffa126066
Move resource fonts to common location.
...
Move resource fonts to resources/fonts, add a destortable font for
testing, and clean up how the tests create fonts from resources.
R=joshualitt@google.com
Review URL: https://codereview.chromium.org/1120823002
2015-04-30 17:12:58 -04:00
mtklein
f1d6df772e
Looks like rssPages * pageSize is overflowing on 32-bit Linux...
...
... resulting in apparently negative memory usage:
(-2040/2058MB 5867) 1.81s serialize-8888 skp top25desk_google_com_calendar_.skp
Turns out long is 32-bit there, long long is 64-bit.
NOTREECHECKS=true
BUG=skia:
Review URL: https://codereview.chromium.org/1117923002
2015-04-30 07:35:28 -07:00
mtklein
d75c466ef5
DM+nanobench: print both current and max RSS.
...
out/Debug/dm:
( 360/380 MB 2112) 396ms gpu gm xfermodes
out/Release/nanobench:
32/33 MB 1659 2.46µs 2.55µs 2.54µs 2.67µs 2% ▄▄▄▅▅▃▂▁▂█ gpu gradient_conicalZero_clamp_hicolor
out/Debug/nanobench:
42/42 MB desk_css3gradients.skp_1 8888
BUG=skia:
NOTREECHECKS=true
Review URL: https://codereview.chromium.org/1115203002
2015-04-30 07:11:22 -07:00
rmistry
23c5f51371
Handpick 16 Skia page sets to create SP enabled SKPs from
...
Context is in: https://code.google.com/p/skia/issues/detail?id=3763#c18
NOTRY=true
BUG=skia:3763
Review URL: https://codereview.chromium.org/1115003002
2015-04-29 10:15:07 -07:00
caryclark
aec2510125
minor fixes to cubics code and overall alignment of how bounds and tops are computed for all curve types
...
All but 17 extended tests work.
A helper function is privately added to SkPath.h to permit a test to modify a given point in a path.
BUG=skia:3588
Review URL: https://codereview.chromium.org/1107353004
2015-04-29 08:28:30 -07:00
rmistry
385e88cc16
Create SP enabled SKPs from only the top_25_smooth page set.
...
Context is here: https://code.google.com/p/skia/issues/detail?id=3763#c14
BUG=skia:3763
NOTRY=true
Review URL: https://codereview.chromium.org/1111273003
2015-04-29 07:26:33 -07:00
halcanary
5190a481f9
doc: add quickstart to linux and macos
...
also, better install_deps
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=1112663002
Review URL: https://codereview.chromium.org/1112663002
2015-04-28 13:06:54 -07:00
borenet
97025e34d3
Run DM on GalaxyS* in one thread
...
Drive-by cleanup of Xoom
BUG=skia:3214
Review URL: https://codereview.chromium.org/1106173004
2015-04-28 09:54:55 -07:00
rmistry
77772f3ca3
Update RecreateSKPs bot to also generate Slimming Paint SKPs with a separate prefix.
...
Will only be committed after I get the go head in skia:3763.
BUG=skia:3763
NOTRY=true
Review URL: https://codereview.chromium.org/1065503007
2015-04-28 08:27:19 -07:00
joshualitt
8f94bb2b25
remove old text contexts and fontcache
...
BUG=skia:
Review URL: https://codereview.chromium.org/1104343003
2015-04-28 07:04:11 -07:00
halcanary
2752314745
dm||nanobench --help looks nice when $COLUMNS == 80.
...
Also, add to --config help message
Review URL: https://codereview.chromium.org/1105593002
2015-04-27 06:41:36 -07:00
caryclark
08bc8488fa
fix multiple intersection logic
...
When three or more curves intersect at the same point, ensure that
each curve records the intersections of the others. This fixes a
number of cubic tests.
TBR=reed@google.com
BUG=skia:3588
Review URL: https://codereview.chromium.org/1105943002
2015-04-24 09:08:57 -07:00
rmistry
aa31ee78ee
Add ability to specify extra browser args and a prefix for SKP names to webpages_playback.py
...
BUG=skia:3763
NOTRY=true
Review URL: https://codereview.chromium.org/1066933006
2015-04-23 12:47:33 -07:00
borenet
e1d7e0f0a5
Blacklist desk_unicodetable SKP on Nexus Player
...
It's getting us killed for OOM.
BUG=skia:3240
Review URL: https://codereview.chromium.org/1104693002
2015-04-23 12:44:31 -07:00
caryclark
03b03cad01
working on initial winding for cubics
...
Path ops works well for all tests except for cubics.
Isolate failures caused by cubics, and do a better job of computing
the initial winding for cubics.
TBR=reed@google.com
BUG=skia:3588
Review URL: https://codereview.chromium.org/1096923003
2015-04-23 09:13:37 -07:00
mtklein
d557462f1f
Skip msaa4 on Tegra 2 and 3.
...
This will fix the N7 and Xoom bots.
TBR=borenet@google.com
BUG=skia:
Review URL: https://codereview.chromium.org/1099943002
2015-04-21 11:25:47 -07:00
mtklein
05641a5582
DM: failure to canary a sink is now fatal.
...
This requires we remove NVPR from the default set of configs, as we only find
out at runtime that it's not available. All the other defaults will either be
compiled in and supported, or not compiled in and non-fatally skipped as
unknown configs.
BUG=skia:
Review URL: https://codereview.chromium.org/1100773003
2015-04-21 10:49:14 -07:00
mtklein
fca5c88873
Ask for NVPR only when we expect it to be available.
...
BUG=skia:
Review URL: https://codereview.chromium.org/1099023003
2015-04-21 10:34:47 -07:00
stephana
cdec56e72b
Landing directly for testing the ios buildbot code.
...
BUG=skia:
TBR=borenet
Review URL: https://codereview.chromium.org/1087653005
2015-04-21 08:31:59 -07:00
caryclark
1049f1246e
Now, path ops natively intersect conics, quads, and cubics in any combination. There are still a class of cubic tests that fail and a handful of undiagnosed failures from skps and fuzz tests, but things are much better overall.
...
Extended tests (150M+) run to completion in release in about 6 minutes; the standard test suite exceeds 100K and finishes in a few seconds on desktops.
TBR=reed
BUG=skia:3588
Review URL: https://codereview.chromium.org/1037953004
2015-04-20 08:31:59 -07:00
joshualitt
9e36c1a930
Start canonicalizing color for all A8 textblobs
...
BUG=skia:
Review URL: https://codereview.chromium.org/1076593002
2015-04-14 12:17:27 -07:00
borenet
22ecae88ee
Blacklist desk_wikipedia pdf on Valgrind bots
...
BUG=skia:3506
Review URL: https://codereview.chromium.org/1056763004
2015-04-13 13:29:26 -07:00
msarett
3c309db75b
Implementing filling for SkBmpCodec
...
The bmp codec currently returns kIncompleteInput
when the stream is truncated, which we treat as a
partial success. However, we neglect the fill the
remaining pixels in the image, leaving these
uninitialized.
This CL addresses this problem by initializing the
remaining pixels in the image to default values.
BUG=skia:3257
Review URL: https://codereview.chromium.org/1075243003
2015-04-10 14:36:49 -07:00
stephana
195f62d07d
BUG=skia:
...
Review URL: https://codereview.chromium.org/1054073003
2015-04-09 07:57:54 -07:00
Mike Klein
fbcf0bd7ff
expand pdf/worldjournal blacklist entry to cover the new skp too
...
BUG=skia:
Review URL: https://codereview.chromium.org/1070013002
2015-04-09 06:03:22 -04:00
caryclark
95bc5f3495
change isNestedRect to isNestedFillRect
...
R=reed@google.com , bsalomon@google.com
Let isNested(Fill)Rect return true if drawn path describes filled
rectangles.
Review URL: https://codereview.chromium.org/1073473002
2015-04-08 08:34:15 -07:00
mtklein
929f63fecc
Make --undefok a little louder now that we're using it all the time.
...
BUG=skia:
Review URL: https://codereview.chromium.org/1073483002
2015-04-08 08:30:38 -07:00
borenet
dfaebfba42
Remove get_uploaded hashes
...
Replaced with an inline script in
https://codereview.chromium.org/1068503002/
BUG=skia:3521
Review URL: https://codereview.chromium.org/1062873002
2015-04-06 13:19:26 -07:00
msarett
2f273a1ed0
Adding non-deterministic images to blacklist
...
BUG=skia:3653
Review URL: https://codereview.chromium.org/1054593006
2015-04-06 08:38:49 -07:00
borenet
09ed480906
Add --uninterestingHashesFile to DM
...
The file is expected to contain a list of strings. If the hash for
any result is in this file, don't write an image for it.
BUG=skia:3521
Review URL: https://codereview.chromium.org/1059363002
2015-04-03 14:15:33 -07:00
rmistry
80bd3ae9d7
Delete no longer needed pagesets, add new pagesets and make names more readable
...
Deleted all pagesets mentioned in https://code.google.com/p/skia/issues/detail?id=3574#c18
Added new Wikipedia and Unicodetable pagesets from https://code.google.com/p/skia/issues/detail?id=3574#c19
BUG=skia:3574
NOTRY=true
Review URL: https://codereview.chromium.org/1053253003
2015-04-03 08:22:51 -07:00
djsollen
54416de523
Update DM to allow Src's to have optional options.
...
Review URL: https://codereview.chromium.org/1059513002
2015-04-03 07:24:48 -07:00
borenet
4808757d7a
Remove all code related to NaCl
...
BUG=skia:3600
DOCS_PREVIEW= https://skia.org/?cl=1036283002
Review URL: https://codereview.chromium.org/1036283002
2015-04-02 12:16:36 -07:00
borenet
11106f196e
Skip desk_baidu skp on Valgrind bot
...
This has been running for 16 hours:
https://uberchromegw.corp.google.com/i/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Valgrind/builds/12/
BUG=skia:3506
Review URL: https://codereview.chromium.org/1056883002
2015-04-02 07:24:03 -07:00
rmistry
2a3c8493af
Turn on Chromium's top 25 page set
...
#crskps
BUG=skia:
BUG=skia:3574
NOTRY=true
TBR=borenet
Review URL: https://codereview.chromium.org/1045153004
2015-03-31 10:59:15 -07:00
rmistry
39383a1946
Fix cr SKPs naming
...
#crskps
BUG=skia:
BUG=skia:3574
NOTRY=true
TBR=borenet
Review URL: https://codereview.chromium.org/1044193003
2015-03-31 08:03:02 -07:00