Subtle differences like location in an atlas can cause LSB differences
in path rendering, depending on FP precision.
Bug: skia:
Change-Id: I1e6fef7eaeef833db767d9c4b6c9d29dca2fee73
Reviewed-on: https://skia-review.googlesource.com/150212
Reviewed-by: Herb Derby <herb@google.com>
Commit-Queue: Chris Dalton <csmartdalton@google.com>
The tiles are now centered in a 200 x 200 box.
Additionally, the frames drawn should now
match how the seeking happens (before, we would
try to draw frame *index* 300 when there were only
300 frames)
I renamed a variable in DmSrcSink because it initially
confused me as the purpose of it.
Bug: skia:
Change-Id: I8552a24727326cd8714dfd1c7794a0c4b0a418cb
Reviewed-on: https://skia-review.googlesource.com/150126
Reviewed-by: Florin Malita <fmalita@chromium.org>
Reviewed-by: Joe Gregorio <jcgregorio@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Previously, X = 1; this CL adds X = [2, 3, 4] to match the equivalent
vector support for floats.
It currently does not define any methods for setting unsigned integers
or for setting explicitly lower bit count integers.
Bug: skia:
Change-Id: Iaa1e9a6b979208a8c30b07b8ccb0792b3dd64c97
Reviewed-on: https://skia-review.googlesource.com/150261
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Michael Ludwig <michaelludwig@google.com>
Change-Id: I0b9e166d20a4c2ae9ec1afcc5de02312a4402b9a
Reviewed-on: https://skia-review.googlesource.com/150260
Auto-Submit: Brian Osman <brianosman@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
Change-Id: Idca6c0bb237d7973f84acbd2f0583cc8b6c6292c
Reviewed-on: https://skia-review.googlesource.com/150241
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
I counted twice... there are 7 pointers and 8 4-byte things.
Change-Id: I106a0f1c1bf9ee580e7b04afc763b2ec977fca3c
Reviewed-on: https://skia-review.googlesource.com/150120
Auto-Submit: Mike Klein <mtklein@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
47f6dd0d4a..1e1b731a98
git log 47f6dd0d4a21..1e1b731a9895 --date=short --no-merges --format='%ad %ae %s'
2018-08-28 jmadill@chromium.org Vulkan: Clean up point coord translation.
Created with:
gclient setdep -r third_party/externals/angle2@1e1b731a9895
The AutoRoll server is located here: https://autoroll.skia.org/r/angle-skia-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE
TBR=stephana@google.com
Change-Id: Ib8c1ac078ab9ce07a975f7b4610f4a281f3edadb
Reviewed-on: https://skia-review.googlesource.com/150220
Reviewed-by: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Change bookmaker to omit files written with unchanged
values. Temporary copies of fiddleout.json and catalog.htm
are written, and if the same as the existing copies, are
silently deleted.
Update stdout from examples in SkColor4f_Reference that
have changed to keep up with the latest checkin.
TBR=brianosman@google.com
Docs-Preview: https://skia.org/?cl=150146
Bug: skia:6898
Change-Id: I14e326bdd53baec92853d265edbe160c84583381
Reviewed-on: https://skia-review.googlesource.com/150146
Commit-Queue: Cary Clark <caryclark@skia.org>
Auto-Submit: Cary Clark <caryclark@skia.org>
Reviewed-by: Cary Clark <caryclark@skia.org>
Compared with current master:
1.26% faster in Seal_of_New_Hampshire.svg_1
1.90% faster in native_image_to_raster_surface
2.70% faster in Seal_of_Texas.svg_1
2.76% faster in WestVirginia-StateSeal.svg_1
2.80% faster in chart_aa
3.36% faster in Iowa-StateSeal.svg_1
3.44% faster in Seal_of_Illinois.svg_1
4.37% faster in Seal_of_Maryland_%28reverse%29.svg_1
4.64% faster in Minnesota-StateSeal.svg_1
5.06% faster in Seal_of_Tennessee.svg_1
16.76% faster in clip_strategy_path_100
Compared with the Skia without https://skia-review.googlesource.com/c/skia/+/146220
(no significant slowdowns for any SVGs)
4.69% slower in path_fill_big_rotated_rect_aa_45
2.50% slower in points
1.27% faster in native_image_to_raster_surface
1.39% faster in patch_square_meshlines_0.100000x0.100000
2.09% faster in path_hairline_big_noAA_line
2.62% faster in Seal_of_Maryland_%28reverse%29.svg_1
3.63% faster in rotated_rects_aa_alternating_transparent_and_opaque_darken
3.93% faster in zeroradroundrect
4.60% faster in rotated_rects_aa_same_transparent_darken
4.64% faster in ovals_1
4.73% faster in rotated_rects_aa_changing_opaque_darken
4.74% faster in rotated_rects_aa_changing_transparent_darken
5.01% faster in rotated_rects_aa_same_opaque_darken
5.07% faster in nested_aaclip_AA
6.06% faster in ovals_3
6.25% faster in dash_0_noclip
7.86% faster in rotated_rects_aa_same_transparent_src
7.86% faster in rotated_rects_aa_changing_transparent_src
9.31% faster in rrects_3
9.35% faster in rotated_rects_aa_alternating_transparent_and_opaque_src
10.95% faster in rotated_rects_aa_same_transparent_srcover
10.95% faster in rotated_rects_aa_changing_transparent_srcover
11.46% faster in rotated_rects_aa_alternating_transparent_and_opaque_srcover
11.90% faster in rotated_rects_aa_same_opaque_srcover
11.90% faster in rotated_rects_aa_changing_opaque_srcover
12.09% faster in rotated_rects_aa_same_opaque_src
12.13% faster in rotated_rects_aa_changing_opaque_src
20.89% faster in path_fill_small_triangle
Bug: skia:8272
Change-Id: Ic1434ea71660b0d3a7ddf1f63d098cfe7acfd861
Reviewed-on: https://skia-review.googlesource.com/149337
Auto-Submit: Yuqian Li <liyuqian@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
This reverts commit 8ae7c90faf.
Reason for revert: Chrome roll
Original change's description:
> Remove old ICC parser, A2B SkColorSpace, SkGammas, etc...
>
> Docs-Preview: https://skia.org/?cl=148807
> Change-Id: I2d77f6543e390c4948d57242a518af77443f0165
> Reviewed-on: https://skia-review.googlesource.com/148807
> Commit-Queue: Mike Klein <mtklein@google.com>
> Reviewed-by: Mike Klein <mtklein@google.com>
TBR=mtklein@google.com,brianosman@google.com,reed@google.com
Change-Id: I5821591b22e395327ec0cd29ec18569bf7f61859
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://skia-review.googlesource.com/150142
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
This close to branching, I'm inclined to disable this for M70.
Here is the Chrome-side CL that sets the flag:
https://chromium-review.googlesource.com/c/chromium/src/+/1193968 (
Disable mask-filtered mask caching in Skia)
Bug: 878195
Change-Id: Ifaf92fac80b75431badb52e0e5b09ccc57c08d8e
Reviewed-on: https://skia-review.googlesource.com/150080
Commit-Queue: Robert Phillips <robertphillips@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
Remove documentation, see also references, and examples
that rely on SkCanvas::drawTextOnPath(HV).
Move example that uses SkDrawTextOnPath into illustrations.
TBR=reed@google.com
Docs-Preview: https://skia.org/?cl=150020
Bug: skia:6898
Change-Id: I1d92f258b75a8a10a6aa89ebf9380871ba7ecac5
Reviewed-on: https://skia-review.googlesource.com/150020
Commit-Queue: Cary Clark <caryclark@skia.org>
Reviewed-by: Cary Clark <caryclark@skia.org>
Use EGL_EXT_protected_content extension if present to render
AHardwareBuffer with AHARDWAREBUFFER_USAGE_PROTECTED_CONTENT.
Bug: skia:
Change-Id: I1a5fa4cdc8f432b89ae9ef889175b50a25b846e0
Reviewed-on: https://skia-review.googlesource.com/149803
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Stan Iliev <stani@google.com>
Region iterators return bounds but do not initialize
the result if Iterator has no region or region is
empty.
Add general tests for empty region iterators.
R=reed@google.com,halcanary@google.com
Docs-Preview: https://skia.org/?cl=149980
Bug: skia:8186
Change-Id: If4367d4c0eef7fc9c7bfd7d1436143e155b78309
Reviewed-on: https://skia-review.googlesource.com/149980
Commit-Queue: Cary Clark <caryclark@skia.org>
Reviewed-by: Hal Canary <halcanary@google.com>
This adds 2 docker containers (based on the ones used for PathKit
added in https://skia-review.googlesource.com/c/skia/+/147042)
which bundle Chrome and puppeteer to allow the lottiecap.js
to be run anywhere.
This adds a recipe (test_lottie_web.py) to drive the docker
container and do a little bit of set-up (and a few docs/bug
fixes discovered in the test_pathkit.py that it was based on).
Additionally, this modifies lottiecap.js to support POSTing
output to a running go server (again, the same as PathKit)
which has the image data hashed and the metadata added to
a large JSON output.
This re-works driver.html to avoid re-loading the JSON object
25 times. The performance boost is important because, right now,
the lottie files are processed individually.
In a future CL, I want to address the two TODOs in
lottie-web-aggregator.go
Bug: skia:8108
Change-Id: I100c9ce23dcc5033a27287211cbf0db898960da9
Reviewed-on: https://skia-review.googlesource.com/149282
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Joe Gregorio <jcgregorio@google.com>
Reviewed-by: Stephan Altmueller <stephana@google.com>
- This bot didn't start failing the non-ERA version that was added
yesterday, so I suspect it's going to pass all versions.
- Also, the CCPR Pixel bots are continuing to fail, but it's not clear
if the non-ERA version is passing, so label the failures to find out.
Bug: skia:
Change-Id: Ib5fcb3cf03065453fe31c2a4ac8a9f2fd5bdeaf8
Reviewed-on: https://skia-review.googlesource.com/149982
Reviewed-by: Robert Phillips <robertphillips@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
In this case, even if the path matrix was only a translate, we were losing the ability to create a mask-filter key (because we were transforming the path)
Bug: skia:
Change-Id: I953d8d4e9bbcda9cc0f91cc367c028fb568b2e00
Reviewed-on: https://skia-review.googlesource.com/149981
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>
This reverts commit 5f7b5e3624.
Reason for revert: Codec CL has re-landed.
Original change's description:
> Revert "Stop conflating F16 with linear gamma"
>
> This reverts commit d1589c7213.
>
> Reason for revert: Depends on skcms CL that's been reverted.
>
> Original change's description:
> > Stop conflating F16 with linear gamma
> >
> > Note to self: I debugged this, realized that the codecs
> > need to handle A2B -> XYZ, then realized that I just need
> > to wait for https://skia-review.googlesource.com/c/skia/+/136062
> >
> > Bug: skia:
> > Change-Id: I594c22076feb3700b8a40c471a541fef5ff4e13e
> > Reviewed-on: https://skia-review.googlesource.com/137587
> > Commit-Queue: Brian Osman <brianosman@google.com>
> > Reviewed-by: Mike Klein <mtklein@google.com>
>
> TBR=mtklein@google.com,brianosman@google.com
>
> Change-Id: I6dca583697c8efd2563d30cb7ab9ef505b6903ae
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: skia:
> Reviewed-on: https://skia-review.googlesource.com/148860
> Reviewed-by: Brian Osman <brianosman@google.com>
> Commit-Queue: Brian Osman <brianosman@google.com>
TBR=mtklein@google.com,brianosman@google.com
# Not skipping CQ checks because original CL landed > 1 day ago.
Bug: skia:
Change-Id: Iee66531049843758e7ed4130b99d8df6a553d805
Reviewed-on: https://skia-review.googlesource.com/149700
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
33dab025ad..47f6dd0d4a
git log 33dab025ada1..47f6dd0d4a21 --date=short --no-merges --format='%ad %ae %s'
2018-08-28 jiajia.qin@intel.com Implement robust initialization for image texture
2018-08-28 jmadill@chromium.org Suppress TransformFeedbackNegativeAPI test on Mac AMD.
2018-08-28 xinghua.cao@intel.com ES31: support compute shader sampling on D3D backend
2018-08-28 jmadill@chromium.org Add Windows MSVC x64 builders to CQ.
Created with:
gclient setdep -r third_party/externals/angle2@47f6dd0d4a21
The AutoRoll server is located here: https://autoroll.skia.org/r/angle-skia-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE
TBR=stephana@google.com
Change-Id: I6be7e9148274153cc2803a9aa6a51c0dded70182
Reviewed-on: https://skia-review.googlesource.com/149920
Reviewed-by: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
89664843c6..33dab025ad
git log 89664843c656..33dab025ada1 --date=short --no-merges --format='%ad %ae %s'
2018-08-27 jmadill@chromium.org Add test for transform feedback state change validation.
2018-08-27 jmadill@chromium.org Inline more buffer binding calls.
2018-08-27 bryan.bernhart@intel.com Add webgl checks in GetActiveUniformsiv.
2018-08-27 syoussefi@google.com Fix dEQP_GLES3.functional.negative_api.shader.program_binary
Created with:
gclient setdep -r third_party/externals/angle2@33dab025ada1
The AutoRoll server is located here: https://autoroll.skia.org/r/angle-skia-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE
TBR=stephana@google.com
Change-Id: Id2486e3282d35eaa52a24113703b7aa31a5178aa
Reviewed-on: https://skia-review.googlesource.com/149900
Reviewed-by: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Bug: skia:
Change-Id: I0c98157ec36f056c3c1b217f3b6561e371b4f057
Reviewed-on: https://skia-review.googlesource.com/148987
Reviewed-by: Brian Osman <brianosman@google.com>
Reviewed-by: Stan Iliev <stani@google.com>
Commit-Queue: Stan Iliev <stani@google.com>
This reverts commit cbf64e3634.
Reason for revert: Ancestral CLs have re-landed.
Original change's description:
> Revert "Add support for unpremul image sources in the GPU backend"
>
> This reverts commit f06240de2c.
>
> Reason for revert: I think this requires the skcms codec change to re-land,
>
> Original change's description:
> > Add support for unpremul image sources in the GPU backend
> >
> > Change-Id: Ib940fa0d658fff0b2dd923abfcc5ca4a49b2b38b
> > Reviewed-on: https://skia-review.googlesource.com/148397
> > Commit-Queue: Brian Osman <brianosman@google.com>
> > Reviewed-by: Mike Klein <mtklein@google.com>
>
> TBR=mtklein@google.com,bsalomon@google.com,brianosman@google.com
>
> Change-Id: Ib9358cf858c3c0887322503a4b021e08a0ac4cd5
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://skia-review.googlesource.com/148861
> Reviewed-by: Brian Osman <brianosman@google.com>
> Commit-Queue: Brian Osman <brianosman@google.com>
TBR=mtklein@google.com,bsalomon@google.com,brianosman@google.com
# Not skipping CQ checks because original CL landed > 1 day ago.
Change-Id: I20d8d17f5cc6ed1a359c0f7af1c96bf5304f6885
Reviewed-on: https://skia-review.googlesource.com/149804
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
We've long interpreted null source colorspaces as sRGB.
We've also been treating null destination colorspaces as legacy,
non-color-managed drawing. Assigning dst=src in this situation
is the best way to express that.
I have reverted the changes to SkImageShader and SkBlitter_Sprite,
where we had very slightly different logic.
Change-Id: I90e5ab424aea534d83cfbecd282b6cf48b56d056
Reviewed-on: https://skia-review.googlesource.com/148996
Commit-Queue: Brian Osman <brianosman@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
