AuroraMiddleware/skia2
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
12,619 Commits 1 Branch 0 Tags 544 MiB
2983ff5da3
Commit Graph

12619 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
halcanary
2983ff5da3 CrashHandler calls strsignal on linux 
R=mtklein@google.com

Author: halcanary@google.com

Review URL: https://codereview.chromium.org/349623004
 2014-06-20 08:26:23 -07:00
mtklein
77a83962ac undefok -> bool 
BUG=skia:

not waiting for (dead?) win builder
NOTRY=True
R=reed@google.com, mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/348063002
 2014-06-20 08:24:56 -07:00
borenet
f6fb36eebc Add DEPS entry for common repo 
BUG=skia:
R=reed@google.com, rmistry@google.com

Author: borenet@google.com

Review URL: https://codereview.chromium.org/334633008
 2014-06-20 07:55:03 -07:00
borenet
a535b7beec Add common/ to .gitignore 
BUG=skia:2682
NOTRY=true
R=rmistry@google.com

Author: borenet@google.com

Review URL: https://codereview.chromium.org/342353002
 2014-06-20 07:47:36 -07:00
bsalomon
160a52ba21 Stop referencing gl_FragCoord z and w components. 
This fixes an Adreno driver bug where GL programs fail to link if the FS refers to these components of gl_FragCoord.

R=jvanverth@google.com

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/345083002
 2014-06-20 07:25:14 -07:00
egdaniel
6b8f1ba1ef Rebaseline win7-HD2000 for flaky dashing4 gm 
R=bsalomon@google.com
TBR=bsalomon@google.com

BUG=skia:

Author: egdaniel@google.com

Review URL: https://codereview.chromium.org/344853005
 2014-06-20 06:33:05 -07:00
george
ae6a059c68 Undef FloatToFixed and FixedToFloat as well in SkConvolver to avoid confusion with OS X's maths library 
BUG=skia:
R=reed@google.com

Author: george@mozilla.com

Review URL: https://codereview.chromium.org/326623004
 2014-06-20 06:32:58 -07:00
krajcevski
aed7007e9e Fix shader code 
R=bsalomon@google.com, reed@google.com
NOTREECHECKS=true
NOTRYS=true

Author: krajcevski@google.com

Review URL: https://codereview.chromium.org/347563006
 2014-06-20 05:46:12 -07:00
mtklein
fd117d8829 Port SampleApp to SkCommandLineFlags. 
BUG=skia:
R=bsalomon@google.com, mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/344873004
 2014-06-19 14:18:56 -07:00
krajcevski
f461a8fdf6 Simple GPU based dithering: 
If dithering is turned on, apply an effect that filters the pixel through
the following pipeline:

for each channel c:
  1. Compute quantized colors [low, high] that c is between
  2. Pick high by flipping a coin weighted by (c - low)

R=bsalomon@google.com, egdaniel@google.com, robertphillips@google.com

Author: krajcevski@google.com

Review URL: https://codereview.chromium.org/321253002
 2014-06-19 14:14:06 -07:00
bsalomon
8b2fac4b25 Cache the GrEffect used for text rendering in GrBitmapTextContext. 
R=jvanverth@google.com

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/338093005
 2014-06-19 14:13:45 -07:00
senorblanco
9efd66b845 Revert "Fix external SkImageFilter caching with clips." 
This reverts commit ffa9b500d7.

R=reed@google.com
TBR=reed@google.com
NOTRY=True
NOTREECHECKS=True

Author: senorblanco@chromium.org

Review URL: https://codereview.chromium.org/340413004
 2014-06-19 13:23:27 -07:00
bsalomon
3935a7bfe6 Check for degenerate edges in cubic->quad conversion called by convex path renderer. 
Cubics that are nearly degenerate now make it down here via the convex path renderer. They used to get filtered out by the path iterator but that was problematic. We wound up producing NaN vertices.

BUG=2677
R=jvanverth@google.com

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/338633007
 2014-06-19 12:33:08 -07:00
tfarina
f168b86d7f Remove Sk prefix from some bench classes. 
This idea came while commenting on
https://codereview.chromium.org/343583005/

Since SkBenchmark, SkBenchLogger and SkGMBench are not part of the Skia library,
they should not have the Sk prefix.

BUG=None
TEST=make all
R=mtklein@google.com

Author: tfarina@chromium.org

Review URL: https://codereview.chromium.org/347823004
 2014-06-19 12:32:29 -07:00
jvanverth
8e80d17d2b Reduce texture uploads for font atlas. 
Also adds upload tracing for Chrome.

R=bsalomon@google.com

Author: jvanverth@google.com

Review URL: https://codereview.chromium.org/347563005
 2014-06-19 12:01:11 -07:00
bungeman
d7f846bdd1 Add needed virtual destructors. 
These were found by the clang on Windows build.

R=mtklein@google.com

Author: bungeman@google.com

Review URL: https://codereview.chromium.org/328303005
 2014-06-19 11:26:59 -07:00
vandebo
0f9bad01b0 [PDF] Fix font embedding restrictions. 
Stop using restricted font outlines and honor don't subset restriction.

Resubmit of r12600.

R=halcanary@google.com, bungeman@google.com, reed@google.com

Author: vandebo@chromium.org

Review URL: https://codereview.chromium.org/334443002
 2014-06-19 11:05:39 -07:00
egdaniel
bbcb38df4f Allow gpu debug markers to be placed by using a GrContext 
If a marker is placed using a GrContext, it will add a marker to both the
drawBuffer and gpu targets of that context.

BUG=skia:
R=bsalomon@google.com

Author: egdaniel@google.com

Review URL: https://codereview.chromium.org/340893002
 2014-06-19 10:19:29 -07:00
mtklein
3f73e8c8d5 CrashHandler for Windows. 
Plus, print out assertion failures on Windows,
and some little tweaks to CrashHandler on other platforms for consistency.

BUG=skia:
R=bungeman@google.com, mtklein@google.com, reed@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/340523007
 2014-06-19 07:41:59 -07:00
senorblanco
373dd9b52f New Nexus4 baselines for imagefiltersclipped, GPU path. 
R=reed@google.com
TBR=reed@google.com
NOTRY=True
BUG=skia:

Author: senorblanco@chromium.org

Review URL: https://codereview.chromium.org/347693002
 2014-06-18 16:26:39 -07:00
reed
9f0147143f Revert of remove guarded code - there are no more callers (https://codereview.chromium.org/343783002/) 
Reason for revert:
webkit still uses getTotalClip -- need to find where they define the guard.

../../skia/ext/skia_utils_mac.mm:400:42: error: no member named 'getTotalClip' in 'SkCanvas'
      const SkRegion& clipRgn = canvas_->getTotalClip();
                                ~~~~~~~  ^

Original issue's description:
> remove guarded code - there are no more callers
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/c5d5cf9489977aa6fba077d1dc242029fbb4859e

R=scroggo@google.com, reed@google.com
TBR=reed@google.com, scroggo@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Author: reed@chromium.org

Review URL: https://codereview.chromium.org/342843002
 2014-06-18 15:51:20 -07:00
senorblanco
ffa9b500d7 Fix external SkImageFilter caching with clips. 
When the external cache is active, do not intersect the saveLayer
bounds with the clip bounds.  This is so that the cache is always the
full size of the primitive's bounds, regardless of the clip active on
first draw. (Drawing of the filtered or cached result is always drawn
against the active clip, though, since it is restored before
internalDrawDevice() is called.)

This is a slightly hacky solution, but this code can all go away
(including the external cache) once all platforms have switched to
impl-side painting.

See Chromium bug http://crbug.com/379147.

BUG=skia:
R=reed@google.com

Author: senorblanco@chromium.org

Review URL: https://codereview.chromium.org/340203002
 2014-06-18 15:11:25 -07:00
reed
c5d5cf9489 remove guarded code - there are no more callers 
BUG=skia:
R=scroggo@google.com

Author: reed@google.com

Review URL: https://codereview.chromium.org/343783002
 2014-06-18 14:41:26 -07:00
tfarina
bcbc1788b4 Refactor how we handle resources path in Tests. 
This idea emerged while doing https://codereview.chromium.org/321723002/
(commit 880914c35c).

BUG=None
TEST=make tests && out/Debug/tests
R=mtklein@google.com

Author: tfarina@chromium.org

Review URL: https://codereview.chromium.org/346453002
 2014-06-18 14:32:49 -07:00
reed
6518eaaefa remove legacy moz flags 
NOTRY=True
R=george@mozilla.com, scroggo@google.com

Author: reed@google.com

Review URL: https://codereview.chromium.org/342803002
 2014-06-18 14:05:22 -07:00
egdaniel
3eee3834fb Modify gpu debug markers to store gpu device markers when a flush occurs. 
BUG=skia:
R=bsalomon@google.com

Author: egdaniel@google.com

Review URL: https://codereview.chromium.org/341583002
 2014-06-18 13:09:11 -07:00
djsollen
1d7975b1c0 Remove unused class from the Android framework build 
R=reed@google.com, scroggo@google.com

Author: djsollen@google.com

Review URL: https://codereview.chromium.org/345613002
 2014-06-18 12:35:10 -07:00
mtklein
4ea2661cbd No CrashHandler for NACL bots. 
CQ_EXTRA_TRYBOTS=tryserver.skia:Build-Ubuntu13.10-GCC4.8-NaCl-Debug-Trybot

BUG=skia:
R=mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/344603005
 2014-06-18 12:29:01 -07:00
mtklein
30e6e2af14 Add basic stacktrace handler using libunwind. 
This means we will all have to apt-get install libunwind8-dev on Linux.  Mac comes with everything we need already.

BUG=skia:
R=reed@google.com, mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/343583005
 2014-06-18 11:44:18 -07:00
scroggo
f01a6c3663 In Android framework, make tools depend on jsoncpp 
Always build the tools with JSON, but either build our own
or use the system's.

Rename skia_build_json_writer to skia_use_system_jsoncpp,
since we now always build with JSON.

Remove SK_BUILD_JSON_WRITER, which was only there so
we could build without JSON it in the framework.

BUG=skia:2448
R=djsollen@google.com, reed@google.com

Author: scroggo@google.com

Review URL: https://codereview.chromium.org/303913002
 2014-06-18 10:31:40 -07:00
mtklein
b59161f000 Add SkASSERTF. 
Example failure:
fRefCnt was 3
../../../usr/local/google/home/mtklein/skia/include/core/SkRefCnt.h:40: failed assertion "(fRefCnt == 1) || (SkDebugf("fRefCnt was %d""\n", fRefCnt), false)"
Command terminated by signal 11

Not pretty, but everything's there.  Perhaps we'll think of ways to make it nicer later.

BUG=skia:
R=bsalomon@google.com, reed@google.com, mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/337243004
 2014-06-18 07:54:47 -07:00
egdaniel
12c2198535 Remove dashing from gpu veto 
With new veto our new veto test results look like the following:
TP: true positive (picked to use gpu and gpu was faster)
I: inderminate, the raster time is withing 5% of gpu time

        TP  FP  TN  FN  I

old     21  9   15  12  3
new     29  12  11  6   3

There are three skps that tend to move from TN -> FP, however
the absolute difference in their run times are not huge between
them. The largest being desk_booking which is about 7.1 raster
and 8.8 gpu. The other two skps are desk_yahooanswers and
desk_linkedin

BUG=skia:
R=bsalomon@google.com, robertphillips@google.com

Author: egdaniel@google.com

Review URL: https://codereview.chromium.org/334053005
 2014-06-18 07:34:39 -07:00
egdaniel
de10fdeee5 Add additional dashing rebaselines 
NOTRY=True
NOTREECHECK=True
R=bsalomon@google.com
TBR=bsalomon@google.com

BUG=skia:

Author: egdaniel@google.com

Review URL: https://codereview.chromium.org/347543003
 2014-06-18 07:31:08 -07:00
caryclark
e4097e3a0b Fix last pathops skp bug 
This fixes the last bug discovered by iterating through the 800K
skp corpus representing the top 1M websites. For every clip on the
stack, the paths are replaced with the pathop intersection. The
resulting draw is compared with the original draw for pixel errors.

At least two prominent bugs remain. In one, the winding value is
confused by a cubic with an inflection. In the other, a quad/cubic
pair, nearly coincident, fails to find an intersection.

These minor changes include ignoring very tiny self-intersections
of cubics, and processing degenerate edges that don't connect to
anything else.

R=reed@android.com
TBR=reed

Author: caryclark@google.com

Review URL: https://codereview.chromium.org/340103002
 2014-06-18 07:24:19 -07:00
mtklein
683e90611c Remove SkBenchmark::postDraw. 
Only one bench used this feature, and it's for things that'd be done by the
destructor anyway.

BUG=skia:
R=bsalomon@google.com, mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/329853007
 2014-06-18 07:15:49 -07:00
jcgregorio
d0eecd461d Use DNS and not hard coded IP address of the monitoring server. 
BUG=skia:
R=mtklein@google.com

Author: jcgregorio@google.com

Review URL: https://codereview.chromium.org/338873003
 2014-06-18 07:13:09 -07:00
egdaniel
00fb42704a Rebaslines from recent dashing changes 
R=bsalomon@google.com
TBR=bsalomon@google.com
BUG=skia:

Author: egdaniel@google.com

Review URL: https://codereview.chromium.org/339203003
 2014-06-18 06:56:19 -07:00
bensong
2668617ea2 Removes Record configs from buildbot bench_pictures runs. 
BUG=skia:
NOTRY=true
R=borenet@google.com, mtklein@google.com

Author: bensong@google.com

Review URL: https://codereview.chromium.org/338413002
 2014-06-18 05:59:55 -07:00
reed
1777f233bd unignore canvas-layer-state 
TBR=
NOTRY=True

Author: reed@google.com

Review URL: https://codereview.chromium.org/336273005
 2014-06-18 05:47:45 -07:00
borenet
69b61412e9 Update SKP version to 26 
Automatic commit by the RecreateSKPs bot.

TBR=

Author: borenet@google.com

Review URL: https://codereview.chromium.org/342653002
 2014-06-18 00:31:16 -07:00
bungeman
33eb30fed8 Clean up DirectWrite typeface cache matching. 
The matching code was difficult to follow due to naming issues,
and performed some duplicate work which is not wanted.
This change will either fix the associated bug or make it possible
to track the cause.

CQ_EXTRA_TRYBOTS=tryserver.skia:Test-Win7-ShuttleA-HD2000-x86-Release-DirectWrite-Trybot

BUG=384529
R=reed@google.com

Author: bungeman@google.com

Review URL: https://codereview.chromium.org/338923003
 2014-06-17 18:12:51 -07:00
mtklein
db6346a5b1 Revert of Add SSE4 optimization of S32A_Opaque_Blitrow (https://codereview.chromium.org/289473009/) 
NOTREECHECKS=true
NOTRY=true

Reason for revert:
Valgrind bot's seeing this code use uninitialized memory, and it's somehow blocking our roll into Chrome too:

> ld: warning: could not create compact unwind for
S32A_Opaque_BlitRow32_SSE4_asm:
> stack subq instruction is too different from dwarf stack size
> [10339/10982 | 3247.792] PACKAGE FRAMEWORK "Chromium Framework.framework",
> POSTBUILDS
> FAILED: ./gyp-mac-tool package-framework "Chromium Framework.framework" A &&
> (export
> BUILT_PRODUCTS_DIR=/Volumes/data/b/build/slave/mac_gpu/build/src/out/Release;
> export CONFIGURATION=Release; export CONTENTS_FOLDER_PATH="Chromium
> Framework.framework/Versions/A"; export
> DYLIB_INSTALL_NAME_BASE=@executable_path/../Versions/37.0.2056.0; export
> EXECUTABLE_NAME="Chromium Framework"; export EXECUTABLE_PATH="Chromium
> Framework.framework/Versions/A/Chromium Framework"; export
> FULL_PRODUCT_NAME="Chromium Framework.framework"; export
> INFOPLIST_PATH="Chromium Framework.framework/Versions/A/Resources/Info.plist";
> export
LD_DYLIB_INSTALL_NAME="@executable_path/../Versions/37.0.2056.0/Chromium
> Framework.framework/Chromium Framework"; export MACH_O_TYPE=mh_dylib; export
> PRODUCT_NAME="Chromium Framework"; export
> PRODUCT_TYPE=com.apple.product-type.framework; export
>
SDKROOT=/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.6.sdk;
> export
>
SRCROOT=/Volumes/data/b/build/slave/mac_gpu/build/src/out/Release/../../chrome;
> export SOURCE_ROOT="${SRCROOT}"; export
> TARGET_BUILD_DIR=/Volumes/data/b/build/slave/mac_gpu/build/src/out/Release;
> export TEMP_DIR="${TMPDIR}"; export
UNLOCALIZED_RESOURCES_FOLDER_PATH="Chromium
> Framework.framework/Versions/A/Resources"; export WRAPPER_NAME="Chromium
> Framework.framework"; (cd ../../chrome && ../build/mac/tweak_info_plist.py
> "--breakpad=1" "--breakpad_uploads=0" "--keystone=0" "--scm=1"
> "--branding=Chromium" && ln -fns Versions/Current/Libraries
> "${BUILT_PRODUCTS_DIR}/${WRAPPER_NAME}/Libraries" &&
> tools/build/mac/verify_order _ChromeMain
> "${BUILT_PRODUCTS_DIR}/${EXECUTABLE_PATH}"); G=$?; ((exit $G) || rm -rf
> 'Chromium Framework.framework') && exit $G) && touch "Chromium
> Framework.framework"
> tools/build/mac/verify_order: unordered symbols in
> /Volumes/data/b/build/slave/mac_gpu/build/src/out/Release/Chromium
> Framework.framework/Versions/A/Chromium Framework:
> S32A_Opaque_BlitRow32_SSE4_asm
> _S32A_Opaque_BlitRow32_SSE4_asm
> ninja: build stopped: subcommand failed.

Original issue's description:
> Add SSE4 optimization of S32A_Opaque_Blitrow
>
> Adds optimization of Skia S32A_Opaque_Blitrow blitter using SSE4.2 SIMD
> instruction set. Special case for when alpha is zero or opaque.
>
> Performance increase of 10%-400% compared to the existing SSE2
> optimization (measured on Silvermont architecture).
> Noticeable in ~25 different skia bench subtests, especially in
> bitmap_8888_*, repeatTile_*, and morph_*.
>
> bitmap_8888_A - 100% faster
> bitmap_8888_A_source_transparent - 250% faster
> bitmap_8888_A_source_opaque - 25% faster
> bitmap_8888_A_scale_bicubic - 75% faster
>
> Signed-off-by: Henrik Smiding <henrik.smiding@intel.com>
>
> Committed: https://skia.googlesource.com/skia/+/e2527b147679b0c43019fae7d59cc3777d2d097e
>
> Committed: https://skia.googlesource.com/skia/+/b5c281e1e06af3be804309877de1dac6145686b9

R=reed@google.com, tomhudson@google.com, djsollen@google.com, joakim.landberg@intel.com, henrik.smiding@intel.com, mtklein@chromium.org

Author: mtklein@google.com

Review URL: https://codereview.chromium.org/336413007
 2014-06-17 17:37:05 -07:00
Ben Wagner
60741912fd Rebaseline ANGLE bots. 2014-06-17 18:39:09 -04:00
Brian Salomon
08fe01362d Try to roll angle again. 
BUG=skia:2272

NOTRY=True
NOTREECHECKS=True
R=reed@google.com

Review URL: https://codereview.chromium.org/306483014
 2014-06-17 17:28:17 -04:00
fmalita
6ca763f362 More SaveFlags removal twiddling. 
This is a follow up to https://codereview.chromium.org/338913002/. More
tweaks to allow migrating clients to the new API.

1) switch the shim call direction willSave(SaveFlags) -> willSave()
   (internal users are still using the former, so external overriders of
    the latter will not be notified otherwise - doh)
2) ensure willSave() stays visible in SkProxyCanvas (Chromium's
   TimingCanvas attempts to call it explicitly).

BUG=skia:2297
R=reed@google.com

Author: fmalita@chromium.org

Review URL: https://codereview.chromium.org/334393008
 2014-06-17 13:52:18 -07:00
djsollen
dbb7b30429 Update the name of the friended android class and add the appropriate guards. 
R=scroggo@google.com, robertphillips@google.com, reed@google.com

Author: djsollen@google.com

Review URL: https://codereview.chromium.org/344473002
 2014-06-17 13:42:59 -07:00
humper
4a24cd8ff4 Fifth attempt to land faster rect blur. Remove unnecessary conditionals from the shader. 
approved over in https://codereview.chromium.org/331863006/; reuploading
because it had the wrong base url

BUG=skia:2095
R=bsalomon@google.com
TBR=bsalomon

Author: humper@google.com

Review URL: https://codereview.chromium.org/341543005
 2014-06-17 13:39:31 -07:00
Ben Wagner
9323b01e90 Update Windows baselines due to VS2013 update. 
Floating point operations now differ in the low bits from before.
 2014-06-17 16:28:20 -04:00
reed
0992d0764b rebaseline after changing labels in bitmapfilters 
TBR=
NOTRY=True
NOTREECHECKS=True

Author: reed@google.com

Review URL: https://codereview.chromium.org/340583004
 2014-06-17 12:31:49 -07:00
mtklein
887f3979f0 Add EXPERIMENTAL_beginRecording() for SkRecord-based recording. 
The interesting stuff is in SkPictureRecorder.{h,cpp}.  The rest is mostly moving SkRecord from its own directories into core to avoid circular dependencies in GYP.

After plumbing SkRecord all the way through in Picture, I'll delete its old entry point include/record/SkRecording.h.  For now it and record.gypi need to stay where they are to keep Chrome building.

BUG=skia:
R=reed@google.com, mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/331573004
 2014-06-17 12:08:16 -07:00