Commit Graph

14682 Commits

Author SHA1 Message Date
joshualitt
2f5cb2fb95 update baselines and ignores for texture_domain
TBR=
BUG=skia:

Review URL: https://codereview.chromium.org/697233003
2014-11-03 17:47:47 -08:00
mtklein
ecf987559b Turn SkTaskGroups back on.
Revert "Disable SkTaskGroup in SkMultiPictureDraw temporarily."
Revert "Revert harder, removing SkTaskGroup.cpp from core temporarily."

NOTREECHECKS=true

BUG=skia:

Committed: https://skia.googlesource.com/skia/+/2100c5ed7a5e5470a04e7af7309d8bd3fc4249f7

Review URL: https://codereview.chromium.org/687263007
2014-11-03 17:41:08 -08:00
mtklein
db8d0e5bb0 Manually load CONDITION_VARIABLE methods on Windows, checking for failure (XP).
Tested by running DM on XP.  Before this patch, it fails at startup (even just out/Debug/dm --help).  Now it asserts for other reasons later on in user code, which is just fine by me.

The net effect is that SkTaskGroups will always be synchronous on XP.  That's not ideal, but a step up from crashing.

CQ_EXTRA_TRYBOTS=client.skia:Test-Win7-ShuttleA-HD2000-x86-Release-Trybot,Test-Win7-ShuttleA-HD2000-x86_64-Release-Trybot

BUG=skia:

Review URL: https://codereview.chromium.org/700683002
2014-11-03 17:25:54 -08:00
fmalita
7c11aadd82 Export (SK_API) SkSurfaceProps
R=reed@google.com

Review URL: https://codereview.chromium.org/693973003
2014-11-03 17:07:36 -08:00
tfarina
0c9acd5d2e Cleanup: Remove SimpleiOSApp xcode project file.
There is already an GYP version for it in:
https://skia.googlesource.com/skia/+/master/gyp/SimpleiOSApp.gyp

BUG=None
TEST=None
R=caryclark@google.com

Review URL: https://codereview.chromium.org/691133004
2014-11-03 15:10:49 -08:00
reed
615c593780 move SkTextBox into utils
BUG=skia:
TBR=

Review URL: https://codereview.chromium.org/696293005
2014-11-03 14:55:40 -08:00
qiankun.miao
fb502f072f Optimize SkRect::sort()
This optimization can reduce comparison and assignments. For
geo_rect_sort benchmark, performance improved to 1.63us from 3.28us.

BUG=skia:

Review URL: https://codereview.chromium.org/695443005
2014-11-03 14:34:31 -08:00
bsalomon
87a94eb163 Rename and clarify semantics of GrContext::resolveRenderTarget.
Review URL: https://codereview.chromium.org/696293004
2014-11-03 14:28:32 -08:00
joshualitt
a702415d9e Temporary fix to remove drawrect call from GpuGL
BUG=skia:

Committed: https://skia.googlesource.com/skia/+/d4a5c2028117c100ccf44263c0118a0b4745f627

Review URL: https://codereview.chromium.org/694933002
2014-11-03 14:16:35 -08:00
jvanverth
ada68ef2dc Improve quality of distance field rendering
- Update spacing of LODs to get better results scaling up to 256
- Remove unnecessary "bolding" from dftext
- Add debug colors for dftext LODs

BUG=skia:2933,skia:2935

Review URL: https://codereview.chromium.org/703463002
2014-11-03 14:00:24 -08:00
derekf
a6ca5a002e Detect Mesa OpenGL ES
Original-Author: Henry Song <henrysong@samsung.com>

Review URL: https://codereview.chromium.org/700633002
2014-11-03 13:36:40 -08:00
bsalomon
0537f290c5 Revert changes to GrContext::resolveRenderTarget
TBR=joshualitt@google.com,egdaniel@google.com

Review URL: https://codereview.chromium.org/700483003
2014-11-03 13:32:00 -08:00
danakj
d239d42514 Add comments to SkRecordDraw to help people follow.
The calls to visit() to execute the SkRecord::Draw::operator() code path
is not clear to read, so adding some comments to help other new-comers
follow this through to the SkCanvas calls.

R=mtklein@chromium.org

Review URL: https://codereview.chromium.org/695403003
2014-11-03 12:43:30 -08:00
joshualitt
50408adfd2 Test factory uses the inorder draw buffer
BUG=skia:

Review URL: https://codereview.chromium.org/696353002
2014-11-03 12:31:15 -08:00
reed
9e233b2082 add bullets to slides
BUG=skia:
TBR=
NOTRY=True

Review URL: https://codereview.chromium.org/699723002
2014-11-03 12:18:24 -08:00
bsalomon
89c62980c1 Don't allow renderTarget==NULL to GrContext::clear() and friends.
Review URL: https://codereview.chromium.org/680413005
2014-11-03 12:08:42 -08:00
joshualitt
e672e9fca9 rebase and ignore dash cubics winnvpr
TBR=
BUG=skia:

Review URL: https://codereview.chromium.org/691803005
2014-11-03 12:03:06 -08:00
joshualitt
0b9c015bd9 release expectations rebase
TBR=

BUG=skia:

Review URL: https://codereview.chromium.org/700613002
2014-11-03 11:36:40 -08:00
joshualitt
f002af791f rebase nvpr expectations
TBR=
BUG=skia:

Review URL: https://codereview.chromium.org/688413004
2014-11-03 11:14:25 -08:00
bsalomon
bcaefb0622 Remove GrGLTexID
BUG=skia:2889

Review URL: https://codereview.chromium.org/695133003
2014-11-03 11:07:12 -08:00
joshualitt
882ee19a26 ignoring degenerat segments across all nvprm
TBR=
BUG=skia:

Review URL: https://codereview.chromium.org/696373002
2014-11-03 10:51:42 -08:00
mtklein
3eeb156822 patch from issue 697743002
working

The key here was to get everything into a single library.  Our shared library build is the easiest way to do that.  Some light skimming online makes it look like perhaps cgo requires shared libraries, so that may be at play here too.

BUG=skia:

Review URL: https://codereview.chromium.org/698943002
2014-11-03 10:45:50 -08:00
egdaniel
37b4d866b1 Force input coverage to be only a byte in gpu shaders.
Prime coverage invariant output calculations with single component

BUG=skia:

Review URL: https://codereview.chromium.org/649783003
2014-11-03 10:07:07 -08:00
bsalomon
37dd331b20 Add class GrGLTextureRenderTarget for GL texture/rendertarget objects
BUG=skia:2889

Review URL: https://codereview.chromium.org/695813003
2014-11-03 08:47:23 -08:00
tfarina
89a9ecef9e Cleanup: Remove svn.py script.
We have moved on to a git world.

BUG=None
TEST=None
R=borenet@google.com

Review URL: https://codereview.chromium.org/691203002
2014-11-03 08:33:53 -08:00
tfarina
77ae06ba7a Cleanup: Remove unnecessary forward declarations from some views files.
Cautch in
https://skia.googlesource.com/skia/+/a3a706fcd4cc9376a1223a53f57589f29d4a36ea

BUG=None
TEST=None
R=djsollen@google.com

Review URL: https://codereview.chromium.org/680253004
2014-11-03 08:31:23 -08:00
egdaniel
c5da8b9c8b Rebaselines for new colortype-xfermodes gm
TBR=bsalomon@google.com

BUG=skia:

Review URL: https://codereview.chromium.org/695343002
2014-11-03 08:26:29 -08:00
robertphillips
4d52afef5c Shrink saveLayer device bounds when it supplies an explicit bounds and has a complex paint
This CL shrinks the bound computed for saveLayers that possess both an explicit
bound and a complex paint (e.g., one that affects transparent black). In this
case the bound of the layer should be the clipped explicit bound rather then
the clip prior/after the saveLayer/restore block.

In the following the first bound is the currently computed bound
while the second is the new/desired one:

For a 100x100 picture

saveLayer (no bound, no paint) [ 0 0 100 100 ]  [ 50 50 100 100 ]
  setMatrix (translate 50, 50) [ 0 0 100 100 ] [ 50 50 100 100 ]
  saveLayer (bound of 0, 0, 50, 50 - complex paint) [ 0 0 100 100 ] [ 50 50 100 100 ]
  restore [ 0 0 100 100 ] [ 50 50 100 100 ]
restore [ 0 0 100 100 ] [ 50 50 100 100 ]

Review URL: https://codereview.chromium.org/696763002
2014-11-03 08:19:44 -08:00
robertphillips
66cad7669b Always enable layer hoisting in Skia
This will prevent bit rot of the layer hoisting code and position us better for turning this on in Chromium.

Review URL: https://codereview.chromium.org/698493002
2014-11-03 07:19:30 -08:00
skia.buildbots
f1b471a800 Update SKP version
Automatic commit by the RecreateSKPs bot.

TBR=

Review URL: https://codereview.chromium.org/692313007
2014-11-02 22:41:23 -08:00
reed
de330ffc56 add code-style for slides
BUG=skia:
TBR=

Review URL: https://codereview.chromium.org/697923002
2014-11-02 19:19:34 -08:00
skia.buildbots
181093939c Update SKP version
Automatic commit by the RecreateSKPs bot.

TBR=

Review URL: https://codereview.chromium.org/697003003
2014-11-01 22:32:12 -07:00
skia.buildbots
ae4531a127 Update SKP version
Automatic commit by the RecreateSKPs bot.

TBR=

Review URL: https://codereview.chromium.org/696103002
2014-10-31 23:17:24 -07:00
joshualitt
a393127de5 Revert of Temporary fix to remove drawrect call from GpuGL (patchset #6 id:90005 of https://codereview.chromium.org/694933002/)
Reason for revert:
patch breaks angle bots and K1

Original issue's description:
> Temporary fix to remove drawrect call from GpuGL
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/d4a5c2028117c100ccf44263c0118a0b4745f627

TBR=bsalomon@google.com,joshualitt@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Review URL: https://codereview.chromium.org/693223002
2014-10-31 16:32:22 -07:00
joshualitt
a39c5374f4 rebaseline
TBR=

BUG=skia:

Review URL: https://codereview.chromium.org/696853002
2014-10-31 16:16:56 -07:00
joshualitt
d4a5c20281 Temporary fix to remove drawrect call from GpuGL
BUG=skia:

Review URL: https://codereview.chromium.org/694933002
2014-10-31 15:49:46 -07:00
joshualitt
5c55fef032 GrContext no longer ever draws on Gpu
BUG=skia:

Committed: https://skia.googlesource.com/skia/+/7a75e5230872732e71ea99058d9afe5d4b6758b0

Review URL: https://codereview.chromium.org/683733005
2014-10-31 14:04:35 -07:00
joshualitt
92e496f96a Beginning to refactor nvpr code
BUG=skia:

Review URL: https://codereview.chromium.org/687563008
2014-10-31 13:56:50 -07:00
jvanverth
2faa228435 Some distance field text optimizations.
- Add clipRect check
- Remove creation of scalerContext to check for color fonts in canDraw()
   (no longer needed)

BUG=skia:2933

Review URL: https://codereview.chromium.org/696503004
2014-10-31 12:59:57 -07:00
joshualitt
b9e8230b50 Revert of GrContext no longer ever draws on Gpu (patchset #7 id:120001 of https://codereview.chromium.org/683733005/)
Reason for revert:
breaks some android bots

Original issue's description:
> GrContext no longer ever draws on Gpu
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/7a75e5230872732e71ea99058d9afe5d4b6758b0

TBR=bsalomon@google.com,joshualitt@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Review URL: https://codereview.chromium.org/694983002
2014-10-31 12:20:08 -07:00
joshualitt
7a75e52308 GrContext no longer ever draws on Gpu
BUG=skia:

Review URL: https://codereview.chromium.org/683733005
2014-10-31 11:34:53 -07:00
mtklein
e9f7fbfaee Revert of Turn SkTaskGroups back on. (patchset #1 id:1 of https://codereview.chromium.org/687263007/)
Reason for revert:
precautionary revert.  may have caused WinXP crashes on Chrome tree: https://code.google.com/p/chromium/issues/detail?id=429207

Original issue's description:
> Turn SkTaskGroups back on.
>
> Revert "Disable SkTaskGroup in SkMultiPictureDraw temporarily."
> Revert "Revert harder, removing SkTaskGroup.cpp from core temporarily."
>
> NOTREECHECKS=true
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/2100c5ed7a5e5470a04e7af7309d8bd3fc4249f7

TBR=reed@google.com,mtklein@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Review URL: https://codereview.chromium.org/693993002
2014-10-31 11:30:22 -07:00
joshualitt
3bdd7dce5e small fix for cache clear
BUG=skia:

Review URL: https://codereview.chromium.org/695873002
2014-10-31 08:27:39 -07:00
reed
c17c6582ec SK_USE_SCALED_FONTMETRICS for correct scaling
related blink change:
https://codereview.chromium.org/691133002

Review URL: https://codereview.chromium.org/692083002
2014-10-31 08:20:46 -07:00
jvanverth
9154dd4552 Rebaseline GMs for https://codereview.chromium.org/687283002/
BUG=skia:2935

Review URL: https://codereview.chromium.org/684833003
2014-10-31 07:16:54 -07:00
sugoi
8b602ddd59 Objects should be unrefed instead of deleted
When an error occurs reading a flattenable object, it should be unrefed instead of deleted because, in the case of SkXferMode, for example, we'd actually be deleting a cached object kept in a static array.

BUG=428789

Review URL: https://codereview.chromium.org/695633003
2014-10-31 07:16:16 -07:00
stephana
0b5fc9774f Quick and dirty test to call the C interface from GO.
BUG=skia:

Review URL: https://codereview.chromium.org/670303005
2014-10-31 07:11:19 -07:00
tfarina
38406c82b9 Cleanup: Go with SkDebugf instead of GrPrintf.
Since GrPrintf is just defined to SkDebugf, we can go with the later
directly.

BUG=None
TEST=None
R=bsalomon@google.com

Review URL: https://codereview.chromium.org/695663003
2014-10-31 07:11:12 -07:00
skia.buildbots
8955b0e524 Update SKP version
Automatic commit by the RecreateSKPs bot.

TBR=

Review URL: https://codereview.chromium.org/689833006
2014-10-31 07:06:08 -07:00
tfarina
58f467c210 Cleanup: Remove GR_ARRAY_COUNT macro.
It is defined to SK_ARRAY_COUNT, and there are no uses of it.

Lets just use the SK_ variant.

BUG=None
TEST=None
R=bsalomon@google.com

Review URL: https://codereview.chromium.org/691133003
2014-10-31 07:06:01 -07:00