Commit Graph

8246 Commits

Author SHA1 Message Date
scroggo@google.com
6f67b3b2d9 Test decoding the bounds in skimage.
Test that the bounds match the bounds from doing a pixel decode.

R=djsollen@google.com

Review URL: https://codereview.chromium.org/19587003

git-svn-id: http://skia.googlecode.com/svn/trunk@10164 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-18 20:08:26 +00:00
scroggo@google.com
826d63af97 Add test to ensure buildTileIndex stores SkStream.
PNG fails this test without https://codereview.chromium.org/19185006/

R=djsollen@google.com

Review URL: https://codereview.chromium.org/19555004

git-svn-id: http://skia.googlecode.com/svn/trunk@10163 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-18 20:06:28 +00:00
scroggo@google.com
c70a3aa39b Support decoding Gray to A8 in PNG.
Move the code which sets the filler and forces gray to rgb after
we get the config, so we can skip them if the caller wants A8.

Call set_gray_to_rgb consistently for both normal decode and subset
decode.

In PNG, prevent subset decodes from alternating configs, which
would otherwise fail.

Use SK_RESTRICT for pointers in getBitmapConfig.

Ref the SkStream input to buildTileIndex, so it will not be destroyed
before calling decodeSubset.

Convert some fields to match Skia style.

Builds on https://codereview.chromium.org/18083026/, which has not yet been checked in.

R=reed@google.com

Review URL: https://codereview.chromium.org/19185006

git-svn-id: http://skia.googlecode.com/svn/trunk@10162 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-18 20:03:15 +00:00
reed@google.com
eed6f1b76b pull mipmap class into its own (private) header
BUG=
R=scroggo@google.com

Review URL: https://codereview.chromium.org/19462007

git-svn-id: http://skia.googlecode.com/svn/trunk@10161 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-18 19:53:31 +00:00
scroggo@google.com
12d064236a Initialize config.
Unreviewed.

git-svn-id: http://skia.googlecode.com/svn/trunk@10159 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-18 19:42:35 +00:00
scroggo@google.com
1f6b995fab A8 bitmaps from JPEG are not opaque.
So do not set them to be.

Depends on https://codereview.chromium.org/19185006/

R=reed@google.com

Review URL: https://codereview.chromium.org/19613002

git-svn-id: http://skia.googlecode.com/svn/trunk@10158 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-18 19:37:46 +00:00
scroggo@google.com
f698c8262d Allow decoding JPEG into A8.
If the original image is grayscale, allow decoding into A8.

Change the size of PrefConfigTable to allow for 8bit gray, a new source config.

Add a new sampler to SkScaledBitmapSampler to 'convert' to A8.

FIXME: Should there be a dithered option for gray scale?

R=reed@google.com

Review URL: https://codereview.chromium.org/18083026

git-svn-id: http://skia.googlecode.com/svn/trunk@10157 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-18 19:34:49 +00:00
commit-bot@chromium.org
97e49e97b6 Hold on to image-filtered texture in SkGpuDevice
R=robertphillips@google.com

Author: bsalomon@google.com

Review URL: https://chromiumcodereview.appspot.com/19729006

git-svn-id: http://skia.googlecode.com/svn/trunk@10156 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-18 19:21:44 +00:00
djsollen@google.com
25a11e48e5 Add bench to test float to fixed conversion
R=reed@google.com

Review URL: https://codereview.chromium.org/19773006

git-svn-id: http://skia.googlecode.com/svn/trunk@10155 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-18 19:11:30 +00:00
bungeman@google.com
114cfbd10e Remove unimplemented Mutex() method from SkFontMgr.h.
R=reed@google.com

Review URL: https://codereview.chromium.org/19543008

git-svn-id: http://skia.googlecode.com/svn/trunk@10154 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-18 19:04:45 +00:00
epoger@google.com
627858b903 svndiff.py: add support for git checkouts
(and yes, we should probably rename the tool soon)

R=senorblanco@chromium.org

Review URL: https://codereview.chromium.org/19512002

git-svn-id: http://skia.googlecode.com/svn/trunk@10153 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-18 18:45:17 +00:00
robertphillips@google.com
d6bcfa3313 Fix for Ubuntu compiler complaint
git-svn-id: http://skia.googlecode.com/svn/trunk@10151 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-18 18:33:39 +00:00
robertphillips@google.com
2277b54e81 Yet another build fix for r10148
git-svn-id: http://skia.googlecode.com/svn/trunk@10150 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-18 18:20:20 +00:00
robertphillips@google.com
ae6b777ba6 Fix build breakages due to r10148
git-svn-id: http://skia.googlecode.com/svn/trunk@10149 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-18 18:07:39 +00:00
robertphillips@google.com
d6543e5eda Improve null gpu's memory handling
https://codereview.chromium.org/19678010/



git-svn-id: http://skia.googlecode.com/svn/trunk@10148 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-18 17:39:14 +00:00
djsollen@google.com
69feaca231 Fix Android bench bots for Xoom due to OOM errors.
BUG= 1422
BUG= 1430
R=borenet@google.com

Review URL: https://codereview.chromium.org/19672007

git-svn-id: http://skia.googlecode.com/svn/trunk@10147 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-18 17:22:30 +00:00
robertphillips@google.com
41d2532931 The rest of: Add purgeAsNeeded calls before addResource calls
https://codereview.chromium.org/19591003/



git-svn-id: http://skia.googlecode.com/svn/trunk@10146 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-18 17:12:57 +00:00
robertphillips@google.com
1622a6d950 Add purgeAsNeeded calls before addResource calls
https://codereview.chromium.org/19591003/



git-svn-id: http://skia.googlecode.com/svn/trunk@10145 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-18 17:11:45 +00:00
reed@google.com
c968315136 add FilterLevel API to SkPaint, replacing various Flag bits
BUG=
R=bsalomon@google.com

Review URL: https://codereview.chromium.org/19769005

git-svn-id: http://skia.googlecode.com/svn/trunk@10138 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-18 13:47:01 +00:00
edisonn@google.com
620edc5039 pdfviewer: fix warning in release
Review URL: https://codereview.chromium.org/19773002

git-svn-id: http://skia.googlecode.com/svn/trunk@10137 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-18 13:03:03 +00:00
rmistry@google.com
016a30d1e5 Whitespace change to trigger builds.
git-svn-id: http://skia.googlecode.com/svn/trunk@10135 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-18 11:13:51 +00:00
skia.committer@gmail.com
f7d01ce184 Sanitizing source files in Housekeeper-Nightly
git-svn-id: http://skia.googlecode.com/svn/trunk@10134 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-18 07:00:56 +00:00
commit-bot@chromium.org
6a4ba5b205 [PDF] Use SkTypeface::countGlyphs instead of getAdvancedTypefaceMetrics
resubmit r10063

BUG=1088
R=bungeman@google.com

Author: vandebo@chromium.org

Review URL: https://chromiumcodereview.appspot.com/19668002

git-svn-id: http://skia.googlecode.com/svn/trunk@10133 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-17 21:55:08 +00:00
commit-bot@chromium.org
59e16e4e1d Fix leak of GrGLTexID when its owning GrGLTexture has been abandoned.
BUG=260708
R=robertphillips@google.com

Author: bsalomon@google.com

Review URL: https://chromiumcodereview.appspot.com/19580003

git-svn-id: http://skia.googlecode.com/svn/trunk@10132 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-17 21:39:58 +00:00
commit-bot@chromium.org
a524d5ea22 Avoid lineTo() duplication in SkPath::dump().
Currently, SkPath.dump() produces duplicate entries for lineTo():

path.moveTo(0, 0);
path.lineTo(1.00000012f, 0);
path.lineTo(1.00000012f, 0);
path.lineTo(1.00000012f, 1.00000012f);
path.lineTo(1.00000012f, 1.00000012f);
path.lineTo(0, 1.00000012f);
path.lineTo(0, 1.00000012f);
path.lineTo(0, 0);
path.lineTo(0, 0);
path.close();

R=bungeman@google.com

Author: fmalita@chromium.org

Review URL: https://chromiumcodereview.appspot.com/19540004

git-svn-id: http://skia.googlecode.com/svn/trunk@10131 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-17 21:39:54 +00:00
commit-bot@chromium.org
fd03d4a829 Replace all instances of GrRect with SkRect.
And remove the typedef in GrRect.h. The same with GrIRect.

R=robertphillips@google.com

Author: tfarina@chromium.org

Review URL: https://chromiumcodereview.appspot.com/19449002

git-svn-id: http://skia.googlecode.com/svn/trunk@10130 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-17 21:39:42 +00:00
commit-bot@chromium.org
5dd567c2a5 Add getRectCount to SkRegtion
It is useful to know how many rects comprise a region,
since in some situations we can optimize code based on
the complexity of the region. For instance, if we use
SkRegion for tracking invalidation we might opt to use
the region bounds as invalidation instead of iterating
over each rect.

R=reed@google.com, tomhudson@chromium.org, caryclark@google.com, robertphillips@google.com

Author: vmpstr@chromium.org

Review URL: https://chromiumcodereview.appspot.com/19366008

git-svn-id: http://skia.googlecode.com/svn/trunk@10129 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-17 21:39:28 +00:00
egdaniel@google.com
a308883003 Add bench for hairline paths.
R=bsalomon@google.com

Review URL: https://codereview.chromium.org/19238003

git-svn-id: http://skia.googlecode.com/svn/trunk@10128 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-17 19:30:41 +00:00
zachr@google.com
d658568a82 make OpenCL optional for skpdiff
- add CPU based different pixels metric

R=djsollen@google.com

Review URL: https://codereview.chromium.org/19374006

git-svn-id: http://skia.googlecode.com/svn/trunk@10127 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-17 19:29:19 +00:00
edisonn@google.com
f8341f718f pdfviewer: fixes (indents) in input pdf spec
Review URL: https://codereview.chromium.org/19665002

git-svn-id: http://skia.googlecode.com/svn/trunk@10126 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-17 19:00:33 +00:00
skia.committer@gmail.com
eebe6f4a59 Sanitizing source files in Housekeeper-Nightly
git-svn-id: http://skia.googlecode.com/svn/trunk@10122 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-17 07:01:13 +00:00
epoger@google.com
b248dd5294 rebaseline.py: re-record already succeeding test results, just in case
TBR=borenet

Review URL: https://codereview.chromium.org/19459002

git-svn-id: http://skia.googlecode.com/svn/trunk@10121 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-17 00:09:10 +00:00
epoger@google.com
2aa5757542 in experimental/ : roll back a few expected GM image checksums, for testing
git-svn-id: http://skia.googlecode.com/svn/trunk@10120 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-16 23:49:46 +00:00
epoger@google.com
48bceed842 svndiff.py: fix --add-new for JSON-format expectations
Review URL: https://codereview.chromium.org/19444003

git-svn-id: http://skia.googlecode.com/svn/trunk@10119 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-16 23:37:01 +00:00
commit-bot@chromium.org
1836d337a8 Missed this is r9949 (Allow the resource cache to (indirectly) flush the InOrderDrawBuffer - https://codereview.chromium.org/18466005/)
R=bsalomon@google.com

Author: robertphillips@google.com

Review URL: https://chromiumcodereview.appspot.com/19401002

git-svn-id: http://skia.googlecode.com/svn/trunk@10118 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-16 22:55:03 +00:00
epoger@google.com
4b38301a57 rebaseline.py: fix --add-new for JSON files
TBR=borenet

Review URL: https://codereview.chromium.org/19415002

git-svn-id: http://skia.googlecode.com/svn/trunk@10117 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-16 21:10:54 +00:00
epoger@google.com
1ddb8abb7b experimental/json-expectations: reformat to match output of rebaseline.py
Created using reformat-json.py script from https://codereview.chromium.org/19289011

Review URL: https://codereview.chromium.org/19289012

git-svn-id: http://skia.googlecode.com/svn/trunk@10116 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-16 20:43:08 +00:00
epoger@google.com
9506226ca7 commit updated JSON expectations to experimental (based on gm-expectations at r10113)
Review URL: https://codereview.chromium.org/19399003

git-svn-id: http://skia.googlecode.com/svn/trunk@10115 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-16 20:20:04 +00:00
epoger@google.com
48b3bedfee experimental/json-expectations: mark all JSON files as plaintext, so diff tools work
git-svn-id: http://skia.googlecode.com/svn/trunk@10114 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-16 20:14:11 +00:00
epoger@google.com
61822a25d3 svndiff.py: add ability to compare before-and-after JSON files, not just raw images
This should complete step 3 of https://goto.google.com/ChecksumTransitionDetail !

R=borenet@google.com

Review URL: https://codereview.chromium.org/19112002

git-svn-id: http://skia.googlecode.com/svn/trunk@10113 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-16 18:56:32 +00:00
commit-bot@chromium.org
50df631486 NIT MASTER 9000
fixed nits

BUG=
R=robertphillips@google.com

Author: dierk@google.com

Review URL: https://chromiumcodereview.appspot.com/19394004

git-svn-id: http://skia.googlecode.com/svn/trunk@10112 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-16 18:34:14 +00:00
commit-bot@chromium.org
56799e2ee6 Add the lazy decoder from PictureFlags to SkImageDecoder
R=caryclark@google.com, scroggo@google.com

Author: sglez@google.com

Review URL: https://chromiumcodereview.appspot.com/19109002

git-svn-id: http://skia.googlecode.com/svn/trunk@10111 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-16 18:21:46 +00:00
commit-bot@chromium.org
b92f9fb0f5 More PathUtilsTest.cpp nits
Reordered the includes, changed define to a constant global var.





more PathUtils Nits

BUG=
R=robertphillips@google.com, tfarina@chromium.org

Author: dierk@google.com

Review URL: https://chromiumcodereview.appspot.com/19272014

git-svn-id: http://skia.googlecode.com/svn/trunk@10110 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-16 17:39:08 +00:00
epoger@google.com
ffcbdbfe6a rebaseline.py: add --keep-going-on-failure option, off by default
R=borenet@google.com

Review URL: https://codereview.chromium.org/18092004

git-svn-id: http://skia.googlecode.com/svn/trunk@10109 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-16 17:35:39 +00:00
commit-bot@chromium.org
40f960edc0 Fixed PathUtils nits.
Fixed PathUtils nits

BUG=
R=robertphillips@google.com

Author: dierk@google.com

Review URL: https://chromiumcodereview.appspot.com/19392002

git-svn-id: http://skia.googlecode.com/svn/trunk@10108 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-16 16:36:47 +00:00
caryclark@google.com
8d0a524a48 harden and speed up path op unit tests
PathOps tests internal routines direcctly. Check to make sure that
test points, lines, quads, curves, triangles, and bounds read from
arrays are valid (i.e., don't contain NaN) before calling the
test function.

Repurpose the test flags.
- make 'v' verbose test region output against path output
- make 'z' single threaded (before it made it multithreaded)

The latter change speeds up tests run by the buildbot by 2x to 3x.

BUG=

Review URL: https://codereview.chromium.org/19374003

git-svn-id: http://skia.googlecode.com/svn/trunk@10107 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-16 16:11:16 +00:00
zachr@google.com
92fe073efb add table pregeneration script for pmetric
R=djsollen@google.com

Review URL: https://codereview.chromium.org/19256002

git-svn-id: http://skia.googlecode.com/svn/trunk@10106 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-16 15:47:07 +00:00
bungeman@google.com
f2e7dbb09f Split TLS implementation into its own translation unit.
SkTLS has it's own header separate from SkThread, and having SkThread own
the platform implementation of SkTLS is problematic with Chromium. The
simplest way to clean this up is to put the implementation in its own set
of files, where it is also more easily found.

R=robertphillips@google.com

Review URL: https://codereview.chromium.org/19240007

git-svn-id: http://skia.googlecode.com/svn/trunk@10105 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-16 14:59:24 +00:00
tfarina@chromium.org
883fe7f8b1 Move implementation of SkFilterShader into its source file.
Since SkFilterShader has its own header file, makes more sense to have a
separate source file to implement it rather than placing it in a "random"
SkColorFilter.cpp file.

R=robertphillips@google.com

Review URL: https://codereview.chromium.org/19305004

git-svn-id: http://skia.googlecode.com/svn/trunk@10101 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-16 13:05:27 +00:00
zachr@google.com
a79d40e5ae improve convolve speed of skpdiff using direct pointers
R=djsollen@google.com

Review URL: https://codereview.chromium.org/19107002

git-svn-id: http://skia.googlecode.com/svn/trunk@10099 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-16 12:57:29 +00:00