Commit Graph

3321 Commits

Author SHA1 Message Date
vandebo@chromium.org
610f716b00 Fix four memory leaks uncovered by valgrinding gm tests.
All are triggered by PDF code.
 Two are missing unref's on SkData.
 One is a missing unref on a SkAdvancedTypefaceMetrics.
 The last is missing destruction of SkClipStack internal state.

BUG=526

Review URL: https://codereview.appspot.com/5824049

git-svn-id: http://skia.googlecode.com/svn/trunk@3386 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-03-14 18:34:15 +00:00
tomhudson@google.com
af2313e7e7 Disable overly heavy benchmark - 15x slower than any other benchmark
and not giving us particularly important information. It may be useful
to occasionally reactivate it when trying to optimize rectangle blits,
but otherwise it was a waste to have clogging up the performance bots.



git-svn-id: http://skia.googlecode.com/svn/trunk@3385 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-03-14 18:33:54 +00:00
robertphillips@google.com
bb89cda7e7 This update fixes the problem with GLX failing to find a valid configuration on Linux laptops (Issue 513).
The base issue here was that the default GLX implementation on some Linux laptops lies about its version numbering. Code in SkNativeGLContext_unix.cpp was checking the version number to avoid using FBConfigs in versions prior to 1.3 and thus incorrectly stopped processing.

To resolve this a separate configuration path has been added that uses the pre-1.3 method (i.e., XGetVisualInfo and glXGetConfig). The run-time version check has also been removed and a #define has been added to toggle between the two implementations. This allows the FBConfig method to be used with the wayward GLX implementation while the legacy method can be used with older implementations.

Please see http://codereview.appspot.com/5823049/ for more information.

git-svn-id: http://skia.googlecode.com/svn/trunk@3384 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-03-14 18:06:26 +00:00
bsalomon@google.com
71d59a495f Rebaselines from r3382 for bots that completed before bot reset.
git-svn-id: http://skia.googlecode.com/svn/trunk@3383 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-03-14 14:13:11 +00:00
bsalomon@google.com
fb4ce6fe9f Batch path draws.
THIS IS EXPECTED TO SUBTLY CHANGE ONE GM IMAGE, WILL REBASELINE.

Review URL: http://codereview.appspot.com/5796080/




git-svn-id: http://skia.googlecode.com/svn/trunk@3382 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-03-14 13:27:54 +00:00
reed@google.com
77613a5038 enable fractionalint (64bit) math in bitmap procs
git-svn-id: http://skia.googlecode.com/svn/trunk@3381 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-03-14 12:21:17 +00:00
reed@google.com
9faea3af2d add baselines
git-svn-id: http://skia.googlecode.com/svn/trunk@3380 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-03-14 12:19:00 +00:00
reed@google.com
05ebe1a20f add baselines
git-svn-id: http://skia.googlecode.com/svn/trunk@3379 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-03-14 12:17:44 +00:00
reed@google.com
95df6228d1 add baselines
git-svn-id: http://skia.googlecode.com/svn/trunk@3378 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-03-14 12:15:07 +00:00
mike@reedtribe.org
602f2272be need to pack the two values into a 32bit long
git-svn-id: http://skia.googlecode.com/svn/trunk@3377 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-03-14 02:04:40 +00:00
reed@google.com
9f79ece67d add build option to revert hairline-clipping fix from 3366
git-svn-id: http://skia.googlecode.com/svn/trunk@3376 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-03-13 17:29:54 +00:00
bungeman@google.com
f44f055db4 Rebaseline for r3374.
git-svn-id: http://skia.googlecode.com/svn/trunk@3375 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-03-13 15:42:26 +00:00
bungeman@google.com
3aacb419ca Use floats for mask table for accuracy.
http://codereview.appspot.com/5783099/



git-svn-id: http://skia.googlecode.com/svn/trunk@3374 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-03-13 14:55:12 +00:00
bsalomon@google.com
73d98aace4 Fix missing return statement
git-svn-id: http://skia.googlecode.com/svn/trunk@3373 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-03-13 14:41:19 +00:00
bsalomon@google.com
97805382d8 Add option to automatically flush GrInOrderDrawBuffer based on previewing vtx/idx request sizes
Review URL: http://codereview.appspot.com/5794079/



git-svn-id: http://skia.googlecode.com/svn/trunk@3372 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-03-13 14:32:07 +00:00
bsalomon@google.com
e3d7095c23 Change interface on GrDrawTarget to reserve vtx/idx space at same time
Review URL: https://codereview.appspot.com/5796066/


git-svn-id: http://skia.googlecode.com/svn/trunk@3371 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-03-13 12:40:53 +00:00
reed@google.com
470f07f9a9 promote floats to scalars for the fixed-point build
git-svn-id: http://skia.googlecode.com/svn/trunk@3370 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-03-12 21:31:00 +00:00
reed@google.com
c9fa63c869 don't draw in constructor (makes debugging harder)
git-svn-id: http://skia.googlecode.com/svn/trunk@3369 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-03-12 21:14:09 +00:00
reed@google.com
7b1859034f add init() method, so we don't draw in our constructor (makes debugging harder)
git-svn-id: http://skia.googlecode.com/svn/trunk@3368 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-03-12 21:13:48 +00:00
reed@google.com
0a0726542e add unittest for rev. 3366 -- clipping antihairlines
git-svn-id: http://skia.googlecode.com/svn/trunk@3367 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-03-12 21:11:18 +00:00
reed@google.com
adb2e24018 if we are extending past our clip in antihairlines, don't draw that last
row/col (setting its scale to 0), so we don't violate the clip-rule and
possibly double-draw the last pixel.



git-svn-id: http://skia.googlecode.com/svn/trunk@3366 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-03-12 20:26:17 +00:00
reed@google.com
f9f258c656 detect all masks, and don't use masksuperblitter with those
git-svn-id: http://skia.googlecode.com/svn/trunk@3364 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-03-12 16:09:06 +00:00
djsollen@google.com
8ff1e51c5a Updating SkAvoidXferMode to use new 4byte interp function.
Review URL: https://codereview.appspot.com/5795058

git-svn-id: http://skia.googlecode.com/svn/trunk@3363 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-03-12 14:39:20 +00:00
reed@google.com
6adf79746f add SkFourByteInterp256 variant, when the caller has already scaled the last
parameter to 0..256



git-svn-id: http://skia.googlecode.com/svn/trunk@3362 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-03-12 14:25:18 +00:00
bsalomon@google.com
208236d2b6 add/delete some comments to path renderer interface
Submitted by Guanqun.Lu@gmail.com

Review URL: http://codereview.appspot.com/5783060/



git-svn-id: http://skia.googlecode.com/svn/trunk@3361 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-03-12 13:15:33 +00:00
vandebo@chromium.org
188838c208 [PDF] Fix memory hungry inefficiency in pdf resource tracking.
When moving the content of a device into a PDF object like SkPDFFormXObject
or SkPDFShader does, we only need the top level resources in the new object's
resource list, not the recursive set of objects.  Otherwise, when you
put a form on a form on form, etc, references to the objects multiply.

This fixed http://crbug.com/117321

Review URL: https://codereview.appspot.com/5796048

git-svn-id: http://skia.googlecode.com/svn/trunk@3360 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-03-09 22:16:58 +00:00
bungeman@google.com
a2d8014e66 Rebaseline for r3358.
git-svn-id: http://skia.googlecode.com/svn/trunk@3359 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-03-09 20:52:05 +00:00
bungeman@google.com
d2dae96295 Use default lcd filter until we have the means to specify one.
git-svn-id: http://skia.googlecode.com/svn/trunk@3358 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-03-09 20:31:17 +00:00
reed@google.com
f444e8ccda don't flip the fractional bits (low 4) for bilerp when in kMirror_TileMode
Review URL: https://codereview.appspot.com/5795043

git-svn-id: http://skia.googlecode.com/svn/trunk@3357 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-03-09 19:59:46 +00:00
vandebo@chromium.org
54ff85c79d [PDF] Fix some fixed/float-point mismatches for image shaders.
BUG=520

Review URL: https://codereview.appspot.com/5787061

git-svn-id: http://skia.googlecode.com/svn/trunk@3356 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-03-09 17:18:50 +00:00
tomhudson@google.com
4c4337291d If we try to clip against a path and the path only contains a rect, treat it as a clip against a rect.
(Works around a performance issue: JavaScript Canvas2D API only provides canvas.clipPath(), and we don't
optimize path clips nearly as much as we can rects; this shows up more in Ganesh than in the software
rasterizer.)

http://codereview.appspot.com/5795044/



git-svn-id: http://skia.googlecode.com/svn/trunk@3355 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-03-09 16:48:20 +00:00
epoger@google.com
4ce3da5e9e whitespace change to trigger Skia buildbot
git-svn-id: http://skia.googlecode.com/svn/trunk@3354 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-03-09 11:40:45 +00:00
reed@google.com
b0b462b93b add more modes/flags to giantbitmap test
git-svn-id: http://skia.googlecode.com/svn/trunk@3353 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-03-08 22:13:39 +00:00
reed@google.com
26b73d3128 defer any drawing until our first time, so we don't do it in our
constructor (which may get called multiple times)



git-svn-id: http://skia.googlecode.com/svn/trunk@3352 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-03-08 22:13:04 +00:00
reed@google.com
a1bfa214c5 reenable vertical lcd support
git-svn-id: http://skia.googlecode.com/svn/trunk@3351 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-03-08 21:57:12 +00:00
reed@google.com
d115ca51c7 delete for now, as I rework this test
git-svn-id: http://skia.googlecode.com/svn/trunk@3350 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-03-08 20:49:27 +00:00
reed@google.com
c5039dd9f1 disable 64bit opt for now, as I debug skew failure in DRT
git-svn-id: http://skia.googlecode.com/svn/trunk@3349 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-03-08 20:48:28 +00:00
reed@google.com
411215ae2b apply FractionalInt improvement to rotated
git-svn-id: http://skia.googlecode.com/svn/trunk@3348 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-03-08 20:13:46 +00:00
bsalomon@google.com
9183216a7c use floats to compute texture matrix / coords
Review URL: http://codereview.appspot.com/5781059/



git-svn-id: http://skia.googlecode.com/svn/trunk@3347 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-03-08 19:53:02 +00:00
bungeman@google.com
ee329defb9 Rebaseline for r3344.
git-svn-id: http://skia.googlecode.com/svn/trunk@3346 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-03-08 19:49:28 +00:00
vandebo@chromium.org
d41e70de19 [PDF] Treat TTF Fonts that report zero glyphs as other font type.
Fix crbug.com/117322 crash

Patch from Arthur Hsu, Original CL: http://codereview.appspot.com/5786057/

Review URL: https://codereview.appspot.com/5792050

git-svn-id: http://skia.googlecode.com/svn/trunk@3345 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-03-08 19:41:01 +00:00
bungeman@google.com
f4f2b8010a Don't override the user's hinting level.
http://codereview.appspot.com/5792049/


git-svn-id: http://skia.googlecode.com/svn/trunk@3344 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-03-08 19:19:51 +00:00
bsalomon@google.com
d850c18fdf Turn off pedantic check that causes too much noise in GL logs.
git-svn-id: http://skia.googlecode.com/svn/trunk@3343 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-03-08 16:45:22 +00:00
bsalomon@google.com
3f5a95e974 Misc bug fix in GrInOrderDrawBuffer
Code review: http://codereview.appspot.com/5787054/



git-svn-id: http://skia.googlecode.com/svn/trunk@3342 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-03-08 16:41:42 +00:00
bsalomon@google.com
ab9e2c6fc8 Annotate overridden functions with SK_OVERRIDE in OverView class.
R=bsalomon@google.com

Signed-off-by: Thiago Farina <tfarina@chromium.org>


Committed on behalf of tfarina@chromium.org
Review URL: https://codereview.appspot.com/5752057/



git-svn-id: http://skia.googlecode.com/svn/trunk@3341 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-03-08 16:20:16 +00:00
reed@google.com
ce151d0eba return false if the typeface cannot be found
from https://codereview.appspot.com/5756059/



git-svn-id: http://skia.googlecode.com/svn/trunk@3340 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-03-08 16:10:57 +00:00
bsalomon@google.com
d510809317 Fix GrBufferAllocPool to include padding in bytes used for an allocation
Review URL: http://codereview.appspot.com/5784053/



git-svn-id: http://skia.googlecode.com/svn/trunk@3339 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-03-08 15:10:39 +00:00
reed@google.com
584493e653 disable PDF for now, until http://code.google.com/p/skia/issues/detail?id=520
is fixed



git-svn-id: http://skia.googlecode.com/svn/trunk@3338 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-03-08 14:40:07 +00:00
reed@google.com
170b769f7b add new baselines (still need to debug gpu version)
git-svn-id: http://skia.googlecode.com/svn/trunk@3337 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-03-07 21:50:37 +00:00
reed@google.com
4bc0a9db18 use higher precision (64bit) fixed-point for matrix proc
Review URL: https://codereview.appspot.com/5772044

git-svn-id: http://skia.googlecode.com/svn/trunk@3336 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-03-07 21:47:41 +00:00