robertphillips
3342d1b5a0
Add suppression for multipicturedraw_biglayer GM
...
TBR=reed@google.com
NOTRY=true
Review URL: https://codereview.chromium.org/631973002
2014-10-06 12:27:53 -07:00
robertphillips
410dd051c3
Fix some incorrect assumptions in GrLayerCache.cpp
...
Review URL: https://codereview.chromium.org/630173002
2014-10-06 12:19:50 -07:00
derekf
f4555aa53c
Create MSAA render target for blur mask texture
...
Original Author: Henry Song <henrysong@samsung.com>
Review URL: https://codereview.chromium.org/616923004
2014-10-06 12:19:12 -07:00
egdaniel
307796bc2e
Plumb OptDrawState down to VertexShaderBuilder
...
BUG=skia:
Review URL: https://codereview.chromium.org/628293002
2014-10-06 12:13:54 -07:00
robertphillips
1564dde11a
Fix multipicturedraw_biglayer GM
...
Having a layer is a prerequisite for having it be hoisted.
Review URL: https://codereview.chromium.org/632743002
2014-10-06 11:50:31 -07:00
robertphillips
0cb34b5ab6
Update baseline GM images
...
This updates the multipicturedraw_* GM images for:
Reduce overdraw in MultiPictureDraw Sierpinski GM - https://codereview.chromium.org/582633003/
Don't turn on dither for saveLayers which have no paint - https://codereview.chromium.org/619363002/
TBR=reed@google.com
NOTRY=true
Review URL: https://codereview.chromium.org/632703003
2014-10-06 11:41:04 -07:00
mtklein
e356c7f0ee
Restore a really single-threaded mode to DM.
...
Used to be:
0 -> run on main thread plus an autodetected number of extra threads (default)
N -> run on main thread plus N extra threads
Now it's:
-1 -> run on main thread plus an autodetected number of extra threads (default)
0 -> run on main thread
N -> run on main thread plus N extra threads
BUG=skia:
Review URL: https://codereview.chromium.org/636593002
2014-10-06 11:24:08 -07:00
reed
8e47478333
implement some so we can test it
...
NOTRY=True
TBR=
Review URL: https://codereview.chromium.org/629903004
2014-10-06 11:00:51 -07:00
robertphillips
2e5a986bc7
New baselines
...
New baseline images for multipicturedraw_biglayer* GMs added in (Add a MultiPictureDraw GM to exercise layer clipping - https://codereview.chromium.org/617723004/ ).
NOTRY=true
TBR=reed@google.com
Review URL: https://codereview.chromium.org/629293002
2014-10-06 10:57:14 -07:00
jvanverth
5d271f1581
Update fontcache expectations
...
TBR=reed@google.com
Review URL: https://codereview.chromium.org/634623002
2014-10-06 10:47:59 -07:00
tfarina
6b87df2997
Fix usage of SK_BUILD_* defines.
...
Since we just 'define' them, but not attribute anything to them, like
'1' for example, cpp expands it to nothing and that breaks the "#if"
clauses.
To fix that, uses "#if defined(...)" which will correctly check if your
macro name was defined or not.
BUG=skia:2850
TEST=make most
R=robertphillips@google.com
Review URL: https://codereview.chromium.org/628763005
2014-10-06 10:46:51 -07:00
humper
8d56e27ef5
a few more tweaks to the webtry setup doc
...
BUG=skia:
TBR=tfarina
Review URL: https://codereview.chromium.org/626623002
2014-10-06 09:56:14 -07:00
Greg Humphreys
bc3dbbd8fd
add environment variable to webtry local run documentation
...
BUG=skia:
Review URL: https://codereview.chromium.org/631693003
2014-10-06 12:33:32 -04:00
Greg Humphreys
de9bec4f04
Automatically resize the webtry text editor to fit the content
...
BUG=skia:
Review URL: https://codereview.chromium.org/626033004
2014-10-06 12:31:42 -04:00
Greg Humphreys
d3b7ef6c2b
fix webtry local run documentation
...
BUG=skia:
Review URL: https://codereview.chromium.org/630093002
2014-10-06 12:04:40 -04:00
reed
938dfba51d
experimental c api
...
BUG=skia:
Review URL: https://codereview.chromium.org/624973004
2014-10-06 06:08:16 -07:00
jvanverth
fa38a30897
Add GrAASmallPathRenderer.
...
Uses cached signed distance fields to render scaled and rotated versions
of small paths.
BUG=skia:2935
Review URL: https://codereview.chromium.org/589103004
2014-10-06 05:59:05 -07:00
borenet
2f6628e69c
Update SKP version to 118
...
Automatic commit by the RecreateSKPs bot.
TBR=
Review URL: https://codereview.chromium.org/630733002
2014-10-05 20:37:06 -07:00
borenet
6848e58ffc
Update SKP version to 117
...
Automatic commit by the RecreateSKPs bot.
TBR=
Review URL: https://codereview.chromium.org/632503002
2014-10-04 22:19:08 -07:00
borenet
863d19be17
Update SKP version to 116
...
Automatic commit by the RecreateSKPs bot.
TBR=
Review URL: https://codereview.chromium.org/623423002
2014-10-03 21:10:15 -07:00
tfarina
f16cd28a04
Restart webtry to pick up changes.
...
Also add webtry.db to gitignore so it does not polute `git status`.
BUG=None
TEST=None
R=humper@google.com
Review URL: https://codereview.chromium.org/626703002
2014-10-03 21:05:00 -07:00
tfarina
d0a185e5bb
Run goimports through 'go' code in bug_chomper.
...
$ cd ~/golib
$ go get code.google.com/p/go.tools/cmd/goimports
$ cd ~/skia/tools/bug_chomper/
$ ~/golib/bin/goimports -w src/
BUG=None
TEST=None
R=borenet@google.com
Review URL: https://codereview.chromium.org/624813002
2014-10-03 14:25:11 -07:00
piotaixr
f05f5a7399
Remove globals from tests/CanvasTest.cpp
...
BUG=skia:
Review URL: https://codereview.chromium.org/617093004
2014-10-03 13:26:55 -07:00
reed
37c5a815d8
Speculative revert to diagnose crash in chrome. Revert "Add SkCachedData and use it for SkMipMap"
...
This reverts commit 92561a0b99
.
crasher in question:
https://code.google.com/p/chromium/issues/detail?id=420178
Review URL: https://codereview.chromium.org/617613003
2014-10-03 13:23:31 -07:00
reed
9e96aa07db
remove unused TextBufferDirection enum
...
BUG=skia:
Review URL: https://codereview.chromium.org/621403002
2014-10-03 12:44:37 -07:00
bungeman
22edc8310c
Fix int16_t for glyphs, const glyphs, and clarify glyph loop.
...
Several places in the PDF code are using int16_t for glyphs. With
newer NotoSans fonts, all possible glyph ids are being used, so this
can lead to problems.
The PDF glyphs from text code returns the text for the glyphs if the
encoding is for glyphs. However, it returns this using an unsafe const
cast which is hiding possible bugs and preventing correct use of const
in other places.
The way the glyph loop in SkPDFDevice::drawPosText is written uses a
'--i' in the loop, which makes it appear this can loop forever. I don't
believe it can, but it is an unecessary code folding. We should also at
least assert the forward progress correctness here.
Review URL: https://codereview.chromium.org/626613002
2014-10-03 07:55:58 -07:00
robertphillips
7f1ed835e9
Reduce overdraw in MultiPictureDraw Sierpinski GM
...
As written, all the layers in the MPD Sierpinski GM are full screen. This CL bounds each layer to reduce overdraw.
This CL will cause differences in:
multipicturedraw_sierpinski_simple
multipicturedraw_sierpinski_tiled
but they are/will be suppressed in: (Don't turn on dither for saveLayers which have no paint - https://codereview.chromium.org/619363002/ )
Review URL: https://codereview.chromium.org/582633003
2014-10-03 07:29:20 -07:00
robertphillips
4611e7f479
Don't turn on dither for saveLayers which have no paint
...
Only the gpu, 565 and msaa configs of GMs in ignored-tests.txt need rebaselining.
NOTRY=true
Review URL: https://codereview.chromium.org/619363002
2014-10-03 06:53:04 -07:00
egdaniel
1a8ecdfb73
Add isSingleComponent bool to getConstantColorComponent
...
Initial step to allowing effects to use/output 1 or 4 color/coverage components. This cl doesn't change any current logic and all effects still assume they are working with 4 components.
BUG=skia:
Committed: https://skia.googlesource.com/skia/+/3b8af078281a5a20f951b9fd84f38d92b8f6217b
Review URL: https://codereview.chromium.org/608253002
2014-10-03 06:24:12 -07:00
caryclark
d751ac01a3
abort op early if path isn't parseable
...
TBR=
BUG=419649
Review URL: https://codereview.chromium.org/623943002
2014-10-03 05:36:27 -07:00
bsalomon
d012877a6d
Fix ref cnt'ing issue in GrProgramElement.
...
Drop ref on GrGpuResources when GrProgramElement loses its last ref and already has a pending execution.
BUG=skia:2889
Review URL: https://codereview.chromium.org/612293003
2014-10-03 05:31:41 -07:00
borenet
6a6567458b
Update SKP version to 115
...
Automatic commit by the RecreateSKPs bot.
TBR=
Review URL: https://codereview.chromium.org/623023002
2014-10-02 21:25:20 -07:00
reed
2cc22b8f2f
make SkMatrix::dump always available
...
BUG=skia:
TBR=
Review URL: https://codereview.chromium.org/624783002
2014-10-02 17:52:03 -07:00
reed
92561a0b99
Add SkCachedData and use it for SkMipMap
...
Review URL: https://codereview.chromium.org/592843003
2014-10-02 13:47:08 -07:00
bungeman
d51ce44d18
Handle getMemoryBase returning NULL in WriteTask.
...
DM::WriteTask::fData was changed from a data to a stream in
"SkData to SkStreamAsset to avoid unneeded copying"
https://skia.googlesource.com/skia/+/a4c6094177ebde18c706cbcfbd2013d0a088e0ee
However, DM::WriteTask::draw was not updated to handle this,
resulting in segfaults when trying to write out PDF files.
Review URL: https://codereview.chromium.org/627473002
2014-10-02 13:39:00 -07:00
mtklein
38c05871c6
Save/Restore around bench runs.
...
BUG=skia:
Review URL: https://codereview.chromium.org/619353002
2014-10-02 13:03:58 -07:00
mtklein
0a528c187a
Use +- 2B for unbounded draw ops.
...
This lets us skip a check inside SkTileGrid::insert().
BUG=skia:
Review URL: https://codereview.chromium.org/620093006
2014-10-02 13:03:53 -07:00
reed
337c2dd420
check for newSurface failure
...
BUG=skia:
Review URL: https://codereview.chromium.org/622063003
2014-10-02 12:58:49 -07:00
reed
d1f0ebd0e2
specialize setConcat for scale+translate
...
This reverts commit 2a382f5199
.
BUG=skia:
Review URL: https://codereview.chromium.org/626583002
2014-10-02 12:58:43 -07:00
robertphillips
b4b7a4c9ea
Revert of Add isSingleComponent bool to getConstantColorComponent (patchset #6 id:100001 of https://codereview.chromium.org/608253002/ )
...
Reason for revert:
Changing some GMs
Original issue's description:
> Add isSingleComponent bool to getConstantColorComponent
>
> Initial step to allowing effects to use/output 1 or 4 color/coverage components. This cl doesn't change any current logic and all effects still assume they are working with 4 components.
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/3b8af078281a5a20f951b9fd84f38d92b8f6217b
TBR=joshualitt@chromium.org ,bsalomon@google.com,reed@google.com,egdaniel@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/617853003
2014-10-02 12:12:48 -07:00
bsalomon
85d3427d49
Revert of GrContext::copyTexture->GrContext::copySurface. Add a flush writes pixel ops flag. (patchset #3 id:40001 of https://codereview.chromium.org/622663002/ )
...
Reason for revert:
Breaking GMs on some bots
Original issue's description:
> GrContext::copyTexture->GrContext::copySurface.
>
> Add a flush writes pixel ops flag.
>
> Add an explicit flush writes for GrSurface.
>
> BUG=skia:2977
>
> Committed: https://skia.googlesource.com/skia/+/cf99b00980b6c9c557e71abf1a7c9f9b21217262
TBR=robertphillips@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:2977
Review URL: https://codereview.chromium.org/621073002
2014-10-02 11:23:04 -07:00
piotaixr
e4b231428e
Caching the result of readPixelsSupported
...
The call was calling GR_GL_GetIntegerv 2 times for each readPixels
and thus was causing a loss of performance
(resubmit of issue 344793008)
Benchmark url: http://packages.gkny.fr/tst/index.html
BUG=skia:2681
Committed: https://skia.googlesource.com/skia/+/753a2964afe5661ce9b2a8ca77ca9d0aabd3173c
Committed: https://skia.googlesource.com/skia/+/8339371f1ec3c57a0741932fd96bff32c53d4e54
Review URL: https://codereview.chromium.org/364193004
2014-10-02 10:57:53 -07:00
bsalomon
cf99b00980
GrContext::copyTexture->GrContext::copySurface.
...
Add a flush writes pixel ops flag.
Add an explicit flush writes for GrSurface.
BUG=skia:2977
Review URL: https://codereview.chromium.org/622663002
2014-10-02 10:42:24 -07:00
humper
f0e2154b45
Update webtry setup docs to reflect new installation procedure
...
BUG=skia:
Review URL: https://codereview.chromium.org/626443004
2014-10-02 10:37:14 -07:00
humper
149366e884
fix sudo redirection in setup script
...
BUG=skia:
Review URL: https://codereview.chromium.org/618013004
2014-10-02 10:36:59 -07:00
egdaniel
3b8af07828
Add isSingleComponent bool to getConstantColorComponent
...
Initial step to allowing effects to use/output 1 or 4 color/coverage components. This cl doesn't change any current logic and all effects still assume they are working with 4 components.
BUG=skia:
Review URL: https://codereview.chromium.org/608253002
2014-10-02 09:57:48 -07:00
mtklein
8f8c25eabb
Demote getCount, getDepth, and clear to RTree-only methods.
...
We use them only to test RTree.
BUG=skia:
Review URL: https://codereview.chromium.org/622773003
2014-10-02 09:53:04 -07:00
mtklein
ed48ebe39e
Archive more dead code.
...
These classes were used by QuadTree, which has been archived (with prejudice).
BUG=skia:
Review URL: https://codereview.chromium.org/616963006
2014-10-02 09:06:02 -07:00
mtklein
15c7ceb6aa
TileGrid: earliest need not be a pointer anymore
...
BUG=skia:
Review URL: https://codereview.chromium.org/625573003
2014-10-02 08:50:41 -07:00
robertphillips
b1fc64b8fa
Add a MultiPictureDraw GM to exercise layer clipping
...
This adds a "biglayer" variant that creates a picture with a single big layer. The tiling composition will test whether the layer hoisting code correctly caches the layers with their clipping information.
BUG=skia:2315
Review URL: https://codereview.chromium.org/617723004
2014-10-02 08:32:43 -07:00