Commit Graph

15363 Commits

Author SHA1 Message Date
reed
2ff1fcede1 Defer saves() until they're needed
patch from issue 759443006 at patchset 40001 (http://crrev.com/759443006#ps40001)

BUG=skia:

Review URL: https://codereview.chromium.org/767333002
2014-12-11 07:07:38 -08:00
joshualitt
8da8e9d751 rebase hairlines
TBR=
BUG=skia:

Review URL: https://codereview.chromium.org/795133002
2014-12-11 06:53:34 -08:00
joshualitt
f364b61dd8 Really fix valgrind issue
TBR=
BUG=skia:

Review URL: https://codereview.chromium.org/795123002
2014-12-11 06:52:01 -08:00
scroggo
0ac8c786a5 More rebaselines.
TBR=robertphillips
BUG=skia:

Review URL: https://codereview.chromium.org/793353002
2014-12-11 06:22:32 -08:00
scroggo
dfc3a635f3 Mark nexus10 images as flaky.
TBR=robertphillips
BUG=skia:3226

Review URL: https://codereview.chromium.org/785323003
2014-12-11 06:21:50 -08:00
bungeman
90d354e448 Additional rebaselines for 3490263287.
TBR=bungeman1

Review URL: https://codereview.chromium.org/794863004
2014-12-11 03:37:37 -05:00
bungeman
3490263287 Replace use of deprecated CG methods.
OSX10.9 and iOS7.0 deprecated CGContextShowGlyphsAtPoint so a new API
should be used. OSX10.7 and iOS4.2 replace CGContextShowGlyphsAtPoint with
CTFontDrawGlyphs. OSX10.5 and iOS2.0 have CGContextShowGlyphsAtPositions
which works similarly to CTFontDrawGlyphs and has not yet been deprecated.
This change allows the use of CTFontDrawGlyphs when it is available,
falling back to CGContextShowGlyphsAtPositions when it isn't.

Review URL: https://codereview.chromium.org/770383002
2014-12-10 21:43:28 -08:00
joshualitt
294738268d Revert of Create xfer processor backend. (patchset #6 id:100001 of https://codereview.chromium.org/764643004/)
Reason for revert:
CL breaks windows DM

Original issue's description:
> Create xfer processor backend.
>
> This includes:
> -Having an actual XP stage at the end of the gl pipeline.
> -All Blending work is handled by XP until actually setting GL blend states
> -GLPrograms test to test XP
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/4dffc940c430eec66d4707490eace19c9b3f7904

TBR=bsalomon@google.com,joshualitt@chromium.org,egdaniel@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Review URL: https://codereview.chromium.org/789343002
2014-12-10 15:03:01 -08:00
joshualitt
5f9ba17a02 Revert of Add more ignore gm's for recent Xfer Processor CL (patchset #1 id:1 of https://codereview.chromium.org/786083004/)
Reason for revert:
Preventing revert of cl breaking windows DM

Original issue's description:
> Add more ignore gm's for recent Xfer Processor CL
>
> TBR=bsalomon@google.com
> NOTRY=true
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/125251133a62a07225b7119ab3ac90153ba4c58a

TBR=bsalomon@google.com,egdaniel@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Review URL: https://codereview.chromium.org/794883002
2014-12-10 14:57:56 -08:00
joshualitt
06f019fc0f Revert of Fix to set correct output type when blending when we've read dst (patchset #4 id:60001 of https://codereview.chromium.org/791143002/)
Reason for revert:
Breaks DM on windows

Original issue's description:
> Fix to set correct output type when blending when we've read dst
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/733fc2054044377e914559fa4f46db66ab7d9cea

TBR=bsalomon@google.com,egdaniel@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Review URL: https://codereview.chromium.org/795783002
2014-12-10 14:57:50 -08:00
joshualitt
bd528cdb51 fix for chrome bug with sub pixel hairlines
BUG=skia:

Review URL: https://codereview.chromium.org/796573002
2014-12-10 14:23:40 -08:00
Brian Salomon
b2fe5407df Initial baselines for tall_stretched_bitmaps GM
BUG=skia:

Review URL: https://codereview.chromium.org/789293003
2014-12-10 17:20:15 -05:00
joshualitt
8c0f615fdd Revert of Remove GP from drawstate, revision of invariant output for GP (patchset #9 id:160001 of https://codereview.chromium.org/791743003/)
Reason for revert:
breaks mac

Original issue's description:
> Remove GP from drawstate, revision of invariant output for GP
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/c6bc58eded89b0c0a36b8e20e193c200f297a0da

TBR=bsalomon@google.com,egdaniel@google.com,joshualitt@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Review URL: https://codereview.chromium.org/794843002
2014-12-10 14:12:22 -08:00
joshualitt
c6bc58eded Remove GP from drawstate, revision of invariant output for GP
BUG=skia:

Review URL: https://codereview.chromium.org/791743003
2014-12-10 13:48:57 -08:00
fmalita
04b49c3178 Don't store an SkMatrix in BitmapShaderKey.
SkMatrix makes for a poor key component due to mutable/cache fields.

Use its canonical scalars instead.

R=reed@google.com,mtklein@google.com

Review URL: https://codereview.chromium.org/792123002
2014-12-10 13:01:43 -08:00
egdaniel
733fc20540 Fix to set correct output type when blending when we've read dst
BUG=skia:

Review URL: https://codereview.chromium.org/791143002
2014-12-10 12:45:20 -08:00
joshualitt
9b33822891 fix for valgrind uninit variables
TBR=bsalomon@google.com
BUG=skia:

Review URL: https://codereview.chromium.org/793773002
2014-12-10 12:28:08 -08:00
robertphillips
da3124d05a Rebaseline imagefiltersscaled images (and rm from ignored-tests file)
Rebaselines for https://codereview.chromium.org/785893004/ (Fix MatrixImageFilter computeFastBounds)

TBR=scroggo@google.com

Review URL: https://codereview.chromium.org/794673004
2014-12-10 12:23:09 -08:00
scroggo
92392c9c36 More rebaselines.
TBR=bsalomon
BUG=skia:

Review URL: https://codereview.chromium.org/790263002
2014-12-10 12:23:03 -08:00
bungeman
5bec916cf6 Remove MULTILINE, ^, and $ from re finding actual_results.json.
MULTILINE, ^, and $ work based on the platform, but the files being
parsed are from other platforms. As a result, the current code for
extracting the actual_results.json version will not find it in
logfiles produced on Windows when run on Mac.

The code for extracting the exact actual_results.json file to use
from a logfile is itself something of a hack, as this information
should be provided ina more structured manner. This proposed
method of finding the exact file is no worse than the old one, and
in cases like above, better.

Review URL: https://codereview.chromium.org/789253002
2014-12-10 12:18:04 -08:00
fmalita
387a01a635 Detect discarded SkPictureShader pixel refs.
This doesn't address the more general problem, but reduces the race
window significantly.

BUG=440282
R=reed@google.com

Review URL: https://codereview.chromium.org/787043006
2014-12-10 12:17:58 -08:00
scroggo
f3e218c215 Rebaseline.
All these images barely differ.

TBR=bsalomon

BUG=skia:

Review URL: https://codereview.chromium.org/795673002
2014-12-10 10:53:29 -08:00
mtklein
59f939eda6 Include SkTypes.h from SkDynamicAnnotations.h
This allows us to control SK_DYNAMIC_ANNOTATIONS_ENABLED by Sk*Config.h files.
This is a no-op today, because we control it from the compiler command line.

BUG=430815

Review URL: https://codereview.chromium.org/787003003
2014-12-10 10:49:42 -08:00
mtklein
cc695fee81 Gradient shaders: make fPtsToUnit const, pre-cache getType().
This prevents races when calling fPtsToUnit.getType() from multiple threads.

This introduces a small amount of redundant code in SkTwoPointRadialGradient,
but it's probably optimized together into no extra run-time work.

BUG=437511

Review URL: https://codereview.chromium.org/793763003
2014-12-10 10:29:19 -08:00
scroggo
6cfce1b7b4 Change how SkDebugf is sent to stdout on Android.
Previously, a function was called using dlsym in skia_launcher.

Add a static initializer that changes the setting, and include that for
the tools we automate for testing.

Also only do va_copy if we actually use it.

BUG=skia:2454

Review URL: https://codereview.chromium.org/753543003
2014-12-10 10:23:06 -08:00
reed
96472deea7 dd readPixels to SkImage
patch from issue 789673007 at patchset 1 (http://crrev.com/789673007#ps1)

BUG=skia:

Review URL: https://codereview.chromium.org/793723002
2014-12-10 09:53:42 -08:00
Florin Malita
18abd1acef Suppress clipped-bitmap-shaders-clamp
Pending PDF rebaseline after c54d8db4d1

TBR=scroggo@google.com

Review URL: https://codereview.chromium.org/788143003
2014-12-10 12:23:18 -05:00
Florin Malita
c54d8db4d1 Remove SkCanvas::drawBitmapMatrix()
R=mtklein@google.com, reed@google.com, robertphillips@google.com

Review URL: https://codereview.chromium.org/789033002
2014-12-10 12:02:16 -05:00
Brian Salomon
3d6405b52d more rebaselines
Review URL: https://codereview.chromium.org/789263002
2014-12-10 11:46:46 -05:00
egdaniel
125251133a Add more ignore gm's for recent Xfer Processor CL
TBR=bsalomon@google.com
NOTRY=true

BUG=skia:

Review URL: https://codereview.chromium.org/786083004
2014-12-10 08:14:44 -08:00
robertphillips
eb33d5f7fa Add baseline images for new filterfastbounds GM
TBR=scroggo@google.com

Review URL: https://codereview.chromium.org/787423002
2014-12-10 07:53:53 -08:00
egdaniel
4dffc940c4 Create xfer processor backend.
This includes:
-Having an actual XP stage at the end of the gl pipeline.
-All Blending work is handled by XP until actually setting GL blend states
-GLPrograms test to test XP

BUG=skia:

Review URL: https://codereview.chromium.org/764643004
2014-12-10 07:43:50 -08:00
qiankun.miao
28828d00b2 Add GM for 2-rects blur which cannot break into nine-patch
BUG=skia:

Review URL: https://codereview.chromium.org/791943002
2014-12-10 07:40:36 -08:00
reed
3054be16df Remove canvas::NewRaster, and rename surface::NewRasterPMColor to N32Premul
patch from issue 781403002 at patchset 20001 (http://crrev.com/781403002#ps20001)

BUG=skia:
TBR=
re-landing after chrome fixes have landed

Review URL: https://codereview.chromium.org/784223007
2014-12-10 07:24:28 -08:00
qiankun.miao
72b0c05fc1 Add SSSE3 acceleration for S32_D16_filter_DX
With this CL, related nanobench can be improved for 565 config.
         bitmap_BGRA_8888_update_scale_bilerp   76.1us -> 46.7us        0.61x
                bitmap_BGRA_8888_scale_bilerp   78.7us ->   47us        0.6x
bitmap_BGRA_8888_update_volatile_scale_bilerp   82.7us -> 46.9us        0.57x

BUG=skia:

Review URL: https://codereview.chromium.org/788853002
2014-12-10 07:21:35 -08:00
reed
67f2eb45b9 fix surface test for gpu and codecs
BUG=skia:

Review URL: https://codereview.chromium.org/789173004
2014-12-10 06:54:06 -08:00
skia.buildbots
f9d09c969f Update SKP version
Automatic commit by the RecreateSKPs bot.

TBR=

Review URL: https://codereview.chromium.org/790073002
2014-12-09 23:29:37 -08:00
qiankun.miao
e18a530afd Add bench to measure blur rects performance
BUG=skia:

Review URL: https://codereview.chromium.org/787913002
2014-12-09 17:47:05 -08:00
skia.buildbots
933d4380eb Update SKP version
Automatic commit by the RecreateSKPs bot.

TBR=

Review URL: https://codereview.chromium.org/760943003
2014-12-09 14:59:26 -08:00
reed
7543aa2b36 add readPixels to SkSurface (later try to remove it from SkCanvas)
BUG=skia:
TBR=bsalomon, robertphilips

Review URL: https://codereview.chromium.org/789993002
2014-12-09 14:39:44 -08:00
hendrikw
9a0c7abfd7 Skia: Track the fIsWrapped separately so that we delete correctly
GrGlTextureRenderTarget inherits virtually from both GrGlRenderTarget and
GrGLTexture, which both have a 'wrap' flag.  The passed in wrap setting could
be different for the two base classes, but since it's virtually inherited,
they share the same flag, so they're either both on, or both off.

As a result, we fail to delete the frambuffer.

To fix this, we now keep a separate isWrapped flag for GrGlRenderTarget.

BUG=437998

Review URL: https://codereview.chromium.org/791493003
2014-12-09 14:26:47 -08:00
Brian Salomon
7af39f6e8d rrrrrrrrrrrreeeeeeeeeeebaseline!
Review URL: https://codereview.chromium.org/790643004
2014-12-09 17:23:46 -05:00
reed
a8918a0650 Revert of remove (dumb) canvas::NewRaster, and rename surface::NewRasterPMColor to N32Premul (patchset #3 id:40001 of https://codereview.chromium.org/790733003/)
Reason for revert:
need to update chrome first

Original issue's description:
> remove (dumb) canvas::NewRaster, and rename surface::NewRasterPMColor to N32Premul
>
> patch from issue 781403002 at patchset 20001 (http://crrev.com/781403002#ps20001)
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/2c1605a1fbaa2e35a27399a34254fb1200ec2ae6

TBR=fmalita@google.com,fmalita@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Review URL: https://codereview.chromium.org/791763002
2014-12-09 13:55:20 -08:00
joshualitt
2e3b3e369d This cl moves color and coverage off of drawstate. In an effort to keep this CL manageable, I have left the compute invariant input / output in a bit of a strange state(fixing this will be complicated).
In addition, NVPR makes this very complicated, and I haven't quite figured out a good way to handle it, so for now color and coverage DO live on optstate, but I will figure out some way to refactor that in future CLs.

BUG=skia:

Review URL: https://codereview.chromium.org/783763002
2014-12-09 13:31:15 -08:00
junov
f3c78ccf56 Adding an option for pixelated rendering in SkPictureImageFilter
BUG=skia:3209

Review URL: https://codereview.chromium.org/787073003
2014-12-09 13:07:22 -08:00
Brian Salomon
4beac74324 More N10 rebaselines
TBR=

Review URL: https://codereview.chromium.org/784413002
2014-12-09 15:48:11 -05:00
egdaniel
138aa2245f Remove unused static function skcolor_to_grcolor_nopremultiply.
BUG=skia:

Review URL: https://codereview.chromium.org/762223003
2014-12-09 12:38:51 -08:00
reed
2c1605a1fb remove (dumb) canvas::NewRaster, and rename surface::NewRasterPMColor to N32Premul
patch from issue 781403002 at patchset 20001 (http://crrev.com/781403002#ps20001)

BUG=skia:

Review URL: https://codereview.chromium.org/790733003
2014-12-09 12:33:38 -08:00
Brian Salomon
269edd5f7e Rebaseline after texture coord precision changes.
TBR=scroggo@google.com

Review URL: https://codereview.chromium.org/788903003
2014-12-09 15:29:19 -05:00
reed
a8b326c01a change SkPoint::setLength to set itself to (0,0) if it starting length is degenerate.
BUG=skia:3203
TBR=caryclark

Review URL: https://codereview.chromium.org/785933003
2014-12-09 11:50:33 -08:00