joshualitt
341400ea7b
I could create new GMs if you prefer.
...
BUG=skia:
Review URL: https://codereview.chromium.org/812163002
2014-12-18 11:54:14 -08:00
mtklein
7cdc1ee115
Add always-threaded SkRecord quilt tests.
...
Now that we're drawing tiles threaded like implside painting, remove the checks
that those lock counts are balanced. They're just not right for anyone anymore.
SkBitmaps themselves are not threadsafe (even const ones), so shallow copy them
on playback of an SkRecord. (The underlying SkPixelRefs are threadsafe.)
Simplify quilt drawing by using SkBitmap::extractSubset. No need for locking.
Bump up to 256x256 tiles. 16x16 tiles just murders performance (way too much
contention). This has the nice side effect of letting us enable a bunch more
GMs for quilt mode; they drew wrong with small tiles but exactly right with large.
BUG=171776
R=reed@google.com , mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/371023005
2014-07-07 10:41:04 -07:00
scroggo
ef470f185f
Remove brackets from gm names.
...
BUG=skia:2634
R=epoger@google.com , borenet@google.com
Author: scroggo@google.com
Review URL: https://codereview.chromium.org/307373003
2014-06-03 06:50:26 -07:00
commit-bot@chromium.org
a90c680386
Turn on quilt mode in DM.
...
- Rename TileGrid -> Quilt to avoid the name overload.
- Tag all failing GMs with kSkipTiled_Flag.
You may be wondering, do any GMs pass? Yes, some do! And that trends towards all of them as we increase --quiltTile.
Two GMs only fail in --quilt mode in 565. Otherwise all GMs which fail are skipped, and those which don't fail aren't. (The 8888 variants of those two GMs are skipped even though they pass.)
BUG=skia:2477
R=reed@google.com , mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/256373002
git-svn-id: http://skia.googlecode.com/svn/trunk@14457 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-30 13:20:45 +00:00
commit-bot@chromium.org
3d8bf232bd
Fast path for blurred round rects -- blur a small 9patch rect on the CPU
...
And nonlinearly stretch the resulting texture across proxy geometry.
BUG=
Committed: http://code.google.com/p/skia/source/detail?r=14392
Committed: http://code.google.com/p/skia/source/detail?r=14404
R=bsalomon@google.com , reed@google.com
Author: humper@google.com
Review URL: https://codereview.chromium.org/248613004
git-svn-id: http://skia.googlecode.com/svn/trunk@14420 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-28 19:49:24 +00:00
commit-bot@chromium.org
55aec08681
revert humper changes
...
https://skia.googlesource.com/skia.git/+/24e91ba3029a3a1fb60cab3ae4e68c3c44776f25
https://skia.googlesource.com/skia.git/+/a36c78240e14aeb130a97c43f3992ea19696b929
NOTREECHECKS=true
BUG=skia:
R=caryclark@google.com , mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/256803011
git-svn-id: http://skia.googlecode.com/svn/trunk@14414 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-28 18:21:24 +00:00
commit-bot@chromium.org
e396455d2d
move common blur types into central header
...
BUG=skia:
R=scroggo@google.com , djsollen@google.com
Author: reed@google.com
Review URL: https://codereview.chromium.org/253833002
git-svn-id: http://skia.googlecode.com/svn/trunk@14411 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-28 16:25:35 +00:00
commit-bot@chromium.org
24e91ba302
Fast path for blurred round rects -- blur a small 9patch rect on the CPU
...
And nonlinearly stretch the resulting texture across proxy geometry.
BUG=
Committed: http://code.google.com/p/skia/source/detail?r=14392
R=bsalomon@google.com , reed@google.com
Author: humper@google.com
Review URL: https://codereview.chromium.org/248613004
git-svn-id: http://skia.googlecode.com/svn/trunk@14404 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-28 15:09:14 +00:00
commit-bot@chromium.org
c76a4b2a81
Revert of Fast path for blurred round rects -- blur a small 9patch rect on the CPU ( https://codereview.chromium.org/248613004/ )
...
Reason for revert:
Looks like this causes unit tests to fail with a zero constructor like this one: http://108.170.220.120:10117/builders/Test-Win7-ShuttleA-HD2000-x86-Release/builds/2326/steps/RunTests/logs/stdio
Original issue's description:
> Fast path for blurred round rects -- blur a small 9patch rect on the CPU
> And nonlinearly stretch the resulting texture across proxy geometry.
>
> BUG=
>
> Committed: http://code.google.com/p/skia/source/detail?r=14392
R=bsalomon@google.com , reed@google.com , humper@google.com
TBR=bsalomon@google.com , humper@google.com , reed@google.com
NOTREECHECKS=true
NOTRY=true
BUG=
Author: caryclark@google.com
Review URL: https://codereview.chromium.org/258893010
git-svn-id: http://skia.googlecode.com/svn/trunk@14400 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-28 14:44:54 +00:00
commit-bot@chromium.org
5729387fe0
Fast path for blurred round rects -- blur a small 9patch rect on the CPU
...
And nonlinearly stretch the resulting texture across proxy geometry.
BUG=
R=bsalomon@google.com , reed@google.com
Author: humper@google.com
Review URL: https://codereview.chromium.org/248613004
git-svn-id: http://skia.googlecode.com/svn/trunk@14392 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-28 13:19:23 +00:00
commit-bot@chromium.org
73cb15351f
Make sure SkDrawLooper objects can only be allocated on the heap.
...
Make constructors of SkLayerDrawLooper and SkBlurDrawLooper non-public.
Remove addLayer* methods from SkLayerDrawLooper. SkLayerDrawLooper::Builder is
used to create new objects.
Provide factory method for creating SkBlurDrawLooper.
BUG=2141
R=scroggo@google.com , reed@google.com , djsollen@google.com
Author: dominikg@chromium.org
Review URL: https://codereview.chromium.org/232913003
git-svn-id: http://skia.googlecode.com/svn/trunk@14200 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-15 15:48:36 +00:00
reed@google.com
48f31bdbb3
try to deprecate fFlagsMask from SkLayerDrawLooper
...
We think we want to move around how flags/fields like linearText and strikeThru
are specified. SkPaint has helpers for nearly all of these, but LayerInfo in
the draw looper just exposes the raw bitfield.
On survey of chrome/android, it appears that no one uses those, so it may be
safe to just remove the feature entirely from the looper.
R=bungeman@google.com , scroggo@google.com
Review URL: https://codereview.chromium.org/181433009
git-svn-id: http://skia.googlecode.com/svn/trunk@13607 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-02-27 14:27:44 +00:00
commit-bot@chromium.org
4b413c8bb1
remove SkFloatToScalar macro
...
BUG=
R=reed@google.com , djsollen@google.com
Author: caryclark@google.com
Review URL: https://codereview.chromium.org/85463005
git-svn-id: http://skia.googlecode.com/svn/trunk@12385 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-25 19:44:07 +00:00
robertphillips@google.com
6c1e49af8d
Removed deprecated API calls that have crept in
...
git-svn-id: http://skia.googlecode.com/svn/trunk@12210 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-10 15:08:45 +00:00
epoger@google.com
7e6e80a6eb
blurroundrect gm: disable one set of tests in attempt to fix bug
...
BUG=skia:1801
R=scroggo@google.com
Review URL: https://codereview.chromium.org/61073002
git-svn-id: http://skia.googlecode.com/svn/trunk@12146 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-05 22:04:53 +00:00
scroggo@google.com
4ef88a213b
Fix overzealous IntToScalar.
...
git-svn-id: http://skia.googlecode.com/svn/trunk@12145 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-05 21:22:04 +00:00
scroggo@google.com
8610d2cdbd
Fixes for blurroundrect gm/bench.
...
Simplify naming/various cases.
Have an atlas of gms, rather than several different images.
In the bench, pull non rendering out of the loop.
Use meaningful enums instead of integers where appropriate.
Add comments.
Addresses comments in https://codereview.chromium.org/52793005/
R=robertphillips@google.com
Review URL: https://codereview.chromium.org/59983004
git-svn-id: http://skia.googlecode.com/svn/trunk@12144 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-05 21:10:58 +00:00
scroggo@google.com
9d3c422ea6
Int to scalar (again)
...
git-svn-id: http://skia.googlecode.com/svn/trunk@12139 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-05 17:29:23 +00:00
scroggo@google.com
770269d962
More IntToScalars
...
Fix build.
git-svn-id: http://skia.googlecode.com/svn/trunk@12137 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-05 17:02:07 +00:00
scroggo@google.com
5fdef98f62
Build fix number 2.
...
Use SkColors instead of numbers.
git-svn-id: http://skia.googlecode.com/svn/trunk@12135 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-05 16:28:38 +00:00
scroggo@google.com
28f43dbee2
Fix build.
...
Fix some warnings.
git-svn-id: http://skia.googlecode.com/svn/trunk@12134 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-05 16:19:32 +00:00
scroggo@google.com
7b05659072
Add gms and benchmarks for drawing blurry round rects.
...
Further changes (https://codereview.chromium.org/48623006 ) will change
the speed at which the bench draws and the drawing of the gm (the gm
change is small).
One of these round rects causes slow drawing in a webpage that we have
observed.
BUG=https://b.corp.google.com/issue?id=11174385
Review URL: https://codereview.chromium.org/52793005
git-svn-id: http://skia.googlecode.com/svn/trunk@12133 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-05 15:57:21 +00:00