Commit Graph

55883 Commits

Author SHA1 Message Date
John Stiles
7bf799956d Reland "Add format-specifier warnings to SkDebugf."
This is a reland of e58831cd95

Original change's description:
> Add format-specifier warnings to SkDebugf.
>
> This CL fixes up many existing format-specifier violations in Skia.
> Note that GCC has a warning for formatting nothing, so existing calls to
> `SkDebugf("")` have been removed, or replaced with `SkDebugf("%s", "")`.
> These were apparently meant to be used as a place to set a breakpoint.
>
> Some of our clients also use SkDebug with bad format specifiers, so this
> check is currently only enabled when SKIA_IMPLEMENTATION is true.
>
> Change-Id: I8177a1298a624c6936adc24e0d8f481362a356d0
> Bug: skia:12143
> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/420902
> Auto-Submit: John Stiles <johnstiles@google.com>
> Commit-Queue: Brian Osman <brianosman@google.com>
> Reviewed-by: Brian Osman <brianosman@google.com>

Bug: skia:12143
Change-Id: Id3c0c21436ebd13899908d5ed5d44c42a0e23921
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/421918
Commit-Queue: John Stiles <johnstiles@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
2021-06-25 17:57:43 +00:00
John Stiles
9a1c5be4d4 Fix class name in debug message.
Change-Id: Id0e727b58e7415a28bb67ae0c1bc03f953fb4e9c
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/421926
Commit-Queue: John Stiles <johnstiles@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
Auto-Submit: John Stiles <johnstiles@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
2021-06-25 17:53:49 +00:00
Brian Osman
36ddc4de79 Roll ICU
Picks up python3 fixes for make_data_assembly

Change-Id: I9bb46ef08d30c951f12d7c427c7cbdabcfaa41e3
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/421924
Reviewed-by: Ben Wagner <bungeman@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
2021-06-25 17:40:19 +00:00
Brian Osman
b384eb204c Convert shape-clipping FPs to GrSkSLFP
Change-Id: Ic574939fd37dd9ded9868d3ffa9ac962140fb66c
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/421537
Commit-Queue: Brian Osman <brianosman@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
Reviewed-by: Chris Dalton <csmartdalton@google.com>
2021-06-25 17:08:39 +00:00
Brian Osman
65b4597d07 Reland "Replace some gradient .fps with runtime FPs"
This reverts commit 16c0791a5a.

Reason for revert: Only errors are AMD+ANGLE+D3D9+ES2

Original change's description:
> Revert "Replace some gradient .fps with runtime FPs"
>
> This reverts commit 68d6983acd.
>
> Reason for revert: Going to investigate some bad ANGLE_D3D_ES2 images.
>
> Original change's description:
> > Replace some gradient .fps with runtime FPs
> >
> > Change-Id: Ia00f88d00c6010d87c775acd32493673020d5ae8
> > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/420577
> > Commit-Queue: Brian Osman <brianosman@google.com>
> > Reviewed-by: Michael Ludwig <michaelludwig@google.com>
>
> TBR=bsalomon@google.com,brianosman@google.com,michaelludwig@google.com
>
> Change-Id: If57772f0e2d5236c5122f3c7fe261c0a59f3b141
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/421920
> Reviewed-by: Brian Osman <brianosman@google.com>
> Commit-Queue: Brian Osman <brianosman@google.com>

# Not skipping CQ checks because this is a reland.

Change-Id: I3903a23ab08c256303ee14814f16b4d2e1cbc642
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/421928
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
2021-06-25 17:05:49 +00:00
Herb Derby
d253088fc2 Fix float to bool implicit cast
Simple fix as request by Cobalt...
https://lbshell-internal-review.git.corp.google.com/c/third_party/skia/+/100156/1/include/core/SkMatrix.h

Change-Id: Iac3de1d674aec6693b10a85db2f3cd4e36365687
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/421538
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Herb Derby <herb@google.com>
2021-06-25 15:36:39 +00:00
Mike Reed
f74eea7488 Refactor textToGlyphs closer to the source
Bug: skia:12113
Change-Id: I61c5789885a31d23c583227481afa87e7e784c7a
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/421919
Reviewed-by: Ben Wagner <bungeman@google.com>
Reviewed-by: Florin Malita <fmalita@chromium.org>
Commit-Queue: Mike Reed <reed@google.com>
2021-06-25 15:22:50 +00:00
Brian Salomon
eac233ac2a Make transferability a per-format flag in GrGLCaps
Add workaround for 16 bit unorm on freedreno

Make sure callsites are checking for transfer alignment
of 0 to indicate unsupported.

Bug: skia:11876
Change-Id: Ia1c22a430f675fc57724f220f5dee5b23f325f3c
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/421317
Commit-Queue: Brian Salomon <bsalomon@google.com>
Reviewed-by: Greg Daniel <egdaniel@google.com>
2021-06-25 15:22:39 +00:00
John Stiles
65f65465eb Add methods to SkBlenderBase to identify SkBlendMode-based blends.
Change-Id: Ia0ef90dd62b15f679791be6b9d14ed24a59ea8af
Bug: skia:12080
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/420821
Commit-Queue: John Stiles <johnstiles@google.com>
Auto-Submit: John Stiles <johnstiles@google.com>
Reviewed-by: Mike Reed <reed@google.com>
2021-06-25 15:07:29 +00:00
Greg Daniel
28bea445a5 Revert "Reland "Round up DMSAA attachments to pow2 if supported.""
This reverts commit 9c81a4b704.

Reason for revert: still broken on dmsaa

Original change's description:
> Reland "Round up DMSAA attachments to pow2 if supported."
>
> This reverts commit fe788f9cd2.
>
> Reason for revert: maybe works now
>
> Original change's description:
> > Revert "Round up DMSAA attachments to pow2 if supported."
> >
> > This reverts commit c3e8a7eeb6.
> >
> > Reason for revert: breaks dmsaa clip_shader_persp and complexclip4_aa
> >
> > Original change's description:
> > > Round up DMSAA attachments to pow2 if supported.
> > >
> > > Change-Id: I03f5ea649209b9894753c981872edbd7d718288c
> > > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/408643
> > > Reviewed-by: Brian Salomon <bsalomon@google.com>
> > > Commit-Queue: Greg Daniel <egdaniel@google.com>
> >
> > TBR=egdaniel@google.com,bsalomon@google.com,csmartdalton@google.com
> >
> > Change-Id: I3ff0931d7d00b064b5721a2593d2e9865e8edebc
> > No-Presubmit: true
> > No-Tree-Checks: true
> > No-Try: true
> > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/408896
> > Reviewed-by: Greg Daniel <egdaniel@google.com>
> > Commit-Queue: Greg Daniel <egdaniel@google.com>
>
> # Not skipping CQ checks because original CL landed > 1 day ago.
>
> Change-Id: Id4c9f49c9ee5bbc1c19ededf4ee911942c67f204
> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/421320
> Reviewed-by: Greg Daniel <egdaniel@google.com>
> Reviewed-by: Brian Salomon <bsalomon@google.com>
> Commit-Queue: Greg Daniel <egdaniel@google.com>

TBR=egdaniel@google.com,bsalomon@google.com,csmartdalton@google.com

Change-Id: I1d8b2512c1d933084904952faf383907a2a57ec5
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/421925
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Greg Daniel <egdaniel@google.com>
2021-06-25 15:06:31 +00:00
Brian Osman
16c0791a5a Revert "Replace some gradient .fps with runtime FPs"
This reverts commit 68d6983acd.

Reason for revert: Going to investigate some bad ANGLE_D3D_ES2 images.

Original change's description:
> Replace some gradient .fps with runtime FPs
>
> Change-Id: Ia00f88d00c6010d87c775acd32493673020d5ae8
> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/420577
> Commit-Queue: Brian Osman <brianosman@google.com>
> Reviewed-by: Michael Ludwig <michaelludwig@google.com>

TBR=bsalomon@google.com,brianosman@google.com,michaelludwig@google.com

Change-Id: If57772f0e2d5236c5122f3c7fe261c0a59f3b141
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/421920
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
2021-06-25 14:33:51 +00:00
John Stiles
bef379ba62 Add SkBlendModeBlender class.
This is an SkBlender type which represents a traditional Skia blend mode
(from the SkBlendMode enum).

Change-Id: I7c74395be70584e11a5f1445b7f6cacfff35c532
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/420817
Commit-Queue: Mike Reed <reed@google.com>
Auto-Submit: John Stiles <johnstiles@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
Reviewed-by: Mike Reed <reed@google.com>
2021-06-25 13:55:59 +00:00
Tyler Denniston
283dba5785 Revert "Add format-specifier warnings to SkDebugf."
This reverts commit e58831cd95.

Reason for revert: looks like breaking a few build bots

Original change's description:
> Add format-specifier warnings to SkDebugf.
>
> This CL fixes up many existing format-specifier violations in Skia.
> Note that GCC has a warning for formatting nothing, so existing calls to
> `SkDebugf("")` have been removed, or replaced with `SkDebugf("%s", "")`.
> These were apparently meant to be used as a place to set a breakpoint.
>
> Some of our clients also use SkDebug with bad format specifiers, so this
> check is currently only enabled when SKIA_IMPLEMENTATION is true.
>
> Change-Id: I8177a1298a624c6936adc24e0d8f481362a356d0
> Bug: skia:12143
> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/420902
> Auto-Submit: John Stiles <johnstiles@google.com>
> Commit-Queue: Brian Osman <brianosman@google.com>
> Reviewed-by: Brian Osman <brianosman@google.com>

TBR=brianosman@google.com,ethannicholas@google.com,johnstiles@google.com

Change-Id: I07848c1bf8992925c9498e916744d0840355a077
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: skia:12143
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/421917
Reviewed-by: Tyler Denniston <tdenniston@google.com>
Commit-Queue: Tyler Denniston <tdenniston@google.com>
2021-06-25 13:33:10 +00:00
Brian Osman
68d6983acd Replace some gradient .fps with runtime FPs
Change-Id: Ia00f88d00c6010d87c775acd32493673020d5ae8
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/420577
Commit-Queue: Brian Osman <brianosman@google.com>
Reviewed-by: Michael Ludwig <michaelludwig@google.com>
2021-06-25 13:08:49 +00:00
John Stiles
e58831cd95 Add format-specifier warnings to SkDebugf.
This CL fixes up many existing format-specifier violations in Skia.
Note that GCC has a warning for formatting nothing, so existing calls to
`SkDebugf("")` have been removed, or replaced with `SkDebugf("%s", "")`.
These were apparently meant to be used as a place to set a breakpoint.

Some of our clients also use SkDebug with bad format specifiers, so this
check is currently only enabled when SKIA_IMPLEMENTATION is true.

Change-Id: I8177a1298a624c6936adc24e0d8f481362a356d0
Bug: skia:12143
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/420902
Auto-Submit: John Stiles <johnstiles@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
2021-06-25 11:05:59 +00:00
skia-autoroll
3a35f0b263 Roll ANGLE from 4375d6c732ef to c24494415a1a (17 revisions)
4375d6c732..c24494415a

2021-06-24 gert.wollny@collabora.com Capture/Replay: Make sure EGLImageKHR is a parsable number
2021-06-24 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from f0a9f88dd5cb to 8f075627d16b (1 revision)
2021-06-24 angle-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 5fbfa253f282 to e0136f0880da (7 revisions)
2021-06-24 gert.wollny@collabora.com Capture: Add capturing of framebuffer and renderbuffer IDs
2021-06-24 gert.wollny@collabora.com Capture: Add a specialization for const GLuint *
2021-06-24 gert.wollny@collabora.com Capture: read four values for GL_TEXTURE_CROP_RECT_OES
2021-06-24 gert.wollny@collabora.com Capture/Replay: Capture (Get)TexParameterxv
2021-06-24 gert.wollny@collabora.com Capture/Replay: Capture params of (Get)TexEnv calls
2021-06-24 gert.wollny@collabora.com Capture/Replay: implement CapturePointParameterfv_params
2021-06-24 gert.wollny@collabora.com Capture/Replay: Enable MatrixModeTest.InitialState
2021-06-24 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from bbc918ca9021 to fa6954ae7bb5 (441 revisions)
2021-06-24 gert.wollny@collabora.com Capture/Replay: Capture glGetLightfv parameter
2021-06-24 gert.wollny@collabora.com Capture/Replay: Add capture for Fogfv parameters
2021-06-24 gert.wollny@collabora.com Capture: Only capture texels of initialized textures
2021-06-24 gert.wollny@collabora.com Capture/Relplay: Enable most of ImageTest.*
2021-06-24 gert.wollny@collabora.com Capture: Add specialization for ParamType::TGLubyte
2021-06-24 gert.wollny@collabora.com Capture: Add support for capturing (Get)ClipPlanef equation

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-skia-autoroll
Please CC tdenniston@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: skia/skia.primary:Build-Debian10-Clang-x86_64-Release-ANGLE;skia/skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-Golo-GPU-QuadroP400-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC8i5BEK-GPU-IntelIris655-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE
Tbr: tdenniston@google.com
Change-Id: Ie4f2b85971f0bea429aa1b02b8a9534103e868e9
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/421698
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2021-06-25 05:17:42 +00:00
skia-autoroll
cb31620357 Roll Dawn from 75c5067ed12e to a9faf7f74aef (5 revisions)
https://dawn.googlesource.com/dawn.git/+log/75c5067ed12e..a9faf7f74aef

2021-06-24 enga@chromium.org Fix misplaced ASSERT in bind group validation
2021-06-24 enga@chromium.org Add scoped autoreleasepool to tests and examples
2021-06-24 cwallez@chromium.org Roll third_party/swiftshader/ 4a304244d..8f075627d (2 commits)
2021-06-24 cjj19970505@live.cn Add UWP compilation support in CMake
2021-06-24 zhaoming.jiang@intel.com Validate the buffer offset in T2B and B2T for depth/stencil texture

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dawn-skia-autoroll
Please CC rharrison@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: skia/skia.primary:Build-Debian10-Clang-x86_64-Debug-Dawn
Bug: None
Tbr: rharrison@google.com
Change-Id: Idf51b0330e272209378a502dffd40a5fbf106c22
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/421699
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2021-06-25 05:09:42 +00:00
Greg Daniel
0b04b6b16f Reland "Fix texture barriers on DMSAA"
This reverts commit 9a2d3d1e19.

Reason for revert: relanding with fix

Original change's description:
> Revert "Fix texture barriers on DMSAA"
>
> This reverts commit 1a3f4ab490.
>
> Reason for revert: breaking dmsaa test on intel hd405, https://ci.chromium.org/raw/build/logs.chromium.org/skia/54538c41f1c1b111/+/annotations
>
> Original change's description:
> > Fix texture barriers on DMSAA
> >
> > Bug: skia:11396
> > Change-Id: Iad74958c05ed086fe85656b9dc5418d5ab4589e7
> > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/419838
> > Commit-Queue: Greg Daniel <egdaniel@google.com>
> > Reviewed-by: Chris Dalton <csmartdalton@google.com>
> > Reviewed-by: Brian Salomon <bsalomon@google.com>
>
> TBR=egdaniel@google.com,bsalomon@google.com,csmartdalton@google.com
>
> Change-Id: I8be8107a98584dfb7f831a296078753fecfcebcf
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: skia:11396
> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/421056
> Reviewed-by: Greg Daniel <egdaniel@google.com>
> Commit-Queue: Greg Daniel <egdaniel@google.com>

# Not skipping CQ checks because this is a reland.

Bug: skia:11396
Change-Id: I6c65a3639e87b32a30774f33445bb3174a4fdffa
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/421058
Reviewed-by: Chris Dalton <csmartdalton@google.com>
Commit-Queue: Greg Daniel <egdaniel@google.com>
2021-06-25 01:35:42 +00:00
Greg Daniel
9c81a4b704 Reland "Round up DMSAA attachments to pow2 if supported."
This reverts commit fe788f9cd2.

Reason for revert: maybe works now

Original change's description:
> Revert "Round up DMSAA attachments to pow2 if supported."
>
> This reverts commit c3e8a7eeb6.
>
> Reason for revert: breaks dmsaa clip_shader_persp and complexclip4_aa
>
> Original change's description:
> > Round up DMSAA attachments to pow2 if supported.
> >
> > Change-Id: I03f5ea649209b9894753c981872edbd7d718288c
> > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/408643
> > Reviewed-by: Brian Salomon <bsalomon@google.com>
> > Commit-Queue: Greg Daniel <egdaniel@google.com>
>
> TBR=egdaniel@google.com,bsalomon@google.com,csmartdalton@google.com
>
> Change-Id: I3ff0931d7d00b064b5721a2593d2e9865e8edebc
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/408896
> Reviewed-by: Greg Daniel <egdaniel@google.com>
> Commit-Queue: Greg Daniel <egdaniel@google.com>

# Not skipping CQ checks because original CL landed > 1 day ago.

Change-Id: Id4c9f49c9ee5bbc1c19ededf4ee911942c67f204
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/421320
Reviewed-by: Greg Daniel <egdaniel@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Greg Daniel <egdaniel@google.com>
2021-06-24 20:56:12 +00:00
Ben Wagner
2c7c36a4b0 SkTypeface_FreeType to own FT_Face
Previously, FT_Face were cached and owned by a global linked list in
which they were retained only if a reference was kept to it.
SkScalerContext_FreeType would keep a reference, but SkTypeface_FreeType
would not. This leads to situations where the FT_Face may be created and
destroyed on most method calls into SkTypeface_FreeType if a
corresponding SkScalerContext were not also created.

One of the reasons for this design was to avoid forcing the creation of
FT_Face on SkTypeface_FreeType creation. This allows for many
SkTypefaces to be created (like creating one for every system font) but
not actually creating the FT_Faces until they are actually used.

This change moves the ownership of FT_Face to SkTypeface_FreeType. The
linked list is removed. As before the FT_Face is created on demand, but
once created is now retained by SkTypeface_FreeType until it is
destroyed.

Bug: skia:12112
Change-Id: I36a2a88dfae1b1313c03060c38e17f0782f02276
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/420578
Reviewed-by: Mike Reed <reed@google.com>
Reviewed-by: Herb Derby <herb@google.com>
Commit-Queue: Ben Wagner <bungeman@google.com>
2021-06-24 20:51:52 +00:00
Brian Osman
b9108feefe Remove declaration of unused, unimplemented FP
Change-Id: Ib4f5c5f3e0918ef5cc54aac8341e3958fbf6647d
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/421516
Commit-Queue: Brian Osman <brianosman@google.com>
Commit-Queue: John Stiles <johnstiles@google.com>
Auto-Submit: Brian Osman <brianosman@google.com>
Reviewed-by: John Stiles <johnstiles@google.com>
2021-06-24 20:12:52 +00:00
Kevin Lubick
559185ad34 [canvaskit] Ensure clean build on CI
Hypothesis that the gen and obj folders not being deleted led to some
failed builds if there were conflicting object files.

Change-Id: I63df08092bf7d325c0f008d429dd13981f0a67a5
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/421496
Reviewed-by: Brian Osman <brianosman@google.com>
2021-06-24 18:54:52 +00:00
Kevin Lubick
bd7ed7434a [canvaskit] Fix font.getGlyphID test
The previous version accidentally retrieved all values from
the in memory glyph cache because it was always measuring
the range 1-300. This changes the glyphID to always be an
increasing number, which avoids the cache hits.

There is now some differences between the font types:
 - ttf: ~4ms
 - woff: ~160ms
 - woff2: ~230ms

The high numbers in the woff categories are expected to be
fixed by https://skia-review.googlesource.com/c/skia/+/420578

Bug: skia:12112
Change-Id: I52f6f7baf27fc28b99ac65a067142281918d7298
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/421324
Reviewed-by: Kevin Lubick <kjlubick@google.com>
2021-06-24 18:27:49 +00:00
Joe Gregorio
cd9890a0da Remove disabled_examples.txt
It is no longer used. The example runner uses the registry and fiddle
checks for the '#if'.

Change-Id: I1213702e89cc4927108eeeabcc10501b30eab934
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/205588
Commit-Queue: Ben Wagner <bungeman@google.com>
Reviewed-by: Ben Wagner <bungeman@google.com>
Auto-Submit: Ben Wagner <bungeman@google.com>
2021-06-24 17:47:50 +00:00
Florin Malita
b445cbeee2 [androidkit] Add remaining gradients
Consolidate the common logic in a Gradient base class, and add
radial/conical/sweep factories.

Change-Id: Ife15ae78e7c6df48cfa67fe20054f9bd9a8a1e90
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/420897
Commit-Queue: Florin Malita <fmalita@chromium.org>
Commit-Queue: Florin Malita <fmalita@google.com>
Reviewed-by: Mike Reed <reed@google.com>
Reviewed-by: Jorge Betancourt <jmbetancourt@google.com>
2021-06-24 17:43:38 +00:00
Chris Dalton
a1e7f44c63 Revert "Remove all instances of incorrect coverage with DMSAA"
This reverts commit 3722d3195b.

Reason for revert: Disables msaa for paths

Original change's description:
> Remove all instances of incorrect coverage with DMSAA
>
> Here we pivot and handle DMSAA differently depending on platform:
>
> 1) Desktop GL and EXT_multisample_compatibility: Here it's easy to use
>    all our existing coverage ops because we can just call
>    glDisable(GL_MULTISAMPLE). So we only trigger MSAA for paths and
>    use the coverage ops for everything else with MSAA disabled.
>
> 2) EXT_multisampled_render_to_to_texture (86% adoption on Android):
>    The assumption here is that MSAA is almost free. So we just allow
>    MSAA to be triggered often and don't worry about it.
>
> Devices that neither support #1 nor #2 just don't get DMSAA for now.
>
> Bug: skia:11396
> Change-Id: I53ad840216ea6d88ae69eece6f7a062f9e82dad7
> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/421019
> Commit-Queue: Chris Dalton <csmartdalton@google.com>
> Reviewed-by: Brian Salomon <bsalomon@google.com>

TBR=egdaniel@google.com,bsalomon@google.com,csmartdalton@google.com

Change-Id: If9b9cd25b93d5db2cc7f9c6cd4be783284587a37
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: skia:11396
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/421416
Reviewed-by: Chris Dalton <csmartdalton@google.com>
Commit-Queue: Chris Dalton <csmartdalton@google.com>
2021-06-24 17:15:00 +00:00
Chris Dalton
3722d3195b Remove all instances of incorrect coverage with DMSAA
Here we pivot and handle DMSAA differently depending on platform:

1) Desktop GL and EXT_multisample_compatibility: Here it's easy to use
   all our existing coverage ops because we can just call
   glDisable(GL_MULTISAMPLE). So we only trigger MSAA for paths and
   use the coverage ops for everything else with MSAA disabled.

2) EXT_multisampled_render_to_to_texture (86% adoption on Android):
   The assumption here is that MSAA is almost free. So we just allow
   MSAA to be triggered often and don't worry about it.

Devices that neither support #1 nor #2 just don't get DMSAA for now.

Bug: skia:11396
Change-Id: I53ad840216ea6d88ae69eece6f7a062f9e82dad7
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/421019
Commit-Queue: Chris Dalton <csmartdalton@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
2021-06-24 16:04:19 +00:00
Chris Dalton
c5a65cb22d Don't enable --hwtess on DMSAA bots
The GpuTess bot is enough to keep this codepath tested.

Bug: skia:10419
Change-Id: I596e141ea3af26375443f0717d6b9413beb5959b
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/421216
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Chris Dalton <csmartdalton@google.com>
2021-06-24 15:41:29 +00:00
skia-autoroll
ecee7cc6fe Roll SK Tool from 3407a9e6d9ae to 7949048ae367
https://skia.googlesource.com/buildbot.git/+log/3407a9e6d9ae..7949048ae367

2021-06-24 sokcevic@google.com Update chromiumos and luci-go branch to main
2021-06-23 lovisolo@google.com Regenerate licenses.
2021-06-23 rmistry@google.com Use metrics logging in codereview-watcher
2021-06-23 borenet@google.com [autoroll] More fixes for CAS -> recipes-py roller
2021-06-23 lovisolo@google.com [gold] Build gold-frontend container with Bazel.
2021-06-23 rmistry@google.com TrivialPatchsetKinds public; expose GetCommit; AccountID to LabelDetail;
2021-06-23 rmistry@google.com Add SubmittedTogether func to go/gerrit
2021-06-23 rmistry@google.com Add more options to gerrit.SetReview
2021-06-23 rmistry@google.com Add support for searching by tags in buildbucket.GetTrybotsForCL
2021-06-23 rmistry@google.com Add CancelBuilds to go/buildbucket
2021-06-23 rmistry@google.com Add ScheduleBuilds to go/buildbucket

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/sk-tool-skia
Please CC jcgregorio@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Tbr: jcgregorio@google.com
Change-Id: If06c0603ddb784f0814fc7b46217ae84a08d45b2
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/421276
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2021-06-24 14:17:21 +00:00
skia-autoroll
2bf88911b9 Roll Dawn from a7173fcab4af to 75c5067ed12e (5 revisions)
https://dawn.googlesource.com/dawn.git/+log/a7173fcab4af..75c5067ed12e

2021-06-24 enga@chromium.org Implement initialization of multisampled textures
2021-06-23 sarahmashay@google.com update compute shaders to include workgroup_size in their attribute
2021-06-23 yunchao.he@intel.com Add a few tests for copies and fix bugs found by new tests
2021-06-23 enga@chromium.org Guard against some arithmetic overflows
2021-06-23 cwallez@chromium.org Rolling build dependencies for new d3dcompiler_47.dll

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dawn-skia-autoroll
Please CC rharrison@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: skia/skia.primary:Build-Debian10-Clang-x86_64-Debug-Dawn
Bug: None
Tbr: rharrison@google.com
Change-Id: Ibdd79de380ff991a3f29b3fe5ce24c410ed10fb7
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/421161
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2021-06-24 06:11:09 +00:00
skia-autoroll
35b76a47cb Roll SwiftShader from f0a9f88dd5cb to 8f075627d16b (1 revision)
https://swiftshader.googlesource.com/SwiftShader.git/+log/f0a9f88dd5cb..8f075627d16b

2021-06-23 capn@google.com Make UpdateAfterBind descriptor limits equal to base limits

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-skia-autoroll
Please CC tdenniston@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: skia/skia.primary:Test-Debian10-Clang-GCE-GPU-SwiftShader-x86_64-Debug-All-SwiftShader
Bug: None
Tbr: tdenniston@google.com
Change-Id: I540dfc413dd4aa21b80bfad62c9de32c293e6054
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/421160
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2021-06-24 05:26:49 +00:00
skia-autoroll
f13ac8487e Roll ANGLE from 09bd55786427 to 4375d6c732ef (13 revisions)
09bd557864..4375d6c732

2021-06-24 syoussefi@chromium.org Vulkan: Support multiview queries
2021-06-24 syoussefi@chromium.org No-op glGenerateMipmap on zero-sized textures
2021-06-24 syoussefi@chromium.org Vulkan: Support OVR_multiview and OVR_multiview2
2021-06-24 syoussefi@chromium.org Vulkan: Unpack RenderPassDesc
2021-06-23 gert.wollny@collabora.com Capture/Replay: Add feature for robust resource init
2021-06-23 gert.wollny@collabora.com gl_tests:DrawArraysThenDrawElements: glFinish instead of swap
2021-06-23 jmadill@chromium.org Test Runner: Omit results files when too many failures.
2021-06-23 gert.wollny@collabora.com Capture: Serialize only the content of initialized attachments
2021-06-23 jmadill@chromium.org Disable warning on invalid feature name.
2021-06-23 jmadill@chromium.org Finish switch to angle_version.h.
2021-06-23 angle-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 85e758a22b7a to 5fbfa253f282 (2 revisions)
2021-06-23 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 685eab2b2e45 to bbc918ca9021 (471 revisions)
2021-06-23 syoussefi@chromium.org Vulkan: Use pipeline statistics query to emulate primitives generated

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-skia-autoroll
Please CC tdenniston@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: skia/skia.primary:Build-Debian10-Clang-x86_64-Release-ANGLE;skia/skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-Golo-GPU-QuadroP400-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC8i5BEK-GPU-IntelIris655-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE
Tbr: tdenniston@google.com
Change-Id: I674a12e3fbaefee2450a0f2c17c11668789eee1e
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/421159
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2021-06-24 05:26:39 +00:00
skia-autoroll
95bc974cad Roll Chromium from 493d9cce5082 to a685aa37c9fa (449 revisions)
493d9cce50..a685aa37c9

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-skia-autoroll
Please CC tdenniston@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: skia/skia.primary:Perf-Mac10.13-Clang-MacBookPro11.5-GPU-RadeonHD8870M-x86_64-Release-All-CommandBuffer;skia/skia.primary:Test-Mac10.13-Clang-MacBookPro11.5-GPU-RadeonHD8870M-x86_64-Debug-All-CommandBuffer
Tbr: tdenniston@google.com
Change-Id: Id2f4c9583d5242f858a8cdb64ff36a75fd32725d
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/421158
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2021-06-24 05:14:39 +00:00
Chris Dalton
8c3036c145 Small improvement to tessellation atlas packing
Bug: chromium:928984
Change-Id: I1b2a43b6d14b834247c1505bd7c9b2ae51a146ba
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/421017
Commit-Queue: Chris Dalton <csmartdalton@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
2021-06-24 04:51:39 +00:00
Chris Dalton
83420eb817 Rewrite tessellation atlases as normal render tasks
Rewrites tessellation atlases as normal render tasks instead of
"onFlush" tasks. These tasks get inserted into the DAG upfront, lay
out their atlases as dependent tasks get built and reference them, and
finally add their ops to render themselves during onMakeClosed. Doing it
this way allows us to pause the flush and re-render the atlas whenever
it runs out of room.

Bug: b/188794626
Bug: chromium:928984
Change-Id: Id59a5527924c63d5ff7c5bce46a88368e79fc3ef
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/420556
Commit-Queue: Chris Dalton <csmartdalton@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
Reviewed-by: Adlai Holler <adlai@google.com>
2021-06-24 01:44:19 +00:00
Chris Dalton
aa938cea33 Upgrade GrRenderTask::makeClosed to take a GrRecordingContext
The tessellation atlas task will need a recording context in order to
record its ops during onMakeClosed.

Bug: b/188794626
Bug: chromium:928984
Change-Id: Ie8719a514899a5748c52ae78a6ecd997b1439ab7
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/420879
Commit-Queue: Chris Dalton <csmartdalton@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
2021-06-24 01:43:10 +00:00
Greg Daniel
9a2d3d1e19 Revert "Fix texture barriers on DMSAA"
This reverts commit 1a3f4ab490.

Reason for revert: breaking dmsaa test on intel hd405, https://ci.chromium.org/raw/build/logs.chromium.org/skia/54538c41f1c1b111/+/annotations

Original change's description:
> Fix texture barriers on DMSAA
>
> Bug: skia:11396
> Change-Id: Iad74958c05ed086fe85656b9dc5418d5ab4589e7
> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/419838
> Commit-Queue: Greg Daniel <egdaniel@google.com>
> Reviewed-by: Chris Dalton <csmartdalton@google.com>
> Reviewed-by: Brian Salomon <bsalomon@google.com>

TBR=egdaniel@google.com,bsalomon@google.com,csmartdalton@google.com

Change-Id: I8be8107a98584dfb7f831a296078753fecfcebcf
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: skia:11396
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/421056
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Greg Daniel <egdaniel@google.com>
2021-06-23 22:36:20 +00:00
Chris Dalton
b1e8f85fb8 Add an 'opBeingClipped' param to GrClip::apply
The tessellation atlas needs this to call visitProxies.

Bug: b/188794626
Bug: chromium:928984
Change-Id: I5bfb2559abcaf5c7602393e96adb846bcfbce971
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/420878
Commit-Queue: Chris Dalton <csmartdalton@google.com>
Reviewed-by: Michael Ludwig <michaelludwig@google.com>
2021-06-23 20:41:39 +00:00
Herb Derby
d1d0a9f1f3 Small cleanups to drawVertices
Change-Id: I16301e6fb7193ba67b9fea292f931fda480c8ac3
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/420956
Commit-Queue: Herb Derby <herb@google.com>
Reviewed-by: Mike Reed <reed@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
2021-06-23 19:43:18 +00:00
Greg Daniel
1a3f4ab490 Fix texture barriers on DMSAA
Bug: skia:11396
Change-Id: Iad74958c05ed086fe85656b9dc5418d5ab4589e7
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/419838
Commit-Queue: Greg Daniel <egdaniel@google.com>
Reviewed-by: Chris Dalton <csmartdalton@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
2021-06-23 19:30:38 +00:00
Ethan Nicholas
d0f4d0d5d4 Switched more DSL APIs over to skstd::string_view
Change-Id: I87defa005fab8b1be92a700bf38c91b92c0ab8a7
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/420616
Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
Reviewed-by: John Stiles <johnstiles@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
2021-06-23 18:59:16 +00:00
Brian Salomon
b149700e01 Avoid non-indexed quad draws on PowerVR Rogue and 54x
Bug: chromium:1203652
Change-Id: Id83ac81c40eda2653e97a7c8ae9326c273f0f00b
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/420537
Reviewed-by: Michael Ludwig <michaelludwig@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
2021-06-23 18:11:18 +00:00
Brian Salomon
b18a947a35 Don't use strokerect op with reduced shader mode.
Bug: skia:11844
Change-Id: I8a5fdd6b074ba070022b6da3e31d8642b2f35181
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/420896
Reviewed-by: Jim Van Verth <jvanverth@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
2021-06-23 17:48:36 +00:00
Greg Daniel
095185d175 Ignore another vk extension implemented by nvidia but not in validation layers yet.
Change-Id: I015cc2401c9f4a87fa7a02a93890bcf0a6704a91
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/420901
Commit-Queue: Greg Daniel <egdaniel@google.com>
Commit-Queue: Chris Dalton <csmartdalton@google.com>
Auto-Submit: Greg Daniel <egdaniel@google.com>
Reviewed-by: Chris Dalton <csmartdalton@google.com>
2021-06-23 17:08:35 +00:00
Brian Osman
48f83fd5d1 Reland "Replace GrColorMatrixFragmentProcessor with a runtime FP"
This reverts commit 3366efd581.

Reason for revert: Perf regression root cause fixed.

Original change's description:
> Revert "Replace GrColorMatrixFragmentProcessor with a runtime FP"
>
> Triggered a perf regression, somehow.
>
> This reverts commit 311010405e.
>
> Change-Id: Ic468d34c8ccd28aaaed2d3028ce9559115860844
> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/420816
> Reviewed-by: Brian Osman <brianosman@google.com>
> Commit-Queue: Brian Osman <brianosman@google.com>

# Not skipping CQ checks because this is a reland.

Change-Id: Iea53fba22ef08b0ed97220b9cd2a9a0d054ecf57
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/420900
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
2021-06-23 17:05:15 +00:00
Brian Osman
d02d4eb6de In GrSkSLFP, advance the iterator pointer while building the key
We were checking the flags for each uniform, but never advancing the
uniform iterator. As a result, for each uniform that was specialized,
we'd just fold in another copy of the *first* uniform's data.

This led to a nasty performance regression (extra shader compiles) in
certain scenarios. (And it was a correctness issue, as well).

Change-Id: Iaac878a7b9eb37e98815f56dc55a58d1f8e85c22
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/420820
Reviewed-by: John Stiles <johnstiles@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
2021-06-23 17:02:31 +00:00
Jorge Betancourt
b75ee08162 [androidkit] add bounds and paint to canvas.saveLayer()
Change-Id: I55701ebb23bcf31a8f1e1533b030f685f2f10127
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/420117
Reviewed-by: Florin Malita <fmalita@chromium.org>
Commit-Queue: Jorge Betancourt <jmbetancourt@google.com>
2021-06-23 16:40:45 +00:00
Ethan Nicholas
b4f8b7a9f2 Cleaned up DSL error handling
This unifies various chunks of error handling code and makes the DSL
more gracefully handle failed object construction.

Change-Id: I4edc581c9eba276ce2ee2a17125ea7bd6057134a
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/420237
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
2021-06-23 15:22:35 +00:00
skia-autoroll
c5fb326453 Roll SK Tool from 7aa627c29dba to 1e6dc2e432bd
https://skia.googlesource.com/buildbot.git/+log/7aa627c29dba..1e6dc2e432bd

2021-06-23 borenet@google.com Fix gazelle
2021-06-23 borenet@google.com [autoroll] Add CAS Client -> recipes-py roller
2021-06-23 borenet@google.com [sk] Actually fix logging

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/sk-tool-skia
Please CC jcgregorio@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Tbr: jcgregorio@google.com
Change-Id: I339d6d33034e9bc95f6e336c3f19ed177a1ce343
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/420837
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2021-06-23 15:19:05 +00:00
Robert Phillips
c29810e882 [ngatoy] add ovals
Adding ovals reveals the clipping failure. The "actual" results with the
oval clips are currently incorrect.

Bug: skia:11837
Change-Id: I0789d5f758457425250ff6cecc0a5bb44f6e82ef
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/420637
Commit-Queue: Robert Phillips <robertphillips@google.com>
Reviewed-by: Michael Ludwig <michaelludwig@google.com>
2021-06-23 14:06:05 +00:00