Change-Id: I98fcaa0e83e574cdbdd767abbedcf6763c0fdce4
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/422521
Commit-Queue: Brian Osman <brianosman@google.com>
Reviewed-by: Ethan Nicholas <ethannicholas@google.com>
These mac minis had been mysteriously low on disk space.
They reported 20 or fewer GB free, but no tool could tell
us where that space was being used.
Updating from 11.1 to 11.4 seems to have cleared that up.
Change-Id: I5291b1ac5616b9899b1cd6de35ae36af0cb8c75b
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/423056
Reviewed-by: Joe Gregorio <jcgregorio@google.com>
Ycbcr images in vulkan can use anywhere from 1 to 3 descriptor set slots.
This comes from some gpus needing to internally treat the different
planes as different textures/samplers. So when you allocated a desc set
that includes a ycbcr image it may actually use up 3 desc set slots from
the pool. Nothing else changes in how we use the VkImage or descriptor
set. Just a matter of accounting for it in the pool.
Change-Id: I10dead981e59f0ebee54b76bdeabf968114d83b0
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/422520
Reviewed-by: Jim Van Verth <jvanverth@google.com>
Commit-Queue: Greg Daniel <egdaniel@google.com>
Discovered while trying to run viewer in ASAN
Change-Id: Ic7469fdbf8cb77573c2f93503440b2137bdba783
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/423016
Commit-Queue: Brian Osman <brianosman@google.com>
Commit-Queue: Greg Daniel <egdaniel@google.com>
Auto-Submit: Brian Osman <brianosman@google.com>
Reviewed-by: Greg Daniel <egdaniel@google.com>
Apparently the guarantee of buffer space has been refactored out from
underneath this class.
Bug: 1223365
Change-Id: I9beb9566a641933322bd946a5067eeafb9c4c013
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/422636
Commit-Queue: Robert Phillips <robertphillips@google.com>
Reviewed-by: Michael Ludwig <michaelludwig@google.com>
8767ec1549..e70c21f4cb
2021-06-28 cnorthrop@google.com Tests: Add Beach Buggy Racing trace
2021-06-28 timvp@google.com Fixes and updates to roll_aosp.sh
2021-06-28 jmadill@chromium.org Suppress flaky TSAN TLS false positive.
2021-06-28 gert.wollny@collabora.com Capture/Replay: enable passing DrawBuffersTest.*
2021-06-28 cnorthrop@google.com Capture/Replay: Disable GL_OES_depth32 during capture
2021-06-28 penghuang@chromium.org Disable shader cache for PowerVR Rogue GPUs.
2021-06-28 m.maiya@samsung.com Vulkan: Handle incompatible pipeline layouts
2021-06-28 jmadill@chromium.org Revert "Vulkan: Load custom Vk Loader."
2021-06-28 gert.wollny@collabora.com Capture/Replay: enable passing OcclusionQueriesTest.*
2021-06-28 cnorthrop@google.com Capture/Replay: Update CopyImageSubData params
2021-06-28 gert.wollny@collabora.com Capture/Replay: enable passing IndexedPointsTest* tests
2021-06-28 gert.wollny@collabora.com Capture/Replay: capture GetMaterialfv parameters
2021-06-28 syoussefi@chromium.org Vulkan: SPIR-V Gen: Support loops
2021-06-28 gert.wollny@collabora.com Capture/Replay: Handle Gen/Delete Semaphores and fix map emit
2021-06-28 jmadill@chromium.org Vulkan: Load custom Vk Loader.
2021-06-28 jmadill@chromium.org Add SearchType to OpenSharedLibraryWithExtension.
2021-06-28 syoussefi@chromium.org Add angle::BitMask for creating bit masks
2021-06-28 gert.wollny@collabora.com Capture/Replay: Limit number of compile processes based on load
2021-06-28 jmadill@chromium.org Trace Tests: Use hermetic depot_tools.
2021-06-28 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 8f075627d16b to e4fea30bb438 (3 revisions)
2021-06-28 gert.wollny@collabora.com Capture/Replay: Add test to capture an uninitialized buffer
2021-06-28 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 94cea2515faf to 1078c63704e4 (468 revisions)
2021-06-28 gert.wollny@collabora.com Capture/Replay: Enable BufferDataTests.*
2021-06-28 gert.wollny@collabora.com Capture/Replay: SimpleOperationTest.* pass now
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-skia-autoroll
Please CC bungeman@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: skia/skia.primary:Build-Debian10-Clang-x86_64-Release-ANGLE;skia/skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-Golo-GPU-QuadroP400-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC8i5BEK-GPU-IntelIris655-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE
Tbr: bungeman@google.com
Test: Test: Beach Buggy Racing MEC
Test: Test: ImageTest.SourceAHBTarget2DExternalCycleThroughRgbAndYuvTargets*Vulkan
Test: Test: PUBG Mobile MEC
Test: Test: angle_perftests --gtest_filter="*beach_buggy_racing*"
Change-Id: Ifa2fd660df5ed29328133be07143a224007771b1
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/422839
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
This allows tests which draw this font on platforms which do not support
the COLRv1 table to draw something rather than nothing.
Change-Id: I024dd4809498d55f8c4c9f0de9e342fed5fb69ac
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/422757
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Ben Wagner <bungeman@google.com>
DMSAA is complete enough now that we can just add gldmsaa configs to the
normal test bots.
Bug: skia:11396
Change-Id: I4f65777388e2e4ddbe10271dd419a71e8fa7820b
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/421376
Commit-Queue: Chris Dalton <csmartdalton@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
Particlarly with runtime FPs, this is a poor space/time tradeoff.
This doesn't completely undo the memory losses from the linked bugs.
Some of it is the unavoidable cost of initializing the runtime effect
compiler - but that's going to happen once, sooner or later. It does
reduce the heap impact of each effect from ~64k to something like 2-3k,
depending on the effect.
Bug: chromium:1223995 chromium:1223996
Change-Id: I929b7a94a88119a155ca403793bebd003a2deca6
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/422518
Reviewed-by: Brian Salomon <bsalomon@google.com>
Reviewed-by: Ethan Nicholas <ethannicholas@google.com>
This is a reland of 76b80eca64
Original change's description:
> Use GL_ANGLE_instanced_arrays
>
> It turns out the es2 command buffer has supported instanced rendering
> all along. We just weren't using it! This CL starts using
> GL_ANGLE_instanced_arrays, after which point chrome es2 will start
> taking many of our instanced codepaths. It can even use tessellation if
> we update the shaders to not rely on gl_VertexID.
>
> Bug: chromium:1220246
> Change-Id: I173f4c07771691143d2540ecb9c3f8222ed8e4b3
> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/422379
> Reviewed-by: Brian Salomon <bsalomon@google.com>
> Commit-Queue: Chris Dalton <csmartdalton@google.com>
Bug: chromium:1220246
Change-Id: I4d6f74adff4e2eda4b55a459faf16b5f5a230d06
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/422616
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Chris Dalton <csmartdalton@google.com>
This also tightens up the rules around releasing DSL objects.
Bug: skia:12133
Change-Id: I11a6d8fbcec58374f7b5ed5ced1c5c112e2b7cc7
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/421323
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
Adds the ability to create an es3 command buffer context, but does not
yet begin testing it because libcommand_buffer_gles2.dylib needs to be
updated first to respect the EGL_CONTEXT_CLIENT_VERSION attrib. Adds a
version check on the context as well to verify we actually get an es3
context when we ask for one.
Bug: chromium:1220246
Change-Id: I996f482d8ad831b81f873e1bfd2f0526e5f1e73e
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/419616
Commit-Queue: Chris Dalton <csmartdalton@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
Move some rough equivalents to Pixel2XL.
Change-Id: I8e96cdf011f02061cdbbda774b5ac53dd1581d54
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/422500
Reviewed-by: Ravi Mistry <rmistry@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
skif::Mapping's deviceToLayer space had a punt when the device matrix
was not invertible and just returned the value unmodified, silently.
In this instance, it meant that conversion of device bounds into layer
space produced non-empty bounds, but the actual non-invertible CTM
would always result in an empty layer.
Now skif::Mapping asserts that its device matrix is invertible and
caches that inverse. The SkCanvas's get_layer_bounds_and_mapping checks
for invertibility first.
This doesn't quite fix the linked fuzzer bug's test case, but allows
it to proceed past the saved layer with image filter.
Bug: chromium:1222351
Change-Id: I1342634e6ba5d78709a5f1b30785c9e7c69633e5
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/421096
Reviewed-by: Robert Phillips <robertphillips@google.com>
Commit-Queue: Michael Ludwig <michaelludwig@google.com>
This reverts commit 76b80eca64.
Reason for revert: Chrome layout test diffs
Original change's description:
> Use GL_ANGLE_instanced_arrays
>
> It turns out the es2 command buffer has supported instanced rendering
> all along. We just weren't using it! This CL starts using
> GL_ANGLE_instanced_arrays, after which point chrome es2 will start
> taking many of our instanced codepaths. It can even use tessellation if
> we update the shaders to not rely on gl_VertexID.
>
> Bug: chromium:1220246
> Change-Id: I173f4c07771691143d2540ecb9c3f8222ed8e4b3
> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/422379
> Reviewed-by: Brian Salomon <bsalomon@google.com>
> Commit-Queue: Chris Dalton <csmartdalton@google.com>
TBR=bsalomon@google.com,csmartdalton@google.com
Change-Id: I62c25be4f6cf6937c0b5ab6e765a7113aad76916
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: chromium:1220246
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/422441
Reviewed-by: Chris Dalton <csmartdalton@google.com>
Commit-Queue: Chris Dalton <csmartdalton@google.com>
This is a reland of 3722d3195b
Original change's description:
> Remove all instances of incorrect coverage with DMSAA
>
> Here we pivot and handle DMSAA differently depending on platform:
>
> 1) Desktop GL and EXT_multisample_compatibility: Here it's easy to use
> all our existing coverage ops because we can just call
> glDisable(GL_MULTISAMPLE). So we only trigger MSAA for paths and
> use the coverage ops for everything else with MSAA disabled.
>
> 2) EXT_multisampled_render_to_to_texture (86% adoption on Android):
> The assumption here is that MSAA is almost free. So we just allow
> MSAA to be triggered often and don't worry about it.
>
> Devices that neither support #1 nor #2 just don't get DMSAA for now.
>
> Bug: skia:11396
> Change-Id: I53ad840216ea6d88ae69eece6f7a062f9e82dad7
> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/421019
> Commit-Queue: Chris Dalton <csmartdalton@google.com>
> Reviewed-by: Brian Salomon <bsalomon@google.com>
Bug: skia:11396
Change-Id: I536d365efc3c6890b45f14b7d188e0ef5ec36e19
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/421825
Reviewed-by: Brian Salomon <bsalomon@google.com>
This reverts commit 688d3180ab.
Reason for revert: Fixing error
Original change's description:
> Revert "Metal: First pass at async pipelineState creation."
>
> This reverts commit adf36be2f9.
>
> Reason for revert: breaking Flutter roll
>
> Original change's description:
> > Metal: First pass at async pipelineState creation.
> >
> > Trying a basic approach to generating pipelineStates asynchronously.
> > Rather than managing the caching ourselves, we depend on the Apple
> > cache. When a pipelineState is created during the regular path, it
> > should find it in the Apple cache and return immediately.
> >
> > To avoid too much duplication of the shader compilation step we cache
> > the MTLLibrarys locally until the final PSO is cached.
> >
> > Bug: skia:12141
> > Change-Id: Id8f6ba7caee33b4c7f6a5af0e8ad5b84993b1246
> > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/421321
> > Reviewed-by: Brian Osman <brianosman@google.com>
> > Commit-Queue: Jim Van Verth <jvanverth@google.com>
>
> TBR=jvanverth@google.com,brianosman@google.com,chinmaygarde@google.com
>
> Change-Id: Iad7c4c87c22d0d002809c215878439fdb098f54a
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: skia:12141
> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/422117
> Reviewed-by: Tyler Denniston <tdenniston@google.com>
> Commit-Queue: Tyler Denniston <tdenniston@google.com>
# Not skipping CQ checks because original CL landed > 1 day ago.
Bug: skia:12141
Change-Id: Ibf6aa5383b6aabbf538dab679f3f83241a4504d9
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/422499
Reviewed-by: Jim Van Verth <jvanverth@google.com>
Commit-Queue: Jim Van Verth <jvanverth@google.com>
This reverts commit b149700e01.
Reason for revert: This was a speculative fix that didn't pan out.
Original change's description:
> Avoid non-indexed quad draws on PowerVR Rogue and 54x
>
> Bug: chromium:1203652
> Change-Id: Id83ac81c40eda2653e97a7c8ae9326c273f0f00b
> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/420537
> Reviewed-by: Michael Ludwig <michaelludwig@google.com>
> Commit-Queue: Brian Salomon <bsalomon@google.com>
# Not skipping CQ checks because original CL landed > 1 day ago.
Bug: chromium:1203652
Change-Id: I73f2415e35d92514229572f2d8823c1a632a68fa
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/421921
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
The make_lotties_with_assets is a handy tool to take a
directory of lottie files and move them into their own
folders. This will make it easier to add assets (e.g. fonts,
images) if we want to get more accurate benchmarks.
This also makes the test not stop on the first failure, but complete
all of them, so we can see more easily if multiple things have broken.
Change-Id: Idb2ece71376a11e7524cd513a2798884a44bb59f
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/421927
Reviewed-by: Florin Malita <fmalita@google.com>
We also catch any errors that happen during running the
test or flushing. This allows them to show up in the CI logs.
For skottie-frames in particular, we stop clearing the canvas
before each render, as that was masking an error (and not how
we do things on skottie.skia.org).
Change-Id: I83936a35b6c314da76a0a64e15deaabd156e71f2
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/421923
Reviewed-by: Kevin Lubick <kjlubick@google.com>
It turns out the es2 command buffer has supported instanced rendering
all along. We just weren't using it! This CL starts using
GL_ANGLE_instanced_arrays, after which point chrome es2 will start
taking many of our instanced codepaths. It can even use tessellation if
we update the shaders to not rely on gl_VertexID.
Bug: chromium:1220246
Change-Id: I173f4c07771691143d2540ecb9c3f8222ed8e4b3
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/422379
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Chris Dalton <csmartdalton@google.com>
This also updates a few other CIPD packages.
Change-Id: I078e7ac8da49ae79392263013158956a6d29c656
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/422096
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
c24494415a..8767ec1549
2021-06-28 cnorthrop@google.com Tests: Add Bricks Breaker Quest trace
2021-06-26 cnorthrop@google.com Tests: Add Mario Kart Tour trace
2021-06-25 syoussefi@chromium.org Translator: Better group ES100 texture builtins
2021-06-25 jmadill@chromium.org infra: Add perf mb configs.
2021-06-25 pkasting@chromium.org Fix -Wimplicit-int-float-conversions.
2021-06-25 jmadill@chromium.org infra: Add perf configs.
2021-06-25 jmadill@chromium.org Trace Tests: Use xvfb consistently on Linux.
2021-06-25 jmadill@chromium.org D3D11: Fix OOB write in Blit11.
2021-06-25 ynovikov@chromium.org Remove obsolete Android bots from CQ
2021-06-25 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from fa6954ae7bb5 to 94cea2515faf (470 revisions)
2021-06-25 syoussefi@chromium.org Vulkan: SPIR-V Gen: Support the ternary operator
2021-06-25 syoussefi@chromium.org Vulkan: SPIR-V Gen: Basic support for fragment shaders
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-skia-autoroll
Please CC bungeman@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: skia/skia.primary:Build-Debian10-Clang-x86_64-Release-ANGLE;skia/skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-Golo-GPU-QuadroP400-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC8i5BEK-GPU-IntelIris655-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE
Tbr: bungeman@google.com
Test: Test: angle_perftests --gtest_filter="*bricks_breaker_quest*"
Test: Test: angle_perftests --gtest_filter="*mario_kart_tour*"
Change-Id: I6b47f47cb43d963a18ca761d3ed3388ba515c33a
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/422376
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
This reverts commit 702fb679f3.
Reason for revert: Landed without original CL
Original change's description:
> Fix warning
>
> Change-Id: I7f017aa0a842c40e5041529f5e3d7b9a03989a65
> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/422116
> Reviewed-by: Ben Wagner <bungeman@google.com>
> Commit-Queue: Jim Van Verth <jvanverth@google.com>
TBR=jvanverth@google.com,bungeman@google.com
Change-Id: Ie1ab9daaff46efbff5879bf451269fcf9f554d3f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/422118
Reviewed-by: Jim Van Verth <jvanverth@google.com>
Commit-Queue: Jim Van Verth <jvanverth@google.com>
Change-Id: I7f017aa0a842c40e5041529f5e3d7b9a03989a65
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/422116
Reviewed-by: Ben Wagner <bungeman@google.com>
Commit-Queue: Jim Van Verth <jvanverth@google.com>
This reverts commit adf36be2f9.
Reason for revert: breaking Flutter roll
Original change's description:
> Metal: First pass at async pipelineState creation.
>
> Trying a basic approach to generating pipelineStates asynchronously.
> Rather than managing the caching ourselves, we depend on the Apple
> cache. When a pipelineState is created during the regular path, it
> should find it in the Apple cache and return immediately.
>
> To avoid too much duplication of the shader compilation step we cache
> the MTLLibrarys locally until the final PSO is cached.
>
> Bug: skia:12141
> Change-Id: Id8f6ba7caee33b4c7f6a5af0e8ad5b84993b1246
> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/421321
> Reviewed-by: Brian Osman <brianosman@google.com>
> Commit-Queue: Jim Van Verth <jvanverth@google.com>
TBR=jvanverth@google.com,brianosman@google.com,chinmaygarde@google.com
Change-Id: Iad7c4c87c22d0d002809c215878439fdb098f54a
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: skia:12141
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/422117
Reviewed-by: Tyler Denniston <tdenniston@google.com>
Commit-Queue: Tyler Denniston <tdenniston@google.com>
This also introduces "IgnoreOptFlags", for child FPs that should not
influence the OptFlags of the parent.
Change-Id: I8f7ba2ca59f612bd7d6e226b96e9fd94d656150b
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/421929
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
Trying a basic approach to generating pipelineStates asynchronously.
Rather than managing the caching ourselves, we depend on the Apple
cache. When a pipelineState is created during the regular path, it
should find it in the Apple cache and return immediately.
To avoid too much duplication of the shader compilation step we cache
the MTLLibrarys locally until the final PSO is cached.
Bug: skia:12141
Change-Id: Id8f6ba7caee33b4c7f6a5af0e8ad5b84993b1246
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/421321
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Jim Van Verth <jvanverth@google.com>
This will replace needing to call FontMgr.RefDefault()
just to call MakeTypefaceFromData().
Change-Id: I72a8c3be62267f6c54c48a5309ef9351acb16768
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/421916
Reviewed-by: Ben Wagner <bungeman@google.com>
Reviewed-by: Mike Reed <reed@google.com>
