Commit Graph

22028 Commits

Author SHA1 Message Date
djsollen
48d6f88479 Repurpose Release_Developer BUILDTYPE and remove SK_DEVELOPER.
The Release_Developer build type is now used to build Skia with
release level optimizations but still enable SK_DEBUG. This in turn
means that SkASSERTS and SkRTConf are available in this mode.

Further we can then remove SK_DEVELOPER as a define as it is true
iff SK_DEBUG is true.
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1927583002
DOCS_PREVIEW= https://skia.org/?cl=1927583002

Review-Url: https://codereview.chromium.org/1927583002
2016-04-27 13:37:23 -07:00
robertphillips
2f1c42e844 Refactor drawContext/RenderTarget creation
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1914883002

Review-Url: https://codereview.chromium.org/1914883002
2016-04-27 13:34:01 -07:00
bsalomon
4eeccc9de7 Add tests for volatile paths to GrShapeTest
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1923403003

Review-Url: https://codereview.chromium.org/1923403003
2016-04-27 13:30:25 -07:00
bsalomon
409ed73237 Add tests for empty GrShapes.
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1927673002

Review-Url: https://codereview.chromium.org/1927673002
2016-04-27 12:36:02 -07:00
bungeman
77a8ab25c8 Simplify style handling in custom font manager.
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1915103002

Review-Url: https://codereview.chromium.org/1915103002
2016-04-27 12:30:25 -07:00
halcanary
eabaf79824 SkDocument::CreateXPS fix roll
NOTRY=true
TBR=reed@google.com

Review-Url: https://codereview.chromium.org/1918713006
2016-04-27 12:07:55 -07:00
jvanverth
a4b0fed3b7 Remove AttachmentInfo from VulkanViewer setup
It's not necessary to pass this information back up to the client;
we can store it in the TestContext if needed for Surface creation.

GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1920163004

Review-Url: https://codereview.chromium.org/1920163004
2016-04-27 11:42:21 -07:00
egdaniel
c355bc8dd1 Add work around for vulkan copies on the 5X
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1923963002

Review-Url: https://codereview.chromium.org/1923963002
2016-04-27 11:31:59 -07:00
senorblanco
900c367796 Image filters: de-nest SkImageFilter::Cache and Cache::Key.
This reduces the public header, and also allows us to foward-
declare them, so we can remove an #include from all the
SkDevice subclass headers.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1919063002

Review-Url: https://codereview.chromium.org/1919063002
2016-04-27 11:31:23 -07:00
halcanary
f8e8d5ee43 SkPDF/None: fix compilation
TBR=stephana@google.com

Review-Url: https://codereview.chromium.org/1929593002
2016-04-27 10:57:52 -07:00
robertphillips
6c7e325236 Bring sk_sp to GrDrawContext
This is split out of: https://codereview.chromium.org/1914883002/ (Refactor drawContext/RenderTarget creation)

GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1918003003

Review-Url: https://codereview.chromium.org/1918003003
2016-04-27 10:47:51 -07:00
bungeman
b4bb7d8255 Add oblique as a slant.
Some fonts have italic and oblique in the same family, see

http://lucidafonts.com/fonts/family/lucida-sans
http://www.gust.org.pl/projects/e-foundry/latin-modern

GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1921903002

Chromium side change at https://crrev.com/1921503006/ .

Review-Url: https://codereview.chromium.org/1921903002
2016-04-27 10:21:05 -07:00
rmistry
12135f50bd Add dry_run_access_list to Skia's cq.proto
This will give all users who have access to our trybots access to our dry run CQ as well.

BUG=591183
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1926783002

Review-Url: https://codereview.chromium.org/1926783002
2016-04-27 09:43:21 -07:00
mtklein
569b02151f Revert of Enable flattening of SkRecordedDrawable (patchset #8 id:140001 of https://codereview.chromium.org/1913843002/ )
Reason for revert:
Release mode bots appear to be crashing while loading .skp files in nanobench.

Original issue's description:
> Enable flattening of SkRecordedDrawable
>
> BUG=skia:
> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1913843002
>
> Committed: https://skia.googlesource.com/skia/+/d636950e8ecba89c0021ce4e76037c67aa6ee2cd

TBR=djsollen@google.com,reed@google.com,msarett@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Review-Url: https://codereview.chromium.org/1923393002
2016-04-27 09:29:34 -07:00
msarett
d636950e8e Enable flattening of SkRecordedDrawable
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1913843002

Review-Url: https://codereview.chromium.org/1913843002
2016-04-27 09:03:17 -07:00
djsollen
f62b2354b3 Upgrade Android Gradle plugins
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1926743002

Review-Url: https://codereview.chromium.org/1926743002
2016-04-27 08:48:56 -07:00
reed
1e7f5e708e remove 'deprecated' region from SkDraw
Most call-sites that used it just took its bounds, so it was trivial to convert them
to get the bounds of the RasterClip. Two clients wanted the actual region:
1. layeriter for android
2. pdf

Android already only has BW clips, so should be safe.
PDF now overrides its clip methods to ensure that all clips are BW.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1925693002

Review URL: https://codereview.chromium.org/1925693002
2016-04-27 07:49:17 -07:00
halcanary
4b6566644f SkDocument/PDF: new API
has a pdf/a switch.
sets metadata in factory.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1916093002

Review URL: https://codereview.chromium.org/1916093002
2016-04-27 07:45:18 -07:00
halcanary
d155607171 tools/pdf-comparison.sh: stop relying on /usr/bin/timeout
NOTRY=true
TBR=

Review URL: https://codereview.chromium.org/1921943006
2016-04-27 07:44:03 -07:00
rmistry
6f47dbaff5 Treat kIncompleteInput as successes in get_images_from_skps
Context:
https://bugs.chromium.org/p/skia/issues/detail?id=5226
and
https://codereview.chromium.org/1844713003/diff/160001/tools/get_images_from_skps.cpp#newcode83

BUG=skia:5226
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1917413003

Review URL: https://codereview.chromium.org/1917413003
2016-04-27 07:31:23 -07:00
stephana
338eaea602 Disable ReadWriteAlpha on TSAN
BUG=skia:
R=borenet
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1927573002

Review URL: https://codereview.chromium.org/1927573002
2016-04-27 06:50:03 -07:00
bsalomon
72dc51c288 Add support for building GrShape from SkPath and more tests
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1922713002

Review URL: https://codereview.chromium.org/1922713002
2016-04-27 06:46:23 -07:00
msarett
92bd2e8f32 Add comments and sanity checks to parsing of ICC headers
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1922073003

Review URL: https://codereview.chromium.org/1922073003
2016-04-27 06:12:26 -07:00
borenet
6f4c1aa8f9 Don't isolate the Skia repo for Swarming compiles
BUG=skia:
NOTREECHECKS=true
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1886343002

Review URL: https://codereview.chromium.org/1886343002
2016-04-27 06:06:25 -07:00
brianosman
3ec513632c Change default window size on Windows.
The OS tends to pick a very large size if you let it. Instead, choose a
smaller (fixed) window (matching what we currently use on Linux).

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1919133004

Review URL: https://codereview.chromium.org/1919133004
2016-04-26 16:51:03 -07:00
brianosman
adf4fa6fde Ensure we're operating on the correct texture when generating mipmaps.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1915403004

Review URL: https://codereview.chromium.org/1915403004
2016-04-26 16:48:06 -07:00
robertphillips
ed086cae88 Revert of Remove gpu-specialization of SkSpecialImage (patchset #5 id:80001 of https://codereview.chromium.org/1918993002/ )
Reason for revert:
N6 bot has gone red

Original issue's description:
> Remove gpu-specialization of SkSpecialImage
>
> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1918993002
>
> Committed: https://skia.googlesource.com/skia/+/0533d6e4142c2787d6d3c325ef0d8d1962292cad

TBR=reed@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/1921393003
2016-04-26 15:02:25 -07:00
brianosman
5529b7dccc Remove unmatched restore call in gamma GM
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1917303002

Review URL: https://codereview.chromium.org/1917303002
2016-04-26 14:37:27 -07:00
robertphillips
0533d6e414 Remove gpu-specialization of SkSpecialImage
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1918993002

Review URL: https://codereview.chromium.org/1918993002
2016-04-26 14:33:36 -07:00
bsalomon
71de3537f6 Don't buffer stdout in DM
TBR=egdaniel@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1922223002

Review URL: https://codereview.chromium.org/1922223002
2016-04-26 14:27:21 -07:00
deanm
83496425e3 pathops: Split loop type cubics only when there is a self-intersection.
The ComplexBreak code comes from Loop and Blinn, which requires loops to be
split if either double point is visible.  However for intersection loops only
need to be split when there is actually a self-intersection (when both double
points are in [0, 1]).  This patch splits cubics much less often so the output
doesn't have extra segments unless the input had a self-intersecting loop.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1920663002

Review URL: https://codereview.chromium.org/1920663002
2016-04-26 14:15:21 -07:00
deanm
b77821c30c pathops: Cosmetic only change, update comments around ComplexBreak().
Rename loopT to splitT and make it clearer that it is not just
self intersecting loop cubics that are split.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1921173003

Review URL: https://codereview.chromium.org/1921173003
2016-04-26 14:12:22 -07:00
deanm
12670eb63b pathops: Add missing header guards in two files.
Guards were missing in SkIntersectionHelper.h and
SkPathOpsTSect.h.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1914873002

Review URL: https://codereview.chromium.org/1914873002
2016-04-26 14:09:01 -07:00
msarett
0b55664afc Update SK_IMAGE_VERSION, run nanobench on its own image set
I've added a new directory to the cloud
(gs://chromium-skia-gm/skimage/v4/nanobench) which will
allow us to run dm and nanobench on different sets of
images.

The dm image set will stay the same, and includes
incomplete images, edge cases images, etc.

The nanobench set is much smaller, and includes jpegs and
pngs that we've found useful to bench in the past, plus
a couple of each for the other formats.  We can refine
this set as we move forward (and may also want to monitor
these images on perf.skia.org).

For now the goal is to reduce nanobench runtime by not
testing on many, many obscure images that are not
particularly interesting to time.

The actual change to use nanobench images is in:
https://codereview.chromium.org/1917903003/

BUG=skia:5181
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1913813004

Review URL: https://codereview.chromium.org/1913813004
2016-04-26 13:08:57 -07:00
msarett
f3dc188514 Remove redundant tests to make DM a little faster
This should help with some of the slow down caused by
https://codereview.chromium.org/1907593004.

BUG=skia:5181
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1923533002

Review URL: https://codereview.chromium.org/1923533002
2016-04-26 13:06:38 -07:00
msarett
c5db972fce Remove redundant test
FlattenDrawable test now exercises the use of custom unflatten procs.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1917183002

Review URL: https://codereview.chromium.org/1917183002
2016-04-26 12:59:47 -07:00
bsalomon
47cc769118 Add initial implementation of GrShape and GrStyle classes and tests
The initial intent is to use GrShape to simplify the mask blur code paths. However, I also want to use this to explore a more unified drawing code flow for different geometry types. The goal is to have a single representation for geometries+styling that attempts to always keep the geometry in the simplest form (e.g. preferring rrects to paths). It also allows for converting styling information into modified geometry and for computing consistent keys.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1822723003

Committed: https://skia.googlesource.com/skia/+/c885dacfe4625af8b0e2e5c6e8a8ae8dc2d620a8

Committed: https://skia.googlesource.com/skia/+/824e58fc6df8fc149d9675f577f7deeaba698b09

Review URL: https://codereview.chromium.org/1822723003
2016-04-26 12:56:00 -07:00
liyuqian
cbaafc34bc Add runhooks to multi_repo_trybots
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1924573002
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=1924573002

Review URL: https://codereview.chromium.org/1924573002
2016-04-26 12:54:05 -07:00
halcanary
dc09f131d4 pdf comparison tool
NOTRY=true

Review URL: https://codereview.chromium.org/1924513002
2016-04-26 12:43:59 -07:00
djsollen
e6e2e54036 Update android docs for how to sync source code
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1921023002
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=1921023002

Review URL: https://codereview.chromium.org/1921023002
2016-04-26 12:38:52 -07:00
halcanary
298ab76f1a bin/fetch-skps: print instruction on error
NOTRY=true

Review URL: https://codereview.chromium.org/1919133003
2016-04-26 12:38:47 -07:00
borenet
8ffab6fc0e Whitespace change to trigger bots after recipe fix
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1922783003
NOTREECHECKS=true

Review URL: https://codereview.chromium.org/1922783003
2016-04-26 12:16:52 -07:00
bsalomon
82ecc5773f Revert of Add initial implementation of GrShape and GrStyle classes and tests (patchset #11 id:280001 of https://codereview.chromium.org/1822723003/ )
Reason for revert:
test failing

Original issue's description:
> Add initial implementation of GrShape and GrStyle classes and tests
>
> The initial intent is to use GrShape to simplify the mask blur code paths. However, I also want to use this to explore a more unified drawing code flow for different geometry types. The goal is to have a single representation for geometries+styling that attempts to always keep the geometry in the simplest form (e.g. preferring rrects to paths). It also allows for converting styling information into modified geometry and for computing consistent keys.
>
> BUG=skia:
> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1822723003
>
> Committed: https://skia.googlesource.com/skia/+/c885dacfe4625af8b0e2e5c6e8a8ae8dc2d620a8
>
> Committed: https://skia.googlesource.com/skia/+/824e58fc6df8fc149d9675f577f7deeaba698b09

TBR=robertphillips@google.com,egdaniel@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Review URL: https://codereview.chromium.org/1919243002
2016-04-26 08:41:47 -07:00
rmistry
cda08f8490 Return error code when get_images_from_skps has failures.
BUG=skia:4981
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1916183002

Review URL: https://codereview.chromium.org/1916183002
2016-04-26 08:27:49 -07:00
msarett
002c92bcbf Do not globally register drawables in test code
TBR=reed@google.com
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1922853003

Review URL: https://codereview.chromium.org/1922853003
2016-04-26 08:20:14 -07:00
herb
5d4943caae Add guards for edge cases.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1915263002

Review URL: https://codereview.chromium.org/1915263002
2016-04-26 08:15:27 -07:00
egdaniel
b1b59576ba Remove unnessary uniform barriers in Vulkan.
Also added a fix to descriptor set allocation.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1914053004

Review URL: https://codereview.chromium.org/1914053004
2016-04-26 08:15:09 -07:00
jvanverth
6234006727 Add automatic generation of mipmaps to Vulkan
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1916563002

Review URL: https://codereview.chromium.org/1916563002
2016-04-26 08:01:44 -07:00
jvanverth
9d5e47f354 Fix animation with stats in VulkanViewer
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1918083003

Review URL: https://codereview.chromium.org/1918083003
2016-04-26 08:01:33 -07:00
reed
86ae3d1614 make context() virtual on device
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1922123002

TBR=robertphilips

Review URL: https://codereview.chromium.org/1922123002
2016-04-26 06:57:31 -07:00