msarett
5406d6f39a
Scanline decoding for bmp
...
Redesigns SkScanlineDecoder.h to indicate the ordering
in which the scanlines are provided
Refactors SkSwizzler::Fill() to include the zeroInit check
and to actually be correct.
BUG=skia:3257
BUG=skia:4198
Review URL: https://codereview.chromium.org/1287423002
2015-08-31 06:55:13 -07:00
bsalomon
8db52b6367
Revert of By default purge resources that haven't been used for 64 flushes (patchset #3 id:40001 of https://codereview.chromium.org/1316233003/ )
...
Reason for revert:
Blocking roll
Original issue's description:
> By default purge resources that haven't been used for 64 flushes
>
> BUG=skia:4258
>
> Committed: https://skia.googlesource.com/skia/+/85047175508a24f43eef49359bed215a2a3bb104
>
> R=robertphillips@google.com
>
> Committed: https://skia.googlesource.com/skia/+/71d0c33068d41878cc3117f3761f49300f6b3d54
TBR=robertphillips@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:4258
Review URL: https://codereview.chromium.org/1316263003
2015-08-31 03:24:13 -07:00
Brian Salomon
71d0c33068
By default purge resources that haven't been used for 64 flushes
...
BUG=skia:4258
Committed: https://skia.googlesource.com/skia/+/85047175508a24f43eef49359bed215a2a3bb104
R=robertphillips@google.com
Review URL: https://codereview.chromium.org/1316233003 .
2015-08-30 22:12:11 -04:00
rmistry
1a7f8f4a81
Update SKP version
...
Automatic commit by the RecreateSKPs bot.
TBR=
NO_MERGE_BUILDS
Review URL: https://codereview.chromium.org/1316403003
2015-08-30 00:19:11 -07:00
bsalomon
6d2a203117
Fix leak in test create for perlin noise fp
...
TBR=robertphillips@google.com
Review URL: https://codereview.chromium.org/1319723005
2015-08-29 06:27:29 -07:00
bsalomon
c21b09eec9
Change SkShader;asFragmentProcessor signature to no longer take skpaint\grcolor*
...
Committed: https://skia.googlesource.com/skia/+/ecfdc251be71f3d634e76afdd6375bf55fc061aa
Review URL: https://codereview.chromium.org/1316513002
2015-08-28 18:46:56 -07:00
rmistry
a511e6ad10
Revert of Change SkShader;asFragmentProcessor signature to no longer take skpaint\grcolor* (patchset #8 id:140001 of https://codereview.chromium.org/1316513002/ )
...
Reason for revert:
Primary suspect in failing DEPS rolls:
* https://codereview.chromium.org/1315753006
* https://codereview.chromium.org/1308323006
* https://codereview.chromium.org/1320903004
Primary suspect because the failing win bots did not fail in https://codereview.chromium.org/1315753005
Original issue's description:
> Change SkShader;asFragmentProcessor signature to no longer take skpaint\grcolor*
>
> Committed: https://skia.googlesource.com/skia/+/ecfdc251be71f3d634e76afdd6375bf55fc061aa
TBR=joshualitt@google.com ,wangyix@google.com,robertphillips@google.com,bsalomon@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/1313573005
2015-08-28 17:16:50 -07:00
bsalomon
ecfdc251be
Change SkShader;asFragmentProcessor signature to no longer take skpaint\grcolor*
...
Review URL: https://codereview.chromium.org/1316513002
2015-08-28 14:33:47 -07:00
reed
264873d5a8
fix bounds check for ctables (thanks Hal)
...
BUG=skia:
Review URL: https://codereview.chromium.org/1319973008
2015-08-28 12:38:04 -07:00
benjaminwagner
5b4c69e555
Change 900k to 910k in another location.
...
BUG=skia:4063
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=1317373002
Review URL: https://codereview.chromium.org/1317373002
2015-08-28 12:23:54 -07:00
mtklein
e0f06a4752
Example CMake build for Skia.
...
This works only on Mac, probably only on 64-bit,
and doesn't support SkCodec.
BUG=skia:4269
Review URL: https://codereview.chromium.org/1319543003
2015-08-28 11:51:07 -07:00
benjaminwagner
fd0eca2583
Update CT documentation on Skia site.
...
BUG=skia:4063
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=1314413002
Review URL: https://codereview.chromium.org/1314413002
2015-08-28 10:34:47 -07:00
reed
b236d1a37b
change colortable to use factory for reinflating, check for empty
...
BUG=525763
Review URL: https://codereview.chromium.org/1307023004
2015-08-28 10:14:18 -07:00
bungeman
62ce0303fb
Replace SkPin32 with SkTPin and remove.
...
SkPin32 is already just forwarding to SkTPin, so convert existing
users and remove SkPin32.
Review URL: https://codereview.chromium.org/1314583003
2015-08-28 09:09:32 -07:00
bungeman
7445cef42f
Remove sys/types.h include from SkTypes.h.
...
It appears this was added to support SkToOffT, but SkToOffT
is no longer used, so it is removed as well.
Review URL: https://codereview.chromium.org/1306963004
2015-08-28 07:39:30 -07:00
msarett
d02b99f106
Interlaced gifs without the iterator
...
BUG=skia:
Review URL: https://codereview.chromium.org/1315583003
2015-08-28 07:36:55 -07:00
bungeman
761cf6186e
Clean up SkTLogic.
...
This change regularizes Skia's type traits so that when <type_traits>
can finally be used the transition is easier. Various traits are
renamed to match <type_traits> and placed in the skstd namespace.
Current users of these traits are updated.
Review URL: https://codereview.chromium.org/1317593004
2015-08-28 07:09:20 -07:00
bsalomon
4204800cd8
Convert child FPs from refs to pending executions when parent converts
...
Review URL: https://codereview.chromium.org/1315923004
2015-08-27 16:43:48 -07:00
bungeman
0153dea2f9
Some codec code formatting cleanup.
...
While looking at users of SkTAddOffset, some unwanted casts were
found. These casts are removed and the lines reformatted. However,
the formatting of the rest of the file was unhappy, so this is really
just a formatting clean-up.
Review URL: https://codereview.chromium.org/1301393010
2015-08-27 16:43:42 -07:00
rmistry
b6bf36785c
Revert of By default purge resources that haven't been used for 64 flushes (patchset #2 id:20001 of https://codereview.chromium.org/1316233003/ )
...
Reason for revert:
Suspect for the failed "webgl_conformance on Intel GPU on Mac" test on 2 DEPS rolls:
https://codereview.chromium.org/1320943002/
https://codereview.chromium.org/1315703003/
Example build: http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/105501
Original issue's description:
> By default purge resources that haven't been used for 64 flushes
>
> BUG=skia:4258
>
> Committed: https://skia.googlesource.com/skia/+/85047175508a24f43eef49359bed215a2a3bb104
TBR=robertphillips@google.com ,bsalomon@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:4258
Review URL: https://codereview.chromium.org/1319053002
2015-08-27 13:53:48 -07:00
mdempsky
38f1f6f9e5
Remove overly complicated GR_CREATE_STATIC_PROCESSOR macro
...
This macro was responsible for producing code like:
static SkAlignedStorage<sizeof(Foo)> g_gFoo_Storage;
static Foo* gFoo = new(g_gFoo_Storage.get()) Foo;
static SkAutoTDestroy<Foo> gFoo_ad(gFoo);
which would allocate static storage for an object of type Foo
(g_gFoo_Storage), lazily instantiate the object in that memory (via
gFoo's initializer), and then ensure that at global destruction time
the object is destroyed (via gFoo_Ad's destructor).
However, the exact same effect is achieved by just writing:
static Foo gFoo;
Review URL: https://codereview.chromium.org/1314763009
2015-08-27 12:57:01 -07:00
mtklein
6904d1d3f1
Add a note about (x*y+255)/256.
...
BUG=skia:4117
Review URL: https://codereview.chromium.org/1312283004
2015-08-27 12:05:57 -07:00
mtklein
e01008fdbc
Add trace event to SkPicture analysis.
...
RE: https://codereview.chromium.org/1319723002/
This should mark out the time spent to support hasText(),
willPlayBackBitmaps(), and numSlowPaths() in about:tracing.
BUG=skia:
Review URL: https://codereview.chromium.org/1317103002
2015-08-27 10:39:07 -07:00
hendrikw
885bf09255
skia: add ability to load command_buffer_gles2
...
BUG=skia:
Review URL: https://codereview.chromium.org/1306823003
2015-08-27 10:38:39 -07:00
ssid
33c594c961
[tracing] Add support for skia caches to dump memory stats
...
Dump the memory statistics of resource cache and glyph cache using the
SkTraceMemoryDump interface.
BUG=chromium:503168
Review URL: https://codereview.chromium.org/1313793004
2015-08-27 09:23:54 -07:00
bsalomon
8504717550
By default purge resources that haven't been used for 64 flushes
...
BUG=skia:4258
Review URL: https://codereview.chromium.org/1316233003
2015-08-27 08:47:47 -07:00
halcanary
aaf951d537
nullptr isn't an int; this is what we want
...
Review URL: https://codereview.chromium.org/1306753006
2015-08-27 08:32:26 -07:00
halcanary
96fcdcc219
Style Change: NULL->nullptr
...
DOCS_PREVIEW= https://skia.org/?cl=1316233002
Review URL: https://codereview.chromium.org/1316233002
2015-08-27 07:41:16 -07:00
mtklein
435af2f736
SkColorCubeFilter_opts: start with a statically-initializable zero.
...
SkPMFloat(0) and SkPMFloat(0,0,0,0) end up with the same value,
but the first goes through math to get there. The second is a lot more
transparent to the compiler, and should compile all the way down to
just `xorps xmmN,xmmN` or even be optimized away.
Didn't measure any additional benefit from hoisting the zero outside
the loop and writing `SkPMFloat color = zero;`.
Perf win is <2%.
BUG=skia:
Review URL: https://codereview.chromium.org/1314763007
2015-08-27 06:46:03 -07:00
chinmaygarde
fe495f0bae
Fix assertion about GPU memory size when the target is not FBO 0
...
Review URL: https://codereview.chromium.org/1313783007
2015-08-27 06:36:33 -07:00
bsalomon
ac856c97ac
Remove GrStagedProcessor, remove the word Stage as it applies to FPs
...
Committed: https://skia.googlesource.com/skia/+/24243446cdf7b7e4e132c2a0c387c7723777e0c7
Review URL: https://codereview.chromium.org/1307223004
2015-08-27 06:30:17 -07:00
mdempsky
a04c650459
Remove deprecated usage of SkNEW and SkDELETE
...
Review URL: https://codereview.chromium.org/1311713003
2015-08-26 15:27:59 -07:00
senorblanco
7b7ecfc046
Fix clipped lighting image filters.
...
The CPU path for lighting image filters was not adjusting the filter
matrix to accommodate srcOffset, resulting in incorrectly-positioned
lights. (The GPU path was doing this correctly.)
This change adds a new test case to the imagefiltersclipped GM,
so it will need new baselines.
BUG=skia:
Review URL: https://codereview.chromium.org/1310053004
2015-08-26 14:26:40 -07:00
reed
d5c448fd85
make cacherator thread-safe
...
hoisted from https://codereview.chromium.org/1282363002 as that CL is going to take a while to finish
BUG=skia:
TBR=
Review URL: https://codereview.chromium.org/1313423002
2015-08-26 14:16:43 -07:00
mtklein
9c84b112aa
Add white variants to TextBench
...
Might be worth a look.
BUG=skia:
Review URL: https://codereview.chromium.org/1319503003
2015-08-26 13:41:31 -07:00
halcanary
385fe4d4b6
Style Change: SkNEW->new; SkDELETE->delete
...
DOCS_PREVIEW= https://skia.org/?cl=1316123003
Review URL: https://codereview.chromium.org/1316123003
2015-08-26 13:07:49 -07:00
mtklein
5015176adf
trifurcate blit_mask_d32_a8 into _black, _opaque, _general.
...
We used to split the NEON code this way, and just had one path for SSE.
It's unclear to me testing locally if there's any major win here, but there's at least a small one.
No pixel diffs or even any math changes, just folding constants through.
BUG=skia:4117
Review URL: https://codereview.chromium.org/1304373006
2015-08-26 12:35:14 -07:00
joshualitt
e46cf96ef5
Write a gm to verify append large glyph as path works
...
BUG=chromium:522846
Review URL: https://codereview.chromium.org/1316443006
2015-08-26 11:19:56 -07:00
bungeman
897640e4ca
Add HangingS.ttf to test large flourish caps.
...
This is designed to allow local testing of the related bug.
BUG=chromium:522846
Review URL: https://codereview.chromium.org/1315983002
2015-08-26 10:44:48 -07:00
caryclark
5cb00a9573
zero-length cap fix
...
Re-land; layout tests are suppressed and gm differences are understood.
A merge conflict prevented a automatic reland.
If the endcap is not butt, draw the endcaps even when the line
has zero length.
If the dash length is zero, generate a zero length line segment.
Treat a move followed by a close as a move followed by a zero-length
line.
TBR=reed@google.com
BUG=422974
Review URL: https://codereview.chromium.org/1314213002
2015-08-26 09:04:55 -07:00
mtklein
a16af21b17
Have SkPicture::willPlayBackBitmaps() count SkImages too.
...
New unit test fails at head but passes with this patch.
BUG=skia:4225
Review URL: https://codereview.chromium.org/1319723002
2015-08-26 08:14:52 -07:00
joshualitt
bcf33d5c06
Rename GrBWFillRectBatch to GrNonAAFillRectBAtch
...
TBR=bsalomon@google.com
BUG=skia:
Review URL: https://codereview.chromium.org/1319733002
2015-08-26 08:10:35 -07:00
rmistry
4bf69f7bbc
Revert of Remove GrStagedProcessor, remove the word Stage as it applies to FPs (patchset #6 id:90001 of https://codereview.chromium.org/1307223004/ )
...
Reason for revert:
Causes bot failures:
https://uberchromegw.corp.google.com/i/client.skia/builders/Test-Mac10.9-Clang-MacMini6.2-GPU-HD4000-x86_64-Debug/builds/1639
https://uberchromegw.corp.google.com/i/client.skia/builders/Test-Ubuntu-GCC-ShuttleA-GPU-GTX660-x86_64-Debug/builds/1702
https://uberchromegw.corp.google.com/i/client.skia.android/builders/Test-Android-GCC-NexusPlayer-GPU-PowerVR-x86-Debug/builds/1223
Original issue's description:
> Remove GrStagedProcessor, remove the word Stage as it applies to FPs
>
> Committed: https://skia.googlesource.com/skia/+/24243446cdf7b7e4e132c2a0c387c7723777e0c7
TBR=joshualitt@google.com ,egdaniel@google.com,bsalomon@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/1306803003
2015-08-26 06:48:27 -07:00
joshualitt
8cce8f139e
Modify GrBWFillRectBatch to use GrQuad
...
BUG=skia:
Committed: https://skia.googlesource.com/skia/+/c611b5afbef6df6c02e949fdf092aab2bb7e0e2e
Review URL: https://codereview.chromium.org/1311793002
2015-08-26 06:23:39 -07:00
mtklein
002c2ce66b
stray malloc/free -> sk_malloc/sk_free
...
BUG=skia:
TBR=bungeman@google.com
Review URL: https://codereview.chromium.org/1315123002
2015-08-26 05:43:22 -07:00
bsalomon
24243446cd
Remove GrStagedProcessor, remove the word Stage as it applies to FPs
...
Review URL: https://codereview.chromium.org/1307223004
2015-08-26 05:39:18 -07:00
bungeman
60e0fee6d4
Remove include of stdlib.h from SkTypes.h.
...
Unfortunately, immintrin.h (which is also included by SkTypes)
includes xmmintrin.h which includes mm_malloc.h which includes
stdlib.h for malloc even though, from the implementation, it is
difficult to see why.
Fortunately, arm_neon.h does not seem to be involved in such
shenanigans, so building for Android will keep things sane.
TBR=reed@google.com
Doesn't change Skia API, just moves an include.
Review URL: https://codereview.chromium.org/1313203003
2015-08-26 05:15:46 -07:00
rmistry
8d624bd44e
Add markdown for Infra troopers
...
BUG=skia:4251
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=1313993002
Review URL: https://codereview.chromium.org/1313993002
2015-08-25 13:39:41 -07:00
caryclark
45398dff71
Reland of ix zero-length tangent (patchset #1 id:1 of https://codereview.chromium.org/1312243002/ )
...
Reason for revert:
Layout suppression has landed, and verified that Skia gm test changes are correct.
Original issue's description:
> Revert of fix zero-length tangent (patchset #2 id:20001 of https://codereview.chromium.org/1311273002/ )
>
> Reason for revert:
> causes layout test to draw differently -- new drawing is more correct. Reverting until layout test ignore is landed.
>
> Original issue's description:
> > fix zero-length tangent
> >
> > If the end point and the control point are the same, computing
> > the tangent will result in (0, 0). In this case, use the prior
> > control point instead.
> >
> > R=reed@google.com
> >
> > BUG=skia:4191
> >
> > Committed: https://skia.googlesource.com/skia/+/7544124fb8ee744f68f549a353f8a9163cd7432d
>
> TBR=reed@google.com
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=skia:4191
>
> Committed: https://skia.googlesource.com/skia/+/91298b47c547b2ab4697038c04685af957bd1416
TBR=reed@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:4191
Review URL: https://codereview.chromium.org/1320473002
2015-08-25 13:19:06 -07:00
joshualitt
b5fb5af573
Fix for MSAN unintialized value
...
BUG=524094
Review URL: https://codereview.chromium.org/1320433002
2015-08-25 12:10:54 -07:00