Commit Graph

33229 Commits

Author SHA1 Message Date
Brian Osman
57337d90a5 Reland "Add SkColorSpaceXform_skcms"
This reverts commit 8103ecae7b.

Reason for revert: Investigated the 565 diffs, they appear to be *more* correct.

Original change's description:
> Revert "Add SkColorSpaceXform_skcms"
> 
> This reverts commit 67f62b1a61.
> 
> Reason for revert: I want to investigate the image/colorimage gold diffs. May be correct, but some of them are pretty large.
> 
> Original change's description:
> > Add SkColorSpaceXform_skcms
> > 
> > Currently only enabled in Skia dev builds. Passes all unit
> > tests. Has some GM differences, but nothing major.
> > 
> > Bug: skia:
> > Change-Id: Ib87f8cff44649c731e829f063ccef448d67d1910
> > Reviewed-on: https://skia-review.googlesource.com/112520
> > Commit-Queue: Brian Osman <brianosman@google.com>
> > Reviewed-by: Mike Klein <mtklein@google.com>
> 
> TBR=mtklein@google.com,brianosman@google.com,reed@google.com
> 
> Change-Id: Ib4d7174f5c2700d6f742f488e740e5a6c87ac7a8
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: skia:
> Reviewed-on: https://skia-review.googlesource.com/113880
> Reviewed-by: Brian Osman <brianosman@google.com>
> Commit-Queue: Brian Osman <brianosman@google.com>

TBR=mtklein@google.com,brianosman@google.com,reed@google.com

Change-Id: I6501ff55349a6aeed62bb64afc47f789e8cc3460
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: skia:
Reviewed-on: https://skia-review.googlesource.com/114040
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
2018-03-13 14:00:43 +00:00
Brian Salomon
4000a5e622 Remove yoda rule from style guide
No-Try: true
Docs-Preview: https://skia.org/?cl=114023
Change-Id: Iefd2205b1aa68a19a835b033464a3407edb7cf18
Reviewed-on: https://skia-review.googlesource.com/114023
Reviewed-by: Mike Klein <mtklein@chromium.org>
2018-03-13 13:52:10 +00:00
Cary Clark
2f06a53b25 fix a couple pathops fuzzers
This fixes these:
 src/pathops/SkOpCoincidence.cpp -- 1 crash-causing fuzzes
 src/pathops/SkOpSpan.h -- 1 crash-causing fuzzes

R=kjlubick@google.com

Bug: skia:
Change-Id: I2b0dbd74757a32e522901753e2e17114a1a9f79b
Reviewed-on: https://skia-review.googlesource.com/113751
Commit-Queue: Cary Clark <caryclark@skia.org>
Reviewed-by: Kevin Lubick <kjlubick@google.com>
2018-03-13 12:41:42 +00:00
Cary Clark
4ce53a6ffd remove paint flatten unflatten from generated docs
No-Try: true
Docs-Preview: https://skia.org/?cl=114014
Bug: skia:6898
Change-Id: Ic53e3b9041576888a1d533cd9ef0f575e35cb0bc
Reviewed-on: https://skia-review.googlesource.com/114014
Commit-Queue: Cary Clark <caryclark@skia.org>
Reviewed-by: Cary Clark <caryclark@skia.org>
2018-03-13 12:33:32 +00:00
angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com
cc59c278ab Roll skia/third_party/externals/angle2/ e98b1b5d4..64e5ed2ab (7 commits)
e98b1b5d41..64e5ed2abd

$ git log e98b1b5d4..64e5ed2ab --date=short --no-merges --format='%ad %ae %s'
2018-03-09 lucferron Vulkan: Fix scissor clears + enable dEQP tests
2018-02-25 lfy GLES1: state: Define / initialize GLES1-specific states
2018-03-12 lucferron Vulkan: Enable culling rasterization state dEQP tests
2018-03-09 lucferron Vulkan: enable multiple draw* dEQP tests
2018-03-12 lfy Run clang-format on State.cpp
2018-03-09 lucferron Vulkan: Enable 16 additional tests for the scissor test
2018-03-09 lucferron Vulkan: Enable 1046 additional tests for blending rasterization states

Created with:
  roll-dep skia/third_party/externals/angle2


The AutoRoll server is located here: https://angle-skia-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Build-Debian9-Clang-x86_64-Release-ANGLE
TBR=stephana@google.com

Change-Id: Ib5fe881ce096940709a510f4473840b3c83b414d
Reviewed-on: https://skia-review.googlesource.com/113920
Reviewed-by: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
2018-03-13 02:02:47 +00:00
Brian Osman
c25e2693ab Fix several bugs in SkDebugCanvas/SkDrawCommand
This adds drawImageNine and drawRegion support, actually
serializes regions (badly) for clipRegion, and fixes bugs
in quite a few other draw commands (wrong op type, missing
factory registration, JSON attribute mismatch, etc...)

There are still some other draw virtuals missing, but even
getting Lattice to round-trip through JSON is going to be
a bunch of new code, and I didn't want to combine too much
new code with the fixes for existing bugs.

Change-Id: I13749a2d21f4a5ca5f5948b60fc11185bc46645f
Reviewed-on: https://skia-review.googlesource.com/113707
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
2018-03-13 01:35:26 +00:00
Brian Osman
8103ecae7b Revert "Add SkColorSpaceXform_skcms"
This reverts commit 67f62b1a61.

Reason for revert: I want to investigate the image/colorimage gold diffs. May be correct, but some of them are pretty large.

Original change's description:
> Add SkColorSpaceXform_skcms
> 
> Currently only enabled in Skia dev builds. Passes all unit
> tests. Has some GM differences, but nothing major.
> 
> Bug: skia:
> Change-Id: Ib87f8cff44649c731e829f063ccef448d67d1910
> Reviewed-on: https://skia-review.googlesource.com/112520
> Commit-Queue: Brian Osman <brianosman@google.com>
> Reviewed-by: Mike Klein <mtklein@google.com>

TBR=mtklein@google.com,brianosman@google.com,reed@google.com

Change-Id: Ib4d7174f5c2700d6f742f488e740e5a6c87ac7a8
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: skia:
Reviewed-on: https://skia-review.googlesource.com/113880
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
2018-03-12 21:07:29 +00:00
Brian Osman
67f62b1a61 Add SkColorSpaceXform_skcms
Currently only enabled in Skia dev builds. Passes all unit
tests. Has some GM differences, but nothing major.

Bug: skia:
Change-Id: Ib87f8cff44649c731e829f063ccef448d67d1910
Reviewed-on: https://skia-review.googlesource.com/112520
Commit-Queue: Brian Osman <brianosman@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
2018-03-12 20:26:19 +00:00
Ben Wagner
501c17cb91 Revert "IWYU for some test files starting with 'C'."
This reverts commit 1a462bd0fe.

Reason for revert: Broke android. Need to run android bot for these.

Original change's description:
> IWYU for some test files starting with 'C'.
> 
> Change-Id: I9a9596f7a941cdd8f01e055965c70a4b24438499
> Reviewed-on: https://skia-review.googlesource.com/113746
> Reviewed-by: Herb Derby <herb@google.com>
> Commit-Queue: Ben Wagner <bungeman@google.com>

TBR=bungeman@google.com,herb@google.com

Change-Id: Ic63c2fcc7457e442e9b29a9ccd429927e24e3b77
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://skia-review.googlesource.com/113841
Reviewed-by: Ben Wagner <bungeman@google.com>
Commit-Queue: Ben Wagner <bungeman@google.com>
2018-03-12 20:04:39 +00:00
skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com
1f66527ae2 Roll skia/third_party/externals/skcms/ 3ca91a31d..6cecdee60 (2 commits)
https://skia.googlesource.com/skcms/+log/3ca91a31d659..6cecdee60988

$ git log 3ca91a31d..6cecdee60 --date=short --no-merges --format='%ad %ae %s'
2018-03-12 mtklein static_assert -> assert
2018-03-12 brianosman Pack skcms_Curve better

Created with:
  roll-dep skia/third_party/externals/skcms


The AutoRoll server is located here: https://skcms-skia-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=stephana@google.com

Change-Id: I6852ef3fb30dd29c74455bbe9e23eb35dddff029
Reviewed-on: https://skia-review.googlesource.com/113860
Reviewed-by: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
2018-03-12 19:44:38 +00:00
Ben Wagner
1a462bd0fe IWYU for some test files starting with 'C'.
Change-Id: I9a9596f7a941cdd8f01e055965c70a4b24438499
Reviewed-on: https://skia-review.googlesource.com/113746
Reviewed-by: Herb Derby <herb@google.com>
Commit-Queue: Ben Wagner <bungeman@google.com>
2018-03-12 19:21:48 +00:00
Herb Derby
24f25dc8bc Move ComputeAxisAlignmentForHText to Rec.
BUG=skia:7515

Change-Id: I81d7950e508e0893f3591cc07596c10e8aaa636a
Reviewed-on: https://skia-review.googlesource.com/113749
Reviewed-by: Ben Wagner <bungeman@google.com>
Commit-Queue: Herb Derby <herb@google.com>
2018-03-12 18:50:48 +00:00
Mike Reed
18e7556371 move blur impl into core
Ever since we added drawShadow to the public api, blurs have necessarily
part of the core. This CL just formalizes that.

This should also allow us to have builds that exclude all of /effects (for code size)
and still be valid.

Will follow-up with a change to deprecate SkBlurMaskFilter and SkBlurQuality (both no longer needed).

Bug: skia:
Change-Id: Ifbbd8b47a30a0386d215726b67bcf1e8b84fb8f5
Reviewed-on: https://skia-review.googlesource.com/113713
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Mike Reed <reed@google.com>
2018-03-12 18:48:18 +00:00
Kevin Lubick
05cb229e58 Add oss-fuzz endpoint for PathMeasure
Bug: skia:
Change-Id: I3e051cefd6861b63bab33a1812674eacf67a35dd
Reviewed-on: https://skia-review.googlesource.com/113748
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
2018-03-12 18:43:38 +00:00
Robert Phillips
7611ed53b9 Temporary patch for Mus/Viz
Change-Id: I2936be1d5d0d4b65a9d04b6b9c8bf95b3644dad8
Reviewed-on: https://skia-review.googlesource.com/113714
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>
2018-03-12 17:56:08 +00:00
Herb Derby
95252607e6 Expose SkGlyphCache's alloc
BUG=skia:7515

Change-Id: I3716417bd3bcf721cc5262d872c0912105e15541
Reviewed-on: https://skia-review.googlesource.com/113744
Reviewed-by: Ben Wagner <bungeman@google.com>
Commit-Queue: Herb Derby <herb@google.com>
2018-03-12 17:55:08 +00:00
angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com
62557833c7 Roll skia/third_party/externals/angle2/ 391bda23b..e98b1b5d4 (4 commits)
391bda23b5..e98b1b5d41

$ git log 391bda23b..e98b1b5d4 --date=short --no-merges --format='%ad %ae %s'
2018-03-08 jmadill Framebuffer: Handle errors in checkStatus.
2018-03-12 lucferron gpu_test_expectations: Fix test for API overlap
2018-03-08 jiawei.shao ES31: Update dEQP-GLES31 geometry shader related test expectations
2018-03-09 kvark Update driver constants on program change. Comes with a new SamplerMetadataUpdateOnSetProgram test.

Created with:
  roll-dep skia/third_party/externals/angle2


The AutoRoll server is located here: https://angle-skia-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Build-Debian9-Clang-x86_64-Release-ANGLE
TBR=stephana@google.com

Change-Id: I3862be5332c7580abaf2ce36f680da2caf5c8c72
Reviewed-on: https://skia-review.googlesource.com/113728
Reviewed-by: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
2018-03-12 17:22:18 +00:00
Mike Reed
061c27825d fix writeImage when encode step fails, since data is null
Bug: skia:
Change-Id: Ifdfeba4b6d46a3169f60f3494245cf5abefe4c4a
Reviewed-on: https://skia-review.googlesource.com/113743
Commit-Queue: Mike Reed <reed@google.com>
Reviewed-by: Mike Reed <reed@google.com>
2018-03-12 17:15:23 +00:00
Herb Derby
d34c633442 Make SubpixelAlignment public
And, change the logic to handle NaN and Inf.
Small cleanup.

BUG=skia:7515

Change-Id: Ib02ad8f4bc66df57d226d4440ef6214fd2f813d6
Reviewed-on: https://skia-review.googlesource.com/113742
Reviewed-by: Ben Wagner <bungeman@google.com>
Commit-Queue: Herb Derby <herb@google.com>
2018-03-12 17:12:53 +00:00
Herb Derby
b1cdc786f9 Remove unused SkAutoGlyphCache constructor
Change-Id: I63c391130beacba37ca42d9d3a8f2aeaf108a03e
Reviewed-on: https://skia-review.googlesource.com/113717
Reviewed-by: Ben Wagner <bungeman@google.com>
Commit-Queue: Herb Derby <herb@google.com>
2018-03-12 17:10:18 +00:00
skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com
d90dd5b5fc Roll skia/third_party/externals/skcms/ e5ac7a7c8..3ca91a31d (1 commit)
https://skia.googlesource.com/skcms/+log/e5ac7a7c8d83..3ca91a31d659

$ git log e5ac7a7c8..3ca91a31d --date=short --no-merges --format='%ad %ae %s'
2018-03-12 brianosman Transform improvements

Created with:
  roll-dep skia/third_party/externals/skcms


The AutoRoll server is located here: https://skcms-skia-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=stephana@google.com

Change-Id: I39765e1ef737f7f014c30eb6c09789a81a9db451
Reviewed-on: https://skia-review.googlesource.com/113760
Reviewed-by: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
2018-03-12 17:07:48 +00:00
Ben Wagner
93adfd62de SkReadBuffer.h shouldn't include itself.
SkReadBuffer.h currently includes itself. Due to the include guards this
doesn't turn into an issue at compile time, but it is strange,
unecessary, and makes include-what-you-use unhappy.

Change-Id: I92df9ccf7c53ed2b5e9433ebf654dbf041b5e143
Reviewed-on: https://skia-review.googlesource.com/113716
Reviewed-by: Herb Derby <herb@google.com>
Commit-Queue: Ben Wagner <bungeman@google.com>
2018-03-12 16:22:38 +00:00
Brian Osman
d824406c4b Remove SK_SUPPORT_LEGACY_ADOBE_XYZ
Chrome stopped using this months ago

Change-Id: I5ea432b1545980680b2d54205513a55ef43dfc62
Reviewed-on: https://skia-review.googlesource.com/113711
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
2018-03-12 16:09:28 +00:00
Ben Wagner
cf81fa995f Use goma ensure_stop.
Bug: b/72128121
No-Try: true
Change-Id: I34ae57e1e6caa18fd22c0a9151206142323c094e
Reviewed-on: https://skia-review.googlesource.com/107560
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
2018-03-12 16:01:38 +00:00
Mike Reed
554aa6a9e2 update include path for SkBlurMask.h
fixes https://skia-review.googlesource.com/c/skia/+/113463

Bug: skia:
Change-Id: I78abc53bd802286e9fc65487551db17a2c737e1a
Reviewed-on: https://skia-review.googlesource.com/113715
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Mike Reed <reed@google.com>
2018-03-12 15:59:48 +00:00
Cary Clark
60ca8675e5 make paint flatten unflatten private
SkPaint flatten and unflatten rely
on interfaces that are not public,
SkReadBuffer and SkWriteBuffer.

R=reed@google.com
Bug: skia:6172
Change-Id: I487af9f8931c78daf763c51d9e0d3ff8ff440b22
Reviewed-on: https://skia-review.googlesource.com/112561
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Cary Clark <caryclark@skia.org>
2018-03-12 15:53:48 +00:00
Leon Scroggins III
c618a5b3e9 Update piex
Bug: oss-fuzz:6293
Change-Id: I05e344a879e9b0453e270dcd7c1974d311999e29
Reviewed-on: https://skia-review.googlesource.com/113709
Reviewed-by: Kevin Lubick <kjlubick@google.com>
Commit-Queue: Leon Scroggins <scroggo@google.com>
2018-03-12 15:39:28 +00:00
Herb Derby
c6b347e98f Fix overflow in blur for VERY wide bitmaps.
UBSAN has identified an int overflow in a byte offset calculation.

BUG=skia:7698

Change-Id: Ia9687c15bb63dc2953de5d9b9aad764a24e73a57
Reviewed-on: https://skia-review.googlesource.com/113710
Reviewed-by: Ben Wagner <bungeman@google.com>
Commit-Queue: Herb Derby <herb@google.com>
2018-03-12 15:32:18 +00:00
Cary Clark
91390c8ace pathmeasure fuzzer
R=kjlubick@google.com, reed@google.com
Bug: skia:
Change-Id: I16a8b09312e5d1d1783bd6a4b791636ad8f63889
Reviewed-on: https://skia-review.googlesource.com/113165
Reviewed-by: Mike Reed <reed@google.com>
Reviewed-by: Kevin Lubick <kjlubick@google.com>
Commit-Queue: Cary Clark <caryclark@skia.org>
2018-03-12 15:29:18 +00:00
Herb Derby
82a36ac4e6 Remove DetachCache and AttachCache.
Change-Id: I78697bed25f5d26ad91318b1fa3efbfc697a428a
Reviewed-on: https://skia-review.googlesource.com/113275
Reviewed-by: Ben Wagner <bungeman@google.com>
Commit-Queue: Herb Derby <herb@google.com>
2018-03-12 14:47:48 +00:00
Kevin Lubick
b5502b2012 Small cleanups suggested by ClangTidy
Bug: skia:
Cq-Include-Trybots: skia.primary:Test-Debian9-Clang-GCE-CPU-AVX2-x86_64-Release-All-SKNX_NO_SIMD
Change-Id: Idd95e359838fdaecbdccc3a2c5a1b36971f20b8b
Reviewed-on: https://skia-review.googlesource.com/113703
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
2018-03-12 14:44:18 +00:00
Cary Clark
689d02d4b4 harden pathmeasure and fix empty case
change int to unsigned (just make it uniform,
part of it was already unsigned)

change path by pointer to path by value
since it will be copied on write; fixes bug
where path changes from underneath measure

Allow empty paths to still initialize measure state.
This fixes the GM failure from the earlier check-in attempt
in CL 113269.

R=reed@google.com
Bug: skia:7675
Change-Id: I6296bbf75296ead826e54662b025277dd226e2b8
Reviewed-on: https://skia-review.googlesource.com/113246
Commit-Queue: Mike Reed <reed@google.com>
Reviewed-by: Mike Reed <reed@google.com>
2018-03-12 14:26:28 +00:00
Florin Malita
827af667bb Extend SkTrimPathEffect semantics
Add support for multiple contours, and an explicit "inverted" mode.

Bug: skia:
Change-Id: Iafadbbe9d4692f2467a4ef8585f7fcd9cee9566a
Reviewed-on: https://skia-review.googlesource.com/113270
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Florin Malita <fmalita@chromium.org>
2018-03-12 14:07:28 +00:00
Mike Reed
8e03f6930f remove unused ConvertRadiusToSigma from SkBlurMaskFilter
Bug: skia:
Change-Id: I1726f22fc40ad61b1b0485bcda6d383614da1fdb
Reviewed-on: https://skia-review.googlesource.com/113463
Commit-Queue: Mike Reed <reed@google.com>
Reviewed-by: Mike Reed <reed@google.com>
2018-03-12 13:26:48 +00:00
Eric Boren
3be061cd8b Fix binary size analysis
Bug: skia:
Change-Id: Ic739fd2d24ee2e9ed2c8b0dfdfc7118005350400
Reviewed-on: https://skia-review.googlesource.com/113300
Commit-Queue: Eric Boren <borenet@google.com>
Reviewed-by: Ravi Mistry <rmistry@google.com>
2018-03-12 13:23:58 +00:00
Cary Clark
566414ef70 fail on mdout error
bookmaker sent mdout errors to stdout, but did not return
failure, fooling skia-commit-bot into thinking that the
md files should be updated.

Continue to report all mdout errors in a file, but fail
once the errors are reported.

TBR=rmistry@google.com

Bug: skia:6898
Change-Id: Ic342dd9a6e4aeea29626b52efe7d2c4e53da155e
Reviewed-on: https://skia-review.googlesource.com/113701
Commit-Queue: Cary Clark <caryclark@skia.org>
Reviewed-by: Cary Clark <caryclark@skia.org>
2018-03-12 12:47:18 +00:00
Cary Clark
947326638a add SkDebugCanvas to undocumented
SkDumpCanvas was replaced by SkDebugCanvas as an undefined reference,
but SkDumpCanvas was not added to undocumented.bmh and caused bookmaker
to generate a broken version of site/user/api/SkCanva_Reference.md

The Skia-Commit-Bot detected that the SkCanvas_Reference.md was
changed, and checked it in, causing the online version of SkCanvas
like https://skia.org/user/api/SkCanvas_Reference#SkCanvas_readPixels
to be truncated.

I assume there is a mistake in bookmaker where it wrote an error
to stdout but failed to abort the tool when the *.md file was partially
written. I'll look into that.

This CL adds SkDebugCanvas to undocumented.bmh to fix the documentation.

TBR=brianosman@google.com,rmistry@google.com

Docs-Preview: https://skia.org/?cl=113700
Bug: skia:6898
Change-Id: Ib4e32eea3e56c178d0016f8ae392e28aab5ffafa
Reviewed-on: https://skia-review.googlesource.com/113700
Commit-Queue: Cary Clark <caryclark@skia.org>
Reviewed-by: Cary Clark <caryclark@skia.org>
2018-03-12 12:28:58 +00:00
angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com
ef9b793386 Roll skia/third_party/externals/angle2/ b7d924a8f..391bda23b (1 commit)
b7d924a8f4..391bda23b5

$ git log b7d924a8f..391bda23b --date=short --no-merges --format='%ad %ae %s'
2018-02-23 oetuaho Generate code for initializing built-in variables

Created with:
  roll-dep skia/third_party/externals/angle2


The AutoRoll server is located here: https://angle-skia-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Build-Debian9-Clang-x86_64-Release-ANGLE
TBR=stephana@google.com

Change-Id: I66924f22a2dc72bd1c162637ee0c3f10294783fa
Reviewed-on: https://skia-review.googlesource.com/113690
Reviewed-by: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
2018-03-12 08:39:18 +00:00
Mike Klein
e8de02456a with no more offline codegen, seed_shader can be normal
We passed this iota array as an argument before because it was
generating awkward code for our object file parser to handle
(relocations, other weird things, can't quite remember).

Now that we're compiling pipeline code normally, we can make seed_shader
a normal stage again, with no special iota ctx pointer needed.

Change-Id: I3929d61bfb6f914248f360c2c2326ce3d1f23163
Reviewed-on: https://skia-review.googlesource.com/113667
Reviewed-by: Herb Derby <herb@google.com>
Commit-Queue: Mike Klein <mtklein@chromium.org>
2018-03-11 15:47:59 +00:00
UpdateSKPs
6f5bfdca20 Update SKP version
Automatic commit by the RecreateSKPs bot.

TBR=update-skps@skia.org
NO_MERGE_BUILDS

Change-Id: I3de038edff134557690f38cb1aa658b998dd5c36
Reviewed-on: https://skia-review.googlesource.com/113687
Commit-Queue: update-skps <update-skps@skia.org>
Reviewed-by: update-skps <update-skps@skia.org>
2018-03-11 08:04:19 +00:00
Ben Wagner
87122d3809 Fix OS and GPU driver version for GT610 bots.
No-Try: true
Change-Id: Ib15ccc492abdab42a215b3b36cbb85453dd94f45
Reviewed-on: https://skia-review.googlesource.com/113669
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
2018-03-10 23:24:59 +00:00
Ben Wagner
299b882f20 Add ProcDump support to gn_flavor.py.
Adds procdump_win asset.

Enable ProcDump for some of the jobs failing in skia:7177 as a test
case. If it has no ill effect, we can proceed with enabling it for all
Win bots (and remove "ProcDump" tag).

Bug: skia:7626, skia:7177
Change-Id: I50c67ecfca86fe0c6d91d5f970f81485cc9cfd0a
Reviewed-on: https://skia-review.googlesource.com/113265
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
2018-03-10 19:03:28 +00:00
angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com
79ee1b0c4e Roll skia/third_party/externals/angle2/ e2995cce7..b7d924a8f (1 commit)
e2995cce71..b7d924a8f4

$ git log e2995cce7..b7d924a8f --date=short --no-merges --format='%ad %ae %s'
2018-03-10 jmadill Vulkan: Make free part of DescriptorPool.

Created with:
  roll-dep skia/third_party/externals/angle2


The AutoRoll server is located here: https://angle-skia-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Build-Debian9-Clang-x86_64-Release-ANGLE
TBR=fmalita@google.com

Change-Id: I2155355e68c7afb4da8aa9c03ef0d93c6d54d8f4
Reviewed-on: https://skia-review.googlesource.com/113683
Reviewed-by: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
2018-03-10 17:54:38 +00:00
Mike Klein
a46623b2f3 follow JUMPER_NARROW_STAGES in lowp stages too
Should give dramatically better codegen for all 32-bit builds and 64-bit
Windows builds, bringing it in line with how we make highp float stages.

May help this bug, which is mostly Windows perf regressions.

Bug: chromium:820469

Change-Id: I223f7568a09dea28ec614b18555766ea7d8365fa
Reviewed-on: https://skia-review.googlesource.com/113665
Reviewed-by: Herb Derby <herb@google.com>
Commit-Queue: Mike Klein <mtklein@chromium.org>
2018-03-10 16:07:18 +00:00
Update Docs
e3dc6a9346 Update markdown files
Automatic commit by the Housekeeper-Nightly-Bookmaker bot.

TBR=update-docs@skia.org
NO_MERGE_BUILDS

Change-Id: I54a3fe89b88a947f80aee099c6a5d44b6c9dcd4c
Reviewed-on: https://skia-review.googlesource.com/113680
Reviewed-by: Update Docs <update-docs@skia.org>
Commit-Queue: Update Docs <update-docs@skia.org>
2018-03-10 06:29:14 +00:00
Brian Osman
46fe9c7f6c Remove SkDumpCanvas
Bug: skia:
Change-Id: I045e84f154d0294121a4c1966dcf47c0d7e52934
Reviewed-on: https://skia-review.googlesource.com/113464
Commit-Queue: Ben Wagner <bungeman@google.com>
Reviewed-by: Ben Wagner <bungeman@google.com>
2018-03-10 03:29:54 +00:00
angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com
efd4411c23 Roll skia/third_party/externals/angle2/ 331404098..e2995cce7 (10 commits)
3314040981..e2995cce71

$ git log 331404098..e2995cce7 --date=short --no-merges --format='%ad %ae %s'
2018-03-09 jmadill Vulkan: Fix layers not being enabled on the bots.
2018-03-09 geofflang Use full type names instead of auto for simple structs.
2018-03-09 geofflang Rename syncRendererState methods to syncImplementationState.
2018-03-09 cwallez cq.cfg: Add equivalent_to to ramp-up during LUCI migration
2018-03-09 ynovikov Skip TransformFeedbackLifetimeTest.DeletedBuffer on Win Intel GL
2018-03-09 jmadill Vulkan: Add Vk format overrides table.
2018-03-09 jmadill Vulkan: Use free descriptor set bits in pool.
2018-03-09 lucferron Vulkan: Fix issue in blending factor conversions
2018-03-08 jmadill Nuke ValidationContext.
2017-09-22 geofflang Reorder state synchronization for resource init.

Created with:
  roll-dep skia/third_party/externals/angle2
BUG=815092


The AutoRoll server is located here: https://angle-skia-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Build-Debian9-Clang-x86_64-Release-ANGLE
TBR=fmalita@google.com

Change-Id: I9207d4884e1562305045d6ae54b23caf39f0a494
Reviewed-on: https://skia-review.googlesource.com/113624
Reviewed-by: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
2018-03-10 02:02:54 +00:00
Brian Salomon
0c51eeada6 Add GrMockRenderTarget and mock backend render targets
Change-Id: I59673dd7d0015471b7a81aa0c237c67043892454
Reviewed-on: https://skia-review.googlesource.com/113427
Commit-Queue: Brian Salomon <bsalomon@google.com>
Reviewed-by: Greg Daniel <egdaniel@google.com>
2018-03-09 22:32:14 +00:00
Herb Derby
8c4cbf4cfb Remove last use of DetachCache.
Change-Id: I2ef8a134cedf2d0d98e102b921031e0d5ef7fb63
Reviewed-on: https://skia-review.googlesource.com/113274
Reviewed-by: Ben Wagner <bungeman@google.com>
Commit-Queue: Herb Derby <herb@google.com>
2018-03-09 21:46:14 +00:00
Yuqian Li
2ac541e66c Revert "Check the boundary while cumulating deltas in a mask"
This reverts commit d9779bcf93.

Reason for revert: breaks gold

Original change's description:
> Check the boundary while cumulating deltas in a mask
> 
> Without the fix,
> 
> ./out/Debug/dm --config t8888 -m complexclip_bw
> 
> will trigger the assert.
> 
> Note that this boundary check is already in place when deltas are
> cumulated without using a mask.
> 
> Bug: skia:
> Change-Id: I68bfe2b7196d440743d3a7535d097bb8ec7689c3
> Reviewed-on: https://skia-review.googlesource.com/113210
> Commit-Queue: Yuqian Li <liyuqian@google.com>
> Reviewed-by: Cary Clark <caryclark@skia.org>

TBR=liyuqian@google.com,reed@google.com,caryclark@skia.org

Change-Id: Ice0e3618b02ef48b0f2a9f0662a12f76078e984a
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: skia:
Reviewed-on: https://skia-review.googlesource.com/113170
Reviewed-by: Yuqian Li <liyuqian@google.com>
Commit-Queue: Yuqian Li <liyuqian@google.com>
2018-03-09 21:37:04 +00:00