Commit Graph

760 Commits

Author SHA1 Message Date
Mike Klein
e60e56003b set _XOPEN_SOURCE=0 when building ICU
Today I learned -dD -E is the super-power version of -dM -E.

Change-Id: Ib8f6f426006261638f2a97ed9053bbe228f301bb
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/313166
Reviewed-by: Ben Wagner <bungeman@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
2020-08-25 19:47:37 +00:00
Nikolay Igotti
7e9b563179 Search ICU data on Windows relative to the current module.
Bug: n/a
Change-Id: If2fc09f6fc0a24915b4938c62451c693a9712586
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/311136
Commit-Queue: Derek Sollenberger <djsollen@google.com>
Reviewed-by: Derek Sollenberger <djsollen@google.com>
Reviewed-by: Heather Miller <hcm@google.com>
Reviewed-by: Jim Sproch <jsproch@google.com>
2020-08-20 14:51:42 +00:00
Leon Scroggins III
21706f1d14 Switch Skia's libjpeg-turbo used for testing to Chromium version
Bug: chromium:922430
Bug: b/135180511

Chromium has diverged from upstream libjpeg-turbo in order to take
advantage of SIMD optimizations that have not yet been merged into
upstream. Android is also interested in using these. Switch to the
version with the optimizations in order to test them.

Chromium has its own jconfig.h and jconfigint.h, so ours are never used
after the switch. Remove them. The only Skia-specific modification to
these files was to define flags to enable arithmetic encoding. Move
them to BUILD.gn, so they're still applied. Also remove jsimdcfg.inc,
which is currently unused. (It appears to be only for x86/x64, where we
are not building SIMD anyway.)

Update BUILD.gn to build SIMD files on arm. The existing ones have
moved, and there are new ones to build, too.

Change-Id: I47606609c23be43b319150ffb5a4fe55d8869755
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/311105
Commit-Queue: Leon Scroggins <scroggo@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
2020-08-18 14:08:15 +00:00
skia-autoroll
4470ba1491 Roll skcms from 8da4cb002cb4 to b1f9041ffe31 (1 revision)
https://skia.googlesource.com/skcms.git/+log/8da4cb002cb4..b1f9041ffe31

2020-07-31 mtklein@google.com allow Gray and RGB profiles to be equal

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skcms-skia-autoroll
Please CC mtklein@google.com,borenet@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Change-Id: I52534519ef7c092b313ea83ceb5faa59d1af47b6
Cq-Include-Trybots: luci.chromium.try:linux-blink-rel
Tbr: mtklein@google.com,borenet@google.com
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/307166
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2020-07-31 13:54:35 +00:00
Kevin Lubick
7c8659256b Inclusive language
Bug: 842296
Change-Id: I4564f96d4f179211df19893270ccc222abcdd446
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/305439
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Ben Wagner <bungeman@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
2020-07-24 13:33:53 +00:00
Robert Phillips
98e6447f8a Manually Roll ANGLE from 20eb9be55299 to f6659b3df028 (17 revisions)
20eb9be552..f6659b3df0

ANGLE has updated the structure of their gn files. This CL updates Skia to match.

Change-Id: I20a735bbb3f4f119c5315627118a82d12df3f856
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/305518
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>
2020-07-23 16:06:38 +00:00
skia-autoroll
67fd3b8257 Roll skcms from 6982458867c4 to 8da4cb002cb4 (1 revision)
https://skia.googlesource.com/skcms.git/+log/6982458867c4..8da4cb002cb4

2020-07-22 mtklein@google.com add .bazelrc

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skcms-skia-autoroll
Please CC robertphillips@google.com,mtklein@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Change-Id: I4cedc6985ceb8f05daa7d6282b2a11c8b87b0060
Cq-Include-Trybots: luci.chromium.try:linux-blink-rel
Tbr: robertphillips@google.com,mtklein@google.com
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/304936
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2020-07-22 00:53:26 +00:00
skia-autoroll
4526665f2b Roll skcms from 3eb9a5ac7e53 to 6982458867c4 (1 revision)
https://skia.googlesource.com/skcms.git/+log/3eb9a5ac7e53..6982458867c4

2020-07-21 mtklein@google.com basic bazel project structure

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skcms-skia-autoroll
Please CC robertphillips@google.com,mtklein@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Change-Id: Icf23d12eb8fcf49400f593766f28f75a682dc6cd
Cq-Include-Trybots: luci.chromium.try:linux-blink-rel
Tbr: robertphillips@google.com,mtklein@google.com
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/304919
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2020-07-21 23:50:06 +00:00
skia-autoroll
9e7f73230c Roll skcms from fc0d614b6313 to 3eb9a5ac7e53 (1 revision)
https://skia.googlesource.com/skcms.git/+log/fc0d614b6313..3eb9a5ac7e53

2020-07-21 mtklein@google.com rename build/ ninja/

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skcms-skia-autoroll
Please CC robertphillips@google.com,mtklein@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Change-Id: I466bf0fb5789614dab7299e54a92f9254ec4469a
Cq-Include-Trybots: luci.chromium.try:linux-blink-rel
Tbr: robertphillips@google.com,mtklein@google.com
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/304877
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2020-07-21 23:18:06 +00:00
skia-autoroll
c1be15da4d Roll skcms from f73242142ce5 to fc0d614b6313 (1 revision)
https://skia.googlesource.com/skcms.git/+log/f73242142ce5..fc0d614b6313

2020-07-21 mtklein@google.com bake in default bench profiles

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skcms-skia-autoroll
Please CC robertphillips@google.com,mtklein@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Change-Id: Ia682574e42b35b256f8048745ff5650e87ba4290
Cq-Include-Trybots: luci.chromium.try:linux-blink-rel
Tbr: robertphillips@google.com,mtklein@google.com
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/304798
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2020-07-21 18:56:08 +00:00
skia-autoroll
3164b4494f Roll skcms from c21106442079 to f73242142ce5 (1 revision)
https://skia.googlesource.com/skcms.git/+log/c21106442079..f73242142ce5

2020-07-16 mtklein@papyrus.localdomain add skcms_TransferFunction_isFooish()

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skcms-skia-autoroll
Please CC nifong@google.com,mtklein@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Change-Id: I77846e3f984c295e25f7a72c38cdb0002de24a8f
Cq-Include-Trybots: luci.chromium.try:linux-blink-rel
Tbr: nifong@google.com,mtklein@google.com
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/303442
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2020-07-16 21:50:37 +00:00
skia-autoroll
b7f47e832a Roll skcms from 403d32176ebc to c21106442079 (1 revision)
https://skia.googlesource.com/skcms.git/+log/403d32176ebc..c21106442079

2020-07-16 mtklein@google.com bump emscripten/node

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skcms-skia-autoroll
Please CC nifong@google.com,mtklein@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Change-Id: I69a2eec2092931706b2519dbb002fde6c1f208c2
Cq-Include-Trybots: luci.chromium.try:linux-blink-rel
Tbr: nifong@google.com,mtklein@google.com
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/303269
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2020-07-16 20:24:34 +00:00
Greg Daniel
5ee964e2a2 Reland "Roll dawn from 0d52f800a1d1 to b31f5e717e2d (4 revisions)"
This reverts commit 06980dba90.

Reason for revert: probably wrong guess on revert

Original change's description:
> Revert "Roll dawn from 0d52f800a1d1 to b31f5e717e2d (4 revisions)"
> 
> This reverts commit 14fdcdc891.
> 
> Reason for revert: speculative revert to see if this is cause the d3d failures.
> 
> Original change's description:
> > Roll dawn from 0d52f800a1d1 to b31f5e717e2d (4 revisions)
> > 
> > Also includes a build file fix for glslang.
> > 
> > https://dawn.googlesource.com/dawn.git/+log/0d52f800a1d1..b31f5e717e2d
> > 
> > 2020-07-14 enga@chromium.org Remove kMaxBindingsPerGroup limit
> > 2020-07-14 rharrison@chromium.org Roll 5 dependencies
> > 2020-07-14 kainino@chromium.org Skip clang-format on Windows
> > 2020-07-14 cwallez@chromium.org Rolling build dependencies.
> > 
> > Also rolling transitive DEPS:
> >   https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang from 29c9135d06f1 to b481744aea1e
> >   https://chromium.googlesource.com/external/github.com/google/shaderc from 1402ed576596 to 5515d2a0c20c
> > 
> > Change-Id: I8af4c9a0bcd031fde120c9b2108b3bd2c1db0174
> > Bug: None
> > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/302796
> > Reviewed-by: Eric Boren <borenet@google.com>
> > Commit-Queue: Eric Boren <borenet@google.com>
> 
> TBR=borenet@google.com,bsalomon@google.com,cwallez@chromium.org
> 
> Change-Id: Ieae7fe809da0a9b9404da26163c96015f97e9761
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: None
> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/302898
> Reviewed-by: Greg Daniel <egdaniel@google.com>
> Commit-Queue: Greg Daniel <egdaniel@google.com>

TBR=borenet@google.com,egdaniel@google.com,bsalomon@google.com,cwallez@chromium.org

# Not skipping CQ checks because this is a reland.

Bug: None
Change-Id: I8aa7e8740eb7c7da2197b3fd19bd19b9d94124cb
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/303018
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Greg Daniel <egdaniel@google.com>
2020-07-15 19:42:03 +00:00
Greg Daniel
06980dba90 Revert "Roll dawn from 0d52f800a1d1 to b31f5e717e2d (4 revisions)"
This reverts commit 14fdcdc891.

Reason for revert: speculative revert to see if this is cause the d3d failures.

Original change's description:
> Roll dawn from 0d52f800a1d1 to b31f5e717e2d (4 revisions)
> 
> Also includes a build file fix for glslang.
> 
> https://dawn.googlesource.com/dawn.git/+log/0d52f800a1d1..b31f5e717e2d
> 
> 2020-07-14 enga@chromium.org Remove kMaxBindingsPerGroup limit
> 2020-07-14 rharrison@chromium.org Roll 5 dependencies
> 2020-07-14 kainino@chromium.org Skip clang-format on Windows
> 2020-07-14 cwallez@chromium.org Rolling build dependencies.
> 
> Also rolling transitive DEPS:
>   https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang from 29c9135d06f1 to b481744aea1e
>   https://chromium.googlesource.com/external/github.com/google/shaderc from 1402ed576596 to 5515d2a0c20c
> 
> Change-Id: I8af4c9a0bcd031fde120c9b2108b3bd2c1db0174
> Bug: None
> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/302796
> Reviewed-by: Eric Boren <borenet@google.com>
> Commit-Queue: Eric Boren <borenet@google.com>

TBR=borenet@google.com,bsalomon@google.com,cwallez@chromium.org

Change-Id: Ieae7fe809da0a9b9404da26163c96015f97e9761
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: None
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/302898
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Greg Daniel <egdaniel@google.com>
2020-07-15 14:24:02 +00:00
Corentin Wallez
14fdcdc891 Roll dawn from 0d52f800a1d1 to b31f5e717e2d (4 revisions)
Also includes a build file fix for glslang.

https://dawn.googlesource.com/dawn.git/+log/0d52f800a1d1..b31f5e717e2d

2020-07-14 enga@chromium.org Remove kMaxBindingsPerGroup limit
2020-07-14 rharrison@chromium.org Roll 5 dependencies
2020-07-14 kainino@chromium.org Skip clang-format on Windows
2020-07-14 cwallez@chromium.org Rolling build dependencies.

Also rolling transitive DEPS:
  https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang from 29c9135d06f1 to b481744aea1e
  https://chromium.googlesource.com/external/github.com/google/shaderc from 1402ed576596 to 5515d2a0c20c

Change-Id: I8af4c9a0bcd031fde120c9b2108b3bd2c1db0174
Bug: None
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/302796
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
2020-07-15 12:16:50 +00:00
Nigel Tao
c91db040ad Use Wuffs v0.3 by default, not v0.2
This is roll-forward of
https://skia-review.googlesource.com/c/skia/+/298616/

Change-Id: I44d65dcb67555fd76075e2d415d96db82c376cae
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/301756
Commit-Queue: Leon Scroggins <scroggo@google.com>
Reviewed-by: Leon Scroggins <scroggo@google.com>
2020-07-10 16:10:43 +00:00
Mike Klein
313869939d Revert "Use Wuffs v0.3 by default, not v0.2"
This reverts commit 7a3ea55259.

Reason for revert: linker failures rolling to Flutter, e.g

[5594/5828] LINK ./flow_unittests
FAILED: flow_unittests exe.unstripped/flow_unittests 
/b/s/w/ir/cache/goma/client/gomacc ../../buildtools/linux-x64/clang/bin/clang++ -Wl,--fatal-warnings -m64 -fPIC -Wl,-z,noexecstack -Wl,-z,now -Wl,-z,relro -Wl,-z,defs -pthread --sysroot=/b/s/w/ir/cache/builder/src/build/linux/debian_sid_amd64-sysroot -L/b/s/w/ir/cache/builder/src/build/linux/debian_sid_amd64-sysroot/usr/local/lib/x86_64-linux-gnu\ -Wl,-rpath-link=/b/s/w/ir/cache/builder/src/build/linux/debian_sid_amd64-sysroot/usr/local/lib/x86_64-linux-gnu\ -L/b/s/w/ir/cache/builder/src/build/linux/debian_sid_amd64-sysroot/lib/x86_64-linux-gnu\ -Wl,-rpath-link=/b/s/w/ir/cache/builder/src/build/linux/debian_sid_amd64-sysroot/lib/x86_64-linux-gnu\ -L/b/s/w/ir/cache/builder/src/build/linux/debian_sid_amd64-sysroot/usr/lib/x86_64-linux-gnu\ -Wl,-rpath-link=/b/s/w/ir/cache/builder/src/build/linux/debian_sid_amd64-sysroot/usr/lib/x86_64-linux-gnu -Wl,-rpath=\$ORIGIN/ -Wl,-rpath-link= -Wl,--disable-new-dtags  -o ./exe.unstripped/flow_unittests -Wl,--build-id=sha1 -Wl,--start-group @./flow_unittests.rsp  -Wl,--end-group  -ldl -lpthread  && strip --strip-unneeded -o ./flow_unittests ./exe.unstripped/flow_unittests
ld.lld: error: undefined symbol: wuffs_base__note__end_of_data
>>> referenced by SkWuffsCodec.cpp:0 (../../third_party/skia/src/codec/SkWuffsCodec.cpp:0)
>>>               obj/third_party/skia/src/codec/wuffs.SkWuffsCodec.o:(SkWuffsCodec::onGetFrameCountInternal())
clang-11: error: linker command failed with exit code 1 (use -v to see invocation)

https://github.com/flutter/engine/pull/19466
https://ci.chromium.org/p/flutter/builders/try/Linux%20Host%20Engine/9900? (among several)

Original change's description:
> Use Wuffs v0.3 by default, not v0.2
> 
> Change-Id: Ie57fea197778f4b17ca08d2e3022b77f783de927
> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/298616
> Reviewed-by: Leon Scroggins <scroggo@google.com>
> Commit-Queue: Mike Klein <mtklein@google.com>

TBR=mtklein@google.com,scroggo@google.com,nigeltao@google.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Change-Id: Ie21293deade92e064099ebd5d41de69dbf8b2545
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/300413
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
2020-07-03 14:41:53 +00:00
Nigel Tao
7a3ea55259 Use Wuffs v0.3 by default, not v0.2
Change-Id: Ie57fea197778f4b17ca08d2e3022b77f783de927
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/298616
Reviewed-by: Leon Scroggins <scroggo@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
2020-07-02 00:36:02 +00:00
John Stiles
b5f7a07b77 Enable OS X clipboard in ImGui.
ImGui gates the OS clipboard behind a #define to avoid forcing ImGui
apps to link against ApplicationServices if they otherwise wouldn't need
to. In our case this is harmless; our tools already link against Cocoa.

This #define is safe to enable on all platforms.

Context:
29d9394a41

Change-Id: Ice5d027ddc0157c0cfe87a7cc0c064c4fa682425
Bug: skia:10338
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/300197
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Mike Reed <reed@google.com>
Auto-Submit: John Stiles <johnstiles@google.com>
2020-07-01 21:33:07 +00:00
Florin Malita
65513a9834 Tweak scripts to fix CK builds with python 3
- print -> print()
- xrange() gone in 3, but range() works similarly - if somewhat
  less efficient in 2
- read() returns strings in python 2 vs. bytes in 3

Change-Id: Ia720551832ef75edbf9235b80a06e2ffa3ddf4b5
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/299444
Commit-Queue: Florin Malita <fmalita@google.com>
Reviewed-by: Kevin Lubick <kjlubick@google.com>
2020-06-29 12:59:05 +00:00
skia-autoroll
345e999a59 Roll dawn from 92379bff49c2 to 8ab3719fc486 (2 revisions)
Also includes GN file fixes for glslang.

https://dawn.googlesource.com/dawn.git/+log/92379bff49c2..8ab3719fc486

2020-06-23 enga@chromium.org Fix validation of multisampled BGL bindings
2020-06-22 rharrison@chromium.org Rolling 4 dependencies

Also rolling transitive DEPS:
  https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang from 00965b9fa9a8 to 839704450200
  https://chromium.googlesource.com/external/github.com/google/shaderc from c2ac70797a38 to caa519ca532a

Change-Id: I46f2d1ed1e137cfc2576fe7da34495f035fdac16
Cq-Include-Trybots: skia/skia.primary:Build-Debian10-Clang-x86_64-Debug-Dawn
Bug: None
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/298437
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
2020-06-24 17:35:33 +00:00
Mike Klein
29cb9f9478 decouple werror and -isystem in third_party
Some users of Skia want to build these with -I instead of -isystem, and
until now we've piggybacked it on werror, but it's still kind of
annoying to see warnings even if they're not fatal.

Change-Id: I5a349b2571adc2f94c75dc17317666ddc2dec373
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/297788
Commit-Queue: Mike Klein <mtklein@google.com>
Commit-Queue: John Stiles <johnstiles@google.com>
Reviewed-by: John Stiles <johnstiles@google.com>
2020-06-19 21:59:35 +00:00
Derek Sollenberger
74b06275bb Manually update ANGLE DEPS
Recent ANGLE changes require BUILD.gn updates to make use of new
zlib functions as well as changes to SystemInfo that requires adding
new source dictionaries to our list of build sources.

Bug: skia:10391
Change-Id: I993a9f78e4585618ad4cd16b3bfc81874d7b5b17
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/297116
Reviewed-by: Ben Wagner <bungeman@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Derek Sollenberger <djsollen@google.com>
2020-06-18 12:50:02 +00:00
Derek Sollenberger
abae40299c Reland "Update zlib DEPS"
This is a reland of 6fb3687413

Original change's description:
> Update zlib DEPS
> 
> Pull latest zlib into Skia and updated its BUILD files to build some
> SIMD variants.
> 
> Bug: skia:10391
> Change-Id: Ic1a660c8f5f7e5f94440787779fd74b7192ab6d5
> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/296720
> Auto-Submit: Derek Sollenberger <djsollen@google.com>
> Reviewed-by: Ben Wagner <bungeman@google.com>
> Commit-Queue: Derek Sollenberger <djsollen@google.com>

Bug: skia:10391
Change-Id: I4d38a526f2785e70ef9fa134c681fd3dc4d57c44
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/297020
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Derek Sollenberger <djsollen@google.com>
2020-06-17 17:27:15 +00:00
Derek Sollenberger
1443609db4 Revert "Update zlib DEPS"
This reverts commit 6fb3687413.

Reason for revert: breaking a bunch of linux builds

Change-Id: I71dd154785fb00dd20bc157d5d5daf1ee2101fc2
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/296996
Reviewed-by: Derek Sollenberger <djsollen@google.com>
2020-06-17 13:20:37 +00:00
Derek Sollenberger
6fb3687413 Update zlib DEPS
Pull latest zlib into Skia and updated its BUILD files to build some
SIMD variants.

Bug: skia:10391
Change-Id: Ic1a660c8f5f7e5f94440787779fd74b7192ab6d5
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/296720
Auto-Submit: Derek Sollenberger <djsollen@google.com>
Reviewed-by: Ben Wagner <bungeman@google.com>
Commit-Queue: Derek Sollenberger <djsollen@google.com>
2020-06-17 13:11:53 +00:00
Derek Sollenberger
b48895dca2 Revert "Allow building with Wuffs v0.3, not just v0.2"
This reverts commit c34344989a.

Reason for revert: breaking the windows msvc compile bot as well as the flutter canary

Original change's description:
> Allow building with Wuffs v0.3, not just v0.2
> 
> This is step 1 of a multi-step, multi-repository transition:
> 
> 1. Let Skia work with either Wuffs v0.3 or v0.2. This repository
>    defaults to v0.3 but other repositories' defaults remain at v0.2.
> 2. Update users' Skia version (automatic if they update regularly).
> 3. Update users' Wuffs version and opt them in to Skia-uses-Wuffs-v0.3.
> 4. Flip Skia choosing Wuffs version 0.3 from opt-in to opt-out.
> 5. Remove the option for Skia to work wih Wuffs v0.2.
> 
> Change-Id: Ie5cf238057060f2a40cc7c0070d6e2a076943e2b
> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/295976
> Commit-Queue: Leon Scroggins <scroggo@google.com>
> Reviewed-by: Leon Scroggins <scroggo@google.com>

TBR=scroggo@google.com,nigeltao@google.com

Change-Id: I2c8a44962eb9b136b199dba5f52a860d756a0aa1
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/296441
Reviewed-by: Derek Sollenberger <djsollen@google.com>
Commit-Queue: Derek Sollenberger <djsollen@google.com>
2020-06-15 15:41:26 +00:00
Nigel Tao
c34344989a Allow building with Wuffs v0.3, not just v0.2
This is step 1 of a multi-step, multi-repository transition:

1. Let Skia work with either Wuffs v0.3 or v0.2. This repository
   defaults to v0.3 but other repositories' defaults remain at v0.2.
2. Update users' Skia version (automatic if they update regularly).
3. Update users' Wuffs version and opt them in to Skia-uses-Wuffs-v0.3.
4. Flip Skia choosing Wuffs version 0.3 from opt-in to opt-out.
5. Remove the option for Skia to work wih Wuffs v0.2.

Change-Id: Ie5cf238057060f2a40cc7c0070d6e2a076943e2b
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/295976
Commit-Queue: Leon Scroggins <scroggo@google.com>
Reviewed-by: Leon Scroggins <scroggo@google.com>
2020-06-15 14:34:34 +00:00
Mike Klein
d3927e40f1 Revert "Reland "Add JavaInputStreamAdaptor files into third_party directory.""
This reverts commit 237f794e64.

Reason for revert: blocking the Google3 roll.

I think you may need to land third_party/aosp/LICENSE first, set up the BUILD file to point out code in third_party/aosp is covered by third_party/aosp/LICENSE, and then let the code roll in?

Original change's description:
> Reland "Add JavaInputStreamAdaptor files into third_party directory."
> 
> This is a reland of cf8b723ffd
> 
> The reland is necessary to satisfy the google3 roller.
> 
> Original change's description:
> > Add JavaInputStreamAdaptor files into third_party directory.
> >
> > This code needs to be migrated out of the main Skia directory due to its
> > use of the Apache 2.0 license. A followup CL will remove these files
> > from their current home at platform_tools/android/apps/skottie/src/
> > main/cpp.
> >
> > Change-Id: I939b05afcebb29e1deab1d4ae1b38012f719cf7e
> > Bug: skia:10310
> > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/295082
> > Reviewed-by: Ben Wagner <bungeman@google.com>
> > Reviewed-by: Weston Tracey <westont@google.com>
> > Commit-Queue: John Stiles <johnstiles@google.com>
> 
> Bug: skia:10310, skia:10353
> Change-Id: I3ac62b626825df624a5418e496989facef6b6099
> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/295201
> Commit-Queue: John Stiles <johnstiles@google.com>
> Reviewed-by: Weston Tracey <westont@google.com>

TBR=bungeman@google.com,westont@google.com,johnstiles@google.com

Change-Id: I7f8de31419d86933a79036b48032c4a7ea18dd3a
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: skia:10310, skia:10353
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/295283
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
2020-06-09 16:55:29 +00:00
John Stiles
237f794e64 Reland "Add JavaInputStreamAdaptor files into third_party directory."
This is a reland of cf8b723ffd

The reland is necessary to satisfy the google3 roller.

Original change's description:
> Add JavaInputStreamAdaptor files into third_party directory.
>
> This code needs to be migrated out of the main Skia directory due to its
> use of the Apache 2.0 license. A followup CL will remove these files
> from their current home at platform_tools/android/apps/skottie/src/
> main/cpp.
>
> Change-Id: I939b05afcebb29e1deab1d4ae1b38012f719cf7e
> Bug: skia:10310
> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/295082
> Reviewed-by: Ben Wagner <bungeman@google.com>
> Reviewed-by: Weston Tracey <westont@google.com>
> Commit-Queue: John Stiles <johnstiles@google.com>

Bug: skia:10310, skia:10353
Change-Id: I3ac62b626825df624a5418e496989facef6b6099
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/295201
Commit-Queue: John Stiles <johnstiles@google.com>
Reviewed-by: Weston Tracey <westont@google.com>
2020-06-09 15:31:18 +00:00
John Stiles
9d79ac6b81 Revert "Add JavaInputStreamAdaptor files into third_party directory."
This reverts commit cf8b723ffd.

Reason for revert: reverting and relanding to make the google3
roller happy

Original change's description:
> Add JavaInputStreamAdaptor files into third_party directory.
> 
> This code needs to be migrated out of the main Skia directory due to its
> use of the Apache 2.0 license. A followup CL will remove these files
> from their current home at platform_tools/android/apps/skottie/src/
> main/cpp.
> 
> Change-Id: I939b05afcebb29e1deab1d4ae1b38012f719cf7e
> Bug: skia:10310
> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/295082
> Reviewed-by: Ben Wagner <bungeman@google.com>
> Reviewed-by: Weston Tracey <westont@google.com>
> Commit-Queue: John Stiles <johnstiles@google.com>

TBR=bungeman@google.com,westont@google.com,johnstiles@google.com

Change-Id: Ib3cbad92b8c5616735a013d06e3345ac50f78c84
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: skia:10310, skia:10353
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/295200
Reviewed-by: John Stiles <johnstiles@google.com>
Commit-Queue: John Stiles <johnstiles@google.com>
2020-06-09 14:44:04 +00:00
John Stiles
cf8b723ffd Add JavaInputStreamAdaptor files into third_party directory.
This code needs to be migrated out of the main Skia directory due to its
use of the Apache 2.0 license. A followup CL will remove these files
from their current home at platform_tools/android/apps/skottie/src/
main/cpp.

Change-Id: I939b05afcebb29e1deab1d4ae1b38012f719cf7e
Bug: skia:10310
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/295082
Reviewed-by: Ben Wagner <bungeman@google.com>
Reviewed-by: Weston Tracey <westont@google.com>
Commit-Queue: John Stiles <johnstiles@google.com>
2020-06-08 20:08:30 +00:00
John Stiles
7b1355e509 Revert "Reland "Move JavaInputStreamAdaptor into third_party and add a LICENSE file.""
This reverts commit fee069880d.

Reason for revert: google3 roller is glitchy today, try again later

Original change's description:
> Reland "Move JavaInputStreamAdaptor into third_party and add a LICENSE file."
> 
> This is a reland of eac2d518bd
> 
> The aosp folder was added to the google3 roller include_patterns list:
> http://cl/315274044
> 
> Original change's description:
> > Move JavaInputStreamAdaptor into third_party and add a LICENSE file.
> >
> > Change-Id: I723b15fbcf3343559fb5a3fe3015cf3db96e2841
> > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/294696
> > Reviewed-by: Heather Miller <hcm@google.com>
> > Commit-Queue: John Stiles <johnstiles@google.com>
> 
> Change-Id: I27ac16c3ac05fbee1473af886379e95492302d50
> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/295000
> Reviewed-by: Heather Miller <hcm@google.com>
> Reviewed-by: John Stiles <johnstiles@google.com>
> Commit-Queue: John Stiles <johnstiles@google.com>

TBR=djsollen@google.com,hcm@google.com,johnstiles@google.com

Change-Id: I8c620c47a8c6c7f3e081fe786a17396a40236105
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/295081
Reviewed-by: John Stiles <johnstiles@google.com>
Commit-Queue: John Stiles <johnstiles@google.com>
2020-06-08 19:18:15 +00:00
John Stiles
fee069880d Reland "Move JavaInputStreamAdaptor into third_party and add a LICENSE file."
This is a reland of eac2d518bd

The aosp folder was added to the google3 roller include_patterns list:
http://cl/315274044

Original change's description:
> Move JavaInputStreamAdaptor into third_party and add a LICENSE file.
>
> Change-Id: I723b15fbcf3343559fb5a3fe3015cf3db96e2841
> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/294696
> Reviewed-by: Heather Miller <hcm@google.com>
> Commit-Queue: John Stiles <johnstiles@google.com>

Change-Id: I27ac16c3ac05fbee1473af886379e95492302d50
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/295000
Reviewed-by: Heather Miller <hcm@google.com>
Reviewed-by: John Stiles <johnstiles@google.com>
Commit-Queue: John Stiles <johnstiles@google.com>
2020-06-08 16:44:04 +00:00
John Stiles
429d9d7981 Revert "Move JavaInputStreamAdaptor into third_party and add a LICENSE file."
This reverts commit eac2d518bd.

Reason for revert: google3 roll broke

Original change's description:
> Move JavaInputStreamAdaptor into third_party and add a LICENSE file.
> 
> Change-Id: I723b15fbcf3343559fb5a3fe3015cf3db96e2841
> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/294696
> Reviewed-by: Heather Miller <hcm@google.com>
> Commit-Queue: John Stiles <johnstiles@google.com>

TBR=djsollen@google.com,hcm@google.com,johnstiles@google.com

Change-Id: Ia2e23547ad39a0e3d069d9a9807f581b5c73c199
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/294710
Reviewed-by: John Stiles <johnstiles@google.com>
Commit-Queue: John Stiles <johnstiles@google.com>
2020-06-05 21:21:48 +00:00
John Stiles
eac2d518bd Move JavaInputStreamAdaptor into third_party and add a LICENSE file.
Change-Id: I723b15fbcf3343559fb5a3fe3015cf3db96e2841
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/294696
Reviewed-by: Heather Miller <hcm@google.com>
Commit-Queue: John Stiles <johnstiles@google.com>
2020-06-05 20:29:49 +00:00
skia-autoroll
fcddaf2aa9 Roll skcms from 5404be4a2703 to 403d32176ebc (1 revision)
https://skia.googlesource.com/skcms.git/+log/5404be4a2703..403d32176ebc

2020-06-04 brianosman@google.com Add another test profile, where A2B/B2A and XYZ+TRC disagree strongly

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skcms-skia-autoroll
Please CC tdenniston@google.com,mtklein@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Change-Id: I407af182ada4a06700b9e113c7c7a447d44f5b0a
Cq-Include-Trybots: luci.chromium.try:linux-blink-rel
Tbr: tdenniston@google.com,mtklein@google.com
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/294361
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2020-06-04 20:09:04 +00:00
Ben Wagner
5b8dd73546 Hide ICU C++ API from Skia users.
Parts of third_party need the C++ API so hide it from Skia users as
needed to prevent re-introduction.

This also avoids the ICU version renaming / name mangling when building
our own test version of ICU. This makes life in an editor and debugger
much easier.

Reviewed-on: https://skia-review.googlesource.com/c/skia/+/292854
Reviewed-by: Julia Lavrova <jlavrova@google.com>
Commit-Queue: Ben Wagner <bungeman@google.com>
Change-Id: Id636fbf9e750fe72a4ace8a59fb9acac839a07c4
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/292967
Reviewed-by: Ben Wagner <bungeman@google.com>
2020-05-29 21:43:19 +00:00
Ben Wagner
2837f24a16 Revert "Hide ICU C++ API from Skia users."
This reverts commit 5ef0d2f6c0.

Reason for revert: Sharing a build with flutter is crazy pants.

Original change's description:
> Hide ICU C++ API from Skia users.
> 
> Parts of third_party need the C++ API so hide it from Skia users as
> needed to prevent re-introduction.
> 
> This also avoids the ICU version renaming / name mangling when building
> our own test version of ICU. This makes life in an editor and debugger
> much easier.
> 
> Change-Id: I8fb1903e2b31e9dd04efa22173a03115d629c232
> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/292854
> Reviewed-by: Julia Lavrova <jlavrova@google.com>
> Commit-Queue: Ben Wagner <bungeman@google.com>

TBR=bungeman@google.com,reed@google.com,jlavrova@google.com

Change-Id: If238225b20a6b73064e3b16c5e0bdc89760e522d
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/292966
Reviewed-by: Ben Wagner <bungeman@google.com>
2020-05-29 19:08:04 +00:00
Ben Wagner
5ef0d2f6c0 Hide ICU C++ API from Skia users.
Parts of third_party need the C++ API so hide it from Skia users as
needed to prevent re-introduction.

This also avoids the ICU version renaming / name mangling when building
our own test version of ICU. This makes life in an editor and debugger
much easier.

Change-Id: I8fb1903e2b31e9dd04efa22173a03115d629c232
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/292854
Reviewed-by: Julia Lavrova <jlavrova@google.com>
Commit-Queue: Ben Wagner <bungeman@google.com>
2020-05-29 18:04:46 +00:00
skia-autoroll
15e78d0f78 Roll skcms from da218e6af725 to 5404be4a2703 (1 revision)
https://skia.googlesource.com/skcms.git/+log/da218e6af725..5404be4a2703

2020-05-26 mtklein@google.com add function to disable CPU detection

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skcms-skia-autoroll
Please CC westont@google.com,mtklein@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Change-Id: I26a9428c3d80c249e6e66e7fffc3fb76245a1be6
Cq-Include-Trybots: luci.chromium.try:linux-blink-rel
Tbr: westont@google.com,mtklein@google.com
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/291898
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2020-05-26 16:19:09 +00:00
skia-autoroll
4262f6b7c0 Roll skcms from 97bfcc9529c9 to da218e6af725 (1 revision)
https://skia.googlesource.com/skcms.git/+log/97bfcc9529c9..da218e6af725

2020-05-19 brianosman@google.com Guard exp2f_ to never return a negative value

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skcms-skia-autoroll
Please CC lovisolo@google.com,mtklein@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Change-Id: I6d5c9a36f05ed33a3a8496858794cd79f5d5c3bc
Tbr: lovisolo@google.com,mtklein@google.com
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/290836
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2020-05-19 18:48:24 +00:00
skia-autoroll
7c8ea19025 Roll skcms from 60d5d65325e6 to 97bfcc9529c9 (1 revision)
https://skia.googlesource.com/skcms.git/+log/60d5d65325e6..97bfcc9529c9

2020-05-19 mtklein@google.com rm mips64el build configs

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skcms-skia-autoroll
Please CC lovisolo@google.com,mtklein@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Change-Id: I332d917974dd89d2c850f2fd45da0b8a9c516378
Tbr: lovisolo@google.com,mtklein@google.com
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/290771
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2020-05-19 17:45:22 +00:00
Greg Daniel
2f62abdbe9 Update AMD vulkan memory allocator.
Change-Id: I2ed449cdbb8beac24fbd9d9664ab5fc42a0b3e00
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/289236
Reviewed-by: Jim Van Verth <jvanverth@google.com>
2020-05-13 13:03:39 +00:00
Kevin Lubick
2887d35ca9 [canvaskit] Enable font edging
Adding in the mono rasterizer on freetype adds 12k of code size
(6k compressed), so we make it opt out and don't ship to npm with it.

Bug: skia:10192
Change-Id: I8352adbeaec288800ae1ca4709144860e9a1e84c
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/288546
Reviewed-by: Ben Wagner <bungeman@google.com>
2020-05-08 13:22:18 +00:00
Mike Klein
5cf6b31fc8 Revert "retry absl"
This reverts commit 1d256d66ec.

Reason for revert: Build-Debian10-Clang-arm64-Debug-Android_ASAN can't find <cxxabi.h>.

Original change's description:
> retry absl
> 
> This time around, cut the absl deps down to just what's
> needed to compile, link, and run AbseilTest.cpp.
> 
> Add basic absl::btree_map test.
> 
> Bug: skia:10165
> Cq-Include-Trybots: skia/skia.primary:Build-Debian10-Clang-arm-Debug-Chromebook_GLES;skia/skia.primary:Test-Mac10.13-Clang-MacBookPro11.5-CPU-AVX2-x86_64-Release-All-TSAN
> Change-Id: I53d632a04cba8dadd484b2c4d0ceefb314676486
> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/286070
> Reviewed-by: John Stiles <johnstiles@google.com>
> Commit-Queue: Mike Klein <mtklein@google.com>

TBR=mtklein@google.com,johnstiles@google.com

Change-Id: I2465ed155f7311c6ca35259ea1bf1b610020a66d
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: skia:10165
Cq-Include-Trybots: skia/skia.primary:Build-Debian10-Clang-arm-Debug-Chromebook_GLES;skia/skia.primary:Test-Mac10.13-Clang-MacBookPro11.5-CPU-AVX2-x86_64-Release-All-TSAN
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/286477
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
2020-04-30 16:11:14 +00:00
Mike Klein
1d256d66ec retry absl
This time around, cut the absl deps down to just what's
needed to compile, link, and run AbseilTest.cpp.

Add basic absl::btree_map test.

Bug: skia:10165
Cq-Include-Trybots: skia/skia.primary:Build-Debian10-Clang-arm-Debug-Chromebook_GLES;skia/skia.primary:Test-Mac10.13-Clang-MacBookPro11.5-CPU-AVX2-x86_64-Release-All-TSAN
Change-Id: I53d632a04cba8dadd484b2c4d0ceefb314676486
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/286070
Reviewed-by: John Stiles <johnstiles@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
2020-04-30 16:01:41 +00:00
Mike Klein
5763b37ffb Revert "Reland "Add Abseil to third_party.""
This reverts commit 78debd6f6d.

Reason for revert: unexpectedly, Test-Mac10.13-Clang-MacBookPro11.5-CPU-AVX2-x86_64-Release-All-TSAN

Original change's description:
> Reland "Add Abseil to third_party."
>
> This is a reland of 816226e822
>
> Original change's description:
> > Add Abseil to third_party.
> >
> > At present, this is a proof-of-concept which only supports a small
> > subset of absl modules:
> > - Base
> > - Hash
> > - Numeric
> > - String
> >
> > This is only used by one unit test, which builds a string and then
> > hashes it.
> >
> > Bug: skia:10165
> > Bug: b/154848688
> >
> > Change-Id: I016250bf700b522c7a6bc78cf1844abff2260c35
> > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/284805
> > Reviewed-by: Derek Sollenberger <djsollen@google.com>
> > Commit-Queue: John Stiles <johnstiles@google.com>
> > Auto-Submit: John Stiles <johnstiles@google.com>
>
> Bug: skia:10165, b/154848688
> Change-Id: I618bb4411445fe5b45a91741934ca888a09adf05
> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/285537
> Commit-Queue: John Stiles <johnstiles@google.com>
> Reviewed-by: Mike Klein <mtklein@google.com>

TBR=djsollen@google.com,mtklein@google.com,johnstiles@google.com

Change-Id: I434da738bcc7fa76b46d0fa0fcbdd58c85b70fe7
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: skia:10165, skia:10177, b/154848688
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/285685
Commit-Queue: Mike Klein <mtklein@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
Reviewed-by: John Stiles <johnstiles@google.com>
2020-04-27 18:46:29 +00:00
John Stiles
78debd6f6d Reland "Add Abseil to third_party."
This is a reland of 816226e822

Original change's description:
> Add Abseil to third_party.
>
> At present, this is a proof-of-concept which only supports a small
> subset of absl modules:
> - Base
> - Hash
> - Numeric
> - String
>
> This is only used by one unit test, which builds a string and then
> hashes it.
>
> Bug: skia:10165
> Bug: b/154848688
>
> Change-Id: I016250bf700b522c7a6bc78cf1844abff2260c35
> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/284805
> Reviewed-by: Derek Sollenberger <djsollen@google.com>
> Commit-Queue: John Stiles <johnstiles@google.com>
> Auto-Submit: John Stiles <johnstiles@google.com>

Bug: skia:10165, b/154848688
Change-Id: I618bb4411445fe5b45a91741934ca888a09adf05
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/285537
Commit-Queue: John Stiles <johnstiles@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
2020-04-27 06:07:43 +00:00
Mike Klein
6d54e84dc5 Revert "Add Abseil to third_party."
This reverts commit 816226e822.

Reason for revert: 

https://chromium-swarm.appspot.com/task?id=4bc69ffc0a889110

/mnt/pd0/s/w/ir/clang_linux/bin/clang++ -rdynamic -Wl,-rpath,\$ORIGIN --target=armv7a-linux-gnueabihf --sysroot=/mnt/pd0/s/w/ir/armhf_sysroot -static-libstdc++ -static-libgcc -B/mnt/pd0/s/w/ir/armhf_sysroot/bin -B/mnt/pd0/s/w/ir/armhf_sysroot/gcc-cross -L/mnt/pd0/s/w/ir/armhf_sysroot/gcc-cross -L/mnt/pd0/s/w/ir/armhf_sysroot/lib -L/mnt/pd0/s/w/ir/chromebook_arm_gles/lib -Wl,--start-group @./dm.rsp  -Wl,--end-group -lpthread -ldl -lGLESv2 -lEGL -o ./dm
libabsl.a(libabsl.numbers.o): In function `absl::string_view::substr(unsigned int, unsigned int) const':
/mnt/pd0/s/w/ir/skia/third_party/externals/abseil-cpp/absl/strings/string_view.h:387: undefined reference to `absl::base_internal::ThrowStdOutOfRange(char const*)'
clang-10: error: linker command failed with exit code 1 (use -v to see invocation)


Original change's description:
> Add Abseil to third_party.
> 
> At present, this is a proof-of-concept which only supports a small
> subset of absl modules:
> - Base
> - Hash
> - Numeric
> - String
> 
> This is only used by one unit test, which builds a string and then
> hashes it.
> 
> Bug: skia:10165
> Bug: b/154848688
> 
> Change-Id: I016250bf700b522c7a6bc78cf1844abff2260c35
> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/284805
> Reviewed-by: Derek Sollenberger <djsollen@google.com>
> Commit-Queue: John Stiles <johnstiles@google.com>
> Auto-Submit: John Stiles <johnstiles@google.com>

TBR=djsollen@google.com,johnstiles@google.com

Change-Id: If9936f1beaf6ac9c85718ce445e823bf2f57a6fa
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: skia:10165, b/154848688
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/285491
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
2020-04-24 20:15:42 +00:00
John Stiles
816226e822 Add Abseil to third_party.
At present, this is a proof-of-concept which only supports a small
subset of absl modules:
- Base
- Hash
- Numeric
- String

This is only used by one unit test, which builds a string and then
hashes it.

Bug: skia:10165
Bug: b/154848688

Change-Id: I016250bf700b522c7a6bc78cf1844abff2260c35
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/284805
Reviewed-by: Derek Sollenberger <djsollen@google.com>
Commit-Queue: John Stiles <johnstiles@google.com>
Auto-Submit: John Stiles <johnstiles@google.com>
2020-04-24 19:53:21 +00:00
Ben Wagner
b1acff60fb Roll testing expat to tip of tree.
We currently mirror Android's mirror, which is out of date and only
rolled to tagged revisions. Roll to Chromium's mirror which is actually
up to date.

Change-Id: I754dc58149526e0c820bd7bcff1693d2d851a084
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/282039
Reviewed-by: Derek Sollenberger <djsollen@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Ben Wagner <bungeman@google.com>
2020-04-20 16:14:11 +00:00
Zhenyao Mo
4f17b60208 Use Dawn's BUILD.gn instead of defining another one for Skia.
Bug: chromium:1064305

Change-Id: I10ca629ff88a5492bb9f89075f6d92094340ff55
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/282076
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Zhenyao Mo <zmo@google.com>
2020-04-13 23:26:31 +00:00
Zhenyao Mo
9378b8016c Roll Dawn 6574f92747a2..582e5284d0f6
https://dawn.googlesource.com/dawn.git/+log/6574f92747a2..582e5284d0f6

2020-04-13 yunchao.he@intel.com Support none visibility binding in bind group
2020-04-13 cwallez@chromium.org Fix another -Wc++11-narrowing on ChromeOS
2020-04-13 enga@chromium.org Cleanup: Rename dawn_wire Object "serial" to "generation"
2020-04-13 enga@chromium.org Tombstone exhausted ObjectIds in the wire
2020-04-13 cwallez@chromium.org Metal: Fix MSAA workaround texture being leaked.
2020-04-13 cwallez@chromium.org Fix -Wc++11-narrowing on ChromeOS
2020-04-13 cwallez@chromium.org Make dawn_native link against user32.lib on Windows
2020-04-13 zmo@chromium.org Fix more compilation warnings.
2020-04-11 zmo@chromium.org Fix more compilation warnings.
2020-04-10 zmo@chromium.org Fix two warnings.
2020-04-10 bryan.bernhart@intel.com D3D12: Bucket CPU descriptor allocators on the device.
2020-04-10 cwallez@chromium.org Fix the CMake build because of CMP0077
2020-04-10 cwallez@chromium.org Split third_party/BUILD.gn in per-project files.
2020-04-10 cwallez@chromium.org Split examples, test and utils in their own BUILD.gn
2020-04-09 brandon1.jones@intel.com Residency 6: Enable D3D12 Residency and Add Tests
2020-04-09 brandon1.jones@intel.com Residency Bug: Make Setting Heap's Last Submission Serial Optional
2020-04-09 enga@chromium.org Fix use-after-free if BindGroup is the last owner of its BindGroupLayout

Bug: chromium:1064305
TBR=cwallez@chromium.org
Change-Id: I601058bf17c22519e5353e6d17d1434a89a06a6a
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/282973
Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Commit-Queue: Zhenyao Mo <zmo@chromium.org>
2020-04-13 22:16:10 +00:00
Zhenyao Mo
854ac61e90 Roll Dawn 11652ff8f8b3..6574f92747a2.
This also rolls
* glslang 1f0fcbe5a...b5757b950
* shaderc 362becca1..802636496
* spirv-cross 871c85d7f..6637610b1
* spirv-tools 1c8bda372..e95fbfb1f

https://dawn.googlesource.com/dawn.git/+log/11652ff8f8b3..6574f92747a2

git log 11652ff8f..6574f9274 --date=short --no-merges --format='%ad %ae %s'
2020-04-09 cwallez@chromium.org Fix the @rpath of dawn_components
2020-04-09 cwallez@chromium.org Remove temporary GN groups after Chromium fix
2020-04-09 cwallez@chromium.org Fix UBO/SSBO OOB in ComputeStorageBufferBarrierTests
2020-04-09 cwallez@chromium.org Fix wgpu::WholeSize not being set correctly inside BindGroup
2020-04-09 cwallez@chromium.org Skip ViewportTest failing on Swiftshader.
2020-04-09 cwallez@chromium.org Skip Float16 TextureFormatTests on Swiftshader
2020-04-08 rharrison@chromium.org Propagate comparison sampler support from spvc
2020-04-08 zmo@chromium.org Make the Vulkan Validation Layers an optional dependency.
2020-04-08 cwallez@chromium.org BUILD.gn: enable additional warnings.
2020-04-08 cwallez@chromium.org Roll third_party/swiftshader/ 51b2800bb..63ed0e445 (131 commits)
2020-04-08 cwallez@chromium.org Fix wgpu::WholeSize to count until the end of the buffer.
2020-04-08 cwallez@chromium.org dawn_wire: Correctly handle buffer state changes on Destroy()
2020-04-07 rharrison@chromium.org Add default to conversion utility to avoid build breakage
2020-04-07 cwallez@chromium.org Fixes to be able to build Dawn inside Skia
2020-04-07 cwallez@chromium.org Simplify the device lifecycle.
2020-04-07 cwallez@chromium.org Fix Dawn's proxy groups to use public_deps instead of deps
2020-04-07 cwallez@chromium.org Fix a -Wstrict-prototypes
2020-04-07 cwallez@chromium.org Add a DeviceBase::Initialize that must be called by backends.
2020-04-07 cwallez@chromium.org BUILD.gn: rename libdawn_native/wire to dawn_native/wire
2020-04-07 cwallez@chromium.org Split dawn_(native|wire|platform) to their own BUILD.gn files
2020-04-07 cwallez@chromium.org Rename BG[L]Binding to BG[L]Entry
2020-04-06 kainino@chromium.org Fix is_asan build (at least on Mac)
2020-04-06 bryan.bernhart@intel.com Reland "D3D12: Stage BindGroups on CPU descriptor heaps."
2020-04-06 rafael.cintron@microsoft.com Make RefCounted derived objects have private destructors
2020-04-06 cwallez@chromium.org Make Toggles overriden automatically and device creation
2020-04-06 hao.x.li@intel.com Force uninitialized variables to be zero for shader compiler on D3D12
2020-04-06 rharrison@chromium.org Rolling 3 dependencies
2020-04-06 cwallez@chromium.org Change the TogglesSet API to look like a set<>
2020-04-06 cwallez@chromium.org Revert "D3D12: Stage BindGroups on CPU descriptor heaps."
2020-04-03 hao.x.li@intel.com Roll third_party/shaderc/ f085b9745..f175adffa (4 commits)
2020-04-03 enga@chromium.org Support chained extension structs on the wire
2020-04-03 bryan.bernhart@intel.com D3D12: Stage BindGroups on CPU descriptor heaps.
2020-04-03 hao.x.li@intel.com Return error instead of crash if compile shader failed on D3D12
2020-04-02 cwallez@chromium.org Add enga@chromium.org as OWNER
2020-04-02 cwallez@chromium.org Fix -Wunreachable-code-break
2020-04-02 cwallez@chromium.org Normalize case X : {} break; to case X : { break;}
2020-04-01 natlee@microsoft.com D3D12 Add check for DXGI_ERROR_DEVICE_REMOVED real device removed
2020-04-01 cwallez@chromium.org Rename GetBindGroupLayout's argument group->groupIndex
2020-04-01 cwallez@chromium.org Separate device lost from internal errors.
2020-03-31 cwallez@chromium.org Use the default values for Dispatch in examples and tests
2020-03-31 cwallez@chromium.org Add the defaults for Draw and DrawIndexed
2020-03-31 brandon1.jones@intel.com Residency 5: Implement and Integrate Residency Management
2020-03-30 yunchao.he@intel.com Add validation tests for resource usage tracking - 4
2020-03-30 cwallez@chromium.org Fix compilation on iOS where setDisplaySyncEnabled isn't available.
2020-03-30 bungeman@chromium.org Add std:: to nullptr_t
2020-03-30 rafael.cintron@microsoft.com Call ID3D12SharingContract::Present on WebGPU swap buffer destroy
2020-03-30 rharrison@chromium.org Rolling 4 dependencies
2020-03-30 natlee@microsoft.com D3D12 Immediately release pending commands
2020-03-27 yunchao.he@intel.com Add validation tests for resource usage tracking - 2
2020-03-27 enga@chromium.org Merge BindGroupLayout and ShaderModule BindingInfos
2020-03-27 cwallez@chromium.org Vulkan: Load functions for surface extensions we support.
2020-03-27 cwallez@chromium.org Metal: Don't crash on invalid shaders
2020-03-27 cwallez@chromium.org Vulkan: Free recording context semaphores on destroy.
2020-03-27 cwallez@chromium.org Vulkan: Use EXT_metal_surface instead of MVK_macos_surface
2020-03-27 cwallez@chromium.org Vulkan: Make GatherSurfaceInfo use ResultOrError
2020-03-27 cwallez@chromium.org Vulkan: Don't use vulkan.h's prototypes.
2020-03-27 yunchao.he@intel.com Add validation tests for resource usage tracking
2020-03-26 bryan.bernhart@intel.com perf_tests: Update perf_test_runner format.
2020-03-26 enga@chromium.org Convert LayoutBindingInfo to an array of BindingInfos
2020-03-26 jiawei.shao@intel.com Collect if a storage texture is declared as multisampled in shader
2020-03-25 bryan.bernhart@intel.com D3D12: Add end2end tests for small shader-visible heaps.
2020-03-25 jiawei.shao@intel.com Add validations on the creation of bind groups with storage textures
2020-03-24 enga@chromium.org Add DAWN_NO_DISCARD to ErrorData
2020-03-24 cwallez@chromium.org Validate there are at most kMaxBindingsPerGroup entries per layout.
2020-03-24 jiawei.shao@intel.com Reland "Check bind group layout with storage texture in pipeline descriptors"
2020-03-23 enga@chromium.org Fix MSVC build
2020-03-23 rharrison@chromium.org Rolling 5 dependencies
2020-03-23 cwallez@chromium.org Properly handle SPVC errors.
2020-03-23 cwallez@chromium.org Stop using SPVC by default.
2020-03-20 enga@chromium.org Support and pack unbounded binding numbers in the BGL

1f0fcbe5a...b5757b950

git log 1f0fcbe5a..b5757b950 --date=short --no-merges --format='%ad %ae %s'
2020-04-03 rharrison@google.com Remove extra semicolons (#2170)
2020-04-02 mbechard@users.noreply.github.com Shader interface matching rework to fix #2136 (#2156)
2020-04-01 cepheus@frii.com Build warning: Fix #2167: Remove nested reuse of 'unreachable'.
2020-03-31 cepheus@frii.com Bump revision.
2020-03-30 alele@nvidia.com Error assigns to objects of rayQueryEXT type.
2020-03-30 dsinclair@google.com Remove unused variables.
2020-03-30 cepheus@frii.com Fix #2163: improve comments for addProcess() and the preamble.
2020-03-30 ntfs.hard@gmail.com printf format
2020-03-30 ntfs.hard@gmail.com unused var
2020-03-30 ntfs.hard@gmail.com bitwise on boolean
2020-03-30 ntfs.hard@gmail.com opposite inner condition
2020-03-27 greg@lunarg.com Update spirv-tools known_good to latest stable
2020-03-26 neslisah.torosdagli@amd.com accelerationStructureEXT - issue #2152
2020-03-26 neslisah.torosdagli@amd.com accelerationStructureEXT - issue #2152
2020-03-26 neslisah.torosdagli@amd.com pass by reference updates
2020-03-26 neslisah.torosdagli@amd.com pass-by-reference updates
2020-03-25 gcmn@google.com Add missing braces to if condition
2020-03-25 neslisah.torosdagli@amd.com switch format update
2020-03-24 neslisah.torosdagli@amd.com copyright notice changes removed from unchanged files
2020-03-24 neslisah.torosdagli@amd.com copyright notice changes removed from unchanged files
2020-03-24 neslisah.torosdagli@amd.com copyright notice changes removed from unchanged files
2020-03-24 neslisah.torosdagli@amd.com spirv.hpp reverted to commit f368dcbb7d8af23f0cba3015d0f4dda9dc3aa66d
2020-03-24 neslisah.torosdagli@amd.com .travis updated to origin, rayQueryCheck removed
2020-03-23 neslisah.torosdagli@amd.com const rayFlag defs used in the test cases in stead of numerical values
2020-03-23 neslisah.torosdagli@amd.com compute and fragment shader test_cases added for rayQuery
2020-03-23 neslisah.torosdagli@amd.com rayQuery test cases added
2020-03-23 neslisah.torosdagli@amd.com rayQueryEXT function parameter
2020-03-23 neslisah.torosdagli@amd.com rayQueryEXT assignment is allowed.
2020-03-23 neslisah.torosdagli@amd.com test names updated
2020-03-23 kainino@chromium.org update README
2020-03-23 kainino@chromium.org Fix build on CMake 2.8, and fix Web build
2020-03-23 neslisah.torosdagli@amd.com wait time increased for the install
2020-03-23 neslisah.torosdagli@amd.com rayQuery test cases disabled
2020-03-20 neslisah.torosdagli@amd.com GL_EXT_ray_query glslang updates, and test cases added.
2020-03-19 neslisah.torosdagli@amd.com comment update, rayQueryEXT is writable, readonly check removed.
2020-03-19 ntorosda@amd.com GL_EXT_ray_query updates
2020-03-18 cepheus@frii.com Fix #2132: constant matrix constructor from single non-scalar argument
2020-03-19 neslisah.torosdagli@amd.com comment update, rayQueryEXT is writable, readonly check removed.
2020-03-19 ntorosda@amd.com GL_EXT_ray_query updates
2020-03-18 cepheus@frii.com Fix #2132: constant matrix constructor from single non-scalar argument
2020-03-19 neslisah.torosdagli@amd.com comment update, rayQueryEXT is writable, readonly check removed.
2020-03-19 neslisah.torosdagli@amd.com GL_EXT_ray_query updates
2020-03-19 ntorosda@amd.com GL_EXT_ray_query updates

362becca1...802636496

git log 362becca1..802636496 --date=short --no-merges --format="%ad %ae %s"
2020-04-07 rharrison@google.com Add concept of comparison sampler to API (#1036)
2020-04-06 rharrison@google.com Start shaderc v2020.1
2020-04-06 rharrison@google.com Finalize shaderc v2020.0
2020-04-06 rharrison@google.com Update CHANGES
2020-04-06 rharrison@google.com Rolling 5 dependencies and updating exceptions (#1035)
2020-04-02 rharrison@google.com Add flag to control if we build with -Werror (#1032)
2020-03-31 rharrison@google.com Add knob to control force_zero_initialized_variables (#1028)
2020-03-31 dgkoch@users.noreply.github.com update glslang to SDK-Candidate-2 tag (#1027)
2020-03-30 rharrison@google.com Rolling 5 dependencies and updated exceptions (#1026)
2020-03-30 dgkoch@users.noreply.github.com Roll glslang dependency to SDK-candidate tag (#1024)
2020-03-30 rharrison@google.com Add support for WebGPU to shaderc (#1021)
2020-03-26 rharrison@google.com Convert compile options to require explicit environments (#1019)
2020-03-26 dgkoch@users.noreply.github.com Roll glslang dependency (#1018)
2020-03-24 jiawei.shao@intel.com SPVC: Record if a storage texture is declared as multisampled texture (#1011)
2020-03-24 rharrison@google.com Add message about status of artifacts to downloads.md (#1012)
2020-03-24 rharrison@google.com Rolling 5 dependencies (#1014)
2020-03-20 jiawei.shao@intel.com Extract texture dimension for storage textures (#1008)

871c85d7f...6637610b1

git log 871c85d7f..6637610b1 --date=short --no-merges --format='%ad %ae %s'
2020-04-03 post@arntzen-software.no Expose a query if samplers or images are comparison resources.
2020-04-03 post@arntzen-software.no Do not add NonWritable/NonReadable decorations for regular images.
2020-04-03 post@arntzen-software.no MSL: Deal with cases where builtin is implicitly needed, declared, but unused.
2020-04-03 post@arntzen-software.no HLSL: Add support for treating NonWritable UAV texture as SRV instead.
2020-04-03 troughton@users.noreply.github.com MSL: mark BuiltInFragCoord as implicitly used for subpass reads
2020-03-31 post@arntzen-software.no MSL: Fix access chain for deep struct hierarchy on array of buffers.
2020-03-30 dsinclair@google.com Roll GLSLang, SPIRV-Tools and SPIRV-Headers
2020-03-26 post@arntzen-software.no Add support for forcefully zero-initialized variables.

1c8bda372...e95fbfb1f

git log 1c8bda372..e95fbfb1f --date=short --no-merges --format='%ad %ae %s'
2020-04-02 afdx@google.com spirv-fuzz: Transformation to add OpConstantNull (#3273)
2020-04-02 afdx@google.com spirv-fuzz: Handle isomorphic types property in composite construction (#3262)
2020-04-02 afdx@google.com spirv-fuzz: Limit adding of new variables to 'basic' types (#3257)
2020-04-02 afdx@google.com spirv-fuzz: Only replace regular ids with synonyms (#3255)
2020-04-02 afdx@google.com spirv-fuzz: Introduce TransformationContext (#3272)
2020-04-02 afdx@google.com spirv-fuzz: Add validator options (#3254)
2020-04-02 alanbaker@google.com Update dominates to check for null nodes (#3271)
2020-04-01 alanbaker@google.com Set wrapped kill basic block's parent (#3269)
2020-03-31 caio.oliveira@intel.com Validate Buffer and BufferBlock apply only to struct types (#3259)
2020-03-26 stevenperron@google.com Start SPIRV-Tools v2020.3
2020-03-26 stevenperron@google.com Finalize SPIRV-Tools v2020.2
2020-03-26 stevenperron@google.com Update CHANGES
2020-03-25 alanbaker@google.com Fix identification of Vulkan images and buffers (#3253)
2020-03-23 alanbaker@google.com Disallow phis of images, samplers and sampled images (#3246)

Bug: chromium:1064305
Change-Id: I1cd089f346a21d5c0e8d956e6227d5ba430759c3
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/282738
Commit-Queue: Zhenyao Mo <zmo@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
2020-04-09 23:35:09 +00:00
Ben Wagner
36e67aa869 Mark dawn and shaderc as third_party.
This introduces a 'third_party_config' gn template which forwards any
include_dirs as cflag system dirs. This is then used on the dawn and
shaderc configs to suppress warnings from use of their headers in Skia.
This route was chosen as a way to minimize the diff with the upstream
BUILD.gn files for these projects for easier updates.

It would be nice if gn could handle this in the build system, since it
isn't good to hide include directories from gn this way. The gn issue
https://bugs.chromium.org/p/gn/issues/detail?id=157 was created to track
gn being able to do this in a cleaner way.

Change-Id: I2d17d099db7b3d8b5a960576ca0535a22badd902
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/281356
Auto-Submit: Ben Wagner <bungeman@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
2020-04-03 20:46:14 +00:00
skia-autoroll
d97187cfed Roll skia/third_party/skcms bd0abcd0646a..60d5d65325e6 (1 commits)
https://skia.googlesource.com/skcms.git/+log/bd0abcd0646a..60d5d65325e6

git log bd0abcd0646a..60d5d65325e6 --date=short --first-parent --format='%ad %ae %s'
2020-04-03 mtklein@google.com gn format skcms.gni

Created with:
  gclient setdep -r skia/third_party/skcms@60d5d65325e6

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skcms-skia-autoroll
Please CC michaelludwig@google.com,mtklein@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

TBR=michaelludwig@google.com, mtklein@google.com

Cq-Include-Trybots: luci.chromium.try:linux-blink-rel
Bug: None
Change-Id: Iddb364d4118ddb504281b90738440d9ec4a6e143
Tbr: michaelludwig@google.com,mtklein@google.com
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/281508
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2020-04-03 17:12:44 +00:00
Mike Klein
a01c6b0b59 reformat GN files
Change-Id: I2d19c4f0ff1439dcd923a3064eb3ba78432a5113
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/281043
Commit-Queue: Mike Klein <mtklein@google.com>
Reviewed-by: Ben Wagner <bungeman@google.com>
2020-04-01 23:23:03 +00:00
Ben Wagner
507e486219 Revert "Enable deprecated-copy-dtor warning."
This reverts commit e990fcc4b0.

Reason for revert: Build-Win-Clang-x86_64-Release-Shared

Original change's description:
> Enable deprecated-copy-dtor warning.
> 
> In C++11 a user declared destructor still requires the compiler to
> implicitly default the copy constructor and copy assignment operator,
> but this is deprecated. Note that a user declared destructor suppresses
> the move constructor and move assignment operator; a user declared
> destructor exists if any '~Foo' method declaration appears inside
> 'class Foo' (even if defaulted); if the copy and move operations are the
> same then copy operations that take 'const Foo&' will do fine double
> duty as move operations.
> 
> Clang seems to have an issue with this warning, in that it does not
> appear to distinguish between compiler defaulted and user defaulted
> destructors. As a result, it does not always warn when it should.
> There may yet be places in the code where a move operation is desired
> but may be suppressed because the implicitly defaulted  moves are not
> declared because a destructor has been declared.
> 
> This wraps dawn and shaderc configs in 'third_party' so that their
> headers will be included through '-isystem' in order to avoid the
> warnings generated by including their headers.
> 
> Change-Id: I681524cd890d86305aa99b6b765a52113b4dfa4b
> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/280406
> Reviewed-by: Mike Klein <mtklein@google.com>
> Reviewed-by: Brian Salomon <bsalomon@google.com>
> Commit-Queue: Ben Wagner <bungeman@google.com>

TBR=mtklein@google.com,bsalomon@google.com,bungeman@google.com

Change-Id: Icd6a2487637d21fcf7c4c7ab7cba7a8adfda5afd
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/280836
Reviewed-by: Ben Wagner <bungeman@google.com>
Commit-Queue: Ben Wagner <bungeman@google.com>
2020-03-31 22:32:07 +00:00
Ben Wagner
e990fcc4b0 Enable deprecated-copy-dtor warning.
In C++11 a user declared destructor still requires the compiler to
implicitly default the copy constructor and copy assignment operator,
but this is deprecated. Note that a user declared destructor suppresses
the move constructor and move assignment operator; a user declared
destructor exists if any '~Foo' method declaration appears inside
'class Foo' (even if defaulted); if the copy and move operations are the
same then copy operations that take 'const Foo&' will do fine double
duty as move operations.

Clang seems to have an issue with this warning, in that it does not
appear to distinguish between compiler defaulted and user defaulted
destructors. As a result, it does not always warn when it should.
There may yet be places in the code where a move operation is desired
but may be suppressed because the implicitly defaulted  moves are not
declared because a destructor has been declared.

This wraps dawn and shaderc configs in 'third_party' so that their
headers will be included through '-isystem' in order to avoid the
warnings generated by including their headers.

Change-Id: I681524cd890d86305aa99b6b765a52113b4dfa4b
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/280406
Reviewed-by: Mike Klein <mtklein@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Ben Wagner <bungeman@google.com>
2020-03-31 22:15:07 +00:00
Herb Derby
adf9d21704 Update header list for spirv-tools
Change-Id: I92fd8dbdc5fc1f2a3e52c1fcda7b5740d8978219
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/280608
Reviewed-by: Mike Klein <mtklein@google.com>
Reviewed-by: Sean Gilhuly <sgilhuly@chromium.org>
Auto-Submit: Herb Derby <herb@google.com>
Commit-Queue: Herb Derby <herb@google.com>
2020-03-31 18:20:27 +00:00
Sean Gilhuly
695f57da6c Roll Dawn and add dependencies
Add Dawn's dependencies shaderc and glslang, and roll SPIRV. Update the
BUILD.gn files to match upstream changes.

Bug: skia:9939, chromium:1064563
Change-Id: Ie9720806efe823312da10f7911688f12cad0713e
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/278770
Commit-Queue: Mike Klein <mtklein@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
Reviewed-by: Weston Tracey <westont@google.com>
2020-03-30 18:52:06 +00:00
skia-autoroll
0f4eba56b7 Roll skia/third_party/skcms cbf3b9df1ae1..bd0abcd0646a (1 commits)
https://skia.googlesource.com/skcms.git/+log/cbf3b9df1ae1..bd0abcd0646a

git log cbf3b9df1ae1..bd0abcd0646a --date=short --first-parent --format='%ad %ae %s'
2020-03-24 mtklein@google.com add _sRGB 8888 formats

Created with:
  gclient setdep -r skia/third_party/skcms@bd0abcd0646a

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skcms-skia-autoroll
Please CC robertphillips@google.com,mtklein@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

TBR=mtklein@google.com, robertphillips@google.com

Cq-Include-Trybots: luci.chromium.try:linux-blink-rel
Bug: None
Change-Id: Ia22a284653b8b16f2738518d426027ad0449afa3
Tbr: robertphillips@google.com,mtklein@google.com
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/278803
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2020-03-24 18:03:33 +00:00
Robert Phillips
0cf2b644a5 Add missing files to Dawn build
This adds the RenderPassBuilderD3D12 files and ignores a narrowing error in them.

Change-Id: Ie9ebc1608ad6bbbc48e0f1cd8d54a9213d9836a4
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/278777
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>
2020-03-24 14:42:54 +00:00
Brian Salomon
4b55ff097b Fix cmake angle build on linux.
Include libangle_gl_egl_sources and libangle_gl_egl_dl_sources source sets

Change-Id: I86aa7fb19eb5ec195b8ba35b46a66449e0e461f9
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/277738
Auto-Submit: Brian Salomon <bsalomon@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
2020-03-19 21:10:56 +00:00
Brian Osman
4a4e9c9f2c Restore logic to check for .git in ANGLE BUILD.gn
This should ensure that for users where the ANGLE git repo is present,
we correctly re-generate commit.h when rolling to a new revision.

Cq-Include-Trybots: skia/skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia/skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-Golo-GPU-QuadroP400-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC8i5BEK-GPU-IntelIris655-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE
Change-Id: Ib3c77a19d243896f4e7359dc4f14e87d4907739e
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/274498
Reviewed-by: Geoff Lang <geofflang@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
2020-03-02 20:02:19 +00:00
Brian Osman
470f0637ae (Manual) Roll third_party/externals/angle2 4dc19c38c0c5..ff60abaf62b4 (51 commits)
4dc19c38c0..ff60abaf62

git log 4dc19c38c0c5..ff60abaf62b4 --date=short --first-parent --format='%ad %ae %s'
2020-03-02 tobine@google.com Vulkan:Disable FramebufferVk cache on Apple
2020-03-02 geofflang@google.com Change commit_id 'check' back to looking for .git files.
2020-03-02 wangra@google.com Vulkan: reserve extra varyings
2020-03-02 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/vulkan-validation-layers/src 8c312ef4c7a9..cb689b0b1d30 (4 commits)
2020-03-02 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/SwiftShader 05f5e0b34ac8..416d37452275 (3 commits)
2020-03-02 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/spirv-tools/src 70f888131ede..e1688b60caf7 (2 commits)
2020-03-02 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/glslang/src f13d38f3cd3c..56364b6b6026 (5 commits)
2020-03-02 jmadill@chromium.org Test Runner: Add stub register function to GLES 1 CTS.
2020-03-01 jmadill@chromium.org Test Runner: Add stub register function to white box tests.
2020-03-01 jmadill@chromium.org Test Runner: Use system path for gtest-internal.
2020-03-01 jmadill@chromium.org Add RegisterContextCompatibilityTests stub.
2020-02-29 jmadill@chromium.org Upgrade gl2ext.h.
2020-02-29 jmadill@chromium.org Trace/Replay: Add framebuffer change callback.
2020-02-28 geofflang@google.com Add the ANGLE Android developer options to the ANGLE repository.
2020-02-28 xiaoxuan.liu@arm.com Vulkan: Add robust init for NULL texture image.
2020-02-28 b.schade@samsung.com Add Android boot animation and rounding error test
2020-02-28 ynovikov@chromium.org Suppress SwANGLE dEQP-GLES3.functional.texture.compressed.astc.* failures
2020-02-28 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/glslang/src 07e1a0a67aee..f13d38f3cd3c (1 commits)
2020-02-28 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/vulkan-validation-layers/src 38f68cce445b..8c312ef4c7a9 (5 commits)
2020-02-28 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/SwiftShader 4b34ee3de531..05f5e0b34ac8 (2 commits)
2020-02-28 tobine@google.com Revert "Vulkan:Include precision qualifier in GLSL"
2020-02-27 rnk@chromium.org Revert "Vulkan: Disable global merge for volk"
2020-02-27 jmadill@chromium.org Capture/Replay: Capture DrawBuffersEXT.
2020-02-27 jmadill@chromium.org Fix out-of-bounds read in test.
2020-02-27 jonahr@google.com eglGetConfigAttrib validation missing extension check
2020-02-27 geofflang@chromium.org Make GLSLTest_ES31.MixOfAllResources more lenient.
2020-02-27 cclao@google.com Vulkan: Optimize element buffer conversion
2020-02-27 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/SwiftShader da659b374113..4b34ee3de531 (3 commits)
2020-02-27 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/vulkan-validation-layers/src 3f4d08da8897..38f68cce445b (1 commits)
2020-02-27 ianelliott@google.com Vulkan: Updated expectations after SwS fixed 4259
2020-02-27 ynovikov@chromium.org Fix Android component build.
2020-02-27 ianelliott@google.com Vulkan: Implement Android pre-rotation
2020-02-27 geofflang@google.com Always use commit_id.py to generate commit.h
2020-02-27 jmadill@chromium.org Vulkan: Document command access APIs.
2020-02-26 jmadill@chromium.org Fix MultipleDrawBuffers sample.
2020-02-26 tobine@google.com Vulkan:Include precision qualifier in GLSL
2020-02-26 b.schade@samsung.com glslang: enforce initialize and release as once per process
2020-02-26 courtneygo@google.com Save binding information when caching shader
2020-02-26 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/spirv-tools/src 8910ea5f1c7b..70f888131ede (2 commits)
2020-02-26 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/vulkan-validation-layers/src a09ab94aa920..3f4d08da8897 (2 commits)
2020-02-26 robliao@chromium.org Revert "Always use commit_id.py to generate commit.h"
2020-02-26 tobine@google.com Vulkan:Refactor precision emulation code
2020-02-25 capn@google.com Update DEPS for SPIRV-Tools and SwiftShader
2020-02-25 jmadill@chromium.org Vulkan: Use new APIs in BufferHelper::copyFromBuffer.
2020-02-25 jmadill@chromium.org Vulkan: Fix padding out Buffer allocations on AMD.
2020-02-25 jmadill@chromium.org Vulkan: Update buffer accumulation TODO bug IDs.
2020-02-25 xinyi.he@arm.com Fix the condition of glOrtho{fx} validation
2020-02-25 pmberube@google.com Fix a GCC 10 build failure.
2020-02-25 b.schade@samsung.com Vulkan: prevent volk reloading on null instance and devices
2020-02-25 jmadill@chromium.org Trace/Replay: Add uniform locations map.
2020-02-25 jmadill@chromium.org Vulkan: Update ContextVk command buffer access methods.

Created with:
  gclient setdep -r third_party/externals/angle2@ff60abaf62b4

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-skia-autoroll
Please CC herb@google.com,brianosman@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: skia/skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia/skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-Golo-GPU-QuadroP400-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC8i5BEK-GPU-IntelIris655-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE
Bug: None
Tbr: herb@google.com,brianosman@google.com
Change-Id: I3bbe489230900973f4b2eacbde23a7444ffc0a65
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/274047
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
2020-03-02 17:53:29 +00:00
Weston Tracey
9fbba62dc7 Format GN, isn't checked in third_party, so missed it the first time.
Bug: skia:9939
Change-Id: Ia02803f93a8b90fd8d03465226379b028add7f5e
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/274046
Auto-Submit: Weston Tracey <westont@google.com>
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Greg Daniel <egdaniel@google.com>
2020-02-28 19:05:35 +00:00
Weston Tracey
2d6261557e Add Dawn on Windows job.
This job currently does not build. Once fixed it will be added to the CQ.

Bug: skia:9939
Change-Id: I0f29292670554b43ba4518ba0d2d7593ef4beddf
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/273481
Commit-Queue: Weston Tracey <westont@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
Reviewed-by: Ben Wagner aka dogben <benjaminwagner@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
2020-02-28 17:48:37 +00:00
Brian Salomon
2677debcf0 Manual ANGLE roll. Update to our BUILD.gn to gen ANGLE's commit.h
Change-Id: I2935504caae35b612280691240fa4fff825632e3
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/273268
Reviewed-by: Julia Lavrova <jlavrova@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
2020-02-25 20:10:38 +00:00
skia-autoroll
8da5c3d450 Roll skia/third_party/skcms 605b00d7728f..cbf3b9df1ae1 (1 commits)
https://skia.googlesource.com/skcms.git/+log/605b00d7728f..cbf3b9df1ae1

git log 605b00d7728f..cbf3b9df1ae1 --date=short --first-parent --format='%ad %ae %s'
2020-02-24 benjaminwagner@google.com Update Xcode

Created with:
  gclient setdep -r skia/third_party/skcms@cbf3b9df1ae1

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skcms-skia-autoroll
Please CC jlavrova@google.com,mtklein@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

TBR=jlavrova@google.com, mtklein@google.com

Cq-Include-Trybots: luci.chromium.try:linux-blink-rel
Bug: None
Change-Id: I2368ab4ab1a61ed94e19d96aff2398992320fb12
Tbr: jlavrova@google.com,mtklein@google.com
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/272982
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2020-02-24 16:46:45 +00:00
Brian Osman
4156d33568 Switch SPIRV-Cross to use third_party GN template
Suppresses all warnings (nonportable include paths, etc.)

Change-Id: Ic1bbf2496a2fe259d5e7a9537e1d89ec74a99add
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/271857
Commit-Queue: Brian Osman <brianosman@google.com>
Auto-Submit: Brian Osman <brianosman@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
2020-02-19 14:52:48 +00:00
Mike Klein
c0c0522e80 let's try to fix nullptr + k
Apply -fsanitize-recover=pointer-overflow to third_party code only.

I'm trying to keep Skia behaving the same, avoiding illegal nullptr+k:
    - Add null check in SkJSON fast string path.
    - Add null check (first alloc) and some comments to SkArenaAlloc.
    - March an int index instead dst pointer in SkBase64.

Bug: skia:9731
Change-Id: I646635558ea63ded846b746f2a1f0b4f1e1eacff
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/268109
Reviewed-by: Florin Malita <fmalita@chromium.org>
Reviewed-by: Herb Derby <herb@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
2020-01-31 19:24:21 +00:00
Kevin Lubick
dc49b0ca98 [canvaskit] Fix support for fonts with CFF
Adds a test to load different font types. Currently supported:
 - .ttf
 - .otf
 - .ttc

Not supported:
 - .woff
 - .woff2

This only increases code size by ~4kb, so that big glyph table
has still been successfully removed.

Bug: skia:9829
Change-Id: I0231578b2abf4f36df57ff8073b7697d16606373
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/267180
Reviewed-by: Ben Wagner <bungeman@google.com>
2020-01-29 12:39:55 +00:00
Kevin Lubick
08bf8f79f1 [canvaskit] Remove support for T1 fonts and reduce code size
We were previously building FreeType2 with the psnames module,
which included large tables of glyphnames [1]. These were only
used in code related to PDF (and only when outputting Type 1
fonts, which is very rare).

Even though the PDF backend isn't in CanvasKit, the compiler
couldn't throw away these massive tables (about 80k in all)
of strings. Since these tables were only used for T1 fonts,
it made sense to tell FreeType not to include the rest of the
T1 related code, which saved about 55k more.

If, one day, we add in support for the PDF backend to CanvasKit,
SK_PDF_DO_NOT_SUPPORT_TYPE_1_FONTS is likely something we'll
want to define.

The roll-freetype.sh is inspired by a script of the same name
in the Chromium repo and aids in the updating of freetype
and our forked config files.

[1] 0a3d2bb99b/src/psnames/pstables.h (629)

Bug: skia:9733
Change-Id: I359bab4184587cbe91400661fb012eac1a601a83
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/262232
Reviewed-by: Ben Wagner <bungeman@google.com>
2020-01-06 18:49:41 +00:00
skia-autoroll
ccd45a5efe Roll skia/third_party/skcms ab3cf9c7bd22..605b00d7728f (1 commits)
https://skia.googlesource.com/skcms.git/+log/ab3cf9c7bd22..605b00d7728f

git log ab3cf9c7bd22..605b00d7728f --date=short --first-parent --format='%ad %ae %s'
2020-01-03 benjaminwagner@google.com [infra] Upgrade Win to 2019

Created with:
  gclient setdep -r skia/third_party/skcms@605b00d7728f

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skcms-skia-autoroll
Please CC nifong@google.com,mtklein@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

TBR=mtklein@google.com, nifong@google.com

Cq-Include-Trybots: luci.chromium.try:linux-blink-rel
Bug: None
Change-Id: Id2b8911973cb5b5b46f350ebb841ada741ccbaec
Tbr: nifong@google.com,mtklein@google.com
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/262076
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2020-01-03 16:21:17 +00:00
skia-autoroll
ad178db1fb Roll skia/third_party/skcms 25234a0a9c2c..ab3cf9c7bd22 (1 commits)
https://skia.googlesource.com/skcms.git/+log/25234a0a9c2c..ab3cf9c7bd22

git log 25234a0a9c2c..ab3cf9c7bd22 --date=short --first-parent --format='%ad %ae %s'
2020-01-02 benjaminwagner@google.com Use new dimension value for Win2016.

Created with:
  gclient setdep -r skia/third_party/skcms@ab3cf9c7bd22

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skcms-skia-autoroll
Please CC nifong@google.com,mtklein@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

TBR=mtklein@google.com, nifong@google.com

Cq-Include-Trybots: luci.chromium.try:linux-blink-rel
Bug: None
Change-Id: If9441b0b473ec26f288ffc655201aee406d24ec4
Tbr: nifong@google.com,mtklein@google.com
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/261888
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2020-01-02 20:09:53 +00:00
Mike Klein
d2da6a7902 build libjpeg-turbo with -DUSE_CLZ_INTRINSIC
Otherwise it falls back on a 64K table.

Change-Id: I871fdfd9ef22ba7f3df758272b7dc557f217d5e0
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/261942
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
2020-01-02 18:06:36 +00:00
skia-autoroll
f5cde33d58 Roll skia/third_party/skcms ec78f685becd..25234a0a9c2c (1 commits)
https://skia.googlesource.com/skcms.git/+log/ec78f685becd..25234a0a9c2c

git log ec78f685becd..25234a0a9c2c --date=short --first-parent --format='%ad %ae %s'
2020-01-02 mtklein@google.com update skcms bot packages

Created with:
  gclient setdep -r skia/third_party/skcms@25234a0a9c2c

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skcms-skia-autoroll
Please CC nifong@google.com,mtklein@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

TBR=mtklein@google.com, nifong@google.com

Cq-Include-Trybots: luci.chromium.try:linux-blink-rel
Bug: None
Change-Id: Idaa7ef26f88e2c24d08683f1d0fdd5a24d616383
Tbr: nifong@google.com,mtklein@google.com
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/261939
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2020-01-02 17:57:46 +00:00
Brian Osman
63d32153ad Remove third_party warning suppression for MSVC:4244
This was a workaround for older MSVC that didn't suppress that
particular warning as part of "/w". Bots are using a newer compiler that
fixes the issue.

Change-Id: If8582a688294286c2b307970415cd1d929b184b1
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/261738
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
2019-12-30 16:13:56 +00:00
Brian Osman
22a2419863 Fix CMake build
Change-Id: I1bd8a319cff923448c0e2e9e11b1416d0cb89fee
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/261541
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
2019-12-26 19:33:42 +00:00
Brian Osman
1e5672715a Roll ICU and Harfbuzz
Updating the bots to MSVC 2019 requires a newer ICU (to fix an issue
with usage of std::atomic), and updating ICU requires updating HB.

Change-Id: I889add046b957d7699cb8c3cafb9dd91b3e588d4
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/261540
Commit-Queue: Brian Osman <brianosman@google.com>
Reviewed-by: Florin Malita <fmalita@chromium.org>
Reviewed-by: Brian Osman <brianosman@google.com>
2019-12-26 18:13:42 +00:00
Mike Klein
cd774debd7 disable warnings in ANGLE
We already actively don't turn on more warnings; this disables what must
be default warnings.  This is the same logic we apply in our usual
third_party() template (see third_party/third_party.gni).

Change-Id: Icc164f8d288005baf1f0a1c7d408054acc7d4701
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/260881
Commit-Queue: Mike Klein <mtklein@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
Auto-Submit: Mike Klein <mtklein@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
2019-12-18 19:24:11 +00:00
skia-autoroll
ea47b0e658 Roll skia/third_party/skcms cd31cb38833c..ec78f685becd (1 commits)
https://skia.googlesource.com/skcms.git/+log/cd31cb38833c..ec78f685becd

git log cd31cb38833c..ec78f685becd --date=short --first-parent --format='%ad %ae %s'
2019-12-13 brianosman@google.com Direct fit of small tables can produce "kBad" transfer functions

Created with:
  gclient setdep -r skia/third_party/skcms@ec78f685becd

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skcms-skia-autoroll
Please CC djsollen@google.com,mtklein@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

TBR=djsollen@google.com, mtklein@google.com

Cq-Include-Trybots: luci.chromium.try:linux-blink-rel
Bug: None
Change-Id: If37d38274c0d05ef6bcfc26be2a8393bd8b30957
Tbr: djsollen@google.com,mtklein@google.com
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/259969
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2019-12-13 19:46:33 +00:00
skia-autoroll
39cdc37bdd Roll skia/third_party/skcms 5855011aeee5..cd31cb38833c (1 commits)
https://skia.googlesource.com/skcms.git/+log/5855011aeee5..cd31cb38833c

git log 5855011aeee5..cd31cb38833c --date=short --first-parent --format='%ad %ae %s'
2019-12-13 mtklein@google.com determine one extra digit, chop it off

Created with:
  gclient setdep -r skia/third_party/skcms@cd31cb38833c

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skcms-skia-autoroll
Please CC djsollen@google.com,mtklein@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

TBR=djsollen@google.com, mtklein@google.com

Cq-Include-Trybots: luci.chromium.try:linux-blink-rel
Bug: None
Change-Id: Ie565af51ae12b90f5b3911ec5909cbcf9e8b6a80
Tbr: djsollen@google.com,mtklein@google.com
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/259873
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2019-12-13 01:28:55 +00:00
skia-autoroll
4d3b4a1bf3 Roll skia/third_party/skcms e7b14532d922..5855011aeee5 (1 commits)
https://skia.googlesource.com/skcms.git/+log/e7b14532d922..5855011aeee5

git log e7b14532d922..5855011aeee5 --date=short --first-parent --format='%ad %ae %s'
2019-12-12 mtklein@google.com roll emscripten on the bots

Created with:
  gclient setdep -r skia/third_party/skcms@5855011aeee5

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skcms-skia-autoroll
Please CC djsollen@google.com,mtklein@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

TBR=djsollen@google.com, mtklein@google.com

Cq-Include-Trybots: luci.chromium.try:linux-blink-rel
Bug: None
Change-Id: I175d03d9042c0a9831e3ed5efecacce2563c50bb
Tbr: djsollen@google.com,mtklein@google.com
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/259865
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2019-12-12 23:06:45 +00:00
skia-autoroll
dcd8e9389d Roll skia/third_party/skcms 7240f337e5d6..e7b14532d922 (1 commits)
https://skia.googlesource.com/skcms.git/+log/7240f337e5d6..e7b14532d922

git log 7240f337e5d6..e7b14532d922 --date=short --first-parent --format='%ad %ae %s'
2019-12-12 mtklein@google.com print one fewer digit than ideal

Created with:
  gclient setdep -r skia/third_party/skcms@e7b14532d922

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skcms-skia-autoroll
Please CC djsollen@google.com,mtklein@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

TBR=djsollen@google.com, mtklein@google.com

Cq-Include-Trybots: luci.chromium.try:linux-blink-rel
Bug: None
Change-Id: Ief74b37cd895f620853cbbd75121eede66eca289
Tbr: djsollen@google.com,mtklein@google.com
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/259837
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2019-12-12 22:38:35 +00:00
skia-autoroll
1521e6b24c Roll skia/third_party/skcms 4e9ed5892c00..7240f337e5d6 (1 commits)
https://skia.googlesource.com/skcms.git/+log/4e9ed5892c00..7240f337e5d6

git log 4e9ed5892c00..7240f337e5d6 --date=short --first-parent --format='%ad %ae %s'
2019-12-12 mtklein@google.com stick to 10.14 Mac bots

Created with:
  gclient setdep -r skia/third_party/skcms@7240f337e5d6

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skcms-skia-autoroll
Please CC djsollen@google.com,mtklein@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

TBR=djsollen@google.com, mtklein@google.com

Cq-Include-Trybots: luci.chromium.try:linux-blink-rel
Bug: None
Change-Id: I3e3a08d7717485a840c6f0f517134e25c55f8d78
Tbr: djsollen@google.com,mtklein@google.com
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/259795
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2019-12-12 21:42:12 +00:00
skia-autoroll
b0892888d1 Roll skia/third_party/skcms 04c7f4ea275f..4e9ed5892c00 (1 commits)
https://skia.googlesource.com/skcms.git/+log/04c7f4ea275f..4e9ed5892c00

git log 04c7f4ea275f..4e9ed5892c00 --date=short --first-parent --format='%ad %ae %s'
2019-12-12 mtklein@google.com better parse mismatch dumps

Created with:
  gclient setdep -r skia/third_party/skcms@4e9ed5892c00

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skcms-skia-autoroll
Please CC djsollen@google.com,mtklein@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

TBR=djsollen@google.com, mtklein@google.com

Cq-Include-Trybots: luci.chromium.try:linux-blink-rel
Bug: None
Change-Id: I39d5d95c0112dfb2e439336fdcc737b9214d560a
Tbr: djsollen@google.com,mtklein@google.com
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/259791
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2019-12-12 21:10:50 +00:00
skia-autoroll
e9e35f736a Roll skia/third_party/skcms 2e1ffb61f677..04c7f4ea275f (1 commits)
https://skia.googlesource.com/skcms.git/+log/2e1ffb61f677..04c7f4ea275f

git log 2e1ffb61f677..04c7f4ea275f --date=short --first-parent --format='%ad %ae %s'
2019-12-12 brianosman@google.com Handle non-invertible fits from linear or direct fit

Created with:
  gclient setdep -r skia/third_party/skcms@04c7f4ea275f

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skcms-skia-autoroll
Please CC djsollen@google.com,mtklein@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

TBR=djsollen@google.com, mtklein@google.com

Cq-Include-Trybots: luci.chromium.try:linux-blink-rel
Bug: None
Change-Id: I2f44da6c70d85f3c66003bb0542c168eee0bb90e
Tbr: djsollen@google.com,mtklein@google.com
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/259781
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2019-12-12 20:16:10 +00:00
skia-autoroll
365bc3ad91 Roll skia/third_party/skcms 64374756e037..2e1ffb61f677 (1 commits)
https://skia.googlesource.com/skcms.git/+log/64374756e037..2e1ffb61f677

git log 64374756e037..2e1ffb61f677 --date=short --first-parent --format='%ad %ae %s'
2019-12-12 mtklein@google.com temporarily disable emscripten on bots

Created with:
  gclient setdep -r skia/third_party/skcms@2e1ffb61f677

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skcms-skia-autoroll
Please CC djsollen@google.com,mtklein@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

TBR=djsollen@google.com, mtklein@google.com

Cq-Include-Trybots: luci.chromium.try:linux-blink-rel
Bug: None
Change-Id: Ia25d01fe3705cc7e60f95346dc7ab10f04fed44b
Tbr: djsollen@google.com,mtklein@google.com
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/259778
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2019-12-12 19:46:09 +00:00
skia-autoroll
70b6b5e977 Roll skia/third_party/skcms ef3043bd8110..64374756e037 (1 commits)
https://skia.googlesource.com/skcms.git/+log/ef3043bd8110..64374756e037

git log ef3043bd8110..64374756e037 --date=short --first-parent --format='%ad %ae %s'
2019-12-11 lode@google.com Add skcms_AdaptToXYZD50 to the API

Created with:
  gclient setdep -r skia/third_party/skcms@64374756e037

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skcms-skia-autoroll
Please CC djsollen@google.com,mtklein@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

TBR=djsollen@google.com, mtklein@google.com

Cq-Include-Trybots: luci.chromium.try:linux-blink-rel
Bug: None
Change-Id: I26a9f24298f1001f024c77ba6a417e43da8961c7
Tbr: djsollen@google.com,mtklein@google.com
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/259376
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2019-12-11 23:12:09 +00:00
skia-autoroll
d07418c457 Roll skia/third_party/skcms 68d3f3a95f1b..ef3043bd8110 (1 commits)
https://skia.googlesource.com/skcms.git/+log/68d3f3a95f1b..ef3043bd8110

git log 68d3f3a95f1b..ef3043bd8110 --date=short --no-merges --format='%ad %ae %s'
2019-11-25 brianosman@google.com Run up to 8 iterations of Gauss-Newton, choose the best error

Created with:
  gclient setdep -r skia/third_party/skcms@ef3043bd8110

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skcms-skia-autoroll
Please CC bungeman@google.com,mtklein@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

TBR=bungeman@google.com, mtklein@google.com

Cq-Include-Trybots: luci.chromium.try:linux-blink-rel
Bug: None
Change-Id: I0c14b4bdd3601848a2a2c6a9f9c8ec3bacf8f068
Tbr: bungeman@google.com,mtklein@google.com
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/256329
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2019-11-25 14:52:45 +00:00
Hal Canary
1ec9a28a28 Replace third_party/gif with new DEPS entry.
- BUILD.gn `gif` optional source_set: use new skia_libgifcodec_path
    code, not third_party/gif code.

  - SkCodec.cpp: use third_party version of SkGifCodec.h.

  - rm src/codec/SkGifCodec.* third_party/gif/*

Original CL: https://review.skia.org/254582

Cq-Include-Trybots: luci.skia.skia.primary:Build-Debian9-Clang-x86-devrel-Android_SKQP
Bug: skia:9654
Change-Id: Ia0379af70a5ec5656a7d123b8b6816b9fa24eaee
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/255780
Reviewed-by: Hal Canary <halcanary@google.com>
Commit-Queue: Hal Canary <halcanary@google.com>
2019-11-21 16:57:57 +00:00
skia-autoroll
d95243b55f Roll skia/third_party/skcms 2914b63d6886..68d3f3a95f1b (1 commits)
https://skia.googlesource.com/skcms.git/+log/2914b63d6886..68d3f3a95f1b

git log 2914b63d6886..68d3f3a95f1b --date=short --no-merges --format='%ad %ae %s'
2019-11-20 brianosman@google.com Add more diagnostic output to ICC profile dumps

Created with:
  gclient setdep -r skia/third_party/skcms@68d3f3a95f1b

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skcms-skia-autoroll
Please CC robertphillips@google.com,mtklein@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel

Bug: None
Change-Id: Id6161785af72c9b37680a1f264cecbb9ff4ef2ac
TBR=robertphillips@google.com,mtklein@google.com
TBR=robertphillips@google.com,mtklein@google.com
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/255475
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2019-11-20 20:59:02 +00:00
Hal Canary
f7cb902904 Revert "Replace third_party/gif with new DEPS entry."
This reverts commit 6d29bfbfcd.

Reason for revert: try to fix g3 roll.

Original change's description:
> Replace third_party/gif with new DEPS entry.
>
>   - skia_libgifcodec_path gn var. Default is
>     third_party/externals/libgifcodec.  Anfroid framework uses
>     third_party/libgifcodec.
>
>   - skia_use_libgifcodec gn var; defaults to !skia_use_wuffs.  Allow
>     disabling both codecs.
>
>   - BUILD.gn `gif` optional source_set: use new skia_libgifcodec_path
>     code, not third_party/gif code.
>
>   - GN template("optional"): add public_include_dirs, similar to
>     public_defines.
>
>   - SK_USE_LIBGIFCODEC, ifdef for skia_use_libgifcodec.
>
>   - SkCodec.cpp: use third_party version of SkGifCodec.h.
>
>   - src/codec/SkGifCodec.*, third_party/gif/*: remove files.
>
> Cq-Include-Trybots: luci.skia.skia.primary:Build-Debian9-Clang-x86-devrel-Android_SKQP
> Bug: skia:9654
> Change-Id: Ie22d2bb7e52322fd3eedb97015f3aec2ce5e3402
> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/254582
> Reviewed-by: Leon Scroggins <scroggo@google.com>
> Commit-Queue: Hal Canary <halcanary@google.com>

TBR=djsollen@google.com,halcanary@google.com,rmistry@google.com,scroggo@google.com

Change-Id: I427e1a073c0574e1502b6196873ac3001a22250b
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: skia:9654
Cq-Include-Trybots: luci.skia.skia.primary:Build-Debian9-Clang-x86-devrel-Android_SKQP
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/255534
Commit-Queue: Hal Canary <halcanary@google.com>
Reviewed-by: Hal Canary <halcanary@google.com>
2019-11-20 20:54:44 +00:00
Hal Canary
6d29bfbfcd Replace third_party/gif with new DEPS entry.
- skia_libgifcodec_path gn var. Default is
    third_party/externals/libgifcodec.  Anfroid framework uses
    third_party/libgifcodec.

  - skia_use_libgifcodec gn var; defaults to !skia_use_wuffs.  Allow
    disabling both codecs.

  - BUILD.gn `gif` optional source_set: use new skia_libgifcodec_path
    code, not third_party/gif code.

  - GN template("optional"): add public_include_dirs, similar to
    public_defines.

  - SK_USE_LIBGIFCODEC, ifdef for skia_use_libgifcodec.

  - SkCodec.cpp: use third_party version of SkGifCodec.h.

  - src/codec/SkGifCodec.*, third_party/gif/*: remove files.

Cq-Include-Trybots: luci.skia.skia.primary:Build-Debian9-Clang-x86-devrel-Android_SKQP
Bug: skia:9654
Change-Id: Ie22d2bb7e52322fd3eedb97015f3aec2ce5e3402
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/254582
Reviewed-by: Leon Scroggins <scroggo@google.com>
Commit-Queue: Hal Canary <halcanary@google.com>
2019-11-20 19:07:00 +00:00
skia-autoroll
cdd774104c Roll skia/third_party/skcms 8d45badce994..2914b63d6886 (1 commits)
https://skia.googlesource.com/skcms.git/+log/8d45badce994..2914b63d6886

git log 8d45badce994..2914b63d6886 --date=short --no-merges --format='%ad %ae %s'
2019-11-20 brianosman@google.com Add another interesting profile to the test corpus

Created with:
  gclient setdep -r skia/third_party/skcms@2914b63d6886

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skcms-skia-autoroll
Please CC robertphillips@google.com,mtklein@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel

Bug: None
Change-Id: Ie1313213d513435a70616583f49a9de87f58c2ed
TBR=robertphillips@google.com,mtklein@google.com
TBR=robertphillips@google.com,mtklein@google.com
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/255536
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2019-11-20 18:56:50 +00:00
John Rosasco
24cbdab97e SKQP Build for Fuchsia SDK
Change-Id: I2619784eca0f7a4dd66f2db0104cb746d9266b4e
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/244369
Commit-Queue: John Rosasco <rosasco@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
2019-11-18 12:34:28 +00:00
skia-autoroll
49481e1000 Roll skia/third_party/skcms 0e5f77218153..8d45badce994 (1 commits)
https://skia.googlesource.com/skcms.git/+log/0e5f77218153..8d45badce994

git log 0e5f77218153..8d45badce994 --date=short --no-merges --format='%ad %ae %s'
2019-11-13 brianosman@google.com Add another test profile from crbug.com/869115

Created with:
  gclient setdep -r skia/third_party/skcms@8d45badce994

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skcms-skia-autoroll
Please CC halcanary@google.com,mtklein@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel

Bug: None
Change-Id: Ic4f14aec3a08bb30d55f3a2d2ea61ee8955449cb
TBR=halcanary@google.com,mtklein@google.com
TBR=halcanary@google.com,mtklein@google.com
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/254399
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2019-11-13 15:34:52 +00:00