Commit Graph

10486 Commits

Author SHA1 Message Date
commit-bot@chromium.org
594aa5e39d Revert of Workaround for assertion in NVPR config in bench. (https://codereview.chromium.org/131503007/)
Reason for revert:
broke the build.

Original issue's description:
> Workaround for assertion in NVPR config in bench.
>
> BUG=skia:2078
>
> Committed: http://code.google.com/p/skia/source/detail?r=13196

R=robertphillips@google.com
TBR=robertphillips@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:2078

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/148473002

git-svn-id: http://skia.googlecode.com/svn/trunk@13199 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-27 18:06:03 +00:00
commit-bot@chromium.org
be39f37e11 Revert of nvpr baselines (https://codereview.chromium.org/132333008/)
Reason for revert:
broke the build

Original issue's description:
> nvpr baselines
> 
> BUG=skia:2042
> 
> Committed: https://code.google.com/p/skia/source/detail?r=13195

TBR=
NOTREECHECKS=true
NOTRY=true
BUG=skia:2042

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/148013003

git-svn-id: http://skia.googlecode.com/svn/trunk@13198 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-27 18:05:21 +00:00
senorblanco@chromium.org
dd13af8449 New baselines for Win7 DirectWrite (shader2 and bezier_conic) and Intel Rhb (imagefiltersbase and imageblur). All failures are pixel intensity mismatch <= 3.
BUG=skia:2085,skia:2081
TBR=epoger@google.com

Review URL: https://codereview.chromium.org/138623007

git-svn-id: http://skia.googlecode.com/svn/trunk@13197 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-27 17:51:12 +00:00
commit-bot@chromium.org
fbd3047d23 Workaround for assertion in NVPR config in bench.
BUG=skia:2078
R=robertphillips@google.com

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/131503007

git-svn-id: http://skia.googlecode.com/svn/trunk@13196 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-27 17:36:38 +00:00
bsalomon@google.com
0655389978 nvpr baselines
BUG=skia:2042

Review URL: https://codereview.chromium.org/132333008

git-svn-id: http://skia.googlecode.com/svn/trunk@13195 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-27 17:04:00 +00:00
commit-bot@chromium.org
788a5f0871 Explain empty report in compare_codereview.py.
Let user know when control and roll have no common trybots, instead of
being silent.

BUG=skia:
R=borenet@google.com

Author: halcanary@google.com

Review URL: https://codereview.chromium.org/135683003

git-svn-id: http://skia.googlecode.com/svn/trunk@13194 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-27 16:34:45 +00:00
senorblanco@chromium.org
b3bf362ce2 Rebaseline some GPU and ANGLE results which started failing on Win7.
BUG=skia:2081
TBR=epoger@google.com

Review URL: https://codereview.chromium.org/135593005

git-svn-id: http://skia.googlecode.com/svn/trunk@13193 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-27 16:22:36 +00:00
commit-bot@chromium.org
0e8d0d6cdc add optional SkAlphaType parameter to notifyPixelsChanged
R=scroggo@google.com, halcanary@google.com, robertphillips@google.com

Author: reed@google.com

Review URL: https://codereview.chromium.org/147213002

git-svn-id: http://skia.googlecode.com/svn/trunk@13192 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-27 15:41:07 +00:00
senorblanco@chromium.org
83c39db913 Remove misc. suppressions from ignored-tests.txt added in https://codereview.chromium.org/105893003. These tests were rebaselined shortly after that patch landed, but the suppressions weren't removed, so differences have snuck in and not been rebaselined.
New Android baselines for imagefiltersgraph, imagefilterscropped, imagefiltersbase, imageblur GMs.
New Nexus4 baselines for testimagefilters, spritebitmap GM.

R=borenet@google.com
TBR=borenet, bungeman
BUG=skia:

Review URL: https://codereview.chromium.org/141033008

git-svn-id: http://skia.googlecode.com/svn/trunk@13191 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-27 15:05:39 +00:00
reed@google.com
7fa2a65c0c fix more 64bit warnings
BUG=skia:

Review URL: https://codereview.chromium.org/147683003

git-svn-id: http://skia.googlecode.com/svn/trunk@13190 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-27 13:42:58 +00:00
reed@google.com
1a5e51f94e remove SkScalarMul from public headers
BUG=skia:

Review URL: https://codereview.chromium.org/132453008

git-svn-id: http://skia.googlecode.com/svn/trunk@13189 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-27 13:41:02 +00:00
commit-bot@chromium.org
e8989578cd Add NVPR configs to bench
BUG=skia:2042
R=robertphillips@google.com

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/145943003

git-svn-id: http://skia.googlecode.com/svn/trunk@13188 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-26 20:51:00 +00:00
commit-bot@chromium.org
440ddf433b Add NVPR configs to GM
BUG=skia:2042
R=robertphillips@google.com

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/139803003

git-svn-id: http://skia.googlecode.com/svn/trunk@13187 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-26 18:07:40 +00:00
bsalomon@google.com
2865839f45 rebaselines from NVPR enable and nexus4 blur radius
BUG=skia:2042

Review URL: https://codereview.chromium.org/146593003

git-svn-id: http://skia.googlecode.com/svn/trunk@13186 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-26 17:51:22 +00:00
skia.committer@gmail.com
33c749a586 Sanitizing source files in Housekeeper-Nightly
git-svn-id: http://skia.googlecode.com/svn/trunk@13185 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-26 07:01:45 +00:00
tfarina@chromium.org
658650c5b4 Remove unused methods from SkWindow.
I came to this while grepping for deprecated SkBitmap's eraseRGB()
method.

BUG=None
TEST=SampleApp still links
R=reed@google.com, robertphillips@google.com

Review URL: https://codereview.chromium.org/147433002

git-svn-id: http://skia.googlecode.com/svn/trunk@13184 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-25 18:45:45 +00:00
commit-bot@chromium.org
c2abd54eda add alternative to isRect named asRect
This defines yunchao's proposed interface in terms of
an existing implementation.

BUG=skia:
R=reed@google.com, yunchao.he@intel.com

Author: caryclark@google.com

Review URL: https://codereview.chromium.org/140953003

git-svn-id: http://skia.googlecode.com/svn/trunk@13183 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-25 16:54:31 +00:00
reed@google.com
eb9a46cbbb add legacy/helper allocN32Pixels, and convert gm to use it
This is an intermediate api, but might help us quickly get to a point where
no one is creating bitmaps in a 2-step process (setConfig + alloc).

BUG=skia:
R=halcanary@google.com

Review URL: https://codereview.chromium.org/140593005

git-svn-id: http://skia.googlecode.com/svn/trunk@13182 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-25 16:46:20 +00:00
skia.committer@gmail.com
d2ac07b64b Sanitizing source files in Housekeeper-Nightly
git-svn-id: http://skia.googlecode.com/svn/trunk@13181 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-25 07:01:49 +00:00
commit-bot@chromium.org
709ca75f03 SkOnce: add option to call another cleanup function once at exit.
Use this to clean up empty SkData and SkPathRef.

Current leaks:
  Leaked SkRefCntBase: 40
     Leaked SkFlattenable: 32
         Leaked SkPixelRef: 32
             Leaked SkMallocPixelRef: 32
     Leaked SkFontConfigInterface: 1
     Leaked SkWeakRefCnt: 1
         Leaked SkTypeface: 1
     Leaked SkFontMgr: 1
     Leaked SkDataTable: 3
     Leaked SkImage: 1
         Leaked ???: 1
     Leaked ???: 1

BUG=skia:
R=halcanary@google.com, reed@google.com

Author: mtklein@google.com

Review URL: https://codereview.chromium.org/132803005

git-svn-id: http://skia.googlecode.com/svn/trunk@13180 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-24 22:38:39 +00:00
commit-bot@chromium.org
3a9ade7f37 Updates bench expectations; adds new platforms.
BUG=skia:
R=borenet@google.com, robertphillips@google.com

Author: bensong@google.com

Review URL: https://codereview.chromium.org/131343009

git-svn-id: http://skia.googlecode.com/svn/trunk@13179 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-24 21:50:03 +00:00
commit-bot@chromium.org
a8c7f7702f fix (some) 64bit warnings -- size_t -> int
BUG=skia:
R=mtklein@google.com

Author: reed@google.com

Review URL: https://codereview.chromium.org/147053003

git-svn-id: http://skia.googlecode.com/svn/trunk@13178 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-24 21:46:29 +00:00
tfarina@chromium.org
8f6884aab8 Cleanup: Sanitize the order of includes under tests/
Initially this was to make sure Test.h appeared after the Sk*.h includes.

Patch generated by the following command line:

$ ~/chromium/src/tools/sort-headers.py tests/*.cpp

BUG=None
TEST=tests
R=robertphillips@google.com

Review URL: https://codereview.chromium.org/145313004

git-svn-id: http://skia.googlecode.com/svn/trunk@13177 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-24 20:56:26 +00:00
commit-bot@chromium.org
d8ed85101e Turn NVPR on by default (but off in tools).
BUG=skia:2042

Committed: http://code.google.com/p/skia/source/detail?r=13164

R=robertphillips@google.com

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/144003006

git-svn-id: http://skia.googlecode.com/svn/trunk@13176 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-24 20:49:44 +00:00
commit-bot@chromium.org
8f22011449 Add a sample doc in markdown format.
BUG=skia:
R=epoger@google.com, halcanary@google.com, borenet@google.com, jcgregorio@google.com, bungeman@google.com

Author: mtklein@google.com

Review URL: https://codereview.chromium.org/146943002

git-svn-id: http://skia.googlecode.com/svn/trunk@13175 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-24 19:25:39 +00:00
reed@google.com
9ebcac5463 add installPixels
BUG=skia:
R=halcanary@google.com

Review URL: https://codereview.chromium.org/143073008

git-svn-id: http://skia.googlecode.com/svn/trunk@13174 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-24 18:53:42 +00:00
commit-bot@chromium.org
bde4ba2ce6 Revert of Use SkMScalar as intermediates in SkMatrix44::setConcat. (https://codereview.chromium.org/146823002/)
Reason for revert:
This will break many Chromium tests when we roll.

Original issue's description:
> Use SkMScalar as intermediates in SkMatrix44::setConcat.
>
> BUG=skia:
>
> Committed: http://code.google.com/p/skia/source/detail?r=13167

R=reed@google.com
TBR=reed@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Author: mtklein@google.com

Review URL: https://codereview.chromium.org/147033002

git-svn-id: http://skia.googlecode.com/svn/trunk@13173 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-24 18:48:00 +00:00
commit-bot@chromium.org
d1630e8fc0 new tool: download all GM images for a given builder, ready for skdiff
BUG=skia:1919
R=rmistry@google.com, bsalomon@google.com

Author: epoger@google.com

Review URL: https://codereview.chromium.org/143653006

git-svn-id: http://skia.googlecode.com/svn/trunk@13172 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-24 18:34:11 +00:00
commit-bot@chromium.org
227c246731 Resolve a few memory leaks in tests.
Purge the global scaled image cache after use in tests.  The cache was
right to hold on to the pixels indefinitely, but this change makes it
easier to run down actual memory leaks.

Add SK_DECLARE_INST_COUNT to several classes.

BUG=skia:
R=reed@google.com

Author: halcanary@google.com

Review URL: https://codereview.chromium.org/145443004

git-svn-id: http://skia.googlecode.com/svn/trunk@13171 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-24 18:33:07 +00:00
commit-bot@chromium.org
dd10e0ec4c make GM self-test run gm/rebaseline_server unittests
R=borenet@google.com

Author: epoger@google.com

Review URL: https://codereview.chromium.org/143983017

git-svn-id: http://skia.googlecode.com/svn/trunk@13170 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-24 18:28:35 +00:00
halcanary@google.com
68c74884d0 Revert "Turn NVPR on by default (but off in tools)."
This reverts commit 83d81c96de.

Broke Windows build.  Autorevert didn't work.

TBR=bsalomon@google.com,robertphillips@google.com
NOTREECHECKS=true
NOTRY=true
NOPRESUBMIT=true
BUG=skia:2042

Review URL: https://codereview.chromium.org/146863003

git-svn-id: http://skia.googlecode.com/svn/trunk@13169 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-24 16:04:09 +00:00
senorblanco@chromium.org
0ded88d431 [Reland of r13154, since the Housekeeping bot seems to have reverted it in r13155. Next time I'll put the "do not disturb" sign on my commit.]
Refactor SkMorphologyImageFilter, CPU and GPU paths. This required making opts/ dependent on effects/, so that we could use the SkMorphologyProc type in SkMorphologyImageFilter.h.

Correctness and performance covered by existing tests; no change in functionality.

R=bsalomon@google.com, djsollen@google.com, reed@google.com

Committed: https://code.google.com/p/skia/source/detail?r=13154

BUG=skia:

Review URL: https://codereview.chromium.org/135013004

git-svn-id: http://skia.googlecode.com/svn/trunk@13168 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-24 15:43:50 +00:00
commit-bot@chromium.org
94ecb66c49 Use SkMScalar as intermediates in SkMatrix44::setConcat.
BUG=skia:
R=reed@google.com

Author: mtklein@google.com

Review URL: https://codereview.chromium.org/146823002

git-svn-id: http://skia.googlecode.com/svn/trunk@13167 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-24 15:30:46 +00:00
senorblanco@chromium.org
0903c3473c Add new baselines for imagefiltersscaled GM.
TBR=borenet

Review URL: https://codereview.chromium.org/145993005

git-svn-id: http://skia.googlecode.com/svn/trunk@13166 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-24 15:02:11 +00:00
commit-bot@chromium.org
cc40f06db7 Add factory class for generating various flavors of GrTextContext.
This is the first pass of making Gr*TextContext more generic and easily
subclassed. The next stage will be making GrBitmapTextContext and
GrDistanceFieldTextContext more similar by moving the SkDraw loop into
each subclass.

BUG=skia:2018

Committed: http://code.google.com/p/skia/source/detail?r=13142

R=bsalomon@google.com, reed@google.com

Author: jvanverth@google.com

Review URL: https://codereview.chromium.org/144283002

git-svn-id: http://skia.googlecode.com/svn/trunk@13165 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-24 14:38:27 +00:00
commit-bot@chromium.org
83d81c96de Turn NVPR on by default (but off in tools).
BUG=skia:2042
R=robertphillips@google.com

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/144003006

git-svn-id: http://skia.googlecode.com/svn/trunk@13164 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-24 14:38:13 +00:00
commit-bot@chromium.org
1c2f8c2973 modify authors file format to use python fnmatch
BUG=skia:2060
R=rmistry@google.com

Author: hcm@google.com

Review URL: https://codereview.chromium.org/145963002

git-svn-id: http://skia.googlecode.com/svn/trunk@13163 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-24 12:39:25 +00:00
bungeman@google.com
1b532f1231 Rebaselines for r13156.
There seems to be an issue where expectations are missing from storage.
Either they didn't actually upload, we pointed at the wrong one.


git-svn-id: http://skia.googlecode.com/svn/trunk@13162 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-23 23:34:38 +00:00
bungeman@google.com
3bfd12d881 Rebaselines for r13156.
The thing blurred in imageblur is actually text.
Who knew?


git-svn-id: http://skia.googlecode.com/svn/trunk@13161 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-23 23:25:19 +00:00
skia.committer@gmail.com
8f7ed2cfd8 Sanitizing source files in Housekeeper-Nightly
git-svn-id: http://skia.googlecode.com/svn/trunk@13160 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-23 22:26:04 +00:00
bungeman@google.com
5aa1116177 Rebaselines for r13156.
These are for affected baselines which are now failing,
but the expected image appears to be unavailable.


git-svn-id: http://skia.googlecode.com/svn/trunk@13159 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-23 22:24:41 +00:00
bungeman@google.com
5a246719a5 Rebaseline for r13156.
git-svn-id: http://skia.googlecode.com/svn/trunk@13158 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-23 22:19:16 +00:00
tfarina@chromium.org
b2c323a91a Remove unused SampleTests.cpp source file.
We never compile this file.

BUG=None
TEST=tests
R=reed@google.com, robertphillips@google.com

Review URL: https://codereview.chromium.org/143823016

git-svn-id: http://skia.googlecode.com/svn/trunk@13157 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-23 21:30:43 +00:00
bungeman@google.com
f6f56878bc Clarify kAutohinting is kForceAutohinting.
BUG=skia:2047
R=reed@google.com

Review URL: https://codereview.chromium.org/139943004

git-svn-id: http://skia.googlecode.com/svn/trunk@13156 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-23 19:01:36 +00:00
skia.committer@gmail.com
1878a44c74 Sanitizing source files in Housekeeper-Nightly
git-svn-id: http://skia.googlecode.com/svn/trunk@13155 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-23 18:48:56 +00:00
senorblanco@chromium.org
76d4d04b18 Refactor SkMorphologyImageFilter, CPU and GPU paths. This required making opts/ dependent on effects/, so that we could use the SkMorphologyProc type in SkMorphologyImageFilter.h.
Correctness and performance covered by existing tests; no change in functionality.

R=bsalomon@google.com, djsollen@google.com, reed@google.com

Review URL: https://codereview.chromium.org/135013004

git-svn-id: http://skia.googlecode.com/svn/trunk@13154 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-23 18:45:23 +00:00
commit-bot@chromium.org
9e63883725 Add a suppressions file for leak sanitizer.
LeakSanitizer is built into AddressSanitizer, and runs with no extra speed
penalty.  Most interestingly, it's got a lock-free allocator, so it doesn't
bottleneck threaded code.

This file is enough to supress all leak warnings except from the Nvidia driver
on my desktop for tests and dm.  Looks like lsan doesn't or can't pay attention
to leaked globals (-fno-common doesn't affect this).

BUG=skia:
R=robertphillips@google.com

Author: mtklein@google.com

Review URL: https://codereview.chromium.org/145033010

git-svn-id: http://skia.googlecode.com/svn/trunk@13153 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-23 18:42:31 +00:00
commit-bot@chromium.org
94da31dd3b Upstream Android Changes from K release
R=scroggo@google.com

Author: djsollen@google.com

Review URL: https://codereview.chromium.org/145233002

git-svn-id: http://skia.googlecode.com/svn/trunk@13152 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-23 17:21:28 +00:00
commit-bot@chromium.org
6dda827913 add leaks flag to show unref'd insts
Leaks are shown optionally instead of always for tests, gm, and bench.
The current display does not show actual leaks necessarily, but
shows global objects that were not deleted when the test ended.
To enable the end-of-run leak display, pass --leaks or -l.

BUG=skia:
R=mtklein@google.com

Author: caryclark@google.com

Review URL: https://codereview.chromium.org/143943009

git-svn-id: http://skia.googlecode.com/svn/trunk@13151 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-23 17:21:19 +00:00
bungeman@google.com
4732df6941 Basic support for vector FON.
This change gives vector FON fonts slightly better support than bitmap 
FON fonts which we already have some support for. 

This also fixes the calculation of the y component of advances for 
bitmap and vector FON glyphs.



git-svn-id: http://skia.googlecode.com/svn/trunk@13150 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-23 15:22:42 +00:00