Commit Graph

8936 Commits

Author SHA1 Message Date
senorblanco@chromium.org
59cd5ca7cd More morphology GM rebaselines.
TBR=epoger

Review URL: https://codereview.chromium.org/23460047

git-svn-id: http://skia.googlecode.com/svn/trunk@11325 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-09-17 18:07:47 +00:00
bensong@google.com
1dd9194fc2 Splits bench_expectations into per-bot files in preparation for growth.
Next steps are switching bots to using per-bot expectations, and deleting the existing bench_expectations.txt.
Review URL: https://codereview.chromium.org/24075008

git-svn-id: http://skia.googlecode.com/svn/trunk@11323 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-09-17 17:21:02 +00:00
edisonn@google.com
8135323f70 pdf: ifgnore shader colors applied for 0 range.
R=vandebo@chromium.org

Review URL: https://codereview.chromium.org/23654044

git-svn-id: http://skia.googlecode.com/svn/trunk@11322 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-09-17 17:17:47 +00:00
mtklein@google.com
5e5239ed35 switch to a new canvas every once in a while in picture_record_unique
BUG=
R=robertphillips@google.com

Review URL: https://codereview.chromium.org/23995020

git-svn-id: http://skia.googlecode.com/svn/trunk@11321 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-09-17 17:14:25 +00:00
djsollen@google.com
d8807976e7 fix broken build due to coloremoji gm.
- fix SkIntToScalar warnings on windows
 - disable the test on Android until freetype changes are submitted

Review URL: https://codereview.chromium.org/23952005

git-svn-id: http://skia.googlecode.com/svn/trunk@11319 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-09-17 16:17:52 +00:00
djsollen@google.com
6def2a2dc7 Add a test for color bitmap fonts.
This CL also includes a sample font from https://code.google.com/p/color-emoji/

R=reed@google.com

Review URL: https://codereview.chromium.org/24181002

git-svn-id: http://skia.googlecode.com/svn/trunk@11317 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-09-17 15:30:21 +00:00
senorblanco@chromium.org
e1e084f102 Rebaseline morphology GM after https://skia.googlesource.com/skia.git/+/3b64f20423a2bfc454cd569594d78f4169756764
TBR=epoger

Review URL: https://codereview.chromium.org/23600064

git-svn-id: http://skia.googlecode.com/svn/trunk@11315 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-09-17 15:14:46 +00:00
fmalita@google.com
257b8c2646 Rebaseline lumamode GM after dce12a8a79f6094bc17eab15ce4d05ba9c99b814
TBR=robertphillips@google.com

Review URL: https://codereview.chromium.org/23526054

git-svn-id: http://skia.googlecode.com/svn/trunk@11314 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-09-17 14:38:04 +00:00
senorblanco@chromium.org
8fcad98791 Implement crop rect for the dilate and erode (morphology) filters. This provoked some cleanup on the GPU side: apply_morphology() now deals with SkBitmaps, rather than GrTextures. There's still a clear opportunity for more refactoring between the two filters.
Note: this adds some test cases to the morphology GM, so it will require a rebaseline.

R=bsalomon@google.com, reed@google.com

Review URL: https://codereview.chromium.org/23892011

git-svn-id: http://skia.googlecode.com/svn/trunk@11313 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-09-17 13:41:43 +00:00
fmalita@google.com
ef45a646a7 [External patch] Source-over support for SkLumaXfermode.
This is a patch by Andrei Parvu <parvu@adobe.com> (Adobe CLA signer).

Original CL/review: https://codereview.chromium.org/24078006/

GM:lumamode will need rebaselining after landing this.

---

  In order to use CSS luminance masking, we need to be able to create an
  instance of SkLumaXfermode which can receive a kSrcOver mode, and applies
  that mode after converting the source using the luminance-to-alpha
  coefficients.

BUG=289420
R=reed@google.com

Review URL: https://codereview.chromium.org/23710053

git-svn-id: http://skia.googlecode.com/svn/trunk@11312 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-09-17 13:09:16 +00:00
robertphillips@google.com
07f81a57ba Baby step in making SkGpuDevice no longer derive from SkBitmapDevice
https://codereview.chromium.org/23641008/



git-svn-id: http://skia.googlecode.com/svn/trunk@11311 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-09-17 12:26:23 +00:00
mtklein@google.com
6a6c6a16db finish rebaselining?
BUG=

Review URL: https://codereview.chromium.org/23724037

git-svn-id: http://skia.googlecode.com/svn/trunk@11310 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-09-17 11:43:44 +00:00
skia.committer@gmail.com
a604c4f971 Sanitizing source files in Housekeeper-Nightly
git-svn-id: http://skia.googlecode.com/svn/trunk@11309 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-09-17 07:01:20 +00:00
mtklein@google.com
f5b7f0b981 rebaseline some more: imageblur, imagemagnification, and yet more gradient_radial2
BUG=

Review URL: https://codereview.chromium.org/23686019

git-svn-id: http://skia.googlecode.com/svn/trunk@11308 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-09-16 21:33:10 +00:00
mtklein@google.com
62b50b7bb8 Have GMs read the GrContext via a setter/getter rather than a global.
GetGr's current global state makes things rather tricky to run GPU GMs in
parallel (DM).  This API change will let me feed the right GrContext to the
right GM in DM.

I'm not planning on changing the status quo in GM-the-tool: the new getters and
setters still just return the same global.

BUG=skia:1590
R=bsalomon@google.com, robertphillips@google.com

Review URL: https://codereview.chromium.org/23567032

git-svn-id: http://skia.googlecode.com/svn/trunk@11306 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-09-16 20:42:15 +00:00
borenet@google.com
1cf02a8adf Enable msaa4 on Nexus 4 in bench_pictures
R=bsalomon@google.com

Review URL: https://codereview.chromium.org/23496059

git-svn-id: http://skia.googlecode.com/svn/trunk@11305 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-09-16 20:39:23 +00:00
jvanverth@google.com
bbe55fdf66 Have multiple plotmgrs, one for each mask format.
Only flush/purge those strikes that match our format.

R=bsalomon@google.com

Review URL: https://codereview.chromium.org/24047005

git-svn-id: http://skia.googlecode.com/svn/trunk@11303 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-09-16 20:28:37 +00:00
jvanverth@google.com
a2f4b15d4e Don't declare displayCache variable if PROGRAM_CACHE_STATS not defined.
BUG=
R=robertphillips@google.com

Review URL: https://codereview.chromium.org/23757053

git-svn-id: http://skia.googlecode.com/svn/trunk@11301 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-09-16 20:00:46 +00:00
jvanverth@google.com
5c9b6faeff Only display program cache info if RTConf flag is set.
Addresses: https://code.google.com/p/skia/issues/detail?id=1615

R=caryclark@google.com, robertphillips@google.com

Review URL: https://codereview.chromium.org/23947006

git-svn-id: http://skia.googlecode.com/svn/trunk@11300 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-09-16 19:40:31 +00:00
mtklein@google.com
fe66c08c66 rebaselines for imageblur, imagemagnifier, and still some for gradient_radial2
BUG=

Review URL: https://codereview.chromium.org/23710057

git-svn-id: http://skia.googlecode.com/svn/trunk@11299 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-09-16 19:37:25 +00:00
borenet@google.com
4e061d3f15 Allow use of "--config defaults" in bench, like GM
R=mtklein@google.com, scroggo@google.com

Review URL: https://codereview.chromium.org/23855006

git-svn-id: http://skia.googlecode.com/svn/trunk@11298 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-09-16 19:12:19 +00:00
mtklein@google.com
26c6d58274 text size is an SkScalar, Windows reminds me.
BUG=
R=jvanverth@google.com

Review URL: https://codereview.chromium.org/23967014

git-svn-id: http://skia.googlecode.com/svn/trunk@11297 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-09-16 19:05:44 +00:00
mtklein@google.com
cfa7ba7753 srand() + rand() -> SkRandom
rand() makes these two GMs thread-unsafe.  When run concurrently they can
interfere with each other.  Use SkRandom instead to guarantee independence.

BUG=skia:1590
R=jvanverth@google.com

Review URL: https://codereview.chromium.org/24105003

git-svn-id: http://skia.googlecode.com/svn/trunk@11295 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-09-16 18:19:30 +00:00
borenet@google.com
b6e915da2e Add --from-trybot flag in rebaseline.py to enable rebaselining from trybots
(SkipBuildbotRuns)

R=epoger@google.com

Review URL: https://codereview.chromium.org/24153003

git-svn-id: http://skia.googlecode.com/svn/trunk@11294 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-09-16 18:13:13 +00:00
mtklein@google.com
427eb475ef straggler rebaselines for radial_gradient2
BUG=

Review URL: https://codereview.chromium.org/23658058

git-svn-id: http://skia.googlecode.com/svn/trunk@11293 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-09-16 18:12:44 +00:00
scroggo@google.com
9dfac2366d Suppress test output.
This output is for debugging purposes, and does not report an error.

BUG=skia:1616

Review URL: https://codereview.chromium.org/24110003

git-svn-id: http://skia.googlecode.com/svn/trunk@11292 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-09-16 17:36:39 +00:00
caryclark@google.com
570863f2e2 path ops work in progress
path ops work in progress

BUG=

Review URL: https://codereview.chromium.org/21359002

git-svn-id: http://skia.googlecode.com/svn/trunk@11291 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-09-16 15:55:01 +00:00
mtklein@google.com
cf78540576 rebaseline radial_gradient2
BUG=

Review URL: https://codereview.chromium.org/24099003

git-svn-id: http://skia.googlecode.com/svn/trunk@11290 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-09-16 14:55:15 +00:00
robertphillips@google.com
1588354a87 Compiler fix for r11288
git-svn-id: http://skia.googlecode.com/svn/trunk@11289 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-09-16 14:42:48 +00:00
robertphillips@google.com
24ddde9758 Revert 11247, 11250, 11251, 11257, and 11279 to unblock DEPS roll (https://codereview.chromium.org/24159002/)
11279 Sanitizing source files in Housekeeper-Nightly - https://code.google.com/p/skia/source/detail?r=11279
11257 Canary build fix - https://codereview.chromium.org/23532068
11251 More warnings as errors fixes - https://code.google.com/p/skia/source/detail?r=11251
11250 Warnings as errors fix - https://code.google.com/p/skia/source/detail?r=11250
11247 Initial error handling code - https://chromiumcodereview.appspot.com/23021015



git-svn-id: http://skia.googlecode.com/svn/trunk@11288 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-09-16 14:04:05 +00:00
robertphillips@google.com
ba6e954140 Revert the revert of 11247, 11250, 11251 and 11279 (Chrome already relies on changes in r11247)
git-svn-id: http://skia.googlecode.com/svn/trunk@11287 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-09-16 13:40:12 +00:00
robertphillips@google.com
478884f7d3 Revert 11247, 11250, 11251 and 11279 to unblock DEPS roll (https://codereview.chromium.org/24159002/)
11279 Sanitizing source files in Housekeeper-Nightly - https://code.google.com/p/skia/source/detail?r=11279
11251 More warnings as errors fixes - https://code.google.com/p/skia/source/detail?r=11251
11250 Warnings as errors fix - https://code.google.com/p/skia/source/detail?r=11250
11247 Initial error handling code - https://chromiumcodereview.appspot.com/23021015



git-svn-id: http://skia.googlecode.com/svn/trunk@11285 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-09-16 13:19:11 +00:00
mtklein@google.com
3ef7eeac9a Split radial_gradients2 GM into two to reproduce its bug.
Android HW rendering seems to be taking the premul-first path, while
Skia takes the interpolate-first path (both SW and HW).

BUG=
R=reed@google.com

Review URL: https://codereview.chromium.org/23637008

git-svn-id: http://skia.googlecode.com/svn/trunk@11284 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-09-16 13:02:52 +00:00
skia.committer@gmail.com
469fec8fee Sanitizing source files in Housekeeper-Nightly
git-svn-id: http://skia.googlecode.com/svn/trunk@11282 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-09-15 07:01:33 +00:00
epoger@google.com
cd7838d3cb Fix mimetype on expectations live-viewer
(SkipBuildbotRuns)



git-svn-id: http://skia.googlecode.com/svn/trunk@11281 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-09-15 02:22:05 +00:00
epoger@google.com
7687a83272 Add live Javascript viewer for GM expectations
BUG=skia:1599

This is similar to the live viewer for GM actuals, at
https://skia-autogen.googlecode.com/svn/gm-actual/view.html

It will be the basis for GM expectations analysis as described in bug 1599.

R=rmistry@google.com

Review URL: https://codereview.chromium.org/23493024

git-svn-id: http://skia.googlecode.com/svn/trunk@11280 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-09-15 02:18:07 +00:00
skia.committer@gmail.com
dc9888c409 Sanitizing source files in Housekeeper-Nightly
git-svn-id: http://skia.googlecode.com/svn/trunk@11279 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-09-14 07:01:34 +00:00
epoger@google.com
6a1f89717c Rebaseline single GM test: Test-Mac10.6-MacMini4.1-GeForce320M-x86-Release__gradients_local_perspective_pdf-poppler
See http://c128.i.corp.google.com/skia/pixeldiffs/gradients_local_perspective/diffs/

TBR=bsalomon

Review URL: https://codereview.chromium.org/23457009

git-svn-id: http://skia.googlecode.com/svn/trunk@11278 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-09-13 21:15:17 +00:00
epoger@google.com
be4ec742e8 Rebaseline known-bad hairline-gpu GM test on ASAN
Marked as unreviewed and ignore-failure
See http://c128.i.corp.google.com/skia/pixeldiffs/hairmodes/diffs/

TBR=bsalomon

Review URL: https://codereview.chromium.org/23619053

git-svn-id: http://skia.googlecode.com/svn/trunk@11277 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-09-13 21:06:00 +00:00
epoger@google.com
7251743209 Rebaseline GM tests for Test-Mac10.6-MacMini4.1-GeForce320M-x86_64-Release
See http://c128.i.corp.google.com/skia/pixeldiffs/Test-Mac10.6-MacMini4.1-GeForce320M-x86_64-Release/diffs/

TBR=bsalomon

Review URL: https://codereview.chromium.org/24078010

git-svn-id: http://skia.googlecode.com/svn/trunk@11276 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-09-13 20:56:54 +00:00
epoger@google.com
7c18494634 Rebaseline known-bad scaled_tilemodes tests on GalaxyNexus
TBR=bsalomon

Review URL: https://codereview.chromium.org/24038005

git-svn-id: http://skia.googlecode.com/svn/trunk@11275 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-09-13 20:50:33 +00:00
epoger@google.com
f7d859aebd Rebaseline scaled_tilemode_gradient GM tests
See http://c128.i.corp.google.com/skia/pixeldiffs/scaled_tilemode_gradient/diffs/

Review URL: https://codereview.chromium.org/23661006

git-svn-id: http://skia.googlecode.com/svn/trunk@11273 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-09-13 20:41:16 +00:00
mtklein@google.com
9ef1d21dc8 OK windows, please take my infinity.
BUG=

Review URL: https://codereview.chromium.org/23526045

git-svn-id: http://skia.googlecode.com/svn/trunk@11272 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-09-13 20:39:50 +00:00
epoger@google.com
7e72693a6d Rebaseline "lighting" GM tests
See diffs at http://c128.i.corp.google.com/skia/pixeldiffs/lighting/diffs/

TBR=bsalomon

Review URL: https://codereview.chromium.org/23441069

git-svn-id: http://skia.googlecode.com/svn/trunk@11271 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-09-13 20:36:24 +00:00
rmistry@google.com
91042c26ca Whitespace change to test commits.
(SkipBuildbotRuns)

Review URL: https://codereview.chromium.org/23522045

git-svn-id: http://skia.googlecode.com/svn/trunk@11269 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-09-13 20:29:55 +00:00
mtklein@google.com
dbd41c8857 It looks like we're not always running long enough to give the GPU counters time to converge (and possibly the same for CPU too, but GPU is definitely worse off).
This CL changes our convergence logic from
  - did the last run take more than x milliseconds?
to
  - did the last run take more x milliseconds and are the last two runs within y% of each other?

There's also now an upper limit where we bail out with an error if we haven't yet met the convergence criteria.  Keeping the lower bound is important for benches where the constant overhead is much larger than the work done in the loop; without it we'll see T(1 loop) == T(2 loops) and converge way too early.

This CL also exposed that DeferredCanvasBench had a bug: it was running N^2 loops when we told it to run N.  (My fault.)

I threw in a couple other linty changes that I'd be happy to split off.

BUG=
R=robertphillips@google.com

Review URL: https://codereview.chromium.org/23536046

git-svn-id: http://skia.googlecode.com/svn/trunk@11267 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-09-13 20:11:09 +00:00
epoger@google.com
3ad5dd009f Speed up GM ~50% by NOT running most renderModes by default
BUG=skia:1566
R=borenet@google.com, bsalomon@google.com

Review URL: https://codereview.chromium.org/23889030

git-svn-id: http://skia.googlecode.com/svn/trunk@11265 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-09-13 19:56:14 +00:00
mtklein@google.com
410e6e80f0 Refactoring: get rid of the SkBenchmark void* parameter.
While I was doing massive sed-ing, I also converted every bench to use DEF_BENCH instead of registering the ugly manual way.

BUG=
R=scroggo@google.com

Review URL: https://codereview.chromium.org/23876006

git-svn-id: http://skia.googlecode.com/svn/trunk@11263 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-09-13 19:52:27 +00:00
edisonn@google.com
af54a513a5 pdfviewer: do not submit, uploaded for backup, and will be done actually after I refactor the params for functions, to put the char* params in a structure: report errors and warnings in pdf, infrastructure
Review URL: https://codereview.chromium.org/23902018

git-svn-id: http://skia.googlecode.com/svn/trunk@11262 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-09-13 19:33:42 +00:00
mtklein@google.com
1fb04e2540 add a way to get code coverage
BUG=
R=borenet@google.com

Review URL: https://codereview.chromium.org/23523055

git-svn-id: http://skia.googlecode.com/svn/trunk@11261 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-09-13 19:32:43 +00:00