reed
93a1215fe0
SkPaint::FilterLevel -> SkFilterQuality
...
clone (+rebase) of https://codereview.chromium.org/1009183002/
BUG=skia:
TBR=scroggo@google.com
Review URL: https://codereview.chromium.org/1014533004
2015-03-16 10:08:34 -07:00
caryclark
94b4ee85f2
(starting with mtklein's 966503002 mod to 963593003)
...
fix casts
Committed: https://skia.googlesource.com/skia/+/9e73a84deb5e6c201081b1d30175863898543e8d
Review URL: https://codereview.chromium.org/979453004
2015-03-04 12:32:22 -08:00
mtklein
a84cff9b99
Revert of fix casts (patchset #1 id:1 of https://codereview.chromium.org/979453004/ )
...
Reason for revert:
64-bit windows build warnings-as-errors
Original issue's description:
> (starting with mtklein's 966503002 mod to 963593003)
> fix casts
>
> Committed: https://skia.googlesource.com/skia/+/9e73a84deb5e6c201081b1d30175863898543e8d
TBR=caryclark@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/977583007
2015-03-04 11:46:27 -08:00
caryclark
9e73a84deb
(starting with mtklein's 966503002 mod to 963593003)
...
fix casts
Review URL: https://codereview.chromium.org/979453004
2015-03-04 11:22:05 -08:00
caryclark
63c684a8a6
fuzzer fixes
...
Fix path bugs exposed by the path fuzzer.
Changes to existing gm and samplecode files defer their calls to construct
SkPath objects until the first draw instead of at test initialization.
Add an experimental call to SkPath to validate the internal SkPathRef.
Fix SkPath::addPoly to set the last moveto after adding a close verb.
Fix stroke to handle failures when computing the unit normal.
Add a unit test for the unit normal failure.
R=reed@google.com
Review URL: https://codereview.chromium.org/953383002
2015-02-25 09:04:04 -08:00
caryclark
1297ecfd1d
flip stroke to chrome compatible define
...
Review URL: https://codereview.chromium.org/932723003
2015-02-24 06:02:06 -08:00
reed
0ab326f530
move GMSampleView into its own cpp
...
BUG=skia:
TBR=
Review URL: https://codereview.chromium.org/947733002
2015-02-21 09:36:50 -08:00
reed
f7f79d2a6e
remove dead code from sampleapp, trim bad asserts
...
BUG=skia:
TBR=
Review URL: https://codereview.chromium.org/948693002
2015-02-21 09:03:21 -08:00
caryclark
04e4d08556
This uses quad approximations of the outer and inner paths describing a stroke. Cubics and conics' thick strokes are approximated with quads as well.
...
The approximation uses a similar error term as the fill scan converter to determine the number of quads to use.
This also updates SampleApp QuadStroker test with conics, ovals, and stroked text.
Review URL: https://codereview.chromium.org/932113002
2015-02-20 06:33:57 -08:00
joshualitt
25d9c15408
Pass Rendertarget into context.
...
Adding Jim for text context stuff, and Steven for image blur stuff.
BUG=skia:
Review URL: https://codereview.chromium.org/939623005
2015-02-18 12:29:52 -08:00
caryclark
88c748aeea
update sampleapp for stroking experiment
...
Add RotateCircles3 back as better-named QuadStroker.
Switch pathfill test to call skia before draw instead of in
initializer to avoid triggering debugging breakpoints.
Review URL: https://codereview.chromium.org/912273003
2015-02-18 10:56:00 -08:00
reed
9e447c08de
remove unneeded preroll
...
BUG=skia:
TBR=robertphilips
Review URL: https://codereview.chromium.org/927443006
2015-02-15 11:08:40 -08:00
bsalomon
bb0502eec5
Support multiple null GL contexts on a thread.
...
This has the side effect of requiring SkNullGLContext to use the null GL interface.
It exposes SkNullGLContext and also removes null context support from SampleApp.
Review URL: https://codereview.chromium.org/916733002
2015-02-11 11:11:11 -08:00
reed
61adb1b649
more gms for conics
...
BUG=skia:
TBR=
Review URL: https://codereview.chromium.org/869843006
2015-02-09 13:01:05 -08:00
robertphillips
c89f6fb29c
Salvage the SampleApp portion of the ill-fated "nudge" CL
...
Trying a different approach than nudging but this will still be useful.
Review URL: https://codereview.chromium.org/907453004
2015-02-09 07:47:17 -08:00
reed
3cb3840c9a
Rename SkCanvasDrawable to SkDrawable, and make public
...
(patchset #2 id:20001 of https://codereview.chromium.org/903993002/ )"
This reverts commit c4e8772492
.
BUG=skia:
TBR=
NOTREECHECKS=True
Review URL: https://codereview.chromium.org/898343004
2015-02-06 08:36:15 -08:00
reed
c4e8772492
Revert of rename SkCanvasDrawable to SkDrawable, and make public (patchset #2 id:20001 of https://codereview.chromium.org/903993002/ )
...
Reason for revert:
bug in gyp
Original issue's description:
> rename SkCanvasDrawable to SkDrawable, and make public
>
> BUG=skia:
> NOTRY=True
> ... winbuilder flake
>
> Committed: https://skia.googlesource.com/skia/+/4ae9eb7463cf2160723407359608f221c0d5e2a6
TBR=robertphillips@google.com ,djsollen@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/882853006
2015-02-06 08:20:07 -08:00
reed
4ae9eb7463
rename SkCanvasDrawable to SkDrawable, and make public
...
BUG=skia:
NOTRY=True
... winbuilder flake
Review URL: https://codereview.chromium.org/903993002
2015-02-06 08:02:57 -08:00
reed
339cdbfb75
migrate more samples over to SkAnimTImer
...
BUG=skia:
TBR=
Review URL: https://codereview.chromium.org/901933004
2015-02-05 22:02:37 -08:00
reed
bf015c34e4
add textual overview
...
BUG=skia:
Review URL: https://codereview.chromium.org/898573002
2015-02-03 15:02:24 -08:00
reed
76113a9b77
add SkAnimTimer, SPACE = pause/resume, ESP = stop
...
BUG=skia:
Review URL: https://codereview.chromium.org/894083003
2015-02-02 12:55:02 -08:00
reed
d9adfe6a22
allow GMs to animate
...
BUG=skia:
Review URL: https://codereview.chromium.org/888283002
2015-02-01 19:01:04 -08:00
robertphillips
7f14c9bbf1
Revert of Add device space "nudge" to gpu draws (patchset #6 id:90001 of https://codereview.chromium.org/877473005/ )
...
Reason for revert:
Blink layout tests this time :(
Original issue's description:
> Add device space "nudge" to gpu draws
>
> This CL nudges all the GPU draws and clips slightly to match raster's round behavior for BW draws. We assume the effect will be negligible and do it for AA draws too.
>
> BUG=423834
>
> Committed: https://skia.googlesource.com/skia/+/2d55d07501c56310f97d2092d789a2bc9fa01b78
>
> Committed: https://skia.googlesource.com/skia/+/b9329991426d0b77ea194a380d72d73fb855308a
TBR=bsalomon@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=423834
Review URL: https://codereview.chromium.org/886153002
2015-01-30 14:44:22 -08:00
scroggo
e7ea40f4e0
Reland "remove unused SkAvoidXfermode"
...
(patchset #2 id:20001 of https://codereview.chromium.org/860583002/ )
SkAvoidXfermode has been moved into Android, so it is safe to remove.
Review URL: https://codereview.chromium.org/890893003
2015-01-30 13:16:02 -08:00
caryclark
c8fcafb3f0
First cut at cleaning up Sergio's example code and moving some common code to SkWindow.
...
Eventually, this will be moved to be a peer of SampleApp so it is compiled by the bots to avoid future bit rot.
Also ignore XCode auto-generated flag in CommandLineFlags, and remove the unused multiple-example part.
Review URL: https://codereview.chromium.org/890873003
2015-01-30 12:37:02 -08:00
robertphillips
b932999142
Add device space "nudge" to gpu draws
...
This CL nudges all the GPU draws and clips slightly to match raster's round behavior for BW draws. We assume the effect will be negligible and do it for AA draws too.
BUG=423834
Committed: https://skia.googlesource.com/skia/+/2d55d07501c56310f97d2092d789a2bc9fa01b78
Review URL: https://codereview.chromium.org/877473005
2015-01-30 11:24:50 -08:00
humper
f75a130c45
enable subpixel text on the subpixel translate sample
...
BUG=skia:
Review URL: https://codereview.chromium.org/885783006
2015-01-29 10:26:37 -08:00
robertphillips
9cc2f2613a
Revert of Add device space "nudge" to gpu draws (patchset #5 id:70001 of https://codereview.chromium.org/877473005/ )
...
Reason for revert:
Chrome pixel test :(
Original issue's description:
> Add device space "nudge" to gpu draws
>
> This CL nudges all the GPU draws and clips slightly to match raster's round behavior for BW draws. We assume the effect will be negligible and do it for AA draws too.
>
> BUG=423834
>
> Committed: https://skia.googlesource.com/skia/+/2d55d07501c56310f97d2092d789a2bc9fa01b78
TBR=bsalomon@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=423834
Review URL: https://codereview.chromium.org/890433003
2015-01-28 17:37:33 -08:00
robertphillips
2d55d07501
Add device space "nudge" to gpu draws
...
This CL nudges all the GPU draws and clips slightly to match raster's round behavior for BW draws. We assume the effect will be negligible and do it for AA draws too.
BUG=423834
Review URL: https://codereview.chromium.org/877473005
2015-01-28 14:41:57 -08:00
reed
40dab98de1
Use murmur3 finisher to improve font hash efficiency.
...
Add dump() method to inspect glyphcache strikes.
Murmur addition improves hash efficient roughly 50%
BUG=skia:
Review URL: https://codereview.chromium.org/877113002
2015-01-28 13:28:53 -08:00
robertphillips
7defaa6c4a
Add ClipDrawMatch SampleApp slide
...
This slide can be used to find and diagnose discrepancies between BW clipping and drawing.
BUG=skia:423834
Review URL: https://codereview.chromium.org/872363003
2015-01-27 06:17:22 -08:00
halcanary
b0cce2c1d3
s/sk_tools::DrawCheckerboard/sk_tool_utils::draw_checkerboard/
...
BUG=skia:
Review URL: https://codereview.chromium.org/873333004
2015-01-26 12:49:00 -08:00
halcanary
878fa0204b
Factor out checkerboard function in gm and sampleapp into tools.
...
Review URL: https://codereview.chromium.org/834303005
2015-01-26 11:24:32 -08:00
robertphillips
42dbfa8651
Add patheffects to debugger printout
...
TBR=bsalomon@google.com
Review URL: https://codereview.chromium.org/872043002
2015-01-26 06:08:52 -08:00
reed
96a857ef5a
initial preroll api
...
BUG=skia:
Review URL: https://codereview.chromium.org/855473002
2015-01-25 10:33:58 -08:00
fmalita
7a2c8f3f28
Fix SampleApp picture-mode transform.
...
The multi-picture-draw path should not ignore the inherited transform.
R=reed@google.com ,robertphillips@google.com
Review URL: https://codereview.chromium.org/867303002
2015-01-23 10:03:15 -08:00
scroggo
a1193e4b0e
Make SkStream *not* ref counted.
...
SkStream is a stateful object, so it does not make sense for it to have
multiple owners. Make SkStream inherit directly from SkNoncopyable.
Update methods which previously called SkStream::ref() (e.g.
SkImageDecoder::buildTileIndex() and SkFrontBufferedStream::Create(),
which required the existing owners to call SkStream::unref()) to take
ownership of their SkStream parameters and delete when done (including
on failure).
Switch all SkAutoTUnref<SkStream>s to SkAutoTDelete<SkStream>s. In some
cases this means heap allocating streams that were previously stack
allocated.
Respect ownership rules of SkTypeface::CreateFromStream() and
SkImageDecoder::buildTileIndex().
Update the comments for exceptional methods which do not affect the
ownership of their SkStream parameters (e.g.
SkPicture::CreateFromStream() and SkTypeface::Deserialize()) to be
explicit about ownership.
Remove test_stream_life, which tested that buildTileIndex() behaved
correctly when SkStream was a ref counted object. The test does not
make sense now that it is not.
In SkPDFStream, remove the SkMemoryStream member. Instead of using it,
create a new SkMemoryStream to pass to fDataStream (which is now an
SkAutoTDelete).
Make other pdf rasterizers behave like SkPDFDocumentToBitmap.
SkPDFDocumentToBitmap delete the SkStream, so do the same in the
following pdf rasterizers:
SkPopplerRasterizePDF
SkNativeRasterizePDF
SkNoRasterizePDF
Requires a change to Android, which currently treats SkStreams as ref
counted objects.
Review URL: https://codereview.chromium.org/849103004
2015-01-21 12:09:53 -08:00
scroggo
b2b416d384
Revert of remove unused SkAvoidXfermode (patchset #2 id:20001 of https://codereview.chromium.org/860583002/ )
...
Reason for revert:
Breaking Android framework build, which still uses AvoidXfermode. (failure shown here: 565b76b4bd/logs/build_error.log
)
Here is the Java class that uses it: https://cs.corp.google.com/#android/frameworks/base/graphics/java/android/graphics/AvoidXfermode.java&sq=package:android
It has been deprecated. The glue code (which actually references the Skia file) is here: https://cs.corp.google.com/#android/frameworks/base/core/jni/android/graphics/Xfermode.cpp&q=Xfermode.cpp&sq=package:android
Mike suggested we move the implementation into Android, which is fine with me.
Original issue's description:
> remove unused SkAvoidXfermode
>
> BUG=skia:
> TBR=
> NOTRY=True
>
> Committed: https://skia.googlesource.com/skia/+/2d02df7a9a50217dac8c1d11681832a927ed79ce
TBR=bsalomon@google.com ,reed@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/822953003
2015-01-20 06:33:14 -08:00
reed
2d02df7a9a
remove unused SkAvoidXfermode
...
BUG=skia:
TBR=
NOTRY=True
Review URL: https://codereview.chromium.org/860583002
2015-01-18 20:01:30 -08:00
reed
09519db20c
fatbits for all 4 views
...
BUG=skia:
TBR=
Review URL: https://codereview.chromium.org/829043005
2015-01-17 19:36:08 -08:00
reed
afdbedb73c
add sample for filter quality
...
BUG=skia:
TBR=
Review URL: https://codereview.chromium.org/788163007
2015-01-14 13:16:26 -08:00
reed
63121f0db6
delete the dreaded TransitionView
...
BUG=skia:
TBR=
Review URL: https://codereview.chromium.org/850843002
2015-01-13 19:43:04 -08:00
mtklein
72c9faab45
Fix up all the easy virtual ... SK_OVERRIDE cases.
...
This fixes every case where virtual and SK_OVERRIDE were on the same line,
which should be the bulk of cases. We'll have to manually clean up the rest
over time unless I level up in regexes.
for f in (find . -type f); perl -p -i -e 's/virtual (.*)SK_OVERRIDE/\1SK_OVERRIDE/g' $f; end
BUG=skia:
Review URL: https://codereview.chromium.org/806653007
2015-01-09 10:06:40 -08:00
mtklein
703dd2ed18
Remove SkTileGrid (except for TileGridInfo).
...
TBR=reed@google.com
BUG=skia:3085
Review URL: https://codereview.chromium.org/845623002
2015-01-09 06:41:48 -08:00
reed
5965c8ae4e
add ImageGenerator::NewFromData to porting layer
...
BUG=skia:3275
Review URL: https://codereview.chromium.org/834633006
2015-01-07 18:04:45 -08:00
tfarina
aa458fb20a
Cleanup: More override fixes - another round.
...
BUG=skia:3075
TEST=ninja -C out/Debug
TBR=reed@google.com
Review URL: https://codereview.chromium.org/831113002
2015-01-05 17:18:51 -08:00
reed
c4fda92f45
remove unused drawData
...
BUG=skia:
Review URL: https://codereview.chromium.org/830083002
2015-01-02 06:39:51 -08:00
jvanverth
fa1e8a7cef
Add sRGB texture support.
...
Review URL: https://codereview.chromium.org/791823003
2014-12-22 08:31:49 -08:00
reed
8b5752443f
add arcto patheffect
...
BUG=skia:
TBR=
Review URL: https://codereview.chromium.org/813513003
2014-12-17 01:47:32 -08:00
reed
a7a8b10134
add sample for arcTo
...
BUG=skia:
TBR=
Review URL: https://codereview.chromium.org/808793002
2014-12-16 08:07:43 -08:00