bsalomon
72dc51c288
Add support for building GrShape from SkPath and more tests
...
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1922713002
Review URL: https://codereview.chromium.org/1922713002
2016-04-27 06:46:23 -07:00
msarett
92bd2e8f32
Add comments and sanity checks to parsing of ICC headers
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1922073003
Review URL: https://codereview.chromium.org/1922073003
2016-04-27 06:12:26 -07:00
borenet
6f4c1aa8f9
Don't isolate the Skia repo for Swarming compiles
...
BUG=skia:
NOTREECHECKS=true
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1886343002
Review URL: https://codereview.chromium.org/1886343002
2016-04-27 06:06:25 -07:00
brianosman
3ec513632c
Change default window size on Windows.
...
The OS tends to pick a very large size if you let it. Instead, choose a
smaller (fixed) window (matching what we currently use on Linux).
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1919133004
Review URL: https://codereview.chromium.org/1919133004
2016-04-26 16:51:03 -07:00
brianosman
adf4fa6fde
Ensure we're operating on the correct texture when generating mipmaps.
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1915403004
Review URL: https://codereview.chromium.org/1915403004
2016-04-26 16:48:06 -07:00
robertphillips
ed086cae88
Revert of Remove gpu-specialization of SkSpecialImage (patchset #5 id:80001 of https://codereview.chromium.org/1918993002/ )
...
Reason for revert:
N6 bot has gone red
Original issue's description:
> Remove gpu-specialization of SkSpecialImage
>
> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1918993002
>
> Committed: https://skia.googlesource.com/skia/+/0533d6e4142c2787d6d3c325ef0d8d1962292cad
TBR=reed@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/1921393003
2016-04-26 15:02:25 -07:00
brianosman
5529b7dccc
Remove unmatched restore call in gamma GM
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1917303002
Review URL: https://codereview.chromium.org/1917303002
2016-04-26 14:37:27 -07:00
robertphillips
0533d6e414
Remove gpu-specialization of SkSpecialImage
...
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1918993002
Review URL: https://codereview.chromium.org/1918993002
2016-04-26 14:33:36 -07:00
bsalomon
71de3537f6
Don't buffer stdout in DM
...
TBR=egdaniel@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1922223002
Review URL: https://codereview.chromium.org/1922223002
2016-04-26 14:27:21 -07:00
deanm
83496425e3
pathops: Split loop type cubics only when there is a self-intersection.
...
The ComplexBreak code comes from Loop and Blinn, which requires loops to be
split if either double point is visible. However for intersection loops only
need to be split when there is actually a self-intersection (when both double
points are in [0, 1]). This patch splits cubics much less often so the output
doesn't have extra segments unless the input had a self-intersecting loop.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1920663002
Review URL: https://codereview.chromium.org/1920663002
2016-04-26 14:15:21 -07:00
deanm
b77821c30c
pathops: Cosmetic only change, update comments around ComplexBreak().
...
Rename loopT to splitT and make it clearer that it is not just
self intersecting loop cubics that are split.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1921173003
Review URL: https://codereview.chromium.org/1921173003
2016-04-26 14:12:22 -07:00
deanm
12670eb63b
pathops: Add missing header guards in two files.
...
Guards were missing in SkIntersectionHelper.h and
SkPathOpsTSect.h.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1914873002
Review URL: https://codereview.chromium.org/1914873002
2016-04-26 14:09:01 -07:00
msarett
0b55664afc
Update SK_IMAGE_VERSION, run nanobench on its own image set
...
I've added a new directory to the cloud
(gs://chromium-skia-gm/skimage/v4/nanobench) which will
allow us to run dm and nanobench on different sets of
images.
The dm image set will stay the same, and includes
incomplete images, edge cases images, etc.
The nanobench set is much smaller, and includes jpegs and
pngs that we've found useful to bench in the past, plus
a couple of each for the other formats. We can refine
this set as we move forward (and may also want to monitor
these images on perf.skia.org).
For now the goal is to reduce nanobench runtime by not
testing on many, many obscure images that are not
particularly interesting to time.
The actual change to use nanobench images is in:
https://codereview.chromium.org/1917903003/
BUG=skia:5181
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1913813004
Review URL: https://codereview.chromium.org/1913813004
2016-04-26 13:08:57 -07:00
msarett
f3dc188514
Remove redundant tests to make DM a little faster
...
This should help with some of the slow down caused by
https://codereview.chromium.org/1907593004 .
BUG=skia:5181
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1923533002
Review URL: https://codereview.chromium.org/1923533002
2016-04-26 13:06:38 -07:00
msarett
c5db972fce
Remove redundant test
...
FlattenDrawable test now exercises the use of custom unflatten procs.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1917183002
Review URL: https://codereview.chromium.org/1917183002
2016-04-26 12:59:47 -07:00
bsalomon
47cc769118
Add initial implementation of GrShape and GrStyle classes and tests
...
The initial intent is to use GrShape to simplify the mask blur code paths. However, I also want to use this to explore a more unified drawing code flow for different geometry types. The goal is to have a single representation for geometries+styling that attempts to always keep the geometry in the simplest form (e.g. preferring rrects to paths). It also allows for converting styling information into modified geometry and for computing consistent keys.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1822723003
Committed: https://skia.googlesource.com/skia/+/c885dacfe4625af8b0e2e5c6e8a8ae8dc2d620a8
Committed: https://skia.googlesource.com/skia/+/824e58fc6df8fc149d9675f577f7deeaba698b09
Review URL: https://codereview.chromium.org/1822723003
2016-04-26 12:56:00 -07:00
liyuqian
cbaafc34bc
Add runhooks to multi_repo_trybots
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1924573002
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=1924573002
Review URL: https://codereview.chromium.org/1924573002
2016-04-26 12:54:05 -07:00
halcanary
dc09f131d4
pdf comparison tool
...
NOTRY=true
Review URL: https://codereview.chromium.org/1924513002
2016-04-26 12:43:59 -07:00
djsollen
e6e2e54036
Update android docs for how to sync source code
...
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1921023002
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=1921023002
Review URL: https://codereview.chromium.org/1921023002
2016-04-26 12:38:52 -07:00
halcanary
298ab76f1a
bin/fetch-skps: print instruction on error
...
NOTRY=true
Review URL: https://codereview.chromium.org/1919133003
2016-04-26 12:38:47 -07:00
borenet
8ffab6fc0e
Whitespace change to trigger bots after recipe fix
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1922783003
NOTREECHECKS=true
Review URL: https://codereview.chromium.org/1922783003
2016-04-26 12:16:52 -07:00
bsalomon
82ecc5773f
Revert of Add initial implementation of GrShape and GrStyle classes and tests (patchset #11 id:280001 of https://codereview.chromium.org/1822723003/ )
...
Reason for revert:
test failing
Original issue's description:
> Add initial implementation of GrShape and GrStyle classes and tests
>
> The initial intent is to use GrShape to simplify the mask blur code paths. However, I also want to use this to explore a more unified drawing code flow for different geometry types. The goal is to have a single representation for geometries+styling that attempts to always keep the geometry in the simplest form (e.g. preferring rrects to paths). It also allows for converting styling information into modified geometry and for computing consistent keys.
>
> BUG=skia:
> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1822723003
>
> Committed: https://skia.googlesource.com/skia/+/c885dacfe4625af8b0e2e5c6e8a8ae8dc2d620a8
>
> Committed: https://skia.googlesource.com/skia/+/824e58fc6df8fc149d9675f577f7deeaba698b09
TBR=robertphillips@google.com ,egdaniel@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/1919243002
2016-04-26 08:41:47 -07:00
rmistry
cda08f8490
Return error code when get_images_from_skps has failures.
...
BUG=skia:4981
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1916183002
Review URL: https://codereview.chromium.org/1916183002
2016-04-26 08:27:49 -07:00
msarett
002c92bcbf
Do not globally register drawables in test code
...
TBR=reed@google.com
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1922853003
Review URL: https://codereview.chromium.org/1922853003
2016-04-26 08:20:14 -07:00
herb
5d4943caae
Add guards for edge cases.
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1915263002
Review URL: https://codereview.chromium.org/1915263002
2016-04-26 08:15:27 -07:00
egdaniel
b1b59576ba
Remove unnessary uniform barriers in Vulkan.
...
Also added a fix to descriptor set allocation.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1914053004
Review URL: https://codereview.chromium.org/1914053004
2016-04-26 08:15:09 -07:00
jvanverth
6234006727
Add automatic generation of mipmaps to Vulkan
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1916563002
Review URL: https://codereview.chromium.org/1916563002
2016-04-26 08:01:44 -07:00
jvanverth
9d5e47f354
Fix animation with stats in VulkanViewer
...
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1918083003
Review URL: https://codereview.chromium.org/1918083003
2016-04-26 08:01:33 -07:00
reed
86ae3d1614
make context() virtual on device
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1922123002
TBR=robertphilips
Review URL: https://codereview.chromium.org/1922123002
2016-04-26 06:57:31 -07:00
bsalomon
824e58fc6d
Add initial implementation of GrShape and GrStyle classes and tests
...
The initial intent is to use GrShape to simplify the mask blur code paths. However, I also want to use this to explore a more unified drawing code flow for different geometry types. The goal is to have a single representation for geometries+styling that attempts to always keep the geometry in the simplest form (e.g. preferring rrects to paths). It also allows for converting styling information into modified geometry and for computing consistent keys.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1822723003
Committed: https://skia.googlesource.com/skia/+/c885dacfe4625af8b0e2e5c6e8a8ae8dc2d620a8
Review URL: https://codereview.chromium.org/1822723003
2016-04-26 06:53:45 -07:00
robertphillips
83af0a63b1
Revert of Add initial implementation of GrShape and GrStyle classes and tests (patchset #10 id:260001 of https://codereview.chromium.org/1822723003/ )
...
Reason for revert:
From what I can tell, this compiles on 2015 but not 2013.
Original issue's description:
> Add initial implementation of GrShape and GrStyle classes and tests
>
> The initial intent is to use GrShape to simplify the mask blur code paths. However, I also want to use this to explore a more unified drawing code flow for different geometry types. The goal is to have a single representation for geometries+styling that attempts to always keep the geometry in the simplest form (e.g. preferring rrects to paths). It also allows for converting styling information into modified geometry and for computing consistent keys.
>
> BUG=skia:
> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1822723003
>
> Committed: https://skia.googlesource.com/skia/+/c885dacfe4625af8b0e2e5c6e8a8ae8dc2d620a8
TBR=egdaniel@google.com ,bsalomon@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/1918203002
2016-04-26 05:07:23 -07:00
halcanary
ff6596460e
Documentation: FAQ: drop shadow
...
NOTRY=true
DOCS_PREVIEW= https://skia.org/user/tips?cl=1918833003#text-shadow
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1918833003
Review URL: https://codereview.chromium.org/1918833003
2016-04-26 04:49:45 -07:00
bsalomon
c885dacfe4
Add initial implementation of GrShape and GrStyle classes and tests
...
The initial intent is to use GrShape to simplify the mask blur code paths. However, I also want to use this to explore a more unified drawing code flow for different geometry types. The goal is to have a single representation for geometries+styling that attempts to always keep the geometry in the simplest form (e.g. preferring rrects to paths). It also allows for converting styling information into modified geometry and for computing consistent keys.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1822723003
Review URL: https://codereview.chromium.org/1822723003
2016-04-25 13:37:22 -07:00
halcanary
21736bd8b5
bin/sync
...
Review URL: https://codereview.chromium.org/1915223002
2016-04-25 13:34:06 -07:00
liyuqian
8528912215
Improve Android Quick Start Guide
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1919973002
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=1919973002
Review URL: https://codereview.chromium.org/1919973002
2016-04-25 13:15:37 -07:00
halcanary
5c4685e0b0
bin/sync-and-gyp: more dirs to search
...
Review URL: https://codereview.chromium.org/1914993003
2016-04-25 12:39:39 -07:00
robertphillips
c91fd3447e
Add another dollop of sk_sp to SkSpecialImage and SkSpecialSurface
...
This is split out of https://codereview.chromium.org/1914883002/ (Refactor drawContext/RenderTarget creation)
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1913743002
Review URL: https://codereview.chromium.org/1913743002
2016-04-25 12:32:55 -07:00
reed
1eca11659e
share code with drawSpriteWithFilter
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1920733003
Review URL: https://codereview.chromium.org/1920733003
2016-04-25 12:29:38 -07:00
djsollen
460f40507e
Make clang the default Android compiler.
...
BUG=skia:5215
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1919873003
Review URL: https://codereview.chromium.org/1919873003
2016-04-25 11:45:35 -07:00
msarett
68758aed88
Remove SkEncodedInfo kPreSwizzled_Color from public API
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1918943002
Review URL: https://codereview.chromium.org/1918943002
2016-04-25 11:41:15 -07:00
borenet
7bedaf5606
build_command_buffer: Don't 'git checkout' when --no-sync
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1915063002
Review URL: https://codereview.chromium.org/1915063002
2016-04-25 11:22:41 -07:00
rmistry
8d965a612e
Test decoding and output failures to JSON in get_images_from_skps.
...
Testing for decoding was copy pasted from msarett's CL https://codereview.chromium.org/1828323002/
BUG=skia:4981
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1844713003
Review URL: https://codereview.chromium.org/1844713003
2016-04-25 10:35:03 -07:00
halcanary
484b3d0b83
SkDefaultColorProfile: Hide gDefaultProfileIsSRGB
...
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1917443002
Review URL: https://codereview.chromium.org/1917443002
2016-04-25 10:32:23 -07:00
halcanary
1e9030472e
SkMD5: .update() -> .write()
...
Review URL: https://codereview.chromium.org/1913173003
2016-04-25 10:29:36 -07:00
msarett
ac6c75056f
Remove SkEncodedInfo kUnknown_Color and kUnknown_Alpha from public API
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1918873002
Review URL: https://codereview.chromium.org/1918873002
2016-04-25 09:30:24 -07:00
halcanary
d51bdae4e1
SkStringPrintf and SkString::printf now are no longer limted by a static buffer
...
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1403803002
Committed: https://skia.googlesource.com/skia/+/606cadd5aac62299ef2e277709b3684cae2bf96c
Review URL: https://codereview.chromium.org/1403803002
2016-04-25 09:25:35 -07:00
reed
96a04f3299
simplify handle-affine: subclass overrides just describe their leaf behavior
...
added new test case (that would have failed before) of blur with a colorfilter input
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1915943002
Review URL: https://codereview.chromium.org/1915943002
2016-04-25 09:25:15 -07:00
herb
9f666a14a9
Whitespace change.
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1915073002
Review URL: https://codereview.chromium.org/1915073002
2016-04-25 09:05:14 -07:00
stephana
27c565adbe
Whitespace change
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1920893002
TBR=borenet
NOTREECHECKS=true
Review URL: https://codereview.chromium.org/1920893002
2016-04-25 08:35:04 -07:00
benjaminwagner
98ab04012d
Revert of Call SkGraphics::Init() automatically for Google3 processes. (patchset #1 id:1 of https://codereview.chromium.org/1906813002/ )
...
Reason for revert:
Fixed in a different way in internal cl/120632580.
Original issue's description:
> Call SkGraphics::Init() automatically for Google3 processes.
>
> This is logically a partial revert of https://codereview.chromium.org/1903503002 .
>
> BUG=skia:
> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1906813002
>
> Committed: https://skia.googlesource.com/skia/+/868060602975834c33eb33a937545c6af8ac8395
TBR=mtklein@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=skia:
Review URL: https://codereview.chromium.org/1916793002
2016-04-25 07:33:19 -07:00