Commit Graph

7823 Commits

Author SHA1 Message Date
scroggo@google.com
99d43ffcfb Fix for caller of GetTmpDir.
Since I changed GetTmpDir to create an SkString each time, it
needs to be assigned to a variable in order for it to stick around.
Update a test which I missed because my client was out of date.

Review URL: https://codereview.chromium.org/15719006

git-svn-id: http://skia.googlecode.com/svn/trunk@9475 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-06-07 14:30:36 +00:00
scroggo@google.com
cf5eb6ab25 Preparations for running skimage tool on bots.
skimage_main:
Specify the full name of the expectations file to write on the command line,
rather than the folder to write 'results.json'. This is consistent with
writeJsonSummaryPath in GM, as well as the format for reading the file.
Further, it allows more flexibility to name the file.
Do not force opaque when writing bitmaps. skimage does its comparison on
the raw bitmaps. The images are written for visual comparison, and mostly
transparent bitmaps (like resources/plane.png) aren't meaningful when
forced opaque.
Provide an option to to write only mismatches to a directory. Handled
similar to the writePath.
Report a failure if there is no expectations file. This allows writing
to the mismatchPath so we can create an initial baseline.
Pass SkBitmap by const&.

skimage_self_test:
Include the name of the json file in the parameter passed to
createExpectationsPath. The name has been changed to be more specific.

.gitignore:
Ignore the new name of the file created by skimage_self_test.

run.sh:
Run skimage_self_tests.py

BUG=http://code.google.com/p/skia/issues/detail?id=1241
R=epoger@google.com

Review URL: https://codereview.chromium.org/15813016

git-svn-id: http://skia.googlecode.com/svn/trunk@9474 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-06-07 12:43:15 +00:00
scroggo@google.com
e762dad67c Run skimage as part of run.sh
Test skimage to ensure that it does not break.

Split off from https://codereview.chromium.org/15813016/

BUG=http://code.google.com/p/skia/issues/detail?id=1241
R=epoger@google.com

Review URL: https://codereview.chromium.org/15774017

git-svn-id: http://skia.googlecode.com/svn/trunk@9473 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-06-07 12:40:35 +00:00
skia.committer@gmail.com
a009083bd1 Sanitizing source files in Housekeeper-Nightly
git-svn-id: http://skia.googlecode.com/svn/trunk@9471 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-06-07 07:01:06 +00:00
robertphillips@google.com
6ede1fe62b Make SkDrawCommands lighter weight
https://codereview.chromium.org/15907023/



git-svn-id: http://skia.googlecode.com/svn/trunk@9470 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-06-06 23:59:28 +00:00
robertphillips@google.com
7bb28a1679 Disable msaa16 by default
https://codereview.chromium.org/16035011/



git-svn-id: http://skia.googlecode.com/svn/trunk@9469 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-06-06 21:29:39 +00:00
djsollen@google.com
e47e7d17a6 Fix crash when attempting to use a font fallback chain with a custom font.
This is a cherry-pick of a CL that has already been merged into Android.

Review URL: https://codereview.chromium.org/16005011

git-svn-id: http://skia.googlecode.com/svn/trunk@9468 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-06-06 21:25:09 +00:00
bsalomon@google.com
2c84aa3598 separate arrays for color and coverage effects.
R=robertphillips@google.com

Review URL: https://codereview.chromium.org/16180006

git-svn-id: http://skia.googlecode.com/svn/trunk@9465 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-06-06 20:28:57 +00:00
commit-bot@chromium.org
f111851ce4 Add dependency to podofo at skia_ext branch.
R=djsollen@google.com

Author: edisonn@google.com

Review URL: https://chromiumcodereview.appspot.com/16026009

git-svn-id: http://skia.googlecode.com/svn/trunk@9464 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-06-06 18:39:53 +00:00
bsalomon@google.com
bbba784dfb Fix ninja/angle build with new gyp rev.
git-svn-id: http://skia.googlecode.com/svn/trunk@9463 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-06-06 18:34:13 +00:00
bsalomon@google.com
804e9941eb Make GrGLProgram no longer depend on kNumStages
R=robertphillips@google.com

Review URL: https://codereview.chromium.org/16158007

git-svn-id: http://skia.googlecode.com/svn/trunk@9462 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-06-06 18:04:38 +00:00
commit-bot@chromium.org
2497c0f5da Whitespace change to test Commit Queue (SkipBuildbotRuns)
R=borenet@google.com

Author: rmistry@google.com

Review URL: https://chromiumcodereview.appspot.com/16572002

git-svn-id: http://skia.googlecode.com/svn/trunk@9461 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-06-06 18:02:22 +00:00
bungeman@google.com
88605bb51d Fix leak in SkFontHost_fontconfig temporary code.
https://codereview.chromium.org/16525003


git-svn-id: http://skia.googlecode.com/svn/trunk@9460 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-06-06 17:25:42 +00:00
epoger@google.com
19e80c16a5 rebaseline.py self-tests: split test inputs and outputs into completely separate directories
Review URL: https://codereview.chromium.org/16557002

git-svn-id: http://skia.googlecode.com/svn/trunk@9459 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-06-06 15:11:11 +00:00
scroggo@google.com
c76218d5ed Fix bug in setting directories for tests.
make_canonical_dir_path only worked if the provided directory
did not end with a slash. Remove this function, and call
SkPathJoin instead. Update the documentation to acknowledge
that this is an acceptable use of SkPathJoin, and update its
test.

R=epoger@google.com

Review URL: https://codereview.chromium.org/16098011

git-svn-id: http://skia.googlecode.com/svn/trunk@9458 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-06-06 14:59:56 +00:00
reed@google.com
7d05ac9508 if you use --picture in SampleApp, make that sample come up first
git-svn-id: http://skia.googlecode.com/svn/trunk@9455 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-06-06 13:14:13 +00:00
borenet@google.com
fb62522960 Whitespace change to verify builds after r9453
Review URL: https://codereview.chromium.org/15894037

git-svn-id: http://skia.googlecode.com/svn/trunk@9454 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-06-06 12:02:25 +00:00
skia.committer@gmail.com
c5fd093ae2 Sanitizing source files in Housekeeper-Nightly
git-svn-id: http://skia.googlecode.com/svn/trunk@9452 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-06-06 07:01:37 +00:00
commit-bot@chromium.org
a15f7e5b96 Use all available texture units.
R=robertphillips@google.com, jvanverth@google.com

Author: bsalomon@google.com

Review URL: https://chromiumcodereview.appspot.com/16452007

git-svn-id: http://skia.googlecode.com/svn/trunk@9451 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-06-05 23:29:25 +00:00
bungeman@google.com
f51e125b94 Update gyp from 1563 to 1643 (take two).
Re-land 9445 (reverted 9448), but add back the libs no longer provided by gyp.


git-svn-id: http://skia.googlecode.com/svn/trunk@9450 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-06-05 18:35:22 +00:00
reed@google.com
5a64902ee9 call through to the device from SkDraw
BUG=
R=robertphillips@google.com

Review URL: https://codereview.chromium.org/16378003

git-svn-id: http://skia.googlecode.com/svn/trunk@9449 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-06-05 18:00:30 +00:00
bungeman@google.com
4609b9ca9d Reverting gyp roll in 9445 due to Windows failures.
git-svn-id: http://skia.googlecode.com/svn/trunk@9448 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-06-05 17:32:27 +00:00
epoger@google.com
bf65378266 add more rebaseline test resources (no behavioral changes)
(SkipBuildbotRuns)

Review URL: https://codereview.chromium.org/15774019

git-svn-id: http://skia.googlecode.com/svn/trunk@9446 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-06-05 16:26:23 +00:00
bungeman@google.com
6b98fbb0da Update gyp from 1563 to 1643.
https://codereview.chromium.org/16384005/


git-svn-id: http://skia.googlecode.com/svn/trunk@9445 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-06-05 16:15:15 +00:00
djsollen@google.com
fe26fb6142 add launcher icon for android hello_skia_app
R=zachr@google.com

Review URL: https://codereview.chromium.org/16452005

git-svn-id: http://skia.googlecode.com/svn/trunk@9444 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-06-05 15:44:16 +00:00
epoger@google.com
99ba65a181 rebaseline.py: if --tests is not specified, get test list from actual-results.json
R=scroggo@google.com

Review URL: https://codereview.chromium.org/16093025

git-svn-id: http://skia.googlecode.com/svn/trunk@9443 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-06-05 15:43:37 +00:00
commit-bot@chromium.org
b4a8d97b4c Fixup some conventions in SkTArray and add reset to count method.
R=jvanverth@google.com

Author: bsalomon@google.com

Review URL: https://chromiumcodereview.appspot.com/15949021

git-svn-id: http://skia.googlecode.com/svn/trunk@9442 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-06-05 15:40:59 +00:00
djsollen@google.com
4fa748d580 Fix issues related to resolving fonts based on name.
1) non-system font files are not added to the cache.
2) We cache the default fonts for quick lookup.

Review URL: https://codereview.chromium.org/16439004

git-svn-id: http://skia.googlecode.com/svn/trunk@9441 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-06-05 14:20:25 +00:00
skia.committer@gmail.com
8f6ef4010f Sanitizing source files in Housekeeper-Nightly
git-svn-id: http://skia.googlecode.com/svn/trunk@9440 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-06-05 07:01:06 +00:00
commit-bot@chromium.org
4a3ca94322 Update debugger for addition of Conic path verb
R=reed@google.com, djsollen@google.com

Author: robertphillips@google.com

Review URL: https://chromiumcodereview.appspot.com/16224008

git-svn-id: http://skia.googlecode.com/svn/trunk@9438 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-06-04 21:51:06 +00:00
commit-bot@chromium.org
ecaa59d878 create simple skia app for android using jni
R=djsollen@google.com

Author: zachr@google.com

Review URL: https://chromiumcodereview.appspot.com/16336004

git-svn-id: http://skia.googlecode.com/svn/trunk@9437 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-06-04 21:13:11 +00:00
reed@google.com
8cb1088034 change impl to explicitly store length as u32, rather than size_t, so we keep a packed struct on 64bit machines
BUG=

Review URL: https://codereview.chromium.org/16356006

git-svn-id: http://skia.googlecode.com/svn/trunk@9436 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-06-04 20:36:52 +00:00
caryclark@google.com
20d5461df7 path ops -- try to fix build again
Review URL: https://codereview.chromium.org/15994019

git-svn-id: http://skia.googlecode.com/svn/trunk@9434 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-06-04 18:30:02 +00:00
caryclark@google.com
4b66f367b4 path ops work in progress
do not check in

Review URL: https://codereview.chromium.org/14865019

git-svn-id: http://skia.googlecode.com/svn/trunk@9433 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-06-04 18:14:11 +00:00
caryclark@google.com
cffbcc3b96 path ops -- rewrite angle sort
This is a major change resulting from a minor
tweak. In the old code, the intersection point
of two curves was shared between them, but the
intersection points and end points of sorted edges was
computed directly from the intersection T value.

In this CL, both intersection points and sorted points
are the same, and intermediate control points are computed
to preserve their slope.

The sort itself has been completely rewritten to be more
robust and remove 'magic' checks, conditions that empirically
worked but couldn't be rationalized.

This CL was triggered by errors generated computing the clips
of SKP files. At this point, all 73M standard tests work and
at least the first troublesome SKPs work.

Review URL: https://codereview.chromium.org/15338003

git-svn-id: http://skia.googlecode.com/svn/trunk@9432 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-06-04 17:59:42 +00:00
epoger@google.com
4075fd4851 gm_json.py: add ability to load JSON file from a string, not just a local file
This will make it easier to read JSON files from new sources (HTTP, etc.)

R=scroggo@google.com

Review URL: https://codereview.chromium.org/15934018

git-svn-id: http://skia.googlecode.com/svn/trunk@9431 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-06-04 17:50:36 +00:00
bungeman@google.com
a9133bbcc6 Fix hinting menu in SampleApp.
git-svn-id: http://skia.googlecode.com/svn/trunk@9430 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-06-04 17:49:20 +00:00
reed@google.com
ed43dffbf1 add size limit for using glyphcache. above that, draw using paths
BUG=
R=bungeman@google.com

Review URL: https://codereview.chromium.org/16336024

git-svn-id: http://skia.googlecode.com/svn/trunk@9429 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-06-04 16:56:27 +00:00
epoger@google.com
db29a310f7 rebaseline.py : add self-tests
R=senorblanco@chromium.org

Review URL: https://codereview.chromium.org/15660014

git-svn-id: http://skia.googlecode.com/svn/trunk@9426 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-06-04 14:58:47 +00:00
skia.committer@gmail.com
11f2b44450 Sanitizing source files in Housekeeper-Nightly
git-svn-id: http://skia.googlecode.com/svn/trunk@9423 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-06-04 07:00:53 +00:00
bungeman@google.com
055aa52b2d Fix signed/unsigned comparison warning as error from r9421.
git-svn-id: http://skia.googlecode.com/svn/trunk@9422 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-06-03 21:35:03 +00:00
bungeman@google.com
96aabc8508 Fix hinting and add subpixel to SampleApp.
This change allows users of SampleApp to cycle through all of the hinting modes
(using the 'h' key) and also toggle subpixel positioning on the paint (using
the 's' key). Because 'up' and 'down' have replaced its functionality,
'scale', the exising user of 's', is removed.


git-svn-id: http://skia.googlecode.com/svn/trunk@9421 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-06-03 21:26:34 +00:00
commit-bot@chromium.org
1ebc67465d Testing the Commit Queue (SkipBuildbotRuns)
R=borenet@google.com

Author: rmistry@google.com

Review URL: https://chromiumcodereview.appspot.com/16305018

git-svn-id: http://skia.googlecode.com/svn/trunk@9420 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-06-03 20:41:50 +00:00
commit-bot@chromium.org
1308f6e6dd Remove assertion in debug GL impl that stencil buffers are deleted after FBOs to which they are bound.
R=robertphillips@google.com

Author: bsalomon@google.com

Review URL: https://chromiumcodereview.appspot.com/15894024

git-svn-id: http://skia.googlecode.com/svn/trunk@9419 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-06-03 20:09:08 +00:00
commit-bot@chromium.org
e904b45696 Fix leak of effect in SkXfermodeImageFilter::filterImageGPU()
R=senorblanco@chromium.org

Author: bsalomon@google.com

Review URL: https://chromiumcodereview.appspot.com/16305016

git-svn-id: http://skia.googlecode.com/svn/trunk@9418 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-06-03 19:40:17 +00:00
commit-bot@chromium.org
7495f59d39 Don't crash if device creation fails in bench.
R=robertphillips@google.com

Author: bsalomon@google.com

Review URL: https://chromiumcodereview.appspot.com/16256011

git-svn-id: http://skia.googlecode.com/svn/trunk@9417 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-06-03 19:31:07 +00:00
reed@google.com
37ab298bd8 reenable colortype gm
git-svn-id: http://skia.googlecode.com/svn/trunk@9413 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-06-03 17:49:37 +00:00
reed@google.com
13e1540f8c if we can't load Times, use default font
git-svn-id: http://skia.googlecode.com/svn/trunk@9412 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-06-03 17:45:29 +00:00
robertphillips@google.com
59ce1377b1 Fix Win7 warning-as-error complaint
git-svn-id: http://skia.googlecode.com/svn/trunk@9411 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-06-03 17:29:58 +00:00
bungeman@google.com
78aa76c02e Follow on to r9408, implement sk_fileno in SkOSFile_none.cpp.
git-svn-id: http://skia.googlecode.com/svn/trunk@9410 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-06-03 17:20:21 +00:00