Commit Graph

15685 Commits

Author SHA1 Message Date
mtklein
748ca3bf2d Sketch DM refactor.
BUG=skia:3255

I think this supports everything DM used to, but has completely refactored how
it works to fit the design in the bug.

Configs like "tiles-gpu" are automatically wired up.

I wouldn't suggest looking at this as a diff.  There's just a bunch of deleted
files, a few new files, and one new file that shares a name with a deleted file
(DM.cpp).

NOTREECHECKS=true

Committed: https://skia.googlesource.com/skia/+/709d2c3e5062c5b57f91273bfc11a751f5b2bb88

Review URL: https://codereview.chromium.org/788243008
2015-01-15 10:56:12 -08:00
egdaniel
0063a9b69a Move XferEffects class to GrCustomXfermode file
BUG=skia:

Review URL: https://codereview.chromium.org/844913003
2015-01-15 10:52:32 -08:00
fmalita
b0878797b4 SkPictureShader should handle negative scaling gracefully.
Let's not choke on inverted tiles.

BUG=chromium:447707
R=robertphillips@google.com,reed@google.com

Review URL: https://codereview.chromium.org/852213002
2015-01-15 10:45:56 -08:00
mtklein
114c3cd054 Revert of Sketch DM refactor. (patchset #45 id:850001 of https://codereview.chromium.org/788243008/)
Reason for revert:
plenty of data

Original issue's description:
> Sketch DM refactor.
>
> BUG=skia:3255
>
>
> I think this supports everything DM used to, but has completely refactored how
> it works to fit the design in the bug.
>
> Configs like "tiles-gpu" are automatically wired up.
>
> I wouldn't suggest looking at this as a diff.  There's just a bunch of deleted
> files, a few new files, and one new file that shares a name with a deleted file
> (DM.cpp).
>
> NOTREECHECKS=true
>
> Committed: https://skia.googlesource.com/skia/+/709d2c3e5062c5b57f91273bfc11a751f5b2bb88

TBR=bsalomon@google.com,mtklein@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=skia:3255

Review URL: https://codereview.chromium.org/853883004
2015-01-15 10:15:02 -08:00
Mike Klein
c563172f53 more GMs to rebase?
TBR=reed@google.com

BUG=skia:

Review URL: https://codereview.chromium.org/789933003
2015-01-15 12:17:14 -05:00
mtklein
709d2c3e50 Sketch DM refactor.
BUG=skia:3255

I think this supports everything DM used to, but has completely refactored how
it works to fit the design in the bug.

Configs like "tiles-gpu" are automatically wired up.

I wouldn't suggest looking at this as a diff.  There's just a bunch of deleted
files, a few new files, and one new file that shares a name with a deleted file
(DM.cpp).

NOTREECHECKS=true

Review URL: https://codereview.chromium.org/788243008
2015-01-15 08:30:25 -08:00
Mike Klein
8eadff1e8c these GM names are ridiculous
TBR=reed@google.com

BUG=skia:

Review URL: https://codereview.chromium.org/852193003
2015-01-15 11:24:38 -05:00
mtklein
0c278972d0 Why are we afraid of saveLayer() bounds?
They're only hints.  We can ignore them in this optimization.
My only hesitation is that this pattern doesn't seem to happen in our .skps.

BUG=skia:

Review URL: https://codereview.chromium.org/849243002
2015-01-15 08:08:10 -08:00
reed
09544fcf96 choose better mip level
BUG=skia:

Review URL: https://codereview.chromium.org/845793005
2015-01-15 08:01:40 -08:00
skia.buildbots
fc5ad3cd97 Update SKP version
Automatic commit by the RecreateSKPs bot.

TBR=

Review URL: https://codereview.chromium.org/845873005
2015-01-15 07:49:25 -08:00
egdaniel
04ea6344fe Add include before SK_SUPPORT_GPU in SkArithmeticMode_gpu.h to fix android build
BUG=skia:

Review URL: https://codereview.chromium.org/852193002
2015-01-15 07:05:03 -08:00
fmalita
1a178ca6dd Use device-space stroke width for SkDraw::drawRect() quick-reject
The stroke width needs to be CTM-adjusted when applied to device space
rects.

BUG=skia:3313
R=reed@google.com

Review URL: https://codereview.chromium.org/801353008
2015-01-15 06:01:23 -08:00
skia.buildbots
6e87913ab9 Update SKP version
Automatic commit by the RecreateSKPs bot.

TBR=

Review URL: https://codereview.chromium.org/852163002
2015-01-15 05:40:51 -08:00
skia.buildbots
05efbfe39d Update SKP version
Automatic commit by the RecreateSKPs bot.

TBR=

Review URL: https://codereview.chromium.org/855473003
2015-01-14 23:06:12 -08:00
fmalita
8703b539f1 Rebaseline 6 GMs after crrev.com/841763005
BUG=skia:3299
TBR=djsollen@google.com

Review URL: https://codereview.chromium.org/852053004
2015-01-14 18:11:18 -08:00
joshualitt
1ceacff65e a few ignores for nvprmsaa4
TBR=
NOTRY=True
BUG=skia:

Review URL: https://codereview.chromium.org/850143003
2015-01-14 16:05:09 -08:00
Brian Salomon
b31f0fb793 update images after texture cache change
Review URL: https://codereview.chromium.org/852913002
2015-01-14 17:55:18 -05:00
mtklein
b54fe40b07 fMaxTexCoords is unused in Release builds
BUG=skia:

Review URL: https://codereview.chromium.org/853643005
2015-01-14 14:18:54 -08:00
joshualitt
89069a9bdb possible bug fix for nvpr
TBR=bsalomon@google.com
BUG=skia:

Review URL: https://codereview.chromium.org/850953003
2015-01-14 13:51:18 -08:00
reed
afdbedb73c add sample for filter quality
BUG=skia:
TBR=

Review URL: https://codereview.chromium.org/788163007
2015-01-14 13:16:26 -08:00
egdaniel
f351aa3bf1 Add Arithmetic mode xp.
BUG=skia:

Review URL: https://codereview.chromium.org/837633005
2015-01-14 12:53:01 -08:00
reed
26feeba267 separate out the scaline-choosing to simplify chooseProcs
BUG=skia:
TBR=

Review URL: https://codereview.chromium.org/796063007
2015-01-14 12:28:22 -08:00
jcgregorio
bd2059a02a fix link reference in docs
BUG=skia:
NOTRIES=1
TBR=halcanary

Review URL: https://codereview.chromium.org/853703003
2015-01-14 12:03:01 -08:00
jcgregorio
0c2dc21a58 Add reference material for the style of markdown we use.
Preview here: http://skiadocs.com:8000/dev/tools/markdown?cl=853493004

Note that the image won't show up, that's a known issue with the way patching in CLs works.

BUG=skia:

Review URL: https://codereview.chromium.org/853493004
2015-01-14 11:26:30 -08:00
egdaniel
16a04b8414 Move Gpu ArithmeticMode xfer effect to _gpu files.
BUG=skia:

Review URL: https://codereview.chromium.org/827163004
2015-01-14 10:49:18 -08:00
bsalomon
5236cf480d Make uncached textures uncached from the get go.
This avoids the problem of a newly created uncached texture causing a purge of cached resources.

BUG=chromium:445885

Review URL: https://codereview.chromium.org/846303002
2015-01-14 10:42:08 -08:00
robertphillips
028b98a080 Add repro GM for GPU clipped-AA vs. non-AA drawRect discrepancy
In the clip stack we were manually rounding out non-AA clip rects but leaving the hardening of non-AA drawRects up to the GPU. In some border cases the GPU can truncate rather than round out resulting in visual discrepancies.

BUG=423834

Committed: https://skia.googlesource.com/skia/+/933a03fecb65c83f81cf65d5cf9870c69aa379ff

Review URL: https://codereview.chromium.org/839883003
2015-01-14 09:44:02 -08:00
mtklein
7c348a8097 DM can see into src/gpu. No need for relative include.
BUG=skia:

Review URL: https://codereview.chromium.org/853613004
2015-01-14 09:25:01 -08:00
mtklein
2c0e8f13a0 Remove self-assignment in a test.
BUG=skia:

Review URL: https://codereview.chromium.org/853723002
2015-01-14 08:49:10 -08:00
joshualitt
71c9260e6f More changes to bring together path / geo procs
BUG=skia:

Review URL: https://codereview.chromium.org/820783005
2015-01-14 08:12:47 -08:00
robertphillips
95145a9d3e Switch to a more complete method of filtering hoisted layers
Committed: https://skia.googlesource.com/skia/+/74668a8e818fd891a08c4966cc5973b04c1ad992

Review URL: https://codereview.chromium.org/842323003
2015-01-14 08:08:21 -08:00
egdaniel
38cd055215 Do some minor pre cleanup work before converting all xfermodes to XPs.
BUG=skia:

Review URL: https://codereview.chromium.org/853543003
2015-01-14 08:05:11 -08:00
mtklein
b47bba7c77 upstream hooking into google3 crash handler for better stacktraces
BUG=skia:

Review URL: https://codereview.chromium.org/821643006
2015-01-14 06:38:28 -08:00
skia.buildbots
8018e680a4 Update SKP version
Automatic commit by the RecreateSKPs bot.

TBR=

Review URL: https://codereview.chromium.org/812283007
2015-01-14 05:14:15 -08:00
mtklein
3f915c0c9a upstream google3 include paths for jsoncpp
BUG=skia:

No public API changes
TBR=reed@google.com

Review URL: https://codereview.chromium.org/853613002
2015-01-14 05:02:39 -08:00
kkinnunen
26a00de4f3 Remove incremental draw optimization from SkDebugCanvas
The SkDebugCanvas can be (or is currently) being used to draw to multiple
different canvases. If this use-case is intended, then storing draw
-related state in the canvas causes bugs.

Remove incremental draw from SkDebugCanvas. It can only optimize the
case where draw command index is advanced, no other changes are done
and no visualization is used. This case is not that critical, as it
happens only once per new frame at most. It causes bugs, because
one SkDebugCanvas is used to draw to multiple canvases.

Leave the draw to canvas in same state as it was passed in.

This fixes the debugger bugs where:
 * Old, stale image would stay on the raster canvas when a new image is
 loaded. Also happened with resizes.

 * Proper image for overdraw filter would be visible only for the first
   frame

Review URL: https://codereview.chromium.org/844493003
2015-01-13 23:09:19 -08:00
kkinnunen
cfdc0e3fee debugger: SW rasterize the picture only when it changes
Rasterize the picture only when it changes, not every time
raster widget paints itself.

Removes include SkForceLinking.h while organizing the SkDebuggerGUI.cpp
includes.

This is part of the work trying to remove bugs that come from
SkDebugCanvas stateful draw. Part of the state comes from some
optimization that this tries to reproduce in a different way.

Review URL: https://codereview.chromium.org/839743003
2015-01-13 22:49:02 -08:00
reed
63121f0db6 delete the dreaded TransitionView
BUG=skia:
TBR=

Review URL: https://codereview.chromium.org/850843002
2015-01-13 19:43:04 -08:00
joshualitt
812c0283b9 rebase + ignores
NOTRY=True
TBR=
BUG=skia:

Review URL: https://codereview.chromium.org/841873007
2015-01-13 18:54:01 -08:00
joshualitt
9b7eb11253 rebase of expectations
TBR=
NOTRY=True
BUG=skia:

Review URL: https://codereview.chromium.org/847313002
2015-01-13 17:50:27 -08:00
joshualitt
31b52b7c64 fix for winvdows nvpr
TBR=bsalomon@google.com
BUG=skia:

Review URL: https://codereview.chromium.org/804023005
2015-01-13 17:05:03 -08:00
joshualitt
abb52a1a70 Move most of the transform logic into the primitive processors
BUG=skia:

Review URL: https://codereview.chromium.org/822423004
2015-01-13 15:02:10 -08:00
reed
a7f11918d9 rename blitrow::proc and add (uncalled) hook for colorproc16
BUG=skia:3302

Review URL: https://codereview.chromium.org/847443003
2015-01-13 13:51:00 -08:00
mtklein
e55fb177e9 Allow -DGOOGLE3 to bypass our normal platform intrinsic dispatch.
The current code that pound-includes another define doesn't seem to be working there.

BUG=skia:

No API changes.
TBR=reed@google.com

Review URL: https://codereview.chromium.org/820643005
2015-01-13 13:27:26 -08:00
joshualitt
3c1096fc07 fix for FB fetch on nexus 10 ES3.0
BUG=skia:3304

Review URL: https://codereview.chromium.org/807143006
2015-01-13 13:13:59 -08:00
rmistry
bb928a0c0a Add pageset for ugamsolutions.com
BUG=skia:3306
NOTRY=true

Review URL: https://codereview.chromium.org/851743004
2015-01-13 11:52:28 -08:00
robertphillips
5d17286b35 Revert of Switch to a more complete method of filtering hoisted layers (patchset #1 id:1 of https://codereview.chromium.org/842323003/)
Reason for revert:
nanobench woes

Original issue's description:
> Switch to a more complete method of filtering hoisted layers
>
> Committed: https://skia.googlesource.com/skia/+/74668a8e818fd891a08c4966cc5973b04c1ad992

TBR=bsalomon@google.com
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/851773002
2015-01-13 10:54:37 -08:00
mtklein
963b832833 allow simple
BUG=skia:

Review URL: https://codereview.chromium.org/824753006
2015-01-13 10:51:36 -08:00
robertphillips
74668a8e81 Switch to a more complete method of filtering hoisted layers
Review URL: https://codereview.chromium.org/842323003
2015-01-13 10:37:55 -08:00
mtklein
199ba8e19b namespace {} trick for SK_DECLARE_STATIC_ONCE
Like all our other SK_DECLARE_STATIC_*, it's usually not a thread-safe
thing to put inside a function.  Adding namespace {} prevents that
syntactically.

Needs https://codereview.chromium.org/841263004/ to land first.

BUG=chromium:447890

No public API changes.
TBR=reed@google.com

Review URL: https://codereview.chromium.org/806473006
2015-01-13 08:40:23 -08:00