commit-bot@chromium.org
7585479202
Allow SkLazyPixelRef to use SkScaledImageCache
...
- SkScaledImageCache:
- Add new FindAndLock/AddAndLock variants that work well with
SkLazyPixelRefs (take width, height, generation_id).
- Add static versions of these new variants.
- SkLazyPixelRef:
- If NULL passed in as SkImageCache* in the constructor, it will
now default to using the static SkScaledImageCache methods to
cache decoded images.
- If (fImageCache==NULL), the default allocator can be changed
with the setAllocator method. If (fImageCache!=NULL), the
SkImageCache handles allocation.
- CachedDecodingPixelRefTest to test the new functionality.
BUG=
R=scroggo@google.com , mtklein@google.com , reed@google.com
Author: halcanary@google.com
Review URL: https://codereview.chromium.org/37343002
git-svn-id: http://skia.googlecode.com/svn/trunk@12006 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-29 19:55:00 +00:00
commit-bot@chromium.org
f9a2759d94
tests: Provide a default resources path.
...
This is cuts down noise when running from skia/trunk, where this is the right
path to look in.
BUG=
R=epoger@google.com
Author: mtklein@google.com
Review URL: https://codereview.chromium.org/51263002
git-svn-id: http://skia.googlecode.com/svn/trunk@12005 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-29 19:50:39 +00:00
commit-bot@chromium.org
40258a5be9
Fix pipe/annotation.
...
We weren't keeping track of the annotation that's on the other side of the pipe.
BUG=skia:1761
R=scroggo@google.com
Author: mtklein@google.com
Review URL: https://codereview.chromium.org/48273011
git-svn-id: http://skia.googlecode.com/svn/trunk@12004 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-29 19:23:26 +00:00
epoger@google.com
4259ef3dbd
rebaseline_server: replace TODOs section with link to documentation/roadmap
...
(SkipBuildbotRuns)
R=bsalomon@google.com
Review URL: https://codereview.chromium.org/47543008
git-svn-id: http://skia.googlecode.com/svn/trunk@12002 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-29 17:39:09 +00:00
epoger@google.com
f4394d5531
rebaseline_server: allow substring filtering for builder and test
...
If the user clicks on a particular value for one of these fields, that field's
value will go into the filtering box (so you will only see results matching
that field value).
(SkipBuildbotRuns)
R=borenet@google.com
Review URL: https://codereview.chromium.org/47423002
git-svn-id: http://skia.googlecode.com/svn/trunk@12000 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-29 15:49:40 +00:00
commit-bot@chromium.org
602b9608f5
Get rid of two unused variables from the .data section.
...
Before:
$ objdump -x out/Release/libskia_opts.a | grep "\.data" | c++filt
1 .data 00000000 0000000000000000 0000000000000000 000004ec 2**2
0000000000000000 l d .data 0000000000000000 .data
1 .data 00000000 0000000000000000 0000000000000000 00000f58 2**2
0000000000000000 l d .data 0000000000000000 .data
2 .data 00000008 0000000000000000 0000000000000000 00001774 2**2
0000000000000000 l d .data 0000000000000000 .data
0000000000000000 g O .data 0000000000000004 debug_x
0000000000000004 g O .data 0000000000000004 debug_y
1 .data 00000000 0000000000000000 0000000000000000 00001d8c 2**2
0000000000000000 l d .data 0000000000000000 .data
1 .data 00000000 0000000000000000 0000000000000000 00000054 2**2
0000000000000000 l d .data 0000000000000000 .data
1 .data 00000000 0000000000000000 0000000000000000 000001f0 2**2
0000000000000000 l d .data 0000000000000000 .data
1 .data 00000000 0000000000000000 0000000000000000 00000044 2**2
0000000000000000 l d .data 0000000000000000 .data
After:
$ objdump -x out/Release/libskia_opts.a | grep "\.data" | c++filt
1 .data 00000000 0000000000000000 0000000000000000 000004ec 2**2
0000000000000000 l d .data 0000000000000000 .data
1 .data 00000000 0000000000000000 0000000000000000 00000f58 2**2
0000000000000000 l d .data 0000000000000000 .data
2 .data 00000000 0000000000000000 0000000000000000 00001774 2**2
0000000000000000 l d .data 0000000000000000 .data
1 .data 00000000 0000000000000000 0000000000000000 00001d8c 2**2
0000000000000000 l d .data 0000000000000000 .data
1 .data 00000000 0000000000000000 0000000000000000 00000054 2**2
0000000000000000 l d .data 0000000000000000 .data
1 .data 00000000 0000000000000000 0000000000000000 000001f0 2**2
0000000000000000 l d .data 0000000000000000 .data
1 .data 00000000 0000000000000000 0000000000000000 00000044 2**2
0000000000000000 l d .data 0000000000000000 .data
Not sure why clang didn't catch them.
R=mtklein@google.com
BUG=
Author: tfarina@chromium.org
Review URL: https://codereview.chromium.org/50013002
git-svn-id: http://skia.googlecode.com/svn/trunk@11999 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-29 15:32:09 +00:00
commit-bot@chromium.org
0caa68ab2f
DM: add --quiet
...
This has been handy when tossing in other SkDebugf's.
BUG=
R=bsalomon@google.com
Author: mtklein@google.com
Review URL: https://codereview.chromium.org/49323007
git-svn-id: http://skia.googlecode.com/svn/trunk@11998 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-29 15:02:17 +00:00
robertphillips@google.com
9ef0426e7c
Don't reuse scratch textures patch
...
https://codereview.chromium.org/24222004/
git-svn-id: http://skia.googlecode.com/svn/trunk@11997 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-29 14:06:15 +00:00
robertphillips@google.com
0b7ab3bb49
Fix bug in erosion filtering
...
https://codereview.chromium.org/50813002/
git-svn-id: http://skia.googlecode.com/svn/trunk@11996 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-29 13:59:31 +00:00
bsalomon@google.com
bc0dbdc169
svndiff for the windows
...
R=epoger@google.com
Review URL: https://codereview.chromium.org/49323006
git-svn-id: http://skia.googlecode.com/svn/trunk@11995 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-29 13:55:29 +00:00
skia.committer@gmail.com
70402c3168
Sanitizing source files in Housekeeper-Nightly
...
git-svn-id: http://skia.googlecode.com/svn/trunk@11992 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-29 07:01:50 +00:00
commit-bot@chromium.org
8ab77eae2c
Fix narrowing conversion errors from r11986
...
Although this function only gets used for SkMScalar=float, it gets
compiled in when SkMScalar=double.
R=epoger@google.com
BUG=1764
Author: enne@chromium.org
Review URL: https://codereview.chromium.org/49463005
git-svn-id: http://skia.googlecode.com/svn/trunk@11991 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-28 22:05:41 +00:00
commit-bot@chromium.org
ea7e69a52e
A fix for annoying clang error "unused-const-variabl" in third_party code.
...
../../third_party/externals/libwebp/src/enc/quant.c:105:23: error: unused variable 'kCoeffThresh' [-Werror,-Wunused-const-variable]
static const uint16_t kCoeffThresh[16] = {
^
1 error generated.
BUG=None
TEST=build with clang, ninja -C out/Debug most.
R=bsalomon@google.com , epoger@google.com , thakis@chromium.org , mtklein@google.com
Author: tfarina@chromium.org
Review URL: https://codereview.chromium.org/47603012
git-svn-id: http://skia.googlecode.com/svn/trunk@11990 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-28 22:05:12 +00:00
bsalomon@google.com
ef923d4b80
rebase msaa4 tests that haven't run in a long time
...
Review URL: https://codereview.chromium.org/48183006
git-svn-id: http://skia.googlecode.com/svn/trunk@11989 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-28 21:12:50 +00:00
mtklein@google.com
745f248ab1
skip android_paint GM in pipe mode
...
BUG=skia:1763
R=scroggo@google.com
Review URL: https://codereview.chromium.org/48113010
git-svn-id: http://skia.googlecode.com/svn/trunk@11988 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-28 20:40:41 +00:00
epoger@google.com
377ebc5186
gm/internal_links test: add kSkipPipe_Flag until we fix bug 1761
...
BUG=skia:1761
TBR=reed
Review URL: https://codereview.chromium.org/49693004
git-svn-id: http://skia.googlecode.com/svn/trunk@11987 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-28 20:21:12 +00:00
commit-bot@chromium.org
c01ba70afc
Remove float/double conversions from SkMatrix44's map2_pf
...
BUG=chromium:303811
R=reed@google.com
Author: enne@chromium.org
Review URL: https://codereview.chromium.org/37693004
git-svn-id: http://skia.googlecode.com/svn/trunk@11986 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-28 20:20:54 +00:00
commit-bot@chromium.org
2d3a7897e5
DM: add --pipe
...
internal_links is failing across all three versions. One of the rects doesn't draw.
BUG=
R=epoger@google.com
Author: mtklein@google.com
Review URL: https://codereview.chromium.org/47773002
git-svn-id: http://skia.googlecode.com/svn/trunk@11985 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-28 19:51:26 +00:00
epoger@google.com
2701be5a6a
Whitespace change to pick up buildbot change https://code.google.com/p/skia/source/detail?r=11983
...
git-svn-id: http://skia.googlecode.com/svn/trunk@11984 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-28 18:22:19 +00:00
robertphillips@google.com
26e30c5223
Cleanup displacement bench
...
https://codereview.chromium.org/47553005/
git-svn-id: http://skia.googlecode.com/svn/trunk@11982 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-28 18:07:44 +00:00
commit-bot@chromium.org
77e079af1a
Enabling validation code in serialization and adding serialization to fuzzer
...
BUG=
Committed: http://code.google.com/p/skia/source/detail?r=11968
R=reed@google.com , mtklein@google.com , senorblanco@chromium.org , bsalomon@google.com , robertphillips@google.com
Author: sugoi@chromium.org
Review URL: https://codereview.chromium.org/44573002
git-svn-id: http://skia.googlecode.com/svn/trunk@11981 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-28 15:52:02 +00:00
commit-bot@chromium.org
42a895730f
Fix for issue 1728: raster vs. gpu text draws with the wrong color
...
The blend mode for LCD text was not set up correctly when using colors with alpha. This takes the color's alpha value
into account when setting up the blending function.
BUG=Skia:1728
R=bsalomon@google.com
Author: jvanverth@google.com
Review URL: https://codereview.chromium.org/45363002
git-svn-id: http://skia.googlecode.com/svn/trunk@11980 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-28 15:13:50 +00:00
commit-bot@chromium.org
da3d69ce71
Fix broken MSAA for RGBA
...
R=robertphillips@google.com
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/46763003
git-svn-id: http://skia.googlecode.com/svn/trunk@11979 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-28 15:09:13 +00:00
robertphillips@google.com
3721ee652a
Reverting r11968 (Enabling validation code in serialization and adding serialization to fuzzer - https://codereview.chromium.org/44573002 ) due to failure on Chromium AllQuads test.
...
git-svn-id: http://skia.googlecode.com/svn/trunk@11974 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-28 12:08:52 +00:00
commit-bot@chromium.org
b2e9fa5298
Clean up the GrTHashTable API.
...
removeAt() and slowFindIndex() were only used by GrFontCache, and didn't really need to exist: they can be replaced by a simple remove() call. This new code should actually be faster; slowFindIndex() was O(N), and this should be O(lg N).
BUG=
R=bsalomon@google.com , jvanverth@google.com
Author: mtklein@google.com
Review URL: https://codereview.chromium.org/43383006
git-svn-id: http://skia.googlecode.com/svn/trunk@11973 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-27 20:50:23 +00:00
epoger@google.com
92165bc09b
rebaseline_server: tiny fix to un-break UI when ng-repeate (key, value) has duplicate values
...
See https://github.com/angular/angular.js/pull/2505
(SkipBuildbotRuns)
TBR=jcgregorio
Review URL: https://codereview.chromium.org/46063005
git-svn-id: http://skia.googlecode.com/svn/trunk@11972 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-26 15:01:08 +00:00
epoger@google.com
2ce9c215ce
mass-committing another round of GM results, marked as reviewed-by-human=false
...
BUG=skia:1759
TBR=bsalomon
Review URL: https://codereview.chromium.org/46653003
git-svn-id: http://skia.googlecode.com/svn/trunk@11971 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-26 14:44:22 +00:00
epoger@google.com
055e3b5f92
rebaseline_server: UI improvements + set reviewed-by-human on commit
...
- select/clear/toggle all tests
- display "bugs" column
- set reviewed-by-human on commit
- a couple more tiny fixes, TODOs adjusted, etc.
(SkipBuildbotRuns)
R=senorblanco@chromium.org
Review URL: https://codereview.chromium.org/44123004
git-svn-id: http://skia.googlecode.com/svn/trunk@11970 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-26 14:31:11 +00:00
skia.committer@gmail.com
0673efeea2
Sanitizing source files in Housekeeper-Nightly
...
git-svn-id: http://skia.googlecode.com/svn/trunk@11969 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-26 07:01:53 +00:00
commit-bot@chromium.org
d25d6c7b8e
Enabling validation code in serialization and adding serialization to fuzzer
...
BUG=
R=reed@google.com , mtklein@google.com , senorblanco@chromium.org , bsalomon@google.com
Author: sugoi@chromium.org
Review URL: https://codereview.chromium.org/44573002
git-svn-id: http://skia.googlecode.com/svn/trunk@11968 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-25 21:04:40 +00:00
bungeman@google.com
10ba006631
Allow users to build on top of, instead of beneath, SkRefCnt.
...
Alternative to r11811.
The Chromium half of this can be seen at https://codereview.chromium.org/40973002/ .
R=reed@google.com
Review URL: https://codereview.chromium.org/40503002
git-svn-id: http://skia.googlecode.com/svn/trunk@11967 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-25 18:40:24 +00:00
commit-bot@chromium.org
5003bde3f8
Factor out skia_keep_frame_pointer. Handy with perf to get call stacks.
...
Today it's set when we're running a sanitizer, but it's more generally useful. perf record -g (--call-graph) only works for me if we don't omit the frame pointer.
BUG=
R=bungeman@google.com
Author: mtklein@google.com
Review URL: https://codereview.chromium.org/41923004
git-svn-id: http://skia.googlecode.com/svn/trunk@11966 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-25 18:14:54 +00:00
bungeman@google.com
72b8cb2320
onCharsToGlyphs to handle non-bmp on Mac.
...
CTFontGetGlyphsForCharacters is a strange API for non-bmp code points.
R=caryclark@google.com
Review URL: https://codereview.chromium.org/43463005
git-svn-id: http://skia.googlecode.com/svn/trunk@11965 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-25 17:49:08 +00:00
senorblanco@chromium.org
cc17673032
New baselines for imagefiltersgraph GM.
...
TBR=bsalomon@google.com
Review URL: https://codereview.chromium.org/44323002
git-svn-id: http://skia.googlecode.com/svn/trunk@11964 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-25 17:04:56 +00:00
commit-bot@chromium.org
cdd3620ac5
DM: move --match check earlier to fix the "N GMs x M configs" log line.
...
BUG=
R=bsalomon@google.com
Author: mtklein@google.com
Review URL: https://codereview.chromium.org/44443002
git-svn-id: http://skia.googlecode.com/svn/trunk@11963 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-25 15:02:57 +00:00
commit-bot@chromium.org
7edad87cdc
Compute clipped src rect once in tiled bitmap draws
...
R=robertphillips@google.com
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/40403002
git-svn-id: http://skia.googlecode.com/svn/trunk@11962 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-25 14:58:12 +00:00
bungeman@google.com
83ba103ff3
Fix warnings as errors from r11960.
...
git-svn-id: http://skia.googlecode.com/svn/trunk@11961 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-25 13:39:42 +00:00
bungeman@google.com
0fc8f1f822
Disable charsToGlyphs test until Mac can pass.
...
git-svn-id: http://skia.googlecode.com/svn/trunk@11960 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-25 12:32:16 +00:00
skia.committer@gmail.com
7dc4fd0313
Sanitizing source files in Housekeeper-Nightly
...
git-svn-id: http://skia.googlecode.com/svn/trunk@11959 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-25 07:02:14 +00:00
bungeman@google.com
b662e0a33f
Revert unwanted change to verttext.cpp.
...
git-svn-id: http://skia.googlecode.com/svn/trunk@11958 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-24 22:38:48 +00:00
bungeman@google.com
fb1663a0a5
Fix non-bmp in generateCharToGlyph on Mac.
...
git-svn-id: http://skia.googlecode.com/svn/trunk@11957 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-24 22:32:43 +00:00
bungeman@google.com
172c363a68
Add missing braces for r11955.
...
git-svn-id: http://skia.googlecode.com/svn/trunk@11956 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-24 21:50:12 +00:00
bungeman@google.com
3c996f8a15
Implement charToGlyph on remaining ports.
...
R=reed@google.com
Review URL: https://codereview.chromium.org/22859070
git-svn-id: http://skia.googlecode.com/svn/trunk@11955 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-24 21:39:35 +00:00
bsalomon@google.com
edf00c7a59
Reduce bitmap sizes in verylargebitmap GM to not crash on windows
...
R=scroggo@google.com
Review URL: https://codereview.chromium.org/39033005
git-svn-id: http://skia.googlecode.com/svn/trunk@11954 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-24 20:55:14 +00:00
bsalomon@google.com
79bf912051
Rebaseline strokes_round and strokes3 on SGX devices
...
BUG=skia:1752
Review URL: https://codereview.chromium.org/41083003
git-svn-id: http://skia.googlecode.com/svn/trunk@11953 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-24 20:03:27 +00:00
bensong@google.com
4a28f598ec
Changes bench_graph_svg.py test to check_bench_regressions.py test; deletes deprecated chunks in syn_bucket_subdir.
...
Review URL: https://codereview.chromium.org/27377002
git-svn-id: http://skia.googlecode.com/svn/trunk@11952 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-24 18:08:45 +00:00
bsalomon@google.com
af562b437e
Tile large bitmaps that are clipped.
...
R=robertphillips@google.com
Review URL: https://codereview.chromium.org/31033002
git-svn-id: http://skia.googlecode.com/svn/trunk@11951 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-24 17:52:07 +00:00
commit-bot@chromium.org
a34b1f8e0b
DM: print cache stats after every GPU GM when GR_CACHE_STATS is set
...
BUG=
R=bsalomon@google.com
Author: mtklein@google.com
Review URL: https://codereview.chromium.org/39743003
git-svn-id: http://skia.googlecode.com/svn/trunk@11950 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-24 17:44:43 +00:00
commit-bot@chromium.org
50a3043194
We want to give SkPixelRef a way to signal over to GrResourceCache that it's become pointless to keep around textures based on that SkPixelRef when its pixels change, so that it can be a good citizen and free those textures.
...
This adds an invalidation listener mechanism to SkPixelRef to let it send this message while still staying ignorant of who's listening.
These messages are tricky to deliver. The SkPixelRefs they originates from and the GrResourceCaches they ultimately end up at may be on different threads; neither class is threadsafe; their object lifetimes are totally independent; it's a many-senders-to-many-receivers relation; and neither codebase should really know about the other.
So I've added a per-message-type global message bus to broadcast messages to threadsafe inboxes. Anyone can post() a message, which will show up in all the inboxes of that type, read whenever the inbox's owner calls poll(). The implementation is _dumb_; it can be improved in several dimensions (inbox size limits, lock-free message delivery) if we find the need.
I took some care to make sure not to send the invalidation message for any SkPixelRef that's sharing a generation ID with another SkPixelRef.
BUG=
R=bsalomon@google.com , scroggo@google.com , reed@google.com
Author: mtklein@google.com
Review URL: https://codereview.chromium.org/26734003
git-svn-id: http://skia.googlecode.com/svn/trunk@11949 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-24 17:44:27 +00:00
vandebo@chromium.org
81c67001f2
[PDF] Rebaseline mac expectations after fixing image unpremtuliplication in r11945
...
Review URL: https://codereview.chromium.org/40263003
git-svn-id: http://skia.googlecode.com/svn/trunk@11948 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-24 16:40:12 +00:00