caryclark
18bbd00190
don't create zero length intervals
...
Dashing a pattern without zero-length intervals should
not create them if the end of the on interval coincides
with the beginning of the initial dash offset.
R=reed@google.com
BUG=591993
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1766243004
Review URL: https://codereview.chromium.org/1766243004
2016-03-09 05:55:53 -08:00
robertphillips
6ac97b7eb9
Switch SkImageSource image filter over to new onFilterImage interface
...
This CL relies on: https://codereview.chromium.org/1762013002/ (Swap over to using SkImageFilter::filterImage instead of filterImageDeprecated)
TBR=bsalomon@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1772933002
Review URL: https://codereview.chromium.org/1772933002
2016-03-09 05:17:10 -08:00
reed
8a21c9fe7f
use Make instead of Create to return a shared shader
...
Partially updated call sites. Undefine the flag in SkSHader.h to convert the remaining sites.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1772463002
Review URL: https://codereview.chromium.org/1772463002
2016-03-08 18:50:00 -08:00
kulshin
042f859c19
Initialize the font fallback when the direct write font
...
manager is created.
This ensures that the fallback is initialized prior to
sandbox startup in Chromium.
This enables the use of font fallback when combined with
Chromium change https://codereview.chromium.org/1740593002/
Review URL: https://codereview.chromium.org/1740533003
2016-03-08 17:30:05 -08:00
halcanary
8103a34300
SkPDF: Add sk_sp setters; .release() becomes std::move()
...
Note to reviewers: Start with changes to SkPDFTypes.h
Many places that had a bare pointer owning a reference are refactored to
use a sk_sp.
There remain several places where a non-owning pointer `T*` should be
replaced with `const sk_sp<T>&` to eliminate the common pattern
`sk_sp<T>(SkRef(x))`.
Committed: https://skia.googlesource.com/skia/+/9904c9212074279380e21f96575078734dbbd308
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1775043002
Review URL: https://codereview.chromium.org/1775043002
2016-03-08 15:10:16 -08:00
mtklein
c48fc9b1fd
Revert of nanobench: turn on f16 and sRGB on the bots (patchset #1 id:1 of https://codereview.chromium.org/1769163006/ )
...
Reason for revert:
Debug bots failing at
Running writepix_RGBA_UPM f16
../../../src/core/SkBitmap.cpp:558: fatal error: ""false && \"Can't return addr for config\"""
Original issue's description:
> nanobench: turn on f16 and sRGB on the bots
>
> BUG=skia:
> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1769163006
>
> Committed: https://skia.googlesource.com/skia/+/6b5c5cc7b7bdffb4882706b915b544aba8714961
TBR=reed@google.com ,mtklein@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/1780463003
2016-03-08 13:25:42 -08:00
joshualitt
b82f088a11
Fix skiaserve in debug mode
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1774263002
Review URL: https://codereview.chromium.org/1774263002
2016-03-08 13:24:33 -08:00
halcanary
51d04d3c17
Revert of SkPDF: Add sk_sp setters; .release() becomes std::move() (patchset #2 id:20001 of https://codereview.chromium.org/1775043002/ )
...
Reason for revert:
https://build.chromium.org/p/client.skia/builders/Linux%20Builder/builds/6405/steps/compile/logs/stdio
Original issue's description:
> SkPDF: Add sk_sp setters; .release() becomes std::move()
>
> Note to reviewers: Start with changes to SkPDFTypes.h
>
> Many places that had a bare pointer owning a reference are refactored to
> use a sk_sp.
>
> There remain several places where a non-owning pointer `T*` should be
> replaced with `const sk_sp<T>&` to eliminate the common pattern
> `sk_sp<T>(SkRef(x))`.
>
> Committed: https://skia.googlesource.com/skia/+/9904c9212074279380e21f96575078734dbbd308
TBR=bungeman@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/1775143002
2016-03-08 13:03:55 -08:00
reed
647cc84748
Add sk_ref_sp helper function.
...
Review URL: https://codereview.chromium.org/1773943004
2016-03-08 12:54:48 -08:00
halcanary
9904c92120
SkPDF: Add sk_sp setters; .release() becomes std::move()
...
Note to reviewers: Start with changes to SkPDFTypes.h
Many places that had a bare pointer owning a reference are refactored to
use a sk_sp.
There remain several places where a non-owning pointer `T*` should be
replaced with `const sk_sp<T>&` to eliminate the common pattern
`sk_sp<T>(SkRef(x))`.
Review URL: https://codereview.chromium.org/1775043002
2016-03-08 12:38:22 -08:00
mtklein
6b5c5cc7b7
nanobench: turn on f16 and sRGB on the bots
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1769163006
Review URL: https://codereview.chromium.org/1769163006
2016-03-08 12:34:11 -08:00
egdaniel
d5e3b9e1e0
Fill out more information in GrVkCaps
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1768083003
Review URL: https://codereview.chromium.org/1768083003
2016-03-08 12:19:54 -08:00
brianosman
8418aacec6
Remove SkImageGeneratorUtils. None of this code is used.
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1778613002
Review URL: https://codereview.chromium.org/1778613002
2016-03-08 12:15:09 -08:00
jvanverth
910114a350
Buffer fix for VkProgram caching
...
When caching VkPrograms, we can end up with situations where we
overwrite uniform buffers while they're in use (or being prepared for
use) in the command buffer. This fix will address that. This also
addresses the rare but similar case of overwriting vertex or index
buffers when they're in flight.
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1774963003
Review URL: https://codereview.chromium.org/1774963003
2016-03-08 12:09:27 -08:00
robertphillips
40736abf74
Switch SkComposeImageFilter over to new onFilterImage interface
...
This CL depends on https://codereview.chromium.org/1762013002/ (Swap over to using SkImageFilter::filterImage instead of filterImageDeprecated)
TBR=bsalomon@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1768283002
Review URL: https://codereview.chromium.org/1768283002
2016-03-08 12:05:37 -08:00
bsalomon
093779c39a
Expand coverage of vertices gm
...
Review URL: https://codereview.chromium.org/1361173003
2016-03-08 11:53:31 -08:00
yujieqin
412f534563
Update DNG SDK version.
...
* Integrate integer overflow changes from security branch
BUG=b/26535130
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1748363004
Committed: https://skia.googlesource.com/skia/+/be2924ad17d47f4ed49666894d87571a28f89567
Committed: https://skia.googlesource.com/skia/+/62c0f75159674087079140e09ef1396316577754
Review URL: https://codereview.chromium.org/1748363004
2016-03-08 11:47:31 -08:00
mtklein
bb6c41b1db
add f16 and srgb --configs to nanobench
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1775093002
Review URL: https://codereview.chromium.org/1775093002
2016-03-08 11:31:11 -08:00
aleksandar.stojiljkovic
88cb82246a
4377: drawVertices crashes when shader+colorfilter in the paint
...
Fix memory corruption that is result of static_casting SkFilterShaderContext*
to SkTriColorShaderContext* and then changing it's state using setup()
SkTriColorShader and it's Context could be wrapped by Compose, 3DShader and
SkFilterShader, but the link SkTriColorShaderContext -> SkTriColorShader
(fShader) always remain - so this way, data about triangle is propagated.
BUG=4377
Didn't add new unit test - it would be redundant since the GM vertices update here: https://codereview.chromium.org/1361173003/ is covering the bug. With this patch it passes.
Review URL: https://codereview.chromium.org/1431713003
2016-03-08 11:18:22 -08:00
joshualitt
810f77fb9c
Create a small python driver for skiaserve
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1754213005
Review URL: https://codereview.chromium.org/1754213005
2016-03-08 10:56:41 -08:00
robertphillips
ab01ccd278
Rename SkSpecialImage::getBitmap to getBitmapDeprecated
...
Review URL: https://codereview.chromium.org/1780433002
2016-03-08 10:45:32 -08:00
joshualitt
b0666ad3a9
Fix up GrAuditTrail to allow arbitrary reordering
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1765123002
Review URL: https://codereview.chromium.org/1765123002
2016-03-08 10:43:42 -08:00
fmalita
d8a4f77211
Fix 4f gradient swizzle post http://crrev.com/1774523002
...
* store interval colors in pm4f-natural/RGBA order
* swizzle to dst order during interval advance
Also remove an unused Interval ctor.
R=reed@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1770153002
Review URL: https://codereview.chromium.org/1770153002
2016-03-08 10:20:49 -08:00
reed
93bb080503
make pm4f be RGBA always, not pmcolor order
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1774523002
Review URL: https://codereview.chromium.org/1774523002
2016-03-08 10:09:18 -08:00
joshualitt
08e65e718a
Lazy init batch unique ID
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1772023003
Review URL: https://codereview.chromium.org/1772023003
2016-03-08 09:31:15 -08:00
senorblanco
e6eaa320e8
Small GrTessellator refactor and cleanup.
...
Implement a VertexList, and use it.
Rename insert<> -> list_insert<>.
Rename remove<> -> list_remove<>.
Remove some spurious returns.
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1771373002
Review URL: https://codereview.chromium.org/1771373002
2016-03-08 09:06:44 -08:00
reed
aa5e1ae06b
work around leftshift for negative values
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1774963002
Review URL: https://codereview.chromium.org/1774963002
2016-03-08 09:02:24 -08:00
mtklein
c41fd9251d
DM: verbose and quiet logging
...
If you pass no flags, output is pretty much unchanged from today: calls to
info() go to the console, calls to vlog() are ignored.
If you pass --verbose and -w dir, all calls to info(), vlog() and all of stderr
are redirected to dir/verbose.log. info() calls also go to the console,
unless you pass --quiet, in which case nothing goes to the console at all.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1771143002
Review URL: https://codereview.chromium.org/1771143002
2016-03-08 09:01:39 -08:00
robertphillips
c80bf74bcc
Switch SkOffsetImageFilter over to new onFilterImage interface
...
This CL relies on: https://codereview.chromium.org/1762013002/ (Swap over to using SkImageFilter::filterImage instead of filterImageDeprecated)
TBR=bsalomon@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1766743003
Review URL: https://codereview.chromium.org/1766743003
2016-03-08 08:47:23 -08:00
robertphillips
bd590aa658
Fix caching bug in new SkImageFilter::filterImage path
...
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1777573002
Review URL: https://codereview.chromium.org/1777573002
2016-03-08 08:37:18 -08:00
bungeman
c901c11549
Add element_type, swap, operators, fix reset on sk_sp.
...
The 'element_type' typedef is to play nice with std::pointer_traits.
The full complement of operators and swap to match unique_ptr so that
sk_sp can be properly compared to nullptr and used with standard
containers.
Update to 'reset' so that calling 'unref' is the last operation.
This also adds tests for these changes, and sets the fPtr to nullptr
in debug for easier bug finding.
Review URL: https://codereview.chromium.org/1773453002
2016-03-08 08:35:23 -08:00
halcanary
ece8392438
SkPDF: use sk_make_sp<T> when it makes sense.
...
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1773033002
Review URL: https://codereview.chromium.org/1773033002
2016-03-08 08:32:12 -08:00
bsalomon
cdaa97bf66
Circle GP/batch housecleaning
...
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1764923003
Review URL: https://codereview.chromium.org/1764923003
2016-03-08 08:30:15 -08:00
borenet
f2e2a1e290
Swarming bots: fix trybots
...
Requires a recipe-side change as well.
NOTRY=true
BUG=skia:4763
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1768333002
Review URL: https://codereview.chromium.org/1768333002
2016-03-08 05:33:03 -08:00
benjaminwagner
706d21ffd0
Hide new methods from non-Android.
...
Review URL: https://codereview.chromium.org/1769933004
2016-03-07 17:58:03 -08:00
msarett
53add95b2e
Disable color space test for old versions of libpng
...
Should fix the Google3 build.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1769953002
Review URL: https://codereview.chromium.org/1769953002
2016-03-07 17:25:12 -08:00
mtklein
4675220000
Archive SkRemote-related code. I want to start fresh.
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1774013002
Review URL: https://codereview.chromium.org/1774013002
2016-03-07 17:20:26 -08:00
cdalton
8d988b3a73
Add support for 2x2 matrices
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1755483002
Review URL: https://codereview.chromium.org/1755483002
2016-03-07 15:39:09 -08:00
halcanary
48810a0237
SkPDF: s/SkAutoTUnref/sk_sp/g
...
Review URL: https://codereview.chromium.org/1771073002
2016-03-07 14:57:50 -08:00
cdalton
28f45b949a
Add "sample locations" feature to GrProcessor
...
Adds a "sample locations" feature to GrProcessor. When enabled, this
allows a processor to know inside the shader where all the samples are
located. Also adds various infastructure to query, cache, and identify
multisample data.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1717393002
Review URL: https://codereview.chromium.org/1717393002
2016-03-07 13:58:26 -08:00
mtklein
b3b13b7ede
dm: log log
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1771993002
Review URL: https://codereview.chromium.org/1771993002
2016-03-07 13:20:52 -08:00
robertphillips
4418dbac33
Swap over to using SkImageFilter::filterImage instead of filterImageDeprecated
...
This CL relies on https://codereview.chromium.org/1757983002/ (Add SkSpecialImage-based methods to SkImageFilter)
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1762013002
TBR=bsalomon@google.com
Review URL: https://codereview.chromium.org/1762013002
2016-03-07 12:45:14 -08:00
benjaminwagner
19de504eae
Add advance[XY]Fixed getters for Android.
...
This prepares for changing the type of these fields to float.
BUG=skia:4632
Review URL: https://codereview.chromium.org/1772863002
2016-03-07 12:41:49 -08:00
halcanary
d7b2885b90
SkPDF Create working move constructor for inner classes
...
BUG=chromium:592330,chromium:592702
Review URL: https://codereview.chromium.org/1774633002
2016-03-07 12:39:14 -08:00
djsollen
f9deeb66d0
Update android_make to support both --gcc and --clang options.
...
This CL also fixes all the errors that resulted from compiling
with clang and ccache.
BUG=skia:4948
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1774503004
Review URL: https://codereview.chromium.org/1774503004
2016-03-07 12:30:47 -08:00
mtklein
71aca54991
add virtual ~Effect()
...
Today we make an sk_sp<Effect> from an sk_sp<EffectImpl>.
But when the sk_sp<Effect> dies, it calls ~Effect(), not ~EffectImpl().
Making ~Effect() virtual fixes this.
This should make our Google3 tests sized-delete clean, unblocking those folks.
Review URL: https://codereview.chromium.org/1769093002
2016-03-07 12:28:17 -08:00
bsalomon
aecc018f86
Attempt to combine batches in forward direction before flush
...
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1763883005
Review URL: https://codereview.chromium.org/1763883005
2016-03-07 11:50:44 -08:00
mtklein
673748a320
link with -rdynamic on Linux
...
This lets our tools get symbols when they backtrace themselves.
Here's an example improved stack trace.
Notice there are symbols for some Skia methods now.
Stack trace:
out/Release/dm() [0x5ec19b]
out/Release/dm() [0x5ec209]
/lib/x86_64-linux-gnu/libc.so.6(+0x36d40) [0x7f6ae0ce2d40]
/lib/x86_64-linux-gnu/libc.so.6(gsignal+0x39) [0x7f6ae0ce2cc9]
/lib/x86_64-linux-gnu/libc.so.6(abort+0x148) [0x7f6ae0ce60d8]
out/Release/dm() [0xcd19f9]
out/Release/dm() [0x8ca959]
out/Release/dm(_ZN11XfermodesGM16onOnceBeforeDrawEv+0x70) [0x8cb640]
out/Release/dm(_ZN6skiagm2GM4drawEP8SkCanvas+0x1c) [0x5fc81c]
out/Release/dm(_ZNK2DM5GMSrc4drawEP8SkCanvas+0x73) [0x5f3563]
out/Release/dm(_ZNK2DM10RasterSink4drawERKNS_3SrcEP8SkBitmapP9SkWStreamP8SkString+0xcc) [0x5f9eac]
out/Release/dm(_ZN4Task3RunERKS_+0xd5) [0x5f1685]
out/Release/dm() [0xa4d320]
out/Release/dm() [0xcb66ba]
/lib/x86_64-linux-gnu/libpthread.so.0(+0x8182) [0x7f6ae2667182]
/lib/x86_64-linux-gnu/libc.so.6(clone+0x6d) [0x7f6ae0da647d]
Today the same crash looks more like this.
Stack trace:
out/Release/dm() [0x5ec19b]
out/Release/dm() [0x5ec209]
/lib/x86_64-linux-gnu/libc.so.6(+0x36d40) [0x7f6ae0ce2d40]
/lib/x86_64-linux-gnu/libc.so.6(gsignal+0x39) [0x7f6ae0ce2cc9]
/lib/x86_64-linux-gnu/libc.so.6(abort+0x148) [0x7f6ae0ce60d8]
out/Release/dm() [0xcd19f9]
out/Release/dm() [0x8ca959]
out/Release/dm() [0x8cb640]
out/Release/dm() [0x5fc81c]
out/Release/dm() [0x5f3563]
out/Release/dm() [0x5f9eac]
out/Release/dm() [0x5f1685]
out/Release/dm() [0xa4d320]
out/Release/dm() [0xcb66ba]
/lib/x86_64-linux-gnu/libpthread.so.0(+0x8182) [0x7f6ae2667182]
/lib/x86_64-linux-gnu/libc.so.6(clone+0x6d) [0x7f6ae0da647d]
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1774593002
Review URL: https://codereview.chromium.org/1774593002
2016-03-07 11:05:15 -08:00
borenet
d8d046c81f
Swarming bots: add build products whitelist
...
Should reduce output isolate size (and therefore upload time) for
compile task by ~10x
NOTRY=true
BUG=skia:4763
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1768273002
Review URL: https://codereview.chromium.org/1768273002
2016-03-07 10:57:26 -08:00
herb
c60fee0f15
Rework files and add test cases.
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1757193002
Review URL: https://codereview.chromium.org/1757193002
2016-03-07 09:17:47 -08:00