herb
7acc008531
Change to sRGB default for codec generated images.
...
Compared the gm and skps for 8888 and srgb. There are no differences for 8888, there are 100 differences for sRGB, but the 100 look correct compared to the old ones.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1955063002
Review-Url: https://codereview.chromium.org/1955063002
2016-05-16 09:43:54 -07:00
bsalomon
2996553ba2
Make blurcircles2 run as a benchmark.
...
In bench mode it does not draw the comparison paths (or line separators). It also randomly perturbs the blur and circle radii to avoid trivially hitting the same cache entries and each repetition.
BUG=skia:5224
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1985713002
Review-Url: https://codereview.chromium.org/1985713002
2016-05-16 09:36:44 -07:00
msarett
f44b020ecb
Recognize Adobe RGB profiles
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1971203002
Review-Url: https://codereview.chromium.org/1971203002
2016-05-16 09:23:42 -07:00
robertphillips
7761d61876
Rename GrDrawingMgr::abandon to wasAbandoned & add a matching entry point to GrDrawingContext
...
Since GrDrawingContext is generally replacing GrRenderTarget, this is to provide functionality similar to GrRenderTarget::wasDestroyed.
This is split out of https://codereview.chromium.org/1930013002/ ((Mostly) Retract GrRenderTarget from SkGpuDevice)
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1979913002
Review-Url: https://codereview.chromium.org/1979913002
2016-05-16 09:14:53 -07:00
bsalomon
d584d46c99
Run GM benchs in bench mode
...
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1978253002
Review-Url: https://codereview.chromium.org/1978253002
2016-05-16 09:09:18 -07:00
scroggo
12e2f50569
Only run kStripe_Mode on JPEGs
...
It was designed to test code in libjpeg-turbo. Skipping scanlines is
tested more generally in other tests.
BUG=skia:5307
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1978013002
Review-Url: https://codereview.chromium.org/1978013002
2016-05-16 09:04:18 -07:00
scroggo
f8dc9df9ab
Drop AndroidCodecSrc::kDivisor_Mode
...
This is redundant with BRD tests.
BUG=skia:5307
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1976303002
Review-Url: https://codereview.chromium.org/1976303002
2016-05-16 09:04:14 -07:00
robertphillips
c99b8f0351
Retract GrRenderTarget from AlphaClipMask code
...
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1977793004
Committed: https://skia.googlesource.com/skia/+/93bc24e8b09b5ad7498ce9bc9a6519c7a43dbc9d
Review-Url: https://codereview.chromium.org/1977793004
2016-05-15 07:53:35 -07:00
update-skps
9342bd8219
Update SKP version
...
Automatic commit by the RecreateSKPs bot.
TBR=
NO_MERGE_BUILDS
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1979893002
Review-Url: https://codereview.chromium.org/1979893002
2016-05-15 00:41:23 -07:00
bsalomon
c902164c3f
Fix return from nullptr to false in GrVkTexture.cpp
...
TBR=egdaniel@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1978113002
Review-Url: https://codereview.chromium.org/1978113002
2016-05-14 17:55:32 -07:00
bsalomon
c67bb575d0
Add blurcircles2 GM
...
In GM mode this draws an array of circles with different radii and different blur radii. Below each circle an almost-circle path is drawn with the same blur filter for comparison.
In Sample mode this draws a single circle and almost-circle with animating radius and blur radius.
BUG=skia:5224
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1974353003
Review-Url: https://codereview.chromium.org/1974353003
2016-05-13 13:48:48 -07:00
bsalomon
2c0aacbfa4
Revert of Retract GrRenderTarget from AlphaClipMask code (patchset #3 id:40001 of https://codereview.chromium.org/1977793004/ )
...
Reason for revert:
Possible cause of leak in ASAN bot:
https://uberchromegw.corp.google.com/i/client.skia/builders/Test-Ubuntu-GCC-Golo-GPU-GT610-x86_64-Debug-ASAN/builds/3351
Original issue's description:
> Retract GrRenderTarget from AlphaClipMask code
>
> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1977793004
>
> Committed: https://skia.googlesource.com/skia/+/93bc24e8b09b5ad7498ce9bc9a6519c7a43dbc9d
TBR=robertphillips@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review-Url: https://codereview.chromium.org/1975353002
2016-05-13 13:47:04 -07:00
egdaniel
72ac55f8e0
Fix msaa on GrVkRenderTarget
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1977113002
Review-Url: https://codereview.chromium.org/1977113002
2016-05-13 13:43:44 -07:00
robertphillips
93bc24e8b0
Retract GrRenderTarget from AlphaClipMask code
...
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1977793004
Review-Url: https://codereview.chromium.org/1977793004
2016-05-13 11:51:23 -07:00
fmalita
796e365999
SkPictureGpuAnalyzer
...
Stateful helper for gathering multi-picture GPU stats.
Exposes the existing SkPicture GPU veto semantics, while preserving
the SKP impl (which has some nice properties: lazy, hierarchical,
cached per pic).
R=reed@google.com ,bsalomon@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1974833003
Review-Url: https://codereview.chromium.org/1974833003
2016-05-13 11:40:07 -07:00
egdaniel
b2df0c2702
Refactor Vulkan image, texture, RTs so that create and getter handles match.
...
This allows allows us to track and notify clients when either side changes
and image layout.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1974983002
Review-Url: https://codereview.chromium.org/1974983002
2016-05-13 11:30:37 -07:00
cdalton
17bf82052f
Abort stencil draws when the attachment fails
...
BUG=skia:611514
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1971353003
Review-Url: https://codereview.chromium.org/1971353003
2016-05-13 11:27:15 -07:00
robertphillips
e576874b16
Retract GrRenderTarget a bit within SkGpuDevice
...
Split off of: https://codereview.chromium.org/1930013002/ ((Mostly) Retract GrRenderTarget from SkGpuDevice)
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1956473002
Committed: https://skia.googlesource.com/skia/+/d215a95882485026d176a81bf58871276b21c89c
Review-Url: https://codereview.chromium.org/1956473002
2016-05-13 11:20:46 -07:00
cdalton
846c051a48
Convert GrClip to an abstract base class
...
Converts GrClip to an abstract base class and adds a "GrFixedClip"
implementation. GrFixedClip denotes a clip implemented with fixed-
function hardware. GrFixedClip allows us to remove the stateful
"fClipMode" member from GrClipMaskManager, and in the future will
be able to nicely encapsulate window rectangles.
After this change GrClipMaskManager is just a wrapper around
GrDrawTarget. We may want to consider removing it altogether.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1971343002
Review-Url: https://codereview.chromium.org/1971343002
2016-05-13 10:25:00 -07:00
herb
670f01f2fc
This has all the different source types in and working. There are many SkDiffs, but they seem to be due to better resolution.
...
This seems to fix all the bugs involved with make all the images produced by the codec to default to sRGB.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1967283002
Review-Url: https://codereview.chromium.org/1967283002
2016-05-13 10:04:46 -07:00
liyuqian
36632f46a6
Change Android activity title from JNI call
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1978843002
Review-Url: https://codereview.chromium.org/1978843002
2016-05-13 09:57:44 -07:00
bsalomon
9fb420393e
Add bounds to GrShape
...
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1970003003
Review-Url: https://codereview.chromium.org/1970003003
2016-05-13 09:23:38 -07:00
borenet
4ca5539df5
Add isolate_android_sdk.py script and android_sdk_hash
...
BUG=skia:5298
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1975893002
Review-Url: https://codereview.chromium.org/1975893002
2016-05-13 08:41:04 -07:00
msarett
aabe15e206
Simple program for visualizing gamuts
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1972343002
Review-Url: https://codereview.chromium.org/1972343002
2016-05-13 07:32:59 -07:00
scroggo
e6f0d6e5fe
GMs: fail gracefully for null surface
...
A couple more instances where MakeRenderTarget returns nullptr
due to --preAbandonGpuContext.
BUG=skia5282
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1976163002
Review-Url: https://codereview.chromium.org/1976163002
2016-05-13 07:25:44 -07:00
liyuqian
6ce4b003a2
Use title buttons to switch slides
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1975723004
Review-Url: https://codereview.chromium.org/1975723004
2016-05-13 06:45:21 -07:00
msarett
c2e4bb39d4
Recognize more sRGB gammas
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1975883003
Review-Url: https://codereview.chromium.org/1975883003
2016-05-13 06:19:04 -07:00
robertphillips
9837740dd5
Simplify GrSWMaskHelper
...
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1974943002
Review-Url: https://codereview.chromium.org/1974943002
2016-05-13 05:47:23 -07:00
robertphillips
f054b1766b
Swap SkGpuBlurUtils over to using SkIRects
...
We don't have to land this, but I found it more comforting for the blurring code to explicitly deal with SkIRects rather than SkRects with integer values.
Split out of: https://codereview.chromium.org/1959493002/ (Retract GrRenderTarget from SkGpuBlurUtils)
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1968603003
Review-Url: https://codereview.chromium.org/1968603003
2016-05-13 05:06:19 -07:00
cdalton
862cff30ea
Remove clip from GrPipelineBuilder
...
This eliminates a copy and will allow us to make the GrClip class
virutal.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1966903004
Review-Url: https://codereview.chromium.org/1966903004
2016-05-12 15:09:48 -07:00
cdalton
193d9cf8f2
Eliminate special case nvpr batch handling
...
Removes drawPathBatch methods from GrDrawTarget and GrDrawContext, and
integrates nvpr batches in with all the other batches.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1966763002
Review-Url: https://codereview.chromium.org/1966763002
2016-05-12 11:52:02 -07:00
egdaniel
dde2c0356c
Ignore patch version when checking compatibility of vulkan layers
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1970233002
Review-Url: https://codereview.chromium.org/1970233002
2016-05-12 11:42:00 -07:00
herb
15332a841d
Make PixelGetters much smaller, move more common code to PixelAccessor.
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1971863002
Review-Url: https://codereview.chromium.org/1971863002
2016-05-12 11:37:00 -07:00
halcanary
dd4fcd4500
cmake: fixes for windows
...
Review-Url: https://codereview.chromium.org/1975933002
2016-05-12 11:25:01 -07:00
robertphillips
04c84af877
Make SkGpuBlurUtils::GaussianBlur more drawContext centric
...
This is split out of https://codereview.chromium.org/1959493002/ (Retract GrRenderTarget from SkGpuBlurUtils)
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1962903003
Committed: https://skia.googlesource.com/skia/+/e7ef01dcfda0f8ae407ba92cc03cf3f7841ec470
Committed: https://skia.googlesource.com/skia/+/d38d92f9ca6a58ee51461488f0869343cf7ca083
Review-Url: https://codereview.chromium.org/1962903003
2016-05-12 11:13:00 -07:00
brianosman
f05ab1b820
Support allowSRGBInputs on Vulkan (via secondary texture views)
...
All textures still have a "correct" image view that matches their actual
format. For sRGB textures, we can ask for a non-sRGB view that is
created on demand (and cached), in legacy mode.
Finally, turn on sRGB support in Vulkan. The gamma GM now looks correct
in both L32 and S32.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1970293002
Review-Url: https://codereview.chromium.org/1970293002
2016-05-12 11:01:10 -07:00
fmalita
1e2e33a74d
Remove SkPicture::hasText()
...
No longer used in Chromium.
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1978533002
Review-Url: https://codereview.chromium.org/1978533002
2016-05-12 10:53:49 -07:00
bungeman
b11cf50b4a
Fix typo in SkOSWindow_AndroidNative.
...
This allows the 'most' target to be built on Android.
Review-Url: https://codereview.chromium.org/1973043002
2016-05-12 10:48:59 -07:00
robertphillips
3806b8fb7f
Fix bug & add code to catch ImageFilter clearing bugs
...
Follow on to https://codereview.chromium.org/1969193002/ (SkPictureImageFilter - clear local canvas before use)
BUG=610667
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1972213002
Review-Url: https://codereview.chromium.org/1972213002
2016-05-12 10:46:40 -07:00
herb
be463bba2e
Fix bad pixel address calculation.
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1974053002
Review-Url: https://codereview.chromium.org/1974053002
2016-05-12 10:36:24 -07:00
liyuqian
7bde8f813f
Warning instead of exception for cmake
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1971953003
Review-Url: https://codereview.chromium.org/1971953003
2016-05-12 10:21:17 -07:00
halcanary
dd05e2a96e
using_skia_and_harfbuzz: compile w/ Android NDK
...
TBR=djsollen@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1977503002
Review-Url: https://codereview.chromium.org/1977503002
2016-05-12 10:09:58 -07:00
bungeman
13b9c95295
Move SkTypeface to sk_sp.
...
Committed: https://skia.googlesource.com/skia/+/6296da736fbf40aae881650c239420f64e576c3f
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1933393002
Review-Url: https://codereview.chromium.org/1933393002
2016-05-12 10:09:31 -07:00
liyuqian
40d21de8b6
Use swipe gesture to switch between slides on Android
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1965013007
Review-Url: https://codereview.chromium.org/1965013007
2016-05-12 09:17:04 -07:00
ericrk
a31312cddd
SkPictureImageFilter - clear local canvas before use
...
In SkPictureImageFilter::onFilterImage, we may create two new surfaces,
one for our final output, and one for a local resolution intermediate.
We clear the final output surface before use, removing any previous
content, however we do not do the same for the local surface. This can
lead to content being incorrectly layered on top of previous content
when we go down this path.
This change adds logic to clear the local surface as well.
BUG=610667
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1969193002
Review-Url: https://codereview.chromium.org/1969193002
2016-05-12 09:06:44 -07:00
brianosman
97fc9308e3
Fix sRGB textures that must be copied (for NPOT tiling, etc...)
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1969923002
Review-Url: https://codereview.chromium.org/1969923002
2016-05-12 07:53:46 -07:00
caryclark
4cba202b71
fix hairline clip
...
Don't remove inner clip if it's non-rectangular.
Add cubic hairline clip code to quad and conic cases.
R=reed@google.com
BUG=skia:5252
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1943403006
Review-Url: https://codereview.chromium.org/1943403006
2016-05-12 07:07:05 -07:00
scroggo
9a9a7b29e5
Revert of Move SkTypeface to sk_sp. (patchset #5 id:80001 of https://codereview.chromium.org/1933393002/ )
...
Reason for revert:
fontmgr_iterAndroid failing to draw emoji. E.g. https://gold.skia.org/search2?blame=6296da736fbf40aae881650c239420f64e576c3f&unt=true&head=true&query=source_type%3Dgm
Original issue's description:
> Move SkTypeface to sk_sp.
>
> Committed: https://skia.googlesource.com/skia/+/6296da736fbf40aae881650c239420f64e576c3f
TBR=reed@google.com ,fmalita@chromium.org,tomhudson@google.com,bungeman@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review-Url: https://codereview.chromium.org/1974783002
2016-05-12 06:22:30 -07:00
scroggo
a1b283345b
Fail gracefully if MakeRenderTarget fails
...
We recently started passing --preAbandonGpuContext when running DM on
valgrind, resulting in this call returning nullptr. We had not been
checking for it, so we crash. Already fixed one in crrev.com/1959173002,
and now we reach another one.
BUG=skia:5282
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1972933002
Review-Url: https://codereview.chromium.org/1972933002
2016-05-12 06:19:37 -07:00
bsalomon
7c73a53894
Add isEmpty() query to GrShape and improve comments.
...
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1971613004
Review-Url: https://codereview.chromium.org/1971613004
2016-05-11 15:15:56 -07:00