kkinnunen
6438f9aca7
Fix debugger with GL to work with non-default locale
...
QApplication forces the process to use the C locale system on
"Unix/Linux" according to the docs.
The float numbers in GL shaders will be printed with printf. These will
be formatted with comma in certain locales, like LC_NUMERIC=fi_FI.UTF-8.
Force the NC_NUMERIC=C before running the QApplication.
Review URL: https://codereview.chromium.org/724753002
2014-11-13 05:13:50 -08:00
kkinnunen
c092d3bdab
Make nanobench and dm be usable from Chromium build
...
Move the app logic for each app as follows:
<app>.cpp -- the file which contains main(). Embedders that compile
their own apps, such as ios shell, upcoming Chromium dm etc, do not use this.
<app>_main.cpp -- the main logic of the Skia test application. This will be
used by Skia -compiled apps as well as embedder -compiled apps.
<app>_main.h -- the API for the main logic. This will be
used by Skia -compiled apps as well as embedder -compiled apps.
This way (the upcoming) Chromium dm can setup its Chromium-specific setup
in custom main(), and then call dm_main(), without the need of any
SK_BUILD_FOR_XXXX defines controlling whether the tool defines main or not.
BUG=skia:2992
Review URL: https://codereview.chromium.org/657373002
2014-11-13 05:00:57 -08:00
reed
5adbf1b579
Revert of move to modify onCreateDevice virtual (patchset #2 id:20001 of https://codereview.chromium.org/723743002/ )
...
Reason for revert:
mac_chromium_rel_ng unittest failures. speculating caused by this cl.
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/5262
Original issue's description:
> start to replace onCreateDevice with onCreateCompatibleDevice
>
> the new virtual takes a struct which we can amend in the future w/o having to
> update our subclasses in chrome.
>
> BUG=skia:
> NOTRY=True
>
> Committed: https://skia.googlesource.com/skia/+/b122ee50fb56cf6669fe1668b82c8815896e9943
TBR=fmalita@google.com ,fmalita@chromium.org,reed@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/728433002
2014-11-13 03:31:41 -08:00
mtklein
8113dd1369
SkVarAlloc
...
Like SkChunkAlloc, but
- does its allocation with better sympathy for malloc granularity;
- the fast path inlines entirely;
- smaller per-block overhead;
- smaller per-SkVarAlloc overhead;
- growth parameters are a little more tunable.
Its main downside is less flexibility; it supports fewer methods than SkChunkAlloc.
These current parameters bring the first allocation down from 4K to 1K,
without affecting recording time on my desktop. skiaperf.com will tell the
whole story.
BUG=skia:
Review URL: https://codereview.chromium.org/674263002
2014-11-12 15:15:28 -08:00
reed
b122ee50fb
start to replace onCreateDevice with onCreateCompatibleDevice
...
the new virtual takes a struct which we can amend in the future w/o having to
update our subclasses in chrome.
BUG=skia:
NOTRY=True
Review URL: https://codereview.chromium.org/723743002
2014-11-12 14:31:11 -08:00
mtklein
e069400cab
Restore bitmap dedup in SkPictureRecord. Cuts RAM usage of DM by half.
...
This should fix our failing 32-bit test bots.
BUG=skia:
Review URL: https://codereview.chromium.org/715423003
2014-11-12 12:49:47 -08:00
egdaniel
90ace96cbb
Rebase gm's for first time that were in no-comparion
...
TBR=
BUG=skia:
Review URL: https://codereview.chromium.org/715363006
2014-11-12 12:12:50 -08:00
scroggo
8338a9a855
Reland "Move from libstlport to libc++ for Android framework builds" (patchset #1 id:1 of https://codereview.chromium.org/718793003/ )
...
> Original issue's description:
> > Move from libstlport to libc++ for Android framework builds
> >
> > Committed: https://skia.googlesource.com/skia/+/ce259510a738fab05a0d456440104f5aba1c9d72
>
> TBR=tomhudson@google.com ,djsollen@google.com
> NOTREECHECKS=true
> NOTRY=true
>
> Committed: https://skia.googlesource.com/skia/+/3c3fe7ce4893204eb8bcf885e8a1d539763bca5d
TBR=tomhudson@google.com ,djsollen@google.com
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/717303002
2014-11-12 11:52:23 -08:00
reed
09a79d0998
cleanup comments
...
BUG=skia:
Review URL: https://codereview.chromium.org/715233005
2014-11-12 11:42:53 -08:00
bsalomon
395ef0568d
Fix use of NULL ptr in GrContext::drawRect
...
BUG=skia:3122
TBR=mtklein@google.com
Review URL: https://codereview.chromium.org/724443002
2014-11-12 11:35:22 -08:00
bungeman
06fc5cf206
Rebaseline for s4-Debug for 6fee786210
.
2014-11-12 14:21:28 -05:00
bsalomon
69ed47f42d
Make GrGpuResource::gpuMemorySize non-virtual w/ onGpuMemorySize virtual impl
...
BUG=skia:2889
Review URL: https://codereview.chromium.org/702413003
2014-11-12 11:13:39 -08:00
mtklein
703d3c7093
Followup: remove unnecessary SkTRefArray
...
BUG=skia:
Review URL: https://codereview.chromium.org/719113004
2014-11-12 11:08:20 -08:00
bsalomon
4bf406a478
Generalize valgrind suppressions for NV driver.
...
Review URL: https://codereview.chromium.org/723603003
2014-11-12 10:51:19 -08:00
bsalomon
48ea202817
set key data in duplicate scratch key unit test
...
TBR=robertphillips@google.com
Review URL: https://codereview.chromium.org/722763002
2014-11-12 10:28:17 -08:00
mtklein
71a2363707
More cleanup: streamline paths and bitmaps.
...
SkBitmapHeap is still used---now exclusively---by pipe.
BUG=skia:
Review URL: https://codereview.chromium.org/715413002
2014-11-12 10:24:55 -08:00
mtklein
391e318b3d
Fix memory leak in BitmapHeapTest
...
BUG=skia:
Review URL: https://codereview.chromium.org/715383003
2014-11-12 10:09:11 -08:00
mtklein
88300a555f
Follow up.
...
BUG=skia:
Review URL: https://codereview.chromium.org/719853002
2014-11-12 09:38:21 -08:00
robertphillips
8236591547
Rename GrAccelData to SkLayerInfo and move it to src/core
...
Review URL: https://codereview.chromium.org/719133002
2014-11-12 09:32:34 -08:00
reed
ac6a2f964e
detect bad bitmaps during deserialization
...
BUG=skia:3117
Review URL: https://codereview.chromium.org/718103002
2014-11-12 09:25:25 -08:00
mtklein
257bf0f6f7
Revert of Sk4x_sse.h (patchset #18 id:330001 of https://codereview.chromium.org/698873003/ )
...
Reason for revert:
Failing bots.
Original issue's description:
> Sk4x_sse.h
>
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/e4bf793120d3bfc9b003d11880a3fb73ff2b89e9
TBR=reed@google.com ,mtklein@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/719143002
2014-11-12 09:24:24 -08:00
mtklein
a74ce853c8
Start stripping out complicated parts of SkPicture{Record,Data}.
...
First step: no more paint flattening or deduplication.
BUG=skia:
Review URL: https://codereview.chromium.org/723593002
2014-11-12 09:19:02 -08:00
bungeman
d41e5bb1cc
Rebaseline for s4-Release for 6fee786210
.
2014-11-12 11:58:10 -05:00
bungeman
cb060082c9
Rebaseline for Nexus10 for 6fee786210
.
2014-11-12 11:36:14 -05:00
egdaniel
605dd0fbce
Move GrInvariantOutput out of GrProcessor and into its own class.
...
This will help with the ability to subclass, add to, etc. GrInvariantOutput. Also it was simply
getting a little too big to be a "supporting" subclass
BUG=skia:
Review URL: https://codereview.chromium.org/699943003
2014-11-12 08:35:25 -08:00
mtklein
e4bf793120
Sk4x_sse.h
...
BUG=skia:
Review URL: https://codereview.chromium.org/698873003
2014-11-12 08:32:49 -08:00
bungeman
6fee786210
Remove SK_USE_SCALED_FONTMETRICS.
...
This define was added in
"SK_USE_SCALED_FONTMETRICS for correct scaling"
c17c6582ec
.
Users all now define this flag, so it may now be removed.
BUG=chromium:420901
Review URL: https://codereview.chromium.org/720743003
2014-11-12 08:29:16 -08:00
mtklein
ef09991255
Add more tests.
...
BUG=skia:
Review URL: https://codereview.chromium.org/717143003
2014-11-12 07:27:01 -08:00
robertphillips
74576eba14
Clean up CollectLayers code
...
Now that CollectLayers directly uses FillBounds we can:
skip the explicit intersection with the clipBounds after an adjustAndMap call
skip the storage and use of the clipBounds in SaveLayerInfo
Review URL: https://codereview.chromium.org/719793002
2014-11-12 07:25:02 -08:00
robertphillips
4e8e3421aa
Move SkRecordComputeLayers and CollectLayers into SkRecordDraw.cpp
...
Rather then exposing parts of FillBounds (as in Expose FillBounds to allow GrPictureUtils::CollectLayers to be layered on top of it - https://codereview.chromium.org/698643002/ ), this CL moves CollectLayers into SkRecordDraw.cpp to accomplish the layering.
Review URL: https://codereview.chromium.org/716913003
2014-11-12 06:46:08 -08:00
joshualitt
b103d0c64a
rebase
...
TBR=
BUG=skia:
Review URL: https://codereview.chromium.org/717033002
2014-11-12 05:44:25 -08:00
tfarina
a3d33c546f
Cleanup: Remove submit_try script.
...
It is probably broken, and by now nobody should be using it really
anyway.
BUG=None
R=borenet@google.com
Review URL: https://codereview.chromium.org/720603002
2014-11-12 05:34:47 -08:00
reed
6a070dc06a
experimental
...
BUG=skia:
Review URL: https://codereview.chromium.org/716793004
2014-11-11 19:36:10 -08:00
mtklein
ad8aa1dcf3
Clang incorrectly thinks this typedef is unused.
...
BUG=skia:3059
Review URL: https://codereview.chromium.org/715093003
2014-11-11 18:52:02 -08:00
egdaniel
cd8b6307fe
Add isUnblended query to GrDrawState.
...
BUG=skia:
Review URL: https://codereview.chromium.org/715873002
2014-11-11 14:46:05 -08:00
bsalomon
453cf40ac7
Add GrGpuResource::CacheAccess
...
Internal only helper class for manipulating and accessing cache keys.
BUG=skia:2889
Review URL: https://codereview.chromium.org/703303003
2014-11-11 14:15:57 -08:00
scroggo
3c3fe7ce48
Revert of Move from libstlport to libc++ for Android framework builds (patchset #1 id:1 of https://codereview.chromium.org/714113002/ )
...
Reason for revert:
The code this depends on is not ready yet. We can submit once https://android-review.googlesource.com/#/c/113924/ is submitted.
Original issue's description:
> Move from libstlport to libc++ for Android framework builds
>
> Committed: https://skia.googlesource.com/skia/+/ce259510a738fab05a0d456440104f5aba1c9d72
TBR=tomhudson@google.com ,djsollen@google.com
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/718793003
2014-11-11 13:58:44 -08:00
joshualitt
4052a8e4f2
Remove coverage from grpaint
...
BUG=skia:
Review URL: https://codereview.chromium.org/683133006
2014-11-11 13:46:30 -08:00
reed
b969fc0f83
notice null colorfilter in legacy unflattening
...
BUG=skia:3117
Review URL: https://codereview.chromium.org/691383003
2014-11-11 13:13:35 -08:00
reed
f539b8cdee
modify nothingToDraw to notice filters
...
This reverts commit c71ffd4e76
.
TBR=
Review URL: https://codereview.chromium.org/683003003
2014-11-11 12:51:33 -08:00
bungeman
842ab70966
Fix "Add support for rebaselining from trybots."
...
Commit d09ade4b44
was missing a needed edit.
2014-11-11 15:28:02 -05:00
mtklein
c71ffd4e76
Revert of modify nothingToDraw to notice filters (patchset #1 id:1 of https://codereview.chromium.org/717753002/ )
...
Reason for revert:
modecolorfilters, perhaps more changed
Original issue's description:
> modify nothingToDraw to notice filters
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/d5688c509293a450c058e0cc1f4673be2931bb5c
TBR=djsollen@google.com ,reed@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/717813002
2014-11-11 12:13:16 -08:00
reed
d5688c5092
modify nothingToDraw to notice filters
...
BUG=skia:
Review URL: https://codereview.chromium.org/717753002
2014-11-11 11:00:55 -08:00
mtklein
bf5dd4170f
Add benchmark to compare different BBH query patterns.
...
On my laptop:
maxrss loops min median mean max stddev samples config bench
37M 1 14ms 14.2ms 14.6ms 18.2ms 9% ▁█▁▁▁▁▂▂▂▁ gpu tiled_playback_tilegrid_tiled
40M 1 17ms 17.2ms 17.2ms 17.6ms 1% ▆▃▁█▄▇▂▁▁▁ gpu tiled_playback_tilegrid_random
40M 1 14.6ms 14.9ms 15.8ms 19.1ms 11% ▂▁▁▁▁▁▁█▅█ gpu tiled_playback_rtree_tiled
43M 1 16.5ms 16.7ms 16.8ms 17.4ms 1% ▂▃▅█▃▂▁▃▃▂ gpu tiled_playback_rtree_random
43M 1 15.9ms 16.1ms 16.5ms 18.7ms 6% ▁▁█▇▁▁▁▂▁▁ gpu tiled_playback_none_tiled
44M 1 17.9ms 17.9ms 18ms 18.1ms 1% ▂▁▅▁▇▃▁▂█▇ gpu tiled_playback_none_random
TileGrid and RTree perform pretty much the same, both beating no BBH.
BUG=skia:3085
Review URL: https://codereview.chromium.org/699313006
2014-11-11 10:39:27 -08:00
scroggo
909b04b630
Fix Android framework build.
...
Need to include (transitively) SkUserConfig before checking
SK_SUPPORT_GPU.
Review URL: https://codereview.chromium.org/693613005
2014-11-11 09:45:33 -08:00
robertphillips
05699e5fe0
Remove multipicturedraw GMs from ignored-tests.txt
...
TBR=jcgregorio@google.com
Review URL: https://codereview.chromium.org/718763002
2014-11-11 09:42:38 -08:00
joshualitt
3595fc6a92
more gms to ignore
...
TBR=
BUG=skia:
Review URL: https://codereview.chromium.org/691143006
2014-11-11 09:28:30 -08:00
joshualitt
4dd9988642
remove separate color from coverage
...
BUG=skia:
Review URL: https://codereview.chromium.org/699023003
2014-11-11 08:51:30 -08:00
bsalomon
672550ddb6
Remove bogus assert
...
content key can be set after pending io scheduled (e.g. when scaling up a npot texture to pot).
BUG=skia:2889
TBR=robertphillips@google.com
Review URL: https://codereview.chromium.org/693843004
2014-11-11 08:29:01 -08:00
robertphillips
1e4595a050
Rebaseline problem (Galaxy S4) multipicturedraw GMs
...
This CL rebaselines the buggy multipicturedraw GMs related to:
Always enable layer hoisting in Skia (https://codereview.chromium.org/698493002/ )
TBR=jcgregorio@google.com
BUG=skia:3116
Review URL: https://codereview.chromium.org/715823002
2014-11-11 08:17:39 -08:00