Commit Graph

5917 Commits

Author SHA1 Message Date
skia.committer@gmail.com
7fc0e0a75a Sanitizing source files in Skia_Periodic_House_Keeping
git-svn-id: http://skia.googlecode.com/svn/trunk@7173 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-15 02:01:40 +00:00
humper@google.com
84831acfad fix all the false --> NULL issues in the gradient code
BUG=

Review URL: https://codereview.appspot.com/7095056

git-svn-id: http://skia.googlecode.com/svn/trunk@7170 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-14 22:09:54 +00:00
humper@google.com
d386b0eb03 remove namespace qualifier for feof; it's making android unhappy
BUG=

Review URL: https://codereview.appspot.com/7106048

git-svn-id: http://skia.googlecode.com/svn/trunk@7169 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-14 22:01:14 +00:00
senorblanco@chromium.org
027c10207a Fix a problem in the matrix convolution image filter exposed by https://code.google.com/p/skia/source/detail?r=7152: when offsetting texture coordinates in a GrEffect, take the origin of the source bitmap origin into account, and flip Y coordinates when we need to.
NOTE:  this will cause the matrixconvolution GM's to need to be rebaselined (again!).

Review URL: https://codereview.appspot.com/7086054

git-svn-id: http://skia.googlecode.com/svn/trunk@7168 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-14 21:53:45 +00:00
humper@google.com
a3bdc1a6cd another false --> NULL return fix
false --> NULL for failure return

BUG=

Review URL: https://codereview.appspot.com/7100052

git-svn-id: http://skia.googlecode.com/svn/trunk@7167 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-14 21:01:28 +00:00
humper@google.com
2ad83ea830 false --> NULL for failure return
BUG=

Review URL: https://codereview.appspot.com/7096058

git-svn-id: http://skia.googlecode.com/svn/trunk@7165 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-14 20:17:04 +00:00
humper@google.com
810ae48f82 move template specializations to inline functions in the header to make windows happy again
BUG=

Review URL: https://codereview.appspot.com/7099053

git-svn-id: http://skia.googlecode.com/svn/trunk@7164 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-14 20:11:00 +00:00
humper@google.com
18a48c3c1c replace getline with fgets for portability
BUG=

Review URL: https://codereview.appspot.com/7085058

git-svn-id: http://skia.googlecode.com/svn/trunk@7163 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-14 19:42:08 +00:00
humper@google.com
6d29eda491 remove dynamic_cast because rtti is disabled on some platforms (but not all??)
BUG=

Review URL: https://codereview.appspot.com/7102056

git-svn-id: http://skia.googlecode.com/svn/trunk@7161 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-14 19:20:28 +00:00
humper@google.com
61a972f11f fix gcc build
BUG=

Review URL: https://codereview.appspot.com/7095055

git-svn-id: http://skia.googlecode.com/svn/trunk@7160 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-14 19:03:46 +00:00
bungeman@google.com
7f5350346a Remove SK_DRAW_POS_TEXT_IGNORE_SUBPIXEL_LEFT_ALIGN_FIX.
https://codereview.appspot.com/7070073/


git-svn-id: http://skia.googlecode.com/svn/trunk@7159 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-14 19:03:20 +00:00
humper@google.com
7af56bee17 Runtime configuration system for skia. This will allow developers to control settings at launch time without relying on compile-time flags or recompilation. It can be used to turn features on and off, as well as to control numeric quantities to 'tune' algorithms. Once I make sure it's working across all platforms I'll send out a quick tutorial on its use.
Review URL: https://codereview.appspot.com/7098051

git-svn-id: http://skia.googlecode.com/svn/trunk@7158 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-14 18:49:19 +00:00
bungeman@google.com
50dd41017a Make SkScalerContextRec::getMatrixFrom2x2 more direct.
https://codereview.appspot.com/7070072/


git-svn-id: http://skia.googlecode.com/svn/trunk@7157 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-14 18:25:55 +00:00
robertphillips@google.com
c62b726dd1 Fix uninitialized memory issue
https://codereview.appspot.com/7085055/



git-svn-id: http://skia.googlecode.com/svn/trunk@7156 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-14 18:10:08 +00:00
robertphillips@google.com
444a401e3a Change SkAutoTUnref usage
https://codereview.appspot.com/7094054/



git-svn-id: http://skia.googlecode.com/svn/trunk@7155 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-14 17:40:15 +00:00
bsalomon@google.com
00835cc550 Fix debug build after r7153 (removed param referenced in assertion)
git-svn-id: http://skia.googlecode.com/svn/trunk@7154 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-14 17:07:22 +00:00
bsalomon@google.com
e197cbf9a3 Change signature of SkShader::asNewEffect(), implement for SkBitmapProcShader.
Review URL: https://codereview.appspot.com/7086051

git-svn-id: http://skia.googlecode.com/svn/trunk@7153 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-14 16:46:26 +00:00
junov@chromium.org
ff06af20fd Changing imageFilter GM tests to use drawBitmap instead of drawSprite
The motivation is be able to test the filters with scaled SkPicture playback in isolation from the issues that surround usage of drawSprite
Review URL: https://codereview.appspot.com/7060071

git-svn-id: http://skia.googlecode.com/svn/trunk@7152 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-14 16:27:50 +00:00
digit@google.com
47ebbcc7ab Use the NDK's cpu-features library when building skia for Chromium/Android.
This patch ensures that when Skia is built for Chromium, it will
always use the Android NDK's cpu-features helper library to detect
NEON at runtime.

This is needed because sandboxed Chromium renderer processes cannot
access /proc, and the probing performed in SkUtilsArm.cpp will never
work. As such, the NEON code paths will never be used even when the
device supports them.

Chromium has special code that ensures that the browser process
passes the CPU features flags to every renderer process, but
Skia needs to use android_getCpuFeatures() to get them.

See http://crbug.com/164154 for full details.
Review URL: https://codereview.appspot.com/7102045

git-svn-id: http://skia.googlecode.com/svn/trunk@7149 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-14 14:58:22 +00:00
bsalomon@google.com
61be7946ed Fix typo bug caught by mac warn-as-error (= should have been &=).
git-svn-id: http://skia.googlecode.com/svn/trunk@7148 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-14 14:36:40 +00:00
bsalomon@google.com
0263fcd72e Implement getConstantColorComponents() for matrix convolution.
R=senorblanco@chromium.org
Review URL: https://codereview.appspot.com/7092047

git-svn-id: http://skia.googlecode.com/svn/trunk@7146 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-11 22:24:04 +00:00
bsalomon@google.com
371e105da5 Add GrEffect::updateKnownColorComponents(). It is used to determine whether the output of an effect has a constant output value for r,g,b, or a.
Review URL: https://codereview.appspot.com/7064057

git-svn-id: http://skia.googlecode.com/svn/trunk@7144 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-11 21:08:55 +00:00
junov@chromium.org
95146ebc43 Adding commandline option to gm to make it write image results for tests that fails due to pixel mismatches.
Review URL: https://codereview.appspot.com/7100043

git-svn-id: http://skia.googlecode.com/svn/trunk@7143 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-11 21:04:40 +00:00
bsalomon@google.com
33cdbdea3d Fix leaks in blurrect benchs and gm.
Review URL: https://codereview.appspot.com/7071060

git-svn-id: http://skia.googlecode.com/svn/trunk@7142 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-11 20:54:44 +00:00
borenet@google.com
b00d670114 Enable per-tile logging in bench_pictures
- Modify bench_pictures buildstep to translate "key: True" --> "--key" rather
  than requiring "key: value" --> "--key value"
- Add whacky TileArgs helper which includes "timeIndividualTiles: True"
Review URL: https://codereview.appspot.com/7092046

git-svn-id: http://skia.googlecode.com/svn/trunk@7141 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-11 20:45:24 +00:00
edisonn@google.com
4fa566b34a Add option to render PDFs to memory only.
Review URL: https://codereview.appspot.com/7097045

git-svn-id: http://skia.googlecode.com/svn/trunk@7140 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-11 20:30:41 +00:00
bungeman@google.com
c18143e89b SkImageDecoder_WIC should work on Win7 with Win8 SDK.
https://codereview.appspot.com/7099044/


git-svn-id: http://skia.googlecode.com/svn/trunk@7139 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-11 20:02:32 +00:00
edisonn@google.com
01754bfd9d Fix typo, report in validate diff teh value of the pixel, not the address of the pixel.
git-svn-id: http://skia.googlecode.com/svn/trunk@7135 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-11 16:08:07 +00:00
rmistry@google.com
d6e6aef1d2 Rebaselined webpage image GMs for ['base-macmini'] on Google Storage.
git-svn-id: http://skia.googlecode.com/svn/trunk@7130 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-11 14:19:52 +00:00
bsalomon@google.com
50db75c871 Make GrEffect::textureAccess non-virtual. Require subclasses to append their GrTAs.
Review URL: https://codereview.appspot.com/7062063

git-svn-id: http://skia.googlecode.com/svn/trunk@7129 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-11 13:54:30 +00:00
bsalomon@google.com
55e4a2005e Remove non-destructive playback from GrIODB.
Review URL: https://codereview.appspot.com/7057070

git-svn-id: http://skia.googlecode.com/svn/trunk@7128 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-11 13:54:21 +00:00
skia.committer@gmail.com
f49b28745f Sanitizing source files in Skia_Periodic_House_Keeping
git-svn-id: http://skia.googlecode.com/svn/trunk@7127 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-11 02:01:25 +00:00
rmistry@google.com
a89e9da23b Whitespace change to trigger rebuilds
git-svn-id: http://skia.googlecode.com/svn/trunk@7126 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-11 01:42:39 +00:00
senorblanco@chromium.org
171f5c76b9 Rename onFilterImageGPU to filterImageGPU(), to match skia convention. No change in functionality.
(Note that this does mean that clients must override onFilterImage() to implement the raster path, but filterImageGPU() to implement the GPU path.)

Review URL: https://codereview.appspot.com/7058078

git-svn-id: http://skia.googlecode.com/svn/trunk@7123 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-10 19:55:18 +00:00
bungeman@google.com
091f51b794 DirectWrite generatePath must transform the path by the current matrix.
https://codereview.appspot.com/7061061/

This will require at least the shadertext2 gm for DirectWrite to be rebaselined.


git-svn-id: http://skia.googlecode.com/svn/trunk@7121 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-10 18:56:18 +00:00
robertphillips@google.com
735edb058b Add display of more SkPaint fields in Debugger
https://codereview.appspot.com/7060063/



git-svn-id: http://skia.googlecode.com/svn/trunk@7120 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-10 18:54:11 +00:00
epoger@google.com
3499f3c0d9 gm: if no readPath is given, report all tests as "missing reference image" instead of "passed"
Review URL: https://codereview.appspot.com/7070066

git-svn-id: http://skia.googlecode.com/svn/trunk@7119 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-10 17:11:27 +00:00
bungeman@google.com
59a6a2b983 Fix assertion caused by change in 7117.
SkRect::intersect returns false if either rectange is empty.
SkCanvas::quickReject returns true if an empty rectange is entirely contained within the clip bounds.



git-svn-id: http://skia.googlecode.com/svn/trunk@7118 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-10 16:58:02 +00:00
bungeman@google.com
99452e6d15 Properly reject clipped out draws in BBox pictures.
https://codereview.appspot.com/7057065/



git-svn-id: http://skia.googlecode.com/svn/trunk@7117 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-10 16:31:09 +00:00
epoger@google.com
8e910abcb7 gm self-test: update expected dashing2.png images (in inputs/ dir) to reflect new behavior
TBR=reed1
Review URL: https://codereview.appspot.com/7068060

git-svn-id: http://skia.googlecode.com/svn/trunk@7116 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-10 15:56:44 +00:00
bungeman@google.com
e1a89ca448 Update order in third_party/externals svn:externals property to match DEPS.
With the previous order a clean svn checkout fails to pull jsoncpp correctly.


git-svn-id: http://skia.googlecode.com/svn/trunk@7115 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-10 15:47:41 +00:00
bsalomon@google.com
358e427763 Remove default clip/drawstate in GrIODB.
R=robertphillips@google.com
Review URL: https://codereview.appspot.com/7070064

git-svn-id: http://skia.googlecode.com/svn/trunk@7114 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-10 14:40:28 +00:00
skia.committer@gmail.com
e04cf0cf1d Sanitizing source files in Skia_Periodic_House_Keeping
git-svn-id: http://skia.googlecode.com/svn/trunk@7113 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-10 02:01:29 +00:00
bsalomon@google.com
13ac3a3dda Fix incorrect sample cnt assert
git-svn-id: http://skia.googlecode.com/svn/trunk@7112 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-09 23:29:39 +00:00
scroggo@google.com
e490420efc Ensure that SkMemoryStream does not crash dereferencing fData.
SkMemoryStream attempts to dereference fData in multiple places.
Instead of allowing it to be NULL, resulting in a crash, set it
to SkData::NewEmpty().

Add a test for SkStream that will crash when its SkData is set to NULL.

Review URL: https://codereview.appspot.com/7061059

git-svn-id: http://skia.googlecode.com/svn/trunk@7111 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-09 22:02:58 +00:00
jvanverth@google.com
74dda9018e This takes the convex path tesselator from the Android code and hooks it into a
GrPathRenderer. GrAndroidPathRenderer is activated by gyp flag 'skia_android_path_rendering'.

A few changes to get this to work:
- Had to change SkPaint* param to SkStrokeRec& in ConvexPathVertices()
- Had to copy the vertex buffer created by the Android code to GrDrawTarget-generated vertex buffer, and convert float alpha to GrColor for AA paths


git-svn-id: http://skia.googlecode.com/svn/trunk@7110 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-09 21:04:52 +00:00
jvanverth@google.com
a543b604e4 Add clear after each image save, so that GPU images won't end up progressively compositing on top of one another.
git-svn-id: http://skia.googlecode.com/svn/trunk@7108 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-09 18:22:53 +00:00
reed@google.com
b6c933cc9b fix iOS build after adding modifierKeys to click events
git-svn-id: http://skia.googlecode.com/svn/trunk@7107 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-09 16:36:30 +00:00
rmistry@google.com
e760445970 Rebaselined webpage image GMs for ['base-shuttle-win7-intel-angle'] on Google Storage.
git-svn-id: http://skia.googlecode.com/svn/trunk@7100 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-09 13:33:22 +00:00
skia.committer@gmail.com
4e73aa1566 Sanitizing source files in Skia_Periodic_House_Keeping
git-svn-id: http://skia.googlecode.com/svn/trunk@7099 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-09 02:01:30 +00:00