Commit Graph

46849 Commits

Author SHA1 Message Date
Mike Reed
8989363322 rm unneeded header, see include/public
Change-Id: Ica26f683a9fd0ef7a624aa081678b619b70c9af8
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/273400
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Mike Reed <reed@google.com>
2020-02-26 04:53:33 +00:00
skia-autoroll
282f60a273 Roll ../src 2ea720658064..04383ff221c4 (360 commits)
2ea7206580..04383ff221


Created with:
  gclient setdep -r ../src@04383ff221

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-skia-autoroll
Please CC jlavrova@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: skia/skia.primary:Perf-Mac10.13-Clang-MacBookPro11.5-GPU-RadeonHD8870M-x86_64-Release-All-CommandBuffer;skia/skia.primary:Test-Mac10.13-Clang-MacBookPro11.5-GPU-RadeonHD8870M-x86_64-Debug-All-CommandBuffer
Bug: None
Tbr: jlavrova@google.com
Change-Id: I7207ebeb90daf36ad0c3a2d63a48fa10678f0966
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/273399
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2020-02-26 04:35:14 +00:00
skia-autoroll
96d61942e6 Roll third_party/externals/swiftshader e162b023f539..da659b374113 (4 commits)
https://swiftshader.googlesource.com/SwiftShader.git/+log/e162b023f539..da659b374113

git log e162b023f539..da659b374113 --date=short --first-parent --format='%ad %ae %s'
2020-02-25 capn@google.com Fix ANGLE standalone build
2020-02-25 capn@google.com Fix Android build after SPIRV-Tools update
2020-02-25 srisser@google.com Log instead of warn of unsupported extensions
2020-02-25 swiftshader.regress@gmail.com Regres: Update test lists @ e162b023

Created with:
  gclient setdep -r third_party/externals/swiftshader@da659b374113

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-skia-autoroll
Please CC jlavrova@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: skia/skia.primary:Test-Debian9-Clang-GCE-GPU-SwiftShader-x86_64-Debug-All-SwiftShader
Bug: None
Tbr: jlavrova@google.com
Change-Id: I3b218f16c64ba935987ef0504b66849178ba64cb
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/273416
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2020-02-26 04:33:05 +00:00
recipe-roller
f0a13d04c2 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (depot_tools) into this repository.

depot_tools:
  https://crrev.com/3b44ac67c9fd59379e9b1e1413ec5419b613c513 (ehmaldonado@google.com)
    Reland "gerrit-util: Fix GCE check from behind proxy."
  https://crrev.com/227d5108573318ac6510f17d80c167d94ceae3e1 (ehmaldonado@google.com)
    git-cl: Invoke presubmit checks via subprocess execution instead of via module.

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I151d89546aa060198e5a0427bb25789eecb5437f
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/273376
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
2020-02-26 00:29:34 +00:00
recipe-roller
7b96793ccc Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (depot_tools) into this repository.

depot_tools:
  https://crrev.com/63832e9056ec06edc6e8fe35a8a216ac8e6e52ab (iannucci@chromium.org)
    [vpython] Update depot_tools vpython to match fleet.
  https://crrev.com/ab9cc2c149a03c61209f69281a2e88c8e26b416f (ehmaldonado@google.com)
    my_activity: Add some tests and fix some bugs

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I1460a8154d03f632f73f9ec7326cdbc6b6262e30
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/273356
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
2020-02-25 23:57:44 +00:00
Julia Lavrova
9b906ce536 Revert "remove private copy of SkM44.h"
This reverts commit f8ef81b35e.

Reason for revert: Build broken

Original change's description:
> remove private copy of SkM44.h
> 
> Change-Id: Ifd47b929bafd40d190722366a0c1e2b856220ab3
> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/272836
> Reviewed-by: Florin Malita <fmalita@chromium.org>
> Commit-Queue: Mike Reed <reed@google.com>

TBR=fmalita@chromium.org,reed@google.com

Change-Id: I0da4ad43d5eaf5813ec489bc9117d4b8fc2b930e
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/273330
Reviewed-by: Julia Lavrova <jlavrova@google.com>
Commit-Queue: Julia Lavrova <jlavrova@google.com>
2020-02-25 23:00:54 +00:00
Mike Klein
f2930f48ad skvm llvm skeleton
Just the basics of getting existing basic structure in place.
Hoping to flesh this out over the next week or so.

Change-Id: Iba3a3023cc779ffa5fa6f79ebedd53499c076442
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/273323
Commit-Queue: Mike Klein <mtklein@google.com>
Reviewed-by: Herb Derby <herb@google.com>
2020-02-25 22:54:05 +00:00
Brian Salomon
adc9bbb2aa Remove GrTextureProducer::MakeMipMappedCopy
No color type fallback

Change-Id: I0429491cca1088e877ba2da2ff71ef2219ac9ec7
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/272521
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
2020-02-25 22:17:28 +00:00
Brian Osman
0941b6e91b Use SkTPin in magnifier filter to avoid integer overflow with NaN
Bug: chromium:1054887
Change-Id: I792a416c7071da75460016574f9aef8832f47e9d
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/273319
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
2020-02-25 21:48:19 +00:00
Brian Salomon
d8575452eb Add GrContextOption for GL error checking, shader, and program success.
Small behavior change: will not check for shader success and program
linking success over the command buffer in a debug build.

Also fail gracefully if stencil renderbuffer allocation fails.

Bug: skia:9938
Bug: chromium:1040186
Change-Id: I623f09d306261d28070078268f6242f92d65fd5f
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/273276
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
2020-02-25 21:00:19 +00:00
Brian Salomon
2677debcf0 Manual ANGLE roll. Update to our BUILD.gn to gen ANGLE's commit.h
Change-Id: I2935504caae35b612280691240fa4fff825632e3
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/273268
Reviewed-by: Julia Lavrova <jlavrova@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
2020-02-25 20:10:38 +00:00
Mike Reed
f8ef81b35e remove private copy of SkM44.h
Change-Id: Ifd47b929bafd40d190722366a0c1e2b856220ab3
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/272836
Reviewed-by: Florin Malita <fmalita@chromium.org>
Commit-Queue: Mike Reed <reed@google.com>
2020-02-25 19:51:17 +00:00
Ben Wagner
7a6db4cbf4 [infra] Move app installation to install method
This generally makes things tidier (e.g. perf_skottietrace.py no longer
needs special logic so that the app is only installed once), and it
means iOS can install only the app that's going to be run instead of
installing everything.

Change-Id: Ic07c56e724d0379255c8da5f204d9d6379b646ec
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/273002
Commit-Queue: Ben Wagner aka dogben <benjaminwagner@google.com>
Auto-Submit: Ben Wagner aka dogben <benjaminwagner@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
Reviewed-by: Kevin Lubick <kjlubick@google.com>
2020-02-25 17:34:21 +00:00
Brian Salomon
9f00494951 Add test that SWPathRenderer GenIDChange listeners get removed.
When a cached path mask texture is destroyed it should remove the
gen ID change listener on from the SkPathRef:
https://skia-review.googlesource.com/c/skia/+/272654

Change-Id: I4d1781e578b29b801b1b5b97ba5119ac321de73c
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/273004
Commit-Queue: Brian Salomon <bsalomon@google.com>
Reviewed-by: Robert Phillips <robertphillips@google.com>
2020-02-25 14:51:51 +00:00
Brian Salomon
c8d092a060 Revert "Revert "Remove copies for wrap modes in GrTextureProducer.""
This reverts commit bf5cb0f539.

Change-Id: I0dd15d03c42c5dc2c09ba81b6bc16d582f9093f6
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/272928
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
2020-02-25 14:06:21 +00:00
skia-recreate-skps
a6572f78d0 Update Go Deps
Change-Id: I74c0becde5948801821cc271287a7112823ef2e7
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/273194
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
2020-02-25 05:25:07 +00:00
skia-autoroll
13afbb2656 Roll third_party/externals/swiftshader 214ec337a0b2..e162b023f539 (3 commits)
https://swiftshader.googlesource.com/SwiftShader.git/+log/214ec337a0b2..e162b023f539

git log 214ec337a0b2..e162b023f539 --date=short --first-parent --format='%ad %ae %s'
2020-02-24 capn@google.com Add SPIRV-Tools headers dependency
2020-02-24 capn@google.com Add SPIR-Tools include headers path for src/Pipeline
2020-02-24 bclayton@google.com Update SPIRV-Tools to 8910ea5f1

Created with:
  gclient setdep -r third_party/externals/swiftshader@e162b023f539

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-skia-autoroll
Please CC jlavrova@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: skia/skia.primary:Test-Debian9-Clang-GCE-GPU-SwiftShader-x86_64-Debug-All-SwiftShader
Bug: None
Tbr: jlavrova@google.com
Change-Id: I2e7c3ddc8c879a781bb4b8c9e08e9a9b3c7e1459
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/273187
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2020-02-25 04:34:07 +00:00
skia-autoroll
86167236d4 Roll ../src f0bb4f52c523..2ea720658064 (312 commits)
f0bb4f52c5..2ea7206580


Created with:
  gclient setdep -r ../src@2ea7206580

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-skia-autoroll
Please CC jlavrova@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: skia/skia.primary:Perf-Mac10.13-Clang-MacBookPro11.5-GPU-RadeonHD8870M-x86_64-Release-All-CommandBuffer;skia/skia.primary:Test-Mac10.13-Clang-MacBookPro11.5-GPU-RadeonHD8870M-x86_64-Debug-All-CommandBuffer
Bug: None
Tbr: jlavrova@google.com
Change-Id: Ic49532e33d7e5de9c30498b90667257cd05f4874
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/273188
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2020-02-25 04:32:37 +00:00
recipe-roller
6d927b63a3 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (depot_tools) into this repository.

depot_tools:
  https://crrev.com/9aa1a9673a3c60858982bed95d6ad7bef469144c (ehmaldonado@google.com)
    git-cl: Add GetAuthor method and cache GetLocalDescription results

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I896570dec257ef01415a05efaf6cf7f19d798e04
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/273180
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
2020-02-25 01:28:37 +00:00
recipe-roller
a8b55bbfaa Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (depot_tools) into this repository.

depot_tools:
  https://crrev.com/f95054fa7d0466b80bd60dbaa0d9e35d9936d48b (yiwzhang@google.com)
    Roll bb tool to @36780e0
  https://crrev.com/61bf4177c413806b3f2355b6ff6375fe4e2e8e12 (ehmaldonado@google.com)
    git-cl: Fix get_cl_statuses for Python 3 and add tests.

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I5d555a3ab6a9433e839e6360b6da9d0a9d0d2d06
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/272897
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
2020-02-24 23:48:38 +00:00
Ben Wagner
b5d977fae3 Control opsz instead of CGFont in create_exact_copy.
Bug: https://github.com/flutter/flutter/issues/49492
Change-Id: Ia32a158e3326c1fe65f5d6f4e497592451458684
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/272116
Commit-Queue: Ben Wagner <bungeman@google.com>
Reviewed-by: Herb Derby <herb@google.com>
2020-02-24 23:33:47 +00:00
Nathaniel Nifong
19304d88c8 Move all canvaskit example resources to CDN
Change-Id: I92c83051017648d5703b06daac77e99ff40aeb2e
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/273000
Commit-Queue: Nathaniel Nifong <nifong@google.com>
Reviewed-by: Kevin Lubick <kjlubick@google.com>
2020-02-24 21:54:47 +00:00
Herb Derby
a64f5b2439 Remove SkExclusiveStrikePtr. Replace it with sk_sp<SkStrike>
* Rename all the Exclusive things.

Change-Id: If6b5fec5130bf58c396e0a472730efd2ae38c0d2
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/273057
Reviewed-by: Ben Wagner <bungeman@google.com>
Commit-Queue: Herb Derby <herb@google.com>
2020-02-24 21:41:05 +00:00
Weston Tracey
bfe5a68c1e Move Pixel2XL Android_DDL1_Vulkan and Android_DDL3_Vulkan jobs to NVIDIA_Shield.
We lost 2 Pixel2XLs last week, so the remaining ones can't keep up.

Change-Id: I60e1e3070c5fc7ea2896ec34434c9c5b296b897e
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/272999
Auto-Submit: Weston Tracey <westont@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>
Reviewed-by: Robert Phillips <robertphillips@google.com>
2020-02-24 20:26:25 +00:00
Shachar Langbeheim
c43a6c54b1 Remove docs for macros that don't exist in the code.
Change-Id: Ibabe3f1f9663ec36b5128bdb6f1cfeb7b8e09e8a
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/272896
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
2020-02-24 19:44:45 +00:00
Chris Dalton
4c20318e48 Remove SWAP_PER_DRAW from GrGLGpu
This debug option was added back in 2011, and the code inside the
#define has not been compilable for many years.

Change-Id: I4366025da6e616f17f75dee14bced2809a90628f
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/273038
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Chris Dalton <csmartdalton@google.com>
2020-02-24 19:40:25 +00:00
Herb Derby
659cc1c907 Make the strike cache hash table own the strike
Make the ownership explicit by using the hash
table.

Change-Id: I3e1520091e755010c71a9b497af62a64636dc5bd
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/272722
Reviewed-by: Ben Wagner <bungeman@google.com>
Commit-Queue: Herb Derby <herb@google.com>
2020-02-24 19:00:46 +00:00
Robert Phillips
251ee1da5b Remove SkDDLTmpRedirect.h
With the Chrome-side CL:

https://chromium-review.googlesource.com/c/chromium/src/+/2067805 (Switch SkDDLTmpRedirect.h reference to SkDeferredDisplayList.h)

having landed, Skia no longer needs this temporary header.

TBR=bsalomon@google.com
Change-Id: I01da4ece2be239407e223105781d4d0d75deabdb
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/273018
Reviewed-by: Robert Phillips <robertphillips@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>
2020-02-24 18:26:35 +00:00
Dominic Mazzoni
2a016bad67 Allow passing multiple node IDs per PDF structure node.
At the time Chromium is painting, we're passing node IDs
along with painting commands to enable tagging. However,
this assumes that all nodes will end up in the structure
tree, which we might not want.

Instead, allow the client to prune the structure tree
later before telling Skia to generate the PDF, but
keep all of the node IDs to be matched up with.

As an example, suppose the doc looks like this:

root id=1
  paragraph id=2
    div id=3
      text1 id=4
    link id=5
      text2 id=6

The pruned tree passed to Skia would look like this:

root id=1
  paragraph id=2 extra_ids=3,4
    link id=5 extra_ids=6

We need to pass the extra node IDs into Skia so
that when content is tagged with id=4, we know to
map that to the paragraph node with id=2 instead.

Note that the resulting PDF document will *not*
have any of these extra IDs, they're all remapped
and consolidated.

While it's not strictly necessary that this is done
in Skia, it's easiest to implement it here. Doing the
same upstream would require replaying an SkPicture
and rewriting all of the node IDs.

Bug: chromium:607777
Change-Id: I0ecb62651e60b84cc5b9d053d7f7d3b9efda1470
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/272462
Reviewed-by: Ben Wagner <bungeman@google.com>
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
2020-02-24 18:21:16 +00:00
Brian Salomon
3fcf83a504 Fix GrTextureEffect with kRepeat/kRepeat/kBilerp.
Use absolute error value when doing shader-based interp between all
four subset corner texels.

Add 2x2 image to rectangle_texture GM and draw with all combos of
tile modes.

Change-Id: Ia5856d592b1c9ab8b588301e7b659b05a7439396
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/272920
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
2020-02-24 18:02:45 +00:00
Jim Van Verth
03b8ab225f Reland "Create D3D device and queue"
This is a reland of 29dc430f43

Original change's description:
> Create D3D device and queue
> 
> Bug: skia:9935
> Change-Id: Ib6548f413ca3a8befb553d2d47354b400c9162b9
> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/272520
> Commit-Queue: Jim Van Verth <jvanverth@google.com>
> Reviewed-by: Greg Daniel <egdaniel@google.com>

Bug: skia:9935
Change-Id: I1c8797e09cdeb3694ea7f47b2236ab7d91d9519f
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/272996
Reviewed-by: Ben Wagner aka dogben <benjaminwagner@google.com>
Commit-Queue: Jim Van Verth <jvanverth@google.com>
2020-02-24 17:41:55 +00:00
Joe Gregorio
6dd3b73f1b [assets] Add CockroackDB as an asset for testing.
Change-Id: I3202bdedebb0f33968a739dd25f6dbcd7d5b4429
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/272997
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Joe Gregorio <jcgregorio@google.com>
2020-02-24 17:28:15 +00:00
Greg Daniel
02497d4016 Update nanobench and skpbench to use flush API for gpu syncing.
This also allows us to remove all the one off Fence code that we
implemented in all the backend TestContexts

Change-Id: I9ff7ba4690cf3f19a180f51fc510991a112bb62c
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/272456
Reviewed-by: Chris Dalton <csmartdalton@google.com>
Commit-Queue: Greg Daniel <egdaniel@google.com>
2020-02-24 17:21:35 +00:00
Kevin Lubick
9279798022 [canvaskit] Expose releaseResourcesAndAbandonContext on GrContext
Bug: skia:9910
Change-Id: If0a6aa106d42c680f1f0f3092c4a4dbd0f04c937
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/270936
Reviewed-by: Nathaniel Nifong <nifong@google.com>
2020-02-24 17:11:28 +00:00
Weston Tracey
cc08d9fabf Update tasks.json based on Go Deps Cl.
Merge commit 'refs/changes/95/272895/2' of https://skia.googlesource.com/skia


Update Go Deps

Change-Id: I8d56caafce1d21bd6bead373c96f57ed0c7d96a7
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/273016
Auto-Submit: Weston Tracey <westont@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
2020-02-24 16:54:15 +00:00
Brian Salomon
4282d2992c Prevent unbounded invalidator growth on SkPathRef from GrSWPathRenderer
Bug: b/149684076
Change-Id: I8edb871c26296da9cc76ab57f9fd9c09d5ebcae5
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/272654
Reviewed-by: Robert Phillips <robertphillips@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
2020-02-24 16:52:25 +00:00
skia-autoroll
8da5c3d450 Roll skia/third_party/skcms 605b00d7728f..cbf3b9df1ae1 (1 commits)
https://skia.googlesource.com/skcms.git/+log/605b00d7728f..cbf3b9df1ae1

git log 605b00d7728f..cbf3b9df1ae1 --date=short --first-parent --format='%ad %ae %s'
2020-02-24 benjaminwagner@google.com Update Xcode

Created with:
  gclient setdep -r skia/third_party/skcms@cbf3b9df1ae1

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skcms-skia-autoroll
Please CC jlavrova@google.com,mtklein@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

TBR=jlavrova@google.com, mtklein@google.com

Cq-Include-Trybots: luci.chromium.try:linux-blink-rel
Bug: None
Change-Id: I2368ab4ab1a61ed94e19d96aff2398992320fb12
Tbr: jlavrova@google.com,mtklein@google.com
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/272982
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2020-02-24 16:46:45 +00:00
Chris Dalton
2e7ed26cc7 Lift calls for setting dynamic state to Ganesh level
Previously, all backends were responsible to check for dynamic state
and update it during their internal draw calls. This CL adds
setScissor() and bindTextures() methods to GrOpsRenderTask, and places
this responsibility to update dynamic state on Ganesh instead. It also
replaces the backend-specific "onDrawMeshes" call, with a singular
"onDrawMesh" call that gets called for each mesh.

For now we keep drawMeshes() on GrOpsRenderPass for convenience, but
it will soon be removed and each call site will be responsible to set
its own dynamic state.

Change-Id: If141feae857b22cbf04416557d0c89986eda2a62
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/271976
Commit-Queue: Chris Dalton <csmartdalton@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
Reviewed-by: Jim Van Verth <jvanverth@google.com>
2020-02-24 16:41:45 +00:00
Chris Dalton
7d25230226 Remove "setData" operations from GrMtlPipelineState::setTextures
Change-Id: Iaba354865599097d562b29c2ba5e7da8112b22a0
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/272724
Reviewed-by: Jim Van Verth <jvanverth@google.com>
Commit-Queue: Chris Dalton <csmartdalton@google.com>
2020-02-24 16:03:35 +00:00
Ben Wagner
108a494984 Omit crashing bench on iOS Metal
Bug: skia:9799
Change-Id: I341a83b575a4e4595756c3ee055fcbc1418bc962
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/272636
Auto-Submit: Ben Wagner aka dogben <benjaminwagner@google.com>
Commit-Queue: Jim Van Verth <jvanverth@google.com>
Reviewed-by: Jim Van Verth <jvanverth@google.com>
2020-02-24 15:40:35 +00:00
Robert Phillips
1cec4d5e3d Add a program iterator to SkDeferredDisplayList
Bug: skia:9455
Change-Id: I201218174b5d6efb72f7c06766a49f6711325bd5
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/272530
Commit-Queue: Robert Phillips <robertphillips@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
2020-02-24 14:03:06 +00:00
Florin Malita
9642b31a71 [skottie] Add support for text animator blur
In adition to transforms/opacity/etc, text animators can target
per-glyph opacity.

Change-Id: I6ab63a6e49a64beaf63fc955f0b672a5b8ba84ba
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/272886
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Florin Malita <fmalita@chromium.org>
2020-02-24 14:01:16 +00:00
Nathaniel Nifong
cc5415a8ce Modify 3D example with light and bump shader.
Depends on what I assume the final version of https://skia-review.googlesource.com/c/skia/+/272646 will be
Change-Id: I53485c5f47e0fef120c8a1bd6d0620fddfb3cde9
Bug: skia:9866
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/272529
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Kevin Lubick <kjlubick@google.com>
2020-02-24 12:46:35 +00:00
skia-autoroll
57bc977e12 Roll third_party/externals/angle2 94ec1e5f8df5..b5576b67bcf5 (18 commits)
94ec1e5f8d..b5576b67bc

git log 94ec1e5f8df5..b5576b67bcf5 --date=short --first-parent --format='%ad %ae %s'
2020-02-22 spang@chromium.org Vulkan: Fix pipeline stage when waiting on a semaphore
2020-02-21 jmadill@chromium.org Vulkan: Rename CommandGraphResource to Resource.
2020-02-21 spang@chromium.org Reformat GN files
2020-02-21 ynovikov@chromium.org Suppress SwANGLE dEQP GLES3 failure.
2020-02-21 spang@google.com Roll chromium_revision a9ad696264..86e00b5dd2 (742676:743688)
2020-02-21 khushalsagar@chromium.org Add uniform location checks for ignored/invalid location
2020-02-21 ynovikov@chromium.org Suppress SwANGLE dEQP failures
2020-02-21 jmadill@chromium.org Refactor DrawCallPerf test parameters.
2020-02-21 spang@chromium.org Implement glImportMemoryZirconHandle & glImportSemaphoreZirconHandle
2020-02-21 geofflang@chromium.org Add geofflang@google.com to OWNERS.
2020-02-21 jmadill@chromium.org Trace/Replay: Add uniform location type.
2020-02-21 jmadill@chromium.org Vulkan: Remove command graph size overlay widget.
2020-02-21 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/vulkan-loader/src c357af84c7cb..136207a63495 (3 commits)
2020-02-21 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/SwiftShader 74d3f371f201..f50cc82b3bed (6 commits)
2020-02-21 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/vulkan-validation-layers/src 6112b121e104..a09ab94aa920 (5 commits)
2020-02-21 jmadill@chromium.org Vulkan: Remove CommandGraph code.
2020-02-21 jmadill@chromium.org Run debug callback in perf render tests.
2020-02-21 lexa.knyazev@gmail.com Reland "Move sampleAlphaToCoverage out of blendState"

Created with:
  gclient setdep -r third_party/externals/angle2@b5576b67bcf5

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-skia-autoroll
Please CC jlavrova@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: skia/skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia/skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-Golo-GPU-QuadroP400-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC8i5BEK-GPU-IntelIris655-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE
Bug: None
Tbr: jlavrova@google.com
Change-Id: Ic36a4e01896cc052ffa44036406af414477054da
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/272890
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2020-02-24 05:07:45 +00:00
skia-autoroll
3a5e853d8c Roll ../src f5ddd865c430..f0bb4f52c523 (1392 commits)
f5ddd865c4..f0bb4f52c5


Created with:
  gclient setdep -r ../src@f0bb4f52c5

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-skia-autoroll
Please CC jlavrova@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: skia/skia.primary:Perf-Mac10.13-Clang-MacBookPro11.5-GPU-RadeonHD8870M-x86_64-Release-All-CommandBuffer;skia/skia.primary:Test-Mac10.13-Clang-MacBookPro11.5-GPU-RadeonHD8870M-x86_64-Debug-All-CommandBuffer
Bug: None
Tbr: jlavrova@google.com
Change-Id: I8b3c6951ed3ed04391955bf8d9b7ebec0bbd37a2
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/272889
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2020-02-24 05:05:35 +00:00
skia-autoroll
f084b8b6b6 Roll third_party/externals/swiftshader f50cc82b3bed..214ec337a0b2 (3 commits)
https://swiftshader.googlesource.com/SwiftShader.git/+log/f50cc82b3bed..214ec337a0b2

git log f50cc82b3bed..214ec337a0b2 --date=short --first-parent --format='%ad %ae %s'
2020-02-23 thakis@chromium.org Fix Wrange-loop-analysis warnings in swiftshader.
2020-02-21 amaiorano@google.com Replace target_cpu with current_cpu in Build.gn files
2020-02-21 sugoi@google.com Revert "Subzero: add support for large stacks on Windows"

Created with:
  gclient setdep -r third_party/externals/swiftshader@214ec337a0b2

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-skia-autoroll
Please CC jlavrova@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: skia/skia.primary:Test-Debian9-Clang-GCE-GPU-SwiftShader-x86_64-Debug-All-SwiftShader
Bug: None
Tbr: jlavrova@google.com
Change-Id: I5033f69fedc14c0cc62fdc610f5c24c43883c269
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/272891
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2020-02-24 04:34:36 +00:00
Ben Wagner
998066127e Update XCode
Chromium now requires the 10.15 SDK
(https://bugs.chromium.org/p/chromium/issues/detail?id=1023913), which
breaks the CommandBuffer bot because it's trying to compile with XCode
10.3, which provides the 10.14 SDK.

What's worse, due to reasons I don't fully understand, after failing to
compile CommandBuffer due to the dependence on the 10.15 SDK, the ninja
out dir is poisoned for future compiles that don't depend on the 10.15
SDK.

Also includes a code snippet from
https://skia-review.googlesource.com/c/skia/+/264429 to find the xSAN
dylibs.

Change-Id: I3cd7661a5ea984ea6899e7a5e8cf878581538d9e
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/272736
Reviewed-by: Ben Wagner aka dogben <benjaminwagner@google.com>
2020-02-23 23:15:26 +00:00
Ben Wagner
d1c90e10f0 Whitespace change to re-trigger Mac/iOS tests
Change-Id: I82104e6a3f9218db48551ec934734c3768e71543
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/272916
Reviewed-by: Ben Wagner aka dogben <benjaminwagner@google.com>
2020-02-23 20:55:01 +00:00
Mike Reed
9e8f605344 SkM44.h is now in include/public
Change-Id: I679d3328a65123d4cbb15045d98fe4ac498ee531
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/272837
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Mike Reed <reed@google.com>
2020-02-22 16:43:56 +00:00
Kevin Lubick
ecd8762e1f [canvaskit] Support children shaders into runtime shaders
Change-Id: I88106babe35f6e5b3ee764e7fbaf82c7f43d136d
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/272646
Reviewed-by: Nathaniel Nifong <nifong@google.com>
2020-02-22 12:38:52 +00:00