Commit Graph

34061 Commits

Author SHA1 Message Date
Brian Salomon
8a98bc9674 Revert "Revert "Add arcs as a specialized geometry to GrShape.""
This reverts commit af88ec3712.

Bug: skia:7794
Change-Id: I2d0e1d7b4e025481241d823b09f5de5d0f1a13eb
Reviewed-on: https://skia-review.googlesource.com/123627
Reviewed-by: Robert Phillips <robertphillips@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
2018-04-25 18:54:07 +00:00
Kevin Lubick
cfd650e43f Move Baytrail to stretch
Bug: skia:
Change-Id: Ib7fe82df428038e1be773446c121010665fe7472
Reviewed-on: https://skia-review.googlesource.com/123628
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
2018-04-25 18:52:07 +00:00
skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com
677809ac16 Roll skia/third_party/skcms 48c6ca0..509a65e (1 commits)
https://skia.googlesource.com/skcms.git/+log/48c6ca0..509a65e

2018-04-25 mtklein@chromium.org Reland "use linear segment instead of recalculating it"


The AutoRoll server is located here: https://skcms-skia-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



TBR=stani@google.com

Change-Id: I61527be2081ed737ca323a4e87ff778270a59104
Reviewed-on: https://skia-review.googlesource.com/123723
Reviewed-by: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
2018-04-25 18:19:47 +00:00
skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com
de5cffbc48 Roll skia/third_party/skcms 9e351c0..48c6ca0 (1 commits)
https://skia.googlesource.com/skcms.git/+log/9e351c0..48c6ca0

2018-04-25 mtklein@chromium.org evaluate skcms_PolyTF carefully


The AutoRoll server is located here: https://skcms-skia-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



TBR=stani@google.com

Change-Id: I8fb39fbacfe84a0ceec668b5221f8f32cc225f26
Reviewed-on: https://skia-review.googlesource.com/123657
Reviewed-by: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
2018-04-25 17:52:07 +00:00
angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com
412d411d66 Roll third_party/externals/angle2/ 023371b3a..f827123d9 (5 commits)
023371b3af..f827123d99

$ git log 023371b3a..f827123d9 --date=short --no-merges --format='%ad %ae %s'
2018-04-25 oetuaho Handle negative float to uint conversion robustly
2018-04-24 lucferron Vulkan: Enable UnpackAlignmentTest and remove useless warning.
2018-04-24 lucferron Vulkan: Fix issue with texsubimage2d barriers
2018-04-25 jmadill Clean up DEPS style.
2018-04-24 lucferron Vulkan: Issue when drawing with a texture and rebinding after.

Created with:
  roll-dep third_party/externals/angle2


The AutoRoll server is located here: https://angle-skia-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE
TBR=stani@google.com

Change-Id: I10362056f2079bde891d905cae2caf3391ba083b
Reviewed-on: https://skia-review.googlesource.com/123655
Reviewed-by: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
2018-04-25 17:47:57 +00:00
Brian Osman
6cd9268907 Don't 'require' external image extensions, 'enable' them
We trigger this when we don't necessarily have support for both
extensions, so requiring them can cause compilation failures.

Bug: https://github.com/flutter/flutter/issues/16178
Change-Id: I54c190709a677bc9ec2fa46f612e8958e3de38cb
Reviewed-on: https://skia-review.googlesource.com/123683
Reviewed-by: Ethan Nicholas <ethannicholas@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
2018-04-25 17:38:37 +00:00
Mike Reed
910ca0fd01 Experiment to track coverage in a layer
Bug: skia:
Change-Id: I5ed334f63e64991944394dc8103092a2c6280546
Reviewed-on: https://skia-review.googlesource.com/122000
Commit-Queue: Mike Reed <reed@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
2018-04-25 17:34:27 +00:00
skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com
f0db23633f Roll skia/third_party/skcms f3a576b..9e351c0 (1 commits)
https://skia.googlesource.com/skcms.git/+log/f3a576b..9e351c0

2018-04-25 mtklein@chromium.org relax is_identity_tf()


The AutoRoll server is located here: https://skcms-skia-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



TBR=stani@google.com

Change-Id: I8e85719c85ca3ebbe3da2bf66e75968fd251c7a2
Reviewed-on: https://skia-review.googlesource.com/123656
Commit-Queue: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
2018-04-25 17:25:57 +00:00
Ethan Nicholas
3c6ae62e0f cache SkSL headers
This reduces the cost of successive shader compilations by caching the
results of compiling SkSL's headers.

Bug: skia:
Change-Id: If7fc21a9877021c4025ad99dd0981523a25855e0
Reviewed-on: https://skia-review.googlesource.com/123422
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
2018-04-25 16:53:27 +00:00
Ben Wagner
f8f1839cc8 Upgrade Win Radeon driver.
Bug: skia:7809
Change-Id: I9266a16acee92f5a5fcb8e723890c1793c957bf3
No-Try: true
Reviewed-on: https://skia-review.googlesource.com/123589
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Auto-Submit: Ben Wagner <benjaminwagner@google.com>
Reviewed-by: Kevin Lubick <kjlubick@google.com>
2018-04-25 16:45:57 +00:00
Robert Phillips
115a12f849 Fix GrRRectBlurEffect.fp
Change-Id: I40192fd1bcc0af7f06edddfd2e961b69b14546f5
Reviewed-on: https://skia-review.googlesource.com/123630
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>
2018-04-25 16:42:37 +00:00
skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com
dc3aa7d3ce Roll skia/third_party/skcms 40a5028..f3a576b (1 commits)
https://skia.googlesource.com/skcms.git/+log/40a5028..f3a576b

2018-04-25 mtklein@chromium.org SKCMS_API


The AutoRoll server is located here: https://skcms-skia-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



TBR=stani@google.com

Change-Id: Ie0a8bc53904ae098ce5ca5909d3e39dd62e437c6
Reviewed-on: https://skia-review.googlesource.com/123649
Commit-Queue: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
2018-04-25 16:40:47 +00:00
skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com
e8b6ddabb2 Roll skia/third_party/skcms 86807d3..40a5028 (1 commits)
https://skia.googlesource.com/skcms.git/+log/86807d3..40a5028

2018-04-25 mtklein@google.com Revert "use linear segment instead of recalculating it"


The AutoRoll server is located here: https://skcms-skia-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



TBR=stani@google.com

Change-Id: Ib70f9037f9acaf6357b2877c977df8a8c09eb268
Reviewed-on: https://skia-review.googlesource.com/123648
Reviewed-by: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
2018-04-25 16:15:27 +00:00
Kevin Lubick
d9b414f37d Migrate ShuttleA bots to Debian9 stretch
Bug: skia:
Change-Id: I0f405b7aed7b90dbeb18e6a419b2eb67725148d0
Reviewed-on: https://skia-review.googlesource.com/123624
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
2018-04-25 15:41:57 +00:00
skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com
27988f76b2 Roll skia/third_party/skcms 289a2a7..86807d3 (1 commits)
https://skia.googlesource.com/skcms.git/+log/289a2a7..86807d3

2018-04-25 mtklein@chromium.org use linear segment instead of recalculating it


The AutoRoll server is located here: https://skcms-skia-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



TBR=stani@google.com

Change-Id: Iba614caef0c1020f4e32752e96d85bcabb96c560
Reviewed-on: https://skia-review.googlesource.com/123644
Reviewed-by: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
2018-04-25 15:08:37 +00:00
Robert Phillips
213ce18fc4 Refactor GaussianBlur
One of the bounding boxes in this method goes haywire in DDL mode. Hopefully, this refactoring will make it easier to determine which one it is.

Note that in this CL I tried to not change the existing behavior at all.

Bug: skia:7765
Change-Id: Ie71b4c338fd7ecf4f4b8b4cb5609ef3e686eaef5
Reviewed-on: https://skia-review.googlesource.com/122956
Reviewed-by: Greg Daniel <egdaniel@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>
2018-04-25 15:01:07 +00:00
skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com
7c09a31344 Roll skia/third_party/skcms e19e9b9..289a2a7 (1 commits)
https://skia.googlesource.com/skcms.git/+log/e19e9b9..289a2a7

2018-04-25 brianosman@google.com Reject parametric curves with negative A, C, D, or G


The AutoRoll server is located here: https://skcms-skia-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



TBR=stani@google.com

Change-Id: Ia6683758ac0a0eae0a71b75c750e4f4f5eab4c8f
Reviewed-on: https://skia-review.googlesource.com/123642
Commit-Queue: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
2018-04-25 14:38:37 +00:00
Adrienne Walker
77e95f7067 Fix SkDashImpl::CreateProc OOM on garbage input
Verify that there's enough data to read from before allocating gigantic
blocks of memory.  This was caught by a fuzzer.

Bug: chromium:835418
Change-Id: I43fb1d11ec13726aacb62fe6aeb9f137424fb783
Reviewed-on: https://skia-review.googlesource.com/123538
Commit-Queue: Mike Klein <mtklein@google.com>
Auto-Submit: Adrienne Walker <enne@chromium.org>
Reviewed-by: Mike Klein <mtklein@google.com>
2018-04-25 13:23:36 +00:00
Kevin Lubick
ec4e7358ba Migrate NUC7i5BNK to Debian 9
Bug: skia:
Change-Id: Icd537f098742a89469e9165e14b230e769247e54
Reviewed-on: https://skia-review.googlesource.com/123563
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
2018-04-25 13:13:07 +00:00
Ben Wagner
e1c37a7b8f [infra] Add image dimension for Win GCE bots
Change-Id: Ib7a8205992c6c1f4d93448afe54468f77511f1f0
Reviewed-on: https://skia-review.googlesource.com/123585
Auto-Submit: Ben Wagner <benjaminwagner@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
2018-04-25 11:19:46 +00:00
angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com
9f63153a03 Roll third_party/externals/angle2/ f2807385c..023371b3a (2 commits)
f2807385cb..023371b3af

$ git log f2807385c..023371b3a --date=short --no-merges --format='%ad %ae %s'
2018-04-24 oetuaho Fix setting mip level metadata on GL backend
2018-04-12 courtneygo Add angle library apk

Created with:
  roll-dep third_party/externals/angle2


The AutoRoll server is located here: https://angle-skia-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE
TBR=stani@google.com

Change-Id: I556dbdc57719a991e7f665673e334fd69a4fef16
Reviewed-on: https://skia-review.googlesource.com/123600
Commit-Queue: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
2018-04-25 08:53:56 +00:00
angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com
56610207ea Roll third_party/externals/angle2/ 66410530a..f2807385c (3 commits)
66410530a7..f2807385cb

$ git log 66410530a..f2807385c --date=short --no-merges --format='%ad %ae %s'
2018-04-24 geofflang D3D: Use an alignment of 1 when uploading zero data to initialize textures.
2018-04-24 jmadill Vulkan: Add GetColorComponentFlags.
2018-04-23 lucferron Vulkan: Bugfix in TextureVk::setSubImage and DynamicBuffer

Created with:
  roll-dep third_party/externals/angle2


The AutoRoll server is located here: https://angle-skia-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE
TBR=stani@google.com

Change-Id: I9ed6218c5bfc56e2600b243ee0d7c77916b36cbf
Reviewed-on: https://skia-review.googlesource.com/123535
Reviewed-by: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
2018-04-25 00:01:36 +00:00
Jim Van Verth
4c8c1e8302 Minor shadow fixes.
Fix inset value for analytic shadows to get full inset (and hence
proper falloff).
Fix compute_radial_values in tessellator to return only positive values
and produce cleaner arcs.
Adjust shadow params in Android sample to match Android.
Fix corner calculation for analytic shadow.

Bug: skia:7486
Change-Id: Ib393b5d577f5a5eb89d3388aa4726ea4dae37055
Reviewed-on: https://skia-review.googlesource.com/123220
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Jim Van Verth <jvanverth@google.com>
2018-04-24 21:53:06 +00:00
skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com
058f2e6ed2 Roll skia/third_party/skcms cca4d5d..e19e9b9 (1 commits)
https://skia.googlesource.com/skcms.git/+log/cca4d5d..e19e9b9

2018-04-24 brianosman@google.com Remove skcms_BestSingleCurve


The AutoRoll server is located here: https://skcms-skia-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



TBR=stani@google.com

Change-Id: I28c0be7b318c8475dd34b0d7f26b012c16dafe44
Reviewed-on: https://skia-review.googlesource.com/123530
Commit-Queue: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
2018-04-24 21:04:37 +00:00
Ben Wagner
ff134f20ae Compile with latest clang 7.
Changes to warnings in clang introduced by https://reviews.llvm.org/D43322
and https://reviews.llvm.org/D44883 cause warning as error failures when
building Skia. In particular this addresses return-std-move-in-c++11 and
self-assign-overloaded.

Change-Id: I680318098d8af1b64fba464585c7cdfcfcf39d66
Reviewed-on: https://skia-review.googlesource.com/123582
Reviewed-by: Greg Daniel <egdaniel@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Ben Wagner <bungeman@google.com>
2018-04-24 20:58:06 +00:00
skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com
a11f7d0a59 Roll skia/third_party/skcms 73399c8..cca4d5d (1 commits)
https://skia.googlesource.com/skcms.git/+log/73399c8..cca4d5d

2018-04-24 mtklein@chromium.org polytf


The AutoRoll server is located here: https://skcms-skia-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



TBR=stani@google.com

Change-Id: I4611cabb3a2ee8fb13f42c2b35f6fbbb71ad1539
Reviewed-on: https://skia-review.googlesource.com/123527
Reviewed-by: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
2018-04-24 20:14:16 +00:00
Brian Osman
7886995ae9 Make SkColorSpace::Make(skcms_ICCProfile) stricter
Don't do any modification to the incoming profile.
Basically, if you want this to succeed, call
skcms_EnsureUsableAsDestinationWithSingleCurve first.

Change-Id: Iafe3fd3c82c2fb2cc0e42b1968a69bf605be241c
Reviewed-on: https://skia-review.googlesource.com/123521
Reviewed-by: Mike Klein <mtklein@chromium.org>
Commit-Queue: Brian Osman <brianosman@google.com>
2018-04-24 19:38:16 +00:00
Hal Canary
47728258b0 include/private/SkTemplates: SkInPlaceNewCheck uses ...
Change-Id: Ia9af6daec20bdd4bfa7f34c8bff7b400f5775dd9
Reviewed-on: https://skia-review.googlesource.com/123503
Reviewed-by: Ben Wagner <bungeman@google.com>
Commit-Queue: Hal Canary <halcanary@google.com>
2018-04-24 19:29:16 +00:00
Cary Clark
6cdb7d3a4c prepare to remove obsolete macros
SkColorSetARGBMacro and SkColorSetARGBInline
are macros which will be deleted. Replace them
with a standard equivalent.

R=scroggo@google.com
Bug: skia:6898
Change-Id: I16e010776e991c19a375d0686ecd1b1cc4c59a9b
Reviewed-on: https://skia-review.googlesource.com/123501
Auto-Submit: Cary Clark <caryclark@skia.org>
Commit-Queue: Leon Scroggins <scroggo@google.com>
Reviewed-by: Leon Scroggins <scroggo@google.com>
2018-04-24 19:19:01 +00:00
Eric Boren
fb20ac4578 [infra] internal_hardware_label is a string now
Thanks, Python.

Bug: skia:7050
Change-Id: I71434effc5da31967190e2eb06bbba2010061e80
Reviewed-on: https://skia-review.googlesource.com/123502
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
2018-04-24 19:14:16 +00:00
Hal Canary
6736236faf include/private/SkTemplates: Cleanup bare pointers.
include/private:
-  SkAutoTArray, SkAutoTMalloc no longer use bare pointers to owned memory,
-   SkTHash and SkAutoTArray are now std::move()able.
-   SkAutoTArray::swap no longer neccesary.
-   SkAutoTMalloc::operator=() defined.

src/pdf:
-   SkPDFCanon and SkPDFObjectSerializer are now std::move()able.
-   `template <class T> static void renew(T* t) { t->~T(); new (t) T; }` is gone.

Change-Id: I2f36a0780c47d1427a85da240121c898387fb4cf
Reviewed-on: https://skia-review.googlesource.com/123401
Reviewed-by: Ben Wagner <bungeman@google.com>
Commit-Queue: Hal Canary <halcanary@google.com>
2018-04-24 19:13:56 +00:00
Greg Daniel
849dce1d7b Update flag checks when validating surface being assigned to proxy.
Bug: skia:7748
Change-Id: Id87c0b1be2efbdefd96740e9591fd102e09b4d95
Reviewed-on: https://skia-review.googlesource.com/123423
Commit-Queue: Greg Daniel <egdaniel@google.com>
Reviewed-by: Robert Phillips <robertphillips@google.com>
2018-04-24 18:59:16 +00:00
Mike Klein
55d330c32d Reland "call skcms_OptimizeForSpeed()"
This is a reland of 3b8feb331a

Original change's description:
> call skcms_OptimizeForSpeed()
> 
> I've guarded src and dst separately, so that we can land,
> rebaseline just the src change, and then later (when it
> does something), rebaseline optimizing dst separately.
> 
> Small threshold tweak to keep a unit test passing.
> 
> Change-Id: I57cc43c54b6065f58fa8f9448ea1d73fc42505f0
> Reviewed-on: https://skia-review.googlesource.com/123181
> Commit-Queue: Mike Klein <mtklein@chromium.org>
> Reviewed-by: Brian Osman <brianosman@google.com>

Change-Id: Ia29b4c941e121486a627ac7221947f4a452211ad
Reviewed-on: https://skia-review.googlesource.com/123480
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
2018-04-24 18:55:36 +00:00
skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com
b14e7b4785 Roll skia/third_party/skcms 8e64fbf..73399c8 (1 commits)
https://skia.googlesource.com/skcms.git/+log/8e64fbf..73399c8

2018-04-24 brianosman@google.com Add inverse tables and approximate curves to Desmos output


The AutoRoll server is located here: https://skcms-skia-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



TBR=stani@google.com

Change-Id: I8914127553d578f51485d1fcca5fd94cb59f0bb6
Reviewed-on: https://skia-review.googlesource.com/123443
Commit-Queue: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
2018-04-24 18:34:16 +00:00
Cary Clark
75acf9f583 update md files
The generated web files have fallen
slightly behind the bookmaker masters,
so bring them up to date.

TBR=caryclark@google.com
No-Try: true
Docs-Preview: https://skia.org/?cl=123460
Bug: skia:6898
Change-Id: Ia630c923ed8784960e85b4ae6edb661c9113d31b
Reviewed-on: https://skia-review.googlesource.com/123460
Commit-Queue: Cary Clark <caryclark@skia.org>
Auto-Submit: Cary Clark <caryclark@skia.org>
Reviewed-by: Cary Clark <caryclark@skia.org>
2018-04-24 18:32:46 +00:00
Kevin Lubick
acd456a620 IWYU for fuzz binary
Bug: skia:
Change-Id: I6d04fad4d5089c97761d6082b6c39f047e90fd52
Reviewed-on: https://skia-review.googlesource.com/123223
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Commit-Queue: Stan Iliev <stani@google.com>
Auto-Submit: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Stan Iliev <stani@google.com>
2018-04-24 18:18:46 +00:00
Hal Canary
fd9bcabca1 sk_tools/Resources: optional SK_TOOLS_REQUIRE_RESOURCES flag
BUG=skia:7842
Change-Id: I1ce7d12308cd8ee101163d73dfc79f2d2155c632
Reviewed-on: https://skia-review.googlesource.com/123425
Auto-Submit: Hal Canary <halcanary@google.com>
Commit-Queue: Florin Malita <fmalita@chromium.org>
Reviewed-by: Florin Malita <fmalita@chromium.org>
2018-04-24 18:08:06 +00:00
skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com
32d19c42a2 Roll skia/third_party/skcms 4028d14..8e64fbf (1 commits)
https://skia.googlesource.com/skcms.git/+log/4028d14..8e64fbf

2018-04-24 brianosman@google.com skcms_EnsureUsableAsDestinationWithSingleCurve


The AutoRoll server is located here: https://skcms-skia-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



TBR=stani@google.com

Change-Id: I4847f6687e95aca7e1b98b9bb24bcd12ed0fa2cd
Reviewed-on: https://skia-review.googlesource.com/123399
Reviewed-by: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
2018-04-24 18:07:33 +00:00
Eric Boren
e9a670045f [infra] Fix missing internal_hardware_label property
Bug: skia:7050
Change-Id: I9fd99f63886c29b42c22d108b5ae29392827dc77
Reviewed-on: https://skia-review.googlesource.com/123427
Auto-Submit: Eric Boren <borenet@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
2018-04-24 17:50:56 +00:00
skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com
fe7e7cbcec Roll skia/third_party/skcms 011b614..4028d14 (1 commits)
https://skia.googlesource.com/skcms.git/+log/011b614..4028d14

2018-04-24 mtklein@chromium.org reduce overhead of profiling code


The AutoRoll server is located here: https://skcms-skia-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



TBR=stani@google.com

Change-Id: I3c9a75e0d51f4380e71d98f5289ab4da1168ab50
Reviewed-on: https://skia-review.googlesource.com/123397
Reviewed-by: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
2018-04-24 16:30:36 +00:00
skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com
eb43fdaaf8 Roll skia/third_party/skcms 5cbdc0a..011b614 (1 commits)
https://skia.googlesource.com/skcms.git/+log/5cbdc0a..011b614

2018-04-24 mtklein@chromium.org gut TF13


The AutoRoll server is located here: https://skcms-skia-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



TBR=stani@google.com

Change-Id: I87e281fc5ac75f11acdcf7d4621d6635836b7a67
Reviewed-on: https://skia-review.googlesource.com/123393
Reviewed-by: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
2018-04-24 15:43:06 +00:00
Ben Wagner
738a25645d Properly restore from image filter save layers.
SkCanvas::internalSaveLayer calls internalSetMatrix to smash the matrix.
SkCanvas::internalRestore tried to restore the state by setting just the
matrix on the canvas. However, this misses restoring the matrix on the
top devices. Correct this by making internalRestore mirror
internalSaveLayer and call internalSetMatrix.

Without this change some draw calls will not respect the matrix
correctly when they follow a draw with an image filter.

Change-Id: If2660cd3799c3050604d9d8754b140507ec3f5e1
Reviewed-on: https://skia-review.googlesource.com/123241
Reviewed-by: Florin Malita <fmalita@chromium.org>
Commit-Queue: Ben Wagner <bungeman@google.com>
2018-04-24 15:26:56 +00:00
Chris Dalton
6f5e77a08f ccpr: Cull extremely thin triangles
When triangles get too thin it's possible for FP round-off error to
actually give us the wrong winding direction, causing rendering
artifacts. This change also allows us to unblacklist ANGLE.

Bug: skia:7805
Bug: skia:7820
Change-Id: Ibaa0f033eba625d720e3a594c4515d8264cc413d
Reviewed-on: https://skia-review.googlesource.com/123262
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Chris Dalton <csmartdalton@google.com>
2018-04-24 15:23:06 +00:00
skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com
b97f28b903 Roll skia/third_party/skcms 6a4194e..5cbdc0a (1 commits)
https://skia.googlesource.com/skcms.git/+log/6a4194e..5cbdc0a

2018-04-24 mtklein@chromium.org build profiling mode into all clang debug builds


The AutoRoll server is located here: https://skcms-skia-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



TBR=stani@google.com

Change-Id: I43af99da817e1850bd4738993c842f077761fd07
Reviewed-on: https://skia-review.googlesource.com/123389
Reviewed-by: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
2018-04-24 14:55:06 +00:00
Kevin Lubick
fffa641896 Make fuzz autodetect file names
e.g.
out/ASAN/fuzz -b /path/to/file

Bug: skia:
Change-Id: I6df370a7f83e8ea8fc8c2dec20834620bc726911
Reviewed-on: https://skia-review.googlesource.com/122901
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
2018-04-24 14:48:37 +00:00
angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com
f50c283f0b Roll third_party/externals/angle2/ b3474d9d7..66410530a (1 commit)
b3474d9d77..66410530a7

$ git log b3474d9d7..66410530a --date=short --no-merges --format='%ad %ae %s'
2018-04-20 lucferron Vulkan: Textures mipmaps support

Created with:
  roll-dep third_party/externals/angle2


The AutoRoll server is located here: https://angle-skia-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE
TBR=stani@google.com

Change-Id: I97fdb7dff17e2bc6264308dc464e94f70351c450
Reviewed-on: https://skia-review.googlesource.com/123388
Reviewed-by: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
2018-04-24 14:27:17 +00:00
Mike Klein
dabf06c0a8 disable skcms on Android framework builds
We need to update BitmapRGBAF16Test.testGetPixel in CTS.
We're getting off-by-a-bit errors when enabling skcms.

I think we allow a per-byte tolerance of 1 in each of red,green,blue?
I'm not convinced the values in the test or the new ones are any more
correct than the others.

Change-Id: I5196f9315aa8187239eabd58e003d4cb6b603e39
Reviewed-on: https://skia-review.googlesource.com/123246
Reviewed-by: Mike Klein <mtklein@google.com>
2018-04-24 12:37:33 +00:00
Mike Klein
af88ec3712 Revert "Add arcs as a specialized geometry to GrShape."
This reverts commit 255bcf57ff.

Reason for revert: layout and scuba image diffs

Original change's description:
> Add arcs as a specialized geometry to GrShape.
> 
> BUG: skia:7794
> 
> Change-Id: I484693711f48e55631732a0f4ee97e2848dec89d
> Reviewed-on: https://skia-review.googlesource.com/122900
> Commit-Queue: Brian Salomon <bsalomon@google.com>
> Reviewed-by: Robert Phillips <robertphillips@google.com>

TBR=bsalomon@google.com,robertphillips@google.com

Change-Id: I9293b8fbb535d940bca5fc30a95908416b9eb7a7
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://skia-review.googlesource.com/123362
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
2018-04-24 12:18:47 +00:00
recipe-roller
01bc273bc5 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
depot_tools:
  https://crrev.com/cb62e48b5424c4bc36b919cc7ed61484599bbc70 Check format of OWNERS files in PRESUBMIT and PanProjectChecks. (ehmaldonado@chromium.org)
  https://crrev.com/4d0f2a33269e456e4897c8ee0b8c750a8c5d8284 cq: start using LUCI downstream testers as an experiment. (tandrii@chromium.org)
recipe_engine:
  https://crrev.com/480046798daeca78c14e4514b25da0c50cf2b680 cq: start using LUCI downstream recipe rollers as an experiment. (tandrii@chromium.org)


TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I1d28eaff9e6165724d848febf48e907a8cfb45ff
Reviewed-on: https://skia-review.googlesource.com/123244
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
2018-04-24 03:09:06 +00:00
Chris Dalton
9e3f578adb Revert "ccpr: Don't preempt the convex path renderer"
This reverts commit 1804b3528c.

Reason for revert: Didn't help

Original change's description:
> ccpr: Don't preempt the convex path renderer
> 
> It seems to perform better on RRects from web pages.
> 
> Bug: skia:7825
> Change-Id: Ibecf33849c6d14e7486d9de740b1cc42f274080f
> Reviewed-on: https://skia-review.googlesource.com/122626
> Reviewed-by: Brian Osman <brianosman@google.com>
> Commit-Queue: Chris Dalton <csmartdalton@google.com>

TBR=brianosman@google.com,csmartdalton@google.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: skia:7825
Change-Id: I06ca833c09f43f4e01989699c88610ae2ef72516
Reviewed-on: https://skia-review.googlesource.com/123381
Reviewed-by: Chris Dalton <csmartdalton@google.com>
Commit-Queue: Chris Dalton <csmartdalton@google.com>
2018-04-24 01:41:46 +00:00