Commit Graph

15417 Commits

Author SHA1 Message Date
mtklein
8aacf20856 Fill SkRRect::fType proactively.
I found no external mentions of SkRRect::kUnknown_Type.

Motivating race found by TSAN:
http://build.chromium.org/p/client.skia/builders/Test-Ubuntu13.10-GCE-NoGPU-x86_64-Release-TSAN-Trybot/builds/48/steps/dm/logs/stdio

BUG=skia:

Review URL: https://codereview.chromium.org/801693003
2014-12-18 13:29:54 -08:00
reed
152d42f628 remove flag (not ready for it yet)
BUG=skia:
TBR=
NOTRY=True

Review URL: https://codereview.chromium.org/803553006
2014-12-18 13:01:40 -08:00
reed
2c770271e6 Revert of enable new gradients + suppress gms for now (patchset #1 id:1 of https://codereview.chromium.org/807513004/)
Reason for revert:
crashy

Original issue's description:
> enable new gradients + suppress gms for now
>
> BUG=skia:
> TBR=
> NOTRY=True
>
> Committed: https://skia.googlesource.com/skia/+/8142a57fa1bf582b66efde276cd43d40c525bc16

TBR=
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Review URL: https://codereview.chromium.org/814963002
2014-12-18 12:59:39 -08:00
reed
8142a57fa1 enable new gradients + suppress gms for now
BUG=skia:
TBR=
NOTRY=True

Review URL: https://codereview.chromium.org/807513004
2014-12-18 12:53:37 -08:00
reed
68331cd92a remove dead code behind SK_SUPPORT_LEGACY_ALLOCPIXELS_BOOL
BUG=skia:

Review URL: https://codereview.chromium.org/814753004
2014-12-18 12:48:16 -08:00
egdaniel
9e4ecdc9f8 Add an InvariantOutput for the XPF.
The Invariant output holds information about final post blended color and other
general information like will it blend with dst. Having this new struct allowed
me to also remove some functions that were previously querying subsets of the
invariant output.

BUG=skia:

Review URL: https://codereview.chromium.org/814933002
2014-12-18 12:44:55 -08:00
reed
caf7e9313b improve precision of gradients (disabled for now)
BUG=skia:2898
TBR=caryclark

Review URL: https://codereview.chromium.org/815623004
2014-12-18 12:43:08 -08:00
joshualitt
695025fe1d rebase
NOTRY=True
TBR=
BUG=skia:

Review URL: https://codereview.chromium.org/798323006
2014-12-18 12:11:41 -08:00
joshualitt
341400ea7b I could create new GMs if you prefer.
BUG=skia:

Review URL: https://codereview.chromium.org/812163002
2014-12-18 11:54:14 -08:00
joshualitt
cecb093334 adding bleed back to ignore
TBR=
NOTRY=True
BUG=skia:

Review URL: https://codereview.chromium.org/810713003
2014-12-18 11:08:48 -08:00
joshualitt
ccd552b007 rebase
TBR=
NOTRY=True
BUG=skia:

Review URL: https://codereview.chromium.org/812423002
2014-12-18 11:00:52 -08:00
bsalomon
309d4d5909 Remove GrCoordTransform::kPosition_CoordSet
Review URL: https://codereview.chromium.org/811373002
2014-12-18 10:17:45 -08:00
reed
a3cbc28e88 remove dead code for SK_SUPPORT_LEGACY_TEXTRENDERMODE
BUG=skia:
TBR=robertphilips

Review URL: https://codereview.chromium.org/812363002
2014-12-18 08:13:03 -08:00
joshualitt
16b2789895 Change to create device coord coordset
BUG=skia:

Review URL: https://codereview.chromium.org/812063002
2014-12-18 07:47:17 -08:00
egdaniel
66644a830f Various complex clip rebases
TBR=
NOTRY=

BUG=skia:

Review URL: https://codereview.chromium.org/806223006
2014-12-18 07:04:12 -08:00
reed
b4a9c8914f rebaseline after perspective/conic fix
BUG=skia:
TBR=
NOTRY=True

Review URL: https://codereview.chromium.org/811383002
2014-12-18 06:40:08 -08:00
bsalomon
3f490a0c01 Fix complexclip3 test on gpu
BUG=skia:3260
R=egdaniel@google.com

Review URL: https://codereview.chromium.org/813653003
2014-12-18 06:20:52 -08:00
tfarina
1348dfd5df Cleanup: Remove a bunch of SkFontHost.h includes (unused).
Nobody that is including SkFontHost is using SkFontHost API, so lets
remove this includes, since the API per se is deprecated.

BUG=None
R=reed@google.com

Review URL: https://codereview.chromium.org/803733006
2014-12-18 05:48:53 -08:00
jvanverth
1334c21eee One more pass at getting half float texture configs correct.
Added in check for sized internal format.
Made choice between RED and ALPHA orthogonal to HALF_FLOAT and
HALF_FLOAT_OES.
Enabled rendertarget support on ES 2.0.

Review URL: https://codereview.chromium.org/805033002
2014-12-18 05:44:55 -08:00
skia.buildbots
eacaa2819d Update SKP version
Automatic commit by the RecreateSKPs bot.

TBR=

Review URL: https://codereview.chromium.org/814633003
2014-12-17 23:06:08 -08:00
tfarina
e3d5c7f5a9 Cleanup: More override fixes.
Fixes errors like:

../../src/gpu/GrGeometryProcessor.h:172:25: error: 'name' overrides a member function but is not marked 'override' [-Werror,-Winconsistent-missing-override]
    virtual const char* name() const = 0;
                            ^
../../include/gpu/GrProcessor.h:66:25: note: overridden virtual function is here
                                virtual const char* name() const = 0;

BUG=skia:3075
TEST=ninja -C out/Debug skia_lib
TBR=mtklein@google.com

Review URL: https://codereview.chromium.org/789343003
2014-12-17 17:50:22 -08:00
joshualitt
602a7428a3 rebase
TBR=
NOTRY=True
BUG=skia:

Review URL: https://codereview.chromium.org/811243002
2014-12-17 17:13:37 -08:00
joshualitt
5531d51ce7 remove view matrix from context
BUG=skia:

Review URL: https://codereview.chromium.org/808703006
2014-12-17 15:50:11 -08:00
reed
1b28a3a489 use conics for addRRect
BUG=skia:

Review URL: https://codereview.chromium.org/792493005
2014-12-17 14:42:09 -08:00
bsalomon
6ae83cf7f6 add inverted path draw cases to complexclip gm
Review URL: https://codereview.chromium.org/809163002
2014-12-17 14:38:49 -08:00
egdaniel
bb63cb7d1c Ignore buggy clip gm on Mac 10.9
TBR=
NOTRY=true

BUG=skia:

Review URL: https://codereview.chromium.org/793403005
2014-12-17 14:03:51 -08:00
bsalomon
3e79124a69 Stop creating GrODS for stencilPath commands.
Review URL: https://codereview.chromium.org/816513003
2014-12-17 13:43:13 -08:00
egdaniel
8750924a14 Add Coverage Drawing XP
BUG=skia:

Review URL: https://codereview.chromium.org/808813002
2014-12-17 13:37:13 -08:00
reed
3739913b6a rebaseline after perspective/conic fix
BUG=skia:
TBR=
NOTRY=True

Review URL: https://codereview.chromium.org/816543002
2014-12-17 13:32:20 -08:00
reed
a816d95b1e version 0 of imgconv tool
BUG=skia:

Review URL: https://codereview.chromium.org/809143002
2014-12-17 13:08:17 -08:00
jvanverth
41bc28843a Rebaseline HD7770 GMs for https://codereview.chromium.org/811133002.
TBR=bensong@google.com

Review URL: https://codereview.chromium.org/808173004
2014-12-17 12:07:21 -08:00
reed
baf9daa809 rebaseline after perspective/conic change
BUG=skia:
TBR=
NOTRY=True

Review URL: https://codereview.chromium.org/812863002
2014-12-17 11:28:35 -08:00
robertphillips
eb3379fe70 Turn off warnings as errors for the debugger
Compiling the debugger on Linux was running afoul of warnings-as-errors

Review URL: https://codereview.chromium.org/812673004
2014-12-17 11:27:47 -08:00
egdaniel
df795036fd Add new complexclip3 gm.
This GM is used to test the combined clipping of a complex clip (packman shape)
and a simple one (circle). We loop over all combinations of clip ops, aa/bw clip,
and inverse/non-inverse clips.

This GM triggers a current bug in the gpu clipping code which fires an assert. Thus
the skipGPU flag is set until that bug is fixed.

BUG=skia:

Review URL: https://codereview.chromium.org/798793003
2014-12-17 11:22:37 -08:00
Brian Salomon
4b0a04fd78 Mark flaky gm as ignore-failure on mac 10.9
BUG=skia:3256

Review URL: https://codereview.chromium.org/803443005
2014-12-17 14:05:17 -05:00
jvanverth
f72b752836 Re-enable default sized formats, handling BGRA exception.
Sized texture formats are accepted by OpenGL desktop and ES 3.0,
except when using BGRA with GL_EXT_texture_format_BGRA8888.
In that case we fall back to using the unsized format.

Review URL: https://codereview.chromium.org/811133002
2014-12-17 10:46:01 -08:00
reed
042a6fe10a rebaseline after perspective/conic fix
BUG=skia:
TBR=
NOTRY=True

Review URL: https://codereview.chromium.org/785333004
2014-12-17 09:47:28 -08:00
bsalomon
1f78c0a2dd Stop calling flushGLState in onStencilPath
Review URL: https://codereview.chromium.org/805293003
2014-12-17 09:43:13 -08:00
reed
438d23c627 remove flags that are now in chrome's userconfig
BUG=skia:

Review URL: https://codereview.chromium.org/809073002
2014-12-17 09:40:50 -08:00
reed
dbf9f1973e rebaseline after perspective fix (using conics)
BUG=skia:
TBR=
NOTRY=True

Review URL: https://codereview.chromium.org/811123003
2014-12-17 09:27:35 -08:00
reed
220f926d9d use conics
BUG=skia:

Review URL: https://codereview.chromium.org/455043002
2014-12-17 08:21:05 -08:00
reed
ed9f7a9220 rebaseline after fix to cornerpatheffect
BUG=skia:
TBR=
NOTRY=True

Review URL: https://codereview.chromium.org/814523004
2014-12-17 07:49:59 -08:00
scroggo
c6b8ffa0ac Fix a case of kPartialSuccess.
Missed in https://codereview.chromium.org/647023006/

When JPEG decoder does not have the remainder of the image, it should
return kPartialSuccess.

BUG:b/17419670
BUG:b/18769124

Review URL: https://codereview.chromium.org/807983002
2014-12-17 06:55:02 -08:00
jvanverth
b270fc105d Rebaseline HD7770 images after sized texture format revert.
TBR=bensong@google.com

Review URL: https://codereview.chromium.org/815463002
2014-12-17 06:34:45 -08:00
reed
2b9445b84e fix end-point and conic bugs in cornerpatheffect
fixes bug in GM/patheffect -- will need to be rebaselined

BUG=skia:

Review URL: https://codereview.chromium.org/803213003
2014-12-17 05:50:55 -08:00
skia.buildbots
ccb28e16fd Update SKP version
Automatic commit by the RecreateSKPs bot.

TBR=

Review URL: https://codereview.chromium.org/813743002
2014-12-17 04:52:31 -08:00
kkinnunen
7445aa7d27 webpages_playback.py: Page sets to use changed telemetry API (AddUserStory)
Make page sets to use telemetry.page.page_set.AddUserStory instead of
AddPage.

BUG=chromium:439512
BUG=skia:3196

NOTRY=true

Review URL: https://codereview.chromium.org/811003002
2014-12-17 04:06:54 -08:00
reed
8b5752443f add arcto patheffect
BUG=skia:
TBR=

Review URL: https://codereview.chromium.org/813513003
2014-12-17 01:47:32 -08:00
fmalita
287ccfece6 Whitespace change
To re-trigger the build bots.

TBR=bensong@google.com
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/811623004
2014-12-17 01:25:33 -08:00
robertphillips
a86a233de5 Give the hoisting surfaces surface props
This mimics how layers are set up in SkGpuDevice::onCreateCompatibleDevice

Review URL: https://codereview.chromium.org/809823003
2014-12-16 14:25:08 -08:00