Commit Graph

7238 Commits

Author SHA1 Message Date
scroggo@google.com
8b5ff5cc0c Fix build (warning).
BUG=

Review URL: https://codereview.chromium.org/14789014

git-svn-id: http://skia.googlecode.com/svn/trunk@8998 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-05-03 20:21:17 +00:00
scroggo@google.com
7e6fceeffd Test region decoding in skimage, plus fixes.
Add tests in skimage to perform region decoding. Write out a
PNG of the region as well as a bitmap obtained with extractSubset
for comparison.

Rename decodeRegion to decodeSubset, so it will not be confused
with SkRegion. (Leave a function called decodeRegion which calls
decodeSubset.)

Clean up some comments.

Use png_set_interlaced_pass instead of modifying pass directly.

Make some changes to region decoding to fix problems I discovered
during testing:

Only call getAddr within a valid range.
Check for a NULL fInputStream.
Return a boolean for whether cropBitmap succeeded.
In cropBitmap, do not attempt to draw to a bitmap to an Index8
bitmap, which crashes. Use extractSubset instead.
Remove an assert.

R=djsollen@google.com

Review URL: https://codereview.chromium.org/14567011

git-svn-id: http://skia.googlecode.com/svn/trunk@8996 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-05-03 20:14:28 +00:00
reed@google.com
dc9cdf8d49 add (temporary) diagnostic code for normalize test
git-svn-id: http://skia.googlecode.com/svn/trunk@8994 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-05-03 18:11:00 +00:00
reed@google.com
c9f81661c1 add endian tests (reviewed by bungeman)
git-svn-id: http://skia.googlecode.com/svn/trunk@8993 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-05-03 18:06:31 +00:00
epoger@google.com
b4ca46d748 SkBitmapHasher: use 64-bit-truncated MD5 instead of 64-bit CityHash
BUG=https://code.google.com/p/skia/issues/detail?id=1257

(if we change our mind within the next few days, we can toggle the
BITMAPHASHER_USES_TRUNCATED_MD5 #ifdef ; at some point, we'll remove that
option so we can delete our CityHash implementation entirely)

R=bungeman@google.com

Review URL: https://codereview.chromium.org/14054012

git-svn-id: http://skia.googlecode.com/svn/trunk@8992 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-05-03 17:35:39 +00:00
reed@google.com
25720b4d7e trick the compiler into not knowning that I will generate an overflow
(which is the point of the test). This avoids a warning, which breaks
our bots.



git-svn-id: http://skia.googlecode.com/svn/trunk@8991 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-05-03 16:30:44 +00:00
bsalomon@google.com
292ce73728 Add benches for all xfermodes.
R=reed@google.com

Review URL: https://codereview.chromium.org/14818005

git-svn-id: http://skia.googlecode.com/svn/trunk@8990 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-05-03 16:28:33 +00:00
reed@google.com
5a5fe58595 change setLength and Normalize to handle when mag2 overflows a float, but the
actual lenght does not.

R=caryclark@google.com

Review URL: https://codereview.chromium.org/14838006

git-svn-id: http://skia.googlecode.com/svn/trunk@8988 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-05-03 15:59:39 +00:00
djsollen@google.com
c772540b4c fix copy-paste error in setup script
BUG=

Review URL: https://codereview.chromium.org/14646027

git-svn-id: http://skia.googlecode.com/svn/trunk@8985 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-05-03 14:21:35 +00:00
djsollen@google.com
d165de44c8 Check for third_party deps before compiling on android
R=borenet@google.com

Review URL: https://codereview.chromium.org/14803004

git-svn-id: http://skia.googlecode.com/svn/trunk@8984 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-05-03 14:12:03 +00:00
djsollen@google.com
403b90e061 Exclude angle dependency on non-angle builds
R=bsalomon@google.com

Review URL: https://codereview.chromium.org/14200018

git-svn-id: http://skia.googlecode.com/svn/trunk@8983 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-05-03 14:00:34 +00:00
sugoi@google.com
6ba0b0f9ad This may potentially fix a chromium issue and shouldn't hurt, so if anyone agrees that this fix should be harmless, we can try merging it in to see if it's enough to fix "Invalid pointer write in GrRenderTarget::onRelease".
R=bsalomon@google.com, robertphillips@google.com

Review URL: https://codereview.chromium.org/14607003

git-svn-id: http://skia.googlecode.com/svn/trunk@8982 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-05-03 13:52:32 +00:00
bsalomon@google.com
6b0cf0273f Add support for GL_*_shader__framebuffer_fetch
R=robertphillips@google.com

Review URL: https://codereview.chromium.org/14875002

git-svn-id: http://skia.googlecode.com/svn/trunk@8980 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-05-03 13:35:14 +00:00
robertphillips@google.com
dfa1ce027f Win7 gpu performance trigger rebaseline (tabl_mlb)
(SkipBuildbotRuns)



git-svn-id: http://skia.googlecode.com/svn/trunk@8978 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-05-03 13:12:48 +00:00
reed@google.com
0889f682fb add bench for SkPoint::normalize()
git-svn-id: http://skia.googlecode.com/svn/trunk@8977 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-05-03 12:56:39 +00:00
skia.committer@gmail.com
2fd42c471c Sanitizing source files in Housekeeper-Nightly
git-svn-id: http://skia.googlecode.com/svn/trunk@8976 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-05-03 07:01:00 +00:00
reed@google.com
f77b35d86a add HACK_COLORGLYPHS (disabled) to test colorglyphs
git-svn-id: http://skia.googlecode.com/svn/trunk@8972 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-05-02 20:39:44 +00:00
reed@google.com
a65a681d43 Cast our LOGFONTs in our enumerator callbacks to ENUMLOGFONTEX, so we
can get at the style-names.



git-svn-id: http://skia.googlecode.com/svn/trunk@8971 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-05-02 19:47:24 +00:00
bsalomon@google.com
00142c4405 Fix GL extension printing on core profiles.
R=robertphillips@google.com

Review URL: https://codereview.chromium.org/14864002

git-svn-id: http://skia.googlecode.com/svn/trunk@8970 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-05-02 19:42:54 +00:00
reed@google.com
5bdfb331ac Detect color masks, and divert to draw-sprite instead of maskblitters.
Review URL: https://codereview.chromium.org/14637007

git-svn-id: http://skia.googlecode.com/svn/trunk@8967 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-05-02 18:55:44 +00:00
djsollen@google.com
ce3d223cfe update recommended gclient config for android
Review URL: https://codereview.chromium.org/14857007

git-svn-id: http://skia.googlecode.com/svn/trunk@8964 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-05-02 18:42:10 +00:00
epoger@google.com
fdea3259d0 GM: fix --mismatchPath option
(currently, it doesn't actually write any files!)

TBR=rmistry

Review URL: https://codereview.chromium.org/14855005

git-svn-id: http://skia.googlecode.com/svn/trunk@8963 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-05-02 18:24:03 +00:00
robertphillips@google.com
4b140b5fbe Add geometry-based rotated AA rect drawing path
https://codereview.chromium.org/14854005/



git-svn-id: http://skia.googlecode.com/svn/trunk@8961 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-05-02 17:13:13 +00:00
robertphillips@google.com
b19cb7f367 Axis aligned shader-based rect drawing
https://codereview.chromium.org/14314004/



git-svn-id: http://skia.googlecode.com/svn/trunk@8960 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-05-02 15:37:20 +00:00
caryclark@google.com
89d1827fa0 fix error that ran no tests if no options were passed
git-svn-id: http://skia.googlecode.com/svn/trunk@8959 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-05-02 14:23:07 +00:00
bungeman@google.com
4bbc524ca4 TTC support for DirectWrite.
https://codereview.chromium.org/14600009/


git-svn-id: http://skia.googlecode.com/svn/trunk@8958 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-05-02 14:01:36 +00:00
robertphillips@google.com
370d835c1c Add new bench for rotated rects (aarects_rotated)
https://codereview.chromium.org/14688007/



git-svn-id: http://skia.googlecode.com/svn/trunk@8957 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-05-02 13:57:52 +00:00
commit-bot@chromium.org
c1c5695f8f Support for libpng > 1.2.
* Add conditional defines for deprecated NULL type casts.
  * Use wrapper functions for accessing png_structp & png_infop fields
    (direct access is deprecated).

Tested on Fedora 17 (libpng 1.5) and Ubuntu 12.04 (libpng 1.2).

Note: there is one png_structp direct field acces left in
SkPNGImageDecoder::onDecodeRegion() for which libpng does not provide a
wrapper method (png_ptr->pass = 0). That should be OK for now as the code
is only enabled when SK_BUILD_FOR_ANDROID is set, and the Android libpng
version is striclty controlled. But it may become an issue in the future
when/if Android decides to update libpng, so we should investigate a
solution.


R=scroggo@google.com, reed@google.com, djsollen@google.com

Author: fmalita@google.com

Review URL: https://chromiumcodereview.appspot.com/14645018

git-svn-id: http://skia.googlecode.com/svn/trunk@8956 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-05-02 13:41:34 +00:00
caryclark@google.com
b631eec0e6 Allow unit tests to include or exclude test sets.
This modifies the command line to take test
matches of the form:

   --match [or -m] [~][^]match[$] [~][^]match[$] ...

   ~ causes a matching test to always be skipped

   ^ requires the start of the test to match

   $ requires the end of the test to match

   ^ and $ requires an exact match


If a test does not match any list entry,
it is skipped unless some list entry starts with ~
Review URL: https://codereview.chromium.org/14650009

git-svn-id: http://skia.googlecode.com/svn/trunk@8955 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-05-02 13:14:40 +00:00
commit-bot@chromium.org
37d883d9d3 Disable AA for ovals and roundrects if MSAA is enabled.
Also remove GrPaint from a number of methods -- we only
use it to get the AA state.

R=bsalomon@google.com

Author: jvanverth@google.com

Review URL: https://chromiumcodereview.appspot.com/14109033

git-svn-id: http://skia.googlecode.com/svn/trunk@8954 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-05-02 13:11:22 +00:00
jvanverth@google.com
f6a90332ae Add msaa configs to bench_pictures.
Enables msaa4 and msaa16 configs in bench_pictures and render_pictures (and
anything else that may use PictureRenderer).

Review URL: https://codereview.chromium.org/14544007/


git-svn-id: http://skia.googlecode.com/svn/trunk@8952 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-05-02 12:39:37 +00:00
djsollen@google.com
4b32101a15 Update DEPS and GYP to use the copy of Android in platform_tools.
R=borenet@google.com

Review URL: https://codereview.chromium.org/13898019

git-svn-id: http://skia.googlecode.com/svn/trunk@8951 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-05-02 12:27:21 +00:00
borenet@google.com
99da601032 Fix submit_try for new builder names
(SkipBuildbotRuns)
Unreviewed.

Review URL: https://codereview.chromium.org/14611009

git-svn-id: http://skia.googlecode.com/svn/trunk@8950 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-05-02 12:14:35 +00:00
skia.committer@gmail.com
d2ada98934 Sanitizing source files in Housekeeper-Nightly
git-svn-id: http://skia.googlecode.com/svn/trunk@8948 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-05-02 07:01:25 +00:00
robertphillips@google.com
879f6c7c0c Hamfistedly removed core dependence on images
https://codereview.chromium.org/14805002/



git-svn-id: http://skia.googlecode.com/svn/trunk@8947 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-05-02 00:12:03 +00:00
junov@chromium.org
b516a41779 Build fix for SurfaceTest on non-gpu platforms
Unreviewed

git-svn-id: http://skia.googlecode.com/svn/trunk@8946 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-05-01 22:49:59 +00:00
junov@chromium.org
da90474b5f Adding public API method on SkImage for extracting the GPU texture handle.
TEST=Surface unit test

Review URL: https://codereview.chromium.org/14646007

git-svn-id: http://skia.googlecode.com/svn/trunk@8945 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-05-01 22:38:16 +00:00
commit-bot@chromium.org
3dab1ff4a3 Whitespace change to test commit queue. (SkipBuildbotRuns)
R=borenet@google.com

Author: rmistry@google.com

Review URL: https://chromiumcodereview.appspot.com/14772006

git-svn-id: http://skia.googlecode.com/svn/trunk@8944 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-05-01 21:50:53 +00:00
scroggo@google.com
8244998dd3 Build fix attempt number 2.
Review URL: https://codereview.chromium.org/14646025

git-svn-id: http://skia.googlecode.com/svn/trunk@8943 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-05-01 21:40:58 +00:00
scroggo@google.com
1be4ec9f4f Fix the build.
Remove an unused function warning.

Review URL: https://codereview.chromium.org/14785008

git-svn-id: http://skia.googlecode.com/svn/trunk@8942 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-05-01 21:27:16 +00:00
scroggo@google.com
c4ebdb03de Force linking with image decoders for images project.
Previously, each tool that wanted to use image decoders
but did not specifically reference them had to create a
dummy function that references them in order to ensure
they are not stripped by the linker.

Instead of making each tool reference each image decoder,
do it once in SkImageDecoder.cpp. Now each tool will have
image decoders linked in, assuming it includes the images
project.

This fixes a bug where SKPs with encoded data could not
be read by bench_ or render_pictures.

R=djsollen@google.com, robertphillips@google.com

Review URL: https://codereview.chromium.org/14678003

git-svn-id: http://skia.googlecode.com/svn/trunk@8941 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-05-01 21:17:27 +00:00
fmalita@google.com
22eb7944e0 SkOpSegment.cpp gcc 4.7 build failure.
SkOpSegment.cpp:2240:5: error: ordered comparison of pointer with integer zero

Caught by gcc 4.7 -Werror=extra.

R=caryclark@google.com

Review URL: https://codereview.chromium.org/14770005

git-svn-id: http://skia.googlecode.com/svn/trunk@8940 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-05-01 20:35:51 +00:00
bsalomon@google.com
347c382d58 Add support for GL_EXT_multisampled_render_to_texture.
R=robertphillips@google.com

Review URL: https://codereview.chromium.org/14091008

git-svn-id: http://skia.googlecode.com/svn/trunk@8939 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-05-01 20:10:01 +00:00
rmistry@google.com
8fc729f8a2 Housekeeper should not fail when skia-autogen is reset.
Created to fix https://code.google.com/p/skia/issues/detail?id=1269 : UpdateDoxygen and UploadDoxygen steps fail when skia-autogen repository is reset. 

(SkipBuildbotRuns)

R=borenet@google.com

Review URL: https://codereview.chromium.org/14772003

git-svn-id: http://skia.googlecode.com/svn/trunk@8935 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-05-01 14:47:03 +00:00
bungeman@google.com
7103344b64 Add FontMgr to DirectWrite.
https://codereview.chromium.org/14314008/


git-svn-id: http://skia.googlecode.com/svn/trunk@8934 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-05-01 14:21:20 +00:00
borenet@google.com
a0eca26ac0 Whitespace change to trigger rebuilds
git-svn-id: http://skia.googlecode.com/svn/trunk@8931 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-04-30 19:45:48 +00:00
borenet@google.com
ffca502023 Resubmit r8929 with the duplicated change in trunk/platform_tools/android
Unreviewed.
(SkipBuildbotRuns)

Review URL: https://codereview.chromium.org/14652007

git-svn-id: http://skia.googlecode.com/svn/trunk@8930 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-04-30 16:37:30 +00:00
borenet@google.com
025f09afc3 Whitespace change to trigger rebuilds after builder name change
git-svn-id: http://skia.googlecode.com/svn/trunk@8925 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-04-30 12:43:07 +00:00
borenet@google.com
dc588d60fe Whitespace change to trigger rebuilds after builder name change
git-svn-id: http://skia.googlecode.com/svn/trunk@8922 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-04-30 12:10:45 +00:00
borenet@google.com
e6598a04a7 Fix builder name references
... as a result of https://codereview.chromium.org/14517004/
(SkipBuildbotRuns)

R=bensong@google.com, rmistry@google.com, senorblanco@chromium.org

Review URL: https://codereview.chromium.org/14544003

git-svn-id: http://skia.googlecode.com/svn/trunk@8921 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-04-30 12:02:32 +00:00