Adds a prebuilt MoltenVK framework asset from:
KhronosGroup/MoltenVK.git:0279543e0bb561f8d0166d4030481136bc914fec
And creates bots that use it.
Bug: skia:
Change-Id: I081b2745c41a25de9ecd94a5363f4fb13b120215
Reviewed-on: https://skia-review.googlesource.com/128646
Commit-Queue: Chris Dalton <csmartdalton@google.com>
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
Should not take up much capacity since it only runs once a day.
Bug: skia:7917
Change-Id: I6e489341032ef40df8cedae4e92c5f00d9a2df91
Reviewed-on: https://skia-review.googlesource.com/128405
Commit-Queue: Ravi Mistry <rmistry@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
Bug: skia:6473
Change-Id: If145e2c29ddafdafaf9b8ed3fecbd6a6de31ac0a
Reviewed-on: https://skia-review.googlesource.com/128481
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
Bug: skia:6473
Change-Id: I89b384668a6a45eaae9995ad8f7b404a1b7f9824
Reviewed-on: https://skia-review.googlesource.com/128318
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
https://skia-review.googlesource.com/c/skia/+/127325 added a couple new
configs that caused 32-bit MSVC Test bots to be quite a bit slower.
After discussion with mtklein, we probably only want to add the more
esoteric configs for 64-bit GCE bots.
No-Try: true
Change-Id: I04e78679c43b380173dce1ea718df5d897e875b7
Reviewed-on: https://skia-review.googlesource.com/128180
Commit-Queue: Mike Klein <mtklein@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
Auto-Submit: Ben Wagner <benjaminwagner@google.com>
Bug: skia:6473
Change-Id: I67b0dbf6dba26233df1d8e44f3e2f69ca0cc9d3e
Reviewed-on: https://skia-review.googlesource.com/128320
Commit-Queue: Eric Boren <borenet@google.com>
Reviewed-by: Stephan Altmueller <stephana@google.com>
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
Bug: skia:7917
Change-Id: Ie76c73c5b8ea24ca0ac54e79ad7597fdac19d860
Reviewed-on: https://skia-review.googlesource.com/128011
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Ravi Mistry <rmistry@google.com>
Change-Id: I9d9d34f1b663a06605eddeacd945517c3e880f4f
Reviewed-on: https://skia-review.googlesource.com/128016
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Mike Klein <mtklein@chromium.org>
We haven't done this in a while.
The only interesting change I've noticed so far is that we no longer
need to link libandroid_support when targeting API 21+.
Change-Id: I6506fbe7bd02534f1ea136f2164acab7f44c29e0
Reviewed-on: https://skia-review.googlesource.com/128009
Reviewed-by: Derek Sollenberger <djsollen@google.com>
Commit-Queue: Mike Klein <mtklein@chromium.org>
Bug: skia:6473
Change-Id: If1d6e1f64ec53624e7b540abd9d8a61cc82c4e0a
Reviewed-on: https://skia-review.googlesource.com/125947
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
This is mostly to pick up new warnings before chromium complains about
them.
Change-Id: I69a0c3da63398f98d3f45b0993ed3325c0edae27
Reviewed-on: https://skia-review.googlesource.com/127395
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
Code:
- Add a non-linear blending bit and makeNonlinearBlending()
to SkColorSpace
- remove enough F16=linear checks to make it possible to
create surfaces and encode pngs with nonlinear F16
Testing:
- add "esrgb" software config to DM, run it
- add "srgbnl" software config, run it
- deemphasize importance of "srgb" config on bots
- update unit tests to reflect relaxed F16 constraints
- add a new unit test file with _really_ basic tests,
and a new unit test that's not working yet
Bug: skia:7942
Change-Id: I8ac042bdf9f3d791765393b68fd9256375184d83
Reviewed-on: https://skia-review.googlesource.com/127325
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Mike Klein <mtklein@chromium.org>
Coverage doesn't seem to deal well with multiple threads. Using 2-core
VMs is faster than using 64-core VMs.
On the other hand, the Coverage Upload task performs much better on a
64-core VM.
Bug: skia:7415
No-Try: true
Change-Id: Ieb58fc47970dd66fa64cf6a8c9de1f9236e2f3a0
Reviewed-on: https://skia-review.googlesource.com/127053
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
Auto-Submit: Ben Wagner <benjaminwagner@google.com>
Reviewed-by: Ravi Mistry <rmistry@google.com>
Don't run them on non-GCE bots either.
Bug: skia:
Change-Id: I15f9a1b7e74eb89a5d580d4e5f82be6e27335600
Reviewed-on: https://skia-review.googlesource.com/126501
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
This is a stop-gap measure.
Bug: skia:7838#c20
Change-Id: Ib9af9aefa4327d24f66f95d9a82ee53c19733524
Reviewed-on: https://skia-review.googlesource.com/126461
Reviewed-by: Mike Klein <mtklein@google.com>
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
Bug: skia:7415, skia:7416
Change-Id: Ibdd391dce62ff16bfc7fa8d860c3cbcaddab7c4d
Reviewed-on: https://skia-review.googlesource.com/124340
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
Each recipe now includes its own setup steps.
Bug: skia:6473
Change-Id: I97eab2cd63f5004c07408e844cbbed735aac355f
Reviewed-on: https://skia-review.googlesource.com/125660
Commit-Queue: Eric Boren <borenet@google.com>
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
Bug: skia:7890
Change-Id: I8322b145800dc41ac59322e89804ff9356d8e767
Reviewed-on: https://skia-review.googlesource.com/125864
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
We need to do some refactoring to remove the repository hack for
cross-repo tryjobs.
Bug: skia:6473
Change-Id: Ie96fba75f6f1752575a4c7cc5b0208a37f0bd73d
Reviewed-on: https://skia-review.googlesource.com/125724
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
Bug: skia:
Change-Id: Ice96cc476b8f022fea250c88c1ec16de6482c704
Reviewed-on: https://skia-review.googlesource.com/124984
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Bug: skia:
Change-Id: Icf90148fadb2293c300962bdf3551c0a9cf1aee0
Reviewed-on: https://skia-review.googlesource.com/124811
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
Bug: skia:
Change-Id: I9e75a703c7063e8a74b7469507f87b44a52c07b3
Reviewed-on: https://skia-review.googlesource.com/124641
Reviewed-by: Kevin Lubick <kjlubick@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
Bug: skia:7883
Change-Id: Id363d59d2466c3f4fae8a79e6ad9e6c270e445ae
Reviewed-on: https://skia-review.googlesource.com/124403
Commit-Queue: Eric Boren <borenet@google.com>
Commit-Queue: Yuqian Li <liyuqian@google.com>
Auto-Submit: Eric Boren <borenet@google.com>
Reviewed-by: Yuqian Li <liyuqian@google.com>
This reverts commit 01d3eb64e7.
Bug: skia:
Change-Id: Ic05b89009eb59a231488bef382dd232a50d2b00f
Reviewed-on: https://skia-review.googlesource.com/124260
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
This reverts commit e033e969ca.
Reason for revert: Should be fast now
Original change's description:
> Remove Android compile bot from the CQ
>
> NoTry: True
> Bug: skia:7834
> Change-Id: Ia38a800da098101effb6804118ccf4b0a0a93c72
> Reviewed-on: https://skia-review.googlesource.com/122945
> Commit-Queue: Ravi Mistry <rmistry@google.com>
> Auto-Submit: Ravi Mistry <rmistry@google.com>
> Reviewed-by: Eric Boren <borenet@google.com>
TBR=borenet@google.com,rmistry@google.com
# Not skipping CQ checks because original CL landed > 1 day ago.
NoTry: true
Bug: skia:7815
Change-Id: I55bba2de4bbff904b92b99802f13c9de55bc9191
Reviewed-on: https://skia-review.googlesource.com/124300
Auto-Submit: Ravi Mistry <rmistry@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
Reviewed-by: Ravi Mistry <rmistry@google.com>
Commit-Queue: Ravi Mistry <rmistry@google.com>
This is in preparation of assigning bots either "small" or "large" GCE
machines.
Bug: skia:7415, skia:7416
Change-Id: I82b6fe454ba3622ef8a9d515dc3e72362dd30ee5
Reviewed-on: https://skia-review.googlesource.com/124183
Commit-Queue: Eric Boren <borenet@google.com>
Auto-Submit: Ben Wagner <benjaminwagner@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
This reverts commit e8615f969e.
Reason for revert: Causing CommandBuffer builds to time out
Original change's description:
> [recipes] Use named caches for git and workdirs
>
> Bug: skia:
> Change-Id: Iaf3d190252c9483c8b9e58a3ab0305db4173cc1c
> Reviewed-on: https://skia-review.googlesource.com/123929
> Commit-Queue: Eric Boren <borenet@google.com>
> Reviewed-by: Ben Wagner <benjaminwagner@google.com>
----------------
Revert "[infra] Fix missing cache for Bookmaker"
This reverts commit d19f039a16.
Reason for revert: Need to revert https://skia-review.googlesource.com/123929
Original change's description:
> [infra] Fix missing cache for Bookmaker
>
> Bug: skia:
> Change-Id: I12d42fa1bb364ea6c75865f72143daf92b8c12c3
> Reviewed-on: https://skia-review.googlesource.com/124052
> Reviewed-by: Ben Wagner <benjaminwagner@google.com>
> Commit-Queue: Eric Boren <borenet@google.com>
----------------
Revert "Fix missing/duplicate named caches"
This reverts commit 0820a6fb69.
Reason for revert: Need to revert https://skia-review.googlesource.com/123929
Original change's description:
> Fix missing/duplicate named caches
>
> Fixes issue with https://skia-review.googlesource.com/c/skia/+/123929
>
> No-Try: true
> Change-Id: I582b2bba67b8b257f35c5b85ccfe6e6304ff7a7c
> Reviewed-on: https://skia-review.googlesource.com/124180
> Commit-Queue: Ben Wagner <benjaminwagner@google.com>
> Auto-Submit: Ben Wagner <benjaminwagner@google.com>
> Reviewed-by: Ravi Mistry <rmistry@google.com>
----------------
TBR=borenet@google.com,benjaminwagner@google.com,rmistry@google.com
Change-Id: Id8443ad9dc50f018251a6b6892b06fe256e6c578
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: skia:
Reviewed-on: https://skia-review.googlesource.com/124203
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
Change-Id: I6b8a16dd6aa1d188a46ca1bdf82c4023d6bab21a
Reviewed-on: https://skia-review.googlesource.com/124043
Commit-Queue: Eric Boren <borenet@google.com>
Auto-Submit: Ben Wagner <benjaminwagner@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
Bug: skia:
Change-Id: I12d42fa1bb364ea6c75865f72143daf92b8c12c3
Reviewed-on: https://skia-review.googlesource.com/124052
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
Bug: skia:
Change-Id: Iaf3d190252c9483c8b9e58a3ab0305db4173cc1c
Reviewed-on: https://skia-review.googlesource.com/123929
Commit-Queue: Eric Boren <borenet@google.com>
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
Automatic commit by the RecreateSKPs bot.
TBR=rmistry@google.com
NO_MERGE_BUILDS
Change-Id: I3d3d0fb933915f79bf993bf6734e1bdf0dfd52f9
Reviewed-on: https://skia-review.googlesource.com/123909
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: Eric Boren <borenet@google.com>
Bug: skia:7833, skia:7050
Change-Id: I8272e4b0beaed2a56260546f4a599a4586c71792
Reviewed-on: https://skia-review.googlesource.com/123921
Reviewed-by: Ravi Mistry <rmistry@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
This causes it to never get triggered automatically, so it will only run
as a try job or when force-triggered.
Caveat: if the job is defined on non-master branches, it will still
trigger for those branches.
Bug: skia:
Change-Id: Idff63bd22536b21ec21eb4b569cc392642297d7b
Reviewed-on: https://skia-review.googlesource.com/123923
Reviewed-by: Ravi Mistry <rmistry@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
Bug: skia:
Change-Id: If01c10c21477bd61c4ec1d4f59921745eb3bf494
Reviewed-on: https://skia-review.googlesource.com/123622
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
Bug: skia:
Change-Id: Icd537f098742a89469e9165e14b230e769247e54
Reviewed-on: https://skia-review.googlesource.com/123563
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Change-Id: Ib7a8205992c6c1f4d93448afe54468f77511f1f0
Reviewed-on: https://skia-review.googlesource.com/123585
Auto-Submit: Ben Wagner <benjaminwagner@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
Thanks, Python.
Bug: skia:7050
Change-Id: I71434effc5da31967190e2eb06bbba2010061e80
Reviewed-on: https://skia-review.googlesource.com/123502
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
Bug: skia:7050
Change-Id: I9fd99f63886c29b42c22d108b5ae29392827dc77
Reviewed-on: https://skia-review.googlesource.com/123427
Auto-Submit: Eric Boren <borenet@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
This reverts commit ea51393ba9.
Reason for revert: try again after many fixes of the threaded backend
Original change's description:
> Revert "Exercise the threaded backend in test bots"
>
> This reverts commit a39991ebd7.
>
> Reason for revert: Random bots timeout
>
> Original change's description:
> > Exercise the threaded backend in test bots
> >
> > We can't draw everything correctly now, but it's at least not crashing.
> >
> > The draw_to_canvas is modified by adding flush because now the raster
> > canvas also needs flush like GPU canvases because of the threaded
> > backend. (Previously, AndroidCodecSrc vetoed GPU (non-raster) sink
> > and that's why it was not crashing.)
> >
> >
> > Bug: skia:
> > Change-Id: I222d706c33e15326e1b97d6bef6c46b8c35cebfd
> > Reviewed-on: https://skia-review.googlesource.com/118886
> > Reviewed-by: Kevin Lubick <kjlubick@google.com>
> > Commit-Queue: Yuqian Li <liyuqian@google.com>
>
> TBR=kjlubick@google.com,stephana@google.com,liyuqian@google.com
>
> Change-Id: Ib1089d937b6e25cc39d90ad4de35b3a4c406f6b1
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: skia:
> Reviewed-on: https://skia-review.googlesource.com/119100
> Reviewed-by: Yuqian Li <liyuqian@google.com>
> Commit-Queue: Yuqian Li <liyuqian@google.com>
TBR=kjlubick@google.com,stephana@google.com,liyuqian@google.com
# Not skipping CQ checks because original CL landed > 1 day ago.
Bug: skia:7838
Change-Id: I1405212204bf694b2f31dfc38154759e1d3e363f
Reviewed-on: https://skia-review.googlesource.com/121680
Commit-Queue: Yuqian Li <liyuqian@google.com>
Reviewed-by: Yuqian Li <liyuqian@google.com>
Bug: skia:7837
Change-Id: Ic7348268da5d131504e5a6cf53534d3a982422c7
Reviewed-on: https://skia-review.googlesource.com/123101
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>
Bug: skia:7835
Change-Id: Iec9469799121f435670c5a3841707fe6199066c5
Reviewed-on: https://skia-review.googlesource.com/122954
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>
Bug: skia:
Change-Id: I3dfda2b49917079350b89d739ba6e00fd12c20f1
Reviewed-on: https://skia-review.googlesource.com/122300
Auto-Submit: Eric Boren <borenet@google.com>
Commit-Queue: Ravi Mistry <rmistry@google.com>
Reviewed-by: Ravi Mistry <rmistry@google.com>
NoTry: True
Bug: skia:7834
Change-Id: Ia38a800da098101effb6804118ccf4b0a0a93c72
Reviewed-on: https://skia-review.googlesource.com/122945
Commit-Queue: Ravi Mistry <rmistry@google.com>
Auto-Submit: Ravi Mistry <rmistry@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
It's perma-failing, and it doesn't work with Kitchen due to the new
service account not being authorized. Rather than spend the energy to
fix the service account (and move to an internal repo) I'll just delete
it since it's blocked on a low priority bug with an unknown ETA.
Bug: skia:
Change-Id: I04636fda334f8a878bde2612b3edad65d81986dc
Reviewed-on: https://skia-review.googlesource.com/122943
Reviewed-by: Ravi Mistry <rmistry@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
Although we will support threaded generation of SW masks in DDL mode, this more closely matches Chrome's behavior
Change-Id: I28596f66693e3daa941c3dbd974a8d33f4561c16
Reviewed-on: https://skia-review.googlesource.com/122789
Reviewed-by: Greg Daniel <egdaniel@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>
The psuedo-tty allocation seems to have been wrong and switching
to Kitchen exacerbated the matter.
Bug: skia:
Change-Id: Ie44d3952383d89d398722837e7bbc51798e5833e
Reviewed-on: https://skia-review.googlesource.com/122304
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
Auto-Submit: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
Bug: skia:7050
Change-Id: Ie262788b02f83d945455fa0cad8f5fe737a1cd4a
Reviewed-on: https://skia-review.googlesource.com/122303
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
Bug: skia:7050
Change-Id: Icf0bcfbbc505c90a4e8cee7437037a3037bdf33b
Reviewed-on: https://skia-review.googlesource.com/121781
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
Bug: skia:7751
Change-Id: Ic76d3bf3f87b37e162df4e519b2b176a887d447f
Reviewed-on: https://skia-review.googlesource.com/121941
Reviewed-by: Robert Phillips <robertphillips@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Greg Daniel <egdaniel@google.com>
This fixes problems with Upload- tasks which just prefix other types of
task names.
Bug: skia:
Change-Id: Icdbcfc5a889e821c6923f635eae0744c3cb0133c
Reviewed-on: https://skia-review.googlesource.com/121786
Commit-Queue: Eric Boren <borenet@google.com>
Reviewed-by: Ravi Mistry <rmistry@google.com>
This reverts commit f39bbe5a31.
Reason for revert: Broke lots of bots
Original change's description:
> Reland "[infra] Run recipes through Kitchen"
>
> Bug: skia:7050
> Change-Id: I331014c408dd5b6f7baafd78ffd12f1235c5bfe7
> Reviewed-on: https://skia-review.googlesource.com/121481
> Commit-Queue: Eric Boren <borenet@google.com>
> Reviewed-by: Ben Wagner <benjaminwagner@google.com>
> Reviewed-by: Ravi Mistry <rmistry@google.com>
TBR=borenet@google.com,benjaminwagner@google.com,rmistry@google.com
Change-Id: I4548c66a9cb0b4f105e2bc3b1c7185d14549172f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: skia:7050
Reviewed-on: https://skia-review.googlesource.com/121463
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
Bug: skia:7050
Change-Id: I331014c408dd5b6f7baafd78ffd12f1235c5bfe7
Reviewed-on: https://skia-review.googlesource.com/121481
Commit-Queue: Eric Boren <borenet@google.com>
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
Reviewed-by: Ravi Mistry <rmistry@google.com>
Bug: skia:7050
Change-Id: I50632444eb4ca7f9ae2b1b30b766e531092ccad4
Reviewed-on: https://skia-review.googlesource.com/82500
Commit-Queue: Eric Boren <borenet@google.com>
Reviewed-by: Ravi Mistry <rmistry@google.com>
Bug: skia:6687
Change-Id: I4244b6345da5edd1ac6fe2225ed8c109a6e66a66
Reviewed-on: https://skia-review.googlesource.com/121347
Reviewed-by: Herb Derby <herb@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
Bug: skia:
Change-Id: I625b46e197ce1bef47aa73f7e7e419cec2450735
Reviewed-on: https://skia-review.googlesource.com/121364
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
Change-Id: Iea8a798c2711233eaf8e8ce1d627745f7071b77f
Reviewed-on: https://skia-review.googlesource.com/121081
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>
This should make the comparison between the DDL1 & DDL3 images easier
Change-Id: I9402364816da009a3991cc38e6a16bfa94899705
Reviewed-on: https://skia-review.googlesource.com/120542
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>
BUG=chromium:815092
Change-Id: I4b1ef90d6053a30e4f66a93974b24b8694dbc351
Reviewed-on: https://skia-review.googlesource.com/120563
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
No-Try: true
Change-Id: I9295739ce755325182a956a0c2ac068b599df767
Reviewed-on: https://skia-review.googlesource.com/120300
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
Change-Id: Iab663424527bbc65566341056664673f02204dce
Reviewed-on: https://skia-review.googlesource.com/119263
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
This is in preparation for upgrading the Windows Skolo bots. See also
https://skia-review.googlesource.com/c/buildbot/+/119320 -- pnputil.exe
doesn't like installing drivers older than the ones available from
Windows Update.
Bug: skia:7680
Change-Id: I8e8dedad89a70eb02730803a777671514ed1e84e
Reviewed-on: https://skia-review.googlesource.com/120440
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
Bug: skia:6653
No-Try: true
Change-Id: I6ac99a67667a4fb719fefc03e1128bcccda4e4c0
Reviewed-on: https://skia-review.googlesource.com/120000
Reviewed-by: Brian Osman <brianosman@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
Change-Id: I912e453ee1f27a5c5e50483d0cfa2ff9862d8e37
Reviewed-on: https://skia-review.googlesource.com/119261
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
This reverts commit a39991ebd7.
Reason for revert: Random bots timeout
Original change's description:
> Exercise the threaded backend in test bots
>
> We can't draw everything correctly now, but it's at least not crashing.
>
> The draw_to_canvas is modified by adding flush because now the raster
> canvas also needs flush like GPU canvases because of the threaded
> backend. (Previously, AndroidCodecSrc vetoed GPU (non-raster) sink
> and that's why it was not crashing.)
>
>
> Bug: skia:
> Change-Id: I222d706c33e15326e1b97d6bef6c46b8c35cebfd
> Reviewed-on: https://skia-review.googlesource.com/118886
> Reviewed-by: Kevin Lubick <kjlubick@google.com>
> Commit-Queue: Yuqian Li <liyuqian@google.com>
TBR=kjlubick@google.com,stephana@google.com,liyuqian@google.com
Change-Id: Ib1089d937b6e25cc39d90ad4de35b3a4c406f6b1
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: skia:
Reviewed-on: https://skia-review.googlesource.com/119100
Reviewed-by: Yuqian Li <liyuqian@google.com>
Commit-Queue: Yuqian Li <liyuqian@google.com>
We can't draw everything correctly now, but it's at least not crashing.
The draw_to_canvas is modified by adding flush because now the raster
canvas also needs flush like GPU canvases because of the threaded
backend. (Previously, AndroidCodecSrc vetoed GPU (non-raster) sink
and that's why it was not crashing.)
Bug: skia:
Change-Id: I222d706c33e15326e1b97d6bef6c46b8c35cebfd
Reviewed-on: https://skia-review.googlesource.com/118886
Reviewed-by: Kevin Lubick <kjlubick@google.com>
Commit-Queue: Yuqian Li <liyuqian@google.com>
Change-Id: I4a0259f82272099e08df0e7dea91489f6d641ca4
Reviewed-on: https://skia-review.googlesource.com/113670
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
Reviewed-by: Mike Klein <mtklein@chromium.org>
Change-Id: I31f4f2aff4e35dac066d208a9048ab0f96020fd1
Reviewed-on: https://skia-review.googlesource.com/118681
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
Change-Id: I783c0ad51a33e4731470f457132a1d20025a3431
Reviewed-on: https://skia-review.googlesource.com/118342
Commit-Queue: Mike Klein <mtklein@chromium.org>
Reviewed-by: Ben Wagner <bungeman@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
No-Try: true
Change-Id: Ief4e48a6bc2f126b31af3e8a381f8a6d5a73d523
Reviewed-on: https://skia-review.googlesource.com/117083
Reviewed-by: Mike Klein <mtklein@chromium.org>
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
Valgrind doesn't support half<->float x86 conversion instructions,
so we build those bots with SK_CPU_LIMIT_SSE41. We now also need
to limit skcms on those same bots.
Easiest thing to do is build completely portable scalar code, using
the existing -DSKCMS_PORTABLE. We can get fancier later if needed.
Change-Id: Icf14c72a220818be9df7b97bcf203e4412c3c6b7
Reviewed-on: https://skia-review.googlesource.com/118264
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Mike Klein <mtklein@chromium.org>
I don't believe any of these have any effect now that all
builds are done through GN. My best recollection is that
they used to affect GYP-based builds.
Change-Id: Ifde9f7c4d531dab43e8d407fc779d2ab6e38411c
Reviewed-on: https://skia-review.googlesource.com/118263
Commit-Queue: Mike Klein <mtklein@chromium.org>
Reviewed-by: Eric Boren <borenet@google.com>
This reverts commit e027e19477.
Reason for revert: capacity problem resolved
Original change's description:
> Temporarily remove Win10 QuadroP400 from CQ.
>
> This tryjob is currently just experimental/non-blocking, and we are
> severely short on capacity due to chromium:821040.
>
> Bug: chromium:821040
> Change-Id: I36b193cecd4f7ecf4c6f5769e869ee37a1285582
> No-Try: true
> Reviewed-on: https://skia-review.googlesource.com/114221
> Reviewed-by: Eric Boren <borenet@google.com>
> Commit-Queue: Ben Wagner <benjaminwagner@google.com>
TBR=borenet@google.com,benjaminwagner@google.com
# Not skipping CQ checks because original CL landed > 1 day ago.
Bug: chromium:821040
Change-Id: Idf305b56bc511b1072c6b7c524c963efd35a643c
Reviewed-on: https://skia-review.googlesource.com/117661
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
Bug: skia:
Change-Id: If7eec995d8683ef6cd7c90db11bc28d777ef2e56
NOTRY=true
Reviewed-on: https://skia-review.googlesource.com/117635
Reviewed-by: Greg Daniel <egdaniel@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
This reverts commit d234c9e6b9.
Reason for revert: GM/TSAN unhappiness
Original change's description:
> Switch bots to use ViaDDL (i.e., ddl-gl) instead of old --ddl flag
>
> Change-Id: I9c5f27bacf7d9fa7a9ac123379e2556913810cba
> Reviewed-on: https://skia-review.googlesource.com/116464
> Reviewed-by: Eric Boren <borenet@google.com>
> Commit-Queue: Robert Phillips <robertphillips@google.com>
TBR=borenet@google.com,robertphillips@google.com
Change-Id: I95388ee582bdd9561b8ebf24250f58b361657b7c
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://skia-review.googlesource.com/116621
Reviewed-by: Robert Phillips <robertphillips@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>
Change-Id: I9c5f27bacf7d9fa7a9ac123379e2556913810cba
Reviewed-on: https://skia-review.googlesource.com/116464
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>
To run on these older bots, looks like we need to statically link
libstdc++ and libgcc. Luckily that is straightforward.
Change-Id: If523067df196e943c2ba2f64c52eea0711dbfcbd
Reviewed-on: https://skia-review.googlesource.com/115743
Commit-Queue: Mike Klein <mtklein@chromium.org>
Reviewed-by: Ravi Mistry <rmistry@google.com>
Bug: skia:
Change-Id: Ie72dee00c5160ce329c74a12d64bc68ce264c1bf
Reviewed-on: https://skia-review.googlesource.com/115990
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Joe Gregorio <jcgregorio@google.com>
No-Try: true
Change-Id: Iaf292ac9875312d3f1fcc81fdc64c3c587f68286
Reviewed-on: https://skia-review.googlesource.com/113674
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
BUG=chromium:731979
Change-Id: Ief5917b06e6c9164cc3bccdd89da169d1e169ba7
Reviewed-on: https://skia-review.googlesource.com/115703
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
Should be used for running karma tests on skia-elements and also
for running lottiecap on bots.
Bug: skia:
Change-Id: I5c48cb741017be4eda014faea77ab88dec2e9637
Reviewed-on: https://skia-review.googlesource.com/115622
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Joe Gregorio <jcgregorio@google.com>
Change-Id: Icbbbe7275cf9bc62cbc175d4453affa12ded495a
Reviewed-on: https://skia-review.googlesource.com/115526
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>
BUG=chromium:815092
Change-Id: I7ec1d448c94bbdb6931fb315d6daf3d882430497
Reviewed-on: https://skia-review.googlesource.com/115362
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
Change-Id: I0d1aa9a137809349e34ab773b5ee41b69e813f9e
Reviewed-on: https://skia-review.googlesource.com/115220
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>
In compile recipes, add a dummy define (e.g.
-DDUMMY_clang_linux_version=42) to the compiler flags so that ninja will
recompile from scratch when the toolchain changes.
Bug: skia:7720
Change-Id: I9a330b21af364b3aa6a1eebbe6ac2022cfa82fdc
Reviewed-on: https://skia-review.googlesource.com/115160
Reviewed-by: Eric Boren <borenet@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
Bug: skia:7720
Change-Id: I044ca5281354b21c9deffa408ad7ec20c51d2e2e
Reviewed-on: https://skia-review.googlesource.com/115122
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
This reverts commit be5947c2f3.
Bug: skia:
Change-Id: I06dc15b31042d7827511d0ac2a7f4262c3f09622
Reviewed-on: https://skia-review.googlesource.com/115079
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
This reverts commit c9a642edf2.
Reason for revert: 1010102 gms broke
Original change's description:
> New read pixels implementation that is simpler but does all conversions on CPU.
>
> Change-Id: Ia548cd24a8544b35a233311706faf48de353b7cf
> Reviewed-on: https://skia-review.googlesource.com/109902
> Commit-Queue: Brian Salomon <bsalomon@google.com>
> Reviewed-by: Robert Phillips <robertphillips@google.com>
TBR=bsalomon@google.com,robertphillips@google.com,brianosman@google.com
Change-Id: I7724a6eef79885ba2a32c1ac871e5b2a9a3c0c12
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://skia-review.googlesource.com/115140
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
Bug: skia:7050
Change-Id: I53b141bf76ab4773909df968f69ba04dc29e0dc9
Reviewed-on: https://skia-review.googlesource.com/114960
Reviewed-by: Ravi Mistry <rmistry@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
This reverts commit 2ab6f7e580.
Reason for revert: Server back with more cores
Original change's description:
> Remove Android Framework bot from CQ while server is being upgraded
>
> NoTry: true
> Bug: skia:7716
> Change-Id: I67695c5f45ac5b9c57d0599ba2ab2e825fa75e4b
> Reviewed-on: https://skia-review.googlesource.com/114788
> Reviewed-by: Ravi Mistry <rmistry@google.com>
> Reviewed-by: Ben Wagner <benjaminwagner@google.com>
> Commit-Queue: Ravi Mistry <rmistry@google.com>
> Commit-Queue: Ben Wagner <benjaminwagner@google.com>
TBR=benjaminwagner@google.com,rmistry@google.com
Change-Id: I01626d9a4de98a27a350b053cb1aa7612d71d136
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: skia:7716
Reviewed-on: https://skia-review.googlesource.com/114820
Reviewed-by: Ravi Mistry <rmistry@google.com>
Commit-Queue: Ravi Mistry <rmistry@google.com>
Bug: skia:
Change-Id: Id4c613385a6948af9808dfbaef8f437e765fb9b5
Reviewed-on: https://skia-review.googlesource.com/114571
Commit-Queue: Ravi Mistry <rmistry@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
Change-Id: If9402ad5a3ae7d17221cf1bca621b8aad4d9e9d0
Reviewed-on: https://skia-review.googlesource.com/114466
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>
Bug: skia:
Change-Id: I1eca549d38b64869a763951b8469712d620e24bf
Reviewed-on: https://skia-review.googlesource.com/114516
Reviewed-by: Ravi Mistry <rmistry@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
This reverts commit aa504cddb9.
Reason for revert: Kevin asked me to revert since this broke things
Original change's description:
> Scale the GPU when running perf on Pixel(2)
>
> This is a similar followup to:
> https://skia-review.googlesource.com/c/skia/+/93561
>
> Bug: skia:
> Change-Id: I9b11dbf3d063fd64b1dd712cf1c596618f2c9ffc
> Reviewed-on: https://skia-review.googlesource.com/114340
> Reviewed-by: Eric Boren <borenet@google.com>
> Commit-Queue: Kevin Lubick <kjlubick@google.com>
TBR=borenet@google.com,kjlubick@google.com
Change-Id: Idbc7234f2b7ff8c5e632680903836e1f4eaa50d5
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: skia:
Reviewed-on: https://skia-review.googlesource.com/114425
Reviewed-by: Ravi Mistry <rmistry@google.com>
Commit-Queue: Ravi Mistry <rmistry@google.com>
The experiment with using Goma to speed up Windows compiles was very
close to being successful, but at this point the ongoing maintenance
does not seem to be worth the 50-70 seconds saved.
Change-Id: Ie3900b9a681e448a3e47634efbab7695ebccad33
Reviewed-on: https://skia-review.googlesource.com/114363
Reviewed-by: Mike Klein <mtklein@chromium.org>
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
It is well after December 2017
Bug: skia:
Change-Id: I3e48735dac9885606bdecab301379a1312966ff1
Reviewed-on: https://skia-review.googlesource.com/114361
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
No-Try: true
Change-Id: I119c7853299b6eef65f991b41cbb2afb0a35f431
Reviewed-on: https://skia-review.googlesource.com/113673
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
Also switch CQ Win 32-bit Build from MSVC to Clang.
No-Try: true
Change-Id: Ic312ee611b1e99143480840c08a9266a4d8b448b
Reviewed-on: https://skia-review.googlesource.com/113672
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
Change-Id: Iea0f841f7c9a3449213c549ba310ab2a3d928ca2
Reviewed-on: https://skia-review.googlesource.com/114093
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
Reviewed-by: Mike Klein <mtklein@chromium.org>
Enable /arch:SSE2 for Win x86 builds (both MSVC and Clang).
Change-Id: I0618e938b6542b60fae3947b7e0dcde22650ba54
Reviewed-on: https://skia-review.googlesource.com/56721
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
This tryjob is currently just experimental/non-blocking, and we are
severely short on capacity due to chromium:821040.
Bug: chromium:821040
Change-Id: I36b193cecd4f7ecf4c6f5769e869ee37a1285582
No-Try: true
Reviewed-on: https://skia-review.googlesource.com/114221
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
Bug: skia:
Change-Id: Ic739fd2d24ee2e9ed2c8b0dfdfc7118005350400
Reviewed-on: https://skia-review.googlesource.com/113300
Commit-Queue: Eric Boren <borenet@google.com>
Reviewed-by: Ravi Mistry <rmistry@google.com>
Adds procdump_win asset.
Enable ProcDump for some of the jobs failing in skia:7177 as a test
case. If it has no ill effect, we can proceed with enabling it for all
Win bots (and remove "ProcDump" tag).
Bug: skia:7626, skia:7177
Change-Id: I50c67ecfca86fe0c6d91d5f970f81485cc9cfd0a
Reviewed-on: https://skia-review.googlesource.com/113265
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
It was released yesterday.
Change-Id: Ied9ef3c65fcee0ac7af785c6642fb899d6bd4b0d
Reviewed-on: https://skia-review.googlesource.com/113380
Commit-Queue: Mike Klein <mtklein@google.com>
Reviewed-by: Kevin Lubick <kjlubick@google.com>
This version is the latest from Windows Update, which is not available from Intel. It is an earlier
version than the one used in https://skia-review.googlesource.com/c/skia/+/106202, but all later
drivers seem to have the same issue that caused that CL to be reverted.
Bug: skia:7490, skia:6398
Change-Id: I96f4262d16066dbd1a05dadd66df32b29d1bd9d6
No-Try: true
Reviewed-on: https://skia-review.googlesource.com/111064
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
- adds building the testlab driver (run_testlab) as a separate step
- adds gcloud isolate necessary to run testlab
- adds Testlab support and uploading a verified AKP to GCS (with
meta data attached).
Bug: skia:
Change-Id: I1bf265f46c99360eb3a9eb684886f93de48085fe
Reviewed-on: https://skia-review.googlesource.com/111603
Reviewed-by: Eric Boren <borenet@google.com>
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
Commit-Queue: Stephan Altmueller <stephana@google.com>
It's not clear that we should ever decode to this format.
Bug: skia:7686
Change-Id: I9f2cc6e72d89d06bf9491d695b4f64b99bfa0392
Reviewed-on: https://skia-review.googlesource.com/111841
Reviewed-by: Leon Scroggins <scroggo@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
This reverts commit ded47a5014.
Bug: skia:
Change-Id: I7d7552e6ccc8591cae91426407ab13b628b93b68
Reviewed-on: https://skia-review.googlesource.com/111760
Commit-Queue: Brian Osman <brianosman@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
This reverts commit 44b61204d9.
Reason for revert: TSAN bot crashing
Original change's description:
> Add 1010102 support to Ganesh
>
> Adds gl1010102, gles1010102, vk1010102, and mtl1010102
> configs to DM.
>
> This uses the same saveLayer approach as CPU, switching
> to 8888 so that we have enough alpha precision.
>
> Change-Id: I9f5b63747ec01031c8db97dadfc42f77e4863ccb
> Reviewed-on: https://skia-review.googlesource.com/110500
> Reviewed-by: Brian Salomon <bsalomon@google.com>
> Commit-Queue: Brian Osman <brianosman@google.com>
TBR=mtklein@google.com,bsalomon@google.com,brianosman@google.com
Change-Id: I782e740763044c1ae78fb219161e37eec7617c74
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://skia-review.googlesource.com/111580
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
This affects GTX660, GTX960, and GTX1070.
No-Try: true
Change-Id: I16a307dde0daa72a70728bfd8da4da2786dac0e5
Reviewed-on: https://skia-review.googlesource.com/111101
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
Adds gl1010102, gles1010102, vk1010102, and mtl1010102
configs to DM.
This uses the same saveLayer approach as CPU, switching
to 8888 so that we have enough alpha precision.
Change-Id: I9f5b63747ec01031c8db97dadfc42f77e4863ccb
Reviewed-on: https://skia-review.googlesource.com/110500
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
This affects GTX660, RadeonHD7770, and GTX1070.
Change-Id: I7b91aa4a8a3893597bb164a32e5e6b2560a84d9b
Reviewed-on: https://skia-review.googlesource.com/109812
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
Make indirect path in writeSurfacePixels2 use a copy rather than a draw.
Fix issue in GrVkGpu where render target dirty region is not updated after copy-as-draw
Remove unnecessary resolve of MSAA RT in GrVkCopyManager.
Splits WritePixelsNonTexture_Gpu test into MSAA and non-MSAA variants. MSAA variant blacklisted
on Adreno because of:
Bug: skia:7663
~~~~~~AND~~~~~~~
Revert "Suppress CopySurface test on Nexus 7"
This reverts commit b42b6169d5.
Bug: skia:7658
Change-Id: I8337d718efb41e266537744bbf5ff8b1545322a7
Reviewed-on: https://skia-review.googlesource.com/110700
Reviewed-by: Brian Osman <brianosman@google.com>
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
This affects GTX960.
Change-Id: I42807d9e51bb7dd3b665db805631f3c9a475056c
Reviewed-on: https://skia-review.googlesource.com/109811
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
This affects RadeonR9M470X.
Change-Id: I6d11ee553aced18494a07c5b8703060d105567f7
Reviewed-on: https://skia-review.googlesource.com/109809
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
Affects IntelIris6100 and IntelHD4400.
No-Try: true
Change-Id: I50927e051ca37a7c39982da937e538698fa34e2d
Reviewed-on: https://skia-review.googlesource.com/108189
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
This affects IntelIris540.
Change-Id: I37fba0a8472fb809f212e8472add6451ffcb8e77
Reviewed-on: https://skia-review.googlesource.com/109808
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
Bug: skia:7497
Change-Id: If40c5a318b1becbe81bac4b1543ceab30c3f840b
Reviewed-on: https://skia-review.googlesource.com/110440
Reviewed-by: Kevin Lubick <kjlubick@google.com>
Commit-Queue: Mike Klein <mtklein@chromium.org>
The load_f16 and store_f16 stages are assuming they can load
each pixel at a time with 8 byte alignment, but as declared
the buffers are only guaranteed 2 byte alignment.
Bug: skia:7497
Change-Id: I47b29f13b48f90d2b15540979c3d87ba25dcc506
Reviewed-on: https://skia-review.googlesource.com/110321
Reviewed-by: Kevin Lubick <kjlubick@google.com>
Commit-Queue: Mike Klein <mtklein@chromium.org>
Bug: skia:
Change-Id: I5bf9e2e09af1cb7392138c9b871d315588ffbf62
Reviewed-on: https://skia-review.googlesource.com/110241
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
This affects IntelIris6100 and IntelHD4400.
Change-Id: I95a1eee3169ad6ad3c7873fd40f9f00069d5c0ab
Reviewed-on: https://skia-review.googlesource.com/109807
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
Bug: skia:7646
Change-Id: Iddf55940230c99fea9d838a1b03a8c3bb476262e
Reviewed-on: https://skia-review.googlesource.com/109360
Commit-Queue: Eric Boren <borenet@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
Bug: skia:
Change-Id: I0415690911a52059eaaf7f32c81b7a4c66117d5b
Reviewed-on: https://skia-review.googlesource.com/109162
Commit-Queue: Stephan Altmueller <stephana@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
Bug: skia:
Change-Id: Ib0e9ddb621056ddce2422b53f312ec42d4d7aa3c
Reviewed-on: https://skia-review.googlesource.com/107880
Commit-Queue: Stephan Altmueller <stephana@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
Bug: skia:
NOTRY=true
Change-Id: I9b79044df1a265a086e77fbadcaab69bf86babe1
Reviewed-on: https://skia-review.googlesource.com/108521
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
also
Revert "Increase ninja thread count for Windows builds."
This reverts commit 98c4231592.
This reverts commit 50a808a518.
Bug: skia:
Change-Id: I7cc50b0bec6e1ad9f9d971a5c88c029488bb80ed
Reviewed-on: https://skia-review.googlesource.com/108504
Reviewed-by: Stephan Altmueller <stephana@google.com>
Reviewed-by: Kevin Lubick <kjlubick@google.com>
Commit-Queue: Stephan Altmueller <stephana@google.com>
Bug: skia:7609
Change-Id: I3c23df024afda53d50409ef19e1de9274a664111
Reviewed-on: https://skia-review.googlesource.com/108440
Commit-Queue: Eric Boren <borenet@google.com>
Reviewed-by: Ravi Mistry <rmistry@google.com>
Bug: skia:7609
Change-Id: Iaaaa2390d87656a4fa40e44fc31c35573abec7b5
Reviewed-on: https://skia-review.googlesource.com/108186
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
Bug: skia:7562
Change-Id: I21eb1d9aa6717edcd89d958149e1ad250b4bf154
Reviewed-on: https://skia-review.googlesource.com/107944
Commit-Queue: Jim Van Verth <jvanverth@google.com>
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
Bug: skia:7562
Change-Id: I56e0991999644c02890008123b25f141aed0b70e
Reviewed-on: https://skia-review.googlesource.com/107520
Commit-Queue: Jim Van Verth <jvanverth@google.com>
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
Change-Id: Ib637360e2f09cd2851771595590203da6195a314
Reviewed-on: https://skia-review.googlesource.com/107600
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
Change-Id: Icc3f3cc144d6d3d2ee467822436df94559d6ff37
Reviewed-on: https://skia-review.googlesource.com/107580
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
This reverts commit e1c2945b5f.
Reason for revert: no crashes since
Original change's description:
> serialize NexusPlayer bots
>
> Temporarily serialize the NexusPlayer Test bots to help diagnose
> skia:7614.
>
> Bug: skia:7614
>
> Change-Id: I190327070f27e53d8344820f2215bad00f12e1ab
> Reviewed-on: https://skia-review.googlesource.com/106621
> Reviewed-by: Mike Klein <mtklein@chromium.org>
> Commit-Queue: Mike Klein <mtklein@chromium.org>
TBR=mtklein@chromium.org,caryclark@google.com
# Not skipping CQ checks because original CL landed > 1 day ago.
Bug: skia:7614
Change-Id: I1c7508c3f9a171d14cad1b77506d98772ef4ef60
Reviewed-on: https://skia-review.googlesource.com/107620
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
These cuts reduce the number of files by 2/3 and the size by 1/3
There's not too much more that could be trimmed - now the size
is dominated by the specially compiled LLVM/Clang binaries
Bug: skia:7186
Change-Id: Ie88fb6f2277eafbefac0f676daaca809dcb53f62
Reviewed-on: https://skia-review.googlesource.com/107061
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Previously, we needed vulkan-1.dll from the Vulkan runtime because some
drivers did not include the Vulkan loader. Now, all drivers include this
DLL and using the version from assets causes problems for newer Intel
drivers.
Bug: skia:7490
Change-Id: I7bd37fb0d2c88a4753f354ab2bc88761562ced2f
Reviewed-on: https://skia-review.googlesource.com/107060
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
I will use this in skcms-Win bots.
Change-Id: Id2e253a73e562181649f17908e5d587cc0d098d6
Reviewed-on: https://skia-review.googlesource.com/106973
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Mike Klein <mtklein@chromium.org>
Bug: skia:
Change-Id: I55bb57a7f199d0f57531523f1fedfec2bf49502c
Reviewed-on: https://skia-review.googlesource.com/106802
Commit-Queue: Eric Boren <borenet@google.com>
Reviewed-by: Stephan Altmueller <stephana@google.com>
This is a hack to get around the fact that we can't update the normal
version of depot_tools we receive through recipe deps, since we are not
yet using kitchen (See skia:7050).
Bug: skia:7609
Change-Id: I7d39e1e5db716960b2df2c8e3d4325c4b20c774e
Reviewed-on: https://skia-review.googlesource.com/106720
Reviewed-by: Ravi Mistry <rmistry@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
Temporarily serialize the NexusPlayer Test bots to help diagnose
skia:7614.
Bug: skia:7614
Change-Id: I190327070f27e53d8344820f2215bad00f12e1ab
Reviewed-on: https://skia-review.googlesource.com/106621
Reviewed-by: Mike Klein <mtklein@chromium.org>
Commit-Queue: Mike Klein <mtklein@chromium.org>
No-Try: true
Change-Id: Ia55bb4bf1e4de5167ed181f4dfcde9210e7a447c
Reviewed-on: https://skia-review.googlesource.com/106024
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
Bug: skia:7586
Change-Id: If52cefadc657fa93d90fe11b08e3efc5aeacb634
Reviewed-on: https://skia-review.googlesource.com/105767
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Ravi Mistry <rmistry@google.com>
Having removed the NVPR text renderer, the nvprdit* configs are no longer interesting/useful.
Change-Id: Ic4b9d6507d3e3595723a27636cb58b5e811fb3a3
Reviewed-on: https://skia-review.googlesource.com/105563
Reviewed-by: Brian Salomon <bsalomon@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>
They've been sufficiently fast for the last few days.
NOTRY=true
Bug: skia:
Change-Id: Id5df2e23bc3fd39526301432bcd625c3dca47367
Reviewed-on: https://skia-review.googlesource.com/104260
Reviewed-by: Ravi Mistry <rmistry@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Noticed this when trybots were not using changes to
trigger_wait_ac_task.py
NoTry: true
Bug: skia:7469
Change-Id: Ifac964e247bfd6862fa030fbf5176f179ef7f3c4
Reviewed-on: https://skia-review.googlesource.com/103521
Commit-Queue: Ravi Mistry <rmistry@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
- allows to choose api versions in run_testlab.go
- adds api_version and work_arounds to generate_gn_args
Bug: skia:
Change-Id: I87516b493f4d8eef3689d1722a5dd864131a44f8
Reviewed-on: https://skia-review.googlesource.com/102900
Reviewed-by: Derek Sollenberger <djsollen@google.com>
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
Commit-Queue: Stephan Altmueller <stephana@google.com>
Bug: skia:
NOTRY=true
Change-Id: Ia5e7e844af57ff06fc0e5a4139cf6c62b60a19ef
Reviewed-on: https://skia-review.googlesource.com/102423
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Bug: skia:7469
Change-Id: I4a570a92d266d86fca20c9394c8d446df3c41e9b
Reviewed-on: https://skia-review.googlesource.com/102600
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Ravi Mistry <rmistry@google.com>
It will be called from a new recipe.
This script follows the same pattern that the trigger_wait_ct_task.py used to
(https://codereview.chromium.org/1370523002).
NoTry: true
Bug: skia:7469
Change-Id: I450e415b004e7f481ca1b377d350eb64e5fa8250
Reviewed-on: https://skia-review.googlesource.com/102340
Commit-Queue: Ravi Mistry <rmistry@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
Here's the current error:
==6835==WARNING: AddressSanitizer failed to allocate 0xc0000028 bytes
==6835==AddressSanitizer's allocator is terminating the process instead of returning 0
==6835==If you don't like this behavior set allocator_may_return_null=1
==6835==AddressSanitizer CHECK failed: external/compiler-rt/lib/sanitizer_common/sanitizer_allocator.cc:221 "((0)) != (0)" (0x0, 0x0)
Looking at how sk_malloc and co all funnel into sk_malloc_flags(), and
how our local sk_malloc_flags() works, I think everything would be fine
to run this bot with allocator_may_return_null=1, but I'm not sure how
to do that.
Change-Id: I155439e17dd6353b82056de12f49de34e9538643
Reviewed-on: https://skia-review.googlesource.com/101660
Reviewed-by: Leon Scroggins <scroggo@google.com>
Commit-Queue: Mike Klein <mtklein@chromium.org>
Change-Id: I8154b9a0b2fcf76fa02af0efa6b57425c6f9ac31
Reviewed-on: https://skia-review.googlesource.com/101580
Reviewed-by: Mike Klein <mtklein@chromium.org>
Commit-Queue: Mike Klein <mtklein@chromium.org>
Our 32-bit "arm" builds can run just fine on most ARMv8 devices. This
mode of operation is called "aarch32", as opposed to the usual mode
we're used to thinking about of running 64-bit "arm64" binaries,
"aarch64".
(Unimportant side note: there are ARMv8 chips that support only
aarch64... I think e.g. the iPhone X's CPU? There are also ARMv8 chips
that support only aarch32, rare and usually for tiny embedded things
like a watch. All the devices we test with support both aarch64 and
aarch32.)
(Technically what we call "arm" is more properly "T32" for Thumb2 32,
and "arm64" is "A64" for... ARM 64. This note is even less important
than the previous one.)
Android ships 64-bit Skia on devices that support it, but Chrome still
clings to 32-bit. So I thought it'd make sense for us to run some of
these Chrome-like builds too. I wasn't sure which ones, so I just went
nuts and mirrored all the Nexus5x bots. If you notice bots that seem
under your purview and you really don't care about how Chrome would work
in that mode, please mark them in the code review and I'll drop them.
Change-Id: I3e67070c669f5c459f4c0f5f46a68529a8eb9afc
Reviewed-on: https://skia-review.googlesource.com/101545
Reviewed-by: Brian Salomon <bsalomon@google.com>
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Mike Klein <mtklein@chromium.org>
ViaSingletonPictures simulates a load pattern that Blink no longer produces.
I don't even remember what Via2ndPic and ViaTwice are meant to test,
but I imagine they're quite obsolete.
There was a lingering reference to ViaMojo, which otherwise doesn't exist.
Bug: skia:7544
Change-Id: I033fd344314054ad66c363e5dbd0a373be188069
Reviewed-on: https://skia-review.googlesource.com/88780
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Mike Klein <mtklein@chromium.org>
Bug: skia:6687
Change-Id: I1562d7e9ded7f1be8a7ddc0c2341e54d5abbc0ae
Reviewed-on: https://skia-review.googlesource.com/97901
Reviewed-by: Brian Salomon <bsalomon@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
I think the Chorizo is now enforcing that our aligned loads are really
aligned. If this sticks, I'll follow up with the rest of the tests
disabled on the bug.
Bug: skia:7497
Change-Id: Id392e20ead395474f716a2c32d2643c801e03a2e
Reviewed-on: https://skia-review.googlesource.com/97202
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Mike Klein <mtklein@chromium.org>
Bug: skia:
Change-Id: I79bdb1ff137c488ef5d4998ffc0cc9cdc28ae9fb
Reviewed-on: https://skia-review.googlesource.com/97240
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Greg Daniel <egdaniel@google.com>
Bug: skia:
Change-Id: If1fc0854a42407fa6acd8d333ef49ae0b6302a81
Reviewed-on: https://skia-review.googlesource.com/95640
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Also a few more blacklists to avoid shader compilation errors
in the Debug-GPU configuration.
Bug: skia:7166
Bug: skia:6687
Change-Id: I07b5adfc62e8029ece21406f0b79b32d9adf346f
Reviewed-on: https://skia-review.googlesource.com/95560
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Bug: skia:7166
Change-Id: Iefc8c6c1b72805dfe3ec8bd06d6ba6a878307582
Reviewed-on: https://skia-review.googlesource.com/93620
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Mike Klein <mtklein@chromium.org>
It should work on 32 and 64 bit android running M or newer.
Bug: skia:
Change-Id: I7e6d4000f4fee8f2704b84b7174174dd0e68d21c
Reviewed-on: https://skia-review.googlesource.com/93700
Reviewed-by: Mike Klein <mtklein@chromium.org>
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
This may fix weird races in tests.
Bug: skia:
Change-Id: I41c36424c7b559301e915a0892590c74931ae463
Reviewed-on: https://skia-review.googlesource.com/93942
Reviewed-by: Kevin Lubick <kjlubick@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
Bug: skia:
Change-Id: I7394d2f392d7179777b65e77194436271efea80d
Reviewed-on: https://skia-review.googlesource.com/93760
Commit-Queue: Mike Klein <mtklein@google.com>
Reviewed-by: Greg Daniel <egdaniel@google.com>
We do some of this already in skpbench.
Bug: skia:
Change-Id: Ia698466e83f9b476644c126747a2f89346361d13
Reviewed-on: https://skia-review.googlesource.com/93561
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
- fill in a couple switches to allow software to rasterize gray8
- add a gray8 config to DM so we can test it
- enable this config on some bots
Today we draw gray8 using SkRasterPipeline, loading it as {g,g,g,1}
and storing using the same fixed luma math as SkLumaColorFilter.
One day it'd be nice to use the color space's luma vector if present.
Can we support this on GPU?
Change-Id: I4ee661c8bd5f33f5db2433ffb6e1bc2483af8397
Reviewed-on: https://skia-review.googlesource.com/92681
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Mike Klein <mtklein@chromium.org>
I spot checked a few of the runs, and the both seem to be < 20m, even when
the tree is busy.
Bug: skia:
NOTRY=true
Change-Id: I1194f34365501afd5c9533332318a91c2db95194
Reviewed-on: https://skia-review.googlesource.com/92100
Reviewed-by: Joe Gregorio <jcgregorio@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Adds activities to the skqp app so it can run as an Android
app (as opposed to just instrumentation tests).
A user can trigger the tests via a button.
Adds the an intent receiver so the tests can be triggered on
Firebase Testlab via the gameloop option.
It adds the run_testlab.go script to run an apk across devices
on Firebase Testlab.
Bug: skia:
Change-Id: I3ff5c37d743fa47913a916a0fa1e7db3c2cc79c7
Reviewed-on: https://skia-review.googlesource.com/89163
Commit-Queue: Stephan Altmueller <stephana@google.com>
Reviewed-by: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Derek Sollenberger <djsollen@google.com>
Bug: skia:7463
Change-Id: I5dd17a5ba33f867346837f006f9dc4cb775cfa04
Reviewed-on: https://skia-review.googlesource.com/91960
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Ravi Mistry <rmistry@google.com>
