Eric Boren
c7bdefa80d
Add a segment about bin/try to the site docs
...
No-Try: true
Docs-Preview: https://skia.org/?cl=60586
Bug: skia:
Change-Id: I8169d4199564380cc602e0c46a5d4fadd1c28dcb
Reviewed-on: https://skia-review.googlesource.com/60586
Reviewed-by: Ravi Mistry <rmistry@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
2017-10-24 15:31:11 +00:00
Mike Klein
8fed655df8
fix libc++/MSAN instructions
...
Change-Id: I2305595eeacc6ed7f8b264b85d6a8c33823c77eb
Reviewed-on: https://skia-review.googlesource.com/61700
Reviewed-by: Yuqian Li <liyuqian@google.com>
2017-10-18 18:45:41 +00:00
Yuqian Li
a0dc0143f8
Update MSAN gn args to match our bots
...
The previous gn args would result in linking errors.
No-Try: true
Docs-Preview: https://skia.org/?cl=60761
Bug: skia:
Change-Id: Ia9e1472080484d29dfbc2f86728f10721c05856c
Reviewed-on: https://skia-review.googlesource.com/60761
Commit-Queue: Yuqian Li <liyuqian@google.com>
Reviewed-by: Mike Klein <mtklein@chromium.org>
2017-10-18 18:19:05 +00:00
Ben Wagner
172c6bd8e9
Add more detail to Swarming bot doc.
...
No-Try: true
Docs-Preview: https://skia.org/?cl=54561
Change-Id: Id7bcccf1ffa7b1726bc5f9394178a629078b1225
Reviewed-on: https://skia-review.googlesource.com/54561
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
Reviewed-by: Ravi Mistry <rmistry@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
2017-10-04 16:31:33 +00:00
Ben Wagner
05572fa6e7
Update docs on Skia bots.
...
No-Try: true
Docs-Preview: https://skia.org/?cl=52163
Change-Id: I2bcd73bc7597219e4748c28e9120b5138a0eb3d1
Reviewed-on: https://skia-review.googlesource.com/52163
Reviewed-by: Eric Boren <borenet@google.com>
Reviewed-by: Ravi Mistry <rmistry@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
2017-09-28 13:45:37 +00:00
Ravi Mistry
6f4c5d5a31
Update Skia trooper page
...
Highlights:
* Add link to the trooper handoff doc.
* Describe how to update trooper/sheriff/wrangler/robocop schedules.
* Add link to the trooper chrome extension.
* Remove things that appear to be no longer valid.
No-Try: true
Docs-Preview: https://skia.org/?cl=51803
Bug: skia:
Change-Id: I82cd2965836a7916f85ffc85c372b8a07b9628f5
Reviewed-on: https://skia-review.googlesource.com/51803
Commit-Queue: Ravi Mistry <rmistry@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
2017-09-27 15:17:48 +00:00
Ravi Mistry
da669f1506
Add links to autoroller cloud logs for roboCops
...
No-Try: true
Docs-Preview: https://skia.org/?cl=42901
Change-Id: I065c69085a8b32e8ff25ab5667882067f26a38c9
Bug: skia:
Reviewed-on: https://skia-review.googlesource.com/42901
Reviewed-by: Ravi Mistry <rmistry@google.com>
Commit-Queue: Ravi Mistry <rmistry@google.com>
2017-09-07 15:30:51 +00:00
Brian Osman
c3cdef5fb0
Add top-level trace markers for each benchmark
...
Also add new paragraph about using systrace correctly
Docs-Preview: https://skia.org/?cl=41502
Change-Id: I114c14cc2e87a8b72aec46d8c354d3ea877a41ab
Reviewed-on: https://skia-review.googlesource.com/41502
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
2017-08-31 18:36:51 +00:00
Yuqian Li
d301629d1d
Add links to Analytic AA design docs
...
No-Try: true
Docs-Preview: https://skia.org/?cl=28860
Bug: skia:
Change-Id: I19b4227bebba9070884b7dbf3530e6305e45aaf2
Reviewed-on: https://skia-review.googlesource.com/28860
Reviewed-by: Heather Miller <hcm@google.com>
Commit-Queue: Yuqian Li <liyuqian@google.com>
2017-07-31 18:36:13 +00:00
Ben Wagner
713195071d
Remove internal use of SkTypeface::Style.
...
Change-Id: I71cf04b12be95a54b7fb47d048ba1f8672ed9a8f
Reviewed-on: https://skia-review.googlesource.com/27760
Commit-Queue: Ben Wagner <bungeman@google.com>
Reviewed-by: Mike Klein <mtklein@chromium.org>
2017-07-27 21:30:45 +00:00
Brian Osman
1627c04d86
Quick documentation of tracing support in our tools
...
No-Try: true
Docs-Preview: https://skia.org/?cl=26260
Bug: skia:
Change-Id: I3cf09f1c94cdc9551ece44da022ef2c2f374d6e4
Reviewed-on: https://skia-review.googlesource.com/26260
Commit-Queue: Brian Osman <brianosman@google.com>
Reviewed-by: Mike Klein <mtklein@chromium.org>
2017-07-24 17:25:05 +00:00
Brian Osman
430e4c84e9
Some basic Flutter/Fuchsia docs
...
No-Try: true
Docs-Preview: https://skia.org/?cl=24406
Bug: skia:
Change-Id: I18ba9bf86b44b27262c9785cc0b5edbc982ae076
Reviewed-on: https://skia-review.googlesource.com/24406
Reviewed-by: Ravi Mistry <rmistry@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
2017-07-19 13:17:54 +00:00
Hal Canary
7cbf5e3e03
SkPDF: simplify drawImage/Bitmap/Sprite code.
...
- SkImageSubset becomes SkKeyedImage
- SkPDFCanvas::onDraw{Bitmap, Image} go away
- Remove SkPDFCanvas: base classes now do the right thing.
- SkPDFDevice::draw{Bitmap,Image}{Rect,}() simplified
- 244 fewer SLOC.
All but a few PDFs are identical, those rasterize almost the same.
Change-Id: I3ceb3b8935c689719cedf1ad544b0407b5c1733e
Reviewed-on: https://skia-review.googlesource.com/22218
Commit-Queue: Hal Canary <halcanary@google.com>
Reviewed-by: Ben Wagner <bungeman@google.com>
2017-07-12 20:41:41 +00:00
Mike Klein
c55a6cb05f
build regenerating SkJumper stages into GN
...
I _think_ this makes it so changes to _stages.cpp or _lowp.cpp get
noticed, regenerated, and baked into Skia all in the same Ninja
invocation.
Now you just need to set up the tools we use in GN:
skia_jumper_clang = ...
skia_jumper_objdump = ...
skia_jumper_ccache = ...
Change-Id: I09fb54d965644ff6e5825056fb0be2c7cab2ea92
Reviewed-on: https://skia-review.googlesource.com/21140
Reviewed-by: Florin Malita <fmalita@chromium.org>
Commit-Queue: Mike Klein <mtklein@chromium.org>
2017-06-28 18:22:16 +00:00
Allan MacKinnon
0059f97c3f
Broken link in Tree Sheriffs Documentation
...
No-Try: true
Docs-Preview: https://skia.org/?cl=19326
Bug: skia:
Change-Id: I215d02470d14f076af68bfdc88046a0123429fb7
Reviewed-on: https://skia-review.googlesource.com/19326
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
Commit-Queue: Allan MacKinnon <allanmac@google.com>
2017-06-09 17:56:14 +00:00
Ben Wagner
094dcc51c1
Update link to testing infrastructure.
...
No-Try: true
Docs-Preview: https://skia.org/?cl=18596
Change-Id: I0d3cae67ccb7db06f3a85a0b1360873a77bbe78f
Reviewed-on: https://skia-review.googlesource.com/18596
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
2017-06-05 18:20:55 +00:00
Ravi Mistry
c823fb598b
Update documentation to specify the new Gerrit style CQ keywords
...
BUG=skia:6667
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=17762
Change-Id: I440b5565589102ae6026b5da4716fd43d4a48d6a
Reviewed-on: https://skia-review.googlesource.com/17762
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Ravi Mistry <rmistry@google.com>
2017-05-23 20:28:54 +00:00
Hal Canary
35a87d60e6
documentaion: consistant formatting
...
NOTRY=true
Change-Id: I2dd9d755242ca6c3522c465e1fa00139dda71a9d
Reviewed-on: https://skia-review.googlesource.com/16220
Reviewed-by: Hal Canary <halcanary@google.com>
Commit-Queue: Hal Canary <halcanary@google.com>
2017-05-15 20:05:56 +00:00
Mike Klein
892af1ec7b
add a guide to contributing to SkJumper
...
Change-Id: Icd40cf5eff3d2156a3ca00d7950059d5b77f48bf
Reviewed-on: https://skia-review.googlesource.com/15890
Reviewed-by: Ben Wagner <bungeman@google.com>
Commit-Queue: Mike Klein <mtklein@chromium.org>
2017-05-08 23:40:14 +00:00
Ravi Mistry
7efa047630
Document the new bug and test lines behavior of the release rollers
...
BUG=skia:6506
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=13686
Change-Id: I8f38d2f87784a846ccdc4be54d0f07e0fe98f7dc
Change-Id: I8f38d2f87784a846ccdc4be54d0f07e0fe98f7dc
Reviewed-on: https://skia-review.googlesource.com/13686
Reviewed-by: Matt Sarett <msarett@google.com>
Commit-Queue: Ravi Mistry <rmistry@google.com>
2017-04-18 12:20:57 +00:00
Ravi Mistry
028c3d77ea
Add documentation for android-o-roll.skia.org
...
BUG=skia:6438
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=13475
Change-Id: I7d76d66b9b665fafc5c89bd4620517ebb9d2b076
Change-Id: I7d76d66b9b665fafc5c89bd4620517ebb9d2b076
Reviewed-on: https://skia-review.googlesource.com/13475
Reviewed-by: Matt Sarett <msarett@google.com>
Reviewed-by: Derek Sollenberger <djsollen@google.com>
Commit-Queue: Ravi Mistry <rmistry@google.com>
2017-04-14 14:38:56 +00:00
Ravi Mistry
6d2cf4726c
Update Android autoroller documentation
...
BUG=skia:5538
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=13266
Change-Id: I76fa8db5ea9916fab2ef0f8058157dac96d52517
Change-Id: I76fa8db5ea9916fab2ef0f8058157dac96d52517
Reviewed-on: https://skia-review.googlesource.com/13266
Reviewed-by: Matt Sarett <msarett@google.com>
Commit-Queue: Ravi Mistry <rmistry@google.com>
2017-04-12 17:03:17 +00:00
Kevin Lubick
7cad9897d4
Add docs for downloading prebuilt binaries from CIPD
...
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=13101
Bug: skia:
Change-Id: Iefa8070c65881ff8c05a3b88aa8385fcc1a427ff
Change-Id: Iefa8070c65881ff8c05a3b88aa8385fcc1a427ff
Reviewed-on: https://skia-review.googlesource.com/13101
Reviewed-by: Mike Klein <mtklein@chromium.org>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
2017-04-12 12:10:05 +00:00
bungeman
981108b004
Update instructions on Skia/Chromium multi try.
...
Change-Id: I7ac583dbf04d18210847c54f7c69cf8a4f46deea
Reviewed-on: https://skia-review.googlesource.com/10597
Reviewed-by: Mike Klein <mtklein@chromium.org>
Commit-Queue: Ben Wagner <bungeman@google.com>
2017-03-30 15:59:50 +00:00
Brian Salomon
6405e71279
Remove gpu configs that don't have explicit API.
...
DOCS_PREVIEW= https://skia.org/?cl=9871
Change-Id: I510473cf91d8bee38d1e33424b1ae7b30dc86968
Reviewed-on: https://skia-review.googlesource.com/9871
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
2017-03-20 13:31:49 +00:00
Hal Canary
30a6b81f4b
Documentation: Consistancy
...
* Don't rely on '#!', since it doesn't work for Windows cmd shell.
* Consistantly use `tools/git-sync-deps` rather than `bin/sync`.
* Always call `bin/gn` ranther than `gn` in case depot_tools is
missing from the path.
NOTRY=true
Change-Id: I27909f2610d1bb3241874399d7d2f7286f99f43b
Reviewed-on: https://skia-review.googlesource.com/9640
Reviewed-by: Mike Klein <mtklein@chromium.org>
Commit-Queue: Mike Klein <mtklein@chromium.org>
2017-03-14 14:21:49 +00:00
Hal Canary
0f4f3e875d
Documentation: fix width
...
NOTRY=true
Change-Id: I60861019cc19537eaff000dec15b4ecbea54e915
Reviewed-on: https://skia-review.googlesource.com/9298
Commit-Queue: Hal Canary <halcanary@google.com>
Reviewed-by: Hal Canary <halcanary@google.com>
2017-03-06 15:34:39 +00:00
Hal Canary
51aa1f5cce
Documentation: ASAN, MSAN, and TSAN
...
NOTRY=true
Change-Id: I7ed212047a60d323e2e98470fc1eed454d333958
Reviewed-on: https://skia-review.googlesource.com/9170
Commit-Queue: Hal Canary <halcanary@google.com>
Reviewed-by: Mike Klein <mtklein@chromium.org>
2017-03-06 15:23:55 +00:00
Heather Miller
7df440bbaf
remove no longer used links from directory
...
BUG=skia:
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=8914
Change-Id: I8497764cf12c0a0df96ea559f0595365d76252a3
Reviewed-on: https://skia-review.googlesource.com/8914
Reviewed-by: Hal Canary <halcanary@google.com>
Commit-Queue: Hal Canary <halcanary@google.com>
2017-02-23 16:08:20 +00:00
Ben Wagner
33064926c7
Update codesearch docs.
...
BUG=skia:
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=8321
Change-Id: Ia8c87fbb3b2380c18d27bffbbd060a0d77194f7d
Reviewed-on: https://skia-review.googlesource.com/8321
Reviewed-by: Joe Gregorio <jcgregorio@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
2017-02-10 21:47:45 +00:00
Hal Canary
4d3adb6b0d
bin/sync : call tools/git-sync-deps now
...
Also, update some docs.
NOTRY=true
Change-Id: I7ad3375fc1cbf8f71ed42a460ecfe29ef6c1d85e
Reviewed-on: https://skia-review.googlesource.com/7657
Reviewed-by: Hal Canary <halcanary@google.com>
Commit-Queue: Hal Canary <halcanary@google.com>
2017-01-27 16:03:35 +00:00
Skia_Android Canary Bot
5b92e4ab8e
Fix autoroller instructions
...
BUG=skia:6065
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=7377
Change-Id: Iefd6af3104f4aea2f2ae93c556b6b429e54ebff4
Reviewed-on: https://skia-review.googlesource.com/7377
Reviewed-by: Matt Sarett <msarett@google.com>
Commit-Queue: Ravi Mistry <rmistry@google.com>
2017-01-23 15:53:15 +00:00
Eric Boren
6d4d6cce5e
Update Buildbot doc for Task Scheduler
...
BUG=skia:6118
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=7023
Change-Id: I398f4fd98959bb37bcb5499d38e517542e0df90f
Reviewed-on: https://skia-review.googlesource.com/7023
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
2017-01-17 14:54:12 +00:00
Ravi Mistry
b5bb0d2292
Add robocop instructions on how to interact with the autoroller
...
BUG=skia:6065
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=6812
Change-Id: I04acc6d4a75ce01a3c0af94091ada84aeadc7da8
Reviewed-on: https://skia-review.googlesource.com/6812
Reviewed-by: Derek Sollenberger <djsollen@google.com>
Commit-Queue: Ravi Mistry <rmistry@google.com>
2017-01-09 20:02:10 +00:00
Yuqian Li
db90e26e2b
Fix typos in the sheriffing document
...
BUG=skia:
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=6470
Change-Id: Id80f5bb1a3f0279162b0397fd6822aec83eae322
Reviewed-on: https://skia-review.googlesource.com/6470
Reviewed-by: Stephan Altmueller <stephana@google.com>
Commit-Queue: Stephan Altmueller <stephana@google.com>
2016-12-29 15:38:01 +00:00
Derek Sollenberger
cb2c8ae42a
Add documentation for being a Android RoboCop.
...
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=5759
Change-Id: I6172c9edfcac63855b3f7c2b120bac44760a24a5
Reviewed-on: https://skia-review.googlesource.com/5759
Reviewed-by: Leon Scroggins <scroggo@google.com>
Commit-Queue: Derek Sollenberger <djsollen@google.com>
2016-12-12 13:35:19 +00:00
Hal Canary
a4a3381790
tools and docs: clean up gyp-specific things
...
BUG=skia:
DOCS_PREVIEW= https://skia.org/?cl=5770
Change-Id: Iadc436a68cbf7ec0d1dd3c019072eb28bf589bb6
Reviewed-on: https://skia-review.googlesource.com/5770
Commit-Queue: Hal Canary <halcanary@google.com>
Reviewed-by: Mike Klein <mtklein@chromium.org>
2016-12-09 21:15:27 +00:00
Joe Gregorio
87da4efd63
docs: Use the new floating ment on skpaint.md
...
Screenshot:
https://screenshot.googleplex.com/C3E0hpuNwdu.png
https://screenshot.googleplex.com/vdfQMRc24Nv.png
BUG=skia:
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=5757
Change-Id: I00b1bb01cab05592d19f020f3190576bf7907aa2
Reviewed-on: https://skia-review.googlesource.com/5757
Reviewed-by: Hal Canary <halcanary@google.com>
Commit-Queue: Joe Gregorio <jcgregorio@google.com>
2016-12-09 16:43:56 +00:00
Joe Gregorio
dd56632ae3
docs: Update Perf docs.
...
BUG=skia:
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=5458
Change-Id: If8a452711076bef19566fa64a5a52ca9b3e7b83c
Reviewed-on: https://skia-review.googlesource.com/5458
Reviewed-by: Heather Miller <hcm@google.com>
Commit-Queue: Heather Miller <hcm@google.com>
2016-12-01 20:51:04 +00:00
Ben Wagner
aa5fe5ef07
Clarify documentation for CQ_INCLUDE_TRYBOTS.
...
BUG=skia:
DOCS_PREVIEW= https://skia.org/?cl=5330
CQ_INCLUDE_TRYBOTS=skia.primary:Test-Win-MSVC-ShuttleC-GPU-GTX960-x86_64-Debug-ANGLE
Change-Id: I2e9fa401c470951a8676c2357bb409d136b971ad
Reviewed-on: https://skia-review.googlesource.com/5330
Reviewed-by: Ravi Mistry <rmistry@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
2016-11-30 15:39:31 +00:00
Hal Canary
d7148f673a
Documentation: move some things around
...
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=4750
Change-Id: I0d1bc77a533ede8e0514ff0b680a5aa851051fc6
Reviewed-on: https://skia-review.googlesource.com/4750
Reviewed-by: Heather Miller <hcm@google.com>
Commit-Queue: Hal Canary <halcanary@google.com>
2016-11-14 14:31:14 +00:00
Hal Canary
64dded3d95
Documentation: more gn, less gyp
...
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4698
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=4698
Change-Id: I03100542752a769060a7f0c9671cc44acbea2e48
Reviewed-on: https://skia-review.googlesource.com/4698
Reviewed-by: Mike Klein <mtklein@chromium.org>
Commit-Queue: Hal Canary <halcanary@google.com>
2016-11-11 16:59:14 +00:00
Ravi Mistry
152ad7e7fb
Update skia.org docs to reference Gerrit instead of Rietveld
...
BUG=skia:5958
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4648
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=4648
Change-Id: I6a57b7f9b92f6b769ba2b78f8e0ab9f4ae7bb24e
Reviewed-on: https://skia-review.googlesource.com/4648
Commit-Queue: Ravi Mistry <rmistry@google.com>
Reviewed-by: Heather Miller <hcm@google.com>
2016-11-10 16:20:59 +00:00
Ben Wagner
d49128ab8e
Add note about CQ_INCLUDE_TRYBOTS and -Trybot suffix.
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4428
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=4428
Change-Id: I5f1fc4ad1cca50ed245d5c14ceff28aa7dfaee53
Reviewed-on: https://skia-review.googlesource.com/4428
Reviewed-by: Ravi Mistry <rmistry@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
2016-11-04 16:45:11 +00:00
bsalomon
bab7945563
Add documentation for using testing using the command buffer
...
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2479833003
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=2479833003
Review-Url: https://codereview.chromium.org/2479833003
2016-11-04 08:36:00 -07:00
Ben Wagner
a3f79c0b42
Update trooper doc with chrome-infra chat.
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=3745
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=3745
Change-Id: Icc9b52a7b4bc90f4ef8d8b952d49663f74104ba9
Reviewed-on: https://skia-review.googlesource.com/3745
Reviewed-by: Ravi Mistry <rmistry@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
2016-10-24 16:14:01 +00:00
Brian Salomon
30d99c66f5
Update CQ_INCLUDE_TRYBOTS examples in docs to actually be "real world"
...
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=3409
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=3409
Change-Id: I5f524b2d04822dd9780302fae9bd064d81f10c6c
Reviewed-on: https://skia-review.googlesource.com/3409
Reviewed-by: Ravi Mistry <rmistry@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
2016-10-14 14:23:39 +00:00
stephana
f79d6a1a2b
Add description to Gold
...
BUG=skia:
R=hcm,jcgregorio
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2406753002
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=2406753002
Review-Url: https://codereview.chromium.org/2406753002
2016-10-10 07:59:08 -07:00
Joe Gregorio
bc4cc336d5
Update Perf docs and add a couple screenshots.
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=3121
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=3121
Change-Id: Ic2d1743b2dc42701202ff316277db4c944d969d3
Reviewed-on: https://skia-review.googlesource.com/3121
Reviewed-by: Joe Gregorio <jcgregorio@google.com>
Commit-Queue: Joe Gregorio <jcgregorio@google.com>
2016-10-10 13:42:06 +00:00
borenet
777ee88129
Make the housekeeper upload doxygen to a newer bucket
...
BUG=skia:2969
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2370153003
DOCS_PREVIEW= https://skia.org/?cl=2370153003
Review-Url: https://codereview.chromium.org/2370153003
2016-10-04 13:23:57 -07:00
halcanary
ca9654e4c6
documentation: update PDF design doc
...
NOTRY=true
Review-Url: https://codereview.chromium.org/2295373002
2016-09-28 11:19:52 -07:00
liyuqian
21112deff8
Fix typo
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2370003002
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=2370003002
Review-Url: https://codereview.chromium.org/2370003002
2016-09-26 12:49:06 -07:00
hcm
3d89a7c0d2
Update Chrome section to include Skia roll/sheriff/bug info
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2351593003
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=2351593003
Review-Url: https://codereview.chromium.org/2351593003
2016-09-22 12:47:14 -07:00
jcgregorio
e050555bf3
docs: Add instructions on how to download isolated intermediaries.
...
Screenshot:
https://screenshot.googleplex.com/2cXAQMqypHv.png
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2316113002
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=2316113002
Review-Url: https://codereview.chromium.org/2316113002
2016-09-07 06:23:44 -07:00
rmistry
674b925227
Add trooper documentation for CT bots and for iOS "the service is invalid"
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2263103003
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=2263103003
Review-Url: https://codereview.chromium.org/2263103003
2016-08-22 12:54:54 -07:00
halcanary
4e44efe504
SkRTConf: eliminate
...
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2212473002
DOCS_PREVIEW= https://skia.org/?cl=2212473002
CQ_INCLUDE_TRYBOTS=master.client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot
[mtklein]
TBR=reed@google.com
Only removing unused public API.
Review-Url: https://codereview.chromium.org/2212473002
2016-08-04 10:47:16 -07:00
mtklein
b979634012
Revert of SkRTConf: reduce functionality to what we use, increase simplicity (patchset #8 id:150001 of https://codereview.chromium.org/2212473002/ )
...
Reason for revert:
missed GrVkPipelineStateCache
Original issue's description:
> SkRTConf: reduce functionality to what we use, increase simplicity
>
> GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2212473002
> DOCS_PREVIEW= https://skia.org/?cl=2212473002
> CQ_INCLUDE_TRYBOTS=master.client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot
>
> [mtklein]
> TBR=reed@google.com
> Only removing unused public API.
>
> Committed: https://skia.googlesource.com/skia/+/ef59974708dade6fa72fb0218d4f8a9590175c47
TBR=halcanary@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review-Url: https://codereview.chromium.org/2215433003
2016-08-03 19:19:48 -07:00
halcanary
ef59974708
SkRTConf: reduce functionality to what we use, increase simplicity
...
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2212473002
DOCS_PREVIEW= https://skia.org/?cl=2212473002
CQ_INCLUDE_TRYBOTS=master.client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot
[mtklein]
TBR=reed@google.com
Only removing unused public API.
Review-Url: https://codereview.chromium.org/2212473002
2016-08-03 15:30:37 -07:00
brianosman
fe8d2cf520
Add special Windows instructions for getting SKPs
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2184723002
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=2184723002
Review-Url: https://codereview.chromium.org/2184723002
2016-07-26 06:43:51 -07:00
borenet
1543487fc6
Change SKPs to new asset management format
...
BUG=skia:5427
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2169653003
DOCS_PREVIEW= https://skia.org/?cl=2169653003
Review-Url: https://codereview.chromium.org/2169653003
2016-07-22 08:31:07 -07:00
jcgregorio
59e3039fad
docs: Add info on using blamer to the sheriffing docs.
...
BUG=skia:
R=kjlubick
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2167803002
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=2167803002
Review-Url: https://codereview.chromium.org/2167803002
2016-07-21 05:37:28 -07:00
pdr
48898561db
Update markdown docs to specify --local for the local devserver
...
If the devserver is run locally following the instructions on
https://skia.org/dev/tools/markdown , you'll get an error about influxdb.
It looks like an influxdb username/password is required but using
--local works around this issue.
-------------------8<-------------------
$ ./bin/docserver --preview
E0703 19:33:31.510379 30448 common.go:37] Initializing logserver for log level ERROR.
F0703 19:33:31.516750 30448 common.go:63] metadata.Get() failed to make HTTP request for influxdb_name: Get http://metadata/computeMetadata/v1/project/attributes/influxdb_name : dial tcp: lookup metadata: no such host
goroutine 1 [running]:
github.com/skia-dev/glog.stacks(0x772300, 0x0, 0x0, 0x0)
/src/github.com/skia-dev/glog/glog.go:769 +0xb8
github.com/skia-dev/glog.(*loggingT).output(0x756000, 0xc800000003, 0xc820136000, 0x73613e, 0x9, 0x3f, 0x0)
/src/github.com/skia-dev/glog/glog.go:720 +0x259
github.com/skia-dev/glog.(*loggingT).printDepth(0x756000, 0x3, 0x1, 0xc8200dde28, 0x1, 0x1)
/src/github.com/skia-dev/glog/glog.go:649 +0x1b8
github.com/skia-dev/glog.(*loggingT).print(0x756000, 0x3, 0xc8200dde28, 0x1, 0x1)
/src/github.com/skia-dev/glog/glog.go:640 +0x50
github.com/skia-dev/glog.Fatal(0xc8200dde28, 0x1, 0x1)
/src/github.com/skia-dev/glog/glog.go:1128 +0x49
go.skia.org/infra/go/common.StartMetrics2(0x5103e0, 0x9, 0xc820104400, 0xc820104430, 0xc820104450, 0xc820104470, 0xc8200dde00)
/src/go.skia.org/infra/go/common/common.go:63 +0x192
go.skia.org/infra/go/common.InitWithMetrics2(0x5103e0, 0x9, 0xc820104400, 0xc820104430, 0xc820104450, 0xc820104470, 0xc820104498)
/src/go.skia.org/infra/go/common/common.go:48 +0x65
main.main()
/src/skia.googlesource.com/buildbot.git/doc/go/docserver/main.go:183 +0x95
-------------------8<-------------------
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2118113002
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=2118113002
Review-Url: https://codereview.chromium.org/2118113002
2016-07-09 17:08:24 -07:00
pdr
c42475cea2
Update markdown to use absolute image paths, fixing broken images
...
Markdown can be served with or without a trailing slash but when a
trailing slash is present, relative image links were broken.
The following example works as expected:
url: https://skia.org/dev/design/pdftheory
image url: PdfLogicalDocumentStructure.png
resolves to: https://skia.org/dev/design/PdfLogicalDocumentStructure.png
The following example was broken before this patch:
url: https://skia.org/dev/design/pdftheory/
image url: PdfLogicalDocumentStructure.png
resolves to: https://skia.org/dev/design/pdftheory/PdfLogicalDocumentStructure.png
The PdfLogicalDocumentStructure.png file lives in /dev/design/, not
/dev/design/pdftheory/. This patch updates all images in our markdown
files to be served with the full path so a trailing slash no longer
breaks images.
I hit this bug when promoting the new Skia debugger:
https://groups.google.com/a/chromium.org/d/msg/paint-dev/QJ8xpu8dNyA/F4KX2O4ZBwAJ
BUG=skia:5493
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2128013003
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=2128013003
Review-Url: https://codereview.chromium.org/2128013003
2016-07-07 14:48:53 -07:00
bungeman
52fa668dc5
Update rebaseline instructions.
...
BUG=skia:2805
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=2127953002
Review-Url: https://codereview.chromium.org/2127953002
2016-07-06 10:19:54 -07:00
pdr
1e2a702c19
Update dev docs to reference the new skia debugger (skiaserve)
...
This patch adds a new markdown file describing the new debugger along
with instructions on running it locally and a sweet screenshot. The
screenshot has been sized to not be clipped when viewed in production.
The old documentation for the qt-based debugger has been marked as
deprecated and all docs referencing the old debugger have been updated.
BUG=skia:5493
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2121673002
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=2121673002
Review-Url: https://codereview.chromium.org/2121673002
2016-07-06 06:10:25 -07:00
rmistry
d9114cb8f3
Update CT documentation on skia.org
...
BUG=skia:5465
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2103853002
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=2103853002
Review-Url: https://codereview.chromium.org/2103853002
2016-06-28 10:52:47 -07:00
rmistry
6a3f07e985
Update documentation on how to download CT SKPs
...
BUG=skia:5465
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2103443003
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=2103443003
Review-Url: https://codereview.chromium.org/2103443003
2016-06-27 12:51:47 -07:00
rmistry
0b04fea228
Update CQ keywords documentation
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2056733002
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=2056733002
Review-Url: https://codereview.chromium.org/2056733002
2016-06-09 06:56:39 -07:00
martina.kollarova
2f64bf7931
Document dm error about missing skps
...
BUG=None
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2049703002
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=2049703002
Review-Url: https://codereview.chromium.org/2049703002
2016-06-08 09:25:24 -07:00
bungeman
7ae5627be2
Update running Chromium trybots on Skia CLs docs.
...
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=1930773005
Review-Url: https://codereview.chromium.org/1930773005
2016-04-29 07:08:12 -07:00
djsollen
efe46d2094
Repurpose Release_Developer BUILDTYPE and remove SK_DEVELOPER.
...
The Release_Developer build type is now used to build Skia with
release level optimizations but still enable SK_DEBUG. This in turn
means that SkASSERTS and SkRTConf are available in this mode.
Further we can then remove SK_DEVELOPER as a define as it is true
iff SK_DEBUG is true.
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1931903002
DOCS_PREVIEW= https://skia.org/?cl=1931903002
Review-Url: https://codereview.chromium.org/1931903002
2016-04-29 06:41:35 -07:00
reed
28d5bdd97e
Revert of Repurpose Release_Developer BUILDTYPE and remove SK_DEVELOPER. (patchset #2 id:20001 of https://codereview.chromium.org/1927583002/ )
...
Reason for revert:
still blocking DEPS roll
Original issue's description:
> Repurpose Release_Developer BUILDTYPE and remove SK_DEVELOPER.
>
> The Release_Developer build type is now used to build Skia with
> release level optimizations but still enable SK_DEBUG. This in turn
> means that SkASSERTS and SkRTConf are available in this mode.
>
> Further we can then remove SK_DEVELOPER as a define as it is true
> iff SK_DEBUG is true.
> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1927583002
> DOCS_PREVIEW= https://skia.org/?cl=1927583002
>
> Committed: https://skia.googlesource.com/skia/+/48d6f88479e72efaf9b9d8f9c0769acb1ba773db
TBR=bungeman@gmail.com ,bungeman@google.com,benjaminwagner@google.com,djsollen@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review-Url: https://codereview.chromium.org/1918253006
2016-04-28 08:12:55 -07:00
djsollen
48d6f88479
Repurpose Release_Developer BUILDTYPE and remove SK_DEVELOPER.
...
The Release_Developer build type is now used to build Skia with
release level optimizations but still enable SK_DEBUG. This in turn
means that SkASSERTS and SkRTConf are available in this mode.
Further we can then remove SK_DEVELOPER as a define as it is true
iff SK_DEBUG is true.
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1927583002
DOCS_PREVIEW= https://skia.org/?cl=1927583002
Review-Url: https://codereview.chromium.org/1927583002
2016-04-27 13:37:23 -07:00
liyuqian
cbaafc34bc
Add runhooks to multi_repo_trybots
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1924573002
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=1924573002
Review URL: https://codereview.chromium.org/1924573002
2016-04-26 12:54:05 -07:00
bungeman
bc95173756
Explain Rietveld patching better on site.
...
State which values should be updated and how to determine them.
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=1883213002
Review URL: https://codereview.chromium.org/1883213002
2016-04-14 10:25:01 -07:00
bungeman
ccb0de64f3
Add doc instructions for multi-repo Chromium trybots.
...
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=1865153003
Review URL: https://codereview.chromium.org/1865153003
2016-04-14 09:23:41 -07:00
bungeman
85c9447d4d
Add note about Chromium's use of old libstdc++ to docs.
...
Chromium must still build against libstdc++4.6.4, which presents limits
on at least type traits and perhaps performance.
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=1820873002
Review URL: https://codereview.chromium.org/1820873002
2016-03-21 07:46:28 -07:00
halcanary
3bcef213d1
documentation: simplify pdf diagram
...
NOTRY=true
TBR=
Review URL: https://codereview.chromium.org/1810943003
2016-03-17 13:33:50 -07:00
halcanary
b78afe9286
documentation: simplify pdf diagram
...
NOTRY=true
TBR=
Review URL: https://codereview.chromium.org/1810943003
2016-03-17 13:27:57 -07:00
halcanary
3eac8d1b23
Doc: pdf illustration
...
TBR=
NOTRY=true
Review URL: https://codereview.chromium.org/1807963002
2016-03-16 10:19:33 -07:00
halcanary
1cc345f699
Documentation: sync-and-gyp design document
...
NOTRY=true
DOCS_PREVIEW= https://skia.org/dev/design/sync-and-gyp?cl=1736483002
Review URL: https://codereview.chromium.org/1736483002
2016-02-24 10:50:35 -08:00
benjaminwagner
e52bebbb47
skia.org internal links: Add link to Google3 Autoroller doc.
...
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1720943003
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=1720943003
Review URL: https://codereview.chromium.org/1720943003
2016-02-22 09:31:38 -08:00
halcanary
6f96cf4bde
Documantation: nanobench
...
DOCS_PREVIEW= https://skia.org/dev/testing/tests?cl=1696723002
https://skia.org/dev/testing/tests?cl=1696723002#bench
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1696723002
NOTRY=true
Review URL: https://codereview.chromium.org/1696723002
2016-02-12 08:08:27 -08:00
rmistry
d31588523c
Documentation for accessing the different repositories of SKPs
...
BUG=skia:2306
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1683233002
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=1683233002
Review URL: https://codereview.chromium.org/1683233002
2016-02-10 12:55:07 -08:00
kjlubick
a58ec2162c
Fix autoroll link
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1676993002
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=1676993002
Review URL: https://codereview.chromium.org/1676993002
2016-02-08 05:23:37 -08:00
mtklein
98b2f0c096
update C++11 doc
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1678673002
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=1678673002
Review URL: https://codereview.chromium.org/1678673002
2016-02-06 15:45:28 -08:00
benjaminwagner
5962957d95
Fix typo on trooper page.
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1642183002
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=1642183002
Review URL: https://codereview.chromium.org/1642183002
2016-01-28 12:58:02 -08:00
hcm
4020665b81
Fix patch check-in instructions for non-committers
...
BUG=skia:4681
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1606003003
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=1606003003
Review URL: https://codereview.chromium.org/1606003003
2016-01-19 13:57:27 -08:00
jcgregorio
8bae7c537a
docs: Fix link to 'How to submit a patch'.
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1579593002
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=1579593002
Review URL: https://codereview.chromium.org/1579593002
2016-01-11 07:42:33 -08:00
caryclark
201efb5ae0
try again on md formatting
...
TBR=hcm@google.com
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=1520533002
Review URL: https://codereview.chromium.org/1520533002
2015-12-10 08:03:58 -08:00
caryclark
9ca30a3b9b
add path ops presentations to skia.org
...
TBR=hcm@google.com
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=1518453003
Review URL: https://codereview.chromium.org/1518453003
2015-12-10 06:29:44 -08:00
borenet
b1514801cc
Add documentation for Status bot filters
...
BUG=skia:4602
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=1489583002
Review URL: https://codereview.chromium.org/1489583002
2015-11-30 09:58:56 -08:00
jcgregorio
15d5b82f90
Add an example of embedding a Skia Perf graph to the site docs.
...
This specific page:
https://skia.org/dev/testing/skiaperf?cl=1462583002
BUG=skia:
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=1462583002
Review URL: https://codereview.chromium.org/1462583002
2015-11-18 11:14:31 -08:00
rmistry
7224ae9d51
Update all code site issue tracker links to point to bug.skia.org
...
BUG=skia:
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=1461613002
Review URL: https://codereview.chromium.org/1461613002
2015-11-18 06:47:11 -08:00
halcanary
e0c64c5846
Documentation: clean up
...
- /user/quick/desktop to bring together all common information for
using Skia on desktop OSes. Remove duplication.
- Replace all instances of call ing gyp_skia directly with calling
`python bin/sync-and-gyp`. This is more correct on Windows
- Remove outdated linux prerequisite packages
- Formatting, formatting, formatting.
- Note command-line syntax differences in Windows
- SampleApp.app is no longer a bundle on MacOS
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=1439493003
Review URL: https://codereview.chromium.org/1439493003
2015-11-13 04:29:59 -08:00
halcanary
3a210bfd40
Documentation - Remove references to gclient sync
...
skia.org/user/download
- Move sections "Making changes" and "Uploading changes for review"
to "How to submit a patch" page
- Mention bin/sync-and-gyp
skia.org/dev/contrib/submit
- Mention branch.autosetuprebase=always to fit with Skia's linear
history style.
NOTRY=true
DOCS_PREVIEW= https://skia.org/user/download?cl=1411403010
DOCS_PREVIEW= https://skia.org/dev/contrib/submit?cl=1411403010
Review URL: https://codereview.chromium.org/1411403010
2015-11-09 11:47:09 -08:00
halcanary
6950de6c41
Comments Style: s/skbug.com/bug.skia.org/
...
DOCS_PREVIEW= https://skia.org/?cl=1432503003
Review URL: https://codereview.chromium.org/1432503003
2015-11-07 05:29:00 -08:00
hcm
6065d8eae6
Adding Skia Debugger documentation
...
BUG=skia:
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=1414393010
Review URL: https://codereview.chromium.org/1414393010
2015-11-06 11:29:06 -08:00
stephana
5b8faf7c7c
Add docs on how to install iOS test tools
...
BUG=skia:
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=1413653002
Review URL: https://codereview.chromium.org/1413653002
2015-10-16 11:47:37 -07:00
benjaminwagner
e8dc3f2f0b
Move code search info to sub-page. Add additional code search options.
...
BUG=skia:
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=1375523003
Review URL: https://codereview.chromium.org/1375523003
2015-09-28 11:15:09 -07:00