Commit Graph

33540 Commits

Author SHA1 Message Date
angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com
876dd31483 Roll skia/third_party/externals/angle2/ 1c08cbb39..dfebe9b2d (4 commits)
1c08cbb398..dfebe9b2d5

$ git log 1c08cbb39..dfebe9b2d --date=short --no-merges --format='%ad %ae %s'
2018-03-14 jmadill D3D11: Add dirty bits for Transform Feedback.
2018-03-14 jmadill Vulkan: Enable SimpleVertexShader.
2018-03-16 jmadill Vulkan: Implement depth range correction.
2018-03-14 jmadill Remove HasIndexRange.

Created with:
  roll-dep skia/third_party/externals/angle2


The AutoRoll server is located here: https://angle-skia-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Build-Debian9-Clang-x86_64-Release-ANGLE
TBR=stephana@google.com

Change-Id: I896a161b718b1fcf79729bcf513e60c8a3ea330f
Reviewed-on: https://skia-review.googlesource.com/114880
Reviewed-by: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
2018-03-17 00:03:40 +00:00
Stan Iliev
0a86820f2f Revert "fix nextContour bug"
This reverts commit 473f69276f.

Reason for revert: a CTS test PathMeasureTest.android.graphics.cts.PathMeasureTest.testNextContour is failing

Original change's description:
> fix nextContour bug
> 
> Calling nextContour() needs to ensure that we've already measured the "current" one.
> 
> Bug: skia:
> Change-Id: I501c26d0b068028d67103888f06ec89125a5407a
> Reviewed-on: https://skia-review.googlesource.com/114692
> Reviewed-by: Cary Clark <caryclark@google.com>
> Commit-Queue: Mike Reed <reed@google.com>

TBR=caryclark@google.com,reed@google.com

Change-Id: I7f1e08651dfe73c02158b209dc28af2b174e246f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: skia:
Reviewed-on: https://skia-review.googlesource.com/114823
Reviewed-by: Stan Iliev <stani@google.com>
Commit-Queue: Stan Iliev <stani@google.com>
2018-03-16 21:01:16 +00:00
Greg Daniel
55fa647596 Correctly discard or load RT when doing copies as draws in Vulkan
This fixes all the copy as draw issues we've had with certain devices and
the cap is no longer needed.

Bug: skia:
Change-Id: Id0b750849c4c920beae2d8cb3eda5f402018f194
Reviewed-on: https://skia-review.googlesource.com/114860
Commit-Queue: Greg Daniel <egdaniel@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
2018-03-16 20:54:26 +00:00
Ben Wagner
041e7ced7c Add GT610 Debug ANGLE jobs.
Bug: skia:7312
Change-Id: Ib84b57c8ca029e94da8897de5b7d400a394bf87c
No-Try: true
Reviewed-on: https://skia-review.googlesource.com/74140
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
2018-03-16 20:43:16 +00:00
Herb Derby
76d69b44bb Apply filterTextFlags so the fonts are the same.
In order to apply filterTextFlags correctly, teach
TrackLayerDevice how to process save and restore layers.

At this point, I don't see any other traffic than the
cache warming traffic.

This code has a performance between 82% and 105% of just
drawing the picture.

BUG=skia:7515

Change-Id: I44736be46884f18b6d120d4b5ca582f34dbdff0f
Reviewed-on: https://skia-review.googlesource.com/114641
Reviewed-by: Herb Derby <herb@google.com>
Commit-Queue: Herb Derby <herb@google.com>
2018-03-16 20:28:36 +00:00
Greg Daniel
7278d68cac Add DoneProc to Promise Images
This proc will notify the client when we will no longer call fulfill on
their promise image so that can delete any meta data they needed to store
to be able to complete the fulfill requests.

Bug: skia:
Change-Id: Ife1e6845f221c31ce1ae2c0d2ba5e4c8f0203b74
Reviewed-on: https://skia-review.googlesource.com/114092
Commit-Queue: Greg Daniel <egdaniel@google.com>
Reviewed-by: Robert Phillips <robertphillips@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
2018-03-16 19:27:46 +00:00
Mike Reed
7ba427ef40 handle bad xform in drawTextRSXform
Bug: oss-fuzz:6955
Change-Id: Ide1f57459a611980a86afea577eb4c2425e49e63
Reviewed-on: https://skia-review.googlesource.com/114782
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Mike Reed <reed@google.com>
2018-03-16 19:03:16 +00:00
Mike Reed
b5319d5e13 fix overflow in rgnbuilder
Bug: oss-fuzz:6956
Change-Id: I244e49d458eb78e0c6200fc3c147f0f67823f97f
Reviewed-on: https://skia-review.googlesource.com/114780
Reviewed-by: Herb Derby <herb@google.com>
Commit-Queue: Mike Reed <reed@google.com>
2018-03-16 19:02:06 +00:00
Ravi Mistry
310a2d9280 Revert "Remove Android Framework bot from CQ while server is being upgraded"
This reverts commit 2ab6f7e580.

Reason for revert: Server back with more cores

Original change's description:
> Remove Android Framework bot from CQ while server is being upgraded
> 
> NoTry: true
> Bug: skia:7716
> Change-Id: I67695c5f45ac5b9c57d0599ba2ab2e825fa75e4b
> Reviewed-on: https://skia-review.googlesource.com/114788
> Reviewed-by: Ravi Mistry <rmistry@google.com>
> Reviewed-by: Ben Wagner <benjaminwagner@google.com>
> Commit-Queue: Ravi Mistry <rmistry@google.com>
> Commit-Queue: Ben Wagner <benjaminwagner@google.com>

TBR=benjaminwagner@google.com,rmistry@google.com

Change-Id: I01626d9a4de98a27a350b053cb1aa7612d71d136
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: skia:7716
Reviewed-on: https://skia-review.googlesource.com/114820
Reviewed-by: Ravi Mistry <rmistry@google.com>
Commit-Queue: Ravi Mistry <rmistry@google.com>
2018-03-16 18:40:36 +00:00
Cary Clark
681287eb67 more imageinfo text and warnings and cleanup
more imageinfo text

rewrote many examples to fix newly exposed compiler warnings

marked a couple of YUV method bodies as deprecated

also cleaned up line endings to use the linux style

R=bsalomon@google.com
TBR=caryclark@google.com
Docs-Preview: https://skia.org/?cl=112302
Bug: skia:6898
Change-Id: I89626a27353aa84526f9b9475d927bd0e9d8f0d5
Reviewed-on: https://skia-review.googlesource.com/112302
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Cary Clark <caryclark@google.com>
2018-03-16 18:11:35 +00:00
Greg Daniel
a3c68df565 Make sure we do a render pass load if we copied to a surface before hand
Bug: skia:
Change-Id: I4858e0774956f6283122bf71c84f3c6161e1d349
Reviewed-on: https://skia-review.googlesource.com/114790
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Greg Daniel <egdaniel@google.com>
2018-03-16 18:10:25 +00:00
Ethan Nicholas
16c1196ea6 fix SkSL SPIR-V geometry shaders' entry point declaration
Bug: skia:
Change-Id: I5cd5a35fe1a554b127548a7809c106de70df0be7
Reviewed-on: https://skia-review.googlesource.com/114785
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
2018-03-16 17:54:05 +00:00
Ravi Mistry
2ab6f7e580 Remove Android Framework bot from CQ while server is being upgraded
NoTry: true
Bug: skia:7716
Change-Id: I67695c5f45ac5b9c57d0599ba2ab2e825fa75e4b
Reviewed-on: https://skia-review.googlesource.com/114788
Reviewed-by: Ravi Mistry <rmistry@google.com>
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
Commit-Queue: Ravi Mistry <rmistry@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
2018-03-16 17:21:51 +00:00
Ethan Nicholas
6c94271f55 we now complain if an SkSL program tries to override the default output
Bug: skia:
Change-Id: I387ddc3aac0712eb6c0a6ea39e48e5f3d809bc48
Reviewed-on: https://skia-review.googlesource.com/114691
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
2018-03-16 16:44:11 +00:00
Greg Daniel
ea022cd714 Fix vulkan layout barriers when we are doing in line uploads.
Bug: skia:
Change-Id: I0842a4eebba8cfa8310d0680941d59f1e363e574
Reviewed-on: https://skia-review.googlesource.com/114760
Reviewed-by: Jim Van Verth <jvanverth@google.com>
Commit-Queue: Greg Daniel <egdaniel@google.com>
2018-03-16 15:54:01 +00:00
angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com
8b858526fa Roll skia/third_party/externals/angle2/ 5ae6ee457..1c08cbb39 (1 commit)
5ae6ee4578..1c08cbb398

$ git log 5ae6ee457..1c08cbb39 --date=short --no-merges --format='%ad %ae %s'
2018-03-15 jiawei.shao Clean up link validations on interface blocks

Created with:
  roll-dep skia/third_party/externals/angle2


The AutoRoll server is located here: https://angle-skia-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Build-Debian9-Clang-x86_64-Release-ANGLE
TBR=stephana@google.com

Change-Id: Ic7da673d0bda6d4c013112c2f7b39c73611cadc6
Reviewed-on: https://skia-review.googlesource.com/114694
Commit-Queue: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
2018-03-16 15:22:11 +00:00
Mike Reed
473f69276f fix nextContour bug
Calling nextContour() needs to ensure that we've already measured the "current" one.

Bug: skia:
Change-Id: I501c26d0b068028d67103888f06ec89125a5407a
Reviewed-on: https://skia-review.googlesource.com/114692
Reviewed-by: Cary Clark <caryclark@google.com>
Commit-Queue: Mike Reed <reed@google.com>
2018-03-16 15:11:31 +00:00
Greg Daniel
e464160f69 Fix Vulkan Copy as draw shader
Bug: skia:7663
Change-Id: I745900ccc56c697e4abb982e921d99bc28502b33
Reviewed-on: https://skia-review.googlesource.com/114687
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Greg Daniel <egdaniel@google.com>
2018-03-16 13:36:51 +00:00
Robert Phillips
874b5357da Prevent crash when flushing while DDL recording
Change-Id: I35e96d3c3020092b33d9b952394d40d4fd5a587b
Reviewed-on: https://skia-review.googlesource.com/114685
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>
2018-03-16 13:30:01 +00:00
Brian Osman
91fba61f24 Support GL_OES_EGL_image_external on newer GLSL without essl3
Bug: skia:7713
Change-Id: I15c6a55370848cd211c783c886923f31dec1788c
Reviewed-on: https://skia-review.googlesource.com/114505
Commit-Queue: Brian Osman <brianosman@google.com>
Reviewed-by: Robert Phillips <robertphillips@google.com>
2018-03-16 13:08:32 +00:00
Greg Daniel
6e9a4f6327 Make TestForPreservingPMConversions helper use lazy createTextureProxy call.
Bug: skia:
Change-Id: I337efc531aa5685c138b2f9e2bd47b47ba4e1fd5
Reviewed-on: https://skia-review.googlesource.com/114583
Reviewed-by: Robert Phillips <robertphillips@google.com>
Commit-Queue: Greg Daniel <egdaniel@google.com>
2018-03-16 12:25:51 +00:00
Ravi Mistry
bcc00b2a61 Output fiddleout.json in bookmaker recipe
Bug: skia:
Change-Id: Id4c613385a6948af9808dfbaef8f437e765fb9b5
Reviewed-on: https://skia-review.googlesource.com/114571
Commit-Queue: Ravi Mistry <rmistry@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
2018-03-16 11:55:11 +00:00
angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com
36221f9377 Roll skia/third_party/externals/angle2/ 44a73fcfb..5ae6ee457 (2 commits)
44a73fcfbe..5ae6ee4578

$ git log 44a73fcfb..5ae6ee457 --date=short --no-merges --format='%ad %ae %s'
2018-03-06 jiajia.qin ES31: Sync dirty objects for compute shader
2018-03-08 oetuaho Don't use TIntermSymbol nodes for function parameters

Created with:
  roll-dep skia/third_party/externals/angle2


The AutoRoll server is located here: https://angle-skia-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Build-Debian9-Clang-x86_64-Release-ANGLE
TBR=stephana@google.com

Change-Id: I4d8d978eb7a9f647e4dfa8759acb96438361f05e
Reviewed-on: https://skia-review.googlesource.com/114700
Commit-Queue: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
2018-03-16 04:01:11 +00:00
Ben Wagner
8402542dac Fix GPU dimension for Win2k8 QuadroP400 jobs.
Fixes a bug in https://skia-review.googlesource.com/113740

No-Try: true
Change-Id: I1d03f1a266dfb50b223c665a44bc0ace8ab081c7
Reviewed-on: https://skia-review.googlesource.com/114621
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
2018-03-15 21:54:06 +00:00
Robert Phillips
6ceaafa7b9 Handle GrContext creation failure in DDL
TBR=bsalomon@google.com
Change-Id: Ib34448a60cb127ef89bcb0b1f85d07abc91af582
Reviewed-on: https://skia-review.googlesource.com/114569
Reviewed-by: Brian Salomon <bsalomon@google.com>
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>
2018-03-15 21:25:16 +00:00
Leon Scroggins III
af18f22da6 Make get_images_from_skps always return success
Previously, it would fail (and thus turn the bot red) if an image failed
to decode (e.g. with SkCodec::Result of kInvalidInput). This tends to
happen because the captured page had not fully downloaded yet. Stop
treating this an error. It may still be useful to test using SkCodec
just to be sure that we didn't crash, so keep running the test.

Change-Id: I1a0530fb82fa32d95c5f01d5131626745cf6c4f2
Reviewed-on: https://skia-review.googlesource.com/114582
Reviewed-by: Ravi Mistry <rmistry@google.com>
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Leon Scroggins <scroggo@google.com>
2018-03-15 21:13:26 +00:00
Mike Reed
e489c9f03d rm guard for google3
Bug: skia:
Change-Id: I86495e0fefff2dbd34e39e3a0be891bfc62ec08b
Reviewed-on: https://skia-review.googlesource.com/114581
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Mike Reed <reed@google.com>
2018-03-15 20:18:19 +00:00
Brian Salomon
6a426c1d72 Cleanup SkImage YUV texture factories.
Remove unused GrBackendObject variants.

Add versions without redundant size param.

Make this work with GrBackendTextures that weren't created with a GrPixelConfig.

Change-Id: Ic1bbf5f2817cebab938b4f31000126a6ab5c44d5
Reviewed-on: https://skia-review.googlesource.com/114460
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
2018-03-15 19:41:26 +00:00
angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com
1a11437789 Roll skia/third_party/externals/angle2/ 0b0dcbc1c..44a73fcfb (2 commits)
0b0dcbc1cf..44a73fcfbe

$ git log 0b0dcbc1c..44a73fcfb --date=short --no-merges --format='%ad %ae %s'
2018-03-06 brandon1.jones Always Invalidate Vertex Attribute Translation
2018-03-13 lucferron Vulkan: Additional texture formats support. RGB565, RGBA4444, RGBA5551

Created with:
  roll-dep skia/third_party/externals/angle2


The AutoRoll server is located here: https://angle-skia-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Build-Debian9-Clang-x86_64-Release-ANGLE
TBR=stephana@google.com

Change-Id: I830a5f7b33ad65524aab37112dc954969028608a
Reviewed-on: https://skia-review.googlesource.com/114564
Reviewed-by: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
2018-03-15 19:11:46 +00:00
Mike Reed
e11d793294 detect non-finite pts
Bug: oss-fuzz:6638
Change-Id: I72dab6783099facbe8d658ec1bc4b175a383e174
Reviewed-on: https://skia-review.googlesource.com/114565
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Mike Reed <reed@google.com>
2018-03-15 19:06:46 +00:00
Ben Wagner
f6148b6d23 Upgrade OS and NVIDIA driver on Win10 Golo/MTV lab bots.
Bug: chromium:821040, chromium:821857
No-Try: true
Change-Id: Iebad9eca31dedfda484faa91333c42c3ba3df186
Reviewed-on: https://skia-review.googlesource.com/113740
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
2018-03-15 18:47:36 +00:00
Robert Phillips
f733a72b83 Disable CCPR path rendering in DDL mode
Change-Id: Ib16a7b037eff6cd0528177646c2eced467763a06
Reviewed-on: https://skia-review.googlesource.com/114560
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>
2018-03-15 18:39:06 +00:00
Robert Phillips
36150be729 Add DDL SkpOnly bot
Change-Id: If9402ad5a3ae7d17221cf1bca621b8aad4d9e9d0
Reviewed-on: https://skia-review.googlesource.com/114466
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>
2018-03-15 18:33:57 +00:00
Eric Boren
464846e1a5 update_meta_config: Use new LUCI optional GPU trybot
Bug: skia:
Change-Id: I1eca549d38b64869a763951b8469712d620e24bf
Reviewed-on: https://skia-review.googlesource.com/114516
Reviewed-by: Ravi Mistry <rmistry@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
2018-03-15 18:14:26 +00:00
Mike Reed
9c2916e0c7 drawTextRSXform should not apply matrix to shader
drawTextRSXform should draw the same as drawTextOnPath (as regards shaders)

Bug: b/69904791
Change-Id: I393dd8fd7a5bdc6a018b1ca33592b208c7141868
Reviewed-on: https://skia-review.googlesource.com/114468
Commit-Queue: Mike Reed <reed@google.com>
Reviewed-by: Herb Derby <herb@google.com>
Reviewed-by: Florin Malita <fmalita@chromium.org>
2018-03-15 18:14:16 +00:00
Greg Daniel
bdea98cff1 Delete unused VkClearTest
Bug: skia:
Change-Id: I4aa1886e7f4048fc13a741ddbc37b9ca3f48a41d
Reviewed-on: https://skia-review.googlesource.com/114510
Commit-Queue: Ben Wagner <bungeman@google.com>
Reviewed-by: Ben Wagner <bungeman@google.com>
2018-03-15 17:30:26 +00:00
Hal Canary
25375e80c2 GrGLES: unify MakeNativeInterface_{android,egl}
BUG=skia:3508
Change-Id: Ibc98ea3e579cb545635c28d345cae24f57d0c2a3
Reviewed-on: https://skia-review.googlesource.com/114471
Commit-Queue: Hal Canary <halcanary@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
2018-03-15 17:10:56 +00:00
Cary Clark
b8421edb47 fix pathops fuzzers and debugging
En route to fixing fuzzer bugs, I discovered that most
debugging in pathops was broken. Pathops has extensive
runtime functions that trace links and connections between
data structures that are invaluable to debugging. The
only practical way to use these functions is to call them
from the debugger in immediate mode.

Some time, some where, the MSVS Immediate Window ceased
to be able to call functions that are members of structs
or classes, and functions that take templated parameters.

I can find no mention of this on the web, so I assume
that something about our setup is triggering this, but
I've had no luck finding the culprit.

In the meantime, I've added global functions wrapped in
a namespace to sneak calls to these functions without
MSVS being any the wiser. While this works, it is likely
to bitrot by tomorrow or next Tuesday so I will continue
to try to find and fix the root cause.

This also fixes the fuzzer bugs; generally one-line edits
that change asserts to fails. All pathops tests succeed
with this. To run all tests, do:
./out/debug/pathops_unittest -V -x
./out/release/pathops_unittest -V -x

TBR=caryclark@google.com
Bug: skia:
Change-Id: I956ae3d8df6d25e155e62bd6dede64519c7fbdb1
Reviewed-on: https://skia-review.googlesource.com/114321
Reviewed-by: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Cary Clark <caryclark@skia.org>
Commit-Queue: Cary Clark <caryclark@skia.org>
2018-03-15 17:07:16 +00:00
Herb Derby
c2ec4e8d83 SkAutoGlyphCache change some sites to Find*.
Change-Id: Iec3a0c60106017394fcdd981052713b6e42fa595
Reviewed-on: https://skia-review.googlesource.com/114506
Commit-Queue: Herb Derby <herb@google.com>
Reviewed-by: Ben Wagner <bungeman@google.com>
2018-03-15 16:59:46 +00:00
Robert Phillips
7f4419696b Make CreateBackendFormatFromTexture shared code
TBR=bsalomon@google.com
Change-Id: I19e6e6c8dc32ba584738545d443de092e4987a5a
Reviewed-on: https://skia-review.googlesource.com/114374
Reviewed-by: Robert Phillips <robertphillips@google.com>
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>
2018-03-15 16:51:36 +00:00
Greg Daniel
4f4a53f948 Fix initialLayout update in Vk createTestingOnlyImage
Bug: skia:
Change-Id: I5d4321e68c065e3775266994c65a4abf18360731
Reviewed-on: https://skia-review.googlesource.com/114497
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Greg Daniel <egdaniel@google.com>
2018-03-15 15:10:56 +00:00
Alexis Hetu
0e90f9849a Check GL_EXT_texture_format_BGRA8888 before GL_APPLE_texture_format_BGRA8888
When both GL_EXT_texture_format_BGRA8888 and GL_APPLE_texture_format_BGRA8888
extensions are present, the presence of GL_APPLE_texture_format_BGRA8888 was
preventing GL_EXT_texture_format_BGRA8888 from allowing BGRA8888 to be used
as a render target. By checking for GL_EXT_texture_format_BGRA8888 first,
this solves the issue.

The issue was encountered trying to run vr_pixeltests on top of SwiftShader
on the bots with a version of SwiftShader exposing both extension strings.

Change-Id: I446ec502a4703d24c24339708dcbbe9c334a7533
Reviewed-on: https://skia-review.googlesource.com/114495
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Alexis Hetu <sugoi@google.com>
2018-03-15 14:51:06 +00:00
Cary Clark
5d389c2359 protect PathMeasure against input paths with NaNs
found by fuzzer

R=kjlubick@google.com
Bug: skia:
Change-Id: Ifde8706a7ca6fad785a1b0b50f3df3fb099c0e36
Reviewed-on: https://skia-review.googlesource.com/114477
Reviewed-by: Kevin Lubick <kjlubick@google.com>
Commit-Queue: Cary Clark <caryclark@skia.org>
2018-03-15 14:34:26 +00:00
Robert Phillips
38eb740b94 Remove SK_RASTER_RECORDER_IMPLEMENTATION
TBR=bsalomon@google.com
Change-Id: I9608ce5ce2b9d38c5e356d8428a8ff05df6ccda7
Reviewed-on: https://skia-review.googlesource.com/114490
Commit-Queue: Robert Phillips <robertphillips@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
Reviewed-by: Greg Daniel <egdaniel@google.com>
2018-03-15 12:55:06 +00:00
Greg Daniel
0fe4ed8598 Revert "ccpr: Unblacklist vulkan"
This reverts commit 30ce2a3620.

Reason for revert: Crashing drivers on intel and powerVR. Possible SPIR-V error

Original change's description:
> ccpr: Unblacklist vulkan
> 
> All issues have been resolved.
> 
> Bug: skia:
> Change-Id: Id63d63ad081725885cb0225b410b0d3972abd8f7
> Reviewed-on: https://skia-review.googlesource.com/113060
> Commit-Queue: Chris Dalton <csmartdalton@google.com>
> Reviewed-by: Greg Daniel <egdaniel@google.com>

TBR=egdaniel@google.com,csmartdalton@google.com

Change-Id: Ibb9ea75cc0fbe2db0ff11a8b22bac8f47242f775
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: skia:
Reviewed-on: https://skia-review.googlesource.com/114540
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Greg Daniel <egdaniel@google.com>
2018-03-15 12:27:37 +00:00
Greg Daniel
057627f6f1 Make sure we set correct GrPixelConfig in promise images
Land just the Promise image fixes from, https://skia-review.googlesource.com/c/skia/+/114261

Bug: skia:
Change-Id: I917cf2c1f5c6e51f9d7f1d3ec4526db551e89d84
Reviewed-on: https://skia-review.googlesource.com/114472
Reviewed-by: Robert Phillips <robertphillips@google.com>
Commit-Queue: Greg Daniel <egdaniel@google.com>
2018-03-15 12:22:16 +00:00
Robert Phillips
7e6dafdfed Prepare ddl skp rendering for prime time
Change-Id: I87742b8ef043588c4e835ab6ec49b217dd49f829
Reviewed-on: https://skia-review.googlesource.com/114289
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>
2018-03-15 11:48:16 +00:00
angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com
945ac788d8 Roll skia/third_party/externals/angle2/ 5eaddbd01..0b0dcbc1c (1 commit)
5eaddbd018..0b0dcbc1cf

$ git log 5eaddbd01..0b0dcbc1c --date=short --no-merges --format='%ad %ae %s'
2018-03-14 oetuaho Prune empty cases and switch statements

Created with:
  roll-dep skia/third_party/externals/angle2


The AutoRoll server is located here: https://angle-skia-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Build-Debian9-Clang-x86_64-Release-ANGLE
TBR=stephana@google.com

Change-Id: I4577adae4389eb5f8e248c5cbb46d226434e84f2
Reviewed-on: https://skia-review.googlesource.com/114487
Commit-Queue: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
2018-03-15 10:23:46 +00:00
Chris Dalton
30ce2a3620 ccpr: Unblacklist vulkan
All issues have been resolved.

Bug: skia:
Change-Id: Id63d63ad081725885cb0225b410b0d3972abd8f7
Reviewed-on: https://skia-review.googlesource.com/113060
Commit-Queue: Chris Dalton <csmartdalton@google.com>
Reviewed-by: Greg Daniel <egdaniel@google.com>
2018-03-15 04:14:46 +00:00
angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com
34417a5b0d Roll skia/third_party/externals/angle2/ 87db7c524..5eaddbd01 (9 commits)
87db7c524e..5eaddbd018

$ git log 87db7c524..5eaddbd01 --date=short --no-merges --format='%ad %ae %s'
2018-03-14 jmadill Vulkan: Flag uniforms as dirty when they are updated.
2018-03-14 lucferron Vulkan: Support of float uniform matrixes (2,3,4).
2018-03-14 geofflang Add an EGL extension to disable GL extensions by default.
2018-03-14 jmadill VertexArray: Add perf tests for VAO dirty bits.
2018-03-14 jiawei.shao ES31: Support program parameter queries on geometry shader
2018-03-13 lucferron Vulkan: Get/SetUniform for float / int and vec*
2018-03-14 cwallez cq.cfg: equivalent_to to 100% for Linux tryservers.
2018-03-13 cwallez Fix cubemap robust resource init for GenerateMipmap
2018-03-14 jmadill Move DrawCallParams to the gl front-end.

Created with:
  roll-dep skia/third_party/externals/angle2
BUG=815092


The AutoRoll server is located here: https://angle-skia-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Build-Debian9-Clang-x86_64-Release-ANGLE
TBR=stephana@google.com

Change-Id: Iaa1f591c7efbc29332e1ef5075e52c8f06aed6a1
Reviewed-on: https://skia-review.googlesource.com/114520
Reviewed-by: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
2018-03-15 01:42:25 +00:00