Commit Graph

28242 Commits

Author SHA1 Message Date
recipe-roller
a5da966a86 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
build:
  https://crrev.com/f1a52bdea3939b52c096b980fdda4cdd00a45577 Switch recipes over to recipe_engine "url". (dnj@google.com)
  https://crrev.com/1dad4f223eeb2f867d5e6d7c88ad6a23afb26f16 Add 3 more android perf bots to swarming (martiniss@chromium.org)


TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I1241e5ec55769bc8775f4e8d58f8c2bda2a5e30b
Reviewed-on: https://skia-review.googlesource.com/16991
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
2017-05-16 00:44:17 +00:00
recipe-roller
cdee29aa90 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
build:
  https://crrev.com/5bf5ff865bea2479f2f50fd4829dd3a3d56943be Fix the PGO trybot slaves config. (sebmarchand@chromium.org)
  https://crrev.com/14341361190c01441ac69f599f9856604f879370 ios: Use checkout-relative paths. (dnj@google.com)


TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ib6881e77f1eb18e058aad48f02880a7687d074f4
Reviewed-on: https://skia-review.googlesource.com/16990
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
2017-05-16 00:13:17 +00:00
Mike Klein
ca2194b38e add a test that sRGB stages round trip
Change-Id: Ide8303f6fc162f3703f7db298fe210d47225a580
Reviewed-on: https://skia-review.googlesource.com/16988
Reviewed-by: Matt Sarett <msarett@google.com>
Commit-Queue: Mike Klein <mtklein@chromium.org>
2017-05-15 23:57:48 +00:00
recipe-roller
f82b3cd6b5 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
build:
  https://crrev.com/f522dd62d97d12f77f41793955f68bbae2d944d3 annotated_run: Flip on use_result_proto on chromium.fyi (martiniss@chromium.org)


TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I9207e5b373f7632bf2bbb132e655380501c9a94d
Reviewed-on: https://skia-review.googlesource.com/16989
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
2017-05-15 22:56:13 +00:00
recipe-roller
4399601b7d Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
build:
  https://crrev.com/182e9aa84d8536bb43c28ce0c0653cc8b78d6848 [remote_run] roll recipes-py to match canary (iannucci@chromium.org)


TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I01cae50984a1c24118a7e6a6a9a77eee267403d1
Reviewed-on: https://skia-review.googlesource.com/16987
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
2017-05-15 22:26:18 +00:00
recipe-roller
d43afc65b9 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
build:
  https://crrev.com/3dd44c72ac7525343fe66f240897daeb0402855c Fix bug in recipe result handling logic (martiniss@chromium.org)


TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ia8c03ee08a2087389d54f3f32c662f374a514d1d
Reviewed-on: https://skia-review.googlesource.com/16985
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
2017-05-15 21:55:18 +00:00
Mike Klein
8af18591ca fix windows detection in SkExecutor.cpp
defined(SK_BUILD_FOR_WIN32) is our usual way of detecting Windows.
It's basically a roundabout defined(_WIN32).

Don't know why I picked _MSC_VER here.

BUG=skia:6635

Change-Id: I8986ec12dc1cc79a1cf16abf2a1ecbc5e0447786
Reviewed-on: https://skia-review.googlesource.com/16919
Reviewed-by: Herb Derby <herb@google.com>
Commit-Queue: Mike Klein <mtklein@chromium.org>
2017-05-15 21:47:27 +00:00
recipe-roller
25166c6637 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
build:
  https://crrev.com/5ec0e7a366c2ecae11a1603aa5d91097014b34b7 Add new bots to client.boringssl. (davidben@chromium.org)
  https://crrev.com/31979e555f4e6c30109344df86232a52e73e73e3 Switch buckets for BoringSSL SDE builder. (davidben@chromium.org)


TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I1d867a3ead1a45f76c81a0b663a46e848420e2c5
Reviewed-on: https://skia-review.googlesource.com/16982
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
2017-05-15 21:17:41 +00:00
Greg Daniel
5635193be2 Enable CrossContextTextureSupport on vulkan
Bug: skia:
Change-Id: I49d9c697e1749972f4f2fbc89ca47a472c986b65
Reviewed-on: https://skia-review.googlesource.com/16980
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Greg Daniel <egdaniel@google.com>
2017-05-15 21:14:21 +00:00
Brian Salomon
05441c40d6 Convert GrOvalOpFactory from GrLegacyMeshDrawOp to GrMeshDrawOp using GrSimpleDrawOpHelper.
Change-Id: Ib9f59ddf1c2c3f2bd0004ae16f842e52f45df8c9
Reviewed-on: https://skia-review.googlesource.com/16832
Commit-Queue: Brian Salomon <bsalomon@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
2017-05-15 21:11:41 +00:00
recipe-roller
ab1a34670e Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
build:
  https://crrev.com/df3fabbcf94016a8a37b74014bb4604e55faa577 Add another slave to the PGO pool (sebmarchand@chromium.org)
  https://crrev.com/a1d4fe1c5b7eb1960420c1f2cc7d11f3442e9ab7 move goma_setup() and goma_teardown() into goma_utils.py (tfarina@chromium.org)


TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I2de885899ed22916e360f2bb0cf33c491c0602cf
Reviewed-on: https://skia-review.googlesource.com/16916
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
2017-05-15 20:48:18 +00:00
Mike Klein
fd35c742bf fix SkJumper radial gradient precision
rcp(rsqrt(x)) doesn't have enough precision when x is a coordinate.
(It's fine when x is a color, like in the softlight blend mode.)

Adds a GM to test this.  It used to look quite ugly.

Change-Id: Icec295c2e2f50ae7a5e3e33c62270f632a58f65c
Reviewed-on: https://skia-review.googlesource.com/16914
Reviewed-by: Herb Derby <herb@google.com>
Commit-Queue: Mike Klein <mtklein@chromium.org>
2017-05-15 20:37:16 +00:00
Mike Klein
0dc6dd0a3f Add sRGB support to monobench.
We'll now run non-rendering and raster benchmarks,
for simplicity choosing sRGB as the only raster configuration.

$ ninja -C out monobench; and out/monobench "linear_clamp_(3color|pos)\$"
    gradient_linear_clamp_…
    6257  …3color 1x  …pos 1.03x

$ ninja -C out monobench; and out/monobench "linear_clamp_.*[^4][^f]\$"
    gradient_linear_clamp_…
    321  …shallow 1x  …shallow_dither 1x  …3color 1.49x  …hicolor 1.5x  …pos 1.52x

Change-Id: I7282a84c982eb1f11f0ea2dfe39afea66231761c
Reviewed-on: https://skia-review.googlesource.com/16877
Reviewed-by: Herb Derby <herb@google.com>
Commit-Queue: Mike Klein <mtklein@chromium.org>
2017-05-15 20:24:26 +00:00
Hal Canary
cbd0f3b4e3 experimental/documentation/gerrit.md: more tricks
NOTRY=true
Change-Id: I04d371b16f7805b4c972010a5bc1eebd979169a6
Reviewed-on: https://skia-review.googlesource.com/16915
Reviewed-by: Hal Canary <halcanary@google.com>
Commit-Queue: Hal Canary <halcanary@google.com>
2017-05-15 20:21:36 +00:00
Hal Canary
35a87d60e6 documentaion: consistant formatting
NOTRY=true
Change-Id: I2dd9d755242ca6c3522c465e1fa00139dda71a9d
Reviewed-on: https://skia-review.googlesource.com/16220
Reviewed-by: Hal Canary <halcanary@google.com>
Commit-Queue: Hal Canary <halcanary@google.com>
2017-05-15 20:05:56 +00:00
Mike Reed
74564b40bc check for no_paint and remove some drawdrawable special-casing
Bug: skia:
Change-Id: I824980a47ddd7c8c7627dabb5efd40f8f0889b67
Reviewed-on: https://skia-review.googlesource.com/16900
Commit-Queue: Mike Reed <reed@google.com>
Reviewed-by: Mike Klein <mtklein@chromium.org>
2017-05-15 19:03:11 +00:00
Jim Van Verth
4c9b893953 Allow shadow zParams to be applied to affine transformations
Change-Id: Iedfded98ce82d15945667232fde22d046d5106b3
Reviewed-on: https://skia-review.googlesource.com/16879
Commit-Queue: Jim Van Verth <jvanverth@google.com>
Reviewed-by: Mike Reed <reed@google.com>
2017-05-15 18:21:39 +00:00
Brian Salomon
0ec981ba49 Remove kCheckAllocation_GrSurfaceFlags.
This flags was only specified in one place (per backend). However, it was specified when no allocations occur.

Change-Id: Ic892d3064598519a07fb6773ba626fe022ef2f78
Reviewed-on: https://skia-review.googlesource.com/16904
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
2017-05-15 18:19:49 +00:00
Greg Daniel
604b197c6b Add support for creating a shared vulkan test context
Bug: skia:
Change-Id: I997c6269e4676bf4cedddcd87e71d107053678bb
Reviewed-on: https://skia-review.googlesource.com/16905
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Greg Daniel <egdaniel@google.com>
2017-05-15 18:12:59 +00:00
Chris Dalton
bca46e29e9 Convert GrMesh back to a class
Specific methods that limit the data to valid configurations are better
than a runtime mega-assert.

Bug: skia:
Change-Id: Ie15f2dc79659e44cfaddd16eb474795b110fda73
Reviewed-on: https://skia-review.googlesource.com/16577
Commit-Queue: Chris Dalton <csmartdalton@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
2017-05-15 18:01:59 +00:00
Robert Phillips
18e9484ad5 Rename finishOpList to finishFlush and call it less frequently
It is expected that this will fix the Vulkan perf regression associated with splitting up the opLists

Change-Id: I1bbb6f71745bb08d4a8c2f7810e5ab84cca75e84
Reviewed-on: https://skia-review.googlesource.com/16901
Commit-Queue: Robert Phillips <robertphillips@google.com>
Reviewed-by: Greg Daniel <egdaniel@google.com>
2017-05-15 17:39:38 +00:00
Ben Wagner
bcce7ff0d7 Remove old iPadMini4 jobs.
These were replaced with RPi-based jobs in
https://skia-review.googlesource.com/c/11521/. The old jobs no longer
have any bots to run them, which is causing a lot of warnings in the
task scheduler logs.

No-Try: true
Change-Id: Iae7b8371cd80fd7ee3fbe368d5dccb0a94913f14
Reviewed-on: https://skia-review.googlesource.com/16876
Reviewed-by: Eric Boren <borenet@google.com>
Reviewed-by: Stephan Altmueller <stephana@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
2017-05-15 17:18:57 +00:00
Mike Klein
c33aa9090c add unaligned_store()
Don't know why I never wrote unaligned_store() to mirror
unaligned_load(), but now I have.  This replaces all
remaining memcpy() in SkJumper_stages.cpp, which is nice.

The generated stage code didn't change.

Change-Id: I714c1072a975d7fa268a4b06c13f06557bf0c12c
Reviewed-on: https://skia-review.googlesource.com/16870
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Mike Klein <mtklein@chromium.org>
2017-05-15 17:14:07 +00:00
recipe-roller
c4c4b60d55 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
build:
  https://crrev.com/a2952f1cdf2d9a080b6f9d83f921a0bfe8bed2e7 [cipd_bootstrap_v2] Roll vpython. (dnj@google.com)


TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I97353c4714722ae23fb04435d27a5027bf2f9a99
Reviewed-on: https://skia-review.googlesource.com/16878
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
2017-05-15 17:07:17 +00:00
Jim Van Verth
78c8f30d61 Add filled occluders to shadow_utils GM, take 2
Classifies fully visible opaque shadows differently
than transparent to avoid cache collisions.

Change-Id: Iba5aab2b2cbe08f70205c343e86fe92b0cab7497
Reviewed-on: https://skia-review.googlesource.com/16858
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Jim Van Verth <jvanverth@google.com>
2017-05-15 16:01:43 +00:00
Brian Salomon
e334c59654 Attempt to work around iOS varying limit in GLPrograms test
Dump shaders when linking fails.

Bug: skia:6627
Change-Id: I7f1df4be039eb56d990aa64c58c8dd2a22d97dbe
Reviewed-on: https://skia-review.googlesource.com/16867
Reviewed-by: Robert Phillips <robertphillips@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
2017-05-15 15:41:01 +00:00
recipe-roller
63cef6b8c1 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
build:
  https://crrev.com/31740fbd20df2c1aa309ced416038d71ba6636ab Archive the PGO Profile databases. (sebmarchand@chromium.org)


TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ib167bcce111352d43b0bd84cc6a5e75f7fc0b01b
Reviewed-on: https://skia-review.googlesource.com/16872
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
2017-05-15 15:34:21 +00:00
Herb Derby
4de1304297 Add evenly spaced stops and unify gradient contexts
Change-Id: I17ac13b9d1ea6765e2c1a2b53aa6975eab408856
Reviewed-on: https://skia-review.googlesource.com/16713
Commit-Queue: Herb Derby <herb@google.com>
Reviewed-by: Mike Klein <mtklein@chromium.org>
2017-05-15 15:11:46 +00:00
Mike Reed
36015ab796 remove SkXfermode from api dox -- it is gone
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=16868
Bug: skia:1312
Change-Id: I28aafb80bcad0f3a810ca0b08caa15b70707b4a1
Reviewed-on: https://skia-review.googlesource.com/16868
Reviewed-by: Heather Miller <hcm@google.com>
Commit-Queue: Mike Reed <reed@google.com>
2017-05-15 14:24:02 +00:00
Mike Reed
9959f723c3 composeshader stages
needed to add two helper stages for composeshader

load_rgba, store_rgba

These just read/write the r,g,b,a registers to context memory, making no promise as to how the
memory is formatted (e.g. interleaved -vs- planar).

Note that we have similar existing stages, but they did not seem to suit:

constant_color

This guy loads 4 floats from memory, and splats them into registers. I need to load 4 entire
registers.

load_f32, store_f32

These offset where they read/write based on the 'x' register, plus they guarantee that the memory
will be interleaved ala SkPM4f.

Bug: skia:
Change-Id: Iaa81f950660b837bdb34416ab3e342d56a92239b
Reviewed-on: https://skia-review.googlesource.com/16716
Reviewed-by: Mike Klein <mtklein@chromium.org>
Commit-Queue: Mike Reed <reed@google.com>
2017-05-15 14:13:02 +00:00
Mike Reed
787a16dd9e move impl for drawvertices into separate file
expect to refactor the impl, so this just makes that easier
(plus SkDraw.cpp was just too big)

Bug: skia:
Change-Id: I22c07d37429195363d9a76e56a1dca915f9c2d57
Reviewed-on: https://skia-review.googlesource.com/16863
Commit-Queue: Mike Reed <reed@google.com>
Reviewed-by: Florin Malita <fmalita@chromium.org>
2017-05-15 13:51:25 +00:00
Matt Sarett
dedac85b4f Allow numerical color spaces with legacy rendering
Bug: 720083
Change-Id: Ibd4dbf6ee95ac14857e8280a441f81976710e5e8
Reviewed-on: https://skia-review.googlesource.com/16700
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Matt Sarett <msarett@google.com>
2017-05-15 13:46:50 +00:00
Robert Iannucci
297a7efd54 [skia] convert recipes and module to new context module
This is a syntax-only change to convert to the new (documented) context
module.

R=borenet@google.com

Bug: skia:
Change-Id: Id907c309d3cf38b85a46f6d8d7ce90ed58ba026f
Reviewed-on: https://skia-review.googlesource.com/16840
Commit-Queue: Eric Boren <borenet@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
2017-05-15 13:46:22 +00:00
Kevin Lubick
9018952290 Use CIPD->Isolate on RPI Perf tasks too
Bug: skia:
NOTRY=true
Change-Id: Ide4c5065ab6c252570a81a52b377cb5fb748d0d5

Change-Id: Ide4c5065ab6c252570a81a52b377cb5fb748d0d5
Reviewed-on: https://skia-review.googlesource.com/16862
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
2017-05-15 12:41:43 +00:00
recipe-roller
7c61dc9a08 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
build:
  https://crrev.com/a5879798e46344f83022b4da1ba28911e4d4c9d9 V8: Bump shards on slowest bots (machenbach@chromium.org)


TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ibd08ca994c4a86a06ff103c3cc1af59284d7be13
Reviewed-on: https://skia-review.googlesource.com/16861
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
2017-05-15 07:03:17 +00:00
UpdateSKPs
9e566ce9c1 Update SKP version
Automatic commit by the RecreateSKPs bot.

TBR=update-skps@skia.org
NO_MERGE_BUILDS

Change-Id: I85da3a796a5bf0be6bdead1b14de3a4ca01f79ac
Reviewed-on: https://skia-review.googlesource.com/16849
Reviewed-by: update-skps <update-skps@skia.org>
Commit-Queue: update-skps <update-skps@skia.org>
2017-05-14 08:02:20 +00:00
recipe-roller
ea15e03511 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/63fd5fef30ebf0db04266b4f4723f77838979365 [url]: get_file has default (empty) test data (dnj@google.com)


TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ib437973e7ce76059ee1f7461452356f0da80c974
Reviewed-on: https://skia-review.googlesource.com/16860
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
2017-05-14 03:05:16 +00:00
recipe-roller
7fbc3fca9c Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/e9c7176184ed588bbf66335e834834496f28cf9c [url] Cleanup, bugfix, step_test_data. (dnj@google.com)


TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ieb498433b8c6e93c36195327c25cd766d07fe64f
Reviewed-on: https://skia-review.googlesource.com/16838
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
2017-05-14 00:04:18 +00:00
Brian Osman
60751d7a06 Sort all user-supplied rects before computeFastBounds
https://codereview.chromium.org/908353002 fixed drawRect 2+ years ago, but
drawOval and drawArc were still susceptible. This version ensures that all
rects are sorted before we do the bounds check. Added a new makeSorted
helper to simplify the code, and an assert to catch any future oversight.

All other drawing functions compute their bounds rect in some way that
already ensures it is sorted.

Bug: skia:
Change-Id: I8926b2dbe9d496d0876f1ac5313bd058ae4568b7
Reviewed-on: https://skia-review.googlesource.com/16702
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
2017-05-13 22:58:17 +00:00
recipe-roller
ee93e7803a Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/0070123d9c8f830d813e6ec1064b9bf24a5b29db [context] Fix docstring. (iannucci@chromium.org)


TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Id76c262abb6f53e420fc00ecef1cf99e383a6592
Reviewed-on: https://skia-review.googlesource.com/16836
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
2017-05-13 18:45:43 +00:00
Cary Clark
304f9d4e0f add and fix parameter names
after manually fixing missing names
needed to make documentation easier,
the bookmaker tool found a number of
additional errors.

this is why computers will take our jobs

R=reed@google.com

DOCS_PREVIEW= https://skia.org/?cl=16616
Change-Id: Ieabebf5672601769852adde9be47459602fb43ab

Change-Id: Ieabebf5672601769852adde9be47459602fb43ab
Reviewed-on: https://skia-review.googlesource.com/16616
Commit-Queue: Cary Clark <caryclark@skia.org>
Reviewed-by: Mike Reed <reed@google.com>
2017-05-13 18:00:48 +00:00
recipe-roller
569beceb08 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
depot_tools:
  https://crrev.com/9b46527628683523d81d7b11b9872761fa1bad1d git-cl: let 'git config gerrit.host false' work (agable@chromium.org)
  https://crrev.com/69e760e4a571d16e75f30f1e97ea1a917445f333 Switch to recipe engine "url" module. (dnj@google.com)


TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: If8fa7b47be8a9c59565a07ddf00fdbf71d0454fc
Reviewed-on: https://skia-review.googlesource.com/16834
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
2017-05-13 04:07:59 +00:00
recipe-roller
831d842b43 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
build:
  https://crrev.com/227e19e6aa342b29ee65e78075446ca7e9457681 [boringssl] convert recipes and module to new context module (iannucci@chromium.org)
  https://crrev.com/fc81373391e1ce78f0794eaf693f4b32e9752136 [swarming+isolate] convert recipes and module to new context module (iannucci@chromium.org)
  https://crrev.com/f2df34cef0c1f9ad8e27029dee05442e06099440 [mojo] convert recipes and module to new context module (iannucci@chromium.org)
  https://crrev.com/5018c2d38e95c49bdd8edd02c0942a188d619694 [misc] convert recipes and module to new context module. (iannucci@chromium.org)
  https://crrev.com/03127b79eae3314fc07759456ec7a21a015ea2d7 [chromium_codesearch] convert recipes and module to new context module (iannucci@chromium.org)
  https://crrev.com/218a9a725c37b295c01318641870286672098332 [pdfium] convert recipes and module to new context module (iannucci@chromium.org)
  https://crrev.com/bc6f7db1d0cd860287461a512e1922d8fc8f54ed [dart] convert recipes and module to new context module. (iannucci@chromium.org)


TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I1378b4cf060e8116b74a7793f16a26905944f98a
Reviewed-on: https://skia-review.googlesource.com/16831
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
2017-05-13 02:18:56 +00:00
recipe-roller
a1956c366a Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
build:
  https://crrev.com/098e59c5c73a153e7492d963582d097199bdef84 [findit] convert recipes and module to new context module (iannucci@chromium.org)


TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I759428d4ce0d650cb1c6851e4c0ecbd7fd9e2aa6
Reviewed-on: https://skia-review.googlesource.com/16830
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
2017-05-13 01:38:13 +00:00
recipe-roller
c6363b9fc1 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
build:
  https://crrev.com/11ec9ef87c6d6ca597a1c820225cf299ca2dd53f [flutter] convert recipes and module to new context module (iannucci@chromium.org)


TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I17250e25016f5190904c2b03ee712aa61fdb7ad2
Reviewed-on: https://skia-review.googlesource.com/16829
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
2017-05-13 00:54:21 +00:00
recipe-roller
884f3f809f Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
build:
  https://crrev.com/4fde89076103c315b8c1c1c89ecc9da70c6c6d1e chromite: Stop using self.m.path['root'] for swarming builds. (dgarrett@google.com)


TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Id254cb85d1b8e626274dc132f360f7796df9b24d
Reviewed-on: https://skia-review.googlesource.com/16828
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
2017-05-12 23:58:54 +00:00
recipe-roller
6a73f9cdc9 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
build:
  https://crrev.com/5f26f71095d6af2bd74c035badf11122bbfabe96 Notify network-service-dev mailing list when Mojo Linux bot has a failure. (jam@chromium.org)


TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ia70328b19c303b6e3f4cd31b9c0675522ba65ac8
Reviewed-on: https://skia-review.googlesource.com/16827
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
2017-05-12 23:28:18 +00:00
recipe-roller
aad0f735d5 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
build:
  https://crrev.com/384957bd4425660fb818f85f6225778bdf8db1fc Enable remote run passthrough. (dnj@chromium.org)


TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I9fe088619291b00ae1c3bbaf9e296761f3508623
Reviewed-on: https://skia-review.googlesource.com/16826
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
2017-05-12 22:57:15 +00:00
recipe-roller
2a474f127c Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
build:
  https://crrev.com/ef454fe8ba423c8d62dd715e560f0ef3273869f9 Enforce strict coverage for gatekeeper recipe module (phajdan.jr@chromium.org)


TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I0d33fe34c385e7fc984625a3846c06ea4877497b
Reviewed-on: https://skia-review.googlesource.com/16825
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
2017-05-12 22:10:21 +00:00
recipe-roller
e8a426965d Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
build:
  https://crrev.com/6423755bf44f611b0bef88c573b83701ec61ffc2 chromite: Recipe helper. (dgarrett@google.com)
  https://crrev.com/435c46700222fc7cf44380b15c877ee8f928e81d [ios] convert recipes and module to new context module (iannucci@chromium.org)


TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I4e8cd508d7c4f2bd8cb3d21342d3be1984a921f9
Reviewed-on: https://skia-review.googlesource.com/16824
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
2017-05-12 21:38:18 +00:00