gogil
40ff5fe59b
Prevent overflows when using gamma_alloc_size
...
BUG=636268
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2230163002
Review-Url: https://codereview.chromium.org/2230163002
2016-08-14 02:12:40 -07:00
cabanier
e75cdcb85b
SkPDF: Use type 2/3 shading for gradient shaders
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1925233003
Review-Url: https://codereview.chromium.org/1925233003
2016-06-17 12:38:54 -07:00
Melnikov.Sergey.V
601e36a5c5
Add AVX/AVX2 support for runtime check
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1867193002
CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot
Review URL: https://codereview.chromium.org/1867193002
2016-04-08 15:31:45 -07:00
marco.diiga
f8ee67edb8
Fix for unaligned automatic variable address in SSE routines. This used to work on linux but crashed on windows when rendering antialiased glyphs. I tracked the problem down to an alignment issue.
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1817813002
Review URL: https://codereview.chromium.org/1817813002
2016-03-21 06:04:43 -07:00
lsalzman
b8b479b29d
use malloc/calloc/free instead of moz_malloc/moz_calloc/moz_free in ports/SkMemory_mozalloc.cpp
...
BUG=skia:4560
Review URL: https://codereview.chromium.org/1449093002
2015-11-23 10:30:14 -08:00
plesner
d975fc9599
Add ifdef guard around gpu-specific code in native windows window.
...
Review URL: https://codereview.chromium.org/1405963014
2015-11-05 08:10:45 -08:00
yang.zhang
dc77b35918
Optimize RGB16 blitV functions with NEON for ARM platform.
...
Here are some performance resultsi on Nexus 9:
SkRGB16BlitterBlitV_neon:
+--------+-----------+
|height | C/NEON |
+--------+-----------+
|1 | 0.765230 |
+--------+-----------+
|8 | 1.273330 |
+--------+-----------+
|18 | 1.441462 |
+--------+-----------+
|32 | 1.627798 |
+--------+-----------+
|76 | 1.683131 |
+--------+-----------+
|85 | 1.679456 |
+--------+-----------+
|120 | 1.721311 |
+--------+-----------+
|128 | 1.725482 |
+--------+-----------+
|512 | 1.784117 |
+--------+-----------+
BUG=skia:
Review URL: https://codereview.chromium.org/1213723002
2015-07-15 07:07:30 -07:00
zoran.jovanovic
7f00acbda6
Return cropBitmap
...
cropBitmap returns 'true' on success and 'false' on failure.
Propagate its return value so that cascading failures can be avoided.
Signed-off-by: Mykola Kondratenko <mykola.kondratenko@sonymobile.com>
BUG=skia:
Review URL: https://codereview.chromium.org/1088093003
2015-04-15 05:48:54 -07:00
jei.mayol
63af1441ce
Fix GIF transparency.
...
The GIF decoder, in the onDecode() function, tries to obtain the
transparency info from the temporary SavedImage object, temp_save,
but the decoder had been changed to save extension block data to
the GifFileType object instead. As a result, find_transpIndex() can't
find the correct transaprency index and returns -1.
This had been reported in Android 4.4. AOSP pulled skia changes
related to giflib 5.x changes after Android 4.3, which is why
the problem is not reproducible in versions before KitKat.
AOSP Issue 62016:
https://code.google.com/p/android/issues/detail?id=62016
BUG=skia:
Review URL: https://codereview.chromium.org/429053004
2015-02-04 21:31:23 -08:00
hcm
45453c2acf
authors update- add herb and reorganize
...
BUG=skia:
TBR=reed@google.com
NOTRY=true
Review URL: https://codereview.chromium.org/881993002
2015-01-28 14:16:43 -08:00
tomhudson
612e92680b
Revert of Revert of Add gpu support for Apple specific 'Vertex Arrays' functions (patchset #1 id:1 of https://codereview.chromium.org/750973003/ )
...
Reason for revert:
Original patchset seems to have been exonerated. Crash was mac-specific, but appears to be triggered by a non-mac-specific change (https://codereview.chromium.org/747043004/ ); suspecting driver bug?
Original issue's description:
> Revert of Add gpu support for Apple specific 'Vertex Arrays' functions (patchset #2 id:20001 of https://codereview.chromium.org/754653002/ )
>
> Reason for revert:
> Suspected in DM crashes, e.g.
>
> 2033 tasks left 344M peak 843ms tabl-cuteoverload_skp
> Signal 11:
> _sigtramp (+0x1a)
> create_surface(CanvasConfig const&, GrContext*) (+0x1b2)
> test_WritePixels(skiatest::Reporter*, GrContextFactory*) (+0x8d4)
> skiatest::WritePixelsClass::onRun(skiatest::Reporter*) (+0x21)
> skiatest::Test::run() (+0x7c)
> DM::GpuTestTask::draw(GrContextFactory*) (+0x8c)
> DM::GpuTask::run(GrContextFactory*) (+0xa6)
> DM::TaskRunner::wait() (+0x7f)
> dm_main() (+0x33f)
> main (+0x27)
>
>
> On all MacMini platforms (the following URL with -Mac{10.6,10.7,10.8}- and -{Debug,Release}):
>
> http://build.chromium.org/p/client.skia/builders/Test-Mac10.6-MacMini4.1-GeForce320M-x86_64-Debug
>
>
> Original issue's description:
> > Add gpu support for Apple specific 'Vertex Arrays' functions
> >
> > BUG=skia:
> >
> > Committed: https://skia.googlesource.com/skia/+/af000f469e1b0153ce445c96ca3d20e6d12224cc
>
> TBR=bsalomon@google.com ,paraboul@gmail.com
> NOTREECHECKS=true
> NOTRY=true
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/55fe3d7748b873e362edc4e6a43bd77914ed25fb
TBR=bsalomon@google.com ,paraboul@gmail.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/734633005
2014-11-24 11:22:37 -08:00
tomhudson
55fe3d7748
Revert of Add gpu support for Apple specific 'Vertex Arrays' functions (patchset #2 id:20001 of https://codereview.chromium.org/754653002/ )
...
Reason for revert:
Suspected in DM crashes, e.g.
2033 tasks left 344M peak 843ms tabl-cuteoverload_skp
Signal 11:
_sigtramp (+0x1a)
create_surface(CanvasConfig const&, GrContext*) (+0x1b2)
test_WritePixels(skiatest::Reporter*, GrContextFactory*) (+0x8d4)
skiatest::WritePixelsClass::onRun(skiatest::Reporter*) (+0x21)
skiatest::Test::run() (+0x7c)
DM::GpuTestTask::draw(GrContextFactory*) (+0x8c)
DM::GpuTask::run(GrContextFactory*) (+0xa6)
DM::TaskRunner::wait() (+0x7f)
dm_main() (+0x33f)
main (+0x27)
On all MacMini platforms (the following URL with -Mac{10.6,10.7,10.8}- and -{Debug,Release}):
http://build.chromium.org/p/client.skia/builders/Test-Mac10.6-MacMini4.1-GeForce320M-x86_64-Debug
Original issue's description:
> Add gpu support for Apple specific 'Vertex Arrays' functions
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/af000f469e1b0153ce445c96ca3d20e6d12224cc
TBR=bsalomon@google.com ,paraboul@gmail.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/750973003
2014-11-24 09:59:41 -08:00
paraboul
af000f469e
Add gpu support for Apple specific 'Vertex Arrays' functions
...
BUG=skia:
Review URL: https://codereview.chromium.org/754653002
2014-11-24 07:05:28 -08:00
rosca
ace7f42769
Preventing division by 0 in non-separable blend mode shaders.
...
In the software path, the same issue has been fixed some time ago:
https://codereview.chromium.org/114173002
BUG=skia:
Review URL: https://codereview.chromium.org/666043003
2014-11-20 07:24:32 -08:00
pavel
47eedcc848
Add utils to better quantize grayscale values to three bit indices while
...
compressing coverage masks.
Signed-off-by: Pavel Krajcevski <pavel@cs.unc.edu>
BUG=skia:
Review URL: https://codereview.chromium.org/669243003
2014-10-23 13:18:50 -07:00
jmuizelaar
60e4ad7b29
Improve SkARGB32_A8_BlitMask_SSE2
...
With clang this:
- movzbl -3(%rbx), %edx
- pxor %xmm5, %xmm5
- pinsrw $0, %edx, %xmm5
- pinsrw $1, %edx, %xmm5
- movzbl -2(%rbx), %edx
- pinsrw $2, %edx, %xmm5
- pinsrw $3, %edx, %xmm5
- movzbl -1(%rbx), %edx
- pinsrw $4, %edx, %xmm5
- pinsrw $5, %edx, %xmm5
- movzbl (%rbx), %edx
- pinsrw $6, %edx, %xmm5
- pinsrw $7, %edx, %xmm5
becomes:
+ movd (%rbx), %xmm4
+ punpcklbw %xmm9, %xmm4
+ punpcklwd %xmm4, %xmm4
And clang already does better codegen than msvc 2013 on this.
BUG=skia:
Review URL: https://codereview.chromium.org/609823003
2014-10-09 11:43:02 -07:00
derekf
8c8f71ac07
Always disable the scissor test before BlitFrameBuffer
...
It seems most (all?) implementations of BlitFrameBuffer actually
obey the scissor test, so just always disable the scissor before
calling BlitFrameBuffer.
Original Author: Henry Song <henrysong@samsung.com>
R=bsalomon@google.com , hcm@google.com
Author: derekf@osg.samsung.com
Review URL: https://codereview.chromium.org/574543002
2014-09-16 06:24:58 -07:00
mtklein
9db328b64f
Add *@skia.org to AUTHORS so we can land CLs using those addresses if we like.
...
BUG=skia:
R=hcm@google.com , reed@google.com , mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/565293002
2014-09-12 12:03:55 -07:00
ehsan.akhgari
db5f7bf0a4
Do not export SkTDArray when building Skia as a DLL
...
This class has four members (deleteAll, freeAll, unrefAll and
safeUnrefAll) which will only compile for certain instantiations of
SkTDArray depending on the template argument type. Marking this class
as dllexport breaks the build with clang-cl because of
http://llvm.org/PR20163 . Since this class is header-only, we can just
make it non-exported to enable building Skia as a DLL with clang-cl.
BUG=skia:
R=ctguil@chromium.org , mtklein@google.com , reed@google.com
Author: ehsan.akhgari@gmail.com
Review URL: https://codereview.chromium.org/368253002
2014-07-09 11:13:55 -07:00
djordje.pesut
aaf1df632d
MIPS: modified gypi files to support build
...
R=teodora.petrovic@gmail.com , djsollen@google.com
Author: djordje.pesut@imgtec.com
Review URL: https://codereview.chromium.org/304903003
2014-06-06 14:09:12 -07:00
commit-bot@chromium.org
b7fedac2d1
Fixed Skia compilation error with strict clang.
...
BUG=skia:
R=reed@google.com , sergeyberezin@chromium.org , hcm@google.com
Author: kolczyk@opera.com
Review URL: https://codereview.chromium.org/227043006
git-svn-id: http://skia.googlecode.com/svn/trunk@14071 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-07 13:12:47 +00:00
commit-bot@chromium.org
9e613c096c
Add skia.buildbots@gmail.com to CQ_COMMITTERS
...
BUG=skia:2225
R=borenet@google.com , rmistry@google.com
Author: skia.buildbots@gmail.com
Review URL: https://codereview.chromium.org/218393023
git-svn-id: http://skia.googlecode.com/svn/trunk@14056 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-03 22:21:08 +00:00
commit-bot@chromium.org
8ec45cede9
Add more big endian platforms
...
This patch adds more platforms to the list that have the BIGENDIAN defines set.
Downstream users are using parts of SKIA on BigEndian machines.
R=cmp@chromium.org , bungeman@google.com , bsalomon@google.com , reed@google.com , sergeyberezin@chromium.org
Author: steve@ssinger.info
Review URL: https://codereview.chromium.org/218733002
git-svn-id: http://skia.googlecode.com/svn/trunk@14046 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-03 16:38:01 +00:00
commit-bot@chromium.org
9fbbcca1c9
SkPerlinNoiseShader::CreateTubulenceNoise() is misspelled
...
Add missing 'r'.
BUG=skia:2329
R=bsalomon@google.com , hcm@google.com , sugoi@chromium.org
Author: siglesias@igalia.com
Review URL: https://codereview.chromium.org/207543008
git-svn-id: http://skia.googlecode.com/svn/trunk@14008 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-01 16:09:37 +00:00
commit-bot@chromium.org
8e13a159f3
Fixed cross compilation with mingw.
...
Tested in Mozilla source tree. I tried to use skia build system, but it's up to the task for cross compilation.
SkHRESULT.cpp - Use proper file name (that matters on case sensitive OSes)
SkAtomics_win.h - Don't use pragma intrinsic on GCC (this causes massive warnings)
SkOSFile_win.cpp - This one is tricky. GCC doesn't allow (void*) casts in template argument constants and INVALID_HANDLE_VALUE looks like this:
((HANDLE)(LONG_PTR)-1)
where HANDLE is typedefed to void*. Changed the code to use LONG_PTR as template argument and cast it when needed.
BUG=skia:
R=bungeman@google.com , reed@google.com
Author: cjacek@gmail.com
Review URL: https://codereview.chromium.org/198643004
git-svn-id: http://skia.googlecode.com/svn/trunk@13862 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-03-19 19:28:00 +00:00
commit-bot@chromium.org
0bc406df48
Adding code to calculate Underline Thickness from Font Metrics, this will be useful when Skia is used with Blink/Chrome. Blink changes are uploaded with code change in patch https://codereview.chromium.org/147703002/
...
BUG=skia:
R=reed@android.com , edisonn@google.com , reed@google.com , mtklein@google.com , mtklein@chromium.org , bungeman@google.com
Author: h.joshi@samsung.com
Review URL: https://codereview.chromium.org/152073003
git-svn-id: http://skia.googlecode.com/svn/trunk@13635 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-03-01 20:12:26 +00:00
commit-bot@chromium.org
d328fb6293
Defer deletion of our shaders until after linking the gl program to work around an Android emulator bug
...
R=bsalomon@google.com , brian@thesalomons.net , bsalomon
BUG=skia:
Author: george@mozilla.com
Review URL: https://codereview.chromium.org/164973002
git-svn-id: http://skia.googlecode.com/svn/trunk@13446 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-02-14 00:03:38 +00:00
commit-bot@chromium.org
b000d76af4
Drawing fake bold text, line and normal text made normal text bolder on PDF.
...
When PDF uses fake bold text, it uses stroke and fill for the
text. After that, line is drawn. It creates new ContextEntry which
GraphicStateEntry has 0 fTextScaleX. Since fTextScaleX is 0,
GraphicStackState::updateDrawingState() doesn't update text fill mode or
the PDF page. When the normal text is drawn, it reuse the line's
ContextEntry because GraphicStateEntry::compareInitialState() returns
true. However, since the reused GraphicsStateEntry's fTextScaleX is 0,
the text fill mode is not updated to fill, and the text is drawn in
stroke and fill mode.
When the fTextScaleX is changed, we should not reuse GraphicStateEntry
even if ether of fTextScaleX is 0.
BUG=skia:2132
R=reed@google.com , vandebo@chromium.org , bungeman@google.com
Author: yuki.sekiguchi@access-company.com
Review URL: https://codereview.chromium.org/137923005
git-svn-id: http://skia.googlecode.com/svn/trunk@13369 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-02-07 19:39:57 +00:00
commit-bot@chromium.org
2fc672dd46
Adding Chromium authors to the AUTHORS file.
...
Some Googlers commit code into Skia using their chromium.org accounts.
The Chromium AUTHORS file has a similar entry:
http://src.chromium.org/viewvc/chrome/trunk/src/AUTHORS
(SkipBuildbotRuns)
NOTRY=true
BUG=skia:2072
R=hcm@google.com
Author: rmistry@google.com
Review URL: https://codereview.chromium.org/146853004
git-svn-id: http://skia.googlecode.com/svn/trunk@13271 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-31 19:12:43 +00:00
commit-bot@chromium.org
1c2f8c2973
modify authors file format to use python fnmatch
...
BUG=skia:2060
R=rmistry@google.com
Author: hcm@google.com
Review URL: https://codereview.chromium.org/145963002
git-svn-id: http://skia.googlecode.com/svn/trunk@13163 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-24 12:39:25 +00:00
commit-bot@chromium.org
bd00629708
Add AUTHORS file for copyright tracking
...
BUG=skia:
R=jcgregorio@google.com , rmistry@google.com
Author: hcm@google.com
Review URL: https://codereview.chromium.org/138413004
git-svn-id: http://skia.googlecode.com/svn/trunk@13117 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-17 15:00:14 +00:00