caryclark
aec2510125
minor fixes to cubics code and overall alignment of how bounds and tops are computed for all curve types
...
All but 17 extended tests work.
A helper function is privately added to SkPath.h to permit a test to modify a given point in a path.
BUG=skia:3588
Review URL: https://codereview.chromium.org/1107353004
2015-04-29 08:28:30 -07:00
rmistry
385e88cc16
Create SP enabled SKPs from only the top_25_smooth page set.
...
Context is here: https://code.google.com/p/skia/issues/detail?id=3763#c14
BUG=skia:3763
NOTRY=true
Review URL: https://codereview.chromium.org/1111273003
2015-04-29 07:26:33 -07:00
halcanary
5190a481f9
doc: add quickstart to linux and macos
...
also, better install_deps
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=1112663002
Review URL: https://codereview.chromium.org/1112663002
2015-04-28 13:06:54 -07:00
borenet
97025e34d3
Run DM on GalaxyS* in one thread
...
Drive-by cleanup of Xoom
BUG=skia:3214
Review URL: https://codereview.chromium.org/1106173004
2015-04-28 09:54:55 -07:00
rmistry
77772f3ca3
Update RecreateSKPs bot to also generate Slimming Paint SKPs with a separate prefix.
...
Will only be committed after I get the go head in skia:3763.
BUG=skia:3763
NOTRY=true
Review URL: https://codereview.chromium.org/1065503007
2015-04-28 08:27:19 -07:00
joshualitt
8f94bb2b25
remove old text contexts and fontcache
...
BUG=skia:
Review URL: https://codereview.chromium.org/1104343003
2015-04-28 07:04:11 -07:00
halcanary
2752314745
dm||nanobench --help looks nice when $COLUMNS == 80.
...
Also, add to --config help message
Review URL: https://codereview.chromium.org/1105593002
2015-04-27 06:41:36 -07:00
caryclark
08bc8488fa
fix multiple intersection logic
...
When three or more curves intersect at the same point, ensure that
each curve records the intersections of the others. This fixes a
number of cubic tests.
TBR=reed@google.com
BUG=skia:3588
Review URL: https://codereview.chromium.org/1105943002
2015-04-24 09:08:57 -07:00
rmistry
aa31ee78ee
Add ability to specify extra browser args and a prefix for SKP names to webpages_playback.py
...
BUG=skia:3763
NOTRY=true
Review URL: https://codereview.chromium.org/1066933006
2015-04-23 12:47:33 -07:00
borenet
e1d7e0f0a5
Blacklist desk_unicodetable SKP on Nexus Player
...
It's getting us killed for OOM.
BUG=skia:3240
Review URL: https://codereview.chromium.org/1104693002
2015-04-23 12:44:31 -07:00
caryclark
03b03cad01
working on initial winding for cubics
...
Path ops works well for all tests except for cubics.
Isolate failures caused by cubics, and do a better job of computing
the initial winding for cubics.
TBR=reed@google.com
BUG=skia:3588
Review URL: https://codereview.chromium.org/1096923003
2015-04-23 09:13:37 -07:00
mtklein
d557462f1f
Skip msaa4 on Tegra 2 and 3.
...
This will fix the N7 and Xoom bots.
TBR=borenet@google.com
BUG=skia:
Review URL: https://codereview.chromium.org/1099943002
2015-04-21 11:25:47 -07:00
mtklein
05641a5582
DM: failure to canary a sink is now fatal.
...
This requires we remove NVPR from the default set of configs, as we only find
out at runtime that it's not available. All the other defaults will either be
compiled in and supported, or not compiled in and non-fatally skipped as
unknown configs.
BUG=skia:
Review URL: https://codereview.chromium.org/1100773003
2015-04-21 10:49:14 -07:00
mtklein
fca5c88873
Ask for NVPR only when we expect it to be available.
...
BUG=skia:
Review URL: https://codereview.chromium.org/1099023003
2015-04-21 10:34:47 -07:00
stephana
cdec56e72b
Landing directly for testing the ios buildbot code.
...
BUG=skia:
TBR=borenet
Review URL: https://codereview.chromium.org/1087653005
2015-04-21 08:31:59 -07:00
caryclark
1049f1246e
Now, path ops natively intersect conics, quads, and cubics in any combination. There are still a class of cubic tests that fail and a handful of undiagnosed failures from skps and fuzz tests, but things are much better overall.
...
Extended tests (150M+) run to completion in release in about 6 minutes; the standard test suite exceeds 100K and finishes in a few seconds on desktops.
TBR=reed
BUG=skia:3588
Review URL: https://codereview.chromium.org/1037953004
2015-04-20 08:31:59 -07:00
joshualitt
9e36c1a930
Start canonicalizing color for all A8 textblobs
...
BUG=skia:
Review URL: https://codereview.chromium.org/1076593002
2015-04-14 12:17:27 -07:00
borenet
22ecae88ee
Blacklist desk_wikipedia pdf on Valgrind bots
...
BUG=skia:3506
Review URL: https://codereview.chromium.org/1056763004
2015-04-13 13:29:26 -07:00
msarett
3c309db75b
Implementing filling for SkBmpCodec
...
The bmp codec currently returns kIncompleteInput
when the stream is truncated, which we treat as a
partial success. However, we neglect the fill the
remaining pixels in the image, leaving these
uninitialized.
This CL addresses this problem by initializing the
remaining pixels in the image to default values.
BUG=skia:3257
Review URL: https://codereview.chromium.org/1075243003
2015-04-10 14:36:49 -07:00
stephana
195f62d07d
BUG=skia:
...
Review URL: https://codereview.chromium.org/1054073003
2015-04-09 07:57:54 -07:00
Mike Klein
fbcf0bd7ff
expand pdf/worldjournal blacklist entry to cover the new skp too
...
BUG=skia:
Review URL: https://codereview.chromium.org/1070013002
2015-04-09 06:03:22 -04:00
caryclark
95bc5f3495
change isNestedRect to isNestedFillRect
...
R=reed@google.com , bsalomon@google.com
Let isNested(Fill)Rect return true if drawn path describes filled
rectangles.
Review URL: https://codereview.chromium.org/1073473002
2015-04-08 08:34:15 -07:00
mtklein
929f63fecc
Make --undefok a little louder now that we're using it all the time.
...
BUG=skia:
Review URL: https://codereview.chromium.org/1073483002
2015-04-08 08:30:38 -07:00
borenet
dfaebfba42
Remove get_uploaded hashes
...
Replaced with an inline script in
https://codereview.chromium.org/1068503002/
BUG=skia:3521
Review URL: https://codereview.chromium.org/1062873002
2015-04-06 13:19:26 -07:00
msarett
2f273a1ed0
Adding non-deterministic images to blacklist
...
BUG=skia:3653
Review URL: https://codereview.chromium.org/1054593006
2015-04-06 08:38:49 -07:00
borenet
09ed480906
Add --uninterestingHashesFile to DM
...
The file is expected to contain a list of strings. If the hash for
any result is in this file, don't write an image for it.
BUG=skia:3521
Review URL: https://codereview.chromium.org/1059363002
2015-04-03 14:15:33 -07:00
rmistry
80bd3ae9d7
Delete no longer needed pagesets, add new pagesets and make names more readable
...
Deleted all pagesets mentioned in https://code.google.com/p/skia/issues/detail?id=3574#c18
Added new Wikipedia and Unicodetable pagesets from https://code.google.com/p/skia/issues/detail?id=3574#c19
BUG=skia:3574
NOTRY=true
Review URL: https://codereview.chromium.org/1053253003
2015-04-03 08:22:51 -07:00
djsollen
54416de523
Update DM to allow Src's to have optional options.
...
Review URL: https://codereview.chromium.org/1059513002
2015-04-03 07:24:48 -07:00
borenet
4808757d7a
Remove all code related to NaCl
...
BUG=skia:3600
DOCS_PREVIEW= https://skia.org/?cl=1036283002
Review URL: https://codereview.chromium.org/1036283002
2015-04-02 12:16:36 -07:00
borenet
11106f196e
Skip desk_baidu skp on Valgrind bot
...
This has been running for 16 hours:
https://uberchromegw.corp.google.com/i/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Valgrind/builds/12/
BUG=skia:3506
Review URL: https://codereview.chromium.org/1056883002
2015-04-02 07:24:03 -07:00
rmistry
2a3c8493af
Turn on Chromium's top 25 page set
...
#crskps
BUG=skia:
BUG=skia:3574
NOTRY=true
TBR=borenet
Review URL: https://codereview.chromium.org/1045153004
2015-03-31 10:59:15 -07:00
rmistry
39383a1946
Fix cr SKPs naming
...
#crskps
BUG=skia:
BUG=skia:3574
NOTRY=true
TBR=borenet
Review URL: https://codereview.chromium.org/1044193003
2015-03-31 08:03:02 -07:00
rmistry
5af9a3792f
Turn on key mobile sites cr page set and delete dashed desktop
...
#crskps
BUG=skia:3574
BUG=skia:3605
NOTRY=true
Review URL: https://codereview.chromium.org/1040233004
2015-03-31 06:22:55 -07:00
rmistry
009b069f52
Fix gs.upload_dir_contents arguments mismatch
...
Fixing bug introduced by https://codereview.chromium.org/737123005
BUG=skia:
NOTRY=true
TBR=borenet
Review URL: https://codereview.chromium.org/1041003003
2015-03-31 05:20:12 -07:00
rmistry
49d093cef9
Add ability to capture SKPs from Chromium's pagesets
...
Also added support for pagesets with multiple pages in them.
#crskps
BUG=skia:1723
BUG=skia:3574
NOTRY=true
Review URL: https://codereview.chromium.org/1047703003
2015-03-31 05:04:29 -07:00
kkinnunen
b4ee7ea834
webpages_playback.py: Support storing to local directories
...
Make webpages_playback support storing to local directories as an
alternative to Google Storage.
Rename argument --dest_gsbase to --data_store=<location>. Make this parameter
accept either gs:// url or directory for local file system storage.
Rename argument --upload_to_gs to --upload.
Implement file existence check, download and upload for the file
operation.
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/737123005
2015-03-31 00:18:27 -07:00
bungeman
5c9fa2844c
Add option to embed font data into executable.
...
Some tools would like to be built with all resources embedded.
This change makes it possible to build a font manager which
uses font data embedded into the executable.
Review URL: https://codereview.chromium.org/1015723004
2015-03-30 12:53:48 -07:00
kkinnunen
f9310fe2be
webpages_playback.py: Avoid crash when retrying to capture skp
...
Move the .wpr files after recording, in the recording retry loop.
Previously they were moved in the skp capture retry loop.
Review URL: https://codereview.chromium.org/1033223005
2015-03-29 22:33:16 -07:00
borenet
1e37d1762c
Update [dm|nanobench]_flags for CPU/GPU split
...
TBR=mtklein
NOTREECHECKS=true
BUG=skia:2073
Review URL: https://codereview.chromium.org/1036223002
2015-03-27 05:42:18 -07:00
caryclark
54359294a7
cumulative pathops patch
...
Replace the implicit curve intersection with a geometric curve intersection. The implicit intersection proved mathematically unstable and took a long time to zero in on an answer.
Use pointers instead of indices to refer to parts of curves. Indices required awkward renumbering.
Unify t and point values so that small intervals can be eliminated in one pass.
Break cubics up front to eliminate loops and cusps.
Make the Simplify and Op code more regular and eliminate arbitrary differences.
Add a builder that takes an array of paths and operators.
Delete unused code.
BUG=skia:3588
R=reed@google.com
Review URL: https://codereview.chromium.org/1037573004
2015-03-26 07:52:43 -07:00
mtklein
ce86687310
pdf skp tabl_worldjournal.skp took 5 days to run on Valgrind
...
#notry
BUG=skia:
NOTRY=true
Review URL: https://codereview.chromium.org/1030263003
2015-03-26 05:12:13 -07:00
mtklein
36352bf5e3
C++11 override should now be supported by all of {bots,Chrome,Android,Mozilla}
...
NOPRESUBMIT=true
BUG=skia:
DOCS_PREVIEW= https://skia.org/?cl=1037793002
Review URL: https://codereview.chromium.org/1037793002
2015-03-25 18:17:32 -07:00
msarett
114912d4b9
Fix android_run_skia script to allow for larger blacklist
...
BUG=skia:
Review URL: https://codereview.chromium.org/1011653004
2015-03-25 12:28:33 -07:00
reed
0dc4dd6dda
Revert of pathops version two (patchset #16 id:150001 of https://codereview.chromium.org/1002693002/ )
...
Reason for revert:
ASAN investigation
Original issue's description:
> pathops version two
>
> R=reed@google.com
>
> marked 'no commit' to attempt to get trybots to run
>
> TBR=reed@google.com
>
> Committed: https://skia.googlesource.com/skia/+/ccec0f958ffc71a9986d236bc2eb335cb2111119
TBR=caryclark@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/1029993002
2015-03-24 13:55:33 -07:00
tomhudson
7aa846c683
Revert of Enabling ico decoding with use of png and bmp decoders (patchset #10 id:280001 of https://codereview.chromium.org/1011343003/ )
...
Reason for revert:
Reverting on suspicion of massive bot failures - possible command line too long?
Original issue's description:
> Enabling ico decoding with use of png and bmp decoders
>
> BUG=skia:3257
>
> Committed: https://skia.googlesource.com/skia/+/15bfd075d38e4422a477e22940d06a137f66cc97
TBR=scroggo@google.com ,reed@google.com,djsollen@google.com,msarett@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:3257
Review URL: https://codereview.chromium.org/1022843005
2015-03-24 13:47:41 -07:00
msarett
15bfd075d3
Enabling ico decoding with use of png and bmp decoders
...
BUG=skia:3257
Review URL: https://codereview.chromium.org/1011343003
2015-03-24 12:24:27 -07:00
rmistry
6776a538f9
Increase timeout of ukwsj to get more consistent SKP captures
...
BUG=skia:3574
TBR=borenet
NOTRY=true
Review URL: https://codereview.chromium.org/1038443002
2015-03-24 10:58:37 -07:00
caryclark
ccec0f958f
pathops version two
...
R=reed@google.com
marked 'no commit' to attempt to get trybots to run
TBR=reed@google.com
Review URL: https://codereview.chromium.org/1002693002
2015-03-24 07:28:17 -07:00
robertphillips
3e5c2b1041
Preserve texture compression when saving a revised skp from debugger
...
Without this CL, saving a revised skp out the debugger can greatly expand the memory it requires.
Review URL: https://codereview.chromium.org/1020103005
2015-03-23 05:46:51 -07:00
egdaniel
9a0f629973
Only use 256x256 tiles on hd2000 nanobench bots
...
Initial experiments did show that the 256 tile size fixed the hd2000 win7
nanobot failures. However it did not have any effect on other bots, so this
change is to move back to the larger tile size on all bots expect for the
hd2000.
BUG=skia:
Review URL: https://codereview.chromium.org/1022083002
2015-03-20 07:03:52 -07:00