Commit Graph

8286 Commits

Author SHA1 Message Date
commit-bot@chromium.org
05256f6811 set a correct breakpoint for gdbserver, gdb can stop here before the app is running, and we can set more breakpoints if we need. For previous one, gdb will not stop, so it will run the app and exit.
R=djsollen@google.com, borenet@google.com

Author: yunchao.he@intel.com

Review URL: https://chromiumcodereview.appspot.com/20671002

git-svn-id: http://skia.googlecode.com/svn/trunk@10430 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-30 13:16:07 +00:00
robertphillips@google.com
073a32ecb6 Fix compiler warning/error in r10428
git-svn-id: http://skia.googlecode.com/svn/trunk@10429 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-30 12:29:20 +00:00
robertphillips@google.com
17ad2bd077 Fix quickReject computation for blurs
https://codereview.chromium.org/17035007/



git-svn-id: http://skia.googlecode.com/svn/trunk@10428 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-30 12:15:19 +00:00
edisonn@google.com
641cce90c9 pdfviewer: fix condition for element in array, reset back the default color to white, and verify type before value in PDF API mapper
Review URL: https://codereview.chromium.org/21017004

git-svn-id: http://skia.googlecode.com/svn/trunk@10427 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-30 12:09:14 +00:00
skia.committer@gmail.com
16d53aac9c Sanitizing source files in Housekeeper-Nightly
git-svn-id: http://skia.googlecode.com/svn/trunk@10426 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-30 07:01:00 +00:00
bungeman@google.com
6a774a1f26 Fix subpixel metrics with GDI.
The previous code uncovered a rather strange issue with GDI, where it
appears that alternating between two HFONTs with the same attributes but
vastly different heights does not appear to invalidate the the 'x'
metrics (the 'y' metrics appear to be correct). As a result it is
possible to get completely useless results from GetGlyphOutlineW. This
change works around the issue by simply scaling the one font to the
required sizes, which also saves us an HFONT.

Review URL: https://codereview.chromium.org/21047008

git-svn-id: http://skia.googlecode.com/svn/trunk@10425 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-30 01:07:48 +00:00
bungeman@google.com
a3aaf16e0f Fix invalid comparison between int16 and int16be in name table code.
Review URL: https://codereview.chromium.org/21138005

git-svn-id: http://skia.googlecode.com/svn/trunk@10424 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-29 22:25:02 +00:00
edisonn@google.com
4ef4bed00e pdfviewer: load files with missing xref (we need in order to help with testing, as most good pdfx in the whild miss the xref). add period as a valid character to start a real value.
Review URL: https://codereview.chromium.org/21096006

git-svn-id: http://skia.googlecode.com/svn/trunk@10423 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-29 22:14:45 +00:00
mtklein@google.com
d49173afc8 always have conditional instruction
BUG=
R=djsollen@google.com

Review URL: https://codereview.chromium.org/21155002

git-svn-id: http://skia.googlecode.com/svn/trunk@10422 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-29 20:53:14 +00:00
mtklein@google.com
069aea7f2c one more thing to try before rebaselining android
BUG=
R=djsollen@google.com

Review URL: https://codereview.chromium.org/21112004

git-svn-id: http://skia.googlecode.com/svn/trunk@10420 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-29 19:30:00 +00:00
edisonn@google.com
e878e726bd pdfviewer: more plumming for soft masks, blend modes and transparency groups
Review URL: https://codereview.chromium.org/21125002

git-svn-id: http://skia.googlecode.com/svn/trunk@10419 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-29 19:10:58 +00:00
reed@google.com
08df48d241 expose getFamilyName to public SkTypeface
git-svn-id: http://skia.googlecode.com/svn/trunk@10418 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-29 18:54:08 +00:00
senorblanco@chromium.org
e8232bc6f0 Small optimization for convolution shader: only apply the bounds check in direction of convolution, not both. This requires generating different versions of the shader depending on direction.
R=robertphillips@google.com

Review URL: https://codereview.chromium.org/20789003

git-svn-id: http://skia.googlecode.com/svn/trunk@10417 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-29 18:45:44 +00:00
mtklein@google.com
b3915b5a9f Turn thumb back on.
We expect this might break Android GMs.  If it does I'll rebaseline or revert.

BUG=
R=djsollen@google.com

Review URL: https://codereview.chromium.org/21096004

git-svn-id: http://skia.googlecode.com/svn/trunk@10415 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-29 18:33:33 +00:00
commit-bot@chromium.org
4dcd062803 Matrix decomposition cleanup: Add is_degenerate_2x2(), and fix some asserts
(atan2 can take a zero x value, but both x == 0 and y == 0 is undefined).

R=reed@google.com, robertphillips@google.com

Author: jvanverth@google.com

Review URL: https://chromiumcodereview.appspot.com/20303003

git-svn-id: http://skia.googlecode.com/svn/trunk@10410 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-29 14:43:31 +00:00
djsollen@google.com
81152f4d5b adjust performance triggers for flakes on the Windows bots.
R=borenet@google.com, robertphillips@google.com

Review URL: https://codereview.chromium.org/21076002

git-svn-id: http://skia.googlecode.com/svn/trunk@10408 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-29 13:29:49 +00:00
edisonn@google.com
96ba3aa2fa pdfviewer: fix a few warnings
Review URL: https://codereview.chromium.org/20662003

git-svn-id: http://skia.googlecode.com/svn/trunk@10404 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-28 20:04:35 +00:00
edisonn@google.com
a0cefa18fc pdfviewer: gs operator implementation: dashing and font
Review URL: https://codereview.chromium.org/20810002

git-svn-id: http://skia.googlecode.com/svn/trunk@10403 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-28 18:34:14 +00:00
skia.committer@gmail.com
27e21fe577 Sanitizing source files in Housekeeper-Nightly
git-svn-id: http://skia.googlecode.com/svn/trunk@10402 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-28 07:01:03 +00:00
bungeman@google.com
791386c77d Rebaseline for 10399 and 10400 (GDI metrics).
git-svn-id: http://skia.googlecode.com/svn/trunk@10401 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-28 00:53:43 +00:00
bungeman@google.com
7c86d8eb3a Disable GDI slight hinting.
FontHostTest fails because 'Times New Roman' 'o' and 'g' have
a different number of points in their hinted and un-hinted versions.
Disable slight hinting until this is understood.


git-svn-id: http://skia.googlecode.com/svn/trunk@10400 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-27 21:42:21 +00:00
bungeman@google.com
0abbff9987 Fix metrics on Windows.
With this change, Skia's metrics are much better in general, and
specifically can be made to match the metrics produced by current
Blink code. This allows Blink to use Skia's metrics.

This change will require a number of rebaselines in Skia, since
previous metrics were quite different. This will require about five
rebaslines in Blink, as the new code may cause GDI's matrix to differ
in the low bits.

Review URL: https://codereview.chromium.org/20585004

git-svn-id: http://skia.googlecode.com/svn/trunk@10399 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-27 20:37:56 +00:00
skia.committer@gmail.com
aeefb2afe7 Sanitizing source files in Housekeeper-Nightly
git-svn-id: http://skia.googlecode.com/svn/trunk@10398 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-27 07:01:06 +00:00
commit-bot@chromium.org
149f4f5b40 differentiate mag and min filters
BUG=
R=bsalomon@google.com, robertphillips@google.com

Author: humper@google.com

Review URL: https://chromiumcodereview.appspot.com/20809002

git-svn-id: http://skia.googlecode.com/svn/trunk@10397 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-26 20:40:06 +00:00
senorblanco@chromium.org
0989b21d5a Remove Nexus10 strokes3_gpu expectations. This one seems to change every run (uninit? driver bug?).
TBR=fmalita
BUG=

Review URL: https://codereview.chromium.org/20501004

git-svn-id: http://skia.googlecode.com/svn/trunk@10396 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-26 19:55:28 +00:00
zachr@google.com
785ef5d521 process gm expectation violations
R=epoger@google.com

Review URL: https://codereview.chromium.org/20527002

git-svn-id: http://skia.googlecode.com/svn/trunk@10395 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-26 19:29:39 +00:00
senorblanco@chromium.org
fe07cfcf01 Another try at rebaselining strokes_gpu on Nexus10. If this doesn't work, I'll just add all of the hashes generated so far to the list.
TBR=fmalita
BUG=

Review URL: https://codereview.chromium.org/20774002

git-svn-id: http://skia.googlecode.com/svn/trunk@10394 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-26 17:27:21 +00:00
commit-bot@chromium.org
cffff79a40 get genmipmap function in the struct
BUG=
R=bsalomon@google.com, reed@google.com

Author: humper@google.com

Review URL: https://chromiumcodereview.appspot.com/20436002

git-svn-id: http://skia.googlecode.com/svn/trunk@10393 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-26 16:36:04 +00:00
humper@google.com
0f48ee0a07 add more stats to the bitmap matrix locator
BUG=
R=reed@google.com

Review URL: https://codereview.chromium.org/19091006

git-svn-id: http://skia.googlecode.com/svn/trunk@10392 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-26 15:23:43 +00:00
senorblanco@chromium.org
c074ff5020 New Nexus10 baselines for strokes3_gpu.
TBR=fmalita
BUG=

Review URL: https://codereview.chromium.org/20725002

git-svn-id: http://skia.googlecode.com/svn/trunk@10387 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-26 12:29:37 +00:00
senorblanco@chromium.org
42ecd5f927 New Galaxy Nexus lighting baselines.
TBR=fmalita
BUG=

Review URL: https://codereview.chromium.org/20718002

git-svn-id: http://skia.googlecode.com/svn/trunk@10386 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-26 11:52:19 +00:00
skia.committer@gmail.com
956b310f13 Sanitizing source files in Housekeeper-Nightly
git-svn-id: http://skia.googlecode.com/svn/trunk@10385 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-26 07:00:58 +00:00
senorblanco@chromium.org
a260e2e4e7 New Nexus10 baselines after r10379.
TBR=fmalita
BUG=

Review URL: https://codereview.chromium.org/20648002

git-svn-id: http://skia.googlecode.com/svn/trunk@10384 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-26 03:10:17 +00:00
senorblanco@chromium.org
2dc8bf780e Yet another round of lighting rebaselines: win7.
TBR=fmalita
BUG=

Review URL: https://codereview.chromium.org/20625003

git-svn-id: http://skia.googlecode.com/svn/trunk@10383 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-26 02:46:19 +00:00
senorblanco@chromium.org
01178b4871 Next round of lighting rebaselines after r10379.
TBR=fmalita
BUG=

Review URL: https://codereview.chromium.org/20636003

git-svn-id: http://skia.googlecode.com/svn/trunk@10382 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-26 02:21:12 +00:00
senorblanco@chromium.org
a79d6c5b53 Next round of lighting baselines after r10379.
TBR=fmalita
BUG=

Review URL: https://codereview.chromium.org/20617002

git-svn-id: http://skia.googlecode.com/svn/trunk@10381 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-26 01:14:38 +00:00
senorblanco@chromium.org
6d427f252c First round of new lighting baselines after r10379.
TBR=fmalita
BUG=

Review URL: https://codereview.chromium.org/20600003

git-svn-id: http://skia.googlecode.com/svn/trunk@10380 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-26 00:51:29 +00:00
senorblanco@chromium.org
4e16bb2a32 Implement crop rect for lighting image filters. Changes for the CPU path were fairly straightforward: use the bounds rectangle when traversing the pixels, not the source rectangle.
For the GPU path, this required modifying the signature of SkImageFilter::asNewEffect() to receive the bounds offset, so that the lighting filters could offset the light position by the offset. It also required modifying the base-class implementation of SkImageFilter::filterImageGPU() (which implements single-pass filters) to intersect against the bounds rect, to pass its offset to asNewEffect(), and to modify the caller's offset (so it's drawn in the correct place).

Note: this will require rebaselining the lighting GM. Six new test cases were added, to accommodate a cropped version of each lighting filter.

R=bsalomon@google.com, reed@google.com

Review URL: https://codereview.chromium.org/20426002

git-svn-id: http://skia.googlecode.com/svn/trunk@10379 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-26 00:10:07 +00:00
commit-bot@chromium.org
4d24b747e2 Make SkImage_Gpu share it's pixelref with the surface to prevent premature return to scratch pool.
BUG=crbug.com/263329
TEST=Surface unit test, function Test_crbug263329
R=bsalomon@google.com, reed@google.com

Author: junov@chromium.org

Review URL: https://chromiumcodereview.appspot.com/20354003

git-svn-id: http://skia.googlecode.com/svn/trunk@10378 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-25 23:29:40 +00:00
edisonn@google.com
1acab362fd pdfviewer: limit the characters we support in ToUnicode, to 0xffff
Review URL: https://codereview.chromium.org/20538002

git-svn-id: http://skia.googlecode.com/svn/trunk@10377 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-25 22:03:22 +00:00
edisonn@google.com
ac4bedcb10 pdfviewer: set the default background to transparent (to match render_picture default), and fix a bug a with corrupt diffs
Review URL: https://codereview.chromium.org/20526002

git-svn-id: http://skia.googlecode.com/svn/trunk@10376 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-25 21:40:23 +00:00
robertphillips@google.com
aaa9b29ed8 Added GM to test forthcoming bleed flag
https://codereview.chromium.org/20101004/



git-svn-id: http://skia.googlecode.com/svn/trunk@10375 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-25 21:34:00 +00:00
bsalomon@google.com
68f2a0df14 This reverts commit 4052fd051db67bd1099fde2c4fe400cfbe1f2426.
git-svn-id: http://skia.googlecode.com/svn/trunk@10374 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-25 21:30:52 +00:00
humper@google.com
5dbdfee3bd reversed senses of none and bilerp
git-svn-id: http://skia.googlecode.com/svn/trunk@10373 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-25 20:43:44 +00:00
commit-bot@chromium.org
47fad70da3 R=borenet@google.com, bungeman@google.com, robertphillips@google.com
Author: bsalomon@google.com

Review URL: https://chromiumcodereview.appspot.com/19862002

git-svn-id: http://skia.googlecode.com/svn/trunk@10372 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-25 20:01:20 +00:00
zachr@google.com
48b8891194 add basic HTTP server for viewing skpdiff results
R=epoger@google.com

Review URL: https://codereview.chromium.org/19929007

git-svn-id: http://skia.googlecode.com/svn/trunk@10371 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-25 19:49:17 +00:00
humper@google.com
e2cf805e9a clean up printf usage in gm
BUG=
R=reed@google.com

Review URL: https://codereview.chromium.org/20373002

git-svn-id: http://skia.googlecode.com/svn/trunk@10370 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-25 19:14:37 +00:00
humper@google.com
f9ed6fe6c5 fix android build
git-svn-id: http://skia.googlecode.com/svn/trunk@10369 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-25 19:09:47 +00:00
humper@google.com
b86add1ad3 make the filter mode for GrTextureAccess an enum so we can plumb down
the paint's filter modes to the GPU

BUG=
R=bsalomon@google.com

Review URL: https://codereview.chromium.org/20362002

git-svn-id: http://skia.googlecode.com/svn/trunk@10368 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-25 18:49:07 +00:00
senorblanco@chromium.org
7168ecc363 Transpose the samples in imagefilterscropped, and add a 1x1 blur. The latter
exercises a different path in the GPU backend, and the former is because my
tiny brain gets confused between the results of this test and imagefiltersbase.

R=reed@google.com
BUG=

Review URL: https://codereview.chromium.org/20315002

git-svn-id: http://skia.googlecode.com/svn/trunk@10366 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-25 18:08:13 +00:00